From patchwork Thu Jan 4 14:27:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Malcolm X-Patchwork-Id: 185021 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp5643149dyb; Thu, 4 Jan 2024 06:27:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IGAD474JxzUouZ5bHUIcErbo+HQb8Cc2mBCGsxKrcQJY7KgskFDbFBPtNITlpEVyai0yVfh X-Received: by 2002:a05:622a:1b09:b0:428:3616:d62b with SMTP id bb9-20020a05622a1b0900b004283616d62bmr689925qtb.120.1704378478532; Thu, 04 Jan 2024 06:27:58 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1704378478; cv=pass; d=google.com; s=arc-20160816; b=kLoOGKJ1uU/e/XMvZpVOQqh5Bqp1maa/siRdrYrxrJv+ilXsXJcaaK55ULjbueFgEC NgFjZcWZfvQnCbS4V6TqmxEQFYkCOqGy/iI7oPLdzAR1bXunNiRd8sM0gWyynI1IdDH8 0H1tJVEYiUHu0meiOCykO7bmbmnFeSlDjJgSgQ8XO3FFKCmzKIt49XTakK96snrbVe7F wrRBzbq1l+ioWGDZFNumsyE2nVIk/VtR6Z4Nk1EQrWahL++s6OkYJkCIYrn64PEMTnv3 SCYZl7GArEhjL5ig61H4wYydMAKPXIP2gicNURDGK5ZpLOL9fHBj+8wao7bZlkxzZoyr jK6Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=ZlOqA0ngMl37pSfdeRHdyG3BFwPLG/o/P+Ev38eMHAY=; fh=NXemEfxTRbZtBxUkxR2ehQUaYlcDfMdzPkO8MChVQE4=; b=zhNJ42vHJaYPQBOPGp2xZNYsp0bpr874WSBjBN2xO6idxIcv2gYs8wCkmeKiBlhExA RsRzFZzP1DHLCSEqZG5P+jKss9hRuzT+BvYZranPbIDmoybl9VUHqPnQE9+u6B/IMOUK DggBImB2dQDoWHDnSaCu3MRjTwuxjqv2tuJO87ikLI6yXLFAz88FDfTmuvUSY5IY+StW dDqwE1x+pqKdEHGZ1mLOd8T0aBpwsH+H5TqnxNOWwsYTE0V17BI7dTUDAdDtTWyDQSu+ F+RHMwMK3MwByIaOoHOUg5yoO1YLeOUgl14HfjI+wM66ExvDUtcV6OxMTJkG+DKyc9El S78Q== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BnHPqR1h; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id o13-20020a05622a044d00b004256217f1a9si31423500qtx.347.2024.01.04.06.27.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 06:27:58 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BnHPqR1h; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 394C4385800D for ; Thu, 4 Jan 2024 14:27:58 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id BFCB43858C41 for ; Thu, 4 Jan 2024 14:27:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BFCB43858C41 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BFCB43858C41 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704378428; cv=none; b=GfChgbqpOdBfNCcrYrcqz0HFdsRhm8mr/gmTGdwKPcN1BrlGXDeTLqA8R6xDlfs7rqzrcXG6KxrthxtnYl8grbxj5kd9kfZm2Dg6OLIdfPUDpa98ajVkct43brGg9TCVI0mtr47bp0GzqBk9Fl28CL02UmJHgB7OnfjKqTmFLYY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704378428; c=relaxed/simple; bh=Y8Ng4Mu+/UQ+/2BGof4h5rPKje7ggTSxOzHM/Ute4XI=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=ISeB4HbBt9ExCYaCWiQMmlVh2z64KnQ9xhGDwzfQCGIBBBmwQi8XObx/ryygFJX91rf/+6lKyOaZo4GX15KHSR35yRJgxPJI7SPAYmN4n++aDeAho4xWz7HcvvM8yvcxNQPfMR5Fdafpt4Ym2bZ2dz1Vqd7HVRZmUhSJvflPV9U= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704378426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZlOqA0ngMl37pSfdeRHdyG3BFwPLG/o/P+Ev38eMHAY=; b=BnHPqR1h0NxwCnpHS+dv0BkyHJuNMLRuwh+kVHHMpd7T5h+I+AhMWNPjCIHYqBNQCVLJGu OLFKoAesojxywVhxQ/QkHYlKATeAy2XwlnNzirPaIWhDFxbFVWP8zNxe76HFg/nnHM0Nu3 hShfP9Z5HGM6OkRuMS3xl2fZBrT0wEw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-155-dJ5x9tt-NzWdUdZxX4nDLw-1; Thu, 04 Jan 2024 09:27:04 -0500 X-MC-Unique: dJ5x9tt-NzWdUdZxX4nDLw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8DC3F8828C0 for ; Thu, 4 Jan 2024 14:27:04 +0000 (UTC) Received: from t14s.localdomain.com (unknown [10.22.17.251]) by smtp.corp.redhat.com (Postfix) with ESMTP id 59DA71121313; Thu, 4 Jan 2024 14:27:04 +0000 (UTC) From: David Malcolm To: gcc-patches@gcc.gnu.org Cc: David Malcolm Subject: [pushed] analyzer: handle arrays of unknown size in access diagrams [PR113222] Date: Thu, 4 Jan 2024 09:27:01 -0500 Message-Id: <20240104142701.427320-1-dmalcolm@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787170367321928415 X-GMAIL-MSGID: 1787170367321928415 Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Successful run of analyzer integration tests on x86_64-pc-linux-gnu. Pushed to trunk as r14-6917-gdb5b01d282a0e3. gcc/analyzer/ChangeLog: PR analyzer/113222 * access-diagram.cc (valid_region_spatial_item::add_boundaries): Handle TYPE_DOMAIN being null. (valid_region_spatial_item::add_array_elements_to_table): Likewise. gcc/testsuite/ChangeLog: PR analyzer/113222 * gcc.dg/analyzer/out-of-bounds-diagram-pr113222.c: New test. Signed-off-by: David Malcolm --- gcc/analyzer/access-diagram.cc | 4 +-- .../analyzer/out-of-bounds-diagram-pr113222.c | 26 +++++++++++++++++++ 2 files changed, 28 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/analyzer/out-of-bounds-diagram-pr113222.c diff --git a/gcc/analyzer/access-diagram.cc b/gcc/analyzer/access-diagram.cc index fb8c0282e751..45d218dfb74f 100644 --- a/gcc/analyzer/access-diagram.cc +++ b/gcc/analyzer/access-diagram.cc @@ -1334,7 +1334,7 @@ public: logger->log ("showing first and final element in array type"); region_model_manager *mgr = m_op.m_model.get_manager (); tree domain = TYPE_DOMAIN (base_type); - if (TYPE_MIN_VALUE (domain) && TYPE_MAX_VALUE (domain)) + if (domain && TYPE_MIN_VALUE (domain) && TYPE_MAX_VALUE (domain)) { const svalue *min_idx_sval = mgr->get_or_create_constant_svalue (TYPE_MIN_VALUE (domain)); @@ -1364,7 +1364,7 @@ public: gcc_assert (m_boundaries != nullptr); tree domain = TYPE_DOMAIN (base_type); - if (!(TYPE_MIN_VALUE (domain) && TYPE_MAX_VALUE (domain))) + if (!(domain && TYPE_MIN_VALUE (domain) && TYPE_MAX_VALUE (domain))) return; const int table_y = 0; diff --git a/gcc/testsuite/gcc.dg/analyzer/out-of-bounds-diagram-pr113222.c b/gcc/testsuite/gcc.dg/analyzer/out-of-bounds-diagram-pr113222.c new file mode 100644 index 000000000000..444676669ac3 --- /dev/null +++ b/gcc/testsuite/gcc.dg/analyzer/out-of-bounds-diagram-pr113222.c @@ -0,0 +1,26 @@ +/* Verify that we don't ICE when generating an out-of-bounds diagram + when the size of an array is unknown. */ + +/* { dg-do compile } */ +/* { dg-additional-options "-fdiagnostics-text-art-charset=unicode" } */ + +#include + +struct sched_class +{ + int64_t f; +}; +extern struct sched_class __end_sched_classes[]; + +int +test () +{ + const struct sched_class* class = ((__end_sched_classes - 1)); + return class->f; /* { dg-warning "buffer under-read" } */ +} + +/* We don't care about the content of the diagram, just that we don't + ICE creating it. */ + +/* { dg-allow-blank-lines-in-output 1 } */ +/* { dg-prune-output ".*" } */