From patchwork Wed Jan 3 10:06:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Christian A. Ehrhardt" X-Patchwork-Id: 184690 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp4928158dyb; Wed, 3 Jan 2024 02:07:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IG5f2LpbFgs0Z832IMTXctPv+Pxj5WeXY2/zcD29FQViRte5IO2q7e5oCpPsJQtCqTV6au9 X-Received: by 2002:a17:907:c92:b0:a26:8948:4f50 with SMTP id gi18-20020a1709070c9200b00a2689484f50mr6972455ejc.68.1704276438318; Wed, 03 Jan 2024 02:07:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704276438; cv=none; d=google.com; s=arc-20160816; b=LV11pcIz6ESQsL0W8d8KNmK3PDkaSjt0FgOhB/ijhgcVceWQIBw3h1RtTF8ft241+3 va9TYr7vZiAl2k98KBN0C/VE+8LcEMxoiu4KqIIKDiinWAxTVvP69SjPftfYJHUndHFD Xjn4SRXIY/2qefLiiBM0sPjX5G4dFJ2bnfNe009gbCj6qoG+CI96GWNC/v3z4E4VPou8 USHt2OrIHnq5Yj+iLa66O4VnR8Td1dQ09281buQ8P02DAqfPLJC6laC7snBNLUpsoYgw Mi/xGDXLgBB/XCwOInFYov0EvSgKaBQ5SLXBqJ3oG38RGT4EaflvGzu5v4VVjSJl2rir 8BtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=leztn7Xb4Oi3Blp8e0cSsDkYeELBbBFa4lXVbVM/yU4=; fh=tQmHdDUQIPXkQGN6zxl0sNOuD4uL5AtyiCzLaFenc5Q=; b=qAW1lz3HShZJaKmLIKaCL6Cv33PrAzvAkh86mzWjqFGvrPpN8mLfvVMfF3C79ov1p7 trksBDj/4J2BIo3YIRdS1dKsFZ89RnjOjZzxSHs9bgfJ66/Mmlvft42FOooIVz/uv+60 qhvxCLtwO5IUFQJ1Y6lZ/R+zIG7ldOVck9MoQZDfBgAjZt2won+PSR3DAz7mfVTGsUm3 ESvaLtqItzo4ZPuX9akNOKSSD4WUpVk8QJFqjVMWQ+1JavD51XLwbuQpCz5V95x3NRMG 5JcWk+kj5DxxycBBPnr8yhuvKvIztQvCCLTHpGWUAvO3Y1z5Bd0Y6BwsM5i+5QOSMaTj A3zw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-15372-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-15372-ouuuleilei=gmail.com@vger.kernel.org" Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id vw6-20020a170907058600b00a26f02b8c29si7699566ejb.1043.2024.01.03.02.07.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jan 2024 02:07:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-15372-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-15372-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-15372-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E9FD61F23FF9 for ; Wed, 3 Jan 2024 10:07:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3A63518B04; Wed, 3 Jan 2024 10:06:59 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from cae.in-ulm.de (cae.in-ulm.de [217.10.14.231]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 42D5B18632; Wed, 3 Jan 2024 10:06:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=c--e.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=c--e.de Received: by cae.in-ulm.de (Postfix, from userid 1000) id 10E881408EB; Wed, 3 Jan 2024 11:06:50 +0100 (CET) From: "Christian A. Ehrhardt" To: linux-usb@vger.kernel.org Cc: "Christian A. Ehrhardt" , Heikki Krogerus , Greg Kroah-Hartman , Neil Armstrong , Hans de Goede , Mario Limonciello , Saranya Gopal , linux-kernel@vger.kernel.org Subject: [RFC] Fix stuck UCSI controller on DELL Date: Wed, 3 Jan 2024 11:06:35 +0100 Message-Id: <20240103100635.57099-1-lk@c--e.de> X-Mailer: git-send-email 2.30.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787063370657015980 X-GMAIL-MSGID: 1787063370657015980 I have a DELL Latitude 5431 where typec only works somewhat. After the first plug/unplug event the PPM seems to be stuck and commands end with a timeout (GET_CONNECTOR_STATUS failed (-110)). This patch fixes it for me but according to my reading it is in violation of the UCSI spec. On the other hand searching through the net it appears that many DELL models seem to have timeout problems with UCSI. Do we want some kind of quirk here? There does not seem to be a quirk framework for this part of the code, yet. Or is it ok to just send the additional ACK in all cases and hope that the PPM will do the right thing? regards Christian diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c index 61b64558f96c..65098a454f63 100644 --- a/drivers/usb/typec/ucsi/ucsi.c +++ b/drivers/usb/typec/ucsi/ucsi.c @@ -53,7 +53,10 @@ static int ucsi_acknowledge_connector_change(struct ucsi *ucsi) ctrl = UCSI_ACK_CC_CI; ctrl |= UCSI_ACK_CONNECTOR_CHANGE; - return ucsi->ops->sync_write(ucsi, UCSI_CONTROL, &ctrl, sizeof(ctrl)); + if (ucsi->ops->sync_write(ucsi, UCSI_CONTROL, &ctrl, sizeof(ctrl))) + pr_err("ACK FAILED\n"); + + return ucsi_acknowledge_command(ucsi); } static int ucsi_exec_command(struct ucsi *ucsi, u64 command);