From patchwork Wed Dec 27 16:26:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 183515 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1532720dyb; Wed, 27 Dec 2023 08:28:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IFrb5NukGFese33AspnOt2TgGo6qLcjQlxCJ5tzyE1DPcGL5UmqZpPbR296TQ7nwL/YOz2p X-Received: by 2002:a05:6214:e82:b0:67f:310b:7aa with SMTP id hf2-20020a0562140e8200b0067f310b07aamr14200383qvb.18.1703694509431; Wed, 27 Dec 2023 08:28:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703694509; cv=none; d=google.com; s=arc-20160816; b=r0/Vh7fyHFN401PeTkrEVFIC5IeuvP0zELfLeBBz+hB75jUaKhjq3gdvPVbwmlq6gf Z5/Hx9NEyDmEkZbPhZL0aWwK4yXMzzS1I22bT1ecvP5ArD9TEoRYVPY5Sz3biwifYbyS hT8fNAFNJwaw99Yp6t3cdfbcYAB4H+s4PljknHZwS0fW3uTHHLV16YFFzMg2ey6FljIq N7q/Pgq44BB7uwW5NaaOA9izsTBINmrZm5BdilBOhKqWX3gPf4uZsBKenVAb5NNz7aSP 6lV7SWS8q8wjsn8SrvtXM2fP2SjyM9N016r0GCGMqlbLTjZZLKQGdJwLa6BqcwDMXuWE CmHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=4euGTQWQmuDBbD7Z0U2oMuDE0hHyu3RyhpdH3lolfgo=; fh=Pv8I0nxJOLyHkgyXeQ28bFoz2KGItoI9hXXX1Uk9JJ4=; b=SyR+PsX31TmmnFVnmXcccuFClyNKZFJImDXhmXastuIvLG1j+8YcW4ZJsZ+fCpRUgO JqLWBCJmBxXukfy7hX3JgloXEjDOV4HZpKbv3D04aephOfP4RcTW62MFcs24o74fr8vf +oH0A5GVyzFEZ/l41XaPu9w8doBxHnxr8LCWdwBrYw0kFt7wQSwyfrosPm5jZOHvaaeQ 31165gJb1jQA0STMTy4udFCLK1EgJG3xaII8aGA5En1tGu4wjYlr2Dur4ukaXiXpBf+J WDLOJ+NglyowCj6VO+t6MyTmIIZsypARcMaiQBiM+iCE5X7RcH2ERrdFy+m/zhCNtFdL M0sg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12130-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12130-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id f21-20020a05620a409500b007815e21d56csi2079515qko.340.2023.12.27.08.28.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 08:28:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12130-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12130-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12130-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3D19A1C20E1F for ; Wed, 27 Dec 2023 16:28:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D476E481CC; Wed, 27 Dec 2023 16:26:57 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55CD246437 for ; Wed, 27 Dec 2023 16:26:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIWjz-00059m-UU; Wed, 27 Dec 2023 17:26:43 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rIWjw-001tZK-Lv; Wed, 27 Dec 2023 17:26:41 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rIWjx-001Wmg-2E; Wed, 27 Dec 2023 17:26:41 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Sudeep Holla Cc: kernel@pengutronix.de, Cristian Marussi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/11] firmware: arm_scmi: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 17:26:25 +0100 Message-ID: <86165c8ccd0bb47000a29e711102795b36c8df41.1703693980.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1796; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=JK/CSDYjlDzz8/Ko2zYkIZLw829LGnskJHP4zrb3nSc=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBljFAzHGKIj+U2X2/VquNqcN62INqnmVrFKeBUV waVRlMvMSiJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYxQMwAKCRCPgPtYfRL+ To+6CACSdd6ebXHEHuZH278GDpN/34UYlQyumgf05hEYLn7eStz0mwZTNZNBViswZLobbkbPjvj TUoGFM03/AvIKHgJVHzZmivM8csSsF18pCdURQ/26QNnv4XEItA9q6KOOGze54yeGKt4ir7mRwo H1syPHLrzQLDrf00QPIvhRj3sJoRF6FHV8HfYI7nGpnextDyr6+zTkcfxOC1vUvY+TIUXgHMk3A J41YL+ZRdcpMZEH7qFNq9icFrtCTVzqpNTLBT7x0xMmtWYCvS6o5xqwpQLeDOadis6WNhBrmRIR jH3lsv1OVKlzE+oq89AayWxMuMsgh1FqBuumXnYiubyQyRqf X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786453173866430909 X-GMAIL-MSGID: 1786453173866430909 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/firmware/arm_scmi/driver.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index a9f70e6e58ac..3ea64b22cf0d 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -2834,7 +2834,7 @@ static int scmi_probe(struct platform_device *pdev) return ret; } -static int scmi_remove(struct platform_device *pdev) +static void scmi_remove(struct platform_device *pdev) { int id; struct scmi_info *info = platform_get_drvdata(pdev); @@ -2868,8 +2868,6 @@ static int scmi_remove(struct platform_device *pdev) scmi_cleanup_txrx_channels(info); ida_free(&scmi_id, info->id); - - return 0; } static ssize_t protocol_version_show(struct device *dev, @@ -2947,7 +2945,7 @@ static struct platform_driver scmi_driver = { .dev_groups = versions_groups, }, .probe = scmi_probe, - .remove = scmi_remove, + .remove_new = scmi_remove, }; /** From patchwork Wed Dec 27 16:26:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 183512 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1532113dyb; Wed, 27 Dec 2023 08:27:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IGm9xH1/Ia9Zjs+x/I1tOGyiv08BfcvXtZFgTb/OM6quR7EVIUP60ZeKE79y4SvB8GSEX5a X-Received: by 2002:a17:902:7841:b0:1d4:7f21:d63d with SMTP id e1-20020a170902784100b001d47f21d63dmr1209094pln.46.1703694439056; Wed, 27 Dec 2023 08:27:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703694439; cv=none; d=google.com; s=arc-20160816; b=HrwDg3AG81TkUpe/f9EXWFVqsHXuJjWfR/s2V3OfJ6uD4hJ+9VL4SzPfm8kdGJz9X2 Qbr6qNAHJ9o4aTHKiPTauP7WAEzjNP3u3plOiW/oH4JSMS/kHRQICrDMOIlTUwSZBumN QUFInj+Wrx5oizLo73QCoMJPES5QwwCKDP0eoWiB0wTP6FCMAZAXgXz5Xv3T+uRhspDo D7n2wQspwL5gKJ/dQ1g2xPa+9RKoI9XrZKtcB06AFsLi2RHYWWVUYBxCJHP4y2C0niD4 vMwsVNn5EP326ON+trJp4kHmQxl8vuS1agdNUdqn+7v/zlUzEQhbThZSMlo/4L3HCx1x t5vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=FMqPtaor4fYQlkG4HzccDI4wi1pujykxRUZ0GamEDuc=; fh=Pv8I0nxJOLyHkgyXeQ28bFoz2KGItoI9hXXX1Uk9JJ4=; b=QgRb2tQMDmJiB7GzrdUiEpfUR8J3USoRyWgu/gGRwVp40PXIfw74h2/HD8NylGEzCd baNEqqYdKQEVJ3nMusSU8XklrNZKuVHqHTo4Xad3aq+zmJPeHt8eGxDILH91gKRWS6j7 oxymQ6xtqpiyaRhp/hIWBW7CsMlwurTQ6JoB/UUZgWkus7+epa5FVB4hWNXDcVtIXnTQ WSNrVt8AUAqcsOT7CNrfZUJxR6sJwp0+k2/j72f26vvTvQwMvdK8Hv1x3qDy+x0dsKPI AvCtei4IJkSXinMmcjwJ4Dk+w6IZ16iGVsk3dMS1ITtwyXIReMUXdr6TF2mAIoDnYxCK Rszg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12125-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12125-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id x11-20020a170902fe8b00b001d46a313b41si3491684plm.353.2023.12.27.08.27.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 08:27:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12125-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12125-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12125-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B0F5E2816BE for ; Wed, 27 Dec 2023 16:27:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C8D9F46545; Wed, 27 Dec 2023 16:26:55 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55D024643A for ; Wed, 27 Dec 2023 16:26:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIWjz-00059n-UU; Wed, 27 Dec 2023 17:26:43 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rIWjw-001tZN-S1; Wed, 27 Dec 2023 17:26:41 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rIWjx-001Wml-2q; Wed, 27 Dec 2023 17:26:41 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Sudeep Holla Cc: kernel@pengutronix.de, Cristian Marussi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 02/11] firmware: arm_scpi: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 17:26:26 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1768; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=FF/nyDTSJyTf9/tBea2/MLsCLR8e7FBGnIR1tjwpPwI=; b=owGbwMvMwMXY3/A7olbonx/jabUkhtSeABNWkSWxW+K3Zy7f/dCWS2W3brhfZqL89Gt5ajz3n 5/l2prWyWjMwsDIxSArpshi37gm06pKLrJz7b/LMINYmUCmMHBxCsBEHnGz/48sWTf7KcOmybfe 6BUIBmfaXZRuiGbcW2vINcnP0l/77oLDb7z+TfNinhh9aNmrp32nlbf9CS1b9eLnjSLtPh8jq6K pW+LaUxP5XGsnOU9eumqKqafE/PQnXK7ZmfvmBFapsng1TrmyoCdjDfuziWci8u+uLjzX4PwqsV wnQ85VxDLp5Y76eSvOezcF5ifFVPF1ap7pqJu0+pLRhy0Rx28rK2fJWk6o/v1y1iLuO9XcChqfT px/lipww4XdyNNbwadtHtvdEmmPnVL39vK0WKUlWCVWlK18tq0j+cUcnqCTKY1WtrO+3mFt4yyW iu0PVPBe9DBh39LfF8NqRdtUuDUXTluk2cBntu/aDtlbAA== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786453100284911289 X-GMAIL-MSGID: 1786453100284911289 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/firmware/arm_scpi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c index 3f123f592cb4..94a6b4e667de 100644 --- a/drivers/firmware/arm_scpi.c +++ b/drivers/firmware/arm_scpi.c @@ -863,7 +863,7 @@ static void scpi_free_channels(void *data) mbox_free_channel(info->channels[i].chan); } -static int scpi_remove(struct platform_device *pdev) +static void scpi_remove(struct platform_device *pdev) { int i; struct scpi_drvinfo *info = platform_get_drvdata(pdev); @@ -874,8 +874,6 @@ static int scpi_remove(struct platform_device *pdev) kfree(info->dvfs[i]->opps); kfree(info->dvfs[i]); } - - return 0; } #define MAX_SCPI_XFERS 10 @@ -1048,7 +1046,7 @@ static struct platform_driver scpi_driver = { .dev_groups = versions_groups, }, .probe = scpi_probe, - .remove = scpi_remove, + .remove_new = scpi_remove, }; module_platform_driver(scpi_driver); From patchwork Wed Dec 27 16:26:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 183520 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1533772dyb; Wed, 27 Dec 2023 08:30:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IGv+cq8KHfV2F5k9bLG8o5Amaqzg8OLiTIQ0AwjJz/Gve7O83tMBpeBAIR0VNw27xoE3Ue2 X-Received: by 2002:a05:6a20:2512:b0:18c:23b0:39bd with SMTP id j18-20020a056a20251200b0018c23b039bdmr3505290pzd.16.1703694624347; Wed, 27 Dec 2023 08:30:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703694624; cv=none; d=google.com; s=arc-20160816; b=e8aY5tDSvZNPTWcSlDXhc3nb3GQ4g5OW76t5PvMm7kIEwqWuPIZfNTkA29GW5oemiW ZmNuvDGbngGVD+BIvIBfwQpKXX9UZziuXcBb3Fb3WRPuf2Z3e/6IC04ZSdf0N7NabWKe Cfx8318SuaDm0o3BEvteUoRLjC4kefcQyXNzfKrCmwlnl494BPecUFWzJB7kx6CAu7H0 cutmNFRtwhfRblbhy48InRkuPF7sApmrh+sIn2Y6bYekKpvRngDz+oB3f/7Tggei/uAA Gb/xzHjAUVsx9j8uPLbfnWWkCphYkl4XMJ7pvFmYGD8gk8Kf8sG1MJ19b3SWJuE9JtMr vU1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=oUeI24Mqd2vc/oDUKgmEWh4czCpxFeCIiFghPx4mYaY=; fh=euIUdM3owyLQNPoDw34E+9UPuZn+ZQdE57D5AqAoaws=; b=Cp6GJapkV3C+fgmJDUQhVaem8op3D1pFtPA6BHNvx5tSZQQ3ErdR9Ba3BqnlVvgajN AZEAVyQa6mqwo5Lf6q7xwdoYerFn7BrCDDuGM/A04JogfpX4/NHEjviVOqzIOX5H5jW5 55xnLgDjlwFNtK/VjIR5gf/9GkuymN+ayQyFqzmOgkr3Ylvu8LcuMbh08SNip6cGpLSL k4gkB1eJY9cYEckNJ4CMo1FqyzMyf6jtjGFIb2B/d59Up8qAQme/yVzF7ngKVjsYoDoj XKi+uLp0ygULnS2H4EfGsxks/0dbMQSBMry7b7SZu+KEP/EMWtmH0ZiLqpBQ5urZWjnk jzwQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12132-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12132-ouuuleilei=gmail.com@vger.kernel.org" Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id r11-20020aa7844b000000b006d9b38e6014si5904313pfn.379.2023.12.27.08.30.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 08:30:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12132-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12132-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12132-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id D81E1B216AB for ; Wed, 27 Dec 2023 16:28:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 25D4A487BB; Wed, 27 Dec 2023 16:26:59 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62F954777B for ; Wed, 27 Dec 2023 16:26:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIWjz-00059o-7m; Wed, 27 Dec 2023 17:26:43 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rIWjx-001tZQ-34; Wed, 27 Dec 2023 17:26:42 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rIWjy-001Wmp-0L; Wed, 27 Dec 2023 17:26:42 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Tzung-Bi Shih Cc: kernel@pengutronix.de, Brian Norris , Julius Werner , chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 03/11] firmware: coreboot_table: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 17:26:27 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1801; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=KkJyKFS1tf/Q7uVpfdVoCv0nkB+vzLTFnmTd3unQUCU=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBljFA137qRFmgFH2CW2v85lYu8zAPejn58AHqK2 y66+PpOHTKJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYxQNQAKCRCPgPtYfRL+ TqVtB/48BvW7i2SaSdpDvOEONys5ylT5SBQ0NFtzPMFYUto6wdGN1kkOlGP/CeHhN4+hi0wKzpY aei8fq67PrCMzLM+Z/QsZ95Su0qZnirumRVS5R1ub5V1tt/vzKZMiYDbsz0UAMg6tL4XgGTBhDV urNBX6t1EoZ0Ged/KE/7W1wI2GElYzzIgZ7ZEs6ecrhEH27d0gNxIfePA+hbyIL1P0gY7Xpe0GB GOVrnpTqwE7HXXXOQKWoZUbhrsd24TQYUx1D1aOf/BNFPd1LrPRYIe+NGAby2749jgXqPrx34jN BRHOGnBtxPJntg/feNHo2HmP9cjZInR7u39XBs5Y14wZs0EM X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786453294782026482 X-GMAIL-MSGID: 1786453294782026482 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/firmware/google/coreboot_table.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/google/coreboot_table.c b/drivers/firmware/google/coreboot_table.c index 33ae94745aef..2a4469bf1b81 100644 --- a/drivers/firmware/google/coreboot_table.c +++ b/drivers/firmware/google/coreboot_table.c @@ -176,10 +176,9 @@ static int __cb_dev_unregister(struct device *dev, void *dummy) return 0; } -static int coreboot_table_remove(struct platform_device *pdev) +static void coreboot_table_remove(struct platform_device *pdev) { bus_for_each_dev(&coreboot_bus_type, NULL, NULL, __cb_dev_unregister); - return 0; } #ifdef CONFIG_ACPI @@ -201,7 +200,7 @@ MODULE_DEVICE_TABLE(of, coreboot_of_match); static struct platform_driver coreboot_table_driver = { .probe = coreboot_table_probe, - .remove = coreboot_table_remove, + .remove_new = coreboot_table_remove, .driver = { .name = "coreboot_table", .acpi_match_table = ACPI_PTR(cros_coreboot_acpi_match), From patchwork Wed Dec 27 16:26:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 183522 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1534578dyb; Wed, 27 Dec 2023 08:31:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IHMCxtonb4qC5Fao5mOJ6xCloP+dumIVmilYT9boPQ+nQ7zrKwhoEdakYS8NXUXoowJVfbE X-Received: by 2002:a17:902:6507:b0:1d4:1a0b:565 with SMTP id b7-20020a170902650700b001d41a0b0565mr8398340plk.93.1703694696071; Wed, 27 Dec 2023 08:31:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703694696; cv=none; d=google.com; s=arc-20160816; b=EoDTXyKTvNSNZYU9UB0dsdBINViOeCXYRbc9jisWKIMzOEzUW7Rc88GejOxhKFWKTB ApTeAjaDaIRY5Yj8/Wr3OMBZ3a3yXenum4vsQe+v7wykYMpoyjJrlz2+pYWQFtZEr/fT 6M15Vmby2w9b/jL8ZwyCyUZ5QmayhA9zvbohbTJm3nLOE+Z1rZL2tquiDlI1nTxVoSoq xeaGdW2nBrLQFaoEsiEJncrvtXvdfoyHk5zzYVQPKZP8QYl4rwXEpauPE6hHz/ddV8m4 FVA+knmS46+Zc725iaoTiHzWDDA/AelUsfEx3EIZr+yz4opaSnnIL4JdpngWJCxGl4me 4Yiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=8bUa8rjdzLTZPGqSsj4kHU4f8toeDtRDDiRaEIrchiM=; fh=vd9KFCtNILK6Y7bKkF6HrA1zvmNuSjgkAyrTSrhg27g=; b=wr3br0eBfSNZ3Y45Imi07aAELB4qIHh0LY2Ey8NvKHQF8ljm7BFwHT3eaDCZnTOnt3 6Ow+RQw3+1F+jkkySLA1S9HpscGYV2HKpm937/e+xe3RaSQKI3OSxpy2f9cRNzYVGx3I KWpKkRHCUHjACc7dicIkn8xEf/7/fjb6uION0LZrKWX0xsCXsaXNEc98m/H3O/+zNtod /XpL0f//A3SrJzZZsN3XiUXGvG0rB/EZOQ86VCSy5uWMlEOVghg4WxsL9acwYByeeZvn maPA7U8dNQcz8H9yXvOPcsWgEXIFn7ZoaQhXAc6TVxv9/pW29Z2+C57WSCzv6gQfvSBI t5Pw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12135-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12135-ouuuleilei=gmail.com@vger.kernel.org" Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id q12-20020a170902dacc00b001d42c9339d6si8539105plx.393.2023.12.27.08.31.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 08:31:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12135-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12135-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12135-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 24070B22385 for ; Wed, 27 Dec 2023 16:29:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8246149887; Wed, 27 Dec 2023 16:27:05 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFD4848CDB for ; Wed, 27 Dec 2023 16:27:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIWk9-00059p-P6; Wed, 27 Dec 2023 17:26:53 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rIWjx-001tZT-E1; Wed, 27 Dec 2023 17:26:42 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rIWjy-001Wmt-1O; Wed, 27 Dec 2023 17:26:42 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Shawn Guo , Sascha Hauer , Daniel Baluta , Thierry Reding , Sudeep Holla , Hao Ge , Rob Herring , Christophe JAILLET Cc: kernel@pengutronix.de, Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 04/11] firmware: imx-dsp: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 17:26:28 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1797; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=MlqBx3QsOKLYhj8m2E2EGfokVOl5XV7UkQvCbxh8Dg8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBljFA2JBjZjJ80khzwObhQcArQ5cwJEx64zJY36 CtxgF7WSbyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYxQNgAKCRCPgPtYfRL+ TgByB/4kZis+maU+iwmZbE6Rj8EHJS/0bW1FPBZc3bFsDVcvmuiiduDOw8HVY6Kgtd8olF/jklr 6e9JAlfeFGPqi/HNkDXO/x9MCxCRjZHCuLL6Yo/9b481c7rDhEb4Z+n5je2qNU8zg32CqxA3jD/ PyMHg0Jh8UZuCTwsvgjzWG+Wuxy5trk2jF2zNQVlX1AGixbNOM7nGCCp6al65O2s0YOgY6ohRj2 tJ/IS4IYapHTbktUPR4bQ2a1/w8MhOOdkgrDxdchBkauQgNtbqT9gcb+Xp2Ec8ltF8pM6DnycHt /ySIHanZz7kGgxGI/agQ1ot69EXC5J/A09VnL8E8rtstvwbS X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786453369492772080 X-GMAIL-MSGID: 1786453369492772080 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/firmware/imx/imx-dsp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/imx/imx-dsp.c b/drivers/firmware/imx/imx-dsp.c index a48a58e0c61f..01c8ef14eaec 100644 --- a/drivers/firmware/imx/imx-dsp.c +++ b/drivers/firmware/imx/imx-dsp.c @@ -160,7 +160,7 @@ static int imx_dsp_probe(struct platform_device *pdev) return 0; } -static int imx_dsp_remove(struct platform_device *pdev) +static void imx_dsp_remove(struct platform_device *pdev) { struct imx_dsp_chan *dsp_chan; struct imx_dsp_ipc *dsp_ipc; @@ -173,8 +173,6 @@ static int imx_dsp_remove(struct platform_device *pdev) mbox_free_channel(dsp_chan->ch); kfree(dsp_chan->name); } - - return 0; } static struct platform_driver imx_dsp_driver = { @@ -182,7 +180,7 @@ static struct platform_driver imx_dsp_driver = { .name = "imx-dsp", }, .probe = imx_dsp_probe, - .remove = imx_dsp_remove, + .remove_new = imx_dsp_remove, }; builtin_platform_driver(imx_dsp_driver); From patchwork Wed Dec 27 16:26:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 183516 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1532734dyb; Wed, 27 Dec 2023 08:28:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IHiUDTo3pTwwT4iUPvAbx80V9xEVJeJXpw+/QmWfmzz3ZH9d4LMJ1rh/ZYivfKBhPTtPzXh X-Received: by 2002:ad4:5b8b:0:b0:67f:1965:c40 with SMTP id 11-20020ad45b8b000000b0067f19650c40mr12329605qvp.74.1703694510890; Wed, 27 Dec 2023 08:28:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703694510; cv=none; d=google.com; s=arc-20160816; b=NCshuhPCnFDGhYErXTDThyyD8d+2epNI1jFefJozL8erkICkzLoOYzFFIZh44cCkQy Vwy1eRJ3UOdS650Dv4fmEtjfVqPCkshyNgzd8iK9MLP9qHW87rzXGf3C14sCcZ1Itd/6 iK8kT2NJlKJFVDCySJ4pGTMYPDVvOOv5nLu9tS0nePUEMsaND6voMGUf28OD1FRfdUWz 2WVMWujlj+ZKcOFpeSegD3Xc/dfQdegL9vCg7WCUmkTHzdHOXx/74QLUXkRYen/6/APL 6o6bmHKXgzZBFTkEzsh7xxA2m8oBoEcoNBTfGmxgVqcfjBbdGBHNOulQiBsO5sF+28Oz m4fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=ll6YGpIKic/fJIjuCuZafsLUOG8yDcOukKFLjujQHQs=; fh=GN7NPww7lTt1/NGNHNmRoA6SgXaOW8HjO9zrv8zBbSM=; b=0ZABShzNO3B1JqdSrL2Lydqipl6Q25m9ONVaPPBUs4dS+FD5qevBH1ZEEB+XM3aS0D 5FvC+vxcjy/F814GWB8uNJUKtYxVN6fuymYpC6cxa6j4CTycdPe48LhwC4hzRsvAjjIi 9djcRxrnuLMYEt3jwpFzAAU2UZhiVKRMnEd2PWxBsVT4sJ61Cp+VwuUPx/tNYuWmNx4i yqCEz8Xq6iwrxSWyrecG5GO2U9jG/tPWlXKQdffn81v4fgJxLj5y/R4zhWtVTJRwZndH fUrPVQhgXs9wovs/YMIymIiPE/EGtbP6yxC2nqeZ/S16yGil4/pr3k1/lbrOwFIqxKPY uJwg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12131-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12131-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id s29-20020a0cb31d000000b00680607ae94dsi1210009qve.132.2023.12.27.08.28.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 08:28:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12131-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12131-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12131-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id AC2F81C219C6 for ; Wed, 27 Dec 2023 16:28:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E4985481CF; Wed, 27 Dec 2023 16:26:57 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE9E146424 for ; Wed, 27 Dec 2023 16:26:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIWjz-00059q-UX; Wed, 27 Dec 2023 17:26:43 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rIWjx-001tZW-KD; Wed, 27 Dec 2023 17:26:42 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rIWjy-001Wmx-21; Wed, 27 Dec 2023 17:26:42 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Matthias Brugger , AngeloGioacchino Del Regno , Thierry Reding , Rob Herring , Arnd Bergmann , Sudeep Holla Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH 05/11] firmware: mtk-adsp-ipc: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 17:26:29 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1902; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=a63jCU/xmx3JjQAul7+0HQjMC2XzUPEGHuetp5aEk3E=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBljFA3VZRLFHuI4OPARK9PwC54oddug682gpz+A znDmlUhrkyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYxQNwAKCRCPgPtYfRL+ ThSDCACWPSchgdcXQcSe1ovZmVZAWx9vNPIVAPhqu3ln3Y0yG+zsXGBC0H7gc9JaRmGlwAY+riC eSc7+8e3umCnEsXjDUEu6wJnGrWaJCNz4XQlWNzvPaZFSY+i7Mu4Ez+p6/+vcyu1KcXoXqvMFO5 67QAssIT+LYqZ/834Rieou/m7tWmsf3nBZavxgKHIqdkP+pH9gqxcaNnaFixFR89MkOfLUJ9aZH l9qeyQnZP819ihTK0OlbOu2YRAc0oB14rJ36x3WDkg+YwHzMTsBiMMubWPbCdQzfoeX27D4TvnG VKoMdv3Bb+9ECeJu3WAOA//PoFDN6f9c40u6nLxdDcFKxoD0 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786453175139792215 X-GMAIL-MSGID: 1786453175139792215 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/firmware/mtk-adsp-ipc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/mtk-adsp-ipc.c b/drivers/firmware/mtk-adsp-ipc.c index 85e94ddc7204..a762302978de 100644 --- a/drivers/firmware/mtk-adsp-ipc.c +++ b/drivers/firmware/mtk-adsp-ipc.c @@ -116,7 +116,7 @@ static int mtk_adsp_ipc_probe(struct platform_device *pdev) return 0; } -static int mtk_adsp_ipc_remove(struct platform_device *pdev) +static void mtk_adsp_ipc_remove(struct platform_device *pdev) { struct mtk_adsp_ipc *adsp_ipc = dev_get_drvdata(&pdev->dev); struct mtk_adsp_chan *adsp_chan; @@ -126,8 +126,6 @@ static int mtk_adsp_ipc_remove(struct platform_device *pdev) adsp_chan = &adsp_ipc->chans[i]; mbox_free_channel(adsp_chan->ch); } - - return 0; } static struct platform_driver mtk_adsp_ipc_driver = { @@ -135,7 +133,7 @@ static struct platform_driver mtk_adsp_ipc_driver = { .name = "mtk-adsp-ipc", }, .probe = mtk_adsp_ipc_probe, - .remove = mtk_adsp_ipc_remove, + .remove_new = mtk_adsp_ipc_remove, }; builtin_platform_driver(mtk_adsp_ipc_driver); From patchwork Wed Dec 27 16:26:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 183517 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1532870dyb; Wed, 27 Dec 2023 08:28:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IFc+W7apdRyEIXn1O9Ne/NU7+lAtHz6t4VzO9Pgt4xkuXRRKPfwcj1eiRE+6S3z+aNn/n84 X-Received: by 2002:a17:903:64f:b0:1d3:e8a5:7562 with SMTP id kh15-20020a170903064f00b001d3e8a57562mr9061527plb.96.1703694529666; Wed, 27 Dec 2023 08:28:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703694529; cv=none; d=google.com; s=arc-20160816; b=CwGPJIPWjOSwHRY80kNm2uNJgRFygDx7GaSDtNSq1v6IXbTGUcPbrXRE012L97DHHl Tt+CshwzO7Ww3Stlx+8L2uO3gaXFIXst+8tAXUzeOym37CWTHLGia5q69bA+OO2zrrgd mS4CJXW5f25pLp4AcekesN71ecuEdfBbtDzFH4rvAO4+adhdRaZX89GRJtAhcnhdpQm2 J2Pq0e9G6GIAEOPtP4yk9pdwo7Cwu0HH3XKbV+As5wF+JnOjxqrOAb3f3N4Ryrk30hWE Oy+foEdVU2HIlNnd6s0CiEBoe8k+R566rIQpA5Nhw8e1ad7TRiIcej5K4tpQr1qiBGFV S5eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=iJY904N8dFa8rzKR8rqm677qF50oUnB3c7C5PyshRnU=; fh=WXH/H6gYz9bVDOIibGH+OfHRp+5L9a5qtXixZYpucCQ=; b=fTMAgXuLYxcVO2jUuHYrFXJ7sFpQZHnab0SSfCzmYe3lXDgjg+RXQKdaI3h5n7n/Rn AdZrzl1EqBWzcIILTvfo0xiIP0+QEToIlHQqXDtwYCGU3z+fb1Amc6F1emuu9uQGEy3l 6N+mk/b0MVtxGtutD80X3nmvwKK2LrY6A1Hg0OctdRVU5N+beat5yP17m3uUDc+GCc7C Qz6NFXM+j8fqYrm7yNNAubU25nxvFOT0wr+QoRq9ANFyen+a1gXzIYr2SYTPH/IIVP2V cOSZ4hXI9v7ug9FYo2C2w57m3aq2Vs2O1aDDjHU1wGmj1UXkHyAYZt3ZtEvCtzvLyduK I7Tg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12126-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12126-ouuuleilei=gmail.com@vger.kernel.org" Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id o17-20020a635d51000000b00584ca25959csi11639742pgm.540.2023.12.27.08.28.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 08:28:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12126-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12126-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12126-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 5AD2FB22A1D for ; Wed, 27 Dec 2023 16:27:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A64F947F49; Wed, 27 Dec 2023 16:26:56 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0A654643C for ; Wed, 27 Dec 2023 16:26:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIWk0-00059r-38; Wed, 27 Dec 2023 17:26:44 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rIWjx-001tZZ-Qh; Wed, 27 Dec 2023 17:26:42 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rIWjy-001Wn1-2g; Wed, 27 Dec 2023 17:26:42 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Gabriel Somlo , "Michael S. Tsirkin" Cc: kernel@pengutronix.de, qemu-devel@nongnu.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/11] firmware: qemu_fw_cfg: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 17:26:30 +0100 Message-ID: <8d7d86a24ea36985845c17b6da0933fedbf99ad8.1703693980.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1964; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=Nuh2zfgdzxmPQm9xjM7Qd8aGlwMSzi2SytLozr/ldNI=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBljFA4SiZA8Czr5oUw4pC3X33baRdQ2zK8UNaGd qJkOIfRcM+JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYxQOAAKCRCPgPtYfRL+ TiVtB/9jFGL9M1pmYrAxhcbUa8Fjt8yPqmgn+z7SvuziuDVEWqFHjFWJ8VQZBJ5zynq/yVPl1f6 urdnJg6eOFNj0PYq6BeEZ0EBhieCqObdsqUavigZblPpdxkoUx+3OknYd6j30HbZY3oT2XIJb7g z8LpDGjq3AtUsQvnbSDQnY2Yo/6iw96gEaXu2oAj6UECO8y+KSbYOOhmw320RX5KTlY0lrGlFl1 JHVQBU5OErrYaujF0lFh2gCB3ZMzwHWgidVCDjnKmdMZShf75AeOFCD20INk02WCoNgbKOxzM6S iYLX9UIsbnWxPSzM3Y6UDLK4MeGi4N/dEn96Fg/SHu+Ia7E2 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786453195338788043 X-GMAIL-MSGID: 1786453195338788043 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin --- drivers/firmware/qemu_fw_cfg.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index 1448f61173b3..03da9a4354f8 100644 --- a/drivers/firmware/qemu_fw_cfg.c +++ b/drivers/firmware/qemu_fw_cfg.c @@ -731,7 +731,7 @@ static int fw_cfg_sysfs_probe(struct platform_device *pdev) return err; } -static int fw_cfg_sysfs_remove(struct platform_device *pdev) +static void fw_cfg_sysfs_remove(struct platform_device *pdev) { pr_debug("fw_cfg: unloading.\n"); fw_cfg_sysfs_cache_cleanup(); @@ -739,7 +739,6 @@ static int fw_cfg_sysfs_remove(struct platform_device *pdev) fw_cfg_io_cleanup(); fw_cfg_kset_unregister_recursive(fw_cfg_fname_kset); fw_cfg_kobj_cleanup(fw_cfg_sel_ko); - return 0; } static const struct of_device_id fw_cfg_sysfs_mmio_match[] = { @@ -758,7 +757,7 @@ MODULE_DEVICE_TABLE(acpi, fw_cfg_sysfs_acpi_match); static struct platform_driver fw_cfg_sysfs_driver = { .probe = fw_cfg_sysfs_probe, - .remove = fw_cfg_sysfs_remove, + .remove_new = fw_cfg_sysfs_remove, .driver = { .name = "fw_cfg", .of_match_table = fw_cfg_sysfs_mmio_match, From patchwork Wed Dec 27 16:26:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 183518 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1532967dyb; Wed, 27 Dec 2023 08:29:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IHYVTciX4O5lxybnpPzCL6CaLgwge/dei8tNQzC2jGaBKXcyha/CYFvfGDdElCczx5eddjp X-Received: by 2002:a05:6808:16a4:b0:3bb:8021:7d9b with SMTP id bb36-20020a05680816a400b003bb80217d9bmr9110880oib.91.1703694540849; Wed, 27 Dec 2023 08:29:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703694540; cv=none; d=google.com; s=arc-20160816; b=RetrDpUkRkSMvqAqZRBXzUVMBbwYa6/bAoRyTj1K5a274eieR4AjTWN8FMmOka1TDI pUV2sHndvQp97MyHG5O5HPFYHOENJ+JEfMzSkJB6p07TjDvofKTi5GU4t+623n5xkyPB V2Byj7Yb26wjEiZgneIW/xC8/JL3E2VGGwP6exi8KBWfu4+N1Wb3n+J/eF/La2lk3tQU VW2rvljor84kFAN/bjluqUaOfrJtc/90fhFb35smzHr2ipUFjZ8W1tGxiMwp4lPC8N6E /TKc6no9Fp5Bmq0VUmF0/pU1jVnZCkZ7rsrMLVcblB9A/eEPILDBoaqX0YbRXdDchItd M5lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=QdSW832qXq+pFGBmudFy89fudOYigaDKiGzZCxxrCMY=; fh=mslbplF7pyPB4FwwbMkb69JqaQYQCRyEhCJnroWAO+A=; b=oogekEY2GOS3xCJ0cZhnATUErs6kRGOX8JwglPsLo0/LA66VB39R00NAOSbBKcFOKo XWP2Ca3UqVnasPVA6w6CBxCQIkSOQqNGHdME8f635CgQP+EVwQcZ4KNns/mkleCjzKGT /+rmDmpQe6RKKOSAhyg2nsKKookJIzUaBWKeSIdhg/458BBh9YmcPsCDBWeNyhh6hmv9 2Qk93RbyeBW9oNq4So7LUiDwUea08jDT1Nk4C9TN2nyDkqqF8hHQXK5rxS3LeMnwz6/I MNH0NkExK5nGE0w4niOH0QOTLQ33ZOsStSHRCEWezfZc92IaV8mEgSTHh8KDATgwKWb/ ew7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12133-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12133-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id h1-20020a0cf201000000b0067f6b017e53si14347042qvk.585.2023.12.27.08.29.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 08:29:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12133-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12133-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12133-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9F3EB1C219B5 for ; Wed, 27 Dec 2023 16:29:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 667D748CCB; Wed, 27 Dec 2023 16:26:59 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CF4D47F41 for ; Wed, 27 Dec 2023 16:26:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIWk0-00059y-0b; Wed, 27 Dec 2023 17:26:44 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rIWjy-001tZc-14; Wed, 27 Dec 2023 17:26:43 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rIWjz-001Wn5-08; Wed, 27 Dec 2023 17:26:43 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Florian Fainelli , Kieran Bingham , Arnd Bergmann , Rob Herring Cc: kernel@pengutronix.de, Broadcom internal kernel review list , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 07/11] firmware: raspberrypi: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 17:26:31 +0100 Message-ID: <5df31ef3c069f45634631c9c639bbb60ab1d4798.1703693980.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1900; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=8OnFnV9+Q+XjHGFocc6jyNJphVm9oGZbvop0yAJNf9o=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBljFA5eCGsDsplPuScmklfE3nyikx3e0+FJY3l8 BL3mj5KWsuJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYxQOQAKCRCPgPtYfRL+ TrYJB/wKMxZ0dVeqePWzIe13JUFhLVI4QUjz0EFQb5Rn475cfqK+B7i3dx0wcVewGUkDahlovG2 tdfvhL//8Gt6HvqFq2H+aCEBbKA4BHa48gkArRdq6xQEZDt5z0rQld5osnTbW0IDOdPoYaNuxo5 mkLOex1INSKouwkConwu8R0j9KDoV2neCB/vd0WEhYl0KpkvNgNdCBWBvMxmtoqSGdvAjb9+zb7 qwYQ7p93oWEIF4p9nBNulGEjF14nU7UlVrhmDf7OSOreQ02WFGTaYPacVKdTH9dxk/m5za93xoD 3zuzyc/kgU28KdvmxsL8G2Y1/r2et4CQOAkdyHhWt/k34anG X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786453207270832173 X-GMAIL-MSGID: 1786453207270832173 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Florian Fainelli --- drivers/firmware/raspberrypi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c index 4cd290a60fba..322aada20f74 100644 --- a/drivers/firmware/raspberrypi.c +++ b/drivers/firmware/raspberrypi.c @@ -317,7 +317,7 @@ static void rpi_firmware_shutdown(struct platform_device *pdev) rpi_firmware_property(fw, RPI_FIRMWARE_NOTIFY_REBOOT, NULL, 0); } -static int rpi_firmware_remove(struct platform_device *pdev) +static void rpi_firmware_remove(struct platform_device *pdev) { struct rpi_firmware *fw = platform_get_drvdata(pdev); @@ -327,8 +327,6 @@ static int rpi_firmware_remove(struct platform_device *pdev) rpi_clk = NULL; rpi_firmware_put(fw); - - return 0; } static const struct of_device_id rpi_firmware_of_match[] = { @@ -406,7 +404,7 @@ static struct platform_driver rpi_firmware_driver = { }, .probe = rpi_firmware_probe, .shutdown = rpi_firmware_shutdown, - .remove = rpi_firmware_remove, + .remove_new = rpi_firmware_remove, }; module_platform_driver(rpi_firmware_driver); From patchwork Wed Dec 27 16:26:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 183514 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1532510dyb; Wed, 27 Dec 2023 08:28:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IHpIMzKhMVXsAi3jxvr6aMTtnpxTpmgRnRmlOAloEsAxF73N1tHjnZpEBTcQZbg9AZBptxi X-Received: by 2002:a05:6a20:a121:b0:195:6c34:f9fe with SMTP id q33-20020a056a20a12100b001956c34f9femr2819025pzk.117.1703694484530; Wed, 27 Dec 2023 08:28:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703694484; cv=none; d=google.com; s=arc-20160816; b=VNn7yzp684N5V3p+c5mrhdc5YGXnRhFUaJAkoiGCyaGRLf+tzCErTL4s/1i3C1GN6L fHge8PLASRxZ/bJ2QhtCjI1V4qM9es7uLb/Kgb/SJb4ad6KLoBqQH4482M2BPkay2iLp Ylpy0qa5geO5Z/453SWtmImmyxLtrrilcxHmBAezBfr/83EwvkyC30iAIdR/FPLt3CSu O0VZe3I9ifDnBbT6b4/PkE7dVG+8BQTZ3oUg3QJXJR0aAmHhz3c6+cVgfhmajY2Pzm/c 8IZ/raj+L4BwhUIfVqpFBDTsZ2IA1YGOJSCLjf9Fnoh0JyyOn0ZnHdT430+YAENH04RS 3PTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=k+Qwzae/rL/s4LR3Bkcr4GcMaxFSrO+eysPcueFpZe4=; fh=d5Ex4XQyNQz1zuB8NE+0u1f7IbMJsbB5jtuxZjlQ9M8=; b=q70FRlVDECC2PBEE40ARBylfxBUe+b70lXIuR6uB+xSc2MuYMl7J549Z2r8pAscH36 /2E4uNCVectOXr+yy/0497+a+3ndcceUYqLB5e3qpZD57hirE7mdnFg8jDPdykhBPxj0 SveU9fTrjq9ZxqIk7yi4ELu9f3LzjYi8oQKvF/+jnwNr68ZzpkXc6RYR1GGK6nUC9U1n f1BZtXx2KFuuj9+O/qaxVs3mhRX/yL6bZYuB3eqxtcpt0OUTa1GxegrtdJkcl+H7Jj9j 3ZdWQ0OEee7gfbPi7+mhQ+JGHp9racjVcyvYJmSZJPwqMMDzXVCT6K/7hKox5NPyqN4U 5h8w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12128-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12128-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id i24-20020a63e458000000b005b86142ee56si10989812pgk.277.2023.12.27.08.28.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 08:28:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12128-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12128-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12128-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4FB98282270 for ; Wed, 27 Dec 2023 16:28:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EED1847F68; Wed, 27 Dec 2023 16:26:56 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3FB346430 for ; Wed, 27 Dec 2023 16:26:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIWjz-0005A2-NZ; Wed, 27 Dec 2023 17:26:43 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rIWjy-001tZf-7y; Wed, 27 Dec 2023 17:26:43 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rIWjz-001WnB-0q; Wed, 27 Dec 2023 17:26:43 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Dinh Nguyen Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org Subject: [PATCH 08/11] firmware: stratix10-rsu: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 17:26:32 +0100 Message-ID: <06df45c697a747cb6543800a4613db6e1f5462b4.1703693980.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1672; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=6lAFjA5yiszFloMYI5qzwPntohv2cozrx2dH/FwaD6s=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBljFA6uGEchezFuteKgpv7rVwlJjuBW7qQizAIb F8CKXZq1nSJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYxQOgAKCRCPgPtYfRL+ TkKAB/wNqVOLInJA6P/jvSiLEyPTYDGW0rx8IlWU5cUStwjy0D3Rje8+JpchpcR5tb9pXUv9t1W ac2YENF8QcnS7ANBmdkC29mfmfyXZMrgdeTjG6lJZNR4Sz1QNDOL9s+pQAmZqS4CWWK+SmMNkEZ ojZkPxPMuIf7WJlS9b3IzQEOyGX1/ewLDgJHzEy2vyFsFMwt6bWP3uIjjluRq56SqTzw950nSuK X8uYMtNSdvir5kAH9fMIWCar4LGKQrBAbfl5t1zRKgFAdy21Fo/AGRIoNzj4Z8aCDaWLmxusYrT c/L/B7MzLUqe+JDZeQaRG1inrUTG9OVlRJGb4E+Zk2xq4lSJ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786453147981548245 X-GMAIL-MSGID: 1786453147981548245 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Dinh Nguyen --- drivers/firmware/stratix10-rsu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/stratix10-rsu.c b/drivers/firmware/stratix10-rsu.c index 4f7a7abada48..e20cee9c2d32 100644 --- a/drivers/firmware/stratix10-rsu.c +++ b/drivers/firmware/stratix10-rsu.c @@ -793,17 +793,16 @@ static int stratix10_rsu_probe(struct platform_device *pdev) return ret; } -static int stratix10_rsu_remove(struct platform_device *pdev) +static void stratix10_rsu_remove(struct platform_device *pdev) { struct stratix10_rsu_priv *priv = platform_get_drvdata(pdev); stratix10_svc_free_channel(priv->chan); - return 0; } static struct platform_driver stratix10_rsu_driver = { .probe = stratix10_rsu_probe, - .remove = stratix10_rsu_remove, + .remove_new = stratix10_rsu_remove, .driver = { .name = "stratix10-rsu", .dev_groups = rsu_groups, From patchwork Wed Dec 27 16:26:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 183513 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1532489dyb; Wed, 27 Dec 2023 08:28:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IEwR6tlIiIGv9rs30L2JE/puUs4N3ehDR3LjDG346XojbMwwZ41Va07M+yHz4G/bTAWjSKj X-Received: by 2002:a17:906:844d:b0:a26:8d62:e78d with SMTP id e13-20020a170906844d00b00a268d62e78dmr3910295ejy.74.1703694483389; Wed, 27 Dec 2023 08:28:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703694483; cv=none; d=google.com; s=arc-20160816; b=QpV1epeui79H29BluC8I3ZolCeyQPDElPCH9sPq6vK3vMmOroFkBEeXkSVNRSaZVVt FLVhGmqFzpVY0ClRcaOn+eZWb8T9ZujTtxIh4lSb0sWtl2oGuCozGlpK5EHzErn3+pG4 gXNX/kFdeRITfM+TKiowWLElgzNxIusQZ5Azzyn6TQXbMfzpHh19Pc0/cUPObyBFFhVg vQQ9sv2jwCAq5cagmr8yHypNjIuKao5ImaLK+I3o+iCeST5qO/c+tVdL9G2dKMEP5kD0 j9HDy/yWxxhL9fKyFnyD3bfOHnBGWAha2mvK/lVcIu0ZeLyo3DnzdLwuu09YU04yEf/q KNNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=Ygmq/5CY+0bTBLtR+EVC93CikR8horUUdRtEygfVmiA=; fh=d5Ex4XQyNQz1zuB8NE+0u1f7IbMJsbB5jtuxZjlQ9M8=; b=Cal6WCrGWR5wJ4FIzgzaoetYni0umyHSTDnhM16smxKfofNV7WffxKqHsXFX1B8m8z 226t7CDSx1am0XJjsUDR94XQtM7stDetXRWnE9erFsULceNVpF2NiFrc4oBzD1ZI3jRP iyYr366wUyklOjg408mvi2Plpn1hom013xyMXnieZpyFmnnnZbfMqeBZsqwx+BMjOy4j 6H44IIU8O6FK9iVUmIARipaNeqj6TU9hs9GGo/2gk3cKSYXVJbNAYztyCDBoXhAuRshd JpMqq6Dj7FUKTWh7d4OE+GTNaGVEJSRvqStfdyEyeoVBNYwHSdiQw0VwCfJjbLZ8txZd 048g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12127-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12127-ouuuleilei=gmail.com@vger.kernel.org" Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id e18-20020a1709062c1200b00a235070f26bsi5949045ejh.584.2023.12.27.08.28.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 08:28:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12127-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12127-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12127-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 06E101F22EF4 for ; Wed, 27 Dec 2023 16:28:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EA15B47F63; Wed, 27 Dec 2023 16:26:56 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3F5746420 for ; Wed, 27 Dec 2023 16:26:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIWjz-0005A4-Te; Wed, 27 Dec 2023 17:26:43 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rIWjy-001tZj-E6; Wed, 27 Dec 2023 17:26:43 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rIWjz-001WnF-1S; Wed, 27 Dec 2023 17:26:43 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Dinh Nguyen Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org Subject: [PATCH 09/11] firmware: stratix10-svc: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 17:26:33 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1913; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=+Yp1dgFMlCSzMuNAOCbuCl8YKa3LjfoSgbk3TSiz68M=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBljFA7vfChqYEofqwrz3YeDW1AnHg6WinguwSG1 /9J4dCFhhKJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYxQOwAKCRCPgPtYfRL+ TuSRB/wO29Z+uGNK7yIFswymPxzBzPy/Z4n037X2YkjRXFiG9xxJbNe1VpNhCwd2OWIyxBs1+5M buXcL8F4FtbajrNFtUm42/UR/aUCI0d8gT2ISJVpzU39YarYpsYq3yXQMuR1Yqt4AUrBGsHq/BV aOhAV1+zQg4csv1YyVhO0ZmN1kWjShQd3uwz7cHmB2NPN4KD3X7OvhxMKx36Pgc3lC8kTN+bxJj Ex9RnteN/1b2ZAoA7D/sj9snV5GibE0Tw17FlC+BOKis6osHRUb+n7de+uqRnYGHVIvfyFCx3NX sOJ2To+9pfzDC3922sjuqSaf6t24I2I+DE8y0NLfubtAFO2A X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786453146631829763 X-GMAIL-MSGID: 1786453146631829763 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Dinh Nguyen --- drivers/firmware/stratix10-svc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c index c693da60e9a9..528f37417aea 100644 --- a/drivers/firmware/stratix10-svc.c +++ b/drivers/firmware/stratix10-svc.c @@ -1251,7 +1251,7 @@ static int stratix10_svc_drv_probe(struct platform_device *pdev) return ret; } -static int stratix10_svc_drv_remove(struct platform_device *pdev) +static void stratix10_svc_drv_remove(struct platform_device *pdev) { struct stratix10_svc *svc = dev_get_drvdata(&pdev->dev); struct stratix10_svc_controller *ctrl = platform_get_drvdata(pdev); @@ -1267,13 +1267,11 @@ static int stratix10_svc_drv_remove(struct platform_device *pdev) if (ctrl->genpool) gen_pool_destroy(ctrl->genpool); list_del(&ctrl->node); - - return 0; } static struct platform_driver stratix10_svc_driver = { .probe = stratix10_svc_drv_probe, - .remove = stratix10_svc_drv_remove, + .remove_new = stratix10_svc_drv_remove, .driver = { .name = "stratix10-svc", .of_match_table = stratix10_svc_drv_match, From patchwork Wed Dec 27 16:26:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 183519 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1533239dyb; Wed, 27 Dec 2023 08:29:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IFINwJcZ/u1wX6dzjDqOHPch8/qJKuySZMJH2xtfP1kqBo0/wmsm/Cs9ZocyT4qzS7z0h55 X-Received: by 2002:a92:ca48:0:b0:35f:e901:6b34 with SMTP id q8-20020a92ca48000000b0035fe9016b34mr8616732ilo.1.1703694573000; Wed, 27 Dec 2023 08:29:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703694572; cv=none; d=google.com; s=arc-20160816; b=WSNTjKpImlDINapSlL2U38du4cId5HXF+T+Pu+KBXRSthseaPXlFTBJ+ZMwl/w+NtH EfpnPewOzs9BWs8/3cCryj2nnPDEIJMuncL0MUwPu562PCknbP/i2+4Cc4vnJuTN5bKt YO8V9cqzYrThZ4gMv4isVePJF0nxl0aesK61v83O4+KyZaBVZvE7/18QBAc3217xRvBB 5xC+vGJSe7ztiRDBGYAl3FRjh7G77LvnZjBqpIyl1K4+tb/T5aPGFyl3ZywA25oG1nWd 3rZPBsjGiK27KMds+eiVfCjn6kONdhGGs4mH6wNM39UtXh6+FodFKbkTywXFVgZUHxi0 1rNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=8L82mSR/m095Rp6KLpHwGGiAm9jy2ENiQ0/5F86mn3M=; fh=v6LWeRX+a3Q/A5n0DQPddKvFOuqhfqdl0fb7XwX4tXg=; b=lXiUf0tBT5jpFRZiVbBQz4Y56kqk1nQLlE4QQ4nO8pob8lPhVemWr9F543RS4Gqf37 /VsZGpfaPLygSOhpjivVjBnk89ZT+INOnwtlIJg29Vl+2soZf825Y+CWEjCoOL12qqad wqfLCUE04cx37f5fMzyn6OK/C5ocsNtzHJJ37ZjvTd+/waTFkuhYpbh0Z1zimz8jH836 HGB5f6O9Uko7udwqWjbzEGYdLTSBCYnTM9SXwTw0043+/4R5r7yiBgqgyOcSuc4CrXcX WYErFxPfdEUvHIv9hZeWUOMulWlpVDpmcGf8vg6CSF9kExQEVz+ho4x7lcTbOBeYwoXy xt7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12129-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12129-ouuuleilei=gmail.com@vger.kernel.org" Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id bj19-20020a056a02019300b005cdba90861asi11741551pgb.159.2023.12.27.08.29.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 08:29:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12129-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12129-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12129-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id C25AFB2285F for ; Wed, 27 Dec 2023 16:28:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 83830481B3; Wed, 27 Dec 2023 16:26:57 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3FD246433 for ; Wed, 27 Dec 2023 16:26:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIWk0-0005AX-5U; Wed, 27 Dec 2023 17:26:44 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rIWjy-001tZm-LQ; Wed, 27 Dec 2023 17:26:43 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rIWjz-001WnJ-29; Wed, 27 Dec 2023 17:26:43 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: =?utf-8?q?Marek_Beh=C3=BAn?= Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org Subject: [PATCH 10/11] firmware: turris-mox-rwtm: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 17:26:34 +0100 Message-ID: <9074d1ad2e889425991fecad664781ae27b2418a.1703693980.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2006; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=WEZQXXd5yEntU2Gt+f7/Gkh5GXx5rKG3A+0Dnwst0LE=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBljFA9qk9zaKQX3LUk4LnI0Bgdn7cRxwonrs9nY Bwreka7G7iJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYxQPQAKCRCPgPtYfRL+ TiYRCAChHvmLzvr6zrz7IyRAAX7lZidZ3ESfne2udN3JSW4mLtYdzEQ6YvEhfoWtA0osET5XGJj adYGI/CTr/MJDQAxQ+jkv+BRbPpEN6CCoJ2LuD9B7gL+tfWOhswYSx0i6QQVveeVOOKgo+kwksw gF6e5l1WR/p8iVc7sdSx7mYe6rrTRsgCr7Sk3cU4UrksOY7GZJNhq+4Scz7YrvYwl8qABoCE0c/ 9DeaGLUueTXrSSFQsWrC4IPZVIU+qxZSdAMGf8AAKvrrxwmj3IUwMPMrsXmQhWxkbM55Nz7TNYW dOKmgJ4t1gq2q54Qnwb9gC2QLgcW76fwYFL9l6/JeEvYOJof X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786453240590644524 X-GMAIL-MSGID: 1786453240590644524 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Marek Behún --- drivers/firmware/turris-mox-rwtm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/turris-mox-rwtm.c b/drivers/firmware/turris-mox-rwtm.c index 2de0fb139ce1..31d962cdd6eb 100644 --- a/drivers/firmware/turris-mox-rwtm.c +++ b/drivers/firmware/turris-mox-rwtm.c @@ -554,7 +554,7 @@ static int turris_mox_rwtm_probe(struct platform_device *pdev) return ret; } -static int turris_mox_rwtm_remove(struct platform_device *pdev) +static void turris_mox_rwtm_remove(struct platform_device *pdev) { struct mox_rwtm *rwtm = platform_get_drvdata(pdev); @@ -562,8 +562,6 @@ static int turris_mox_rwtm_remove(struct platform_device *pdev) sysfs_remove_files(rwtm_to_kobj(rwtm), mox_rwtm_attrs); kobject_put(rwtm_to_kobj(rwtm)); mbox_free_channel(rwtm->mbox); - - return 0; } static const struct of_device_id turris_mox_rwtm_match[] = { @@ -576,7 +574,7 @@ MODULE_DEVICE_TABLE(of, turris_mox_rwtm_match); static struct platform_driver turris_mox_rwtm_driver = { .probe = turris_mox_rwtm_probe, - .remove = turris_mox_rwtm_remove, + .remove_new = turris_mox_rwtm_remove, .driver = { .name = DRIVER_NAME, .of_match_table = turris_mox_rwtm_match, From patchwork Wed Dec 27 16:26:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 183521 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp1534127dyb; Wed, 27 Dec 2023 08:30:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IG818CXc1cCJ74ySMBsXcxyHOILrrz8+E0KyI4GZj9/KBApSfst1QTITiHzAYedwiLpYsGO X-Received: by 2002:a05:6e02:3881:b0:360:219b:c3d2 with SMTP id cn1-20020a056e02388100b00360219bc3d2mr739466ilb.58.1703694655965; Wed, 27 Dec 2023 08:30:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703694655; cv=none; d=google.com; s=arc-20160816; b=jZqqx58b6Y0biQMraxMuB5wmd2BJ39v2NQBIpddlta99ziaGdQYYvpBc0Rs5noPpv7 XERzk3JUcDNEz17D8VqDDlU2+1f0q229CKFGcA4UR/a7XOvhZz/la8MUTUNkd10OlK6s WE1c9RqFRpVuiRvL3DPV0ngcXQjK5ebMAIhArXMf/7HWVc2/FmnvYg1IMAcWfRJG4B2k 6efOxsJW+m0c0Ha0cZTaH9k+d7C6k8JqMoRIzga0ZHOQ4/q0LrIgKE5hx7DXM7Y5M+4k QVVObwqvbwc0txNmYFc8wjr3wv+6FqSe0ePGwrAtcX4T5Op6vCi9girjs7tyTms3ofzj yD+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=I3+UhTyqkFrp94UV7Wlt0QGm87TUvH/sDj07oUQ9dX8=; fh=76Xiati3aEKZCKUz+/8/vT46Dr+i8/HkFKL17oemDII=; b=uNPixd4lWx6WCheACA590tJXVWrt0LiN/ruc3e+674dUMPtfnjOaTtPcf8U7hxj3Rd x1gSqLwKAFpfpIsqGPJFms4WcO2QPQY8ZeEm0Egc/by91hgZqULEl9i6HD1feBaofh8X dKvsrUoL9vmA30nK0FRG9IfhirWtMvie5+31qKOe88llvwqGsA+DdNKig0HfzWRZLXKV vch6LTzXH+MgazjCL/E8f15GjYPybBzjwYsF0vTIeNS2F8ZhE3456jvnv2YXUxBT3fj3 L9F94bECWz9rjAMH/5CZA0ZyLrJypPWyX0rRj9ZOkaGhMDvCpuDqyHFXU/JbQojTnrw6 JNwQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12134-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12134-ouuuleilei=gmail.com@vger.kernel.org" Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id n21-20020a634d55000000b005cd84b844e5si8542978pgl.595.2023.12.27.08.30.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Dec 2023 08:30:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-12134-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-12134-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-12134-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id B8D73B227A6 for ; Wed, 27 Dec 2023 16:29:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A07F0495DF; Wed, 27 Dec 2023 16:27:04 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5AB448CD9 for ; Wed, 27 Dec 2023 16:27:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rIWk0-0005Bf-PT; Wed, 27 Dec 2023 17:26:44 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rIWjy-001tZq-Se; Wed, 27 Dec 2023 17:26:43 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rIWjz-001WnN-2r; Wed, 27 Dec 2023 17:26:43 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Michal Simek , Greg Kroah-Hartman , Jay Buddhabhatti , Sai Krishna Potthuri , Linus Walleij , Nava kishore Manne , Rajan Vaja , Rob Herring , Dhaval Shah , Marek Vasut Cc: kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 11/11] firmware: zynqmp: Convert to platform remove callback returning void Date: Wed, 27 Dec 2023 17:26:35 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1949; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=5lA5AskgyOWj5RlJyQL/1YZMBAmaOueb91fZw7g7wBk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBljFA+SOL/OLAdfMhQjjJrd6i8QwhOba6xFIvvF 9XxF7gr7VqJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZYxQPgAKCRCPgPtYfRL+ Tr/0B/43t00D3aB2EI/DNiEEuY+18Axew5V9CICgtxrn/vfQ8Yk5ViKo9PuE1Ee5VBjRwbh0bpP JYG7GNO2F7JcSXMEOEgxIs17hku48vv+Qabv4ho0F1TtgwWiOWxaX2n6yTt8FkbKXykKoV8nEW6 vSR53TvZNvtyIpP59/0KAIs7//PMmtpBfP37i+0JUmDvIH1ypp0rlDDZH+tP9Zjg5kwnv0QCtH/ YoBdzx7xDa5QfcjvFmYVuedqXmDX8n1ratrsNABJKYmaVbMnFIO9qWZiZVc7Xollxdmk9JFHXzi M1F+jOJ8BFTCXyiVfelpt9t0eIk7Gcb4yU+IDf4MHG7rR3+N X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786453327329130634 X-GMAIL-MSGID: 1786453327329130634 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Michal Simek --- drivers/firmware/xilinx/zynqmp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c index a55dfd9bae6b..73cae6ef83ec 100644 --- a/drivers/firmware/xilinx/zynqmp.c +++ b/drivers/firmware/xilinx/zynqmp.c @@ -1929,7 +1929,7 @@ static int zynqmp_firmware_probe(struct platform_device *pdev) return of_platform_populate(dev->of_node, NULL, NULL, dev); } -static int zynqmp_firmware_remove(struct platform_device *pdev) +static void zynqmp_firmware_remove(struct platform_device *pdev) { struct pm_api_feature_data *feature_data; struct hlist_node *tmp; @@ -1944,8 +1944,6 @@ static int zynqmp_firmware_remove(struct platform_device *pdev) } platform_device_unregister(em_dev); - - return 0; } static const struct of_device_id zynqmp_firmware_of_match[] = { @@ -1962,6 +1960,6 @@ static struct platform_driver zynqmp_firmware_driver = { .dev_groups = zynqmp_firmware_groups, }, .probe = zynqmp_firmware_probe, - .remove = zynqmp_firmware_remove, + .remove_new = zynqmp_firmware_remove, }; module_platform_driver(zynqmp_firmware_driver);