From patchwork Tue Dec 26 09:38:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Elfring X-Patchwork-Id: 183289 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp767767dyb; Tue, 26 Dec 2023 01:39:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IGsFsSUzHCS0oRsmNCFulrlAlVhzP+MaugIa4KBq4B2V7ZgGjx6aAxwCiYrjW3Wh5OW+Sy8 X-Received: by 2002:a05:6a20:3713:b0:18b:d3db:7048 with SMTP id t19-20020a056a20371300b0018bd3db7048mr6820661pze.23.1703583547896; Tue, 26 Dec 2023 01:39:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703583547; cv=none; d=google.com; s=arc-20160816; b=IWZUUwUspl1p314oeYFE502qZPLVbAIRzhx/4KJsRTvpuChp6xNuq5lHEL0aikC3pz 3By9Qs0BABdzEu+MSFqGPK2tMAt6qzKx9PBnMFFP/7bCzhZ1UQTTIFgn1cY5KxpumWbm vK81WrZ8jQxt1vtdwcI3V1WK0UhhPZJSv1bL/aZ7Si5SK5rJ7dB/PvsTtxoYn974eHtL ypJ2z9H8c9cVP10zuFbZ8HyprRFwWypUCOCdn/UBOzUgIXkCU0bbytXBzsTKFmaOftnU uII+HbFYKWx1xbj33mSJiY8sOPD3yEAuigC3PxBshbdHsj/2o1G4Q1/wUFFqnG2QtXMm Q1xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:references :cc:to:from:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=UdSpUrVCia57gGLp3j38cgsVMvnNbpTLnwQcX9gie8o=; fh=60vkliJMaNMQ9vWVETCOLiNxdcVoGFT7eofn8OFibpU=; b=J21hKIuuCqKEQYh9jBJFTVIExEMmDR7+xbNgUv4+ghUL88HQ838sKG8IDHTlHuk9ap ZutcRQND/mdvEAFbufwhXYVxRjhPBUEPtHYpCy5Vk/sy9YFX2Oe65v6KSgkU9V+VDOKc kvpLjtr4q3RLao37LdTMJcoeQfE/KhoKuJhAOhU43lMqHYBcObPxCr7UBQyM7S1WULuL bNQI2BmYkMCccHHI7ufzhdPUir4IIvckXsSfIt9rC8D5rXVvnlTPOipFInR3qwSCXhFv SDCRQY6+GchNfQRvihs7bz+udAVmFnhfmg0aaVGwyVllsrpSJYWwN8UBCtInYBs1MfyI 6Xhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=Wy+H4r4G; spf=pass (google.com: domain of linux-kernel+bounces-11446-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11446-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id x4-20020a17090aca0400b0028bf1c4a1e5si8735976pjt.113.2023.12.26.01.39.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 01:39:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-11446-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=Wy+H4r4G; spf=pass (google.com: domain of linux-kernel+bounces-11446-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11446-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id AA1E1282F5F for ; Tue, 26 Dec 2023 09:39:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 179C54D58F; Tue, 26 Dec 2023 09:38:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="Wy+H4r4G" X-Original-To: linux-kernel@vger.kernel.org Received: from mout.web.de (mout.web.de [212.227.17.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 871A44D10D; Tue, 26 Dec 2023 09:38:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1703583504; x=1704188304; i=markus.elfring@web.de; bh=qqBCvkgxbSr3g6FTVllb7hWAQXmgVICHt5PVFl7CIWM=; h=X-UI-Sender-Class:Date:Subject:From:To:Cc:References: In-Reply-To; b=Wy+H4r4Gnaa7y8tBPP7pvGH9Vec+3s9dvNs1B7LVWc/iT6edD5t8cI3E4DBpOLTV qhyV+uMBT/XL3i89SdIhhxywBBUObocgZ32fJHx9VfYhBhdp5yNS5dwXdSMFAju51 FcIFnh4TBrEVloMrstRrQ2/XCqA8qfcN212+mEoUdDxvp1CsyWlkJ24VJns08R+lh eLZLEVJCnAStJAZ4UJ1byJUSaAEswW143Fk+ACvx1j0ZuXz/UZXhG/NhPlsm8VO9n bfT17tpHgSLnT96f0myHggbY8uY9a4EIfb+Y5BpxzEdSRzLJJDGr4QcXvzoZCoP/G BoYy0kHI3wnHNkMbuA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.85.95]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MC0LH-1rQ3aP0NaP-00CKaS; Tue, 26 Dec 2023 10:38:24 +0100 Message-ID: <9b1e7330-f4f6-47f8-a568-eaea1624bb6f@web.de> Date: Tue, 26 Dec 2023 10:38:22 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 1/3] drm: property: One function call less in drm_property_create() after error detection Content-Language: en-GB From: Markus Elfring To: dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: LKML , cocci@inria.fr References: In-Reply-To: X-Provags-ID: V03:K1:iDixZmNvylQDuMt0skzUFKjo8Mh89iiU1EhN0o+/2elM/jOlggR 6muOk7JjgmGLlXj3ITzr5rhHM9PHeCLjkWxFXiVhflFrt6iRboOIWS7Dl5KJDHi1vkOUj71 pvU/i0C+PKKkNZ+eU5BzCX/eLI33iBrs+IvDwscaU8Vvv/c0iWdWouXu1c0vmuzAwXne416 rBGEr9tTaR33LkfrfkioA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:d/X1dljrE+A=;DqE9o4o4RjEHkhdE3U4ZQnuaFTY X7BtY+Blaevtp8Ogi98aTZqmzApKK5NoowuUnky/rLGUjzcuMNPkp3opQGYwAZCAaW+sUVGew x3QvEl96i7st7xV4gRQ7zLiGuqjBArZOkF7UBpLEnnPbPCH7Nea3zu9TstckRmC00FKy+G4W2 ENEbw+k1nTIADPLkzT3JBEDXFE5Va4fMIAAvo8KWdMhZAHbQ1C+S9rXgfVFpB45bj7ZlEiKJV S4TgV/IOkq0grOPVdAJvFmBPENGwPltYqeh70ZIa3A2Y2GGaQvglcni30hejMmGsJBezMEDqX crP+A5P18C9tiXaEHBUkwOhhp06LRvodzsoSVgt50mJm4xIrQM/3xochjkNmcITtL3P7pDB5O UUuIz6X43Trn1F6NVDAgNNlOSkN+69CkQeVwoZpc6Hq3DZihvs5EMifC4iIvvDFZYDl4hOxVG inDeWb1NdllB5EVpTDf5SUmsxPQrCPdb/LmVjSItrUDx7yp+F9hgxWP95aM7FCUZBc/56VAAc O2YQ3P3Ia+EDZJXJSw8EdqW9s0UMfP29uEjUvTjnB4UaPJhFn44xT5/BjkqM9zMc+o+9hMcGv KniLAhWq8b+ElonJTBF9sdYf0iD7xSLj7QYBgML8UqoBjulyCGylO7hkSQNFI7aJPIDU69p43 805KlV3/znVyiISBn9VkzwvaRpmCJhTVBeCOAkaIXdjz6kdSk5ApPWguqT3vFdIW4AhFAAvOy 3CCVqHLBjR4ChxO09YO13+z0JKyXk4QlEvry+VpBGoSqMnTCGG2GrjfI7ZGYrdrAIlvCMGTyK RWdH0HK1XOe5WjBF+7Hmgg2UpTWMMyZzdRTgDXvpCeEpUAezdkXKUL85RxmpXgVc9Gx9+eVug jym4+HsekxTWq/nCXtVazhUnSqOXK2Q0lvGjIS/YgjpnwPodLBrITXzXpeOxjY0FLJZ1JRJpz eaNQEQ== X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786336822210316629 X-GMAIL-MSGID: 1786336822210316629 From: Markus Elfring Date: Tue, 26 Dec 2023 08:44:37 +0100 The kfree() function was called in one case by the drm_property_create() function during error handling even if the passed data structure member contained a null pointer. This issue was detected by using the Coccinelle software. Thus use another label. Signed-off-by: Markus Elfring --- drivers/gpu/drm/drm_property.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.43.0 diff --git a/drivers/gpu/drm/drm_property.c b/drivers/gpu/drm/drm_property.c index 596272149a35..3440f4560e6e 100644 --- a/drivers/gpu/drm/drm_property.c +++ b/drivers/gpu/drm/drm_property.c @@ -117,7 +117,7 @@ struct drm_property *drm_property_create(struct drm_device *dev, property->values = kcalloc(num_values, sizeof(uint64_t), GFP_KERNEL); if (!property->values) - goto fail; + goto free_property; } ret = drm_mode_object_add(dev, &property->base, DRM_MODE_OBJECT_PROPERTY); @@ -135,6 +135,7 @@ struct drm_property *drm_property_create(struct drm_device *dev, return property; fail: kfree(property->values); +free_property: kfree(property); return NULL; } From patchwork Tue Dec 26 09:40:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Markus Elfring X-Patchwork-Id: 183290 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:6f82:b0:100:9c79:88ff with SMTP id tb2csp768497dyb; Tue, 26 Dec 2023 01:41:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IF+sODVo4ANc/4KtQ3FQ5f/fR92wxQWeIoRUbDdbcfodQsLFQfwsa1HAEBhlwVyyh6tX1l0 X-Received: by 2002:a17:907:e92:b0:a23:6dfa:f7ae with SMTP id ho18-20020a1709070e9200b00a236dfaf7aemr3020841ejc.104.1703583684229; Tue, 26 Dec 2023 01:41:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703583684; cv=none; d=google.com; s=arc-20160816; b=mqxfYl/2Wi4IX9BHwBJYAytdq9LTl014HQdDU79DdO6RiWGL5ZJK6xbHAzDy1cml3v mfPH2SjZTzqVn7JL8oVfuwcOXkXhLiFgNZ/ysLxDPY3R4gwb1Xpjg4Xw2GdgviQ2vy36 kCbCi3ltRjxLqIpAb4JmpJyBiFAzfRcC/rw6yENEsx5+Hdno++OP0PMiJv+dk6fgat7/ CDK5CT8IiiTVGY91ggkS35m5AL0//H4/oaFG69Nklh+r33Tug8FY7Qjn3jlaCW/9FPRJ ycc0ixSP3WHFc660BhZawbrnniJScOzZ2kVLrXWkRpS8rObQxGivaEU21wre5tPq/KS8 hRmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:references :cc:to:from:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=0zpnNoqBFFVZXrwInXUdrs1EZ3Ebgxx58d+sjPem2ZQ=; fh=60vkliJMaNMQ9vWVETCOLiNxdcVoGFT7eofn8OFibpU=; b=JzwslX95kcMQ+RsYoSyGyuyF0e3KXJEWbhU7+24QnMom3ANp9ow1PmYTCbpnT4HR/f EkSTNW7d7suWhSoGBQEX/R8EaEF9Gv2KabIOJ/6DN6ywaq7ougRo5sdZc8rLXdyVKBG7 aJO8LpF1PoIgtjURPL9Ade/UJA1OCSHI4e+rKXkGzQNu/fR1kN/RwsdLJUO0HHfMIVE5 BoiyYQ1OEqZrPuYeuMQd2btxqOxC0F3bC6MKgBcgJJZEcx9iILehcbelQeOq4X3AGjD4 4jB9ONhq89I4zwMrl3Rz5BK+iGVPZKtvtbxaZYtleBccNpchHczQLvTQmN5GB2+kbcfv 4XDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=TQpM5jWj; spf=pass (google.com: domain of linux-kernel+bounces-11447-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11447-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id l2-20020a170907914200b00a26866833f7si4995292ejs.127.2023.12.26.01.41.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 01:41:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-11447-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b=TQpM5jWj; spf=pass (google.com: domain of linux-kernel+bounces-11447-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-11447-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D37951F21A76 for ; Tue, 26 Dec 2023 09:41:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C9AF04D58A; Tue, 26 Dec 2023 09:41:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="TQpM5jWj" X-Original-To: linux-kernel@vger.kernel.org Received: from mout.web.de (mout.web.de [212.227.17.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 683DB4D109; Tue, 26 Dec 2023 09:41:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1703583650; x=1704188450; i=markus.elfring@web.de; bh=QEIlNohXQKR5iUvYT2jHXT8Fr7MmOczXQbaPuHwZhWk=; h=X-UI-Sender-Class:Date:Subject:From:To:Cc:References: In-Reply-To; b=TQpM5jWjeEjOy3EjSwtf1SAHvSY3/EKkaMgeqyAojcHix+Ol95Df2AZHbxQ67cUY WEwVgigF7WIPC0+asLsREnOO3Yp9O8mo7fbqhW0GHNIw/gXSVHZOXlsuVQqlTw9m4 rIQU21eOoGO7JotN4tDcRbL5rol/Q+q74MjIAyl+OQ2sDH/LEH+HQ0tE7aDyhBu4d /7F3JsUBS+cN1gx7bkUxzWLpjk5I3ffK2UQTnnGyXtWxkrGZc/kJamCwra3L3JtDd 4IqvIRPs4mcehGPxF5OB/YFc+rPE0EtcYcua+Z14c4k7H54nu5H3SNxM3AlhUnKMS xUXXL6/2u3/nv38PLQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.85.95]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MIc7b-1rWeFb0x1B-00EoEL; Tue, 26 Dec 2023 10:40:50 +0100 Message-ID: <7c6a919c-3757-42af-aee4-3d48721d1959@web.de> Date: Tue, 26 Dec 2023 10:40:48 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 2/3] drm: property: Delete an unnecessary initialisation in drm_property_create() Content-Language: en-GB From: Markus Elfring To: dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: LKML , cocci@inria.fr References: In-Reply-To: X-Provags-ID: V03:K1:gHRM60fhbiROJai12btJyLRtTcOd7dO9E0nCoV0k4kI2NBX1xi4 7CaFJ2MqRCS3EHB4tsGMJ4lf3o0qYjBCYPC9yunWXgxZ3RwuHNqmmHStQSXiziC5JQgrldI ntssKn3BLAuw3gvZFt3VmkSKemER4GRqnCxY9LZAJ8nLgChA9FZg7Mxxa09u5/yszpHqJzr JakSRCxwcYASditzdkqtA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:BkjCJZF6hJY=;YAGeEr5yQNWL/I6B32iev/AXTMY K70iLvRHsrFwc94MoYkBd111HXgaWlwQbe7Maud0HScN0G8gRhYzuflF7rGfJIrgdBmn+XpC1 wJzhCuMZ+euroE94eqQYF5mNcoYbto0ATvt/fMg1HOl8UtIlCT1AOMEzeoCjHaO83ecnJjmuT yIkILu/nISKhnNR6TxzHeuqDTABwBTx+HbHRj4JWHcH59hcX18wGmdXTnemGEodCsb2aMedxC O2RfXbT7FJX87MtivoxNg6oaLr+O/8FvB2XNcIOfDgwU+l3ocDrZe3miH8+ManMOddsyI05eF SEwMpOt1r1kW9sVuMDaTGHx8b0RMPbeQzteLJTodTRFfuCgYzr8EDdLpCPvhNP5Gu5pKJCEVW Z98J6+x4WuHGpTDxLQWrtSFuP63X+MtpxCB9hV0WrkaWaVHedwANc0uYB2GC0QWWE1IySScxY +qFFiGbn4RW+Eq0hAMXqSr6OJbOwoAZu67AZfHyY2B/mf4EBvdG07ff/JS1s9vpKK2WkuiZo5 veF9ZS29RoNMXGLyYsC6LfSUgiu8NT7O8UYmGMnnV8K2ADAJ9C3WL+ysCw2HIA2Z0ZuAKuB3X fCdlZxJfw5o25nqFaIbhAIMpzDHjR8HcYc3wyxHi7J7YKufp5kP6Fx/lWdH6LDeLPfz6B3I5s OAh41DanF4BYpDVmoyUlSf/+aRjY/2sJVJ6V7uoBTq5rHje7fJlJSK9bFL/F0+hM2uIN68Fun uxjotAQKT0AmdZ1NxzmF83m5H1pjTNEtogtCicNDMbOkXOPX+qBQanFcK+STR82JfOnz1dcaF 0sddd3RBHB9yHk6NvGIbajTzmJGG+0cQ0DvnTgUMkUTQRbDfxflmH3zt8pg9TEspM+ugVv78b 9MTXXdiyv6iCyJiIAAuZtPqUREbZolL5vQlITAgXv82mHaVAnodo4ZCBNEKJcA/zpDuwne3Bg qiEUGA== X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1786336965646975046 X-GMAIL-MSGID: 1786336965646975046 From: Markus Elfring Date: Tue, 26 Dec 2023 08:46:12 +0100 The variable “property” will eventually be set to an appropriate pointer a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/gpu/drm/drm_property.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.43.0 diff --git a/drivers/gpu/drm/drm_property.c b/drivers/gpu/drm/drm_property.c index 3440f4560e6e..ea365f00e890 100644 --- a/drivers/gpu/drm/drm_property.c +++ b/drivers/gpu/drm/drm_property.c @@ -98,7 +98,7 @@ struct drm_property *drm_property_create(struct drm_device *dev, u32 flags, const char *name, int num_values) { - struct drm_property *property = NULL; + struct drm_property *property; int ret; if (WARN_ON(!drm_property_flags_valid(flags)))