From patchwork Thu Dec 21 03:20:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 181976 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2483:b0:fb:cd0c:d3e with SMTP id q3csp159497dyi; Wed, 20 Dec 2023 19:21:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IH/zYsIg5YZDK1dvaQzvXQZEMD5uvZIWK0Ds8PbbiFaZblrkjVtkXopZgY1oHAV3rN9o2Q2 X-Received: by 2002:a05:622a:3d1:b0:425:4043:96f5 with SMTP id k17-20020a05622a03d100b00425404396f5mr28673053qtx.130.1703128876276; Wed, 20 Dec 2023 19:21:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703128876; cv=none; d=google.com; s=arc-20160816; b=j0GpCLYBGOBVZ3bmJkLdztHB/tCW9ZqW9o5bLtyeHovpLY5kP8IVTIlbx9hVVvkHcx 4IlCDQ9lMzODLMhg6B+iAqGYHfdtCZxtg6djGjdHLfsC+HAwx6wZ5DCnFr0xJTuAZZj8 EsaY2iPAqrJ4OyZdbDQVBYfGSdwG7ZIO4kkhUYNdre69flMzEU0h/fW74yhmHnZ3AOoo 8Ievp+nYHESiiXuQ0kOm14hkYSabXlFoKhs9wu/mkg33pntRk1PQ5z7TG2+HNX9B4iuw 95YZMuDGqla/qH+IKTYhqupnZnHMTdOW2UtIXNQfyY24v79uQJw8vy3C+sZpYwqFJD02 ncGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=LiVIYSg1d+XSLTzB95bVtSsjQGpYCfcFa5dzKpB5Uj4=; fh=7C+om+4LAiL/I2vqDXHjdCv+GFuVkhSSXjorl92wcJo=; b=jIqBN0kAHumN/kmZpfQ2g+kOI8DeKe6WkCO07ojdVMAk+SgdCjBY951NfA6NERifGW ZyhmzCA08/YkeO+xjOA/Gg67xoCSuG2igfHKXVrkXwiMXzLTXzh5deGFo2OtD8yfwgOu 9czuSYpbYRRIGpovadYNz+5JQ8JgRQ09qDJh92q7pRnIwtjpJMnBJQDm7V+1Y33xjxmF kHpKhkDFpWzulFYjknqHM0Okq8CHNBzGKP+nKk1tIen/Qlia4GxllcW6CfIGtw3+hjLZ NCdjI3N6ThxLWoy4ZCjZ21AylD6Wps8NCV0Uhfh1rfuygnhOli78V1dqz6DLV2XqR6Tb Bk3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=I1yRndFg; spf=pass (google.com: domain of linux-kernel+bounces-7803-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7803-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id s39-20020a05622a1aa700b00423a48ec8adsi1164402qtc.103.2023.12.20.19.21.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 19:21:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-7803-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=I1yRndFg; spf=pass (google.com: domain of linux-kernel+bounces-7803-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7803-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 1665D1C22342 for ; Thu, 21 Dec 2023 03:21:16 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F04001641B; Thu, 21 Dec 2023 03:20:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="I1yRndFg" X-Original-To: linux-kernel@vger.kernel.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 981BEFBFC for ; Thu, 21 Dec 2023 03:20:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=LiVIYSg1d+XSLTzB95bVtSsjQGpYCfcFa5dzKpB5Uj4=; b=I1yRndFgN+zphoGvwhDB3IzZdG sembhqwncaGz6jTurdlnfvi9oMSUqRQ/0zY9uoQkzolU2ayQehNbqUf4tfwe85RTzI4tF+YhzNa3s QQSfCTGmTMMXyq++4G8pKEqbbBI0uI2MmDyIvvddCri2l9W99TnDUlchOB5bK02GgPZ5P0AGl8DrF 2mf3rZJHisB/ZvV6yo5w4K+e4QtQoaD3rIa+D2AZJq3HS3dtNCs00Nmckkdf7qO0bvEzeB4Lxmmsx COkFYe10Un078vXDxMhzZ2eNrG8ZH4ZoxlvS3imTNTtOzCv2G6vJrpcl3ffoK2ZLJxC9e2Bp9CY5Q yVoBIE/w==; Received: from [50.53.46.231] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1rG9bq-001aN9-0v; Thu, 21 Dec 2023 03:20:30 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, Jonathan Corbet , dri-devel@lists.freedesktop.org Subject: [PATCH 1/4] drm/i915/gem: reconcile Excess struct member kernel-doc warnings Date: Wed, 20 Dec 2023 19:20:26 -0800 Message-ID: <20231221032029.30942-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785860064736519267 X-GMAIL-MSGID: 1785860064736519267 Document nested struct members with full names as described in Documentation/doc-guide/kernel-doc.rst. i915_gem_context_types.h:420: warning: Excess struct member 'lock' description in 'i915_gem_context' Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org Cc: Jonathan Corbet Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/i915/gem/i915_gem_context_types.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -- a/drivers/gpu/drm/i915/gem/i915_gem_context_types.h b/drivers/gpu/drm/i915/gem/i915_gem_context_types.h --- a/drivers/gpu/drm/i915/gem/i915_gem_context_types.h +++ b/drivers/gpu/drm/i915/gem/i915_gem_context_types.h @@ -412,9 +412,9 @@ struct i915_gem_context { /** @stale: tracks stale engines to be destroyed */ struct { - /** @lock: guards engines */ + /** @stale.lock: guards engines */ spinlock_t lock; - /** @engines: list of stale engines */ + /** @stale.engines: list of stale engines */ struct list_head engines; } stale; }; From patchwork Thu Dec 21 03:20:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 181978 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2483:b0:fb:cd0c:d3e with SMTP id q3csp159568dyi; Wed, 20 Dec 2023 19:21:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IGtCGK85LmTNSa+nmuAT7yXfqPri23vWeG8Qdey/MCk0LIwYas7puEChb7K20x1IctedGcv X-Received: by 2002:a05:6358:60c1:b0:172:e499:f7f6 with SMTP id i1-20020a05635860c100b00172e499f7f6mr624827rwi.38.1703128890781; Wed, 20 Dec 2023 19:21:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703128890; cv=none; d=google.com; s=arc-20160816; b=LfIc0e/PwaUP1E+O0bunRJ+xlPSSKo4R7grgvkl1bNj/fEyZMIMNjFsIKPaKUqZplB VxismtzE+VlyLZ+os3NqGB8xqIpy6N8M99Tt9j22k1th/CAoeg+QiOcVnw/zRAY3aMgr 8VJktRDZabzVF2COpq2bUWwVCq+iNm3Nr0OPfu4QXlSTCqOv1iWYZdk/xnajiJclcTbz lS/yPdUrT6smEz3DEyjdsDQ7Y6bOpsJQo0edIkORF3iXrmVpqHlPzAUiyBHdUuhKhNJt A5YnO4pOwGbx5ct77Wb8qk7QZTWpO/oN92qvsxPJ0DnRBMA+EvMAh7eW0PNAEDTjsqMS G9+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=uNEK+CxMh6qX0p3sx3zeo+Q9G/JTi2IoSv3JGx0Jd68=; fh=7C+om+4LAiL/I2vqDXHjdCv+GFuVkhSSXjorl92wcJo=; b=v9TC8Qd7pKPdavUAA4qOleQnYqgoUaSfi2tFYAE2yrVV3zZRcHyZWTXIsGCAMlpGs8 5KsVU5RH+XMUw9MBv932mXPNWsG+6jzLK2LFRXaHc4tNs7PCsW7zD7p/v9xSekyyHzTQ OcSqc8aQc1u8tIDTagfkd40HrmkcS7QOFTWP3Oxe2OdHWATw55DnJjChnlglS2zKsYuR NCyemMOtKUTx8XyokDxE1W0ZRQUF7ErutCy6EQfRMKjOpWek6b6BznHGtmjhPMZ1yGc7 bqYf/Pv8AHgEuBtZKrzvqhn/TToiMfZsEe5/HHm6pXMfqvqYicKX01XTLCZKEmCE0rSD BZmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=cxGL4qZq; spf=pass (google.com: domain of linux-kernel+bounces-7805-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7805-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id t4-20020a170902e84400b001d40669349bsi309072plg.158.2023.12.20.19.21.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 19:21:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-7805-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=cxGL4qZq; spf=pass (google.com: domain of linux-kernel+bounces-7805-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7805-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 84E10283C26 for ; Thu, 21 Dec 2023 03:21:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D83BB171D3; Thu, 21 Dec 2023 03:20:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="cxGL4qZq" X-Original-To: linux-kernel@vger.kernel.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9750CF9FC for ; Thu, 21 Dec 2023 03:20:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=uNEK+CxMh6qX0p3sx3zeo+Q9G/JTi2IoSv3JGx0Jd68=; b=cxGL4qZqLeAlP/OS3/K0PMWu8U ihlfoW83p4bpMZXxN9rTJNV6u9n/gqDJJIqYwZ0xhE57Ie5LoIeWIaOG34Fj+j6cuUSFpe9TWPhRP RCZAWKt4YI4okiwzLMAN5JNQb6e8vPtipWUnHALzp0xovTPQECwfp2nONK/nluzCb5p61RMCJyO/E cT3f4v9wgUVswQYksIdB+nfyTOrx8jWzoA6b5ji52Yq73+ViKIGbAhgVAIarA/vRj0z3B1aj0vT7E 3FIkVqJYx7C9lRL5FrtFrrqtLN1shofpe0mZRv3DDsECYvO/vQ0dtaWHRPcvVdma+YWG7rn2H6v/7 OQ8whw0A==; Received: from [50.53.46.231] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1rG9bq-001aN9-1s; Thu, 21 Dec 2023 03:20:30 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, Jonathan Corbet , dri-devel@lists.freedesktop.org Subject: [PATCH 2/4] drm/i915/gt: reconcile Excess struct member kernel-doc warnings Date: Wed, 20 Dec 2023 19:20:27 -0800 Message-ID: <20231221032029.30942-2-rdunlap@infradead.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231221032029.30942-1-rdunlap@infradead.org> References: <20231221032029.30942-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785860079821021579 X-GMAIL-MSGID: 1785860079821021579 Document nested struct members with full names as described in Documentation/doc-guide/kernel-doc.rst. intel_gsc.h:34: warning: Excess struct member 'gem_obj' description in 'intel_gsc' Also add missing field member descriptions. Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org Cc: Jonathan Corbet Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/i915/gt/intel_gsc.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff -- a/drivers/gpu/drm/i915/gt/intel_gsc.h b/drivers/gpu/drm/i915/gt/intel_gsc.h --- a/drivers/gpu/drm/i915/gt/intel_gsc.h +++ b/drivers/gpu/drm/i915/gt/intel_gsc.h @@ -21,8 +21,11 @@ struct mei_aux_device; /** * struct intel_gsc - graphics security controller * - * @gem_obj: scratch memory GSC operations - * @intf : gsc interface + * @intf : gsc interface + * @intf.adev : MEI aux. device for this @intf + * @intf.gem_obj : scratch memory GSC operations + * @intf.irq : IRQ for this device (%-1 for no IRQ) + * @intf.id : this interface's id number/index */ struct intel_gsc { struct intel_gsc_intf { From patchwork Thu Dec 21 03:20:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 181979 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2483:b0:fb:cd0c:d3e with SMTP id q3csp159578dyi; Wed, 20 Dec 2023 19:21:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IFe53t6PQSb7NyAKX4VoTIar4CZMnoKImDbozNcx0P8Sp8K6QlNcsQmamWN3wsFtSGpJLpc X-Received: by 2002:a05:6214:5015:b0:67a:9562:4732 with SMTP id jo21-20020a056214501500b0067a95624732mr29346269qvb.35.1703128893947; Wed, 20 Dec 2023 19:21:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703128893; cv=none; d=google.com; s=arc-20160816; b=ITB+Rcb4SM5gccx/SsLNmAk/a95e/CC//FFu0qQ9LjKajwSZBOWqgxBVaS0XNk204v czxT4kFfv0OtYbXuXoqKrGCfXV7nluuEH7DlVuWTRVJw6ATwu2uaW6i3F9eteUAeuu8K oJSQx52YBtdJysZjlQlB1UkDsAn8CyQ1WGPsUVjByrRj8qL/iD483sRf203B/y21kcHA ZjGP5No2AAD9RVrIfLkIifFU6CDzdbTYaACEPGLVyUJ2aqwuRrftK4t27dPO4RuGfyIs TPhPRpuab8kGQTS23FESsEmTCFkftGR14zlrRApfGmmNsL3D63mZic2qw6EaCTSaLwyO XxTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=RRu6+xmCSluKAIuYpQggnzlBDSLzeyinfR70sEAOAFs=; fh=7C+om+4LAiL/I2vqDXHjdCv+GFuVkhSSXjorl92wcJo=; b=P4kE1as8dqPj4mRO7SZVDC3STzbxcrmjsAk0gmeSjSxZrm/f94X2gP7iC0G/cQz0XJ 2cPARLaHBfU7qnE8wObo2gH5+YCQq/i2IbHhLUCZLJXXH3fdi4N2K5FPQR4NljW7Lfe7 ijjhe9Ia9zAgXNF7uXWfzRN1a5aIuOrmdRLtOz+q66KmlEytYHyluUj001TwTjkvqZo4 a0bnmDpKEXTikjUKA7RYK9UNSq8XbiCfWHXM/hTRrrwzaYHx2nC1ylX9vldPezUFJomr aa3kkfHTrpVw55IYUMALsu+NGZ7NZAXYoGG3i4V4t0fWmP9G8GBn1z3mWtrnZcA/ngjW ngPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=M238aZsB; spf=pass (google.com: domain of linux-kernel+bounces-7806-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7806-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id o12-20020a0ccb0c000000b0067f032d7c53si1251785qvk.112.2023.12.20.19.21.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 19:21:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-7806-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=M238aZsB; spf=pass (google.com: domain of linux-kernel+bounces-7806-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7806-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id ADC901C21F28 for ; Thu, 21 Dec 2023 03:21:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 25CEE1772D; Thu, 21 Dec 2023 03:20:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="M238aZsB" X-Original-To: linux-kernel@vger.kernel.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97577FBF8 for ; Thu, 21 Dec 2023 03:20:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=RRu6+xmCSluKAIuYpQggnzlBDSLzeyinfR70sEAOAFs=; b=M238aZsBeczSAA+r0BwF6dBou2 1/1gAmvoVtzrNGh4hmqa3d7Uux7KI37SmUPnym5Smj28QBORz3HAIPL1s5xk5403BBglxGBgasftb 6sLq+4YjCha9hWvKjFsdM8mXJUUU2OJ0LYr8xtGbzSA7gvkXC2RBtgFEGkIHWBQoZ3Fo6JlexK7IY PjNVCIjkdbLuT0k523nxAguH4UMQ2snIYV3WtmE5/KxetSzl86zur21l8RR2Bnx3vvPtUrde2B+nR IJFCAFAkgS0RiG2kx9pRaDRDTWzj48bG5GJn24JHGt4O38ArMl3eUeqbVdHY+LZ0ZiDvb+ttaCuTr VeQTECVg==; Received: from [50.53.46.231] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1rG9bq-001aN9-2s; Thu, 21 Dec 2023 03:20:30 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, Jonathan Corbet , dri-devel@lists.freedesktop.org Subject: [PATCH 3/4] drm/i915/guc: reconcile Excess struct member kernel-doc warnings Date: Wed, 20 Dec 2023 19:20:28 -0800 Message-ID: <20231221032029.30942-3-rdunlap@infradead.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231221032029.30942-1-rdunlap@infradead.org> References: <20231221032029.30942-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785860082913364962 X-GMAIL-MSGID: 1785860082913364962 Document nested struct members with full names as described in Documentation/doc-guide/kernel-doc.rst. intel_guc.h:305: warning: Excess struct member 'lock' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'guc_ids' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'num_guc_ids' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'guc_ids_bitmap' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'guc_id_list' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'guc_ids_in_use' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'destroyed_contexts' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'destroyed_worker' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'reset_fail_worker' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'reset_fail_mask' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'sched_disable_delay_ms' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'sched_disable_gucid_threshold' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'lock' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'gt_stamp' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'ping_delay' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'work' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'shift' description in 'intel_guc' intel_guc.h:305: warning: Excess struct member 'last_stat_jiffies' description in 'intel_guc' 18 warnings as Errors Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org Cc: Jonathan Corbet Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/i915/gt/uc/intel_guc.h | 75 ++++++++++++----------- 1 file changed, 42 insertions(+), 33 deletions(-) diff -- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h b/drivers/gpu/drm/i915/gt/uc/intel_guc.h --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h @@ -105,61 +105,67 @@ struct intel_guc { */ struct { /** - * @lock: protects everything in submission_state, - * ce->guc_id.id, and ce->guc_id.ref when transitioning in and - * out of zero + * @submission_state.lock: protects everything in + * submission_state, ce->guc_id.id, and ce->guc_id.ref + * when transitioning in and out of zero */ spinlock_t lock; /** - * @guc_ids: used to allocate new guc_ids, single-lrc + * @submission_state.guc_ids: used to allocate new + * guc_ids, single-lrc */ struct ida guc_ids; /** - * @num_guc_ids: Number of guc_ids, selftest feature to be able - * to reduce this number while testing. + * @submission_state.num_guc_ids: Number of guc_ids, selftest + * feature to be able to reduce this number while testing. */ int num_guc_ids; /** - * @guc_ids_bitmap: used to allocate new guc_ids, multi-lrc + * @submission_state.guc_ids_bitmap: used to allocate + * new guc_ids, multi-lrc */ unsigned long *guc_ids_bitmap; /** - * @guc_id_list: list of intel_context with valid guc_ids but no - * refs + * @submission_state.guc_id_list: list of intel_context + * with valid guc_ids but no refs */ struct list_head guc_id_list; /** - * @guc_ids_in_use: Number single-lrc guc_ids in use + * @submission_state.guc_ids_in_use: Number single-lrc + * guc_ids in use */ unsigned int guc_ids_in_use; /** - * @destroyed_contexts: list of contexts waiting to be destroyed - * (deregistered with the GuC) + * @submission_state.destroyed_contexts: list of contexts + * waiting to be destroyed (deregistered with the GuC) */ struct list_head destroyed_contexts; /** - * @destroyed_worker: worker to deregister contexts, need as we - * need to take a GT PM reference and can't from destroy - * function as it might be in an atomic context (no sleeping) + * @submission_state.destroyed_worker: worker to deregister + * contexts, need as we need to take a GT PM reference and + * can't from destroy function as it might be in an atomic + * context (no sleeping) */ struct work_struct destroyed_worker; /** - * @reset_fail_worker: worker to trigger a GT reset after an - * engine reset fails + * @submission_state.reset_fail_worker: worker to trigger + * a GT reset after an engine reset fails */ struct work_struct reset_fail_worker; /** - * @reset_fail_mask: mask of engines that failed to reset + * @submission_state.reset_fail_mask: mask of engines that + * failed to reset */ intel_engine_mask_t reset_fail_mask; /** - * @sched_disable_delay_ms: schedule disable delay, in ms, for - * contexts + * @submission_state.sched_disable_delay_ms: schedule + * disable delay, in ms, for contexts */ unsigned int sched_disable_delay_ms; /** - * @sched_disable_gucid_threshold: threshold of min remaining available - * guc_ids before we start bypassing the schedule disable delay + * @submission_state.sched_disable_gucid_threshold: + * threshold of min remaining available guc_ids before + * we start bypassing the schedule disable delay */ unsigned int sched_disable_gucid_threshold; } submission_state; @@ -243,37 +249,40 @@ struct intel_guc { */ struct { /** - * @lock: Lock protecting the below fields and the engine stats. + * @timestamp.lock: Lock protecting the below fields and + * the engine stats. */ spinlock_t lock; /** - * @gt_stamp: 64 bit extended value of the GT timestamp. + * @timestamp.gt_stamp: 64-bit extended value of the GT + * timestamp. */ u64 gt_stamp; /** - * @ping_delay: Period for polling the GT timestamp for - * overflow. + * @timestamp.ping_delay: Period for polling the GT + * timestamp for overflow. */ unsigned long ping_delay; /** - * @work: Periodic work to adjust GT timestamp, engine and - * context usage for overflows. + * @timestamp.work: Periodic work to adjust GT timestamp, + * engine and context usage for overflows. */ struct delayed_work work; /** - * @shift: Right shift value for the gpm timestamp + * @timestamp.shift: Right shift value for the gpm timestamp */ u32 shift; /** - * @last_stat_jiffies: jiffies at last actual stats collection time - * We use this timestamp to ensure we don't oversample the - * stats because runtime power management events can trigger - * stats collection at much higher rates than required. + * @timestamp.last_stat_jiffies: jiffies at last actual + * stats collection time. We use this timestamp to ensure + * we don't oversample the stats because runtime power + * management events can trigger stats collection at much + * higher rates than required. */ unsigned long last_stat_jiffies; } timestamp; From patchwork Thu Dec 21 03:20:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 181977 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2483:b0:fb:cd0c:d3e with SMTP id q3csp159503dyi; Wed, 20 Dec 2023 19:21:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IFUsJilwCe0XgR19LRTrw/J6ZZiMSjVOeoDDRtvy0MwXvTNmwE9EKBQYAxCbsUGFUzJAhNP X-Received: by 2002:a17:906:5c1:b0:a26:89fc:1910 with SMTP id t1-20020a17090605c100b00a2689fc1910mr1344152ejt.134.1703128876888; Wed, 20 Dec 2023 19:21:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703128876; cv=none; d=google.com; s=arc-20160816; b=inVhxMfRzSjgqi97xct6ikYKU2CeJGfKL0HYyOi+xnjSA7SwJ/Y2sQPv+EEjQ1Fc8z oDFkc0uv1nI/TvXh03NRac7qJ9ZBqyO47HtKFSSSk3B3kr8Xj9B06mStdNhtf7UpJ88K JBT3OS9QmT0OAvTNd9Kp5toiq7bcXUGr99AVoKRcY8vcRVw0sm35+9Cz+D0AgQyv70O1 LuASoGmZh/X7TZ3SrDb/uKmoOtk4ghEezAHNLHertvuT7oNUaCD5sadFmDAd/otX7fgy 6HAnNCxp1LFznw7BoBUOFEBgHFEg8/T+mnXNbfa/JQaC90T+Eoj5BzrEoBqAqAuCg0F/ ZqQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Om7KGzS/g2Y7wQ9rvSrrGdz3FHj7wYsDCL1dsHV/Wu0=; fh=7C+om+4LAiL/I2vqDXHjdCv+GFuVkhSSXjorl92wcJo=; b=KNy0/iB85xXqhcGDbW0518intxgdfUoJRh5pZAtUsIjWYUFVuC7F6zFdKbEXdabKHQ ohqKQxv5x2/NFIhg4ZGzBbFKb/1r61timujZ7msyy9yK0Mf4SSu56CrtSOnYqfC2FG4U 4ah4CHQK6eeupFK8kIb4HcBYjnASPUwoYV0TVXY4R+Cd/9UE0m3TLJTqQr1kp41o7ZDU 275IpN87ANfXV3b+OKd/c7hw9CBRAaZuMNSUklH2SfRakPkCIvsOmWDoRPaboHKI57bM kc74LP9Pc7SBkhzR6s2XIf7+xLZHhFVtnuUtCCdeyb1FC3i31lARIMY4zOf95EoPivde OAUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=d5zq35gg; spf=pass (google.com: domain of linux-kernel+bounces-7804-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7804-ouuuleilei=gmail.com@vger.kernel.org" Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id lv23-20020a170906bc9700b00a1db955c811si450953ejb.318.2023.12.20.19.21.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 19:21:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-7804-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=d5zq35gg; spf=pass (google.com: domain of linux-kernel+bounces-7804-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-7804-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 81E571F229C8 for ; Thu, 21 Dec 2023 03:21:16 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EFF5416413; Thu, 21 Dec 2023 03:20:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="d5zq35gg" X-Original-To: linux-kernel@vger.kernel.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9754EFBEA for ; Thu, 21 Dec 2023 03:20:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=Om7KGzS/g2Y7wQ9rvSrrGdz3FHj7wYsDCL1dsHV/Wu0=; b=d5zq35ggn427N91YatbcRRHKN0 btcolbNdCwea4DDkcdb1wfpYKzT/VxA7xPTpjEl/a8QCUHr20uiNrTAUAmXc12Zvf3wEeKliw4oD2 drCBHe+Kmkjwf4c7jLY4Qfm3hbHvq+jaglYk5prI062CenLStMBKcEjy/8QrLcwj2EGALGMcPiNsd W3hvUag1HDi8G/eQ5/REPo8QKGIgPGWSHT32TamJtNySJvbvH1fWe3m+BSHVVocY1wFExCXxI+Nah F1pYLuzY+kMSe5uYU7qaHs4gBdg96o/ckHNoWiWAwp57ZB7hvr9tBgfosWU3KPAIb2SUe2/+bfh4R NpQklf8A==; Received: from [50.53.46.231] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1rG9br-001aN9-0c; Thu, 21 Dec 2023 03:20:31 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, Jonathan Corbet , dri-devel@lists.freedesktop.org Subject: [PATCH 4/4] drm/i915/perf: reconcile Excess struct member kernel-doc warnings Date: Wed, 20 Dec 2023 19:20:29 -0800 Message-ID: <20231221032029.30942-4-rdunlap@infradead.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231221032029.30942-1-rdunlap@infradead.org> References: <20231221032029.30942-1-rdunlap@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785860064904346906 X-GMAIL-MSGID: 1785860064904346906 Document nested struct members with full names as described in Documentation/doc-guide/kernel-doc.rst. i915_perf_types.h:341: warning: Excess struct member 'ptr_lock' description in 'i915_perf_stream' i915_perf_types.h:341: warning: Excess struct member 'head' description in 'i915_perf_stream' i915_perf_types.h:341: warning: Excess struct member 'tail' description in 'i915_perf_stream' 3 warnings as Errors Signed-off-by: Randy Dunlap Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: intel-gfx@lists.freedesktop.org Cc: Jonathan Corbet Cc: dri-devel@lists.freedesktop.org Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_perf_types.h | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff -- a/drivers/gpu/drm/i915/i915_perf_types.h b/drivers/gpu/drm/i915/i915_perf_types.h --- a/drivers/gpu/drm/i915/i915_perf_types.h +++ b/drivers/gpu/drm/i915/i915_perf_types.h @@ -291,7 +291,8 @@ struct i915_perf_stream { int size_exponent; /** - * @ptr_lock: Locks reads and writes to all head/tail state + * @oa_buffer.ptr_lock: Locks reads and writes to all + * head/tail state * * Consider: the head and tail pointer state needs to be read * consistently from a hrtimer callback (atomic context) and @@ -313,7 +314,8 @@ struct i915_perf_stream { spinlock_t ptr_lock; /** - * @head: Although we can always read back the head pointer register, + * @oa_buffer.head: Although we can always read back + * the head pointer register, * we prefer to avoid trusting the HW state, just to avoid any * risk that some hardware condition could * somehow bump the * head pointer unpredictably and cause us to forward the wrong @@ -322,7 +324,8 @@ struct i915_perf_stream { u32 head; /** - * @tail: The last verified tail that can be read by userspace. + * @oa_buffer.tail: The last verified tail that can be + * read by userspace. */ u32 tail; } oa_buffer;