From patchwork Wed Dec 20 09:49:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wang Jinchao X-Patchwork-Id: 181555 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp2525804dyi; Wed, 20 Dec 2023 01:49:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IHLBlZodeN5vOiS6R/df9UYWZExM+ff7Vo2tlVTQEUUDhe943AJHhlDZiiQBouxY7ymWKk7 X-Received: by 2002:a05:620a:1d94:b0:780:2468:34a0 with SMTP id pj20-20020a05620a1d9400b00780246834a0mr7340083qkn.70.1703065796304; Wed, 20 Dec 2023 01:49:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703065796; cv=none; d=google.com; s=arc-20160816; b=M2u7jjM27fMha8epm2cwOjA23tWksDsO3ZN/PBxtKRMe54D7U163vX1zJvAOl6QmtL MFSPFjBLoM7GSBY7Qj3AzAkwpk8k8xOEfZ5Sgqc8zYP4c90ikufnYjJ/kxCiYXsjTmbw Kt00g6sGHRCzLSedWGzRi9Uc8jYOMfrWhFvZQWv9jIRGYG2lKIfkq4GW4Pe8r/qYdKp4 Zis7plgRZhqGqPoyYk/Y9QeMp3IDbz1aNFYnAJlu/pMfMtD0KsXScD6f38BI04EHVpIq eqVFezGKDigiMATOpTkaiVqk/tCvf9Lu6fNsQSPz+9R4XlkH/okMY4QdW3Xl9oU6rzYl r79A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-disposition:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:message-id:subject:cc:to:from:date; bh=m6qDFSCiI2OYBSCPvAOYJhUcXBIgrfwWZRi4gPgz1SQ=; fh=f40UFx4PIoN5VHjot5Te0Vsnl2epc2I3Vpkjl2f6MCo=; b=SynsqnknbhX9SPaHqIJgvYnQf3easxTJ6vykkeCuFTenxg4MvzTANcLO5z09/rOWq2 RaPRTWpsMWSAEJhv7aJUAqKnsOz08UKM5GjsjH6oCpya6/H6XpNj+3ZqOt/E5aucH6m7 LMyhQ7N+SaR+MvYKZpsLXhR+hUrDRXD9si8F+ei5AZBcmejW98nzDLCGPk4tHZRdav57 fpfzuT1KU/ctM112rnym7rDJReRQYTjCWAqCB+JXxSfjnuteWRyYGNNfNqSMAAA2ZhU8 rg5KIFFetlEflsdNjksLBV1e3/HiUjnXmQrANOwNfRlOx3MNVJT/WOMJ38HBOQZ3JRGl UNwA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-6649-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6649-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id o13-20020a05620a22cd00b0077f3b68f92asi26882363qki.372.2023.12.20.01.49.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 01:49:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-6649-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-6649-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-6649-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 1F7111C2206D for ; Wed, 20 Dec 2023 09:49:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2B134200AC; Wed, 20 Dec 2023 09:49:42 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from wxsgout04.xfusion.com (wxsgout04.xfusion.com [36.139.87.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDECE1F606 for ; Wed, 20 Dec 2023 09:49:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=xfusion.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=xfusion.com Received: from wuxshcsitd00600.xfusion.com (unknown [10.32.133.213]) by wxsgout04.xfusion.com (SkyGuard) with ESMTPS id 4Sw7wb74fnz9ykLG; Wed, 20 Dec 2023 17:45:51 +0800 (CST) Received: from localhost (10.82.147.3) by wuxshcsitd00600.xfusion.com (10.32.133.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 20 Dec 2023 17:49:27 +0800 Date: Wed, 20 Dec 2023 17:49:26 +0800 From: Wang Jinchao To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , CC: , Subject: [PATCH] sched/eevdf: Correct comment in place_entity Message-ID: <202312201748+0800-wangjinchao@xfusion.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-ClientProxiedBy: wuxshcsitd00603.xfusion.com (10.32.134.231) To wuxshcsitd00600.xfusion.com (10.32.133.213) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785793920639206852 X-GMAIL-MSGID: 1785793920639206852 Fix variable names in the place_entity function comments to accurately represent lag calculation. Signed-off-by: Wang Jinchao --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index d7a3c63a2171..23e3fa1236f5 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -5160,7 +5160,7 @@ place_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int flags) * V' = (\Sum w_j*v_j + w_i*v_i) / (W + w_i) * = (W*V + w_i*(V - vl_i)) / (W + w_i) * = (W*V + w_i*V - w_i*vl_i) / (W + w_i) - * = (V*(W + w_i) - w_i*l) / (W + w_i) + * = (V*(W + w_i) - w_i*vl_i) / (W + w_i) * = V - w_i*vl_i / (W + w_i) * * And the actual lag after adding an entity with vl_i is: