From patchwork Fri Nov 11 17:08:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 18920 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp864251wru; Fri, 11 Nov 2022 09:11:03 -0800 (PST) X-Google-Smtp-Source: AA0mqf6nMd8COcIOyqUotI72SLEdixqY5xJ3+ms+oVEF6pbHI2MwC3NEHBm4pyIE7SBEX5MOer54 X-Received: by 2002:a17:902:aa05:b0:17b:2361:9716 with SMTP id be5-20020a170902aa0500b0017b23619716mr3131140plb.56.1668186663549; Fri, 11 Nov 2022 09:11:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668186663; cv=none; d=google.com; s=arc-20160816; b=vRUVjz/2Q/i1KMO/4IyF2ZWUXb5CYR3baVlzHxQL69bOu24ahCBO45XgpOTOxUmG7j YOqmbxw4wd7edJoLyAu0MwJWbGcE7989hw71dHEYM8IPtGetWzkXxigp/Gjbn2AoX1oB B7Zw/2cZ8SNsMxqhbUAZO3JrhXPA6gcPDzEloo+ywjgbsRBqfJFzsrGTXkP2qqmP4KDN SXiARSgJjpw5nrTKVXWOj+ig2hsu2OHV7s8Nih3QvxGXDH7XagesLBYYzZ/7ZbOciYL2 e8mbW9u1woyVTFl9OI80SysT09Is9bQ89mJzGsRedeemRkHmQL7vZ+PnbyDblh8aYYHY q+IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=2IWLrD4C46aKmQaLw0mo+60fQZJP9UtxE6QzQixWpf0=; b=GAY+kCMYxENZHHIw9eqZ+czAzZjrqz8E9ISgsHAEH6SjPXuRqaqoPZaE7xk9TkQ0Yp b/9AGJ5QzJdkktM5lHPiSfwDTPn4fIHl3VZX+tWc6YcgLJ7ISOXSEiY4Hk0s35NOSgFv w5Pyynqd850xnE+yYDdQu5/QYA0ZZalBi/4t43xUr6izYNQSIsmr+iL3ImZvd4XTI8aW ZYmnDJlfDhARRs3+5gpL8eesWdzNFSGkFDdL7rVa0c1feBVZSAtjdXZr3E7h2bEaznzv 7uHJCGgy6inxKhfuZaxNx3XCvRvJ8ZdbuZzpvyHqH+bTww82mgygyDeNZXmn23R7Xw9O kyzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="Rg7o/CAw"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y24-20020a1709029b9800b0017c59fa6b65si2697238plp.597.2022.11.11.09.10.48; Fri, 11 Nov 2022 09:11:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="Rg7o/CAw"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234337AbiKKRJO (ORCPT + 99 others); Fri, 11 Nov 2022 12:09:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234340AbiKKRIx (ORCPT ); Fri, 11 Nov 2022 12:08:53 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8B4410C5; Fri, 11 Nov 2022 09:08:26 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id t4so3275247wmj.5; Fri, 11 Nov 2022 09:08:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=2IWLrD4C46aKmQaLw0mo+60fQZJP9UtxE6QzQixWpf0=; b=Rg7o/CAwJNOUBY+WgCJx82bsbnycLUEJXepv4OfsHgtFrGyVLodrTz5vwPK6SuAdgI KuUyvVDND9kjb2Ri87mvmCkF0RxUiYj9RTDxJR/p09+Qq2CQVZswlyjVZC4Qlx5MTTIy EXptI8ZfrzP2uj/N6IsLkJBllo7BdpvekfN3ufwaOYCNEBn7E40DdHAHBf1/yIMvcl8Z 3N/dEQ9QomhQRIvfinUkPGMwUTa4jKPS/HgjE3xl/4PcTeUBIWCwqqUte01lYhk60djL DWHyWSqKW1HjhgtDcvjGccp3KReIzrAAzq6rGUuRnnAfrFi36x6oXzExcuksltFgiRmo 7wuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2IWLrD4C46aKmQaLw0mo+60fQZJP9UtxE6QzQixWpf0=; b=j6NxtPRW2svn0bV4O6d1DbfRXGN5RVR7An2c4zBnlnhUMU8/jE1Hd0qnCzWETewh4d hFQh/BP6d0c5bmGh7tu0h6J+9Ax61UcXvdmN/h8jKhE3lDKAfYI9rniw55K0t/l4liUC ymXYGBDBvmeoZ3pVyHdkLCd5uiCZNl3O5FCue9utd2KW4fcKGxHMmGVsjGMGfChr9fTe EMjnZiUizlejWhxYGbwr69qdoN5frzA7qTIxCckZfTKp8JE9M/ZQiENSuqHumuinb3mX +H8QKIo0lyD2NsOgTNecGo1Z11Q6FXI/WIU3DSbXsINoqNlyrNEsjt2RC4S7S6fZU4U9 r2AA== X-Gm-Message-State: ANoB5pl7mr1Wc+m4Jm7LKy8TkdCRaAcJ6jyOBC4obU32g2+DRu0w1ofE dYAPvwNNu47WhejPNNZEU8o= X-Received: by 2002:a05:600c:3489:b0:3cf:8731:8110 with SMTP id a9-20020a05600c348900b003cf87318110mr1998435wmq.32.1668186505245; Fri, 11 Nov 2022 09:08:25 -0800 (PST) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id f7-20020adfe907000000b0023677081f3asm2322425wrm.42.2022.11.11.09.08.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Nov 2022 09:08:24 -0800 (PST) From: Colin Ian King To: Hannes Reinecke , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] scsi: libfc: remove redundant variable ev_qual Date: Fri, 11 Nov 2022 17:08:24 +0000 Message-Id: <20221111170824.558250-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749220498885918294?= X-GMAIL-MSGID: =?utf-8?q?1749220498885918294?= Variable ev_qual is being assigned and modified but the end result is never used. The variable is redundant and can be removed. Signed-off-by: Colin Ian King --- drivers/scsi/libfc/fc_disc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/scsi/libfc/fc_disc.c b/drivers/scsi/libfc/fc_disc.c index 942fc60f7c21..0f32ded246d0 100644 --- a/drivers/scsi/libfc/fc_disc.c +++ b/drivers/scsi/libfc/fc_disc.c @@ -75,7 +75,6 @@ static void fc_disc_recv_rscn_req(struct fc_disc *disc, struct fc_frame *fp) struct fc_seq_els_data rjt_data; unsigned int len; int redisc = 0; - enum fc_els_rscn_ev_qual ev_qual; enum fc_els_rscn_addr_fmt fmt; LIST_HEAD(disc_ports); struct fc_disc_port *dp, *next; @@ -107,8 +106,6 @@ static void fc_disc_recv_rscn_req(struct fc_disc *disc, struct fc_frame *fp) goto reject; for (pp = (void *)(rp + 1); len > 0; len -= sizeof(*pp), pp++) { - ev_qual = pp->rscn_page_flags >> ELS_RSCN_EV_QUAL_BIT; - ev_qual &= ELS_RSCN_EV_QUAL_MASK; fmt = pp->rscn_page_flags >> ELS_RSCN_ADDR_FMT_BIT; fmt &= ELS_RSCN_ADDR_FMT_MASK; /*