From patchwork Tue Dec 19 00:28:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Corbet X-Patchwork-Id: 180689 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp1624495dyi; Mon, 18 Dec 2023 16:28:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IHaJtcBavVWqa24GcXA4DxlRhmkT9GbAP1W/Dlj99BMPiHkn+lfAlf/XDbsj0dqBwrrOipC X-Received: by 2002:a05:6a20:1b08:b0:191:70fc:c485 with SMTP id ch8-20020a056a201b0800b0019170fcc485mr5714505pzb.55.1702945716399; Mon, 18 Dec 2023 16:28:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702945716; cv=none; d=google.com; s=arc-20160816; b=wFRi3IdBhSY7Wuk7kRdPCxiAXe1CkGG3KT4WqigKp2MBCrS7IgL1me7rveyTrgsHEJ RWcU4uwxTP56VaKs2go1jfl0TrD+gowDcduUahmn+wWJQqDmLJASubCiyJGjMjbwY8YK pS5OmtrSiejrd0wbHkVBXbVzvkjD9bQehSCTo/uM+WFkFzSNQHEJQ3qdaeOh8UnSJxPJ SnUN8i3A8XQ0Efd+Tr+7KWK8H+u5cyhK8XWKeTHn0RZ696hmB3OZFsYK0ixYj3clkh6a gnub6VgeYd12RJnB8pgSwkNH0ne2UQVSSLj1AX5v3Ye2blGOVsV+yFwIiGZXoYG5XMEr naXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:subject:cc:to:from:dkim-signature:dkim-filter; bh=a0F1KU/c3GJSM1QvgmP6g60KFqrrB2L92VtyVaFu2AE=; fh=Z0ib5hwSEv4EtQyBdHr2xdhXx3R4gCsemVWJEhNfRbg=; b=OpVXNuOH/fhNKl5AEPhP5PIaM/0xURpFWqnqkDhDQwHk9mvugZwZ8nopJFPDfT9fhR lrhsg6jOqHnceC814nubrT4muCppYx46XGImQ58tWbChQQvt0HaheITwmjYVWuXP2FOk TNdEl5ftmGTkXoxNOaNn4iHAyOpMiJtwN/xvx146vNRmFd0rTS9W9eGIDEQlEepeWeY0 DkejH9IiIN6UgHViBoodOj4wpCnqjhrII3uPnnSpHI6g8zyV4vE98LnLSa9n4tPnm/RM +poegFFfl8lZOiAA4KAjyRq9F7OKYHO+EdY2EATzRkjQNDsZCom25axhTVnkcX1L1rNE YpfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lwn.net header.s=20201203 header.b=Vw7IAmmr; spf=pass (google.com: domain of linux-kernel+bounces-4522-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4522-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lwn.net Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id l12-20020a170903120c00b001d2e6c3f144si18718493plh.14.2023.12.18.16.28.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Dec 2023 16:28:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-4522-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lwn.net header.s=20201203 header.b=Vw7IAmmr; spf=pass (google.com: domain of linux-kernel+bounces-4522-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-4522-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lwn.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 0E44628624C for ; Tue, 19 Dec 2023 00:28:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 897001FAE; Tue, 19 Dec 2023 00:28:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lwn.net header.i=@lwn.net header.b="Vw7IAmmr" X-Original-To: linux-kernel@vger.kernel.org Received: from ms.lwn.net (ms.lwn.net [45.79.88.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A7BF387; Tue, 19 Dec 2023 00:28:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lwn.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lwn.net Received: from localhost (unknown [IPv6:2601:280:5e00:7e19::646]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ms.lwn.net (Postfix) with ESMTPSA id AC5A32E5; Tue, 19 Dec 2023 00:28:13 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 ms.lwn.net AC5A32E5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lwn.net; s=20201203; t=1702945693; bh=a0F1KU/c3GJSM1QvgmP6g60KFqrrB2L92VtyVaFu2AE=; h=From:To:Cc:Subject:Date:From; b=Vw7IAmmrc6vAXS/pqzU68bdEHzA1Wq4Cy1DJTXVUvvkpZzZ4xF2RUzYnQZaDkrvf/ 5VLQKzI40rtpt2xsp3acV6laGL87KeduAMWnp4/nH/J090kmgoRTyOxkDuLoJ2sjqK fRKfclNyDMaMbU4ADh0O85kd9kBtl/0DfpVN9E24F5e18BmNkNj6Qzr3XQflUyQTcL 0tYLdTU8JCg5kejRbgrV2L/llepW9RGSrmeJ0eCIy6p59A5/zfZBasfCFJnDS5xTye 1MvNLs9x4HQgbAkixFfBRyAz0nHIVg8ImZJaXiyrLjzhUHQ/qcEilVzN6n9kVLwms2 O3T73zOVc3HUA== From: Jonathan Corbet To: Jon Maloy , Ying Xue Cc: netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH] tipc: Remove some excess struct member documentation Date: Mon, 18 Dec 2023 17:28:13 -0700 Message-ID: <878r5rjasi.fsf@meer.lwn.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785668007495520365 X-GMAIL-MSGID: 1785668007495520365 Remove documentation for nonexistent struct members, addressing these warnings: ./net/tipc/link.c:228: warning: Excess struct member 'media_addr' description in 'tipc_link' ./net/tipc/link.c:228: warning: Excess struct member 'timer' description in 'tipc_link' ./net/tipc/link.c:228: warning: Excess struct member 'refcnt' description in 'tipc_link' ./net/tipc/link.c:228: warning: Excess struct member 'proto_msg' description in 'tipc_link' ./net/tipc/link.c:228: warning: Excess struct member 'pmsg' description in 'tipc_link' ./net/tipc/link.c:228: warning: Excess struct member 'backlog_limit' description in 'tipc_link' ./net/tipc/link.c:228: warning: Excess struct member 'exp_msg_count' description in 'tipc_link' ./net/tipc/link.c:228: warning: Excess struct member 'reset_rcv_checkpt' description in 'tipc_link' ./net/tipc/link.c:228: warning: Excess struct member 'transmitq' description in 'tipc_link' ./net/tipc/link.c:228: warning: Excess struct member 'snt_nxt' description in 'tipc_link' ./net/tipc/link.c:228: warning: Excess struct member 'deferred_queue' description in 'tipc_link' ./net/tipc/link.c:228: warning: Excess struct member 'unacked_window' description in 'tipc_link' ./net/tipc/link.c:228: warning: Excess struct member 'next_out' description in 'tipc_link' ./net/tipc/link.c:228: warning: Excess struct member 'long_msg_seq_no' description in 'tipc_link' ./net/tipc/link.c:228: warning: Excess struct member 'bc_rcvr' description in 'tipc_link' Signed-off-by: Jonathan Corbet Reviewed-by: Randy Dunlap --- net/tipc/link.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/net/tipc/link.c b/net/tipc/link.c index d0143823658d..0716eb5c8a31 100644 --- a/net/tipc/link.c +++ b/net/tipc/link.c @@ -82,10 +82,7 @@ struct tipc_stats { * struct tipc_link - TIPC link data structure * @addr: network address of link's peer node * @name: link name character string - * @media_addr: media address to use when sending messages over link - * @timer: link timer * @net: pointer to namespace struct - * @refcnt: reference counter for permanent references (owner node & timer) * @peer_session: link session # being used by peer end of link * @peer_bearer_id: bearer id used by link's peer endpoint * @bearer_id: local bearer id used by link @@ -94,31 +91,19 @@ struct tipc_stats { * @state: current state of link FSM * @peer_caps: bitmap describing capabilities of peer node * @silent_intv_cnt: # of timer intervals without any reception from peer - * @proto_msg: template for control messages generated by link - * @pmsg: convenience pointer to "proto_msg" field * @priority: current link priority * @net_plane: current link network plane ('A' through 'H') * @mon_state: cookie with information needed by link monitor - * @backlog_limit: backlog queue congestion thresholds (indexed by importance) - * @exp_msg_count: # of tunnelled messages expected during link changeover - * @reset_rcv_checkpt: seq # of last acknowledged message at time of link reset * @mtu: current maximum packet size for this link * @advertised_mtu: advertised own mtu when link is being established - * @transmitq: queue for sent, non-acked messages * @backlogq: queue for messages waiting to be sent - * @snt_nxt: next sequence number to use for outbound messages * @ackers: # of peers that needs to ack each packet before it can be released * @acked: # last packet acked by a certain peer. Used for broadcast. * @rcv_nxt: next sequence number to expect for inbound messages - * @deferred_queue: deferred queue saved OOS b'cast message received from node - * @unacked_window: # of inbound messages rx'd without ack'ing back to peer * @inputq: buffer queue for messages to be delivered upwards * @namedq: buffer queue for name table messages to be delivered upwards - * @next_out: ptr to first unsent outbound message in queue * @wakeupq: linked list of wakeup msgs waiting for link congestion to abate - * @long_msg_seq_no: next identifier to use for outbound fragmented messages * @reasm_buf: head of partially reassembled inbound message fragments - * @bc_rcvr: marks that this is a broadcast receiver link * @stats: collects statistics regarding link activity * @session: session to be used by link * @snd_nxt_state: next send seq number