From patchwork Sun Dec 17 14:29:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 180019 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp733827dyi; Sun, 17 Dec 2023 06:33:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IGD59unKtVQ+itg9esQjljCHjnGd+n62Iq3+sN5qBXBbMYq5BgMR2YRBjXFqtGkpN26JYXB X-Received: by 2002:a17:906:2099:b0:a1f:6541:75b5 with SMTP id 25-20020a170906209900b00a1f654175b5mr7907582ejq.90.1702823599402; Sun, 17 Dec 2023 06:33:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702823599; cv=none; d=google.com; s=arc-20160816; b=v5iSACPQzdgh+FfNd2u81T+jftX5hp/SulylLq5FuXnhaWUfet7QQIXU50VYH9SlHP 7I9Dm9DhQQWgJ0u6HvulhxV1MIMsDuBgSyCsgDoM1uQ5v7OTe43a0vk+BRCQ4zuFG58s u4bOQrGjOsQArfUpju2XmRBugJjxUt3JeXPL3Z7AuEuteDtLmRjTkBrOcEiWeyOv/9VO 1UURF0WFAmaXXwl/Kv8GVyeWuC2CLe0js8JSp+VwMG7p+jtxUsC9QMxTWNlVEy17TYw3 zSJiHvzPvDPQ0oQg4ELyMXShTueitBLHtaLw2mk2jOm+5agRc1lQDI/OEbAAaz7Q05GY SIbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=6kSo6IM5noELbQvPU+rEV4GJIh1YNljG18YOAr8aWyU=; fh=xujKiMmFJlaRajf7/h0r/xgOkeSk7wwiavZofWauGUw=; b=VAc1f0oArRcOpIPz8vFyvDt3dbWzBAhgBju3lgv4ujBsy2j4iT2m1TSMik7wCzBhTf XILA7PsKAV8zIEysGyFbLcNd70SbKe071YD3OUi4J9iz5CbsqU0IWwCvM2FMNbH4b1wx k3PdIE6gpkK+GzmNjH3zkRedq0zq5CI1lkxKkhFkH+RwHc4596V7xr2LPJPKWOrOX1m0 J7zml+2L5PdwVazuhzhh58MbXPEcUpdAh/LdPpi1d9oOTm+8G5uPGyUDgXA1DbwLCBwW Nr5imxOk9oqBu33RuojUn0SyubLPkA3WVSdzqC3v4ObZQMP7oKRYP0JoJ1w7Ftkkr3ti KdEQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2639-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2639-ouuuleilei=gmail.com@vger.kernel.org" Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id d12-20020a170906c20c00b00a1c68c96a27si9623257ejz.436.2023.12.17.06.33.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 06:33:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2639-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2639-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2639-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 08CB31F21435 for ; Sun, 17 Dec 2023 14:33:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7E71F49F9D; Sun, 17 Dec 2023 14:30:29 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68E3745014 for ; Sun, 17 Dec 2023 14:30:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEs9e-0006VK-T6; Sun, 17 Dec 2023 15:30:06 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rEs9c-00GUh6-23; Sun, 17 Dec 2023 15:30:04 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rEs9b-004hyt-Os; Sun, 17 Dec 2023 15:30:03 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski Cc: kernel@pengutronix.de, Markus Mayer , Broadcom internal kernel review list , Florian Fainelli , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/15] memory: brcmstb_dpfe: Convert to platform remove callback returning void Date: Sun, 17 Dec 2023 15:29:27 +0100 Message-ID: <94780e5a414b20b6effa1e87208c14620c854e88.1702822744.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1782; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=NqCgvYjkJld3SgKTMzNoNFlN7UBIUNxiFFLbxrZ5cYQ=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfwXGl1AmJHmGkUrNQ1FnLcrkoZ4iDiokSMdTj kBRQcFosluJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZX8FxgAKCRCPgPtYfRL+ TgZPB/4yygmvfAFl9kDpKc6eG2Iay0PbfcS9KAho672FuxXi2wYKFF92Z7VSJkHcnd6C6Ix+YRk LujlGAzxjH+9IWgeGNV9cz/jweGLzDqkYgRnawaziENAnDO3Iq7tP+/5170007yJdXpXlFysicj oqONP/mZMeQeFSvbOM7JyWFXaOc68SPyPMWNlAyyG7mzc/PRX+bAqHbCZ29SGzxLQC6egU9PYxY rqlrsHx5t2HOBm5Q0ZNsyHawSJ7InOwuk+KFmXAfaR+ddDLxVmO7f7LRPg0kGHREeWYYWhA8TtU T5eo7lMF2U4nXnyd1mIZSLzSno+1pyI6hIUnPNRqb4oKb9fv X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785539958324793217 X-GMAIL-MSGID: 1785539958324793217 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Markus Mayer --- drivers/memory/brcmstb_dpfe.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.c index a7ab3d377206..5028467b2dc9 100644 --- a/drivers/memory/brcmstb_dpfe.c +++ b/drivers/memory/brcmstb_dpfe.c @@ -909,13 +909,11 @@ static int brcmstb_dpfe_probe(struct platform_device *pdev) return ret; } -static int brcmstb_dpfe_remove(struct platform_device *pdev) +static void brcmstb_dpfe_remove(struct platform_device *pdev) { struct brcmstb_dpfe_priv *priv = dev_get_drvdata(&pdev->dev); sysfs_remove_groups(&pdev->dev.kobj, priv->dpfe_api->sysfs_attrs); - - return 0; } static const struct of_device_id brcmstb_dpfe_of_match[] = { @@ -936,7 +934,7 @@ static struct platform_driver brcmstb_dpfe_driver = { .of_match_table = brcmstb_dpfe_of_match, }, .probe = brcmstb_dpfe_probe, - .remove = brcmstb_dpfe_remove, + .remove_new = brcmstb_dpfe_remove, .resume = brcmstb_dpfe_resume, }; From patchwork Sun Dec 17 14:29:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 180021 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp733925dyi; Sun, 17 Dec 2023 06:33:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IETjCek8eBtXnmnHijo9LF/Ocb6oB2lMCHVaUM5Z9GW7jpZnOSfnenJd/hLQhk2pZ+IvRVS X-Received: by 2002:a50:c05b:0:b0:54f:53b1:c941 with SMTP id u27-20020a50c05b000000b0054f53b1c941mr8334729edd.13.1702823613341; Sun, 17 Dec 2023 06:33:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702823613; cv=none; d=google.com; s=arc-20160816; b=JiaB6aDodMXyjA3qWensnK2Hh7F1raoh97QQfaL59nWRvExeuygdii9/pEkJtIRr/M XJpfQIQIlHEjAMSzW0fKxzThkmxt+W83BPrE36KqD2BVIIK3VbCznsu+Yfw3jTx+OJ2N ZseUytBYoTwZW26EUqRaW9SelZZ0fkzl9/ipO8IFzHYGVFxFr4Kl/uN32R5Rwjffv0XJ e8oBT4mv4z7dn09gil99hfo6VAQDmHKd30ViYf4peG2/pKkTL6hCd1pSoPtEDP4bQJJb Y9IqV51KGOU3l8I5PVLA69sKj+lSCAFPhhP3s/hoeJs1J2/AmIof4blaVzaFHNXi0hWc qQGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=3uBhiKvZagbLxIz0w4bC3hU9WRIKGIveBFnPISMeu7c=; fh=JUqUf23jQJn4VKsudodbKzldZ54PJMgJVUGsstYEUqY=; b=0Sk8mK6V1spqVgn+aPQaYgUPGPx+V3glRBgUIwwOxYsmI3HKiYcBH9egDUpC0rj+2f AemX70a2wY8HDDGfNFGBd9O5liXpLIMQ0Hu3BzePCUNEFOmsnvkrUGevpNACfB92xNU5 HnLMAvEO0cYC/6z+u8QO3TT/EGpPbAealVhi7re4mDZXc/PReU5AyyJcD2tZdvvPmiSr Z1uP0TUTOl4EamIHKsge0Kkxl0vcgulW+xOYSNzD0arYyHUeMjuGd7n3SYlBVCssbYO8 arAcArzNL/i9FJ5++LbF3j1M6FwMwSf2EYl+XOON8AqEv5xsm3tEqh96W+YFT3lUfONi PXpQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2635-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2635-ouuuleilei=gmail.com@vger.kernel.org" Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id h3-20020a056402280300b0054ca260d79asi9263346ede.248.2023.12.17.06.33.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 06:33:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2635-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2635-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2635-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B2EF81F22540 for ; Sun, 17 Dec 2023 14:33:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 93D984AF9F; Sun, 17 Dec 2023 14:30:30 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E42045957 for ; Sun, 17 Dec 2023 14:30:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEs9e-0006VL-T4; Sun, 17 Dec 2023 15:30:06 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rEs9c-00GUhA-95; Sun, 17 Dec 2023 15:30:04 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rEs9b-004hyw-W6; Sun, 17 Dec 2023 15:30:04 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski Cc: kernel@pengutronix.de, Florian Fainelli , Broadcom internal kernel review list , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 02/15] memory: brcmstb_memc: Convert to platform remove callback returning void Date: Sun, 17 Dec 2023 15:29:28 +0100 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1775; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=SpMi1wg6uau+YqEvL4zWCt8cnKaO+rNdF1rNrAv67zI=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfwXHmWa9sJ09D5q7RteC6J2eSV0osYkFrjnhH GFnMTS5CiKJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZX8FxwAKCRCPgPtYfRL+ Tv08B/9jWNWVJdwg3eqyaHMspo0t4LNc4AS+YH6ZaFbvzn9MbVijqfopM3kx8fgJ91XdeKYJORL LWTgeid/MeA++pW7lAKZZtW+GHuRnndT8NgbXy2NyM8se82jcfVKSFGRDiom/MEqvPQPeTmNzqp j7SvQ0Igl8YTs0dWfgpfwe+xT1vFFp6Bkx3qfRdZXbT0pBAeTNhpHuzJNwDLo6xhKL3A3qZ548v go+HQS7OwjXD/22sZvYqQd8Qk9SQf+d22Atn3maaigOFc/shB+x0EE3Ez2J1jGC6MwfSCKiOP6o w28Sfrrobm7lWlTnMgH++7AwU+o+p4YZojmCgkVxFaxhsZ5s X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785539972907325282 X-GMAIL-MSGID: 1785539972907325282 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/memory/brcmstb_memc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/memory/brcmstb_memc.c b/drivers/memory/brcmstb_memc.c index a6ea51996522..ea9213f7152e 100644 --- a/drivers/memory/brcmstb_memc.c +++ b/drivers/memory/brcmstb_memc.c @@ -152,13 +152,11 @@ static int brcmstb_memc_probe(struct platform_device *pdev) return 0; } -static int brcmstb_memc_remove(struct platform_device *pdev) +static void brcmstb_memc_remove(struct platform_device *pdev) { struct device *dev = &pdev->dev; sysfs_remove_group(&dev->kobj, &dev_attr_group); - - return 0; } enum brcmstb_memc_hwtype { @@ -284,7 +282,7 @@ static DEFINE_SIMPLE_DEV_PM_OPS(brcmstb_memc_pm_ops, brcmstb_memc_suspend, static struct platform_driver brcmstb_memc_driver = { .probe = brcmstb_memc_probe, - .remove = brcmstb_memc_remove, + .remove_new = brcmstb_memc_remove, .driver = { .name = "brcmstb_memc", .of_match_table = brcmstb_memc_of_match, From patchwork Sun Dec 17 14:29:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 180016 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp733194dyi; Sun, 17 Dec 2023 06:32:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IGIIzVw41KyX8rRurHYE+W3IqlsyWhm9z8KXp4ac9Q7CdHsv7PTv3qQ4IiWb3DZwRIgqbzJ X-Received: by 2002:a05:620a:1458:b0:77f:b2d1:6c24 with SMTP id i24-20020a05620a145800b0077fb2d16c24mr4696127qkl.157.1702823523163; Sun, 17 Dec 2023 06:32:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702823523; cv=none; d=google.com; s=arc-20160816; b=dLPzWXc5g5Uh5h5ZALGCowZMDlptCI6LGMqXtPs9widRME5varZa7OGmHRSY2kVaLa LPUQZVnVQQtdN0osawy1/ehqvVJbhofQ4IZKAC+ShZD4waryg3X7nIyIekSeIdUXN5mq RhSBekP0joc0O+0zpWanmSJqnSXK8vkhgMeS8aL6tiJBiJUHokVHOG5OnCvI0JD6JjQJ rvrZvsE//h4Zv/U57CE4CJ4MJUP59B/XrRAXg4izAe0y4DJiAHwQxIIR2gXEJl4Wih3g RGJ0iboz/aKaqpb2Mgo/e4VeJnCKxAGUoPHCy+oj0xk7o0CCvPs3chXSranq2SnIEPGu yBGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=cI7C2Hn5DZODfFubFCgIdyj/sZQBEepEUrU2eZ5pLu8=; fh=U565yqmgZMcvr3E5NWk2zB3l8gfOALKowPOdrK24J5o=; b=lvOeXNCX3ySevR4/iu2hqgK+9Sj6DnP5u/eHG69VaIW101WM6YlGft1L4NnVDa7oPm 6AUNDfQJ4l7eo4dBGq5sVoYz+1dbTy5P/paWfaGMd0XoIZpECc7tBLM1hZp9HaZ5XGCw WbqjE57zwmZfGV3YLjCqe+EJwiU+isbWMWNrl9h1nYXe5WYkzu6TTFWekOm29QE2xKAb qW1/2aQ/m9iaxXHVlu5NY0PQbvdiiN46gCw+TIdD+erFFi2CCH4Q6rG2fnSZayk4O3L6 Y0eEGctSo5GZ2LtNeck90e9/e7ALSZt+KV/uAIgBR1dqtl063f/HEk3lj7n9mlaLgnP6 WtRQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2633-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2633-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d18-20020a05620a167200b0077da9b7be21si20949070qko.581.2023.12.17.06.32.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 06:32:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2633-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2633-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2633-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id EEF731C21D22 for ; Sun, 17 Dec 2023 14:32:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1F15C46B98; Sun, 17 Dec 2023 14:30:25 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53FA444C84 for ; Sun, 17 Dec 2023 14:30:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEs9c-0006VM-WF; Sun, 17 Dec 2023 15:30:05 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rEs9c-00GUhD-GI; Sun, 17 Dec 2023 15:30:04 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rEs9c-004hz1-7A; Sun, 17 Dec 2023 15:30:04 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski Cc: kernel@pengutronix.de, Santosh Shilimkar , linux-kernel@vger.kernel.org Subject: [PATCH 03/15] memory: emif: Convert to platform remove callback returning void Date: Sun, 17 Dec 2023 15:29:29 +0100 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1692; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=unkZGXW/GBMij3XUkpyQaAXYnruITJsZtJqqHnqW6wY=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfwXIlYCuL20IU+oKd4SHoVuSVc2z9AqLE+XQP VhL8Zc1e3eJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZX8FyAAKCRCPgPtYfRL+ TkcuB/9xUatnUb3NxjSCoYvzf/ZDrQDjLfZpdz6ty/hfopPE7HsdjEpp1xC68ChCZFEpul2N6ka m5baMNk4B2dtrhQR4UMqwmMLL+NK4H57cYWbQmi2scmzb7nk72ewlnpvIy9x/zDbV4mGXWvuYL2 Cwnr3ddJKhhS1huGAh1sY+pasL7xBIIxjCg8PTV7stp1c+tCw7pf2pjPUtJq62Fz8nLhFBW3Yaw fSeVVqCsu+f/fF2/ji7ikpx+tew/rZft/hESOd53krOs9FxQcDfucVp2wMGDjjEp+SUT1I4pO/i 9chBR4OWfNTWcbjvh54/hUFbh4/wlGe004eGG4i2ccRe771G X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785539878339935276 X-GMAIL-MSGID: 1785539878339935276 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/memory/emif.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c index f305643209f0..434982545be6 100644 --- a/drivers/memory/emif.c +++ b/drivers/memory/emif.c @@ -1159,13 +1159,11 @@ static int __init_or_module emif_probe(struct platform_device *pdev) return -ENODEV; } -static int __exit emif_remove(struct platform_device *pdev) +static void __exit emif_remove(struct platform_device *pdev) { struct emif_data *emif = platform_get_drvdata(pdev); emif_debugfs_exit(emif); - - return 0; } static void emif_shutdown(struct platform_device *pdev) @@ -1185,7 +1183,7 @@ MODULE_DEVICE_TABLE(of, emif_of_match); #endif static struct platform_driver emif_driver = { - .remove = __exit_p(emif_remove), + .remove_new = __exit_p(emif_remove), .shutdown = emif_shutdown, .driver = { .name = "emif", From patchwork Sun Dec 17 14:29:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 180015 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp732944dyi; Sun, 17 Dec 2023 06:31:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IEUJrHQQWW4XnEC6PNH95hQBhW9kAVlx6jI4+AHeu/g0oThaZa3Kno4FDG5tQHAob4iKBZe X-Received: by 2002:a17:902:e5cd:b0:1cf:cd31:6b85 with SMTP id u13-20020a170902e5cd00b001cfcd316b85mr17701668plf.27.1702823492251; Sun, 17 Dec 2023 06:31:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702823492; cv=none; d=google.com; s=arc-20160816; b=vS+gcOJ3wM70IX/He4jZOOKWm4GlIjJ3rFXaexGfTQUsLeePkHRX2QltdclLPYx4Vi xqbZr6pwrtltxnkHX4Z86+l7YIJszqOjXZK0yG+hUzsLuOdD1akXdXdx3Yz7MA8UycLc D/VCeT03UUr957XMCgmzh0bW5lbzIFqI6LT7IsxS8grPL+ofqBCrpHJA/gddWlyob7O2 EKBE96VujADovXvmZPFsvqnAQNfYKvRyZQaYyihRFZSBLZ8svZSdSEEUeMPiqiF2Mw2P 78G3aE4LziSWT6KKduyevIroWYdzDCnD67Fe3A9hshQBb7Ui7ZkpZl31gQYsDo6MkAEj TUuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=K6YcywXB8alB5UELw2c1nqAMOGchldJ3T1bycMljXl0=; fh=e08qmhSPRKoDoCS9mOXl3SU+TueaIFtaf9hHDo9WBfU=; b=slhxWEd6jk0HW7AgbYVkEEc33qlZzOUgXcocfzEdByP/Wjr9Tv0JgtoAHEDoBhDffS sKkCA46Nn/CXdQ7CNCz1GEpGcFP+OLc7jcXLFTRNaLf+8FIhsc3lRbYVO2bSpCq/98WR QqPG5/XCHrTmNHAKCIfCTXFd0Z3dWbzJhUNrOxpwtQYo/vu7mu5HPFQKhlkfFjV1rzVf pooeZ13tD5izr/X5PZLi3KY6odm/1uxKIqrK4xavVDMmDFg90eT/lzto2dGgOC4ADInV qrTF/ieGZdb4opmV3BWLg/MaDSOPI/2HyTGOVBlAd/WsztT/88R3AAgDobYSi+Tmovj7 KAIQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2630-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2630-ouuuleilei=gmail.com@vger.kernel.org" Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id b7-20020a170902d88700b001cf9e863152si16014152plz.642.2023.12.17.06.31.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 06:31:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2630-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2630-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2630-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 5560DB2226E for ; Sun, 17 Dec 2023 14:31:16 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 62F7846BB6; Sun, 17 Dec 2023 14:30:20 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56FF744C74 for ; Sun, 17 Dec 2023 14:30:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEs9d-0006VQ-6T; Sun, 17 Dec 2023 15:30:05 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rEs9c-00GUhG-Q0; Sun, 17 Dec 2023 15:30:04 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rEs9c-004hz5-Gp; Sun, 17 Dec 2023 15:30:04 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org Subject: [PATCH 04/15] memory: fsl-corenet-cf: Convert to platform remove callback returning void Date: Sun, 17 Dec 2023 15:29:30 +0100 Message-ID: <3b506dcf90b57c341e59bcf5af7ee69092a2d857.1702822744.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1761; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=4GKd6L0J9ejMA+vYrbmphTcshFPUGEJl8XNbz0nTZqo=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfwXKD2N267gDEQ6+5jqpmelYgMzz8hlB8epUD PGbWwv5StKJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZX8FygAKCRCPgPtYfRL+ TsMSB/4tyd+z/3jSZvqYtk7kHqOBS6yGBKMCquYj1vXCQM+aqhWqyzfWs2kR8ZF24XIa8cRIYwK a4+gmJV0ed+H5Sy5eSRX6KBd5WwMINfjiwq10aPA0bj6+TcxMZpVAwNZLbFmbwSDIRnpLTQG2o/ 0uV+CH/0QKBfvUkfjH0PzVqhQYf5VDvaWR1+W8Y3tcQFdrerzPYCz5vJxUQdZSxOvIk7jjeh3EM oe1VElX/IFxdJ5vbutdNV7lj6s/Odv2OKVALaTiBZf/SrXKcyk4MqIR1pPtEXYoryNCd55QEYei 7kSK2GCSllPdEFBgh++/V5UJJ1X5hRBLgiLQ7XZYlS2G0AMV X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785539846055277718 X-GMAIL-MSGID: 1785539846055277718 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/memory/fsl-corenet-cf.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/memory/fsl-corenet-cf.c b/drivers/memory/fsl-corenet-cf.c index 8096c4f33303..f47d05f7c5c5 100644 --- a/drivers/memory/fsl-corenet-cf.c +++ b/drivers/memory/fsl-corenet-cf.c @@ -223,7 +223,7 @@ static int ccf_probe(struct platform_device *pdev) return 0; } -static int ccf_remove(struct platform_device *pdev) +static void ccf_remove(struct platform_device *pdev) { struct ccf_private *ccf = dev_get_drvdata(&pdev->dev); @@ -241,8 +241,6 @@ static int ccf_remove(struct platform_device *pdev) iowrite32be(0, &ccf->err_regs->errinten); break; } - - return 0; } static struct platform_driver ccf_driver = { @@ -251,7 +249,7 @@ static struct platform_driver ccf_driver = { .of_match_table = ccf_matches, }, .probe = ccf_probe, - .remove = ccf_remove, + .remove_new = ccf_remove, }; module_platform_driver(ccf_driver); From patchwork Sun Dec 17 14:29:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 180027 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp737258dyi; Sun, 17 Dec 2023 06:41:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IEs6OVSf2a2sKvqCGVPA7PYiRK4m4hYP2lnFJ4fH3InJKc7iN6CEniWUMOt3NNKrZ5eiDXj X-Received: by 2002:a05:6e02:19c5:b0:35f:b06b:2f7b with SMTP id r5-20020a056e0219c500b0035fb06b2f7bmr592467ill.34.1702824105773; Sun, 17 Dec 2023 06:41:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702824105; cv=none; d=google.com; s=arc-20160816; b=NbC905MGdjR3F1SVKHD+sX61ReM2oHaycy2SBF/mGN0OIQssq18SOqEHd6NgwCZEqd gHDsZIPG/BkpoCqfN69KK5Oua2NjiQPHEvjZX2IgxdVipkLpxkeL00vVHMYbunc3nonO eTwPkYZiS60EgtKlMxa+jaDe7mSb0NuCiAn+ON+Z20lN50RaTeuymLySRre76XdGkDfV j9naRU/x26j3WfuUQX+yipBxT+bHSqrrGJmJxg0irRsxfY4HWA3A0oyd2VYP8UfnR6kz NnZFjPkUM+arzqdQ/APdGpbWW/gwcKpp1zuR5NUZUcNtvPb+eOklpwquv6/eFNndvy0J /jZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=Htc0iEl6axaypkjWaYK7SEeM+XxwWnrVG+1N6xL50RI=; fh=e08qmhSPRKoDoCS9mOXl3SU+TueaIFtaf9hHDo9WBfU=; b=I+Q/1AhO9KwR0QkuJa8OhDCfquzJOSr6rS8P5+qjd1ScekSdf9dYemc3nGuDdzrhx1 utd3FQwRYxzZMjcLRuxNOKqkOWrbmbKZAE1juxZpHMSgB7kpJpe+1m7fGIRGyj6ChkSP UwliM2WjzQUBgPgcyBlLx/ULZ4QqBuMR7ZL85mJkCHdMaD0J9QA6VpKfNlPw0wk7Vhed nyO6x3wEcHlcSAAl8NRBGmMQcBfEu7WmsX//7PRADDZp+bjtwY29VTFjd6QaIogJ+68A o/KL4SfamCFxH4MRV/FQKQgYkLdl8VJ+XEzZ7UTfAZLu37qDtfvYx+7VZHjQyJ+OoZE1 x4YQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2632-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2632-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id p8-20020a1709026b8800b001d3482dc1b4si8382705plk.369.2023.12.17.06.41.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 06:41:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2632-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2632-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2632-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 02D642869F5 for ; Sun, 17 Dec 2023 14:32:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B522F481DB; Sun, 17 Dec 2023 14:30:24 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56FBC32C86 for ; Sun, 17 Dec 2023 14:30:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEs9d-0006Vd-DX; Sun, 17 Dec 2023 15:30:05 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rEs9d-00GUhJ-0P; Sun, 17 Dec 2023 15:30:05 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rEs9c-004hz9-NZ; Sun, 17 Dec 2023 15:30:04 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org Subject: [PATCH 05/15] memory: fsl_ifc: Convert to platform remove callback returning void Date: Sun, 17 Dec 2023 15:29:31 +0100 Message-ID: <4c90b971e9816320586f4e01e68c95331b8e524a.1702822744.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1764; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=eSBa/fs8NodpdGdszaXDUc+ymMsxDWr2uvmVnp4C53Q=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfwXLxuA7kDucWGGRqw8PGSmNXnGtbc34NX5Ps jjEdWKqqK+JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZX8FywAKCRCPgPtYfRL+ Tj+2B/9I76sHZ3/XmoTh9IF8YE+UyAZ56dGm/AQVNrlGvKUkBwIBmTZ+g+adxfthZwO+qt56Pq/ URQybLtFhCu490mxmzvR7y3v7NpFCGODHGBdSr16lrlB60RVz3Q2F54s3l4S15BM1h1g9XfKnb8 07p/qO6wlkLpBmMrV+uJmmz+6P4BnofX9dsY4P3qXfbPA+nAQSqMqytcVaA5XTZHvcgVoS6rufH i9ggz9r6lA1Qh4SYnEwitVPXlOxGHVY94jR7cejRc9r7H5MRRIrsnt15L7f+88n3WG/hlkee7NB gcI2I76dxQqMdWwckvyT6wv2TMqU1gjPcKtCG5KHTvxetgoN X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785540489610183250 X-GMAIL-MSGID: 1785540489610183250 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/memory/fsl_ifc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/memory/fsl_ifc.c b/drivers/memory/fsl_ifc.c index 2509e5152036..15e919c24f81 100644 --- a/drivers/memory/fsl_ifc.c +++ b/drivers/memory/fsl_ifc.c @@ -84,7 +84,7 @@ static int fsl_ifc_ctrl_init(struct fsl_ifc_ctrl *ctrl) return 0; } -static int fsl_ifc_ctrl_remove(struct platform_device *dev) +static void fsl_ifc_ctrl_remove(struct platform_device *dev) { struct fsl_ifc_ctrl *ctrl = dev_get_drvdata(&dev->dev); @@ -98,8 +98,6 @@ static int fsl_ifc_ctrl_remove(struct platform_device *dev) iounmap(ctrl->gregs); dev_set_drvdata(&dev->dev, NULL); - - return 0; } /* @@ -318,7 +316,7 @@ static struct platform_driver fsl_ifc_ctrl_driver = { .of_match_table = fsl_ifc_match, }, .probe = fsl_ifc_ctrl_probe, - .remove = fsl_ifc_ctrl_remove, + .remove_new = fsl_ifc_ctrl_remove, }; static int __init fsl_ifc_init(void) From patchwork Sun Dec 17 14:29:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 180020 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp733851dyi; Sun, 17 Dec 2023 06:33:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IGapuRb5mB0pAC7RVBXnR8hfdDatLhwzP9lHRxzmdZDYqxkYebSiwket5RvZIj6Z5yseu2m X-Received: by 2002:a17:907:9486:b0:a1d:c376:216b with SMTP id dm6-20020a170907948600b00a1dc376216bmr17859896ejc.45.1702823602739; Sun, 17 Dec 2023 06:33:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702823602; cv=none; d=google.com; s=arc-20160816; b=AMSehmgjp2omktgM5lYCHfu5DhuHKUXktreyk1ewfw+1ixZyV21DxLFQc3pjJ88pvT w+Ny9XmbKOk2KO4hIHdfuUQmPuppJhOliRw2IXpxmKi5Np7ZLGuCyfGVQXzLd2Wv0jek 93MfsIUsK126hrPGB/uluJy/0DWRXdMNhW3X7TYytYsC/XLvpNhOBCFRDixGftRMqTgJ oDBFP9e95mvqeUJSHSQV0wnZBe7eHJce3axeVCHC41lX2xgf/GrbsWornoJTqFVxI++C BpXl/K74TvyE6b5V2K4YON3+oBuIpDHg5lHuGczR+aio7RCw49orqCMRKEuuxnVEGvbe L/Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=TuqPnXlYTrKbnaOwrLELh1IY56IumYqrEyVvXkSjdS4=; fh=CkYZl1lWjJkhOn5aldfywrl9q1wzY8NWCDxStAxvjs4=; b=a5QVzxR5OswSovi82CEbdH4Xkr758+ZH04coPMaw9qB9q0TWTI4F4LOcYeVW+xPX4i VonJ18b4/bqGmAlQfiuyZ4fxBDYelXRoLy+jDZrNTuylw4BdjCrXqA42VvNPlflezcP7 rI3Y5fsLcWWO0XADNsSJXxAPMPlaz7xAfjnpaUQyL1MckZ/rUinu5oHUQTjgKH1ldXqk uwmHiSlStnMVAYOzyCUP/QQ4JqXlnsMqlBGeKmRpp5nRuY+JYHYIhNlDldL6GdfbTwDX YP5+f/rWx7jEtyVZZaK6uBmmH86B9RsIw4E+964Gzrp1aXpVfoDfSoQltR5eJO6qrs8e eYSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2636-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2636-ouuuleilei=gmail.com@vger.kernel.org" Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id z21-20020a1709064e1500b00a2333191858si969821eju.274.2023.12.17.06.33.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 06:33:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2636-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2636-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2636-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5D0C91F2143B for ; Sun, 17 Dec 2023 14:33:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C48044A993; Sun, 17 Dec 2023 14:30:29 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 698814594E for ; Sun, 17 Dec 2023 14:30:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEs9d-0006Vk-Jz; Sun, 17 Dec 2023 15:30:05 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rEs9d-00GUhN-7G; Sun, 17 Dec 2023 15:30:05 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rEs9c-004hzD-UL; Sun, 17 Dec 2023 15:30:04 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski Cc: kernel@pengutronix.de, Paul Cercueil , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/15] memory: jz4780-nemc: Convert to platform remove callback returning void Date: Sun, 17 Dec 2023 15:29:32 +0100 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1789; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=GK2KZnqcdPQ7ce5OhcDXJKsNHWUaLDvnl9OrvLYV59Y=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfwXMSIuOgrnIXMD1kAk4I+wVgUgcHxmTddpF0 qFTcRdlnNaJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZX8FzAAKCRCPgPtYfRL+ Tp05B/4yqfZ5IZZi2h6BJZmfSEXr4OSgNKGOr/3MNfLkaHsCLkJEWUTHMcy0qsug2SfL08iyUpE QakKFZs2XfR6MyCKQRLv5ghZIc6jgP4F2Sr77TQZWQx3ON5P4QOP7vJChRukz+1OI57ZUOwIkbZ 4/LUHd+X8o/mAr92zOJmpdX3JjxqoNMh3unQu0zPpdIbEu+DrJg89IUuypv8XtzVYTqektxTX9F okA21bWCJGXBWLxqI/8y3z1YmerloN3D9USxtZoEiPsyN4IPZzpjFylajsl/56NyZdDcdlLchvx otOqdLbqCCeSpGz6w+Mczf/o7pQtI0U/g/Aqalf/q6/J1xi3 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785539962481486568 X-GMAIL-MSGID: 1785539962481486568 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Paul Cercueil --- drivers/memory/jz4780-nemc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/memory/jz4780-nemc.c b/drivers/memory/jz4780-nemc.c index e5a93e7da15f..fb6db2ffe71b 100644 --- a/drivers/memory/jz4780-nemc.c +++ b/drivers/memory/jz4780-nemc.c @@ -384,12 +384,11 @@ static int jz4780_nemc_probe(struct platform_device *pdev) return 0; } -static int jz4780_nemc_remove(struct platform_device *pdev) +static void jz4780_nemc_remove(struct platform_device *pdev) { struct jz4780_nemc *nemc = platform_get_drvdata(pdev); clk_disable_unprepare(nemc->clk); - return 0; } static const struct jz_soc_info jz4740_soc_info = { @@ -408,7 +407,7 @@ static const struct of_device_id jz4780_nemc_dt_match[] = { static struct platform_driver jz4780_nemc_driver = { .probe = jz4780_nemc_probe, - .remove = jz4780_nemc_remove, + .remove_new = jz4780_nemc_remove, .driver = { .name = "jz4780-nemc", .of_match_table = of_match_ptr(jz4780_nemc_dt_match), From patchwork Sun Dec 17 14:29:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 180023 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp734054dyi; Sun, 17 Dec 2023 06:33:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IHIAXlQIdd0xP/gwk+PHw/yEXVIjle0JRUb8S0RL7Iyvwn5uCiNNJIx0BtE/CKpPPFMIy3R X-Received: by 2002:ac8:5a12:0:b0:423:6e9c:2de6 with SMTP id n18-20020ac85a12000000b004236e9c2de6mr19127946qta.32.1702823630911; Sun, 17 Dec 2023 06:33:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702823630; cv=none; d=google.com; s=arc-20160816; b=goSmuyv03cMnyyLS7wrJ/nre02rbCUauObFFUtTifVpgHFfTg96QPVD/5gXoe0gLsl ZBUw4fMZ/ufEt8JMNKHpbhm237q7qDzmSr/0K51I5r7ow/+NYmk2vue8VugWltWCuKRt 2wm22BsVj38TQIPHmrzyXHS8bD9Z6HtcomwkDpQL6a+ShJv+u4EzMS2XAvSiVfX3A2qK N6BQWetJIwQIYATUlW3YSv88ndnYU6W72HnKhb4A83wxRCxvQFOk+pNGQfC9eHsmPaYA Qo1kCluK+RuNViZOfFKhbZzXQqnAP7CnGmZ9It/hxAcF05RHWWIDJJKAiMBFtxW84sHI pbnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=ga0opQqw6aMBRbhFaZryhxhmDlP5XlAOcEoBuafjafE=; fh=gvRd4GBp98/eGTyvQlMzkAREtTHRkjXEnHHVqbSgsNQ=; b=0A5bW46P7mftEyRkP4YqUhDwMrrlUeBXIOPfvT+76hnHegiFKiboksOxgvQZNjmVQk TCq9FAAOAR340kt2MVlvdzEg+YtvlFLpZb3L1IOq5eanp4Id9POzMBz7KyLM4lPcvZRt vDE8Yc11QDIf8bo1vxwAW3fj/TzQCLuOQgxDbxv4/qiWfjG2kkcs3KW7ARrFjMPPUGbt /znXYRzpgNbf2LOz6Dt/IcTChb2kHuXzxlr4RhnwnBl7YylUcmKDHiQpYv3vkKQvSQ+Z 5M//GjFsMgzhEc2WqKti3RfN87ux30UqiECr1v1FZicOtHg6+iAjRHiPrHuo2YAoZgDI HQZg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2640-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2640-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id fz20-20020a05622a5a9400b004254852372asi22657902qtb.396.2023.12.17.06.33.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 06:33:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2640-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2640-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2640-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9F2F11C21BC7 for ; Sun, 17 Dec 2023 14:33:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D0CF049F81; Sun, 17 Dec 2023 14:30:31 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DE5045BF2 for ; Sun, 17 Dec 2023 14:30:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEs9e-0006Vz-U0; Sun, 17 Dec 2023 15:30:06 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rEs9d-00GUhR-Fv; Sun, 17 Dec 2023 15:30:05 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rEs9d-004hzH-6b; Sun, 17 Dec 2023 15:30:05 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski Cc: kernel@pengutronix.de, Yong Wu , Matthias Brugger , AngeloGioacchino Del Regno , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 07/15] memory: mtk-smi: Convert to platform remove callback returning void Date: Sun, 17 Dec 2023 15:29:33 +0100 Message-ID: <5c35a33cfdc359842e034ddd2e9358f10e91fa1f.1702822744.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2760; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=nsC7YSob3OITdlCeKMTdDVDTrdjo8YuTORSn8Byw9y0=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfwXN3/e8ieYkjMi1tAYZQl77ONh52chbRYAon ZmqHfYltDOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZX8FzQAKCRCPgPtYfRL+ Tjm+CACaZe3fPNzfsFwX+VFxbpC0VXkBNDQp9G105jLOUAwYeNwMsNtQ8Ra7JbD3v/yciHSQC2k c2jN3f0dxUetCqeD3DbanuNuWKI2zJK5cgooyZ15CSK7RE3QsRUIFZpLOe/PgvEgCDo/6olp0VA 7UmbglPSPG/5ij8OPj6IEtinJCbK+p/nWAFvgBAE5EWXjY8mwH+3yl1bOWLD02aDQJ/ohcP4TuN ZZoEeLsxnJIttB6YjR1X/Y7KNJ3jvru9dDQQrAKK/GPfEfMkTH/HiSY6j/IM2fklHsBrvCu1hZF 3XhZLrsbdJUCcj2kGx+9zBnT5m7DIJYxOnImrnhE/aNZjIF6 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785539991959171213 X-GMAIL-MSGID: 1785539991959171213 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/memory/mtk-smi.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c index 6523cb510518..572c7fbdcfd3 100644 --- a/drivers/memory/mtk-smi.c +++ b/drivers/memory/mtk-smi.c @@ -566,14 +566,13 @@ static int mtk_smi_larb_probe(struct platform_device *pdev) return ret; } -static int mtk_smi_larb_remove(struct platform_device *pdev) +static void mtk_smi_larb_remove(struct platform_device *pdev) { struct mtk_smi_larb *larb = platform_get_drvdata(pdev); device_link_remove(&pdev->dev, larb->smi_common_dev); pm_runtime_disable(&pdev->dev); component_del(&pdev->dev, &mtk_smi_larb_component_ops); - return 0; } static int __maybe_unused mtk_smi_larb_resume(struct device *dev) @@ -616,7 +615,7 @@ static const struct dev_pm_ops smi_larb_pm_ops = { static struct platform_driver mtk_smi_larb_driver = { .probe = mtk_smi_larb_probe, - .remove = mtk_smi_larb_remove, + .remove_new = mtk_smi_larb_remove, .driver = { .name = "mtk-smi-larb", .of_match_table = mtk_smi_larb_of_ids, @@ -795,14 +794,13 @@ static int mtk_smi_common_probe(struct platform_device *pdev) return 0; } -static int mtk_smi_common_remove(struct platform_device *pdev) +static void mtk_smi_common_remove(struct platform_device *pdev) { struct mtk_smi *common = dev_get_drvdata(&pdev->dev); if (common->plat->type == MTK_SMI_GEN2_SUB_COMM) device_link_remove(&pdev->dev, common->smi_common_dev); pm_runtime_disable(&pdev->dev); - return 0; } static int __maybe_unused mtk_smi_common_resume(struct device *dev) @@ -842,7 +840,7 @@ static const struct dev_pm_ops smi_common_pm_ops = { static struct platform_driver mtk_smi_common_driver = { .probe = mtk_smi_common_probe, - .remove = mtk_smi_common_remove, + .remove_new = mtk_smi_common_remove, .driver = { .name = "mtk-smi-common", .of_match_table = mtk_smi_common_of_ids, From patchwork Sun Dec 17 14:29:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 180025 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp734453dyi; Sun, 17 Dec 2023 06:34:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IFdNaXvyHsYpgP8vckmp35ERMukjMbyKlxJr26xLeqHYbB2f/kdXlOKoKFao4SRC8aGFttm X-Received: by 2002:a17:902:aa81:b0:1d3:b56f:6bb5 with SMTP id d1-20020a170902aa8100b001d3b56f6bb5mr52911plr.125.1702823691094; Sun, 17 Dec 2023 06:34:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702823691; cv=none; d=google.com; s=arc-20160816; b=FNDIjkJmz/lBeNAgRt79H3XYijMS+W4f1baPv173N+YiSdnnaM14EY73Wgo5Dp9z8y /IVKMIPynZ1Xt6y9dmtdNhhFgb+o/np4pbtB4u0M9vYaJnhunzOjFlvCrXE3/EctO4kg /m8cOgq35jfmzgMe5lc1iUHv/CFULPiYwDoKSLkcAasygvzQuu7UJINZOvMxHKHpm/g8 JQsY7r1G3tiIRaytogNAxE8m8AUKTWJLGa1+borKvbQAhYv4L3BcGASbJSeyiDR/MDrI igq1mWv5DMceuaiDVW+dl5gwCTQX1RSGQuMjbSNOCd5gZVsrVTb76Ss3UgLkzYO4p8uM yVHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=4phpusBQwKGH9t+hgPp/aOcodI7NtceLvsCWs/+tag4=; fh=1gfYtjOmURxcFEHxqbElbYdMxHfwWtZ7kIeCAJqFxCg=; b=V+5rrkiJl9x2F4Hzm/thNiwNZHnxhyKlCyvaDfWDFzOoL0dwGt0kso8mXezO3ZfyuS ARIDaH0uqAg1nLGddgbqccyT0ttJ8K8fKvDLZBrxeJgxgDNW0mzkWfJcPYeAeBjzBYtw 6nKxk/4b+kudejRI5TVjPvzsZNSGhcXEz0PhiM4Lp8cUFlYIVHp+v3Pn0STUDsYLJO7v iRbqQEjO2SbMf3pLToHH2yCSV2Dt2sdVLoeVh5x3DlFyyYZTXq38VIZ7utdgoEmBVPGc dquslR9CxIfHWlhJY8Hd1573jC3uRB3flp8caB+zGM1Xu43+w8IKKjGYfCmec0M6eunM oXJw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2642-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2642-ouuuleilei=gmail.com@vger.kernel.org" Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id s18-20020a170902989200b001d39e517fb6si364855plp.296.2023.12.17.06.34.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 06:34:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2642-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2642-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2642-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 270ACB2272B for ; Sun, 17 Dec 2023 14:33:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 47EEE4B144; Sun, 17 Dec 2023 14:30:32 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6855646445 for ; Sun, 17 Dec 2023 14:30:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEs9e-0006W7-5x; Sun, 17 Dec 2023 15:30:06 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rEs9d-00GUhV-Lt; Sun, 17 Dec 2023 15:30:05 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rEs9d-004hzL-CW; Sun, 17 Dec 2023 15:30:05 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski Cc: kernel@pengutronix.de, Roger Quadros , Tony Lindgren , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/15] memory: omap-gpmc: Convert to platform remove callback returning void Date: Sun, 17 Dec 2023 15:29:34 +0100 Message-ID: <019d9dc31af9b30a6b675fec219e64b667475efd.1702822744.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1813; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=U5CGeCdz6QSAvrFQlhj98hj1wRRaTXzuJdwPMd0OWnY=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfwXOgeJ/I+MLCCzaRR2S0hAuUidKX2H7fnV+l jyp10wIe56JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZX8FzgAKCRCPgPtYfRL+ Th6oCACtPZCoIo+uH4FSx41yvLOR8wWQbzWGm9FpXYZXVzaWiiGYx6ommIRZqHHnhfz8L/bsbOJ /L6QVHQUGm+FaQFwgHndv3F0h30XiAbDgT7+z+7WSo8fntdsBhUJPgfjcI4TNt4Avcjt0cMf36j nJ23HdfmZqiQm3psRAgSdfkGn8FjYu+6KeeBqC/1asWM0dHPj041s24BJ52kZfif8R8fwE0VWbr h+/zdtOCNgWAE8TndXGCrkz9FbNpD0d0EMBpUnkMZfDmK+4qKVIqD/Cj7HuoQc6cJLsL+4reqzV UilU2v/he3wH8BxMi2LOUcFhFqg6cbMvAF0VVyIeUucdVK11 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785540054702337102 X-GMAIL-MSGID: 1785540054702337102 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Tony Lindgren --- drivers/memory/omap-gpmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c index d78f73db37c8..80d038884207 100644 --- a/drivers/memory/omap-gpmc.c +++ b/drivers/memory/omap-gpmc.c @@ -2690,7 +2690,7 @@ static int gpmc_probe(struct platform_device *pdev) return rc; } -static int gpmc_remove(struct platform_device *pdev) +static void gpmc_remove(struct platform_device *pdev) { int i; struct gpmc_device *gpmc = platform_get_drvdata(pdev); @@ -2702,8 +2702,6 @@ static int gpmc_remove(struct platform_device *pdev) gpmc_mem_exit(); pm_runtime_put_sync(&pdev->dev); pm_runtime_disable(&pdev->dev); - - return 0; } #ifdef CONFIG_PM_SLEEP @@ -2747,7 +2745,7 @@ MODULE_DEVICE_TABLE(of, gpmc_dt_ids); static struct platform_driver gpmc_driver = { .probe = gpmc_probe, - .remove = gpmc_remove, + .remove_new = gpmc_remove, .driver = { .name = DEVICE_NAME, .of_match_table = of_match_ptr(gpmc_dt_ids), From patchwork Sun Dec 17 14:29:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 180017 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp733589dyi; Sun, 17 Dec 2023 06:32:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IG/GpJI70YldM9i0NgXvQtCixKvp+/R1OsqSmo0IOMXnnT8VwxA07JnxZ/bVXKBS6sUu1DD X-Received: by 2002:a05:6a00:3099:b0:6ce:6b7c:ba1b with SMTP id bh25-20020a056a00309900b006ce6b7cba1bmr13265872pfb.60.1702823569719; Sun, 17 Dec 2023 06:32:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702823569; cv=none; d=google.com; s=arc-20160816; b=N2u5csfg48J98jN4ZOXfadPR7/MfcAFFysLwZpee9hr+9WFt2jHZHGq9MZRMZr/uVS vmtR4rHt+30EVDGbUjh8UBtR+D0LKDQzl6/AkR/NNihw50SkplE0iEotxeGA+71YNGxn vuo+s8pDE5hQr0sGL6HidvW6veEdnTefCvE3Nr1Jc7YFbdwMSnBNDVq4V56kP2l17R5b ob0LDiwxM7aDjbSvDPbFRZjD3Mr1UUtScIbq/MBuHQkD5pGIvOa01lxMzkoTzjQlWw1u 9UYmvKpH/b6ah1K2n3CWCDkw+hqPzHLJgOkYeFMAJCSTr5Jt54T1QFjvzbLSQ45u3aBq GuaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=QHArEJAR8+lz3+RtGspIM0u+Mn3j/hP8FpMKesgZ7oU=; fh=e08qmhSPRKoDoCS9mOXl3SU+TueaIFtaf9hHDo9WBfU=; b=U1Y76tRJ9oW3Ldf80yMfrsi70Rsgd3r6ZfNGwpJC7sxeVFlVtpSkQWDCyRQyy6NqVi Bi8APKh5buq5lsOceShTzrHms2hOkmxbIecR+kqKGhS1fT2tyn/GMMha0IEWpaxHjMgR 5SI06ZzxtDkBzqrzwGA5jebVU0Mo1ymXKjUFCOzIuDZk5NwlBsGd8bFjA0sgzhJAwv+n 4ewyH1CiIl63SfLUtV6Xd+iiNcxYRrCzzn38EfGvRwP6FUlVFhKg1tXOknhGuSscinA/ nUX42PTNdpK42tWzA4Lsd9WChQ4E7JCcfXYizFUVgYNOzpiXIgWY30X97zX+qZBgJsSZ O/6g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2631-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2631-ouuuleilei=gmail.com@vger.kernel.org" Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id u7-20020a056a00098700b006d693cb47b5si695536pfg.335.2023.12.17.06.32.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 06:32:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2631-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2631-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2631-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 5D36AB22205 for ; Sun, 17 Dec 2023 14:32:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 65DE7481D7; Sun, 17 Dec 2023 14:30:24 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5401444C8C for ; Sun, 17 Dec 2023 14:30:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEs9e-0006WA-83; Sun, 17 Dec 2023 15:30:06 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rEs9d-00GUhZ-Ri; Sun, 17 Dec 2023 15:30:05 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rEs9d-004hzO-Ic; Sun, 17 Dec 2023 15:30:05 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org Subject: [PATCH 09/15] memory: renesas-rpc-if: Convert to platform remove callback returning void Date: Sun, 17 Dec 2023 15:29:35 +0100 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1725; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=ZMDbiRa3FGTihhO4tO5ODGE29OSsGDt4kVGBu1a2R44=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfwXPj3UhNZgDNyg4+9bkx2WCA2L43Uy2kWkf2 vpluzZRuM2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZX8FzwAKCRCPgPtYfRL+ TiKUB/9qljxV2MeMzDUCTbF/CisoK5J7jGBMJKNKmSczc/ZId0wNcKIE/ZII9SiOa0sXgMqooq2 hdXWYXREWg4OuL+Q6yATWPNRJbgu8AcnTbBzxW5mdOnDUVjyH7XYjNdBeoddZQ4pO/c7GDbsJA9 9CXDI67v2k0lSPlOdxGxcw5FHk4jIV45aIdEVvr3YMxoAsM8TkKU8GU5hEyushutaxsNLJybyK5 06XicsJma81Z0Pxc/yJoTw3FJGgjhPQhkJyYpMPnHsEkDeSgQWmeJ+em1rCWYx+ldaoogQ+12FC 6oEs0QakXakB0gOgxA88WgRQdXWMH+NxXbJ/J+AYFLn9x/mv X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785539927618166323 X-GMAIL-MSGID: 1785539927618166323 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/memory/renesas-rpc-if.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/memory/renesas-rpc-if.c b/drivers/memory/renesas-rpc-if.c index 9695b2d3ae59..3167826b236a 100644 --- a/drivers/memory/renesas-rpc-if.c +++ b/drivers/memory/renesas-rpc-if.c @@ -777,13 +777,11 @@ static int rpcif_probe(struct platform_device *pdev) return 0; } -static int rpcif_remove(struct platform_device *pdev) +static void rpcif_remove(struct platform_device *pdev) { struct rpcif_priv *rpc = platform_get_drvdata(pdev); platform_device_unregister(rpc->vdev); - - return 0; } static const struct of_device_id rpcif_of_match[] = { @@ -797,7 +795,7 @@ MODULE_DEVICE_TABLE(of, rpcif_of_match); static struct platform_driver rpcif_driver = { .probe = rpcif_probe, - .remove = rpcif_remove, + .remove_new = rpcif_remove, .driver = { .name = "rpc-if", .of_match_table = rpcif_of_match, From patchwork Sun Dec 17 14:29:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 180024 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp734172dyi; Sun, 17 Dec 2023 06:34:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IFS9E2lL+6aPPEmc0MYmdJa1966hMyvs8jcg32UpWnIkqAb67QzdchFDF+VdNuVcNwU8REr X-Received: by 2002:a17:902:ecc4:b0:1d3:6b17:67c0 with SMTP id a4-20020a170902ecc400b001d36b1767c0mr8133313plh.75.1702823650025; Sun, 17 Dec 2023 06:34:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702823650; cv=none; d=google.com; s=arc-20160816; b=OuXcv3MgXKWQK3VhgvQyyNlr/pzTIF/mqHJ3N67BcrZiwfZIJHcKzR39b6+i92htqg YpvLiy+ilxUqa6Miq/MMRYbkIW+UkQlHigqS8XmiOUyo1T7N9ebEtt3XVo99nyK2y2Dj KKT4lCs5HUkVDC+SiNFxB+LAM0G5juYqsBQyyfgQpbqvE54yHokuPkKNYCtg9zjeaSFZ quCNo7rUPVXo6qekuMUFlFbtn2FhcAThpeM/1OsrlqpEgdL1FzAtKlvuCDMhXtN42dAL uYYqvOCwDDaTVCq/Z8xId/rZmQZBqFSAQKmPLWdcLautK0PqM56Jr+aLxc/KOFL81fNT oGOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=13p/Z9F86ysTjv2l6IYK0yp34bloKdsiygttu0we62w=; fh=h/JrvC6H7D+ow/Q7jWN7cfcRg2QLdrKsFz5Knf1GuxY=; b=yeG34y855SmyBtxEANfKRBhtbc09Hp0e2jtJY8UznP6nM4d4cO1e+U19E05CnXecpG jMHUEgydz8kbrzUtrLveNf7guq5GB7TqWnr9pFcVZCLjbasmmXoCuVk2j7ynR0XxpVld 3sMIkyZBBo46pfj/aPhlBegJ0F3k773aYcWwe/oIV4ghMbRJ71CzRnX0BVJH8pOmuMre kjIz/IpKuf49prNr+vrkltZ9Xdy/lqT7gJ72UpdXnlrIVUJInKNUXyrFdDW5of+FlS2L iUv3eR4RwlL6izOje0VkhuAiZIdW3pGMhgORHAfUjsybacHYraJBfFpj4ZMwA13UHP6x dSTQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2644-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2644-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id o1-20020a170902d4c100b001d0cc15ffddsi16348973plg.154.2023.12.17.06.34.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 06:34:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2644-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2644-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2644-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5264E288E54 for ; Sun, 17 Dec 2023 14:34:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 44D6F4B155; Sun, 17 Dec 2023 14:30:33 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70B7746545 for ; Sun, 17 Dec 2023 14:30:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEs9f-0006WW-9b; Sun, 17 Dec 2023 15:30:07 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rEs9e-00GUhc-2u; Sun, 17 Dec 2023 15:30:06 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rEs9d-004hzT-Pr; Sun, 17 Dec 2023 15:30:05 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski Cc: kernel@pengutronix.de, Lukasz Luba , Alim Akhtar , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 10/15] memory: exynos5422-dmc: Convert to platform remove callback returning void Date: Sun, 17 Dec 2023 15:29:36 +0100 Message-ID: <167dbda286584eafec07da8c11673da07ba72362.1702822744.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2061; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=FHOjgtzRIN9XHjUcxCP7MGMz7yRB1JuZQ6LGi2PE66k=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfwXQmW+Q6PEK4vacr/EoUiA1qF6qrGQu4k8BB 9+ceA0cHFWJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZX8F0AAKCRCPgPtYfRL+ TibiCAC1uo4RR6+/cFLGqWwewyu7CjBqgCgdaQNtmQtdcpP2BuwkSLign+vU7FxZOYvzOomdeb7 Kbha57cN1prbQpTJKp03UX5Y1TyYuVy9YkkPh+Ac2Xi2b98vREFLjfHkN36A2dnfUjLBm4v34+7 vE1YzF5TRy+eKezWaP/iCLmnv85eU9Sn5FMf6SYKYcOEWOuesQzWE+LzP4pM+h4Qsu7IkMOMtgl Hp8SNhDVJklZXTzVGDXH1qQETrw545SnVH1mjxL044eXLlp+mYtBnJhB160GOkhvLz6Z/jZmBgh 50xvY3amw2c7RHVnhGLOYfeiqWmVuYPjiebx2NauufYrlzb+ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785540011921225646 X-GMAIL-MSGID: 1785540011921225646 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/memory/samsung/exynos5422-dmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c index 6d019dbd721c..da7ecd921c72 100644 --- a/drivers/memory/samsung/exynos5422-dmc.c +++ b/drivers/memory/samsung/exynos5422-dmc.c @@ -1558,7 +1558,7 @@ static int exynos5_dmc_probe(struct platform_device *pdev) * clean the device's resources. It just calls explicitly disable function for * the performance counters. */ -static int exynos5_dmc_remove(struct platform_device *pdev) +static void exynos5_dmc_remove(struct platform_device *pdev) { struct exynos5_dmc *dmc = dev_get_drvdata(&pdev->dev); @@ -1569,8 +1569,6 @@ static int exynos5_dmc_remove(struct platform_device *pdev) clk_disable_unprepare(dmc->mout_bpll); clk_disable_unprepare(dmc->fout_bpll); - - return 0; } static const struct of_device_id exynos5_dmc_of_match[] = { @@ -1581,7 +1579,7 @@ MODULE_DEVICE_TABLE(of, exynos5_dmc_of_match); static struct platform_driver exynos5_dmc_platdrv = { .probe = exynos5_dmc_probe, - .remove = exynos5_dmc_remove, + .remove_new = exynos5_dmc_remove, .driver = { .name = "exynos5-dmc", .of_match_table = exynos5_dmc_of_match, From patchwork Sun Dec 17 14:29:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 180029 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp737703dyi; Sun, 17 Dec 2023 06:42:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IEoUE8DZhoe4JJl2WLgEESGnK+a3NsISaCGdldRZL29ORQOGGXNxrNk+lF8nT/r8OuvPYMt X-Received: by 2002:a05:6e02:388f:b0:35f:8772:fa07 with SMTP id cn15-20020a056e02388f00b0035f8772fa07mr6817422ilb.11.1702824167465; Sun, 17 Dec 2023 06:42:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702824167; cv=none; d=google.com; s=arc-20160816; b=jYB9ZyuwrEGWaWarIoBP+Ycq5Nw4sxZbezaSc4QSSPqw13oLTftI+PDjD9kX4pA19Q ggBHwgczsSoHKQVBdSGEI1p9idaJOkQKckV2sQKyYU4QVl9oSinQUFVQfV070FiWK1AL QpLg2na5ssCnqfMI6C7IkZk2ugaco9Cb9Gruc7XyQUwGH/lm+N4X4OtoBiKFGijeotuB cKUv13J201FApLup6suk+6L6p7SFB2IxglbYPy1qs2DtMzre4CL8IXe98aFj1XJHkeEd HfiKvhiK4VOtp993fQZAsHX43iuvLzPaHAFf5J0lXB631Tj87F/LssIBRX5YEtFTLDt7 8azA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=ZMMSE/gieMp/4VORIwYJq30Vct+ri6LLM53M0tCtA1I=; fh=43rHCPEkXfTbQ+MAABzAzTMOy3+Ll+6Gis5+3Sv+zJs=; b=dYy8zKRsmCBOB0nu1WISPFwRx5T9c1IfCgIsLSDn4+Q35hEsSV9i6qTKoj49QVOxt8 6U+Hcrf2HDZmb1cV76uPgKQFw1I+zdHOiqU4VaOToeTi/IaG7//DzfVk8/kuZF3Mu0Z3 K/BVF3+gikC9peEHYwQ70K4/TjCO1KHK+H4TvNLZbFl5fbf5DXuvt7V/2Cd1hyBVXbIG 9zLMcdjDPnVCJJeZbIEA+l5z2Wk3GmrtZEKCUV0KDTiHYLrjiT1Y0RhaWkme7bzLS/Sd DL5i7Jnz3t+OoYNdhWaT24rViB33rhz3MybJ7Fhs1Fgx+HsA78QAxoe6mugjpxhBs4oa 539Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2641-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2641-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id w13-20020a170902a70d00b001cfb4bd0b83si16256867plq.439.2023.12.17.06.42.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 06:42:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2641-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2641-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2641-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 12F75288B15 for ; Sun, 17 Dec 2023 14:33:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 06FB145014; Sun, 17 Dec 2023 14:30:32 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CE9A45BF0 for ; Sun, 17 Dec 2023 14:30:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEs9f-0006XQ-MC; Sun, 17 Dec 2023 15:30:07 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rEs9e-00GUhg-AA; Sun, 17 Dec 2023 15:30:06 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rEs9e-004hzc-0q; Sun, 17 Dec 2023 15:30:06 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski Cc: kernel@pengutronix.de, Maxime Coquelin , Alexandre Torgue , linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH 11/15] memory: stm32-fmc2-ebi: Convert to platform remove callback returning void Date: Sun, 17 Dec 2023 15:29:37 +0100 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1981; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=vnXMNpPc4CNH6yHCGy/VEkrbe/7SkdFU6zjQKAFNmw4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfwXRzgYeIa1M6T02trXcwbebDDAXRteH/aASJ EIeTmDpO4CJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZX8F0QAKCRCPgPtYfRL+ Tlm4B/9oZRXDNti3I91lE3SnU/Anh5vxwqoEOcMKmojlJ6DMKjre9S0FWbf7LQ6tIOgJChGdJfI 5DJb4OZKt42SL/tFDSzqh/EIvKdDcV6WF4wuBJzQFCqTE7aRfQOmeuQZPVa1gyZwV44OR23niIj 4I10JoIIcuAKjKIWXa8Z4H/lV/048Q8W1IMiMvPG9bGFpkim7ypa/edmlbt5Nt49YU7qZB2+1/b GOxAwmrXq8yWvc3cKNRiNHA3xmgZtva1Q5qt8yg7E+rUC1yhzKYW5MJBy4UAipDxk5R9ZZv5k5s HJuw65+ON7MO74lTZicb9ZGvxEyXS8f+od6/Urr+eAKk7vEd X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785540554704458661 X-GMAIL-MSGID: 1785540554704458661 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/memory/stm32-fmc2-ebi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/memory/stm32-fmc2-ebi.c b/drivers/memory/stm32-fmc2-ebi.c index 9015e8277dc8..47d0ea5f1616 100644 --- a/drivers/memory/stm32-fmc2-ebi.c +++ b/drivers/memory/stm32-fmc2-ebi.c @@ -1146,7 +1146,7 @@ static int stm32_fmc2_ebi_probe(struct platform_device *pdev) return ret; } -static int stm32_fmc2_ebi_remove(struct platform_device *pdev) +static void stm32_fmc2_ebi_remove(struct platform_device *pdev) { struct stm32_fmc2_ebi *ebi = platform_get_drvdata(pdev); @@ -1154,8 +1154,6 @@ static int stm32_fmc2_ebi_remove(struct platform_device *pdev) stm32_fmc2_ebi_disable_banks(ebi); stm32_fmc2_ebi_disable(ebi); clk_disable_unprepare(ebi->clk); - - return 0; } static int __maybe_unused stm32_fmc2_ebi_suspend(struct device *dev) @@ -1197,7 +1195,7 @@ MODULE_DEVICE_TABLE(of, stm32_fmc2_ebi_match); static struct platform_driver stm32_fmc2_ebi_driver = { .probe = stm32_fmc2_ebi_probe, - .remove = stm32_fmc2_ebi_remove, + .remove_new = stm32_fmc2_ebi_remove, .driver = { .name = "stm32_fmc2_ebi", .of_match_table = stm32_fmc2_ebi_match, From patchwork Sun Dec 17 14:29:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 180022 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp734007dyi; Sun, 17 Dec 2023 06:33:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IGi5wXGdVr5zDyWbNZxNVId6WdpD+KaKTKKTkgvczaDJmT69OeATfbuFiXJ5w0omcNYIpvl X-Received: by 2002:a17:907:9729:b0:a1e:eebd:ecd with SMTP id jg41-20020a170907972900b00a1eeebd0ecdmr16879305ejc.32.1702823624857; Sun, 17 Dec 2023 06:33:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702823624; cv=none; d=google.com; s=arc-20160816; b=TOwozKR6z1/Ps0UtsweBjBfosnZTuJWXbahj6BFjdWojBJmDabRk77TE80LGXMRYgy MAMn2DuXC1nqAUvyZqfyGyW8Y1cDZfW6sWghh4B6OoHdukWw6pqgitKZKAuHDYKNLojm 4hgwCjC/Tbkf26QTozFBy5XC4hkoK2J0SKzLhmJs347vB1FXSkl8gyyzlI3MHagYBJKg FtvxV9AOotAhpsHKasG5N539f/knPxvl6XGH9XjnsBzJr4aP2UMOunnPB5Jca7WlN+ph vjEROP7Y13KV4NDTXU+oufV5B5xUWLdQ/awTGG0jjW4ie4FE6AjXaNOAShMof/gX+3mQ zt3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=2l6rUO3FU57LU2ByRE7nn777CLXoHS0K7lXnMkMnTBc=; fh=Gq4Q8RtlSH//4ogwlXh78nnzRJBNHDuZfGFnJVtTxgk=; b=QtVI7BwZSRzhThXEjYKgT62L2P6ez229ckmiWAIogazILqCta+7jTg2Tp2Yl274XhA IP/jHseVS9WRptWrKh8GPTSSAWEokQREt7ZcKWVtvOY60OYcmxDW8K9GAgRf1h60j8J8 pk5/0XwA7S1rl1oSYtlf7QvNXIy/uvOPt/W8Mq6YUKpa8eICllmcOnnn2ULJ7r5To0sf 2rABdeCtY4MS+vyRRAgaNpKQCJ5xOo8nPI2rQZqYE0m3qMBn7mpceIERl1lNLzM1HgGv BTX9mCSOjskM2oySQFn4mvO95g3fD2HiaTh3+1StyiKv9J/5Kr46/y75tPFqKfEvb1s/ TVag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2637-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2637-ouuuleilei=gmail.com@vger.kernel.org" Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id qx14-20020a170906fcce00b00a232a3229e1si1224368ejb.529.2023.12.17.06.33.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 06:33:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2637-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2637-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2637-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 756491F220AD for ; Sun, 17 Dec 2023 14:33:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 399F14B130; Sun, 17 Dec 2023 14:30:31 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57DDF44C90 for ; Sun, 17 Dec 2023 14:30:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEs9f-0006XT-NU; Sun, 17 Dec 2023 15:30:07 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rEs9e-00GUhk-HB; Sun, 17 Dec 2023 15:30:06 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rEs9e-004hzg-7v; Sun, 17 Dec 2023 15:30:06 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski Cc: kernel@pengutronix.de, Thierry Reding , Jonathan Hunter , Sumit Gupta , Nick Alcock , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH 12/15] memory: tegra186-emc: Convert to platform remove callback returning void Date: Sun, 17 Dec 2023 15:29:38 +0100 Message-ID: <8481c7e7d5b024325e6b1aabf7cb3a3707d211d6.1702822744.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1927; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=8/pftyzoFtmGA6p6jcaOA6JIc1RRi2neeGtIXzu26sU=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfwXTkEYXXtmYxZ4s8+U/GoL3SKSKZkW9evRbN GNv9diXtaCJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZX8F0wAKCRCPgPtYfRL+ TmZ3B/wJqToPNYpxaErGUho2q1O5sv/fIn6IWr3tr95NscNpSGNq98icF5USm3P5n1jy5oK88H5 YAQSlahvOmYs3rlGOim9tJoxC8ItfqRb/3iRX6qQGuZNw1Cc2JLO5LSJTUwW93w8XhpJ/5bULki krUehMq8ikMVSaZW3KbOp6KmNOeb5XcSZvDAZG8BOsEs6rnyGCH024RseHZVmIsR23awOUiW2Yb MQTegUYdZs/1HF0lmqThU3+P2nSaTP3hFGNZg/PQs8jrZlUdrLS4v0rlEznJwT4uX/7mXikD8Fs 3A+Mud6NvEvfG5kelN5c+20Hev2uWwabIDmkMFzMf9eCMY3E X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785539985230291028 X-GMAIL-MSGID: 1785539985230291028 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/memory/tegra/tegra186-emc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/memory/tegra/tegra186-emc.c b/drivers/memory/tegra/tegra186-emc.c index 4007f4e16d74..fcd4aea48bda 100644 --- a/drivers/memory/tegra/tegra186-emc.c +++ b/drivers/memory/tegra/tegra186-emc.c @@ -378,7 +378,7 @@ static int tegra186_emc_probe(struct platform_device *pdev) return err; } -static int tegra186_emc_remove(struct platform_device *pdev) +static void tegra186_emc_remove(struct platform_device *pdev) { struct tegra_mc *mc = dev_get_drvdata(pdev->dev.parent); struct tegra186_emc *emc = platform_get_drvdata(pdev); @@ -387,8 +387,6 @@ static int tegra186_emc_remove(struct platform_device *pdev) mc->bpmp = NULL; tegra_bpmp_put(emc->bpmp); - - return 0; } static const struct of_device_id tegra186_emc_of_match[] = { @@ -413,7 +411,7 @@ static struct platform_driver tegra186_emc_driver = { .sync_state = icc_sync_state, }, .probe = tegra186_emc_probe, - .remove = tegra186_emc_remove, + .remove_new = tegra186_emc_remove, }; module_platform_driver(tegra186_emc_driver); From patchwork Sun Dec 17 14:29:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 180026 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp734503dyi; Sun, 17 Dec 2023 06:34:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IHVt/TKTGzrIfGF3a9W2DdRySZn1c4i1TsyU714mLG4WzJ13G3KAcVzVU2W9WFbBbBiW2Q2 X-Received: by 2002:a05:6e02:1c0d:b0:35f:af72:1d9b with SMTP id l13-20020a056e021c0d00b0035faf721d9bmr828663ilh.127.1702823699078; Sun, 17 Dec 2023 06:34:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702823699; cv=none; d=google.com; s=arc-20160816; b=wbcOD9oAYwKUSHWV59slXJksM/K/3MkDc8Wvkr/3bUZMKU90/jy8bLDtvKC0eQWv0f h7V73WNY66FLxCpKysAAqmckrMe8JU2siD9YXzw7gmYPYqx+U0Od8deLv+QrGJz5b7v9 dANs7bogeZE025G+x2dSkyDLsQrrhw0u8I7es9muc0I28hl251ZLeyTKlUECZPzaHE9Y hyO3gfetYzxHTXb+lqR6O30oj1Wpy2sl6481IUbU4JEokq42kttvhfcNVEoPMkwWtL6g Qg+ZO4maeEggZSE4bMg9CrBijiA9LVPU4kOPjAbidteLW7yteZKUZCrZQVIUKb2kXLgn fh6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=iiXVnUOpVQilQIWOO+65bUFbNTweck1K2hJVmqsHEGE=; fh=0chRuGPFzrQz3xfHA/HszxMAL9+QTc+wVvcsMLE+/iI=; b=VZMBMBWwF+otPSxNQlTj9H6Vp2H0shyJfK2SvJiSBXPrHqdhMlCyhYc9MKnTBQxOan VICpv4tdR8jcauA8/4T7FPW7aaCj+UmGp+eVPcLwSTNGxlQAo0UlAuev2UF2LsNKgnYv 8E4XMb5zs2A7XknT6UOrnQNlPZrCAL9m34ni9TtvHgGBqJ7eE7VqI53zdPmItFRHcDZL pqf7Dk89TA3m01xs4ACsWzXm19p0hYt4DtqETONaDMxUCfvWHDgAGYjNEan7OkU6tr5e tNcOBH8Kcig6UJsSAhOoIaBnyzy2Pxc9YM3iLfkx0eu/GkZFG+9paTfg5i23WVzrfFwn UqPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2643-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2643-ouuuleilei=gmail.com@vger.kernel.org" Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id b14-20020a631b4e000000b00564c67e66fbsi16358330pgm.842.2023.12.17.06.34.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 06:34:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2643-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2643-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2643-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 8E971B228BD for ; Sun, 17 Dec 2023 14:34:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A1CA6481C7; Sun, 17 Dec 2023 14:30:32 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E3E046453 for ; Sun, 17 Dec 2023 14:30:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEs9f-0006Y8-By; Sun, 17 Dec 2023 15:30:07 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rEs9e-00GUhn-Nz; Sun, 17 Dec 2023 15:30:06 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rEs9e-004hzk-Ef; Sun, 17 Dec 2023 15:30:06 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski Cc: kernel@pengutronix.de, Thierry Reding , Jonathan Hunter , Rob Herring , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH 13/15] memory: tegra210-emc: Convert to platform remove callback returning void Date: Sun, 17 Dec 2023 15:29:39 +0100 Message-ID: <3e2951685dddbc0ab32244916a9849af206a6730.1702822744.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1901; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=bGdyoxMNmY/bbwpr5SN+sb3K9b9jnZzp/Hcxotdsv9Y=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfwXUZZG5GWUBTUeLiKtuoBiiZylSrm31PtSWX 94NiU6Y59uJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZX8F1AAKCRCPgPtYfRL+ TgCOB/0dPqf5bYKYlXnyRskNAJ2J1KfXnjmdTEdDVhDx7V8W651gEkJ9kWcgIzMMPe1kNm9w/MY /FZWlvbRm+V21imJBp+IdlVEXmodVoxUIwNOuZcKHz2yP/OSnVf8zfhKPorwXKlH/wT/INl4zzj +Pp7/rJ8FcK4/aCw0fdDYKFlGNvaThJQ4VOY/UeHWvqjAnhYDzc/gNwlbV0mKnaiBA9aaJV3neO ++YWHaihxoT0q8mH8WePbRn7Xf1x6AvpL/1VSfbvIXOmGixnJk50Zj8A5ci7txtFmrLqJ3yTTg1 gM3wuXnlc82ARyW0RhkX1kgKKS5rMIX9fyRC7pAkdkeMOsaI X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785540063367070514 X-GMAIL-MSGID: 1785540063367070514 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/memory/tegra/tegra210-emc-core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/memory/tegra/tegra210-emc-core.c b/drivers/memory/tegra/tegra210-emc-core.c index 3300bde47c13..78ca1d6c0977 100644 --- a/drivers/memory/tegra/tegra210-emc-core.c +++ b/drivers/memory/tegra/tegra210-emc-core.c @@ -1985,15 +1985,13 @@ static int tegra210_emc_probe(struct platform_device *pdev) return err; } -static int tegra210_emc_remove(struct platform_device *pdev) +static void tegra210_emc_remove(struct platform_device *pdev) { struct tegra210_emc *emc = platform_get_drvdata(pdev); debugfs_remove_recursive(emc->debugfs.root); tegra210_clk_emc_detach(emc->clk); of_reserved_mem_device_release(emc->dev); - - return 0; } static int __maybe_unused tegra210_emc_suspend(struct device *dev) @@ -2053,7 +2051,7 @@ static struct platform_driver tegra210_emc_driver = { .pm = &tegra210_emc_pm_ops, }, .probe = tegra210_emc_probe, - .remove = tegra210_emc_remove, + .remove_new = tegra210_emc_remove, }; module_platform_driver(tegra210_emc_driver); From patchwork Sun Dec 17 14:29:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 180018 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp733697dyi; Sun, 17 Dec 2023 06:33:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IHQ8JQIywtt8DppoNUQPCG6t7z4zlx4v7oNW9kmWWJDvs5lAbGE1zsc22J+8Lf2qBOgYJ0o X-Received: by 2002:a05:6512:689:b0:50d:1968:9f8e with SMTP id t9-20020a056512068900b0050d19689f8emr10191311lfe.100.1702823582010; Sun, 17 Dec 2023 06:33:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702823581; cv=none; d=google.com; s=arc-20160816; b=sXKL760kYe0o84+8uwmrop/m4mar6p7REaKGHsrYzB+O/4b3jPMPwPY7+hhEiri7ay UluowxF9HkjVGO7DIMMLZv+gmYoFY+AEe2owgBDbxRD1nlz5rDxWaVUhw41h6uLXLla8 EHWCdKk3HZ1JjapFemrIJMlH7apoDvu3k/g0nXh8Lwt8IRnalJdDRtNGc38KMcRfMZjd PfazUaYHw6XvtAqAhpmggHhd2CA9lrCRK01LTdirSnh/ym6SuManhbLbQeLrYvqZVrjE An+nu4Q009xhbdk4IPc/R4QTmdUfXtpQDiz9it5aanLKtfJnvYer7dkrk796cEOTzSOY ppQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=M8xNehV5dINDSUuzMoFijoGsrV/QFTAnUKR5BmQmwPE=; fh=U565yqmgZMcvr3E5NWk2zB3l8gfOALKowPOdrK24J5o=; b=F7zz9ig9gHSsmGT/EtIA2nX+/HERNi/wgY3fH4K2VhG7V0nSPu3obhDAw8E13ohUvC FbqPEFYYx9hR5GBdxyP50IEEfEIb21Hhu78Jv3HtKhU8cgLR7f28KiJBK7vqiZ/p1SxT YDrUQbVW9UpQoi3TM0h7PK6d/2UCP/9lpXp20uAEqcRu43kHyogmxcJ+5I0lK+EALL00 FSi5vf5ayW/aCY6bVw7qVwfFeJUy8rHQ6TVP+FENoRUPuzzf+P8hH5QmdFpGJEG14ZN3 6XnqpAduRrIO76E6d8tP8MvFGJfuR1KIF3j3QpNhgA3A6CBxk8ZAZmuh0Qt0ii3ILk7l 7w6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2634-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2634-ouuuleilei=gmail.com@vger.kernel.org" Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id qx14-20020a170906fcce00b00a232a3229e1si1224368ejb.529.2023.12.17.06.33.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 06:33:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2634-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2634-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2634-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 982C21F20582 for ; Sun, 17 Dec 2023 14:33:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 48C8649F7B; Sun, 17 Dec 2023 14:30:28 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6701844C89 for ; Sun, 17 Dec 2023 14:30:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEs9f-0006ZL-Lm; Sun, 17 Dec 2023 15:30:07 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rEs9e-00GUhq-U6; Sun, 17 Dec 2023 15:30:06 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rEs9e-004hzo-Ky; Sun, 17 Dec 2023 15:30:06 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski Cc: kernel@pengutronix.de, Santosh Shilimkar , linux-kernel@vger.kernel.org Subject: [PATCH 14/15] memory: ti-aemif: Convert to platform remove callback returning void Date: Sun, 17 Dec 2023 15:29:40 +0100 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1588; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=pyWtWmiwYcg0+6LNzRmjSApIX5L5AKsgQVYFlPzrv+I=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfwXVntZp5sOxEOB/5fkXOzLz4JVmjpvWLituw Z1H3E7JdPOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZX8F1QAKCRCPgPtYfRL+ ThtuB/9hagkz+RKxDNMHvUqlVsrSIea6Z/3Ptua567Bbsvv/Vm/TW9rnx7r+HP2TtK9PxA+bzZZ 4goIWx5Qec11dH9oFCSVMNlkBiFi910QfVU9ZPk3G774DGlVirfuMCYzu9RgPkqRuVfaaSrq4Be Uf+KUw3YHBNw7gbJCnLtetkBABlrE79c9OT6DRH7ZBJV16it75dcM0Hiz7H9/O+sDzKMAeYEXNk 9pqzSpiGFUDRVgGluK1J+lt99l2Rqu9q++pJn9yi70IZSh3s6ZOFShjKJpaT7X9wx9DEg/PjAvb Zha3UerYfgny7tttBSdN4e7euXHi9YMhv//K/d/SkYJb/e0h X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785539940323386940 X-GMAIL-MSGID: 1785539940323386940 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/memory/ti-aemif.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/memory/ti-aemif.c b/drivers/memory/ti-aemif.c index f81e7df8798a..e192db9e0e4b 100644 --- a/drivers/memory/ti-aemif.c +++ b/drivers/memory/ti-aemif.c @@ -427,17 +427,16 @@ static int aemif_probe(struct platform_device *pdev) return ret; } -static int aemif_remove(struct platform_device *pdev) +static void aemif_remove(struct platform_device *pdev) { struct aemif_device *aemif = platform_get_drvdata(pdev); clk_disable_unprepare(aemif->clk); - return 0; } static struct platform_driver aemif_driver = { .probe = aemif_probe, - .remove = aemif_remove, + .remove_new = aemif_remove, .driver = { .name = "ti-aemif", .of_match_table = of_match_ptr(aemif_of_match), From patchwork Sun Dec 17 14:29:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 180028 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:24d3:b0:fb:cd0c:d3e with SMTP id r19csp737338dyi; Sun, 17 Dec 2023 06:41:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IEksd40/s9jccKKV1wg3fIrqXfXdHX50+X71MjoTGTE9pICewnhH64rMK3zZvfvHmgyxQ8J X-Received: by 2002:a92:cdaf:0:b0:35d:6497:3548 with SMTP id g15-20020a92cdaf000000b0035d64973548mr23222980ild.55.1702824116773; Sun, 17 Dec 2023 06:41:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702824116; cv=none; d=google.com; s=arc-20160816; b=HmRR7c9wtTA1majxPFafZv+k2vG2caz0WPAjT71D8YYFzpBC2QLCh1xdLgPCg7NlxU hFWuLx+n+jRrC9VYhqcY98PQ04243y+ZWSDZ7QvEZYr6531wpKjAx1MbK7cakQZTWU0o Uvb+9avgz2eHZb3BUZPTPD1m7Ugu1ZtkcDcTsbvx2/gHRRWDbv5fLDs8Pd56c8m7s2eq YgtKthpnQwh1aper8K2i2cbaF41OJNqQOJu2pjgZcoptNHiz0N1ypKE1cyjEhvnytRj9 Y3gYPfwyZkkdVsLQoj+y91C7lMpsJd38fWzBYM1UlawiifYyUBmRqxwi6WrdDqWrQzaI WwiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=snmEQSlAEPGTTnYmOExy1ClzPrrdeSrXNuvXygHbSDU=; fh=U565yqmgZMcvr3E5NWk2zB3l8gfOALKowPOdrK24J5o=; b=Jf0Hlez0mVBUK5OcilIG7M7XwdmbUYx6njg/U0k+rwPjWoweKEvVsHXYrxUoijOwyR xlIgcHHYp42DCR+65MR7yusqzdn3MwtRcVK7G40BqN8jB78SpMSrZrcD6MZzCbz6x3E/ DNwv7EIp5apaxUlG3Y6gMh9gNPcceWwrHsi3w4Vc0+Sthlfp57pwZRWmFKNei+wjjWMz 4tiQKc0bGFj9z8WSYOTHjnM9jAkwsF98L105nvnbXp/g7VFjEkNpQfLeDUfYSmA1tFg/ gNYjAdunFKOaheJFPGrABhYvZecaBHrCL0lk0bkTeT2n3uXce1xeQUa+nrSKcDg3HT5E qV1Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2638-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2638-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id j14-20020a170903024e00b001d1ce46f067si16543415plh.485.2023.12.17.06.41.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 06:41:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-2638-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-2638-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-2638-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id C730E2883D1 for ; Sun, 17 Dec 2023 14:33:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C9D304A9A1; Sun, 17 Dec 2023 14:30:29 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6636144C81 for ; Sun, 17 Dec 2023 14:30:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEs9f-0006b0-O8; Sun, 17 Dec 2023 15:30:07 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rEs9f-00GUhw-4D; Sun, 17 Dec 2023 15:30:07 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rEs9e-004hzs-RU; Sun, 17 Dec 2023 15:30:06 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski Cc: kernel@pengutronix.de, Santosh Shilimkar , linux-kernel@vger.kernel.org Subject: [PATCH 15/15] memory: ti-emif-pm: Convert to platform remove callback returning void Date: Sun, 17 Dec 2023 15:29:41 +0100 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1748; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=WJZhwPTIlOIcqqLEYHwjtW0719qozbE7mBK83LkfWTk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfwXWitg8IFqEzU/x3i9wOHluf61iEJdKFWz4e sP6AwJyr2WJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZX8F1gAKCRCPgPtYfRL+ TgQcB/4+1a//3wge4lcfstHDq+FtIiQnRK37NbknYbLzRn5tWA54WLLrR4a0XofCL0GN7YSRAHU 4tu7BUdnZCOxDdTjz/RR1yEFaLgGcij11HxXSoguQ8KEQqsynys0RfRr9AgK687x9PEQeE4+jwg iBLkifzP7BlGxsEpEwtjXc7MsLsFthQ0n80xxHwYrTEZrcFNFUXb/tTkZ8wcn6tTKpS0xeTjAyO rnJNt7KewIhXFdaYSDGNCrXPpPC6DuvbNzoD3e1G+nqPdPsEDotvhJn9KQaQnhFq7Ie074cWR8J nOhS3nF+wQonHYpPT2GhaRRqVFOzI5vIZTIkGTNQ0DXlxpO2 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785540501194016071 X-GMAIL-MSGID: 1785540501194016071 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/memory/ti-emif-pm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/memory/ti-emif-pm.c b/drivers/memory/ti-emif-pm.c index cef0d3beb63b..592f70e9c8e5 100644 --- a/drivers/memory/ti-emif-pm.c +++ b/drivers/memory/ti-emif-pm.c @@ -315,15 +315,13 @@ static int ti_emif_probe(struct platform_device *pdev) return ret; } -static int ti_emif_remove(struct platform_device *pdev) +static void ti_emif_remove(struct platform_device *pdev) { struct ti_emif_data *emif_data = emif_instance; emif_instance = NULL; ti_emif_free_sram(emif_data); - - return 0; } static const struct dev_pm_ops ti_emif_pm_ops = { @@ -332,7 +330,7 @@ static const struct dev_pm_ops ti_emif_pm_ops = { static struct platform_driver ti_emif_driver = { .probe = ti_emif_probe, - .remove = ti_emif_remove, + .remove_new = ti_emif_remove, .driver = { .name = KBUILD_MODNAME, .of_match_table = ti_emif_of_match,