From patchwork Sat Dec 16 01:55:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Armin Wolf X-Patchwork-Id: 179732 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp9700247dys; Fri, 15 Dec 2023 17:57:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IFtmfwFGq/IkhyVv0Q7p0lx3wY2bdy8s+sRwzImZK+xgz/lRqZJryTtJfO3Nbr+NOfgdmbv X-Received: by 2002:a05:6870:d38c:b0:203:8416:d05f with SMTP id k12-20020a056870d38c00b002038416d05fmr1107407oag.33.1702691822799; Fri, 15 Dec 2023 17:57:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702691822; cv=none; d=google.com; s=arc-20160816; b=iSnoz1RD+lTElw4dgi1M3L036TyRH8d75m78jAPa9pJS//o0ptyZ0Zw8FDwaOtVg+Q CirCzRn9tROxZpg5f8rMiY2XES6yaV4YtIKlVyJoceE1RyvSNPgXu7JHLnPHlw2ZIBlW BI5T3aXLvXnl3aw8oii8rQqcjKHP4D4/rUM1rEH0ek0rDCB6iWiOnMRPjBEhI1Zw7JqQ r+0pM53B2RJY+CBIoYZVvMq47sUikyQRJHVMCpv0luN2nzbjbS4qeZNlSh+OqL1TpFPq R0r83WuWnKccRyMGFJ30YK8QlqOD0uB1/wuDuYBejST8ibTRWvjaaHBGNeTG69iX6Dgs pfQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=QJL/oymgKktJpb0b6BlRieduvf4h6pM+eHnmmIXqIIQ=; fh=VE5ZfoJWem8it6OrnlM5ov49ej/hHjarqyIgnpICDoo=; b=K7RjSgL4/scH/5o2olGuZbHA+pen3Izwgna6mYsqH6+jbEk+8cjlQ2vFQRMXlUlExI QtMC/skJ5PFxam/DO4HadHeQWvh0Jbxtnuj6CuGwVwfIa1gXzOcf2RSMNdnH2YjvOP4W dsSaQ7DAE1uOSGWOfoHmJvhLX8CP8Hpqmnfm/053JxXZiGT4YQpW7TUFCFb7f+BXtKmz qURisPSlo/UWAAfGYWHJevYkEgnyOc/+Yntk3ZGiKk95jtw49o0B8pt/k2CAtaZimyFN MekzAGaGOZtGSKK/RhUN7+i6kUcsaIp0Es7F8vj9JpU+m/EnqmeUKQsKz2wIBd8Nu8DA O1lQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmx.de header.s=s31663417 header.b=HVsiTsi4; spf=pass (google.com: domain of linux-kernel+bounces-1939-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1939-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=gmx.de Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id b38-20020a630c26000000b005c201eb7e85si13860801pgl.541.2023.12.15.17.57.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 17:57:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-1939-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmx.de header.s=s31663417 header.b=HVsiTsi4; spf=pass (google.com: domain of linux-kernel+bounces-1939-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1939-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=gmx.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6C1EA285C57 for ; Sat, 16 Dec 2023 01:57:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D62C75387; Sat, 16 Dec 2023 01:56:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.de header.i=w_armin@gmx.de header.b="HVsiTsi4" X-Original-To: linux-kernel@vger.kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D8471363; Sat, 16 Dec 2023 01:56:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1702691774; x=1703296574; i=w_armin@gmx.de; bh=iRRAKbmAPwXhvUW4GeDAtHUeGHCa7UwO3y4IzMhZosU=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=HVsiTsi4E/5xdpDXVtctRIpM2N23LOMCPUHwodHrmknycMsDGuJbRO96zdF4U0SH bjkGyFYIoCaDuckpwtR2jYWvyVF3FtRDM1b/mSVAuS3O4liD20rmhUNAk2hsjuy1R os7TlUFnATc3eYlSNH5D0APJgk38ZI0Wra1NjYNW5qXiNORVR522LHtevLTUxArqX sH9Y53KDZiAr9uNeap08HjigS3h40dFahdEcgbfQs/ODwzWWgjgXyHnY2tVT0QOGY DewFqBZHNoiL1X+PZOfCxDtedI2mRqH6gTE8WQeBVBUdarPUJ+AYRjopM6wkMj3Ub unktvxa+B4vUh5Hisw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from mx-amd-b650.users.agdsn.de ([141.30.226.129]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M59GA-1rDDys1NuW-001CoP; Sat, 16 Dec 2023 02:56:14 +0100 From: Armin Wolf To: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/6] platform/x86: wmi: Remove unused variable in address space handler Date: Sat, 16 Dec 2023 02:55:56 +0100 Message-Id: <20231216015601.395118-2-W_Armin@gmx.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231216015601.395118-1-W_Armin@gmx.de> References: <20231216015601.395118-1-W_Armin@gmx.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:MOirfnZjqqSa7HKQZpaCjRHQzbSnjM/WT0d9T5Iambpw8kD6B9y 28m2Aow+fBqN0ma3ceR3fbZCEW/VusvoVPjx/Z61DKdNH24CTDtgsibYLUp7dQUY/fJL+Pj fyTXopPyGIIbgliOO8KCsKMzSgdfqBEOSn5PypGzVIUz0pok/I3OSZ0aM8LpldoR2rUUjqy uMR1DIPkjCn739AF6FK7g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:g6TJpMyVtzg=;8NJD8ZkcZbvWcPGjTdnCYAfn48e rS/yojc3meuqmvJ5oso+pp5CEd9xvsTzahRVyRzmg949loKL46jyAcNCZI5ImHrGZKmXUswtv BwY23woQqcu1Uqm87Pzi8gfgrqdymGcCdNudKJxPW/+tKW02ZgfJOaFJxxCvr/ueTZuLoiKug /vuc8B7amK/VtZngUoqt+TmBDPbQ4MDc4DdsiYe2vT3oLWhJHgSCtJ176knmVXVF5kI5t75xp DGsOWLfA9XH5uDqIxO3UvN9k132jmxzQ/ZzQPwIxfPxIK18SyvCMDcle4fExUCdws3hQNY7Ze RM1+m3PLYeLm8ma7XGzx6DDcUR3XayOmfnkUIjNHU/WD00JKI7SJ3bfmypl2vST4bXYtIRd2V 8wZ+yaRLUNrMD61NIFenRs1KPdNEOxGmn+zFnvWLOYn2LAwIj9mz4u1lKHdQHfP03uE3KUbiS WyV51xWuM0POH4BOpsBcmPA2C7mzgp21VPf2NnN6cQwwK3CqSDru291Zz2qJycLe7JkLLiiiG V/LcFOZYgNLi11OPsIZ6o1+aJRPfOqkY5iGgtusibw/VmKKsJuisg8hJGAM8P9Xzso1sgdNMR BqRRuRGPE725kooFahxDm8nHFXKWkojFYTq5fGsrk4I5bvX0mzE7Cdm1/WFUYNNv+3YWObtLk T/NdslgPL8YNrH5e0s8CrIikPzu5CSj1w6yrBCOvrZpnz6nFwRdLi/Q0rSKrJ9KywJRe/5PWA Mxb3jVHaK/v8xVGN+zePFUsR8VMZ3ZZUBkO2FoOi01JbHcVEvKWM9av+63+MEI+2rJLjj179M A16yZHI969PbnXwd7DZXHVnhwACLNnCaqW5yG7/SQop7IXrouOltIQJVty4fxzYnzupUlsGJJ EFY0JmZ4OLy02346Xbz8yPUXGnPwifm3f+QAAPIslQr21+Dd1B74cTVAYJmoXxkAdB+luyOV3 Q8aXwqqSRlozaFZ4MPrQ5WXHpN8= X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785401780817969629 X-GMAIL-MSGID: 1785401780817969629 The variable "i" is always zero and only used in shift operations. Remove it to make the code more readable. Signed-off-by: Armin Wolf Reviewed-by: Ilpo Järvinen --- drivers/platform/x86/wmi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.39.2 diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index 7303702290e5..906d3a2831ae 100644 --- a/drivers/platform/x86/wmi.c +++ b/drivers/platform/x86/wmi.c @@ -1144,7 +1144,7 @@ acpi_wmi_ec_space_handler(u32 function, acpi_physical_address address, u32 bits, u64 *value, void *handler_context, void *region_context) { - int result = 0, i = 0; + int result = 0; u8 temp = 0; if ((address > 0xFF) || !value) @@ -1158,9 +1158,9 @@ acpi_wmi_ec_space_handler(u32 function, acpi_physical_address address, if (function == ACPI_READ) { result = ec_read(address, &temp); - (*value) |= ((u64)temp) << i; + *value = temp; } else { - temp = 0xff & ((*value) >> i); + temp = 0xff & *value; result = ec_write(address, temp); } From patchwork Sat Dec 16 01:55:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Armin Wolf X-Patchwork-Id: 179733 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp9700468dys; Fri, 15 Dec 2023 17:57:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IHAt3uKi1LLl68UzABxOZUs4bfbM0wQhtYZ2Es0+vp5rftIv5nHba++I/N7M4y6vixLNWPh X-Received: by 2002:a05:6214:202f:b0:67f:2a02:7f34 with SMTP id 15-20020a056214202f00b0067f2a027f34mr85170qvf.112.1702691858583; Fri, 15 Dec 2023 17:57:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702691858; cv=none; d=google.com; s=arc-20160816; b=Vac6536McUSIA7BNnbgO9rYj8r9wkvoLBoKEDQ41zkq3EBh6CkromaFavhrzXCowGS 9Ch1pv3ZmUl5blf1fYOhtgKEFmyPy/zKPpzBeXBLMULz+cUxaf8pyLHPxXnbVUvcwwNh wPcFivoJaIqQ1Bh8hSZAI1eX741mi5+YEiofr7laqpXQzkd99zwnpmHnWcYOWAcVJ7V1 EbiQbohsoPrv5DMwgYh/3kdiaCC1om4kK1MagzjeLmifHYKRLSz3IrxRA/wLRPiT9Wcm 2Iq+w/rlhxAMHkt72PG3yVkgmA2r1OjHNsmjcbQ7RTbXv+rLRaOW8CjPZndC1EL+z4Dm 9m4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=4uRriTxzUrWSfR+ZbsOKT9aJQv2RaqaPD3e8HpWP0sc=; fh=VE5ZfoJWem8it6OrnlM5ov49ej/hHjarqyIgnpICDoo=; b=XkpdjiRiUPYuJ4UE9LArd+aMJKujjZxS3VEhmfJsm7iYjxJMto+uD7EQ3051wgUOAT m9Tz00DSg89J4bOHYcmoAmmOSpyOqvh7BTMEkeYzn1mRZxTU57SQPolUy4UFdghwR4st zlw/4CJUquzh0e6lCP7wMdAp4aBk+vpTwLM4kGUL5LfLbteHBYLyEvNfOKtrorFraFu1 APWogcFYhD81wPmrEa5SQDCh8Fm27Gy7BsEc9v+Ae2yt30CCjSdq/FDm+u3RHcuYylpl 0vXBXoA2OfCmd9v0gsw0ZgxHqEce96ODkql66oouHq8n9W1/HoL79Ph6r5ApmM8BhzVL yE+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmx.de header.s=s31663417 header.b=n9woXCgU; spf=pass (google.com: domain of linux-kernel+bounces-1942-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1942-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=gmx.de Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id v2-20020a0c9c02000000b0067f20e2145csi1629966qve.149.2023.12.15.17.57.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 17:57:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-1942-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmx.de header.s=s31663417 header.b=n9woXCgU; spf=pass (google.com: domain of linux-kernel+bounces-1942-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1942-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=gmx.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 51C0F1C24726 for ; Sat, 16 Dec 2023 01:57:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E25FDDDB4; Sat, 16 Dec 2023 01:56:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.de header.i=w_armin@gmx.de header.b="n9woXCgU" X-Original-To: linux-kernel@vger.kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44D6A28ED; Sat, 16 Dec 2023 01:56:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1702691778; x=1703296578; i=w_armin@gmx.de; bh=JXqSKmcFLSyeKf7OYURl84uaiL8PV4z/6Y9EVeVg1Vc=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=n9woXCgUk5pkpwrrsAXeVUw6f3vm7fO/k7OkfIrot7moVOsX2lDO/8zvYkVciW0s wikaqjBdVw5eITRhGlMY5wOnrn5fGzw/eQqiwfSq3HGvUlHtFJORdBBLwp/KAplLA 0fhzCn10Nv9LvWwRtqvkgxiDXygMOzGZF3jO9m0Y3VGWj9pRU/KNCxuwQfzCIF9a0 vnQjKY+iS7xNXPiXVPQldHlvuBAGTVaJ86Fxln19rBKPlhtG/2niAG/vrwfQEB8oi c4MP46+lFp03WcGDaLvi2+tEagAc5CDi8qLIBIlp4j/CsIY+fFaWKWkwD3kd2dU7W ivDh5WsaNGCOFeba4g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from mx-amd-b650.users.agdsn.de ([141.30.226.129]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N8ob6-1rIQg02ZpW-015q1t; Sat, 16 Dec 2023 02:56:18 +0100 From: Armin Wolf To: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/6] platform/x86: wmi: Create WMI bus device first Date: Sat, 16 Dec 2023 02:55:59 +0100 Message-Id: <20231216015601.395118-5-W_Armin@gmx.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231216015601.395118-1-W_Armin@gmx.de> References: <20231216015601.395118-1-W_Armin@gmx.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:sWKj5sipcYAyJFmd0R5+CGzUK9Ib961ca3/LW0BsFdGMwSMvakr FbCY7Zn0fIjO3aAK0v4KmhI+6jGTbv4KFsSn3HtdaVhU5m9P4i/2ZadIvX5pL8a23uCPZTp UMoZIAX0/GwDDZtwIdJNTMPrFFUXvo+lxEwzh2ikQ2KOgcemCpnyGnf4qZYrYPfi6IeFyfO GzuaKaIaFBZHk4WAo+jzQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:XSs2184x+uQ=;IMc4kWXI1OoG3Wj4ME7//yyKABh 4u34exp+qKQJJsGJHOnon6yhF+jEmCFw0rACVzLmfI1YY+01vFB0SBl6JuGWzijPIsVS8g9Gf AVBy8lsRLIN2zWlTAZLkHAZ1GekZ6EPIsS09QkT+WcxLGr5ePIE/epe3z29yrz4kkRdTlABLs /jZ318vaPFWwJyBnLqLisewk6wepmZvSXcN7bRXI3V4kuDPNn2zZ07168K3mtzkRLW3vtUg7G VIWe1fTppSvCPdN3E8EwCo+EDaVxnt2y275QrYywdsEbuuOY5dVUhdnRdiNPi37Thyu2ADMs4 VvQaPa0wotbZOo1QAq46/VP6NT73snEa8Pz2F7YvA0uBb3E5ySpjDxPvSo4YichI2mG9I4rQp zqLam9echWLnSw4j49tlXEkbz/czZ2XoQ6AR9XN2vdDbEtVoBkHQ4nBkZNPZbT68wmPhw8R7s QnGLpcfEygLsPT0vsH8nKruRnD51Lux+5scEweYXBKQDDAAz2fzWX7X2+ds9zYOioD7Yf4oE/ P7/Ldh85yor9qa4YJbmIuPMFdXUPTHApsQ5o4vjB+7CIVP+M/cJkOJbJ6odpBUhJ5nJhl60+R JV7CxYG6I2zm7D1vz2yiWIBP6nFJ+AGQT+28QM85H3QEPXjfEQ3U1xPkQod+17H6dCdp0x0UP +TcIrWX1zXqj/PtBvJ5oIHlvWXQGZ0Cwf0ShD84n4RFUUHPodgRbePhnrqJjrGtpnc0WPtj6m rdNCszHSDSQU+RZNcYwBEe8NMxeIs58dyVd8+V9WKMYKxari5sLEYzIqgIbGKg3mw5R6NoPAo Sp+oDUuvKGXO5IcT1ENUdmul5caZ4awjQxGe0GKk8/62ynSHSaiLxfEj+3hpjFoBYhQ31NbTm pF6lYM/ctgBK4a5v/JiJnEKQIXeTAXxxyij3L/Skiffgrb2N0v9ifCt+YSZbNanBMiPuWsI4U E7L/e+CQbOyVuoWo6v5+jJQou4M= X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785401818506815692 X-GMAIL-MSGID: 1785401818506815692 Create the WMI bus device first so that it can be used by the ACPI handlers. Signed-off-by: Armin Wolf --- drivers/platform/x86/wmi.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) -- 2.39.2 diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index 4306a5533842..61849a43e2c2 100644 --- a/drivers/platform/x86/wmi.c +++ b/drivers/platform/x86/wmi.c @@ -1276,6 +1276,17 @@ static int acpi_wmi_probe(struct platform_device *device) return -ENODEV; } + wmi_bus_dev = device_create(&wmi_bus_class, &device->dev, MKDEV(0, 0), NULL, "wmi_bus-%s", + dev_name(&device->dev)); + if (IS_ERR(wmi_bus_dev)) + return PTR_ERR(wmi_bus_dev); + + error = devm_add_action_or_reset(&device->dev, acpi_wmi_remove_bus_device, wmi_bus_dev); + if (error < 0) + return error; + + dev_set_drvdata(&device->dev, wmi_bus_dev); + status = acpi_install_address_space_handler(acpi_device->handle, ACPI_ADR_SPACE_EC, &acpi_wmi_ec_space_handler, @@ -1302,17 +1313,6 @@ static int acpi_wmi_probe(struct platform_device *device) if (error < 0) return error; - wmi_bus_dev = device_create(&wmi_bus_class, &device->dev, MKDEV(0, 0), - NULL, "wmi_bus-%s", dev_name(&device->dev)); - if (IS_ERR(wmi_bus_dev)) { - return PTR_ERR(wmi_bus_dev); - } - error = devm_add_action_or_reset(&device->dev, acpi_wmi_remove_bus_device, wmi_bus_dev); - if (error < 0) - return error; - - dev_set_drvdata(&device->dev, wmi_bus_dev); - error = parse_wdg(wmi_bus_dev, device); if (error) { pr_err("Failed to parse WDG method\n"); From patchwork Sat Dec 16 01:56:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Armin Wolf X-Patchwork-Id: 179734 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp9700568dys; Fri, 15 Dec 2023 17:57:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IECPC4r6Oi/P5c+eh9/fO2orhhzYCd6x1CkQs+jwxuvFv1GDMdV6WIrkfeJ8NrBZQMt9c2K X-Received: by 2002:a50:c011:0:b0:551:86d9:6252 with SMTP id r17-20020a50c011000000b0055186d96252mr3471198edb.55.1702691877083; Fri, 15 Dec 2023 17:57:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702691877; cv=none; d=google.com; s=arc-20160816; b=tEYjfwMTttuzdXGM/lzVMVYlrHCtoWKJcv8StgnNKLC/p0RwMh5MK7dX76MIuf3o0R RnhGSkLSfZHEYBKAJoPk66yfwvpGRlQuE4vTxsAzvcZIqSvbT6IyrfBZlHbqI9Tt7CZN CtIhBVMbLlVi1nG/RVN6jIkxntZgHxSnzCecbWwN1BCnth2+tFVvEoj/v1tj07TMd1Pr eBnVKG+PNtmKbSi4EFBMfDHY6B/Z2D50ZhQ/FY1cOlpn0yZLrmiUqUqlBUNNAUdJBAP1 iKCB72VyAvPShkrTwVY6Gz1grbs3X+w6o/rmV5WaqJthyWJVusgXKDg/5OlsagczneJG nAew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=s3xh/zx00XOYmiwhZtGZyGJ6adxkuS9bvkUEdUc+DDs=; fh=VE5ZfoJWem8it6OrnlM5ov49ej/hHjarqyIgnpICDoo=; b=d8jLoLpz5fiXAehi1MVlgRATuJzJs55QrxoufSy4Vuz9OpviI6Kcf9yLZklSYR32Yt sIXxb2cHr2pg98euWI4PyuAmlU8MkYbL2di72fxjGL79m+baIffCb0+1JO7yehdGZDtE emhRcVX0svJx+R0rdyVTt9OwgZzT3XZRmgIcI8BzzeIDEh+5YNPZZ+afdok1yyFVUxlZ xkYN0OmNuEXkKVaCBHyIZKl6vqMQS/d0/Dv3dzoRUxAEC5i0yZO21amSPA31IqTBR993 TQZ4KI3XMjSwFff0VKDTnm9XNJrXUQzIrPl5mM16ugHmLryNbNUy8HPCC1TfgNkax9VP RBGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmx.de header.s=s31663417 header.b=GpprZU2K; spf=pass (google.com: domain of linux-kernel+bounces-1943-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1943-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=gmx.de Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id 28-20020a508e5c000000b0054cf5668084si7718690edx.444.2023.12.15.17.57.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 17:57:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-1943-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@gmx.de header.s=s31663417 header.b=GpprZU2K; spf=pass (google.com: domain of linux-kernel+bounces-1943-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1943-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=gmx.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B20CA1F258EB for ; Sat, 16 Dec 2023 01:57:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A13AB10965; Sat, 16 Dec 2023 01:56:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.de header.i=w_armin@gmx.de header.b="GpprZU2K" X-Original-To: linux-kernel@vger.kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F03B5679; Sat, 16 Dec 2023 01:56:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1702691780; x=1703296580; i=w_armin@gmx.de; bh=duHpCA4cOBrSH/Azl/sNbIHKrTis7PHVleO/ty9RZmo=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=GpprZU2KiWMpPjwEShF4YUHcsyJpRhktiB800789WqInZUdS2rnGb6WYXkFKq5xP s1i7cJK3idleMqgCogzW2gkvqFH7wN6YbAwoHRCyw2J6zN1s5uJRps0awTHVBLp9q UceKBoEN6utTZJBc0kwNdiRpU9wNfyLJC6jPVsxq+G4omb042RuyofMpEsbKQOEyE 6qwzNt8kGIeh6xyeQ+o0Bm6F6JR/jD0xyU2RS5uRwkb/aLmtIgabNoM8uhP5XuT+z gpELwh4wh5IRMFi47FCNvkVydarFJLA0IsvEKNAXFFpzrgX8Ums/u1YUrSzLCPukB w2UlYggollzfLpcNIg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from mx-amd-b650.users.agdsn.de ([141.30.226.129]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MOiDX-1qpONX21E7-00QF4D; Sat, 16 Dec 2023 02:56:20 +0100 From: Armin Wolf To: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/6] platform/x86: wmi: Decouple ACPI notify handler from wmi_block_list Date: Sat, 16 Dec 2023 02:56:00 +0100 Message-Id: <20231216015601.395118-6-W_Armin@gmx.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231216015601.395118-1-W_Armin@gmx.de> References: <20231216015601.395118-1-W_Armin@gmx.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:ubTPhVWqSQKfAB9dDY6lfW/JMpvW9kP1RzZke8D4rE8HeJBd6Aa vWU4xQ8tV5EmLlrjemCizNm8hWrFL8+d3aOXd1uBxJLGiasWURE6IIS3jfK0CkCCu/hXpi8 gy9qesTcXJ3YCjI340HzTLrWtJEiRqz9ClEVFwAbKgy4qDjIUJakDgMsPpL09jqDWuITRHw clW+S3F60SENi3WCeMAFQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:L5925xHDSAw=;0fc22ktMDiR52HFzvVcn3UqAvGB 5HCd1QbjUSz3jEgRNFrGvdix5tCuGbhoE5kcaHcDLv1BX2zFTkMwZuYONo7EVEua8kKiEbuQM igaRGnA4gj+TIMtIo9O5hE5tJCsZ2Vl6YSTC0O6EgZFHawPGw40+lMYuH6yzgSGwLQhmd+9iU kSS9kjO2Du2+Y1zJS+cJPrs412tQ1GWvQkAy0VqIL/+KfFoZjaQBK7JKleG57+VsuMQfFd0Sl srghbJwrDbzaZVhSTz/+GQ4Vhul3TewvQyjX0lxzHH3wSqphDzYHXkIPMPVOQ3cGoSnQCp9uN EWxR6nIfGFRV2csvV4kHmkioIisfOO9oeZHC1YiQhBL4MvULU1QnlEWLEfNFuK6HBULrXxMn5 kwVXImQ+nO9OI4eT1LuDqZH7iioGGSVYHdwRXC28N9BNFPhOSAwl+EP0/lDlL3sEEIn/teROd S/W6PcJGWz3wJxPpacDG7ziIXoSP5nfJyslKvmxDico/lGn+F+UZeMqNOFjGwlsVopyNe2aHf hvif6oDVbIwE+Fgxl7HAcWhTk3XrO5vPqsR5K4HNX3yEcoghsW/LAniXy3pB9ImN9009Af/96 8NJfQhGX2H/cOE7jezBeJxwxMR7tTfrjLlqpYjo0AXpd1Hy/p7vWLed+YwGPF1mDN2jLjxRGc wZkVsJM18x+sXFl8Nhe2DiBpZ+st7WctdgVWuPhZLbf9OYM0lTNE+WRiYFxoX8xLAf/XUYyS/ GqG7Hxoc74nlhykr7EsKzEJ0amcI79/PcVA8t3yv1pQ3S+uviS6ACvym4hGGkMN+YTKGx+PBS Lx6+BuociCs3ECWZyVt9TIdCY45mtoeIkkOchR6X1/I6UsTpur99KorwBQSSTLtLgRm2DTLHm eUR3vNwKRcMQbSOm7nG9FSr7xe9TjLDjV/rxDu3/d9LqikneRhR6ptTvkHg7LtNONWM09GoUI zyonCPnVEDtKmh+PcsEQo3QXEEg= X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785401837609689462 X-GMAIL-MSGID: 1785401837609689462 Currently, the ACPI notify handler searches all WMI devices for a matching WMI event device. This is inefficient since only WMI devices associated with the notified ACPI device need to be searched. Use the WMI bus device and device_for_each_child() to search for a matching WMI event device instead. Signed-off-by: Armin Wolf --- drivers/platform/x86/wmi.c | 46 +++++++++++++++++--------------------- 1 file changed, 20 insertions(+), 26 deletions(-) -- 2.39.2 diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index 61849a43e2c2..6b581c772fd1 100644 --- a/drivers/platform/x86/wmi.c +++ b/drivers/platform/x86/wmi.c @@ -1176,24 +1176,13 @@ acpi_wmi_ec_space_handler(u32 function, acpi_physical_address address, } } -static void acpi_wmi_notify_handler(acpi_handle handle, u32 event, - void *context) +static int wmi_notify_device(struct device *dev, void *data) { - struct wmi_block *wblock = NULL, *iter; - - list_for_each_entry(iter, &wmi_block_list, list) { - struct guid_block *block = &iter->gblock; - - if (iter->acpi_device->handle == handle && - (block->flags & ACPI_WMI_EVENT) && - (block->notify_id == event)) { - wblock = iter; - break; - } - } + struct wmi_block *wblock = dev_to_wblock(dev); + u32 *event = data; - if (!wblock) - return; + if (!(wblock->gblock.flags & ACPI_WMI_EVENT && wblock->gblock.notify_id == *event)) + return 0; /* If a driver is bound, then notify the driver. */ if (test_bit(WMI_PROBED, &wblock->flags) && wblock->dev.dev.driver) { @@ -1205,7 +1194,7 @@ static void acpi_wmi_notify_handler(acpi_handle handle, u32 event, status = get_event_data(wblock, &evdata); if (ACPI_FAILURE(status)) { dev_warn(&wblock->dev.dev, "failed to get event data\n"); - return; + return -EIO; } } @@ -1215,13 +1204,20 @@ static void acpi_wmi_notify_handler(acpi_handle handle, u32 event, kfree(evdata.pointer); } else if (wblock->handler) { /* Legacy handler */ - wblock->handler(event, wblock->handler_data); + wblock->handler(*event, wblock->handler_data); } - acpi_bus_generate_netlink_event( - wblock->acpi_device->pnp.device_class, - dev_name(&wblock->dev.dev), - event, 0); + acpi_bus_generate_netlink_event(wblock->acpi_device->pnp.device_class, + dev_name(&wblock->dev.dev), *event, 0); + + return -EBUSY; +} + +static void acpi_wmi_notify_handler(acpi_handle handle, u32 event, void *context) +{ + struct device *wmi_bus_dev = context; + + device_for_each_child(wmi_bus_dev, &event, wmi_notify_device); } static int wmi_remove_device(struct device *dev, void *data) @@ -1300,10 +1296,8 @@ static int acpi_wmi_probe(struct platform_device *device) if (error < 0) return error; - status = acpi_install_notify_handler(acpi_device->handle, - ACPI_ALL_NOTIFY, - acpi_wmi_notify_handler, - NULL); + status = acpi_install_notify_handler(acpi_device->handle, ACPI_ALL_NOTIFY, + acpi_wmi_notify_handler, wmi_bus_dev); if (ACPI_FAILURE(status)) { dev_err(&device->dev, "Error installing notify handler\n"); return -ENODEV;