From patchwork Fri Dec 15 23:41:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 179661 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp9647739dys; Fri, 15 Dec 2023 15:41:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IFn1kSzeVtzw8sOvvAm+P+QwI1lhDuR73F8+j0AM5uWbDjIShRXSsM7YDTg/SQ9aPaGxxit X-Received: by 2002:a05:622a:82:b0:425:93d0:8267 with SMTP id o2-20020a05622a008200b0042593d08267mr17436941qtw.48.1702683689752; Fri, 15 Dec 2023 15:41:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702683689; cv=none; d=google.com; s=arc-20160816; b=UP969Y+C+E+f1LMunwEcrN0jZncd90HoigMQ674ETSwwBJBiBV1jREWqiNLjmFr4Mq bcG8ZF6venRCsxbnptgTecErDIP54rlr5wKSKFjljBWwi7SbIMXzdRe14XHuUDUyj+w8 3li3DPcNjYpobLwbhyOVKTtSpybofFrViI1VOWDpEjZqyv6W4nWsLK7uGxMICHiLm3SV IuPKrHIpLX6QkDxJfDYCknyzsjY6du3pEdYvHDUA4Ii3A2X7Wg5DtL4k6QdXavFpNwNV 352MYhc90rDOSwXwwGXYussUPyeN1ULx3xlKl2jbojP6/wVVaFolDnWgWbB9RGn+43+M 3txg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=TfwCAA9rMzkhfqrrIg704MCtQiFwiMoz9kpT2FQboTI=; fh=eizXRh3AEkxJD0KS/Jxv5sH1FV5Dt5qO+6e7Dt597Wg=; b=OEP8/EdNE3UCNg1q4CdnsT1N8XPVUOovDn8e1bEFeKCKvAMW5DoH51pUcApP5+2rKx tO8YmzPB10E7P0DabNxNHtT2l7+M+nJB07bPh6GEc999MCD4hmuwqUVsVIqCl4LugCqo pXy9aoTKToqxqw9VVWRKje4X9VLD5NW9pgzMMGCcl/HsYJpuPADS22seHitRQe/RfXng PRpWyejTaGqJuHS1xwkEwu11o+coh+PEDEEL9GW+kAUGjNpgKJsdexrHNBpC1UfpVPq4 4lRdpXhFyW+V8JAsVODfVdsvLJJBH01+qge929MX4GQ5ShYpwEVbSxAVNdzgbA2eMZmf OFag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=l0ByrVu7; spf=pass (google.com: domain of linux-kernel+bounces-1831-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1831-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id w21-20020a05622a135500b00425f0e81eb6si7107983qtk.514.2023.12.15.15.41.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 15:41:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-1831-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=l0ByrVu7; spf=pass (google.com: domain of linux-kernel+bounces-1831-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-1831-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 7CB991C23F79 for ; Fri, 15 Dec 2023 23:41:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 20EDC4C3D9; Fri, 15 Dec 2023 23:41:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="l0ByrVu7" X-Original-To: linux-kernel@vger.kernel.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0050149F6D for ; Fri, 15 Dec 2023 23:41:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=TfwCAA9rMzkhfqrrIg704MCtQiFwiMoz9kpT2FQboTI=; b=l0ByrVu7BkDBMKvnQ2RLOLYv8q b3X/1R/EdNoP5+MFQp8UqtS7rO562f040IgJk93pXEmTu7ND2Ap43Q3x/6wdBNJSqM0QfvxEqpsxv I9pjmWx5IbLhzoZ9I/piKUjuf5B+uqe/xtJbNN0K/TGwBlVvWRLF0uwv1Uh6VcKjqE9aTrYpCjL9T QNFFsSxWhXOKUdk1021kyLXkYCf6M06RUAnXF+Am5jw8Hkfx9ou/HM1NBLLTkBbLkCHGTDyf0u2E5 b98Z0o3tAvt9sU3+r49aFgXh7SZRBIlE2BpufcDNP1VfkpBPt99eL5e4Is82eVkGRcLwj76ulUtxj oHASiC1Q==; Received: from [50.53.46.231] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1rEHnj-004sOp-1A; Fri, 15 Dec 2023 23:41:03 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , kernel test robot , Zack Rusin , VMware Graphics Reviewers , dri-devel@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Subject: [PATCH] drm/vmwgfx: fix all kernel-doc warnings in stdu Date: Fri, 15 Dec 2023 15:41:02 -0800 Message-ID: <20231215234102.16574-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785393252778982206 X-GMAIL-MSGID: 1785393252778982206 kernel test robot reports one kernel-doc warning in stdu, but running scripts/kernel-doc in -Wall mode reports several more, so fix all of them at one time: vmwgfx_stdu.c:76: warning: Excess struct member 'transfer' description in 'vmw_stdu_dirty' vmwgfx_stdu.c:103: warning: missing initial short description on line: * struct vmw_screen_target_display_unit vmwgfx_stdu.c:215: warning: No description found for return value of 'vmw_stdu_bind_st' vmwgfx_stdu.c:320: warning: No description found for return value of 'vmw_stdu_destroy_st' vmwgfx_stdu.c:551: warning: No description found for return value of 'vmw_kms_stdu_readback' vmwgfx_stdu.c:719: warning: No description found for return value of 'vmw_kms_stdu_surface_dirty' vmwgfx_stdu.c:895: warning: No description found for return value of 'vmw_stdu_primary_plane_prepare_fb' vmwgfx_stdu.c:1470: warning: No description found for return value of 'vmw_stdu_init' Signed-off-by: Randy Dunlap Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202312150347.5icezNlK-lkp@intel.com/ Cc: Zack Rusin Cc: VMware Graphics Reviewers Cc: dri-devel@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Reviewed-by: Zack Rusin --- drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff -- a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c --- a/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c @@ -53,7 +53,6 @@ enum stdu_content_type { * struct vmw_stdu_dirty - closure structure for the update functions * * @base: The base type we derive from. Used by vmw_kms_helper_dirty(). - * @transfer: Transfer direction for DMA command. * @left: Left side of bounding box. * @right: Right side of bounding box. * @top: Top side of bounding box. @@ -100,7 +99,7 @@ struct vmw_stdu_update_gb_image { }; /** - * struct vmw_screen_target_display_unit + * struct vmw_screen_target_display_unit - conglomerated STDU structure * * @base: VMW specific DU structure * @display_srf: surface to be displayed. The dimension of this will always @@ -208,6 +207,8 @@ static int vmw_stdu_define_st(struct vmw * @res: Buffer to bind to the screen target. Set to NULL to blank screen. * * Binding a surface to a Screen Target the same as flipping + * + * Returns: %0 on success or -errno code on failure */ static int vmw_stdu_bind_st(struct vmw_private *dev_priv, struct vmw_screen_target_display_unit *stdu, @@ -314,6 +315,9 @@ static int vmw_stdu_update_st(struct vmw * * @dev_priv: VMW DRM device * @stdu: display unit to destroy + * + * Returns: %0 on success, negative error code on failure. -ERESTARTSYS if + * interrupted. */ static int vmw_stdu_destroy_st(struct vmw_private *dev_priv, struct vmw_screen_target_display_unit *stdu) @@ -536,7 +540,8 @@ static void vmw_stdu_bo_cpu_commit(struc * If DMA-ing till the screen target system, the function will also notify * the screen target system that a bounding box of the cliprects has been * updated. - * Returns 0 on success, negative error code on failure. -ERESTARTSYS if + * + * Returns: %0 on success, negative error code on failure. -ERESTARTSYS if * interrupted. */ int vmw_kms_stdu_readback(struct vmw_private *dev_priv, @@ -703,7 +708,7 @@ static void vmw_kms_stdu_surface_fifo_co * case the device has already synchronized. * @crtc: If crtc is passed, perform surface dirty on that crtc only. * - * Returns 0 on success, negative error code on failure. -ERESTARTSYS if + * Returns: %0 on success, negative error code on failure. -ERESTARTSYS if * interrupted. */ int vmw_kms_stdu_surface_dirty(struct vmw_private *dev_priv, @@ -887,7 +892,7 @@ vmw_stdu_primary_plane_cleanup_fb(struct * backed by a buffer object. The display surface is pinned here, and it'll * be unpinned in .cleanup_fb() * - * Returns 0 on success + * Returns: %0 on success */ static int vmw_stdu_primary_plane_prepare_fb(struct drm_plane *plane, @@ -1465,6 +1470,8 @@ static const struct drm_crtc_helper_func * This function is called once per CRTC, and allocates one Screen Target * display unit to represent that CRTC. Since the SVGA device does not separate * out encoder and connector, they are represented as part of the STDU as well. + * + * Returns: %0 on success or -errno code on failure */ static int vmw_stdu_init(struct vmw_private *dev_priv, unsigned unit) {