From patchwork Fri Dec 15 06:57:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jiapeng Chong X-Patchwork-Id: 179052 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp9089638dys; Thu, 14 Dec 2023 23:03:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IHesFmaVYhpZ0EdIxJ8CxC9NByTaB+HaOaWZMPCy7bPHJeWLQkfV7sWHZ10rxbEB6EBx6Vu X-Received: by 2002:a05:6e02:20c4:b0:35d:7a4f:fcd1 with SMTP id 4-20020a056e0220c400b0035d7a4ffcd1mr13238873ilq.23.1702623806223; Thu, 14 Dec 2023 23:03:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702623806; cv=none; d=google.com; s=arc-20160816; b=DrBKmopVGdLxQkGqfTDj2x6WYp23YBvvl88nkvFmQQqc55mZvBY/dFSUMhJk6yHeNX 7+aX81EGv4DB0UvuQuKBozqqvw0kloio0nA06XHJ1rndzWH0f8Tfdh8/q2E1NE+DhACS rwXBRj/D34g2FI5lrW/6bZYBz7soXP8JJ86Y5i5cUu8AKK3Jf6LsGDwLWkuU7pazDRI/ 1t90KPHmobZlZJGKWZTdW4slYKGIaPVRbf4OhJn+7UHPH0wLEe5ejxAX817sc1hMyGGC d6M5bNGjWni56led/52sg3oc6ygX+JAiJ6TNW0lfkeRnhqoCsHgon83ct8juzlMmxydX djRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=m5TAa946bDBdqEiTVK1D28uxaskXqxxy7re365GGsDc=; fh=fKSnbRWcveY2/UYJ1RM6lNm1S6q9yGV6hSxKE900f8g=; b=JOMLUxNZcJnVMbXKfUcC92feBnV4tYdnbRtDcZ9lOzPzFIHTa2RQ6k/V4XOYCx7oKC JFbVd8RETcekXbJ+a5B3OkLp0Xdh5TwBjKAy2PoW5jfMD1uuJnRTADZ74vy/CZWMilKa Ba9dsFlilAHfByIdgMnHuH+UHZHxBWLDlZ6+ups5cC19I4MeRZDWeiNjPbhHKPHn5gMZ HO10aG8OtOXBGUnU9/u2hqLF041igKDY2Lb5yGvwTDTqf6ksy5L+TPgCfKMTYoiaPBH7 /VUfBqH7Naj3LMBCaDz3gw4GUjz5PkF2+inW8LBuMTVixhhJpagG8AXM1lw2cP2P04Er PCgg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-503-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-503-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id bw20-20020a056a02049400b005c65d9c13f4si13638677pgb.364.2023.12.14.23.03.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 23:03:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-503-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-503-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-503-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D620D2837C4 for ; Fri, 15 Dec 2023 07:03:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F0840D30F; Fri, 15 Dec 2023 07:03:13 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F61FD27A for ; Fri, 15 Dec 2023 07:03:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R551e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046049;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=14;SR=0;TI=SMTPD_---0VyWoQ7T_1702623454; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0VyWoQ7T_1702623454) by smtp.aliyun-inc.com; Fri, 15 Dec 2023 14:57:45 +0800 From: Jiapeng Chong To: hjc@rock-chips.com Cc: heiko@sntech.de, andy.yan@rock-chips.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH] drm/rockchip: vop2: Remove the unused variable if_dclk_rate Date: Fri, 15 Dec 2023 14:57:33 +0800 Message-Id: <20231215065733.48895-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785330460294048011 X-GMAIL-MSGID: 1785330460294048011 Variable if_dclk_rate is not effectively used, so delete it. drivers/gpu/drm/rockchip/rockchip_drm_vop2.c:1688:16: warning: variable ‘if_dclk_rate’ set but not used. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7750 Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c index 44508c2dd614..b4e7cddaf25a 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c @@ -1685,13 +1685,11 @@ static unsigned long rk3588_calc_cru_cfg(struct vop2_video_port *vp, int id, unsigned long dclk_core_rate = v_pixclk >> 2; unsigned long dclk_rate = v_pixclk; unsigned long dclk_out_rate; - unsigned long if_dclk_rate; unsigned long if_pixclk_rate; int K = 1; if (vop2_output_if_is_hdmi(id)) { /* - * K = 2: dclk_core = if_pixclk_rate > if_dclk_rate * K = 1: dclk_core = hdmie_edp_dclk > if_pixclk_rate */ if (output_mode == ROCKCHIP_OUT_MODE_YUV420) { @@ -1700,10 +1698,8 @@ static unsigned long rk3588_calc_cru_cfg(struct vop2_video_port *vp, int id, } if_pixclk_rate = (dclk_core_rate << 1) / K; - if_dclk_rate = dclk_core_rate / K; /* * *if_pixclk_div = dclk_rate / if_pixclk_rate; - * *if_dclk_div = dclk_rate / if_dclk_rate; */ *if_pixclk_div = 2; *if_dclk_div = 4;