From patchwork Thu Dec 14 18:40:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 178865 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp8765168dys; Thu, 14 Dec 2023 10:41:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IHCd4goP3sUTPAbSj+qXVm0/YptsLfFcOe7qT9MWWR6nz6FuLshrmQvcFNLNimEqbyZ0Czg X-Received: by 2002:a05:6a00:1248:b0:6ce:5373:96c9 with SMTP id u8-20020a056a00124800b006ce537396c9mr6087742pfi.40.1702579283508; Thu, 14 Dec 2023 10:41:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702579283; cv=none; d=google.com; s=arc-20160816; b=ujVVeV9fSswXNqEQhFhJLwp0q0PS88NPjCU5dZdh+DvqFOA2IhumFcxqQY7veGtBef gAm/Kahs3uX8Rp2/IBBo7SP0Q3mHdFj6BMGyLWCdSd5fbIWVdxhq8uEsPmsGBrYpaajn R4IXWn6HP7RO16P3bfko2roxpno5k2c46awQw7J4adrMZG/3Vmyd7WafJPALTwk25FVV DHZviTVrbLBB3D5Mlew5BhysxwqWcBDa3Nz3m/YEkKXL8t5dEeX4cKkdAIkyYNpACBfx Z35jRY6NaEGeAoWnccOCxrbVOekftCoDcSQblYmSWjgRiINM6ucla5w25MQRlcLueXjR gaXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=E8DYdmIY6lIpBkClg2aQTPotC4Ck+w2qUQqE36YmfdM=; fh=gYRgAXbu/FHO/Cqj/TKspqZnXUXsvaSPLTSdapZ7Ru0=; b=UtXRYFTYmYrV2gaEDAl4fBFFFkqsoplF8xVs6WgtbA8oDEgKgFYVgvkfeoc+GhP/mA gUwDX04bL9o17wf6xD4cnH0lrhHpLhkVu8EeY2ZrwSw4mD9ZfV9wN6lMep/l2tQGc8HX QzkVCcUDnWgJIfktrSxURwBeJ65t7jhDS8nVOld7/k336HlJPU/NYYxMc07c0voBPs3S HNJL5JHU5GA0NiDhNrfjN267ieDk+Jd9Fjskx+LsRWgsAdeoLwCU8V4nIsk0+aIES8jH D0bb1O/3IQQP5hSFLAoTdVFhD4ESyrLPiU63ZUwnjVXZrvyVHOdUUXNkkzj1VP65MZO+ ts3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HDOuX50S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id h10-20020a65518a000000b005c1cc9caf0asi11698497pgq.899.2023.12.14.10.41.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 10:41:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HDOuX50S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 22BFE809638C; Thu, 14 Dec 2023 10:41:03 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1572937AbjLNSkx (ORCPT + 99 others); Thu, 14 Dec 2023 13:40:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229753AbjLNSkw (ORCPT ); Thu, 14 Dec 2023 13:40:52 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 134CC10E; Thu, 14 Dec 2023 10:40:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702579259; x=1734115259; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=G18B/IrnfrebrjvuaMIQ0eCCWtBtYWxi9zew/6c/ODs=; b=HDOuX50Skft9RqXi5wDVrpxjOrP5dcz7dBbaATjyPOQrx5TYBGsc+SU6 s+nGb+zXW5yU0cq6O/RutLpa45MDzVGhJ+ni5Ap3H1y1LURHgER4/tjtJ uL4Pi/o1dUdAkk8v17Rub4keqJ5fUBcWwXnsGJpyKBD7sOi6Szmy0GTF9 Q+jv2M8+C+++ua34jNpBaP0cfSiQryPs/8ogeZV5LDgyYwrasAHuNUiyh 6xzSoD17Ag85JBj1V9wC464RXTk8nQK8sDQGfhzJI91P/MpneUNte/u9V Hc98qwTzm+tyZW+9IIf45aOtM+3uf5X9eH4Zm0pf4rxQu999fpQ73MScL g==; X-IronPort-AV: E=McAfee;i="6600,9927,10924"; a="385582264" X-IronPort-AV: E=Sophos;i="6.04,276,1695711600"; d="scan'208";a="385582264" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2023 10:40:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10924"; a="840374564" X-IronPort-AV: E=Sophos;i="6.04,276,1695711600"; d="scan'208";a="840374564" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga008.fm.intel.com with ESMTP; 14 Dec 2023 10:40:56 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 1BF5B13A; Thu, 14 Dec 2023 20:40:53 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Patrick Rudolph , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Pavel Machek , Lee Jones Subject: [PATCH v1 1/4] leds: max5970: Remove unused variable Date: Thu, 14 Dec 2023 20:40:08 +0200 Message-ID: <20231214184050.1272848-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20231214184050.1272848-1-andriy.shevchenko@linux.intel.com> References: <20231214184050.1272848-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 14 Dec 2023 10:41:03 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785283774816468240 X-GMAIL-MSGID: 1785283774816468240 leds-max5970.c:50:21: warning: variable 'num_leds' set but not used [-Wunused-but-set-variable] Remove unused variable. Fixes: 736214b4b02a ("leds: max5970: Add support for max5970") Signed-off-by: Andy Shevchenko --- drivers/leds/leds-max5970.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/leds/leds-max5970.c b/drivers/leds/leds-max5970.c index 456a16a47450..7959d079ae94 100644 --- a/drivers/leds/leds-max5970.c +++ b/drivers/leds/leds-max5970.c @@ -45,7 +45,7 @@ static int max5970_led_probe(struct platform_device *pdev) struct regmap *regmap; struct device_node *led_node, *child; struct max5970_led *ddata; - int ret = -ENODEV, num_leds = 0; + int ret = -ENODEV; regmap = dev_get_regmap(pdev->dev.parent, NULL); if (!regmap) @@ -89,7 +89,6 @@ static int max5970_led_probe(struct platform_device *pdev) dev_err(dev, "Failed to initialize LED %u\n", reg); return ret; } - num_leds++; } return ret; From patchwork Thu Dec 14 18:40:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 178866 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp8765181dys; Thu, 14 Dec 2023 10:41:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IEgH9RseBATSpSgbmW2ALi19/RqY+/owS0h3MHTg7iXFEjWYC8nEpk+HelIAQNf5aqRhc2+ X-Received: by 2002:a17:90b:38c3:b0:286:6cc1:2caf with SMTP id nn3-20020a17090b38c300b002866cc12cafmr5001983pjb.57.1702579284716; Thu, 14 Dec 2023 10:41:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702579284; cv=none; d=google.com; s=arc-20160816; b=uzSs2T94ulpYdBabxgOd6POBKdBOjlelbYSz5epPTbYE/7MEkQqBcnJp8FpuP1MkPZ X9uyJjY3ztJt6CRKwSCAnirTucIVhGut/whoyVUzuyyC8AkLDMcr7MDzooJ3T9NELsZM +/fT8GlMYYgLFHcIgh0BVgu5YuGSqzZGPsjPzI4DcYX2cKSNiJkX+J5W99NgCP36ppOM /TeTMdxSvpbG6vZLdKrJv6swSNi8syF4YgCRRYjz/e6WbP7q+1N2g2aBetjyZ14nObyV CxWOvwjjGse1dDejklWOOKqjfFm8rzoHrX2KlPuODeuA9x2lB7kgZQtadKTciMngRMKF d0Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=sw56YCJsL4xhbuGFQ6l9qT7fEkztqJsHA8QlhTS4VbU=; fh=gYRgAXbu/FHO/Cqj/TKspqZnXUXsvaSPLTSdapZ7Ru0=; b=dL5Uxl2jV0IPtXZCwo06jtnOuLnDJn99hyaE+RhTQuO6hJ0hjlRIn+Mjq0WsLehut7 KEQ34dhoy5cCeNDeTiDOWWRtEkrJABdDRSdbEDlWTRBDsAkGcc600ZqmCpEeNAC/i2Gh Ss/TFZlW5LsCEXnsHUEivIqRqOXyJlGFXJ4fWtQO3p1a42AycUh60KZnWrSobNrWd79z 2fJDugZRmK28RRNObhNb/Rn4b4C0epboN5X+uSJbLvntVxUDTXJCKdL10CDDi6UETd7k i4YdrZ/Wn2d9Ze3j82gKurpWtFFj4X1dcR/tNHa/428uWJBJVFPyRO3oYP8gXgWZK9Hq PYHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="H7MHMM6/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id jw5-20020a170903278500b001d09c96ba09si11561947plb.424.2023.12.14.10.41.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 10:41:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="H7MHMM6/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 7ED4580CC12B; Thu, 14 Dec 2023 10:41:10 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573121AbjLNSk5 (ORCPT + 99 others); Thu, 14 Dec 2023 13:40:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1573072AbjLNSkx (ORCPT ); Thu, 14 Dec 2023 13:40:53 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1ED46111; Thu, 14 Dec 2023 10:41:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702579260; x=1734115260; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=tzobM1VNBQfa71tbk5guQU+1z1I5o1Ve5XDjWlrKIeY=; b=H7MHMM6/7Qck/xw8bbwtm4m2q0mfAbrb+FobfXH3FajSTLlx1B+tZI9e foRfZqGuQDQwcOC8Y0uY/N4PrHYAVHmlL8YbbvfMjWw5Ebkqw8eBHrMxU oCTOmJ6wdUYlIyLMyOa4VMY6TAIuQGsqJU2jyJFfbhgeb2n/laJZ++F5r hRqFs1LwTeEBFKpijS6MJQrXWWM7X3LGSi496PPNEkvURY4kUJZWzSXjn 8ox0lDF8zAXYdrV0YFZseb7ndmSfOsoQVRBw3hAsqxXXDLa2p2ggjU8X7 dwjiuMD4TX8UZe2aFIv42xa+ErUAkx5IpNQnS75+JF47Y8Vzh9/E/lmYZ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10924"; a="385582275" X-IronPort-AV: E=Sophos;i="6.04,276,1695711600"; d="scan'208";a="385582275" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2023 10:40:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10924"; a="840374565" X-IronPort-AV: E=Sophos;i="6.04,276,1695711600"; d="scan'208";a="840374565" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga008.fm.intel.com with ESMTP; 14 Dec 2023 10:40:56 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 2BCD23AE; Thu, 14 Dec 2023 20:40:53 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Patrick Rudolph , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Pavel Machek , Lee Jones Subject: [PATCH v1 2/4] leds: max5970: Make use of device properties Date: Thu, 14 Dec 2023 20:40:09 +0200 Message-ID: <20231214184050.1272848-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20231214184050.1272848-1-andriy.shevchenko@linux.intel.com> References: <20231214184050.1272848-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 14 Dec 2023 10:41:10 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785283776078148265 X-GMAIL-MSGID: 1785283776078148265 Convert the module to be property provider agnostic and allow it to be used on non-OF platforms. Add mod_devicetable.h include. Signed-off-by: Andy Shevchenko --- drivers/leds/leds-max5970.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/leds/leds-max5970.c b/drivers/leds/leds-max5970.c index 7959d079ae94..de57b385b4f6 100644 --- a/drivers/leds/leds-max5970.c +++ b/drivers/leds/leds-max5970.c @@ -9,8 +9,9 @@ #include #include -#include +#include #include +#include #include #define ldev_to_maxled(c) container_of(c, struct max5970_led, cdev) @@ -40,25 +41,24 @@ static int max5970_led_set_brightness(struct led_classdev *cdev, static int max5970_led_probe(struct platform_device *pdev) { + struct fwnode_handle *led_node, *child; struct device *dev = &pdev->dev; - struct device_node *np = dev_of_node(dev->parent); struct regmap *regmap; - struct device_node *led_node, *child; struct max5970_led *ddata; int ret = -ENODEV; - regmap = dev_get_regmap(pdev->dev.parent, NULL); + regmap = dev_get_regmap(dev->parent, NULL); if (!regmap) return -ENODEV; - led_node = of_get_child_by_name(np, "leds"); + led_node = device_get_named_child_node(dev->parent, "leds"); if (!led_node) return -ENODEV; - for_each_available_child_of_node(led_node, child) { + fwnode_for_each_available_child_node(led_node, child) { u32 reg; - if (of_property_read_u32(child, "reg", ®)) + if (fwnode_property_read_u32(child, "reg", ®)) continue; if (reg >= MAX5970_NUM_LEDS) { @@ -68,7 +68,7 @@ static int max5970_led_probe(struct platform_device *pdev) ddata = devm_kzalloc(dev, sizeof(*ddata), GFP_KERNEL); if (!ddata) { - of_node_put(child); + fwnode_handle_put(child); return -ENOMEM; } @@ -76,8 +76,8 @@ static int max5970_led_probe(struct platform_device *pdev) ddata->regmap = regmap; ddata->dev = dev; - if (of_property_read_string(child, "label", &ddata->cdev.name)) - ddata->cdev.name = child->name; + if (fwnode_property_read_string(child, "label", &ddata->cdev.name)) + ddata->cdev.name = fwnode_get_name(child); ddata->cdev.max_brightness = 1; ddata->cdev.brightness_set_blocking = max5970_led_set_brightness; @@ -85,7 +85,7 @@ static int max5970_led_probe(struct platform_device *pdev) ret = devm_led_classdev_register(dev, &ddata->cdev); if (ret < 0) { - of_node_put(child); + fwnode_handle_put(child); dev_err(dev, "Failed to initialize LED %u\n", reg); return ret; } @@ -100,8 +100,8 @@ static struct platform_driver max5970_led_driver = { }, .probe = max5970_led_probe, }; - module_platform_driver(max5970_led_driver); + MODULE_AUTHOR("Patrick Rudolph "); MODULE_AUTHOR("Naresh Solanki "); MODULE_DESCRIPTION("MAX5970_hot-swap controller LED driver"); From patchwork Thu Dec 14 18:40:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 178867 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp8765237dys; Thu, 14 Dec 2023 10:41:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IEiXPCXPPnk/mKr+J/yHwHifwekf8Kvu4u+KPbH5uKjg699Jz9cJj3v+0xTuFqiM8t3HSmm X-Received: by 2002:a05:6358:7e97:b0:172:ab3c:b952 with SMTP id o23-20020a0563587e9700b00172ab3cb952mr202883rwn.31.1702579291391; Thu, 14 Dec 2023 10:41:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702579291; cv=none; d=google.com; s=arc-20160816; b=oX7qwlThfF+aQd9enmCj6BUUrhWfyRsXjoNGkuvoN6NWK4DG3RhdEruN7+ir8dHWP+ ma/sfqshmFoX7ia3mIKJc7uqEKUT0K2ssHwKF1/FmJc9WkhN7pZWdFfNTOdYAoA05i2x vqhln29E1AlWi67hxvjpLYJZHDqDirNzpXGzcEk5Dg15k2AMSCtsJuE4ITZHA2IWF6yr mUGI3w728VlAjVURwbcwc7DCQgVT5Lj0yT8/X15XkT8G+8g26/29Hq/v6gPeN772Pplh 21UjXywAQyYYDr0k08ZXbsVRp0p75cnq74YJcGAuzjnduDiMHmv+BLsC5LLPKuP6NItI 3e9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TK9NlbTxDI56GHMUTG1tQI+3qAZA0g+0jgmSrxJAMJM=; fh=gYRgAXbu/FHO/Cqj/TKspqZnXUXsvaSPLTSdapZ7Ru0=; b=vUzhzg61+TWGQIRlvS+m3TOqNTvKR29a20MBoSmdXl9xVdKbQw7oOReBP4/na/Xm7j o3/mPmCidFHJisidnpUrM2AR0WDnuQvoHvQ1TDM6xCJfBaNpN3cJPawkdzHIFa9b6v6q FXFVQjYMQEZdI7hGn7/a9VWdZwsNxf3dBrOejtVuz4T6xtDaVFswhK/29lJaH9SsSXVC 7eLZxhz+inswvOl5gZldTutjbcLco+RFwuengEid/3QbjK0/N0uqAKjd1RF233rDciQN avbvj8S2NTwaKh7c7xcJEoH77hZ0L6JEyWj64ExG3GJiZ7nlpSJ/Bra8/tmnBBXn3wyv vsgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=PnhH0gOR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id z14-20020a63c04e000000b005c6b4e4abe2si11857084pgi.169.2023.12.14.10.41.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 10:41:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=PnhH0gOR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id C5414826FAC6; Thu, 14 Dec 2023 10:41:27 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573084AbjLNSlS (ORCPT + 99 others); Thu, 14 Dec 2023 13:41:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1573124AbjLNSlP (ORCPT ); Thu, 14 Dec 2023 13:41:15 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE20D10F; Thu, 14 Dec 2023 10:41:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702579281; x=1734115281; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=spWRbrUoo3GHPvJawqTt5vlWN5LSpxWaXUCc4b6zvNY=; b=PnhH0gORm5FI1q/3PBOYd32mecI8eniLr8pY4AcSk/VWDVwYcZQAUY7e p6P/2ufKNHXggs5cnM3BR2Hyk0fpuXGmi0dAj7vKYN5F1xXKlPHzY5Uis mzFW96f1Fh8Imh1ilLtVFpLUCQUh7J97HLu9Gb6Z5GM2A787/YcC4ydRU F5W8G0Egq2QQ1W46bsVD/4czyB8UPcfMVvFUezuYUa/1lfTGqnaJtEAjI GpJC6FDtubAPr8c7WI2gz9/CZK6TVuRc+jd/UJPOfHqjvNBWtCywq9Ynm LuVi6GGVJCjNNH+b1WFlw0sm+aKo3ukErR5TRmcAWBphp+7hrBUhlWdtf g==; X-IronPort-AV: E=McAfee;i="6600,9927,10924"; a="461631068" X-IronPort-AV: E=Sophos;i="6.04,276,1695711600"; d="scan'208";a="461631068" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2023 10:40:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10924"; a="803395262" X-IronPort-AV: E=Sophos;i="6.04,276,1695711600"; d="scan'208";a="803395262" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga008.jf.intel.com with ESMTP; 14 Dec 2023 10:40:54 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 3196E44F; Thu, 14 Dec 2023 20:40:53 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Patrick Rudolph , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Pavel Machek , Lee Jones Subject: [PATCH v1 3/4] leds: max5970: Make use of dev_err_probe() Date: Thu, 14 Dec 2023 20:40:10 +0200 Message-ID: <20231214184050.1272848-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20231214184050.1272848-1-andriy.shevchenko@linux.intel.com> References: <20231214184050.1272848-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 14 Dec 2023 10:41:28 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785283783284390630 X-GMAIL-MSGID: 1785283783284390630 Simplify the error handling in probe function by switching from dev_err() to dev_err_probe(). Signed-off-by: Andy Shevchenko --- drivers/leds/leds-max5970.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/leds/leds-max5970.c b/drivers/leds/leds-max5970.c index de57b385b4f6..60db3c28d7d9 100644 --- a/drivers/leds/leds-max5970.c +++ b/drivers/leds/leds-max5970.c @@ -62,7 +62,7 @@ static int max5970_led_probe(struct platform_device *pdev) continue; if (reg >= MAX5970_NUM_LEDS) { - dev_err(dev, "invalid LED (%u >= %d)\n", reg, MAX5970_NUM_LEDS); + dev_err_probe(dev, -EINVAL, "invalid LED (%u >= %d)\n", reg, MAX5970_NUM_LEDS); continue; } @@ -86,8 +86,7 @@ static int max5970_led_probe(struct platform_device *pdev) ret = devm_led_classdev_register(dev, &ddata->cdev); if (ret < 0) { fwnode_handle_put(child); - dev_err(dev, "Failed to initialize LED %u\n", reg); - return ret; + return dev_err_probe(dev, ret, "Failed to initialize LED %u\n", reg); } } From patchwork Thu Dec 14 18:40:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 178868 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp8765336dys; Thu, 14 Dec 2023 10:41:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IFj1yisEoN1kvvvqqiTYX3W1eXuM766VBXIiZrpdtGfCD43BhlQ93kNZtupKSpDn1uSzhf6 X-Received: by 2002:a17:90a:1157:b0:286:2e71:1392 with SMTP id d23-20020a17090a115700b002862e711392mr4440283pje.9.1702579303059; Thu, 14 Dec 2023 10:41:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702579303; cv=none; d=google.com; s=arc-20160816; b=iSYBh9ktqmpY4wQhOSwKBLmMkNa4RVfV05wH1W4oyZcVGnK72BQUL7o6CvHbg0dh0p G1u3i3VXxxxVz4TnSbhK+Lp4df1UkRYYeL6b7sJ1UceJ94+BjNwrzMvFt8na/knQyd8i ESxsnNIRfrdMenOjdYHLlNV1wl8x9riQJhixtR9D4aTUsgK55cww2R2oJ0BwdcZ4yL0o NqroDSmNxk6teaLi4ixYEC87MZqoPjfEk74P4GHTCJM2ShG04w6hX6kEcQdEAy8iIffN OKQfV3LJssTYBzlFVXxBlXnxw9ZvFLjzRGjOqIvEFmdQem4B0ZjAwqV6zV+JvxNUQq8b vkQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vgDR05KaWj1Aud+Ufcq6uerJweYR5z3DPJcEvALjjCI=; fh=gYRgAXbu/FHO/Cqj/TKspqZnXUXsvaSPLTSdapZ7Ru0=; b=i5xHHqN/MRnoiXkFfbFfm2xPBRJan0GbcW5Ud6vt1GUcQb2Ol2wzL4Je4p8ks8w3Un /84nZ7EcJ08cjzWI6wBdXBmS0K340+8DC8LJXpwgF9+KayVIIIN8kqpZqtdBUXxjCJTm I6O/2RiTl9VTM1XMz42nK7b3+NoT9RIgOlySjEdOD6s3U+MF4riZUj4G24HjQy9tOgUn 31teHxiLr3VALlnl18jGn8WX5vb6SlT+ere/m/YglPuzCPaSHStZJJBZlBAtCy+0J0BR AOgheYPVkd+H9Rhp+zJeZxP7BBupGzpz4vyEAtGOD08db41QynfyO7FYundiKoA+88W+ 4wPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=c8VMBTW6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id g4-20020a17090a9b8400b00286b48a6226si12938252pjp.89.2023.12.14.10.41.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Dec 2023 10:41:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=c8VMBTW6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id A98A481972D4; Thu, 14 Dec 2023 10:41:40 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573180AbjLNSlV (ORCPT + 99 others); Thu, 14 Dec 2023 13:41:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1573139AbjLNSlQ (ORCPT ); Thu, 14 Dec 2023 13:41:16 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FA9912B; Thu, 14 Dec 2023 10:41:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702579282; x=1734115282; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ejqGTJqRJV94y5/KtwKcYw2iSBE0q2SaQ5pb83PDPgA=; b=c8VMBTW6kAcPZcH66f2rP+cogRfWLGxZtPDNkDM1TFpKWwLfNVNiduF5 xIhH3XR8VIPjA5qwJlUfrmoLllHLtQE1/JItWfmj4bpue8K+UMFdQZPwk IRVAowZjK1oE4O7LMI3/8LTPRE8j+sCIbBGER9ZyUevF5YAp7P9bxsYM2 hlcmGd9n2C8YI7QnqQoboD621GsUq9xJnhk25z73SQiLmaWI8NHX7MId0 6gn/sa3mmNN0rYYoN0MsjbgsDPEkKPr4ejyI/kyKIixr/+57I7oxK6xeO Rib2NrnNe6FYzakhFSxFWoq5o3OjHj5/b3rGwz3NMr55pbqNYNQHxKTAz Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10924"; a="461631064" X-IronPort-AV: E=Sophos;i="6.04,276,1695711600"; d="scan'208";a="461631064" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2023 10:40:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10924"; a="803395261" X-IronPort-AV: E=Sophos;i="6.04,276,1695711600"; d="scan'208";a="803395261" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga008.jf.intel.com with ESMTP; 14 Dec 2023 10:40:54 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 4511D46D; Thu, 14 Dec 2023 20:40:53 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Patrick Rudolph , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Pavel Machek , Lee Jones Subject: [PATCH v1 4/4] leds: max5970: Add missing headers Date: Thu, 14 Dec 2023 20:40:11 +0200 Message-ID: <20231214184050.1272848-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20231214184050.1272848-1-andriy.shevchenko@linux.intel.com> References: <20231214184050.1272848-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 14 Dec 2023 10:41:40 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785283795403604565 X-GMAIL-MSGID: 1785283795403604565 Don't inherit headers "by chance" from others. Include the needed ones explicitly. Signed-off-by: Andy Shevchenko --- drivers/leds/leds-max5970.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/leds/leds-max5970.c b/drivers/leds/leds-max5970.c index 60db3c28d7d9..56a584311581 100644 --- a/drivers/leds/leds-max5970.c +++ b/drivers/leds/leds-max5970.c @@ -7,9 +7,13 @@ * Author: Patrick Rudolph */ +#include +#include +#include #include #include #include +#include #include #include #include