From patchwork Fri Nov 11 09:38:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 18617 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp643468wru; Fri, 11 Nov 2022 01:45:26 -0800 (PST) X-Google-Smtp-Source: AA0mqf5I5tIUkz/f+jIkFWhszh5IB/6dCArQgAqdvv9kgvzaZJx8xWrg+2tDasa47pxZr7hcFea1 X-Received: by 2002:a17:90a:8a81:b0:214:1caf:d793 with SMTP id x1-20020a17090a8a8100b002141cafd793mr1060197pjn.171.1668159926513; Fri, 11 Nov 2022 01:45:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668159926; cv=none; d=google.com; s=arc-20160816; b=O+ctJgZ5+djADBc55HQQc5+W0wJBEjFFXABtN3gv4nIK4HhgahwW3yeqdXto7zdBJ3 pmSFfrE4zBJdRWYIG0Bs4zLQHZmOaQwzHyPCqn889TV+COAndXQBMWm0pkkb1wZKs6OJ kw7dCO01Z8UnWKtRNRAutUwBQgEazK+0hz2SDdFTI6Ec1E6DxcN292kLUx8Jlo33I7aM sYN3KJ7B8pvFOpbh+XF412eVRJLmDNZi9Iy+EdWoK8nmcmK1RxqZl4rY4u3oh1E/bPA9 g+k6tvPf9FZ164EHBoPAQn/VDFjn4QRmkv79pqMLVLx8ZWHJpCPY2SCie+31SnZwxbjl tFoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=a889/zqrFj85X5Ki/fkeLDXn9m8h9DcUwEsm1IT2RLM=; b=wBIcxkQCBVD6pMt3WyZ8PtpOyz7e7TCWlrQpFA9gP0hT4XJHR1IMsOAW2YViH0MmND SipuUqq1BSsAEY74PIQRn2ym2swyI0ZXuG7G7nXSYfvbjl4xEDhZ5Z077mfVOUDbCNPY rRG812uKRJgZZnBfMyRJxxA5l+t92EHhC2XtD4o4H6l0f7+iikV4gPvum7Iqk+r2PgUZ KOLHqvVZHPPJZGued6Qe/JousNkrKBKg1oPHwpeh0JrICNYS2YYrOy4F1+UvDyKdn5Rb T5/aLlXuPVew6xZH8R9XSzEisLjD4fE+3pSsjZEWh/Nz4C9HTpEpQlxplSssSCzP9dnM x/oQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uYOMf9mB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f1-20020a631001000000b0046ec3bdd048si1837012pgl.484.2022.11.11.01.45.13; Fri, 11 Nov 2022 01:45:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uYOMf9mB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233711AbiKKJk2 (ORCPT + 99 others); Fri, 11 Nov 2022 04:40:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233713AbiKKJkR (ORCPT ); Fri, 11 Nov 2022 04:40:17 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0D3D6CA04; Fri, 11 Nov 2022 01:40:16 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 1EB6ACE2608; Fri, 11 Nov 2022 09:40:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37F69C433D6; Fri, 11 Nov 2022 09:40:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668159611; bh=VAAWEKuCo1e53QmgMf0yNFFYiMrUPT/oqX01uL3eBHM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uYOMf9mBwZBbhzoMGhd/IP5+2FhdEyP88CEu1obynBoQyyOKBbQXgyxjkFgPgrIRw QiADi82aeD1qQW4NTIWVAs1f3Foft+0UQGES3SK3+l3x2SyDXd0GtQtNQIGBNGNP7m HforyS5UYvJld+GOz0Jvu5PFYXLbXrbaItQV0KY1f7ni7cjgsVJnc1a7Gd5MJ9bhKy WBQBebVFHWhhRxfNQRTQGT8Lq4gDqdt1f7/XkDN0CtH+DQ06L6IjAqfgI2sWXjsEzd uiUBKu2ynyv4+WR2zF2xED05NYlimf4sr64ll7gSZaFG2MmzBg4SZ/beIi1/xKVFmZ LvODC0yfkwmQQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1otQVj-0002xh-7c; Fri, 11 Nov 2022 10:39:43 +0100 From: Johan Hovold To: Vinod Koul , Bjorn Andersson Cc: Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 1/3] dt-bindings: phy: qcom,sc8280xp-qmp-usb3-uni: drop reference-clock source Date: Fri, 11 Nov 2022 10:38:55 +0100 Message-Id: <20221111093857.11360-2-johan+linaro@kernel.org> X-Mailer: git-send-email 2.37.4 In-Reply-To: <20221111093857.11360-1-johan+linaro@kernel.org> References: <20221111093857.11360-1-johan+linaro@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749192463039222978?= X-GMAIL-MSGID: =?utf-8?q?1749192463039222978?= The source clock for the reference clock is not used by the PHY directly and should not be included in the devicetree binding. Fixes: e8e58e29a0c9 ("dt-bindings: phy: qcom,qmp-usb: fix sc8280xp binding") Signed-off-by: Johan Hovold Reviewed-by: Bjorn Andersson Reviewed-by: Krzysztof Kozlowski --- .../bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml index ef080509747a..16fce1038285 100644 --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml @@ -22,12 +22,11 @@ properties: maxItems: 1 clocks: - maxItems: 5 + maxItems: 4 clock-names: items: - const: aux - - const: ref_clk_src - const: ref - const: com_aux - const: pipe @@ -82,12 +81,10 @@ examples: reg = <0x088ef000 0x2000>; clocks = <&gcc GCC_USB3_MP_PHY_AUX_CLK>, - <&rpmhcc RPMH_CXO_CLK>, <&gcc GCC_USB3_MP0_CLKREF_CLK>, <&gcc GCC_USB3_MP_PHY_COM_AUX_CLK>, <&gcc GCC_USB3_MP_PHY_PIPE_0_CLK>; - clock-names = "aux", "ref_clk_src", "ref", "com_aux", - "pipe"; + clock-names = "aux", "ref", "com_aux", "pipe"; power-domains = <&gcc USB30_MP_GDSC>; From patchwork Fri Nov 11 09:42:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 18624 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp644071wru; Fri, 11 Nov 2022 01:46:59 -0800 (PST) X-Google-Smtp-Source: AA0mqf4p2Rq1p2GO2oeI4Z8Q0B9hurLfUoZirNQJwjGo/UpCTQfuR5hK21EXq7OtyyC7KTwXWFOM X-Received: by 2002:a17:907:d30e:b0:781:8003:9b08 with SMTP id vg14-20020a170907d30e00b0078180039b08mr1350073ejc.180.1668160019774; Fri, 11 Nov 2022 01:46:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668160019; cv=none; d=google.com; s=arc-20160816; b=CTqGPfHyiPjqCJZlcqiK27WVlDUbsk6LrosfWAbbwh//Kg6km5FGnHhrM96IiNd26D 9s0w/OsgGE2NRBtpcgyALAjUBKKzX1Q9J4W52YlkOuRjs/v7d1/s65Pov+iLRQ9A0HGU JYcTt78Ogu3qdBP1qc1w2VZVwyu2QwMkxQv4EyO+6u1xAfNuav+wuj6c1vogZgQFckqp t30ZJ5YgKbuvWMcMpXAyhVkp5Omigsnwv5cHbArJ2POp4nc+OWWU6juTmRfTGjMNzahI mjJwZwcB26Ds60UUzjRIAOSO5/k80bEEt+p+s4CFHDiEhY10r7yydGBj1WLVd0h7Kgqx 5lTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rh7mey817NKAbE5HlflPPvvTRd0aYNm2kP05+Hn/ioQ=; b=USwf2ttJXEztMQG6aaR/w4A1EcmstBzkCHJhEo7oAi7Is6mRRwiw6f37iEogsB6x4C 1pDp80HCWuC4v42y3a7qldFXqt4SMejm7IyXhnKHkAWZP2oBs5U7sP3EzWXQe+0Bjg5Q eRXUCRMHZB18p4ZSsTErA64bN6E++WoOthgm9jh40nkIwRf4QW8VC8DhLLQRZgOIU1Pj Kchx/5oweRQNtaph6zSgeQRBcogpZfEiLksZ1ZhZF8j0IrKz5r/LVNSwWmPcIOuaMRuS J4cDuV1W0qxBaNilyEy14TmUXLSHvQrIUu7+GorJz8RYDVkdJh+x8bwNZrPNlNIInzAV 6TtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SmTC1BBm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cn15-20020a0564020caf00b00448b88378f8si1441943edb.359.2022.11.11.01.46.36; Fri, 11 Nov 2022 01:46:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SmTC1BBm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233678AbiKKJnd (ORCPT + 99 others); Fri, 11 Nov 2022 04:43:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233685AbiKKJnS (ORCPT ); Fri, 11 Nov 2022 04:43:18 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71AFE78787; Fri, 11 Nov 2022 01:43:17 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 04A8C61F2C; Fri, 11 Nov 2022 09:43:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5BF55C4347C; Fri, 11 Nov 2022 09:43:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668159796; bh=NPLRtc4/Xi9APO2NAgfGkGH+wyMbp8HKKo8ZM8BktiM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SmTC1BBmrJxXcYYRf0fP3bXS4z3EM0EYWeLP9UXr0ulim3nf06NrmRvF0HfJ766kw Krzq1iH5aamZYtsRKqYQys8BlObh/bzCX2qSY3SFPTXmlaiYqtcWG87lhR24fM8sP0 5gNN2VHtaOnvBJQpxwSYonvdk/s6oGfLO+0EbBxTJWLXmR910uSHEki/mEYO9Xw5oV eH3jhao8g3WxHqBVVdYmZjD2SXW3hml5ViNpgpCQUUYuRIfUx8KULpVyiRy41cGTth oMA5bB0MpqmKi9xbz5TTUdIyISQR34+nr8/uPuPFVDFjEmC65DzU+7Hc6sajR09qgC VjiwEg8w5zU8g== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1otQYi-00030d-I4; Fri, 11 Nov 2022 10:42:48 +0100 From: Johan Hovold To: Vinod Koul Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 2/3] phy: qcom-qmp-usb: drop redundant clock allocation Date: Fri, 11 Nov 2022 10:42:38 +0100 Message-Id: <20221111094239.11547-3-johan+linaro@kernel.org> X-Mailer: git-send-email 2.37.4 In-Reply-To: <20221111094239.11547-1-johan+linaro@kernel.org> References: <20221111094239.11547-1-johan+linaro@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749192560703734641?= X-GMAIL-MSGID: =?utf-8?q?1749192560703734641?= Since the QMP driver split, there is no reason to allocate the fixed-rate pipe clock structure separately from the driver data. Signed-off-by: Johan Hovold Reviewed-by: Dmitry Baryshkov --- drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c index 8b111b7087b9..27f2398ebf08 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c @@ -1485,6 +1485,8 @@ struct qmp_usb { enum phy_mode mode; struct phy *phy; + + struct clk_fixed_rate pipe_clk_fixed; }; static inline void qphy_setbits(void __iomem *base, u32 offset, u32 val) @@ -2357,7 +2359,7 @@ static void phy_clk_release_provider(void *res) */ static int phy_pipe_clk_register(struct qmp_usb *qmp, struct device_node *np) { - struct clk_fixed_rate *fixed; + struct clk_fixed_rate *fixed = &qmp->pipe_clk_fixed; struct clk_init_data init = { }; int ret; @@ -2367,10 +2369,6 @@ static int phy_pipe_clk_register(struct qmp_usb *qmp, struct device_node *np) return ret; } - fixed = devm_kzalloc(qmp->dev, sizeof(*fixed), GFP_KERNEL); - if (!fixed) - return -ENOMEM; - init.ops = &clk_fixed_rate_ops; /* controllers using QMP phys use 125MHz pipe clock interface */ From patchwork Fri Nov 11 09:38:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 18621 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp643631wru; Fri, 11 Nov 2022 01:45:51 -0800 (PST) X-Google-Smtp-Source: AA0mqf49sUBIKR41HLMCa14rIiw+IQx9VGcCjTnmjz/HIlsRuYbtuEXBWAY1/d30fPqvOppwSckK X-Received: by 2002:aa7:8e81:0:b0:537:51d3:db1b with SMTP id a1-20020aa78e81000000b0053751d3db1bmr1866906pfr.42.1668159951358; Fri, 11 Nov 2022 01:45:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668159951; cv=none; d=google.com; s=arc-20160816; b=UA9g/rZQHs2UUJl+F9s0vlgRljHP5xN3cWAGniu8RG8U4sBJGtIV2GKulg6b0yJ1ux zuiKBIat4uT0tgl8fLWflzGwgUGwo8Ue3usjigF7ckxnINRvs0qUja+gv/3N2965kpUt R6NHt8SV+je6+hBZidWhzSbXGmT8xartGsEQ8u1Ji+3SN0UCCo+eUZdCmxOjPgidoW8x wTWQIZK9Ep2MuaLieMijZcbn+s+Wim1a6geqtCNivi5VIGclVT9SxBLgHh8i2ITNONlj FtTYZ6PcPrRP27Deds+DaGv7yagLSzIOZJNcaWCzjgGaxKzYJQUW2ntbunj7PcdLYjMI TGUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=B0ELMpZR3SwJ/K+UgOsREDt324cqFbkSbK0jJ7q1V5U=; b=S2zBJlk9qtjfVYKzfWsyRq8dD0QssqSJnNYAg8zJ0mR6gdBkhqXCKuR4vt42CMONMs e9emEICkpm7BYmPxs6aE7nJrWiictRQTkXtNiYBPJ+NMcmBIn8CWEW1e9cwV1mxWzK22 8GRFBlXDnZZWO7qooUc1Z5G+1q7Wffw9h08dBTuzko/6kqHa3WWhdjrRlBrdnpa2GA7L V6ZLTcGUS+nNzbDTYqlZML9bTkd+XVuwuprdS3rkxftoEly9wMZfSOgPioPMuLWGMnUr KzWMV52/548iWqOqkSqb1w83jHwx9Jm0kKGYPxCXuem4i8WQKMppe9YlV5HLSJX4DqL5 GtiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BvB545Se; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z18-20020aa79e52000000b0055cebb19fcdsi1732741pfq.237.2022.11.11.01.45.38; Fri, 11 Nov 2022 01:45:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BvB545Se; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233690AbiKKJkO (ORCPT + 99 others); Fri, 11 Nov 2022 04:40:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233116AbiKKJkN (ORCPT ); Fri, 11 Nov 2022 04:40:13 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C7C7654DD; Fri, 11 Nov 2022 01:40:12 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0F23E61F1F; Fri, 11 Nov 2022 09:40:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4AC53C433B5; Fri, 11 Nov 2022 09:40:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668159611; bh=pwJld/NDv6EFSXj/8bGWt2JYworcFl8ayZrNG0RBYVg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BvB545SeJo3aPXhqnDqx0vrS5nZIUtHJdsgjeJ/QP+3YW3m4h9CpN9abDWqpFNTk0 HrR9sY3Z4gLQFP76NW/irY5vUP/YPJRd3UPBcRxSxor/L/Cu0x7OYotvUjkxNIVddj d9PZ2na8SyjAzvqzL/WJn/kxv7Nxzeo7sZPwynAlfC9Uewpa0lRuKPes76SB9+ho/e jy6pZa6GKjL5OQAFiBDMERdvzvqJTk4I4m+p9KV8q48pwvc/yyudz2Sk3M4x4mdzNI NmGnmVlNyPgWiqVhXOOos6J4Y3dyNn1wqsvmgbpcfNZ1G9h6XVFU3BFKIOc0WNjxmM LL7tGhslsAjpQ== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1otQVj-0002xl-D6; Fri, 11 Nov 2022 10:39:43 +0100 From: Johan Hovold To: Vinod Koul , Bjorn Andersson Cc: Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 3/3] arm64: dts: qcom: sc8280xp: drop reference-clock source Date: Fri, 11 Nov 2022 10:38:57 +0100 Message-Id: <20221111093857.11360-4-johan+linaro@kernel.org> X-Mailer: git-send-email 2.37.4 In-Reply-To: <20221111093857.11360-1-johan+linaro@kernel.org> References: <20221111093857.11360-1-johan+linaro@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749192488971716494?= X-GMAIL-MSGID: =?utf-8?q?1749192488971716494?= The source clock for the reference clock should not be described by the devicetree binding and instead this relationship should be modelled in the clock driver. Update the USB PHY nodes to match the fixed binding. Signed-off-by: Johan Hovold Reviewed-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi index 985138b6adac..531cd68a80ea 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -1595,12 +1595,10 @@ usb_2_qmpphy0: phy@88ef000 { reg = <0 0x088ef000 0 0x2000>; clocks = <&gcc GCC_USB3_MP_PHY_AUX_CLK>, - <&rpmhcc RPMH_CXO_CLK>, <&gcc GCC_USB3_MP0_CLKREF_CLK>, <&gcc GCC_USB3_MP_PHY_COM_AUX_CLK>, <&gcc GCC_USB3_MP_PHY_PIPE_0_CLK>; - clock-names = "aux", "ref_clk_src", "ref", "com_aux", - "pipe"; + clock-names = "aux", "ref", "com_aux", "pipe"; resets = <&gcc GCC_USB3_UNIPHY_MP0_BCR>, <&gcc GCC_USB3UNIPHY_PHY_MP0_BCR>; @@ -1621,12 +1619,10 @@ usb_2_qmpphy1: phy@88f1000 { reg = <0 0x088f1000 0 0x2000>; clocks = <&gcc GCC_USB3_MP_PHY_AUX_CLK>, - <&rpmhcc RPMH_CXO_CLK>, <&gcc GCC_USB3_MP1_CLKREF_CLK>, <&gcc GCC_USB3_MP_PHY_COM_AUX_CLK>, <&gcc GCC_USB3_MP_PHY_PIPE_1_CLK>; - clock-names = "aux", "ref_clk_src", "ref", "com_aux", - "pipe"; + clock-names = "aux", "ref", "com_aux", "pipe"; resets = <&gcc GCC_USB3_UNIPHY_MP1_BCR>, <&gcc GCC_USB3UNIPHY_PHY_MP1_BCR>;