From patchwork Wed Dec 13 17:33:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 178206 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp7944588dys; Wed, 13 Dec 2023 09:34:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IGok6WJ3/JDhwx+Ao7J9dV/JbaJ6a9dIS4WW4EBg9+0JfLTDrw6EMzSwDNCYpCvuaVb7pI+ X-Received: by 2002:a05:6a20:7f94:b0:191:2dc7:573b with SMTP id d20-20020a056a207f9400b001912dc7573bmr3876983pzj.43.1702488875095; Wed, 13 Dec 2023 09:34:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702488875; cv=none; d=google.com; s=arc-20160816; b=wXyup+ej4162VzefZ9HWO82ZY39+eXX7iOLJhoGFVOGQo25zMN1Yy9ePCBZosggqaB ruOqSsbDoSu5UPKSL+f2fCM8om1daq0uOZf15d5ObsFldFzxuk8BHT4hw9M2gUmhaf/1 7o5OBc+Why704o7bCRaSfStqGjaEFWX6I00l7CQWYVxDeM+hKAV+c8N64jmcZvkYUyDG QDxTGds2AG/dijyl+iaybuWbz6odOGfM95ysElayfU6GCXQ6GCCazdCIliFJh+lyP5a0 N6FgorYQy10G9oiUu9EeNIQYD0GLq/OiyJxweifR0oLPeFv+kig+ui2uSybik5nSqqdj r09w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6G4HhTYCgAW82ve0Ur3jREjYxJnJDgZwQEDmCQml3AY=; fh=Hxb5gUnNV+bWwtcQ/Tj2DtiG8sgxTPNybXy8WwmdxRk=; b=0y5gDV8zDmULcridMhuDuQIHLtdyQENzI0TWrHMkSoAvl8ZiJ5FaOwVAb+pn0DR8VM qrB1yzE51MwXghFcB2tZkhF5IfWv6wUUvxbkeQZruBJDIDuxhpmnIIBPwM0vS8ufyStY tcJyV2YOprGd6Mv55kMc+iGRTivYVSHtS/8Juc2EiBRDb0i5pFbSFYuQ0RZdcXH7PGSa gPRNXTEappKe6/iVRqUAlz75o+SXteAjDSd5aeq5qylnc+eCqPXFGPfV89jDmy0pYEIN SzPvUw/r11zIsL3drxao51/Vt+0Ltzv7uTSzk6oFuiD+/ZzYRq9hCZK3hndUMF3N7Vah yVQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RflLWpvd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id n3-20020a632703000000b005b99bfe3301si10056085pgn.462.2023.12.13.09.34.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 09:34:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RflLWpvd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 34276828FAEB; Wed, 13 Dec 2023 09:34:30 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1441905AbjLMReT (ORCPT + 99 others); Wed, 13 Dec 2023 12:34:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379453AbjLMReQ (ORCPT ); Wed, 13 Dec 2023 12:34:16 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAC8A118 for ; Wed, 13 Dec 2023 09:34:19 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C45AC433CB; Wed, 13 Dec 2023 17:34:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702488859; bh=XMvKivJJGzO03vWy8f4JjDdEsuRHzx4sclqP12DcobU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RflLWpvdFlrwNM2Cxcaeoua4o+aUm/Dx4x+WLZCrIy4ySPNKwJtykD+StIkD8bVp2 BoJvs4rWoo+C4r87vHwDnJHwx1N72ytA6gAoRF/OT/zCOdrh7JHQWZolSNmgxzPwiP Ap+5emmCCjRaXb+h/bNxpW8UQGONLrelWTexEtVtWUI9wq0htjLPOuZ/MY3gcWearA oja53QjLKYwSymzUlxaacsCE2Y07JT6lBoaRwmVdDTV883S78jV/nq247LiOGlM6UD QpTYHDXbJZfKOzoGmPwMsdbbX6lLMqvOR5jJoRf49yHUJHRLnzvwGkC/QypF9dEYHC jUNl6SLdw0AKA== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rDT7h-0007gw-1J; Wed, 13 Dec 2023 18:34:17 +0100 From: Johan Hovold To: Bjorn Andersson Cc: Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Kurapati PSSNV , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Vinod Koul Subject: [PATCH 1/5] arm64: dts: qcom: sc8180x: fix USB DP/DM HS PHY interrupts Date: Wed, 13 Dec 2023 18:33:59 +0100 Message-ID: <20231213173403.29544-2-johan+linaro@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231213173403.29544-1-johan+linaro@kernel.org> References: <20231213173403.29544-1-johan+linaro@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 13 Dec 2023 09:34:30 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785188974814680059 X-GMAIL-MSGID: 1785188974814680059 The USB DP/DM HS PHY interrupts need to be provided by the PDC interrupt controller in order to be able to wake the system up from low-power states and to be able to detect disconnect events, which requires triggering on falling edges. A recent commit updated the trigger type but failed to change the interrupt provider as required. This leads to the current Linux driver failing to probe instead of printing an error during suspend and USB wakeup not working as intended. Fixes: 0dc0f6da3d43 ("arm64: dts: qcom: sc8180x: fix USB wakeup interrupt types") Fixes: b080f53a8f44 ("arm64: dts: qcom: sc8180x: Add remoteprocs, wifi and usb nodes") Cc: stable@vger.kernel.org # 6.5 Cc: Vinod Koul Reported-by: Konrad Dybcio Signed-off-by: Johan Hovold Reviewed-by: Konrad Dybcio Tested-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc8180x.dtsi | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi index 7a9cb0418ac1..8f95779c75fa 100644 --- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi @@ -2548,10 +2548,10 @@ gem_noc: interconnect@9680000 { usb_prim: usb@a6f8800 { compatible = "qcom,sc8180x-dwc3", "qcom,dwc3"; reg = <0 0x0a6f8800 0 0x400>; - interrupts = , - , - , - ; + interrupts-extended = <&intc GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>, + <&intc GIC_SPI 486 IRQ_TYPE_LEVEL_HIGH>, + <&pdc 8 IRQ_TYPE_EDGE_BOTH>, + <&pdc 9 IRQ_TYPE_EDGE_BOTH>; interrupt-names = "hs_phy_irq", "ss_phy_irq", "dm_hs_phy_irq", @@ -2622,10 +2622,10 @@ usb_sec: usb@a8f8800 { "xo"; resets = <&gcc GCC_USB30_SEC_BCR>; power-domains = <&gcc USB30_SEC_GDSC>; - interrupts = , - , - , - ; + interrupts-extended = <&intc GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>, + <&intc GIC_SPI 487 IRQ_TYPE_LEVEL_HIGH>, + <&pdc 10 IRQ_TYPE_EDGE_BOTH>, + <&pdc 11 IRQ_TYPE_EDGE_BOTH>; interrupt-names = "hs_phy_irq", "ss_phy_irq", "dm_hs_phy_irq", "dp_hs_phy_irq"; From patchwork Wed Dec 13 17:34:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 178209 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp7944708dys; Wed, 13 Dec 2023 09:34:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IHeaNyNXSkRXPy3uOAkoRNTfZMuwGN0j09Nkqv/FnzppaydeLBl02vVy6foqgeW1LGsGlwV X-Received: by 2002:a17:90a:f00a:b0:28a:f5bd:2b84 with SMTP id bt10-20020a17090af00a00b0028af5bd2b84mr453001pjb.85.1702488885258; Wed, 13 Dec 2023 09:34:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702488885; cv=none; d=google.com; s=arc-20160816; b=IpbQuRfAkFuKDXXPQLFNvmgJWXRIuNxTqxlts3IDBH+kONgJCiFQMb6EPutGBstRoz jVVVO6wIUF9GPId8Pk78vqQPYfCCY82eCQFySRSV/D+Ndzs1RaRttyM7lHvYHOUBdKeu 6ts5FE8yeV+aHAyXjZxF5dGcfLiWCvlbnSnPUsEf7dJNAj4MiUzJ0ZkwKYPdYsiLOf7n 1D5HC34UszSGXCCJgLzgiZE5sVuBXD9QQPGRRW69xYMUQihxdwAHRX57pyeN5v09wNGj gess4udmOmhqBbQW6hmaTtqUogG5SfNE2KP7VA+YAzqgnXs2SQytTmIK1XGFshAZvkGn SXzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=PnANu+p4Ca1TG+bjcEDJgmJyDgQNM7SAqaFt1NTsHGw=; fh=W0vwo+G1jZ0dBT5Mul4bPyEkDBn0Et30sNu4+Wwm3do=; b=dHUn4ma3jf4Jx4+TMMdPiTBgb6rvaIScPUC4J3Hn64lav2wxdK04HPTtyIoEutkoDk NyWIqh4C6I4K043QrvMvHKgjG8ZhFxXS6OfW8P+vhhe3r2pMnN5XdZiOKYxzpPyrEV03 SPyaNH5NY0csRVubgZDTMZkobgPb1jU3zpOt7EE/wTqAaJZ+L4aTVmLhaHr5LbFVbOtR nTCLd5kEk/x0QTDbAMKzBkCslQn51gWCS5IIADVrm5Qrw6ZMfaoM+5S/ChJpyMtgvO33 o251Goe+MJImuweUiDyu6mPV73QIHHAd4CwXy+2er0w2IBlhdepYOE5llV0CEH0+qVKh +zrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="X/vsPDIJ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id d5-20020a17090ae28500b0028688bb3d17si1367195pjz.159.2023.12.13.09.34.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 09:34:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="X/vsPDIJ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id E9EA9822B709; Wed, 13 Dec 2023 09:34:38 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442031AbjLMRe0 (ORCPT + 99 others); Wed, 13 Dec 2023 12:34:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379471AbjLMReQ (ORCPT ); Wed, 13 Dec 2023 12:34:16 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA8B2109 for ; Wed, 13 Dec 2023 09:34:19 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DC4BC433C8; Wed, 13 Dec 2023 17:34:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702488859; bh=z5vRF5xTB2DyU68YJt7eopt5kMmuIX3FIrosJmZo00o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X/vsPDIJdBvT0W9Nu6dz9a57imxvUncs9l5zIGABdEQpyYkMQdJgI2BTGLD5RfLUz 3/e4t0euMXGVnZh/5UzbJd0kPBArG+Y60/uJ5Z2qu49gHRARCNMwVoV+fmGTNjuEQC k3zfR8GCtH3kWTkzE+M3Bu7fPJEIB/mgZOWxOtD6h4jlcAje6BZyV3Uwkqb8uzKGfd M0B8THnNIJAPmVGJZ5+G7rWWrkVrtGYKaWqlyFdgmSDHZ1GTqjb4yUL1mdRnMjNvLN GHI+El/PyoJujlkTfG8VvcL5w/tw3VvaGQePlawcoSxLg5jcYh+A8e+Rhxvgref/1/ N1I2FcHD8mJjg== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rDT7h-0007gy-1Z; Wed, 13 Dec 2023 18:34:17 +0100 From: Johan Hovold To: Bjorn Andersson Cc: Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Kurapati PSSNV , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 2/5] arm64: dts: qcom: sdm845: fix USB DP/DM HS PHY interrupts Date: Wed, 13 Dec 2023 18:34:00 +0100 Message-ID: <20231213173403.29544-3-johan+linaro@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231213173403.29544-1-johan+linaro@kernel.org> References: <20231213173403.29544-1-johan+linaro@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 13 Dec 2023 09:34:39 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785188984959856092 X-GMAIL-MSGID: 1785188984959856092 The USB DP/DM HS PHY interrupts need to be provided by the PDC interrupt controller in order to be able to wake the system up from low-power states and to be able to detect disconnect events, which requires triggering on falling edges. A recent commit updated the trigger type but failed to change the interrupt provider as required. This leads to the current Linux driver failing to probe instead of printing an error during suspend and USB wakeup not working as intended. Fixes: 84ad9ac8d9ca ("arm64: dts: qcom: sdm845: fix USB wakeup interrupt types") Fixes: ca4db2b538a1 ("arm64: dts: qcom: sdm845: Add USB-related nodes") Cc: stable@vger.kernel.org # 4.20 Signed-off-by: Johan Hovold Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 0d2be706505a..97ee02469d69 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -4053,10 +4053,10 @@ usb_1: usb@a6f8800 { <&gcc GCC_USB30_PRIM_MASTER_CLK>; assigned-clock-rates = <19200000>, <150000000>; - interrupts = , - , - , - ; + interrupts-extended = <&intc GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>, + <&intc GIC_SPI 486 IRQ_TYPE_LEVEL_HIGH>, + <&pdc_intc 8 IRQ_TYPE_EDGE_BOTH>, + <&pdc_intc 9 IRQ_TYPE_EDGE_BOTH>; interrupt-names = "hs_phy_irq", "ss_phy_irq", "dm_hs_phy_irq", "dp_hs_phy_irq"; @@ -4104,10 +4104,10 @@ usb_2: usb@a8f8800 { <&gcc GCC_USB30_SEC_MASTER_CLK>; assigned-clock-rates = <19200000>, <150000000>; - interrupts = , - , - , - ; + interrupts-extended = <&intc GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>, + <&intc GIC_SPI 487 IRQ_TYPE_LEVEL_HIGH>, + <&pdc_intc 10 IRQ_TYPE_EDGE_BOTH>, + <&pdc_intc 11 IRQ_TYPE_EDGE_BOTH>; interrupt-names = "hs_phy_irq", "ss_phy_irq", "dm_hs_phy_irq", "dp_hs_phy_irq"; From patchwork Wed Dec 13 17:34:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 178205 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp7944516dys; Wed, 13 Dec 2023 09:34:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IFD0ZaeJPq0OQ6HH6madVFfSvCPRwUGDjYZN/NoJdYw2IG79GejSvelbyxPyTS2BZpUHQJL X-Received: by 2002:a05:6a20:5526:b0:190:2b27:aa34 with SMTP id ko38-20020a056a20552600b001902b27aa34mr8806027pzb.62.1702488869092; Wed, 13 Dec 2023 09:34:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702488869; cv=none; d=google.com; s=arc-20160816; b=iSAgs6TBxT/m8zufU10N4Fa/hfAB3Nsswmvl8KUlk4c0EafTmQIQOaUbC0J0XQW5vd kLPWi7HWXgajPk9RcWhDhiGSSShuVgKT7yRlIelGliwxMxxxN95htm363mSQY1uykRLU jUcEsVBn8HrjENs76XHm/MEqAqYOMHCqxF3Acet84rV55qpQRihKefXRDsf43xxFp8Pp 5pu0Q6zYjLCSW+oED+usuQfGTT6HwisRpDXOmVbBaohXhs4U5DaL90N2j+w6KiCwocTQ leFmkx4CI9S11duwpQWCcCmwcrRpouTxgtQG40QyIiqWhDfuNs3/RrS6Ek3GGM5oTDKR 45Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0VKJoavXrZrZ6qbxuhMqtOAJqWtce2Ko+wg1DkwBkpk=; fh=W0vwo+G1jZ0dBT5Mul4bPyEkDBn0Et30sNu4+Wwm3do=; b=cCwWggQ+eWbLToxFr6OVhN56QsnAKfoRhLwzOIdhh2nHY0WUXi18WaV4txJYLusFWD amqy9cLl3jp1cb5eFuCODSNtVDm5GpcW2e3srRjhLScXzkuleg5Zow6oBiePKvP5zScg fT6i3owOkBh5VdrY7dZlloRgzstbXUYeqUBoXPt67fy5xZek3Kwv8ZhUQ0Lt1aS7Nb8Q JSJCI5EZdr4o9ZM1ljDPpas4KTuxNT3La5jMxn49wbQ1qMYdZwhH2b4KIvMoLINlpfit yexZt+zZIuuPZxmAbQdS87ixumh0Ftz6VETJZ+ddnVzgsqSDLDdHDke3nu51b9ydfVYv 7q8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LE9aIRTo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id x10-20020aa793aa000000b006cbdeec441bsi9566276pff.236.2023.12.13.09.34.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 09:34:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LE9aIRTo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 35C90803FC1B; Wed, 13 Dec 2023 09:34:26 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379472AbjLMReR (ORCPT + 99 others); Wed, 13 Dec 2023 12:34:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235521AbjLMReQ (ORCPT ); Wed, 13 Dec 2023 12:34:16 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA95E10A for ; Wed, 13 Dec 2023 09:34:19 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87BE2C433C7; Wed, 13 Dec 2023 17:34:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702488859; bh=bKFei5Q7xZomKHjqAjdf54ch+KNQbZHCAi1ftfk0a64=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LE9aIRToZm+3jPcamxosX8BHQfI0yTiCcaOngR42aMABEN++T9rdSadRSa7/bogsd kilx0Z+aCaEOc0ecE4E2Ec7XqqrwpuxanbTeYQ/enHywefm3M7snJAvXu+ADErRNBC fUiJrDLkJVK24+GrNs5omoYrSzu5RMoM4Jrb2q5RMv7yuubtAeqteSilOTzThk5kA0 mHNro575T8YzDBdMuUx9okX8iYqGA5KjmwDNqj86LdgU3ZTlbkapLZblbplL5K7dHb PQFVpJvAv0MtsuhRyi+t0jROHolXoXG4mXpsyJSj5mqBayf7GV7FPjr9I2okD0Bxnt CKREM4jF4rLhw== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rDT7h-0007h0-1o; Wed, 13 Dec 2023 18:34:17 +0100 From: Johan Hovold To: Bjorn Andersson Cc: Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Kurapati PSSNV , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 3/5] arm64: dts: qcom: sdm845: fix USB SS wakeup Date: Wed, 13 Dec 2023 18:34:01 +0100 Message-ID: <20231213173403.29544-4-johan+linaro@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231213173403.29544-1-johan+linaro@kernel.org> References: <20231213173403.29544-1-johan+linaro@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 13 Dec 2023 09:34:26 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785188968452765408 X-GMAIL-MSGID: 1785188968452765408 The USB SS PHY interrupts need to be provided by the PDC interrupt controller in order to be able to wake the system up from low-power states. Fixes: ca4db2b538a1 ("arm64: dts: qcom: sdm845: Add USB-related nodes") Cc: stable@vger.kernel.org # 4.20 Signed-off-by: Johan Hovold Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 97ee02469d69..97929954cde6 100644 --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi @@ -4054,7 +4054,7 @@ usb_1: usb@a6f8800 { assigned-clock-rates = <19200000>, <150000000>; interrupts-extended = <&intc GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>, - <&intc GIC_SPI 486 IRQ_TYPE_LEVEL_HIGH>, + <&pdc_intc 6 IRQ_TYPE_LEVEL_HIGH>, <&pdc_intc 8 IRQ_TYPE_EDGE_BOTH>, <&pdc_intc 9 IRQ_TYPE_EDGE_BOTH>; interrupt-names = "hs_phy_irq", "ss_phy_irq", @@ -4105,7 +4105,7 @@ usb_2: usb@a8f8800 { assigned-clock-rates = <19200000>, <150000000>; interrupts-extended = <&intc GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>, - <&intc GIC_SPI 487 IRQ_TYPE_LEVEL_HIGH>, + <&pdc_intc 7 IRQ_TYPE_LEVEL_HIGH>, <&pdc_intc 10 IRQ_TYPE_EDGE_BOTH>, <&pdc_intc 11 IRQ_TYPE_EDGE_BOTH>; interrupt-names = "hs_phy_irq", "ss_phy_irq", From patchwork Wed Dec 13 17:34:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 178207 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp7944605dys; Wed, 13 Dec 2023 09:34:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IGiG6qHK0wMNEAuHDq+pIuzvrMUYA7wjIbaKSS63vRIu9MCZF9OrTkV3e18/5qqWyv4gz0p X-Received: by 2002:a05:6a21:350d:b0:180:e3f1:4f60 with SMTP id zc13-20020a056a21350d00b00180e3f14f60mr6196122pzb.45.1702488877012; Wed, 13 Dec 2023 09:34:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702488877; cv=none; d=google.com; s=arc-20160816; b=Lp2POHAtL79qLlzG32FA5kGLTMCAnS6cAr7OQJoTHVFL7Qe60FWNX62XVOiPDkgCbs zQQloUsN7HktnKCiyidzwjLxYe5dej5x0thgvguBkPYYi4LH0IwsOwHJbTS2RyPMTqzM rEthASQDspryTY48GRARE0/GusQrd5gwdhrLgzSvr4ZCNKgW31nffhY+D2SapJujuyGp CF3+IXu3JHfKpiKgeY8obevdorif4WfD0ZRL1S6Dfe4aAbmGyOJ6E6apjl6H+7HjhEDg pFr3wOIhukMLpAaETupHGMAz4UDoiiFmbuteJBVCszjonkioQM81B2yA3qQJXLLTeMlz 8E1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mayrIzhIUG4GxM47FJvizbZf63OeKCz4qXO3SrVyK1Y=; fh=ywdrdXeIHcQAUFhuz0DBHIi6ku0Hkg0CuIKtz1mRIEM=; b=u5sCrwyYMmLb32+0tMo7CF6vmFYaFqwdoBwxGiHRhBWUnkjpO3j70BRBT6CjOXME90 60VDp8cR+mFVSPihZJx2abcvMnAxHhDcDmgZ5Qh/3TkGi9o/df5SQiwV6Sj0gUonZN/U rctvAcXJxlqlwTTfky1RzmTOhia+ktA598od5/BCrZkbJUjXA9KLvyCyXmW4O6RomLDD GPNjDGXW6Tx13tLff7Bz/LTvHsik2E+EmRXh9HvpSvESykSYHipBZvCLevOWIj3RT3bH G/4pMa66Y/1AzLq+oWE1l/KnUQbwSfb8usiDsoJ/rAkE+skOrvUTjYt7sBxtgtFQcrh9 f+ag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=F6RvUEyw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id h10-20020a63e14a000000b005bdbcf7c446si9886978pgk.171.2023.12.13.09.34.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 09:34:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=F6RvUEyw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id E4322803FC20; Wed, 13 Dec 2023 09:34:32 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1441893AbjLMReV (ORCPT + 99 others); Wed, 13 Dec 2023 12:34:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379458AbjLMReQ (ORCPT ); Wed, 13 Dec 2023 12:34:16 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB06E11A for ; Wed, 13 Dec 2023 09:34:19 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A0C1C433CA; Wed, 13 Dec 2023 17:34:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702488859; bh=zUS79ODlcUHdcw7GpM0p1moR96wliFW3D6A0bvOI7P4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=F6RvUEywvvZvOoGVZSHHfB2Dm/a/D+tEoiCECVRLLQ8Z4SvsGjWY4zOumUcz1Pq/W sPIBrBhcSW075LSfouK1LngszdVvzSx8jnF6sGcMGLYIJMC5Xq0hWhFdCH6I1fK+k9 CG2//gFWlRZwKmX66QeJJ9jREjHuaNfdYoh/u36GH4OfQprPIAWA5Cy8J24Lv+6a9z AiZb/lzO1l2gEMBPIKPhXbn1g0ZnIUByAyxpNQKoL9y5So9mbtJghsjAUtkFF9Nnbn tNrGZndVMSPXxVnVi7fH+s4Dn1rkrNLtYrolH2jblxaDOOh+/pUrlOIW6TkIx9PUqJ bZtg6RhUgVLNw== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rDT7h-0007h2-23; Wed, 13 Dec 2023 18:34:17 +0100 From: Johan Hovold To: Bjorn Andersson Cc: Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Kurapati PSSNV , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Jack Pham , Jonathan Marek Subject: [PATCH 4/5] arm64: dts: qcom: sm8150: fix USB DP/DM HS PHY interrupts Date: Wed, 13 Dec 2023 18:34:02 +0100 Message-ID: <20231213173403.29544-5-johan+linaro@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231213173403.29544-1-johan+linaro@kernel.org> References: <20231213173403.29544-1-johan+linaro@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 13 Dec 2023 09:34:33 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785188976746166457 X-GMAIL-MSGID: 1785188976746166457 The USB DP/DM HS PHY interrupts need to be provided by the PDC interrupt controller in order to be able to wake the system up from low-power states and to be able to detect disconnect events, which requires triggering on falling edges. A recent commit updated the trigger type but failed to change the interrupt provider as required. This leads to the current Linux driver failing to probe instead of printing an error during suspend and USB wakeup not working as intended. Fixes: 54524b6987d1 ("arm64: dts: qcom: sm8150: fix USB wakeup interrupt types") Fixes: 0c9dde0d2015 ("arm64: dts: qcom: sm8150: Add secondary USB and PHY nodes") Fixes: b33d2868e8d3 ("arm64: dts: qcom: sm8150: Add USB and PHY device nodes") Cc: stable@vger.kernel.org # 5.10 Cc: Jack Pham Cc: Jonathan Marek Signed-off-by: Johan Hovold Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi index 3e7048d8ac55..5e46b9ef8642 100644 --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi @@ -3565,10 +3565,10 @@ usb_1: usb@a6f8800 { <&gcc GCC_USB30_PRIM_MASTER_CLK>; assigned-clock-rates = <19200000>, <200000000>; - interrupts = , - , - , - ; + interrupts-extended = <&intc GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>, + <&intc GIC_SPI 486 IRQ_TYPE_LEVEL_HIGH>, + <&pdc 8 IRQ_TYPE_EDGE_BOTH>, + <&pdc 9 IRQ_TYPE_EDGE_BOTH>; interrupt-names = "hs_phy_irq", "ss_phy_irq", "dm_hs_phy_irq", "dp_hs_phy_irq"; @@ -3618,10 +3618,10 @@ usb_2: usb@a8f8800 { <&gcc GCC_USB30_SEC_MASTER_CLK>; assigned-clock-rates = <19200000>, <200000000>; - interrupts = , - , - , - ; + interrupts-extended = <&intc GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>, + <&intc GIC_SPI 487 IRQ_TYPE_LEVEL_HIGH>, + <&pdc 10 IRQ_TYPE_EDGE_BOTH>, + <&pdc 11 IRQ_TYPE_EDGE_BOTH>; interrupt-names = "hs_phy_irq", "ss_phy_irq", "dm_hs_phy_irq", "dp_hs_phy_irq"; From patchwork Wed Dec 13 17:34:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 178208 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:3b04:b0:fb:cd0c:d3e with SMTP id c4csp7944695dys; Wed, 13 Dec 2023 09:34:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IHFeIeI88c6WMWP77xrGIgS2HIrZLsJazIHQRdTv16B7JL2W8lIq80kBwmxD0KqsiTaTVB9 X-Received: by 2002:a17:902:b408:b0:1d2:ec54:894b with SMTP id x8-20020a170902b40800b001d2ec54894bmr8270693plr.61.1702488884408; Wed, 13 Dec 2023 09:34:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702488884; cv=none; d=google.com; s=arc-20160816; b=O190bkts5cWmpGD9fXJGp5OOZsLSOLUAfSjwDCONi7kvFK9ry2DfifmiucOzJGqipc BTeXXRZMuLMMFS76zMAD/AnMYhK7kvDCq0hQlA6mIexY+ifSyQb5MfELa1F0+9ECu5QU TFFDbNu/ZcnZzb5BMixQg31WCU84eBHtuyt9L3wrzq2ZTwFYW2Q7xxdhYlRu74O7pMak Nr5t0Sx+ItFETW3XDdwBgh3mjBrtejc2tElWjeEbbGQWC9718AV9a108AqtJARbeNBxX wRQD10qU14ZH7cYJeEFH8tjdSvVazsGADsT5H3uWuutY5/jUBCH1pRLZejpHkP126LjX Z1Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hyo+Py/7KSA8LbLbJ7v7kV2GvqKisjF2vM0lhQKIiwg=; fh=ywdrdXeIHcQAUFhuz0DBHIi6ku0Hkg0CuIKtz1mRIEM=; b=BZnvU8QbNTGab20FbV7OmXz+KA/M7uFpfEKUp3RxUSJcsqLxK0ru4CSYofgQowVb8V GWDSmd2XZ8y32HNCm+t2aLvd+NwKZfVs3jZwx5KX7BoatQ2FZb6S1/EvoRhXEwlo4J6E Yu/DStsx3vb8IDJnUg6/jWQFLt4oNnLBpJRN2fcJeTe5flcO96rcX9TE3rcGXEo38mXJ uQpY6qsCqVGF3dekbcRhwqXejwKbL13///rBYxAzuCC2dQKCQ6PEw99PKYwcxCrz7YmE 6Xe3tiU2BPQQ/wdBQN5HND2WRS1jukjp0Ibe5PdMTruIbLGF3HS2ePtG8Sziubj8x0K2 O/Bw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=c6pAKJKP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id t6-20020a170902b20600b001cdf0388455si9725981plr.111.2023.12.13.09.34.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 09:34:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=c6pAKJKP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id D45A7803FC28; Wed, 13 Dec 2023 09:34:39 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1441988AbjLMReX (ORCPT + 99 others); Wed, 13 Dec 2023 12:34:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379459AbjLMReQ (ORCPT ); Wed, 13 Dec 2023 12:34:16 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00E5A11B for ; Wed, 13 Dec 2023 09:34:19 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8EEF0C433C9; Wed, 13 Dec 2023 17:34:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702488859; bh=pOzeZqYCumnmyLY7QOO5p/wpjgqUMF/9UXyX7tE2MGk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c6pAKJKPxD9ImO3af3kB3QdIS3Vukdcv56y93m+ANRPOWTLMMrf3y1jkOIhRrEHVT mFAQsnGxpWTs1lRk/Lq+02Cxt+pzoDzvwhPf0q6zmZy9hkMrY53g30Za5vSTlnbyYf z77fjnWKBxyygARx8tvDSHvPdS0lKAPWfGoOEoB8Zb1x09Qae0HmtnhSvx3IiNqjh1 JkJw7K1QY26j5US1ioosTjGz6iu9YsFL8zICiixoSxxpwh/KTa6Rh5gnjIF3jDHGM8 0BbGniqbEzvUaa5/qu7L1r6F2FWM3OrXDKPQ0DQWi1p2/Vn2iIc62v5hYiG3l2oBTH q0mjZia+cOJ0Q== Received: from johan by xi.lan with local (Exim 4.96.2) (envelope-from ) id 1rDT7h-0007h4-2I; Wed, 13 Dec 2023 18:34:17 +0100 From: Johan Hovold To: Bjorn Andersson Cc: Andy Gross , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Krishna Kurapati PSSNV , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Jack Pham , Jonathan Marek Subject: [PATCH 5/5] arm64: dts: qcom: sm8150: fix USB SS wakeup Date: Wed, 13 Dec 2023 18:34:03 +0100 Message-ID: <20231213173403.29544-6-johan+linaro@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231213173403.29544-1-johan+linaro@kernel.org> References: <20231213173403.29544-1-johan+linaro@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 13 Dec 2023 09:34:40 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785188984515153619 X-GMAIL-MSGID: 1785188984515153619 The USB SS PHY interrupts need to be provided by the PDC interrupt controller in order to be able to wake the system up from low-power states. Fixes: 0c9dde0d2015 ("arm64: dts: qcom: sm8150: Add secondary USB and PHY nodes") Fixes: b33d2868e8d3 ("arm64: dts: qcom: sm8150: Add USB and PHY device nodes") Cc: stable@vger.kernel.org # 5.10 Cc: Jack Pham Cc: Jonathan Marek Signed-off-by: Johan Hovold Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi index 5e46b9ef8642..56c74a841d80 100644 --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi @@ -3566,7 +3566,7 @@ usb_1: usb@a6f8800 { assigned-clock-rates = <19200000>, <200000000>; interrupts-extended = <&intc GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>, - <&intc GIC_SPI 486 IRQ_TYPE_LEVEL_HIGH>, + <&pdc 6 IRQ_TYPE_LEVEL_HIGH>, <&pdc 8 IRQ_TYPE_EDGE_BOTH>, <&pdc 9 IRQ_TYPE_EDGE_BOTH>; interrupt-names = "hs_phy_irq", "ss_phy_irq", @@ -3619,7 +3619,7 @@ usb_2: usb@a8f8800 { assigned-clock-rates = <19200000>, <200000000>; interrupts-extended = <&intc GIC_SPI 136 IRQ_TYPE_LEVEL_HIGH>, - <&intc GIC_SPI 487 IRQ_TYPE_LEVEL_HIGH>, + <&pdc 7 IRQ_TYPE_LEVEL_HIGH>, <&pdc 10 IRQ_TYPE_EDGE_BOTH>, <&pdc 11 IRQ_TYPE_EDGE_BOTH>; interrupt-names = "hs_phy_irq", "ss_phy_irq",