From patchwork Fri Nov 11 09:04:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: xu X-Patchwork-Id: 18582 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp629152wru; Fri, 11 Nov 2022 01:06:17 -0800 (PST) X-Google-Smtp-Source: AA0mqf7pxDCufW8YS2mQfTN0XzA0ngUy8teiswdvggA57xgAJVbe0HvyKn3cR1Qxtmsn8+UOfX28 X-Received: by 2002:a05:6402:22f8:b0:461:60e8:7ac3 with SMTP id dn24-20020a05640222f800b0046160e87ac3mr650024edb.80.1668157577385; Fri, 11 Nov 2022 01:06:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668157577; cv=none; d=google.com; s=arc-20160816; b=GR3p6PmQYEZQKOirFPg9HbhfvW2GgQ/l4i6NGOwXSquhprFUzi5EC70OmgqL/XulU8 hSDVw1AC5NHpAkdQw98DDauHnJ73IyXGiIWzAvEu9hoPvjF9AWmwRQqmpkWYeROJP40U gLS4Z4cOdwh4q5O9aYE6iGsPGKRLTg1Ny1SifM72IiIyewa+Q4XgdqBpDEweuOD3cE2L 7g4saTGCZDjejnne0oJAuTJdIgXX4dCr8zcQlARrWhMtq8qjK9scTuHP6NnADCBhx3fB VlixesnzOXdRaN3la2JjqIwIicnFEH2wWfsgKYDnNFugrVqcQnMW/na3BonkzJOgiy2M JlCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=fRlLUlsxf2yRq+biVPsvrOIU+jGYg4EFs8dRHlFQCiM=; b=EOrcS2p0WkPyIGOY6c0kgcMrWNfiAc7KDwDDSOVMAPYORlNEGY3fkeI8qgNYQY4E2B DA4tvi42lD1JKZH8u4WtUnx66tNTkrcMTmdKlLXgZAE9toZ+L8LfdBMof2sPtZ4o/U8F uTqY2NswNEOBUTjdfPWSHPdC8N+IH0R0rM0q0Dhu+TL0HYFjPMUaT/uFbMbDBPKgNOz7 KyA1tBQiawzGBDgDtTGoEr9nHqIet4040CJwgXyWQIpbqMdEC9OzHPh/emaPqJSwlSjU fQORsb4JMnl7tvvww5JkG0WSMoo0+gEx8yhPfCEg4XH3Z2NDjW460faoTcGY3VYuYoqi BkPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=eoinuhlf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nb23-20020a1709071c9700b0073d9c412570si1733938ejc.785.2022.11.11.01.05.54; Fri, 11 Nov 2022 01:06:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=eoinuhlf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233592AbiKKJFR (ORCPT + 99 others); Fri, 11 Nov 2022 04:05:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232943AbiKKJEy (ORCPT ); Fri, 11 Nov 2022 04:04:54 -0500 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41939E0FF; Fri, 11 Nov 2022 01:04:37 -0800 (PST) Received: by mail-pj1-x1041.google.com with SMTP id l22-20020a17090a3f1600b00212fbbcfb78so7232417pjc.3; Fri, 11 Nov 2022 01:04:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fRlLUlsxf2yRq+biVPsvrOIU+jGYg4EFs8dRHlFQCiM=; b=eoinuhlfGT04Lfrw+Bt3sB5LfN/Nlj6nZb2kr3L4Xcan1rVgzTV5prYN7dTcoOZwIY X6MyJarwFIZsyyl+EkUoD3lOtx0sE27N60MJjdYdrgHBxnlAmzP46+XNReFWoYEtPT4/ PK+UvsWp3ya4v2vdPri+OzPJGl6u7o7ZIUAqdTEsFfXX7hAmzdRz5kMZZ0E1LoZRsYHk L8hxs7Ze1E4DAFFZrla1hIRbFEXs/GOP9wuLfZ1iAOtDVDgc4eaHCgI0umXOtxCQZ8vJ pQsG2AvO0IY+XhfdSE4uvFMHdAqOZ7WA3rwWdNeCS3R8PZzI9SyKDsusoBynZKK5DnpY LG8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fRlLUlsxf2yRq+biVPsvrOIU+jGYg4EFs8dRHlFQCiM=; b=qRIQOxAaYR7maplTFqJxIAPBm0D4ekRHudJ0E5hYZA2uhWDMyhtFkRE5RBoqn2ntvJ 0ewjnx21gS3644NXRhuZrJEpgPWQNtlsBBB8r1HaPN/TAh7UW7YE2SfST29yQSdlcKin FsO5eMTfe1adMnTTyF/diRsjy/xiugBF572LzaWfmby0W+fzm8qUz5jFsRI53HWbJeIu Ls46RfhNYsVKxEm9JxsCQ7tApwswcViEpqwqrD+LnhrXRADh+0vj38V6RJO05U6KwP29 NO6KtDPniW2eJNETCBFW44w2qr1Cj/ChUZNajTeAgHgqEYDUBS7dbs8xurt6tE0m+rL0 gkjQ== X-Gm-Message-State: ANoB5pn9aXbC2yzLwFQ/L0l56TOelU3C7SSy2PIOYjqQ1k5EhPtoE/PZ lxiWXvLG9NiJDBS+1qaivgg= X-Received: by 2002:a17:902:7c0c:b0:188:5681:4dc7 with SMTP id x12-20020a1709027c0c00b0018856814dc7mr1387819pll.97.1668157476750; Fri, 11 Nov 2022 01:04:36 -0800 (PST) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id e17-20020a17090301d100b00177f25f8ab3sm1178005plh.89.2022.11.11.01.04.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Nov 2022 01:04:36 -0800 (PST) From: xu.xin.sc@gmail.com X-Google-Original-From: xu.xin16@zte.com.cn To: edumazet@google.com, davem@davemloft.net Cc: yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xu xin Subject: [PATCH linux-next] ipasdv4/tcp_ipv4: remove redundant assignment Date: Fri, 11 Nov 2022 09:04:20 +0000 Message-Id: <20221111090419.494633-1-xu.xin16@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749190000116863212?= X-GMAIL-MSGID: =?utf-8?q?1749190000116863212?= From: xu xin The value of 'st->state' has been verified as "TCP_SEQ_STATE_LISTENING", it's unnecessary to assign TCP_SEQ_STATE_LISTENING to it, so we can remove it. Signed-off-by: xu xin --- net/ipv4/tcp_ipv4.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c index 7a250ef9d1b7..0180f3cefa9c 100644 --- a/net/ipv4/tcp_ipv4.c +++ b/net/ipv4/tcp_ipv4.c @@ -2478,7 +2478,6 @@ static void *tcp_seek_last_pos(struct seq_file *seq) case TCP_SEQ_STATE_LISTENING: if (st->bucket > hinfo->lhash2_mask) break; - st->state = TCP_SEQ_STATE_LISTENING; rc = listening_get_first(seq); while (offset-- && rc && bucket == st->bucket) rc = listening_get_next(seq, rc);