From patchwork Wed Dec 13 03:46:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ethan Zhao X-Patchwork-Id: 177768 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp8161583vqy; Tue, 12 Dec 2023 19:48:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IEnuAhms6KsGutPQJaFr+YEcvNgng+sJP9u63RSGq6+wx+MuUkFrg8LzLedZDEtmpbCOT2F X-Received: by 2002:a05:6808:3998:b0:3b5:6533:d2cb with SMTP id gq24-20020a056808399800b003b56533d2cbmr11273819oib.46.1702439280985; Tue, 12 Dec 2023 19:48:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702439280; cv=none; d=google.com; s=arc-20160816; b=I3344kdIcucfkfa47oYbghMlY/3cMbDicDqhCeFGhfQOF2Uge0/H2pG9CFRuspVOvu 97oCBeu7uajVZXpMXeOvmjqsV87T8iKzm+EncVETimRCC3Mqb67bDUF2pHuA9OkVhKDR RbzSpZ8G+w7p6iNbV2JtyA0A2zUMF9j374WUtqj4U6H6niLsI230kWyGHSc+JJu7r533 Y7EA4Y/ii+XfLsIZpWg1a9x0+gXRsUdMMpQNJrEp2d/vS8cO7N9YUoWTwxHL3ZBrQZOz 9Z3jtRKtdjZPwRdmxfrnY2DhpFH+NsL13XVs6keyD5ufs1PRS+h6ddsE/yW1HWTboUrf vJIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=5EgGsxBwtN/mkxbKDd2rmgkAazFD6pgCNOEYwIGz1BE=; fh=vmzOgBHRo0b47ndbHKSjrphRxaDCuTUw5d6AQjVFIEo=; b=IokozQfCp9j1usshPpo4SjQYm9w7QyJqwceiH14d7X/Ks70pZ4yY95ae7QRf+ZgvNZ rLOS756I/H18JWeDQYCDqZegzyJFTDPskJsVf6MqXu4q7Xv6afbhBkloZRhP91I1qxeA 5cyLYoP0uQu+ZwC3UfLkfUOy6H3nvcA8g+M8CFt820vwO0ERZ6yx/59MdO2642QAI9Ya OUVQs2JkRk1SDiBd1hH7s0jJ6CtLByn/gzdyalCkGMPRV8wdOVE76AQmY/nlNrbb7h9e UDBKiEjtutRuHC4y6fA/zr9Cts16daewikbYNT9Ibf01rw9pOdnswY91iYNGgGAqtFmn 01AA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=clL4F5q2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id 19-20020a631753000000b005c61d17e6aasi8934239pgx.122.2023.12.12.19.48.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 19:48:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=clL4F5q2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 0DE72809C436; Tue, 12 Dec 2023 19:47:58 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378438AbjLMDrb (ORCPT + 99 others); Tue, 12 Dec 2023 22:47:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378428AbjLMDr3 (ORCPT ); Tue, 12 Dec 2023 22:47:29 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F1B69C; Tue, 12 Dec 2023 19:47:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702439256; x=1733975256; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TljuoHGjQTdNL/8N4wKTVKbm0YrUiASyUSEokPW3tOo=; b=clL4F5q2Ncf53dBZ+la6Gr/JknOVcE6qSif2EdYK2I/9MIB2yFcSKDfl hA+30f15HMPKqgfv4XpgGUWWuSLVd+aqJOcvX/FRU6V64xOBPGkaviMeM FyGNwr5wiAwO4JKepllKWqEza1lag8vVj04eCWUgOljniDW2j2G9oayOG avKEkA6iEPJuBFPDvafESm+RT6No/Pu8chWKhc17ARWlWW7O6QMR34kiO iodbzT91rpEuXYajxdtyzQ/m+eOnLDDspu4H9lhh7moDK2ChYGwKJFR/r 7jjgP79u3ANCMlJ7bD6M7r3iOIIgfmHlEgzmFvuliZYVseY/YwD9ceFm1 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10922"; a="459227277" X-IronPort-AV: E=Sophos;i="6.04,272,1695711600"; d="scan'208";a="459227277" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2023 19:47:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10922"; a="897175460" X-IronPort-AV: E=Sophos;i="6.04,272,1695711600"; d="scan'208";a="897175460" Received: from ply01-vm-store.bj.intel.com ([10.238.153.201]) by orsmga004.jf.intel.com with ESMTP; 12 Dec 2023 19:47:33 -0800 From: Ethan Zhao To: bhelgaas@google.com, baolu.lu@linux.intel.com, dwmw2@infradead.org, will@kernel.org, robin.murphy@arm.com Cc: linux-pci@vger.kernel.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, haifeng.zhao@linux.intel.com, Haorong Ye Subject: [PATCH 1/2] PCI: make pci_dev_is_disconnected() helper public for other drivers Date: Tue, 12 Dec 2023 22:46:36 -0500 Message-Id: <20231213034637.2603013-2-haifeng.zhao@linux.intel.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20231213034637.2603013-1-haifeng.zhao@linux.intel.com> References: <20231213034637.2603013-1-haifeng.zhao@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 12 Dec 2023 19:47:58 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785136971292861785 X-GMAIL-MSGID: 1785136971292861785 move pci_dev_is_disconnected() from driver/pci/pci.h to public include/linux/pci.h for other driver's reference. no function change. Tested-by: Haorong Ye Signed-off-by: Ethan Zhao --- drivers/pci/pci.h | 5 ----- include/linux/pci.h | 5 +++++ 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index 5ecbcf041179..75fa2084492f 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -366,11 +366,6 @@ static inline int pci_dev_set_disconnected(struct pci_dev *dev, void *unused) return 0; } -static inline bool pci_dev_is_disconnected(const struct pci_dev *dev) -{ - return dev->error_state == pci_channel_io_perm_failure; -} - /* pci_dev priv_flags */ #define PCI_DEV_ADDED 0 #define PCI_DPC_RECOVERED 1 diff --git a/include/linux/pci.h b/include/linux/pci.h index 60ca768bc867..869f2ec97a84 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -2503,6 +2503,11 @@ static inline struct pci_dev *pcie_find_root_port(struct pci_dev *dev) return NULL; } +static inline bool pci_dev_is_disconnected(const struct pci_dev *dev) +{ + return dev->error_state == pci_channel_io_perm_failure; +} + void pci_request_acs(void); bool pci_acs_enabled(struct pci_dev *pdev, u16 acs_flags); bool pci_acs_path_enabled(struct pci_dev *start, From patchwork Wed Dec 13 03:46:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ethan Zhao X-Patchwork-Id: 177767 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp8161525vqy; Tue, 12 Dec 2023 19:48:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IG21nN4WnNRbfXC8l2x+U/M04eU51NJBcKAY1zskEgqPwXookdKwHhqrV6J9COfJsJJRpt7 X-Received: by 2002:a05:6e02:180c:b0:35d:59a2:a335 with SMTP id a12-20020a056e02180c00b0035d59a2a335mr8778873ilv.55.1702439285651; Tue, 12 Dec 2023 19:48:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702439285; cv=none; d=google.com; s=arc-20160816; b=omzQdVcaWej2COyDG84fnEFYYREhx8h04LsyA6r1LPDTZ1XVKpsUmgtx+gF4oBstf4 GGOWdVjkJaJt/QOWiqV6t2CvoP6o7UmRs9BxaZKOAaWDOPIc1OXYbP73JlVTZ59lq43+ KUNt8VAl2fyvGbBcWeYuuiSTPEZC59vUb7903TvntRmikd1uRDd/Kksyi493hd6+SSjQ B82kSx8pRwu5VF2KdON1UtODl6ag0Jeh3lli6Z8lT95U3ya13qXr+WcJ5qp1p6VoiX6H LkCjmTQcCy2igildWLamESRFCRv8YpxYoETXIjfduMkpa9cZZsgYQxsfi2j6CMlnFgU9 k0jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AScftg5s0VcV3VDbDnO8iiE24Mfht5cDkYR//ERJ7pU=; fh=vmzOgBHRo0b47ndbHKSjrphRxaDCuTUw5d6AQjVFIEo=; b=quqEx/pZkaKaXmHFzTN1TlDS040CJArTUkhZqFcoe5ohLVv4GfIAxl+4ovPc+ztGM5 Y4ipVWuQSFs5VZecBExVh/3FI8IwELx5AsL8W6/HMRahzQUeDm6cdodhCQBjI/8VlgKe jgJXqZjQuSNJAHMpWtDGKq5BCtX/e6XwL7fbXkMZMS63r1zVDmIwZO1NC60x3RO+B7kM aozyDSmqbkFHpyjA5lvMdxk5B4Pxdt2MGYTOMtg0/kjKtOKJ/11RC1IW/76mjj3+Ep9a SsmjfhcdKyPTJYFX+qfwWu3DiyGDeGyJhbc7XKOzi4qwrjwKB7qdl5md1GGGFf1Du5al 8/Wg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ApaXJc4I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id g15-20020a1709029f8f00b001d0cc5485cesi8714150plq.523.2023.12.12.19.48.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 19:48:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ApaXJc4I; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id D127A80898C3; Tue, 12 Dec 2023 19:48:00 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378460AbjLMDri (ORCPT + 99 others); Tue, 12 Dec 2023 22:47:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378428AbjLMDre (ORCPT ); Tue, 12 Dec 2023 22:47:34 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C553ED0; Tue, 12 Dec 2023 19:47:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702439259; x=1733975259; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=B0KlMDNHCldjdyfUi/l+xjoBy1Qj+yUpfSFp9f4RKbA=; b=ApaXJc4IavNsYZEuL+BPj2Wr/gL4P+1QssXpa8WSh1rqQO6bwddo85kN 4aU0GywCs9tNQPAitQVcg7TxntLuGXGDlUpJ2moN1FqUKlU5jSX57Mc4H gDHT0UBYifjcnPEpyeFo+HPAA/4mkK3nCdxURnpLdt2HuJNmPsrh2n3+w j9D8DcuPryERNOIGz2krUijDeS8Pxj4+f6EO9hTCJ+3K9B/J5EAsZgVxA 8gkjAT7Poe+iRRfyqxn8Z+4T58+MiUwe3JgLEPkSMZDvcgHEnNge/Y0pf nZBVN0wwoJNVJkCLVzQBT3m/wQsn+HY6XT+8LWHvnDYfgLCPwtMAdEVPT A==; X-IronPort-AV: E=McAfee;i="6600,9927,10922"; a="459227285" X-IronPort-AV: E=Sophos;i="6.04,272,1695711600"; d="scan'208";a="459227285" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Dec 2023 19:47:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10922"; a="897175469" X-IronPort-AV: E=Sophos;i="6.04,272,1695711600"; d="scan'208";a="897175469" Received: from ply01-vm-store.bj.intel.com ([10.238.153.201]) by orsmga004.jf.intel.com with ESMTP; 12 Dec 2023 19:47:36 -0800 From: Ethan Zhao To: bhelgaas@google.com, baolu.lu@linux.intel.com, dwmw2@infradead.org, will@kernel.org, robin.murphy@arm.com Cc: linux-pci@vger.kernel.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, haifeng.zhao@linux.intel.com, Haorong Ye Subject: [PATCH 2/2] iommu/vt-d: don's issue devTLB flush request when device is disconnected Date: Tue, 12 Dec 2023 22:46:37 -0500 Message-Id: <20231213034637.2603013-3-haifeng.zhao@linux.intel.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20231213034637.2603013-1-haifeng.zhao@linux.intel.com> References: <20231213034637.2603013-1-haifeng.zhao@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 12 Dec 2023 19:48:01 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785136976092872019 X-GMAIL-MSGID: 1785136976092872019 For those endpoint devices connect to system via hotplug capable ports, users could request a warm reset to the device by flapping device's link through setting the slot's link control register, as pciehpt_ist() DLLSC interrupt sequence response, pciehp will unload the device driver and then power it off. thus cause an IOMMU devTLB flush request for device to be sent and a long time completion/timeout waiting in interrupt context. That would cause following continuous hard lockup warning and system hang as following [ 4211.433662] pcieport 0000:17:01.0: pciehp: Slot(108): Link Down [ 4211.433664] pcieport 0000:17:01.0: pciehp: Slot(108): Card not present [ 4223.822591] NMI watchdog: Watchdog detected hard LOCKUP on cpu 144 [ 4223.822622] CPU: 144 PID: 1422 Comm: irq/57-pciehp Kdump: loaded Tainted: G S OE kernel version xxxx [ 4223.822623] Hardware name: vendorname xxxx 666-106, BIOS 01.01.02.03.01 05/15/2023 [ 4223.822623] RIP: 0010:qi_submit_sync+0x2c0/0x490 [ 4223.822624] Code: 48 be 00 00 00 00 00 08 00 00 49 85 74 24 20 0f 95 c1 48 8b 57 10 83 c1 04 83 3c 1a 03 0f 84 a2 01 00 00 49 8b 04 24 8b 70 34 <40> f6 c6 1 0 74 17 49 8b 04 24 8b 80 80 00 00 00 89 c2 d3 fa 41 39 [ 4223.822624] RSP: 0018:ffffc4f074f0bbb8 EFLAGS: 00000093 [ 4223.822625] RAX: ffffc4f040059000 RBX: 0000000000000014 RCX: 0000000000000005 [ 4223.822625] RDX: ffff9f3841315800 RSI: 0000000000000000 RDI: ffff9f38401a8340 [ 4223.822625] RBP: ffff9f38401a8340 R08: ffffc4f074f0bc00 R09: 0000000000000000 [ 4223.822626] R10: 0000000000000010 R11: 0000000000000018 R12: ffff9f384005e200 [ 4223.822626] R13: 0000000000000004 R14: 0000000000000046 R15: 0000000000000004 [ 4223.822626] FS: 0000000000000000(0000) GS:ffffa237ae400000(0000) knlGS:0000000000000000 [ 4223.822627] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 4223.822627] CR2: 00007ffe86515d80 CR3: 000002fd3000a001 CR4: 0000000000770ee0 [ 4223.822627] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 4223.822628] DR3: 0000000000000000 DR6: 00000000fffe07f0 DR7: 0000000000000400 [ 4223.822628] PKRU: 55555554 [ 4223.822628] Call Trace: [ 4223.822628] qi_flush_dev_iotlb+0xb1/0xd0 [ 4223.822628] __dmar_remove_one_dev_info+0x224/0x250 [ 4223.822629] dmar_remove_one_dev_info+0x3e/0x50 [ 4223.822629] intel_iommu_release_device+0x1f/0x30 [ 4223.822629] iommu_release_device+0x33/0x60 [ 4223.822629] iommu_bus_notifier+0x7f/0x90 [ 4223.822630] blocking_notifier_call_chain+0x60/0x90 [ 4223.822630] device_del+0x2e5/0x420 [ 4223.822630] pci_remove_bus_device+0x70/0x110 [ 4223.822630] pciehp_unconfigure_device+0x7c/0x130 [ 4223.822631] pciehp_disable_slot+0x6b/0x100 [ 4223.822631] pciehp_handle_presence_or_link_change+0xd8/0x320 [ 4223.822631] pciehp_ist+0x176/0x180 [ 4223.822631] ? irq_finalize_oneshot.part.50+0x110/0x110 [ 4223.822632] irq_thread_fn+0x19/0x50 [ 4223.822632] irq_thread+0x104/0x190 [ 4223.822632] ? irq_forced_thread_fn+0x90/0x90 [ 4223.822632] ? irq_thread_check_affinity+0xe0/0xe0 [ 4223.822633] kthread+0x114/0x130 [ 4223.822633] ? __kthread_cancel_work+0x40/0x40 [ 4223.822633] ret_from_fork+0x1f/0x30 [ 4223.822633] Kernel panic - not syncing: Hard LOCKUP [ 4223.822634] CPU: 144 PID: 1422 Comm: irq/57-pciehp Kdump: loaded Tainted: G S OE kernel version xxxx [ 4223.822634] Hardware name: vendorname xxxx 666-106, BIOS 01.01.02.03.01 05/15/2023 [ 4223.822634] Call Trace: [ 4223.822634] [ 4223.822635] dump_stack+0x6d/0x88 [ 4223.822635] panic+0x101/0x2d0 [ 4223.822635] ? ret_from_fork+0x11/0x30 [ 4223.822635] nmi_panic.cold.14+0xc/0xc [ 4223.822636] watchdog_overflow_callback.cold.8+0x6d/0x81 [ 4223.822636] __perf_event_overflow+0x4f/0xf0 [ 4223.822636] handle_pmi_common+0x1ef/0x290 [ 4223.822636] ? __set_pte_vaddr+0x28/0x40 [ 4223.822637] ? flush_tlb_one_kernel+0xa/0x20 [ 4223.822637] ? __native_set_fixmap+0x24/0x30 [ 4223.822637] ? ghes_copy_tofrom_phys+0x70/0x100 [ 4223.822637] ? __ghes_peek_estatus.isra.16+0x49/0xa0 [ 4223.822637] intel_pmu_handle_irq+0xba/0x2b0 [ 4223.822638] perf_event_nmi_handler+0x24/0x40 [ 4223.822638] nmi_handle+0x4d/0xf0 [ 4223.822638] default_do_nmi+0x49/0x100 [ 4223.822638] exc_nmi+0x134/0x180 [ 4223.822639] end_repeat_nmi+0x16/0x67 [ 4223.822639] RIP: 0010:qi_submit_sync+0x2c0/0x490 [ 4223.822639] Code: 48 be 00 00 00 00 00 08 00 00 49 85 74 24 20 0f 95 c1 48 8b 57 10 83 c1 04 83 3c 1a 03 0f 84 a2 01 00 00 49 8b 04 24 8b 70 34 <40> f6 c6 10 74 17 49 8b 04 24 8b 80 80 00 00 00 89 c2 d3 fa 41 39 [ 4223.822640] RSP: 0018:ffffc4f074f0bbb8 EFLAGS: 00000093 [ 4223.822640] RAX: ffffc4f040059000 RBX: 0000000000000014 RCX: 0000000000000005 [ 4223.822640] RDX: ffff9f3841315800 RSI: 0000000000000000 RDI: ffff9f38401a8340 [ 4223.822641] RBP: ffff9f38401a8340 R08: ffffc4f074f0bc00 R09: 0000000000000000 [ 4223.822641] R10: 0000000000000010 R11: 0000000000000018 R12: ffff9f384005e200 [ 4223.822641] R13: 0000000000000004 R14: 0000000000000046 R15: 0000000000000004 [ 4223.822641] ? qi_submit_sync+0x2c0/0x490 [ 4223.822642] ? qi_submit_sync+0x2c0/0x490 [ 4223.822642] [ 4223.822642] qi_flush_dev_iotlb+0xb1/0xd0 [ 4223.822642] __dmar_remove_one_dev_info+0x224/0x250 [ 4223.822643] dmar_remove_one_dev_info+0x3e/0x50 [ 4223.822643] intel_iommu_release_device+0x1f/0x30 [ 4223.822643] iommu_release_device+0x33/0x60 [ 4223.822643] iommu_bus_notifier+0x7f/0x90 [ 4223.822644] blocking_notifier_call_chain+0x60/0x90 [ 4223.822644] device_del+0x2e5/0x420 [ 4223.822644] pci_remove_bus_device+0x70/0x110 [ 4223.822644] pciehp_unconfigure_device+0x7c/0x130 [ 4223.822644] pciehp_disable_slot+0x6b/0x100 [ 4223.822645] pciehp_handle_presence_or_link_change+0xd8/0x320 [ 4223.822645] pciehp_ist+0x176/0x180 [ 4223.822645] ? irq_finalize_oneshot.part.50+0x110/0x110 [ 4223.822645] irq_thread_fn+0x19/0x50 [ 4223.822646] irq_thread+0x104/0x190 [ 4223.822646] ? irq_forced_thread_fn+0x90/0x90 [ 4223.822646] ? irq_thread_check_affinity+0xe0/0xe0 [ 4223.822646] kthread+0x114/0x130 [ 4223.822647] ? __kthread_cancel_work+0x40/0x40 [ 4223.822647] ret_from_fork+0x1f/0x30 [ 4223.822647] Kernel Offset: 0x6400000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff) Fix it by checking the device's error_state in devtlb_invalidation_with_pasid() to avoid sending meaningless devTLB flush request to link down device that is set to pci_channel_io_perm_failure and then powered off in pciehp_ist() pciehp_handle_presence_or_link_change() pciehp_disable_slot() remove_board() pciehp_unconfigure_device() Tested-by: Haorong Ye Signed-off-by: Ethan Zhao --- drivers/iommu/intel/pasid.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/iommu/intel/pasid.c b/drivers/iommu/intel/pasid.c index 74e8e4c17e81..8557b6dee22f 100644 --- a/drivers/iommu/intel/pasid.c +++ b/drivers/iommu/intel/pasid.c @@ -476,6 +476,23 @@ devtlb_invalidation_with_pasid(struct intel_iommu *iommu, { struct device_domain_info *info; u16 sid, qdep, pfsid; + struct pci_dev *pdev; + + pdev = to_pci_dev(dev); + if (!pdev) + return; + + /* + * If endpoint device's link was brough down by user's pci configuration + * access to it's hotplug capable slot's link control register, as sequence + * response for DLLSC pciehp_ist() will set the device error_state to + * pci_channel_io_perm_failure. Checking device's state here to avoid + * issuing meaningless devTLB flush request to it, that might cause lockup + * warning or deadlock because too long time waiting in interrupt context. + */ + + if (pci_dev_is_disconnected(pdev)) + return; info = dev_iommu_priv_get(dev); if (!info || !info->ats_enabled) @@ -495,6 +512,8 @@ devtlb_invalidation_with_pasid(struct intel_iommu *iommu, qi_flush_dev_iotlb(iommu, sid, pfsid, qdep, 0, 64 - VTD_PAGE_SHIFT); else qi_flush_dev_iotlb_pasid(iommu, sid, pfsid, pasid, qdep, 0, 64 - VTD_PAGE_SHIFT); + + return; } void intel_pasid_tear_down_entry(struct intel_iommu *iommu, struct device *dev,