From patchwork Tue Dec 12 13:10:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Menglong Dong X-Patchwork-Id: 177341 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp7713880vqy; Tue, 12 Dec 2023 05:16:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IHZQHkub7CdidlPP0zIkGCc3WhZfTRGDk3ddncovcwMkDgHIj3CWlFh+TFWGQlVrEryd3du X-Received: by 2002:a17:90b:3545:b0:28a:d568:98e0 with SMTP id lt5-20020a17090b354500b0028ad56898e0mr49639pjb.14.1702386965306; Tue, 12 Dec 2023 05:16:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702386965; cv=none; d=google.com; s=arc-20160816; b=K33BqXmB2OZdf+TCG8f8jYARL+dDQLBsQiGDFHA1USa4WuYMPViPZekK49MLxn9UzL nySoCJCCJHhnLHNRcT8cpg+e1K6m+gsy4fnWHehygizHpTeSvHw3XQW+79RNcEoACOgw jnQ+7nr/TIVn4DMh51fPpA7eFtT2zHWo4wIQJ2DxDGQIYi++zNw6703jiTtj/ekmC1n9 UANocWSHtC/x4VUWKDU//6jWZntNMJBBH0ffxmCv08U3ky28iYc1UqdhHxibnEk1I0dl T3/SVX9Qh8ijI5tewB3pjMAO98aKl7N3DqiZqxTxhqhlmvSYB+GdLVD76qxNPavIjok+ EoBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Czl9kOFrZP+hpYOswuJ1In+XAL9Pf70YYpXxrimZvIU=; fh=SGifBTVjLZ95Bpo5OYjxcS+0FNZ4Hm4Cdfz1m3M7p+s=; b=Y6vFytSAT/dQZK2TmFm5XjF23hveEoCtkfWhDtr/cs+9p4vqO/tSh0V9pSfUkoEOVC wEyueQI2oBl+rs6hNyDQQFjW9xkZ3AqL0Nn/kuWiT2ILTrkUdyWxQHtgR8ylLJeYuxyW +EouQd/o9rlQm5E7JeIVqSsavRABZq+Jt0FAUJ33zogpAi3w4YIPP/nLZPuDjoYegF3d 6aPbf0rSgbd/NCz1OKUluK5K7ZAVL4SC/ylLxXbBH881EvY9sMBXbGmjCL7c6Pu+Cgaq 77qNUKrGKXcvygcL3KRELhiKDmvl8ROe1sxQdd8eVgxdYarAqffqOE2+0EQHk4+7oC9Y GVBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=cCtGXfOW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id e14-20020a17090a684e00b00286db70cc7csi7698406pjm.70.2023.12.12.05.16.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 05:16:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=cCtGXfOW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id CEA10809692D; Tue, 12 Dec 2023 05:16:02 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235222AbjLLNPf (ORCPT + 99 others); Tue, 12 Dec 2023 08:15:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235218AbjLLNP3 (ORCPT ); Tue, 12 Dec 2023 08:15:29 -0500 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86346CA; Tue, 12 Dec 2023 05:15:35 -0800 (PST) Received: by mail-pf1-x443.google.com with SMTP id d2e1a72fcca58-6ce6d926f76so3917009b3a.1; Tue, 12 Dec 2023 05:15:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702386935; x=1702991735; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Czl9kOFrZP+hpYOswuJ1In+XAL9Pf70YYpXxrimZvIU=; b=cCtGXfOWq+0CMo7XgpQeKs5eD4OLdjfgAa5Y2YPGB9ej2MF1y1Dj3jfJZUEMqVB6/D RKNkYldyLfxKdmH63CfK5waJq+8gpqPFqc8c6I2FAhrz6WDIQeKKdEbQ/7BNAoQiSZGI 7efLD2VNyZ5BYfwtC3/1UcUjJJtJXDjRs5GujSIKEv8ckVCxafl/L1a19T21jM1X07zo e8OL7OqTnsIWe26o9NCUNZFr564HcXtMAt6tBX8DH0XMBZnGEYtIINgLg9dgUgGAS3gH 9YMCVw6A8QEpSo8seeOtdrpp5Qgaj0Q58IJ7v4CAhuSOxgzXp278Zck2SlLaU466FONr bCsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702386935; x=1702991735; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Czl9kOFrZP+hpYOswuJ1In+XAL9Pf70YYpXxrimZvIU=; b=GKPkjyaCz2i/RtbVbRD6YwPbtyOfDjm0BACt3ks+90bCjKyPzheJDn64u+I6EK1gdJ LugZ3lyKF9AK7T8Cr/TBGq8r/eKX809Nvm8bQi1N1mjYjffYLz8kIGlJ+kWfELzEGd6N oHhyPZTgIYkb1rr6G2CBbEwheOVqx24t4UZKnOylq1Ii7zkb9jcsBhQArYriTzJuwVjy sSMLaKxHd/9BiEqDandJOBKH0EgwkvGi6P/stIMvsGRMXdab3SY5ZbQIKsoTqs9Jv4UL Mm/9Q9+fpdgY7oK4r9PPYsXrPYcNxi/x589PoEF3TTGOWC03LcsX4ptdTyNKGOgHmjle KueQ== X-Gm-Message-State: AOJu0Yx0j04TlVjvLICAx1xgRbs2rhxValm4riyarRcrX8nuTREifAua CoVzhhPQAz4Griepuw+t2tY= X-Received: by 2002:a05:6a20:914f:b0:190:37a0:f343 with SMTP id x15-20020a056a20914f00b0019037a0f343mr8677544pzc.34.1702386934738; Tue, 12 Dec 2023 05:15:34 -0800 (PST) Received: from localhost.localdomain ([43.129.244.20]) by smtp.gmail.com with ESMTPSA id x20-20020aa793b4000000b006c4d2479bf8sm8095026pff.51.2023.12.12.05.15.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 05:15:34 -0800 (PST) From: Menglong Dong To: andrii@kernel.org, yonghong.song@linux.dev Cc: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, martin.lau@linux.dev, song@kernel.org, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Menglong Dong Subject: [PATCH net-next v2 1/2] bpf: make the verifier trace the "not qeual" for regs Date: Tue, 12 Dec 2023 21:10:30 +0800 Message-Id: <20231212131031.3088661-2-menglong8.dong@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231212131031.3088661-1-menglong8.dong@gmail.com> References: <20231212131031.3088661-1-menglong8.dong@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 12 Dec 2023 05:16:03 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785082114654938875 X-GMAIL-MSGID: 1785082114654938875 We can derive some new information for BPF_JNE in regs_refine_cond_op(). Take following code for example: /* The type of "a" is u16 */ if (a > 0 && a < 100) { /* the range of the register for a is [0, 99], not [1, 99], * and will cause the following error: * * invalid zero-sized read * * as a can be 0. */ bpf_skb_store_bytes(skb, xx, xx, a, 0); } In the code above, "a > 0" will be compiled to "jmp xxx if a == 0". In the TRUE branch, the dst_reg will be marked as known to 0. However, in the fallthrough(FALSE) branch, the dst_reg will not be handled, which makes the [min, max] for a is [0, 99], not [1, 99]. For BPF_JNE, we can reduce the range of the dst reg if the src reg is a const and is exactly the edge of the dst reg. Signed-off-by: Menglong Dong Acked-by: Eduard Zingerman --- kernel/bpf/verifier.c | 29 ++++++++++++++++++++++++++++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index 727a59e4a647..08ee0e02df96 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -14332,7 +14332,34 @@ static void regs_refine_cond_op(struct bpf_reg_state *reg1, struct bpf_reg_state } break; case BPF_JNE: - /* we don't derive any new information for inequality yet */ + if (!is_reg_const(reg2, is_jmp32)) + swap(reg1, reg2); + if (!is_reg_const(reg2, is_jmp32)) + break; + + /* try to recompute the bound of reg1 if reg2 is a const and + * is exactly the edge of reg1. + */ + val = reg_const_value(reg2, is_jmp32); + if (is_jmp32) { + if (reg1->u32_min_value == (u32)val) + reg1->u32_min_value++; + if (reg1->u32_max_value == (u32)val) + reg1->u32_max_value--; + if (reg1->s32_min_value == (s32)val) + reg1->s32_min_value++; + if (reg1->s32_max_value == (s32)val) + reg1->s32_max_value--; + } else { + if (reg1->umin_value == (u64)val) + reg1->umin_value++; + if (reg1->umax_value == (u64)val) + reg1->umax_value--; + if (reg1->smin_value == (s64)val) + reg1->smin_value++; + if (reg1->smax_value == (s64)val) + reg1->smax_value--; + } break; case BPF_JSET: if (!is_reg_const(reg2, is_jmp32)) From patchwork Tue Dec 12 13:10:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Menglong Dong X-Patchwork-Id: 177342 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp7713903vqy; Tue, 12 Dec 2023 05:16:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IELrMUGAJmSiy5XarECgBCtKpZXKDlub2GQsaFbAEmHwiqZtQSVLh2KgvWuyPzmRYojLwu4 X-Received: by 2002:a05:6a20:914b:b0:190:228e:4c11 with SMTP id x11-20020a056a20914b00b00190228e4c11mr3398002pzc.90.1702386967746; Tue, 12 Dec 2023 05:16:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702386967; cv=none; d=google.com; s=arc-20160816; b=RVawWoy3IQoS7zNVvncUrVUmm0RmALxISJxyLKaqNgthgOdZu9wHrn64x3tUdE6oE/ W4tT/yUxzOymGbwCmsrzCvQ4C+NZAG1TSoawWAho2kWGWuLsDPbH8Znfbjt8Au0POa4d i74ynYA3CxpCPSo7skpfhZSinwdUYY9xY/z0mOcKzGroE020hLcErLlPsWxrBl40OnM/ wy4dEeB8jR5CUCoZbV80aA29DVPUGm1Ls2XtaMAw9NHTGzTP0yKXQoUsu5NrZe9KBRAu qOIo0E0C3XseyA06g3UPumH02IvdCKVoX9Ili9ft0w4lt7cGHKAJrAvH9vOhoDJp5yf0 kGyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0QcCXCm4DPHUOC/Ldcn3syRLAjzqmkGV7uvetVmifyw=; fh=SGifBTVjLZ95Bpo5OYjxcS+0FNZ4Hm4Cdfz1m3M7p+s=; b=C9ULSJrjt8GGUmigCOHSTO15KD3Yt3m8OiDcN0rGHTfyMzhM/w0LP5A1T2NV2Q0DnS +Dx7EhHhMsGPQvtEnlN7AaUw8xVV90hCotbsKA1O3BD09OoCgTVZGIGuglh2w9U01yxo grfIM0N/24ftQn8aLC0GJjtrk4BBg2jfKUBY5xV3pOuRRWAtDyMJpoUTkOWnBItDHBKX 5q+AuOH88mQiDSFHXzi2vCTp0cdKHMvB+NsPLhYc6jP7bFBfGbfhSTy5Kn/XQCaj88MY xH68L5wr03Pid1enmB8Ad+AaHfJclRxqFNl0XhG09DkZqpz45agBYlEm/GqIQouYQ9Oh ZCxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="H6/RmvsC"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id w63-20020a638242000000b005c200c132ddsi7176055pgd.601.2023.12.12.05.16.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 05:16:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="H6/RmvsC"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id E54F580A0E2D; Tue, 12 Dec 2023 05:16:04 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376582AbjLLNPh (ORCPT + 99 others); Tue, 12 Dec 2023 08:15:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376583AbjLLNPd (ORCPT ); Tue, 12 Dec 2023 08:15:33 -0500 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2E97107; Tue, 12 Dec 2023 05:15:38 -0800 (PST) Received: by mail-pf1-x444.google.com with SMTP id d2e1a72fcca58-6cea0fd9b53so3359457b3a.1; Tue, 12 Dec 2023 05:15:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702386938; x=1702991738; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0QcCXCm4DPHUOC/Ldcn3syRLAjzqmkGV7uvetVmifyw=; b=H6/RmvsCHZVQeCoEnugvkOoaz2lU65BOr88iitTj6qAasc+1CN0cBXYH9Qi+ktYqxU JVJ0nDtCaiarBEFgZrCQiGcJiJkNON7NhPcIBeZ2pa1H0LCy/eFj6JErjR79cbLrdE4Z UlsuCcbiVgpKFM430uUL+Gx1faJg1DMhFxTyoTVFbsYLiqRDruXR7+LchMl8naBZGCwt y3rEWvu567omz817ZC63YPGkAkeeyIkwvMgW5DqMv9Sp9jw9rPp9thdiL6z9Rf7luYSK zUiEdUzmbljQMclLrrOOTHUxmnVOU8Pz7mauBMygTMRSvaPMFiCuXch0qiL1zRVfqNh+ Bkfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702386938; x=1702991738; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0QcCXCm4DPHUOC/Ldcn3syRLAjzqmkGV7uvetVmifyw=; b=JoCWRy0wVDnTW1NHNxbAjaWiEMvBTsXeh9VOXVwUWomWAVnZIClQ6JNeBub8egjJLO ort42PwDYW2QJL3+8MXpf9zTn010GwFrAAfl6Dar3+v75me8leHeFdaTdMy/C/Sy9y+x Y6rWijYUyMVoEABfZ4Ey9Gh4WLM5hYVLaTsq805RqOZCbh95JsQ4FClHyRjT2lFVZxAE qhrrVAiuQQmvDsM+vGWLCktNBagTeLFqD3hUzR0TpA/HyshP248c5tkysU6ooAgL4v99 VQMmVfRVhm6hMHXYR0ZGg3DzaxUwvDE40LeAIqYYehg7FU4rWnyfw9bD0gYggOp5t/XW CcfQ== X-Gm-Message-State: AOJu0Yy0jGtGaIzZldkwt83rC7wZf4OQJBtcnD8JnXDT+WxjRrOVKVEq 0VYASB05Z4S4zcZkaQzaOwU= X-Received: by 2002:a62:be11:0:b0:6ce:6407:2264 with SMTP id l17-20020a62be11000000b006ce64072264mr2500987pff.56.1702386938219; Tue, 12 Dec 2023 05:15:38 -0800 (PST) Received: from localhost.localdomain ([43.129.244.20]) by smtp.gmail.com with ESMTPSA id x20-20020aa793b4000000b006c4d2479bf8sm8095026pff.51.2023.12.12.05.15.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 05:15:37 -0800 (PST) From: Menglong Dong To: andrii@kernel.org, yonghong.song@linux.dev Cc: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, martin.lau@linux.dev, song@kernel.org, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Menglong Dong Subject: [PATCH net-next v2 2/2] selftests/bpf: activate the OP_NE login in range_cond() Date: Tue, 12 Dec 2023 21:10:31 +0800 Message-Id: <20231212131031.3088661-3-menglong8.dong@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231212131031.3088661-1-menglong8.dong@gmail.com> References: <20231212131031.3088661-1-menglong8.dong@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 12 Dec 2023 05:16:05 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785082117122844720 X-GMAIL-MSGID: 1785082117122844720 The edge range checking for the registers is supported by the verifier now, so we can activate the extended login in tools/testing/selftests/bpf/prog_tests/reg_bounds.c/range_cond() to test such logic. Signed-off-by: Menglong Dong --- tools/testing/selftests/bpf/prog_tests/reg_bounds.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/tools/testing/selftests/bpf/prog_tests/reg_bounds.c b/tools/testing/selftests/bpf/prog_tests/reg_bounds.c index 0c9abd279e18..49d8d4bafe99 100644 --- a/tools/testing/selftests/bpf/prog_tests/reg_bounds.c +++ b/tools/testing/selftests/bpf/prog_tests/reg_bounds.c @@ -590,12 +590,7 @@ static void range_cond(enum num_t t, struct range x, struct range y, *newy = range(t, max_t(t, x.a, y.a), min_t(t, x.b, y.b)); break; case OP_NE: - /* generic case, can't derive more information */ - *newx = range(t, x.a, x.b); - *newy = range(t, y.a, y.b); - break; - - /* below extended logic is not supported by verifier just yet */ + /* below logic is supported by the verifier now */ if (x.a == x.b && x.a == y.a) { /* X is a constant matching left side of Y */ *newx = range(t, x.a, x.b);