From patchwork Tue Dec 12 03:26:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bixuan Cui X-Patchwork-Id: 177073 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp7488116vqy; Mon, 11 Dec 2023 19:27:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IHZf0qcE9VWBrxrjRtMKqG5ACTboKCTHhZx+PpXpO45dDI7YdGE6lSwGastuc5tznfYln5u X-Received: by 2002:a05:6871:54c:b0:1fb:75a:6d2f with SMTP id t12-20020a056871054c00b001fb075a6d2fmr6216562oal.86.1702351632497; Mon, 11 Dec 2023 19:27:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1702351632; cv=pass; d=google.com; s=arc-20160816; b=aCgCvL9gUxeix5o90TqWvhm9iKk2V13ygL9CezuLM82UUbKDRnIQERyskZ9LNqCsQj akpGe/Iz99gTKiEQhCdq77+BFlTgAZtGl0Wi4BUrXxxyW1mGwuOswiBLKMgGcrBq9MzL SI9KcJf6ugfFRFhV9ZSvj078M3ipMuaSVQ3PRZU3Qnn0Jf08AG28f/70U3C2SgPxqpa7 +5s0du2ZYNtWiT/XP2vl+84oZO9pLTyOtaT8QcdxAf2gKOdIYKpssdmfkm7R/lZ2/5cz V0B2SdFr6xGur8XS94JE5cvZZalCbpDDd8ajQ4bs5FUZAX0giNZr3vCTKXC1NifzHm/D lHbg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=g7oIIAqbzcDOZgSBWU+sOxLWScBOIz8KQyrhRsF24hA=; fh=ICua/4DD+ZpVfbLyNSQKlrI+edYXLMnDU+p06WssHVI=; b=Bh+JRB8oB30bWvaHIouLdiqEyDokcX/ZwLNKj0Up4zlEBIsOEvaw3e7MGwVr4Yp2+B 4msTNmlZz9++tjuX3e5UaCNBgTWebcHdvv5QksYbh/aVqbpnuKUwnFrK44whqF0mQ8v1 rzorc7S5UD0sk5B1Jd4rmwa6l2HsqMKF58huQnmVfkeC8IxFJQuuvki+/uRK7f2xVJzi yRriifFjyVTZtIOyGzA1e57PwWGkrhLuQQDV3DEUgmgMxW7ySudxJ3lXUs1/iamILC/E gla7VXlvU1m8ZgHveZT7iwbs+lx2CMBY2JYAwntj32l4SVMSVkL5obXn5wiHPPBk0owY iKQA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=MmoRfFBd; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id o66-20020a634145000000b005c1eadbacb3si6922062pga.104.2023.12.11.19.27.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 19:27:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=MmoRfFBd; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 95297804E6A0; Mon, 11 Dec 2023 19:27:11 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345868AbjLLD1A (ORCPT + 99 others); Mon, 11 Dec 2023 22:27:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231235AbjLLD06 (ORCPT ); Mon, 11 Dec 2023 22:26:58 -0500 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2122.outbound.protection.outlook.com [40.107.117.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10F9C8F; Mon, 11 Dec 2023 19:27:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A6RVKUPbsuPjpW3Yve+G4cxLgqCcRraIi2LMQ9tcneTmb+IAbTn6Vfek1aftmiYJG64Ui4qgLDSPl4VkuCnyrKs9AniZK9A6lJwjKyRMJ9hS/TElbYHIPW6v5i9SpNIng0FilXJaWlBYNSlEwPnbMZ+RMhp5TyXiCN8W7vGd84GyLtjYaHU2mWb7VRRGCfKZZZgqrnicnuv4/IHLw8Oas2XfotaxfqZ9D8j3zoMnb9FGmZvvLZ0qXnL6Z4mD3+8lujoYw9KeElBnBxLYzGN6ttDYknFFibTELk4TovNF47pIQAbsfw+dZUw1giYCqkYLFiuG54b88aulv1ggLnx3lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g7oIIAqbzcDOZgSBWU+sOxLWScBOIz8KQyrhRsF24hA=; b=PItkxf7EAKVb1XKG5PhU3N4h4WDA41tSA6eZAe3qiy4aGAhymLDlgT8hwUDB+6ror7qxS+sa5H11h/dZCsmPfe6WAF9FXOLXu0gbCCJp6EZyDkVfkfwWvQ7OU8auFUwmsGf+BcZT2SPpo7UpVfkh7kgVllFTPzgY87F/LxL2Ydo08GgTy18fqHnwxnkOdFEWPmmK/l7YdH7aJCxK58vfhpR7QWbZb91+fXAsOSdRDo3d0F6x55hhwXor6RNHmpWFmqEwq+Br9zomxaayGLg8UFG+LO5wVj1n8W7T7zNFE+jzgl5dqFDUM0/xmqOCAVEIncia/ZDQOJhtLgoNuwNk7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g7oIIAqbzcDOZgSBWU+sOxLWScBOIz8KQyrhRsF24hA=; b=MmoRfFBdL4JCkbsfa2iyasY1gKDIxTvG7oTh0YkDIbsSQnQsuk8ARATTZil3mDFXXhUm7F++NnMO6QBrx0L8uXc3021bWsTuKUslm+cWw+BmC2RqHxHfQ2iQ9dwfrOkFzaKUMVHaMMx3HkIzCFepzItEdqZtsIZMtVBxs+G3y+ciHmCQYQedCYXxFn05dKmNFTV3WWsTr27lByjjS5l+ZzWJqzeNGtUCJl/Q85+2sCJbD7IrlXRdFlwMeVi8I9sWQZ+/t+G7bsaOqYDmTRNkGy2IbnNzHNdYCKAAZmgtMLRj23qsS7I6s6BzCtJ0EwfE4vWjus8TSVp0E+0F3++70A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from TYZPR06MB4045.apcprd06.prod.outlook.com (2603:1096:400:21::8) by TY0PR06MB6839.apcprd06.prod.outlook.com (2603:1096:405:10::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32; Tue, 12 Dec 2023 03:27:02 +0000 Received: from TYZPR06MB4045.apcprd06.prod.outlook.com ([fe80::9925:32d7:c818:3c5]) by TYZPR06MB4045.apcprd06.prod.outlook.com ([fe80::9925:32d7:c818:3c5%7]) with mapi id 15.20.7068.033; Tue, 12 Dec 2023 03:27:02 +0000 From: Bixuan Cui To: rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, cuibixuan@vivo.com, opensource.kernel@vivo.com Subject: [PATCH -next 1/2] mm: shrinker: add new event to trace shrink count Date: Mon, 11 Dec 2023 19:26:39 -0800 Message-Id: <20231212032640.6968-2-cuibixuan@vivo.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20231212032640.6968-1-cuibixuan@vivo.com> References: <20231212032640.6968-1-cuibixuan@vivo.com> X-ClientProxiedBy: SGBP274CA0012.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b0::24) To TYZPR06MB4045.apcprd06.prod.outlook.com (2603:1096:400:21::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYZPR06MB4045:EE_|TY0PR06MB6839:EE_ X-MS-Office365-Filtering-Correlation-Id: 67714e02-9049-49e3-7021-08dbfac234ec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6OPrY0Ju4iZDA/QpvEYw4bOJHF2nupxUDom1gLrJ67jhrXGLfjFMMCtTISpp/TqmKLHIDH2iCOvm4Fh0pdW0MFIQNYuXSHNCtiwz1Tx0JfhhRVkc15itAofxxkRy0czi9nLIursovLKOIdNNX/xAfp54UtomW3cqAmrwvqRJ36CzsnfziLn4+Nu0o4eu4Ske8nA3dSHN6u4ehtLheKHae/uYjcX+uHfMo1Pj7Kea5h6n/yjImY/1pqU33/3G4yIfy3IDmdRI8V/PTQ34RWId4FvmBAQSIysW87EZE+FPr6vvb0nrkf7yCLEQZUQqepPxy3yAFUPFsuVIEHUQ53JqqPaWXya0PsWjwXPeOePebwxjntBE3kcjQWvauoDZ3i04MxPdsTo+/LaCtC2U5MKgIZ6A2tugwFFsScZ0ZdZeFX1UbdQcOdRZZFQjwYLfLweQfDVXUaqwParDFByBErA8aDwjwPb4XVlA1hMGC04l9W77aE3VmtjmWS9sIc4ohhvLCWmo1G4FE/WbpFGD8emLILmjLMG8UVvl4JSFOmDS6NLEjkq8S5TouoCzMencBwKUsAkuPSviL4Ml+0/yUQ+BCpagudlsmWnrhT0X974tfNfBidfv+8o9lBF5dSyPWZ3x X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYZPR06MB4045.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(346002)(136003)(396003)(39860400002)(366004)(230922051799003)(186009)(451199024)(1800799012)(64100799003)(2616005)(26005)(1076003)(107886003)(40140700001)(316002)(38350700005)(86362001)(36756003)(38100700002)(83380400001)(5660300002)(52116002)(6512007)(6506007)(6666004)(66556008)(66946007)(8936002)(8676002)(6486002)(66476007)(4326008)(2906002)(41300700001)(478600001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: KFt6CF92Hmsh74MOyXHdEFV85MyYSlnoCQ7QIoCdfDA8a9ZcmjfjV7694Ltu15QGwWXi8yCnkouBg88mk5Cd+da3Jhs0cUqRwokT2F2FKGA1pxvRaUds+HvO/y/zk+OvEyH/bUs1icyE9kLtgWwcjelR70QaUS0/y50nv/4PQYBX7S5EmPU2WKb9NMIMRUnX8U4npf5FR15XowowwwC9f+tKafpjjGTu0oc+Dp5/CZN2HZcyclo2w2qMYKl+fGaruwAHKqHRmBLluaMA+AVDEOK5dOnulXAWVgiI7N5d6uEQ2DVhxYO3zy6wulGEgGIbtC2YFggZpmWaP7ZUAcePy2Q/EpFF8xKW9RX4axJ/oh0NZhBQVYr9qhFfWkqVVwown3r3J+lXHXzwFQJm4iJHyDgLX/uw3S4vGpp/tXMe6WQ3JQsDjcZnL3XvaKBR86B/uquc6qbcj+BmTUx7zHqK/D32V/b2naZsv7o5GPzp+Cw4dLPsfaOjh9/lbKTbF96j5j91387xLjK/9LLPsWct1XyUMw7FlR6g5wyL4A7YknJHxBWE+z2+mAvSPPuAQXxkzwOYC5dqy2EWvVnwDwmQk9wkmbJmFGXXrld1PqYb+cHgiFfOTcy5g0gUAxobbzSjt8JoSWmVepIj6zx5zUJuvd2YOTIdtvCyOiJ5IFpw6hu3j7s2d8UAcAbr3ZUfvKmfntWAwAszaNJr9Og3ebYpgvHQH6PaMNKS1VAEqTJVaGRFW8JYDOM9/jXwh9ZLwkd5EZICQA8P/yeQHJ9gJOIk8NxvAAfex93uz/9Hmg4UoMJs+GrG7LJUI9fV1NUfOEna8q2rjZ8STm20pecHv3HCHuspNwCfevmyXi+lLVLSySvYRNB9NAhr5+TH5q4Hm8hepqswFjB2T0uolHX2IEaXX1A+DMYQ/i0hvvRyHsaINRLftXsQ+OqfNNSf69lSJ5SLZOKeJ5N40ariXGoUNEgaX0ySd1kirXWI1bUyBfrEvH7wYSDTDNhpBOZjf+7XbLz8K2G9vfotBlkhGsrUzDZURz9vQG+gXRUQvlV7Ez2Gp25aZ5z7fZn5kD7BJHgFEBfKzg56eHKgJClgapm2eKRfDd8PDU59Wv3QoLMLibi0iH/e5Mm0OV4jsYH5e7QckmjRrgu33z01h+J7inVCczlUwhwta70I2ldX1gpGPaXWjizgUmi0++rENxuEGMBuUJNh0LhrYsz6Sp8XPJQ9Vl1NWjBVa7G0AkI/w//j8F01R6fEvhPpGqBhXSVRgCS6u172N23aXajTfkdvvTeZZlMnbBkwrC8IXfsZJuBE9+JVhu3TrO4zghytnEBWNVxxAeQBWMYOTIgYIYVlaxDJZDkOw3n4SnNjg8Q/5o+WryDqQOuaKlYBaTUn9zXgwC6ZvIYyUg9YmMG+yS7bvZdOTYiszEDgo0P1bR96Ah+F7hGQU7xEpUoLV87pBwkN7Ar/DqzYp/T4c3htojp/d5Xm0xYCjkeCzq05uQdgM/g/aVsr4hITjMVFXbx++tv9Gk++e0F9it2j58UEkoFyjKq5khCvez8JlnzoUMQOd49a/cPDdFDK71fF75ZMmIakW1sc4b9N X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67714e02-9049-49e3-7021-08dbfac234ec X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4045.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2023 03:27:02.3035 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: I8KcoMiux6zmidmHyrPsPNrFJxv6bsN7aaT06Yr9BlHXXYk5l6GIDVAptjfiubrwNfy3vqAYU9h5JGr9pLvLjg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR06MB6839 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 11 Dec 2023 19:27:11 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785045065587650707 X-GMAIL-MSGID: 1785045065587650707 From: cuibixuan do_shrink_slab() calculates the freeable memory through shrinker->count_objects(), and then reclaims the memory through shrinker->scan_objects(). When reclaiming memory, shrinker->count_objects() takes a certain amount of time: Fun spend(us) ext4_es_count 4302 ext4_es_scan 12 super_cache_count 4195 super_cache_scan 2103 Therefore, adding the trace event to count_objects() can more accurately obtain the time taken for slab memory recycling. Example of output: kswapd0-103 [003] ..... 1098.317942: mm_shrink_count_start: kfree_rcu_shrink_count.cfi_jt+0x0/0x8 00000000c540ff51: nid: 0 kswapd0-103 [003] ..... 1098.317951: mm_shrink_count_end: kfree_rcu_shrink_count.cfi_jt+0x0/0x8 00000000c540ff51: nid: 0 freeable:36 Signed-off-by: Bixuan Cui --- include/trace/events/vmscan.h | 49 +++++++++++++++++++++++++++++++++++ mm/shrinker.c | 4 +++ 2 files changed, 53 insertions(+) diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h index 1a488c30afa5..406faa5591c1 100644 --- a/include/trace/events/vmscan.h +++ b/include/trace/events/vmscan.h @@ -196,6 +196,55 @@ DEFINE_EVENT(mm_vmscan_direct_reclaim_end_template, mm_vmscan_memcg_softlimit_re ); #endif /* CONFIG_MEMCG */ +TRACE_EVENT(mm_shrink_count_start, + TP_PROTO(struct shrinker *shr, struct shrink_control *sc), + + TP_ARGS(shr, sc), + + TP_STRUCT__entry( + __field(struct shrinker *, shr) + __field(void *, shrink) + __field(int, nid) + ), + + TP_fast_assign( + __entry->shr = shr; + __entry->shrink = shr->count_objects; + __entry->nid = sc->nid; + ), + + TP_printk("%pS %p: nid: %d", + __entry->shrink, + __entry->shr, + __entry->nid) +); + +TRACE_EVENT(mm_shrink_count_end, + TP_PROTO(struct shrinker *shr, struct shrink_control *sc, long freeable), + + TP_ARGS(shr, sc, freeable), + + TP_STRUCT__entry( + __field(struct shrinker *, shr) + __field(void *, shrink) + __field(int, nid) + __field(long, freeable) + ), + + TP_fast_assign( + __entry->shr = shr; + __entry->shrink = shr->count_objects; + __entry->nid = sc->nid; + __entry->freeable = freeable; + ), + + TP_printk("%pS %p: nid: %d freeable:%ld", + __entry->shrink, + __entry->shr, + __entry->nid, + __entry->freeable) +); + TRACE_EVENT(mm_shrink_slab_start, TP_PROTO(struct shrinker *shr, struct shrink_control *sc, long nr_objects_to_shrink, unsigned long cache_items, diff --git a/mm/shrinker.c b/mm/shrinker.c index dd91eab43ed3..d0c7bf61db61 100644 --- a/mm/shrinker.c +++ b/mm/shrinker.c @@ -379,7 +379,11 @@ static unsigned long do_shrink_slab(struct shrink_control *shrinkctl, : SHRINK_BATCH; long scanned = 0, next_deferred; + trace_mm_shrink_count_start(shrinker, shrinkctl); + freeable = shrinker->count_objects(shrinker, shrinkctl); + + trace_mm_shrink_count_end(shrinker, shrinkctl, freeable); if (freeable == 0 || freeable == SHRINK_EMPTY) return freeable; From patchwork Tue Dec 12 03:26:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bixuan Cui X-Patchwork-Id: 177074 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp7488174vqy; Mon, 11 Dec 2023 19:27:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IEwFRjZKtmc7l8QfqSIyFcEy22zMaqnvjGh2GOmCj0b8gt2KZtXb9H/Z8/2gpnrZpdzkfI1 X-Received: by 2002:a05:6a00:8b96:b0:6ce:2dde:bbe4 with SMTP id ig22-20020a056a008b9600b006ce2ddebbe4mr5020218pfb.66.1702351642543; Mon, 11 Dec 2023 19:27:22 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1702351642; cv=pass; d=google.com; s=arc-20160816; b=PMD/aUZOwbm3+K+0fmwuxPu63HzNyg9RW1xoxdP8pkNlFcg003EkMgu4loEKnLv/T6 2XzbOCyRAup4kzf0iMsm/Ap/g0lNPdDpf0YfSxWE5txDojf4CWQnEkpf4BdtMKvAg6KR wieMOOBayedhxatU5ROnQ+3MtrtFpm2qmp71l7121llpeCZwZKb0Z2srwVDVGIHEgh/A WePx6QateZEKHuSnLgNzdVb2Zq9r+V+Sn0ueKNHxk8UssV+SUVjQvBeVeIvk9pp+f2Ya Uh2NmaQ1bpdlm6jA9eiPO4Es+RFOrt39NWZETM30bKRNJQDJsOfftlbmn0FXj7FTVbol FylA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=eeU/QXyDeRMtTGN6We1+pgz8pJ6zXq2mwd5p00JEds8=; fh=ICua/4DD+ZpVfbLyNSQKlrI+edYXLMnDU+p06WssHVI=; b=AdzSJcxZnatGFht7hL6Ne7d897PDr07DStyhLROJfCKU5VLID1fsq9439C1WihtZjK 0Og0RIf5nzWFm3q5ok1JcA5HX7LpPuEe9DbEhSQK/c0qbqEiBQDc5EKmJh3OX+M7yheb kLPDbMn2L0OBJz6VA7G3FRNCKH7gXP8EvAnbzRjID5W22x7xTBGVv5TRitA+FxGW3Z8b CU9LkNG1lwJ2FQ3eS+67/II8DuOMwDmjsgNDxdbzI8CUF+TcnKXdhlibnNMBNu2WCGo1 lOsfz29QDBLHWeKKbiBkT9u72N4SzGhuCSLezFAP5vg2T7ftjQumrp10CumPSXQiLxeC hEuA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=J9X7aQGS; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id z11-20020aa7888b000000b006ceb1a0fa60si7104741pfe.8.2023.12.11.19.27.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 19:27:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@vivo.com header.s=selector2 header.b=J9X7aQGS; arc=pass (i=1 spf=pass spfdomain=vivo.com dkim=pass dkdomain=vivo.com dmarc=pass fromdomain=vivo.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=vivo.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 790348050910; Mon, 11 Dec 2023 19:27:16 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345878AbjLLD1H (ORCPT + 99 others); Mon, 11 Dec 2023 22:27:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345807AbjLLD1G (ORCPT ); Mon, 11 Dec 2023 22:27:06 -0500 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2097.outbound.protection.outlook.com [40.107.117.97]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B6B5DC; Mon, 11 Dec 2023 19:27:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EgsA3zu7+/XPZm7Uq0q/G58moKo1+rWsywJu1zVIak+XYQ38KdvrFUDv6qv/rf5nMshfFhFOUY2x8HEJnO19HjeSjtp5eQDYtJz6i10XnyiYR5240lJRB2IY4xgvCHLlVlwN82DuaEulIpfpt2b+m+m3E8ygG1ZUlW+nCXarDnf8NflJYZZqZgDZOCJS4iruJavat54NE/gqmbzlTabNTJbAHeRbbIV6GM2/BBfSyny5xighHCt7O6yltEHaklYAyPjLH7dsMSBh2+wC7Asb+g7LZtbkMEd1UakmmOQaWJ+78+p3PxHhL+pOiU0zZSheu3ln1NDdondBeUtDTTwYsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eeU/QXyDeRMtTGN6We1+pgz8pJ6zXq2mwd5p00JEds8=; b=RqVfzRZc0i74qSXsnwl8aK9hDvPor9/UePVZP1jDqSmFqnfoSh9VYBuvDZMfkpgQda5nOWKlJeVqTTQOqzIss+uX3opFpe2fggiDBf5WuEqNKMavl4UsGop0dFhO0SGFUae/svv3njCRJv6had+hCGMQCTZz6DlfQpVC2CL2m7gT7PLSsydLKBX9acKYyydS3huI4S+sxlTV4vIascihACEFbA4wmDSCluXJZJco2gscMspz54zSg4MnhvD09v5lGlzeD4L4XSGCswfZrO+TWv4BQzIAMKQkr7WGlMUnRsdmUHmBRinGA7ExP9oC+EGjBAOOxZM7a9QHe1LdADNaKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eeU/QXyDeRMtTGN6We1+pgz8pJ6zXq2mwd5p00JEds8=; b=J9X7aQGSKmXRXJ7SXgZRacfplpoOVxLVcuydxihUgFxf/5yW6BpihemZjtXNIoVYlTfeFxjpX82HKgkzuuSbGZdztMlM/FwbO0kXZajglol4GuXrnNh1R/GbGcSQFE6g1eNEaxAfkDQAiYIKs3jgKHUwHWnOefzgiNI8knc2Bd896XCtTcd2dDgdvxa/AfhVqHDq0QFPoTUcAdEOWw+d+N+BhckKQo9vvUVtf92sAV8z/yxEaYN6cUWZZUiGdIVZIHABjNgDCx4adcOuXR/pKCiWcKGmJsx+k7CB2kqUhvw5d6uj5w6WilQBrXvw1WWuk7ypY0tD7WpLrFlsxSJCWw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from TYZPR06MB4045.apcprd06.prod.outlook.com (2603:1096:400:21::8) by TY0PR06MB6839.apcprd06.prod.outlook.com (2603:1096:405:10::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32; Tue, 12 Dec 2023 03:27:09 +0000 Received: from TYZPR06MB4045.apcprd06.prod.outlook.com ([fe80::9925:32d7:c818:3c5]) by TYZPR06MB4045.apcprd06.prod.outlook.com ([fe80::9925:32d7:c818:3c5%7]) with mapi id 15.20.7068.033; Tue, 12 Dec 2023 03:27:09 +0000 From: Bixuan Cui To: rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, cuibixuan@vivo.com, opensource.kernel@vivo.com Subject: [PATCH -next 2/2] mm: vmscan: add new event to trace shrink lru Date: Mon, 11 Dec 2023 19:26:40 -0800 Message-Id: <20231212032640.6968-3-cuibixuan@vivo.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20231212032640.6968-1-cuibixuan@vivo.com> References: <20231212032640.6968-1-cuibixuan@vivo.com> X-ClientProxiedBy: SGBP274CA0012.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b0::24) To TYZPR06MB4045.apcprd06.prod.outlook.com (2603:1096:400:21::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYZPR06MB4045:EE_|TY0PR06MB6839:EE_ X-MS-Office365-Filtering-Correlation-Id: 28db6b3f-c615-4b86-2d69-08dbfac23935 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EggoWrBAtUTj4YEV8eT7BMOkVby2Btc/8TRhdnQ9PmUN2mTJvzU3BBLKmQdH1QCPGykHvOO+RRpu83nsdEdHJFeUdHxDTo1UWmbIqkXQzTVzhiuMcnrqNFKu8DOvb6RGoFZtao6hgiISq6sOyyYmbCqE2miw+ON3BefrMhG/nJ5rB769eSXhZg7J/twNFv5jfc/PUt5UkkK+al5uH+5lr0Ja+wFZ0k+lhwy0KOxxAWgCZk3NSU7uUV+QGWtdCiSA7WnZ83J/wVjFOM/jObq9+niW8upwuIJ0EXB2jp9zKJMp5dh7of28TqrBPiGnkE2oTr1jJ6GFrNIo+U9XXLJ2kAQy1d2GWBxCjEEucfgrkE4ot5Xq42mYRRF/cdQzyCitK58QWuQn8kWy9En3nf/WDv6bWqyvFVJH2oPl3nSwX5KgL034D/zu/ooxOUsuqiylnwDzoE+AsS05NCzipwamLSdO3uI2XVC67ZqqNztObJH9QTAwYRepbMsLo+KoAm6r4lpb6vvfYAb9XVuS7TWBqnZNJ6PNL3PsedoTf2x1InVDOaN16v1A1Ver7tlhTq9WRf0raCiQIIrqexzeED8VwDo5+Uw6y0CifDJmmCBpHro6RW2NxfyF8tiRpMbkb7Bf X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYZPR06MB4045.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(346002)(136003)(396003)(39860400002)(366004)(230922051799003)(186009)(451199024)(1800799012)(64100799003)(2616005)(26005)(1076003)(107886003)(40140700001)(316002)(38350700005)(86362001)(36756003)(38100700002)(83380400001)(5660300002)(52116002)(6512007)(6506007)(6666004)(66556008)(66946007)(8936002)(8676002)(6486002)(66476007)(4326008)(2906002)(41300700001)(478600001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: RSPQMdvNdFuqsHbr/s3uTn46IL39h/0PR8anaPFuO1ZsyeRLnTOCYITNoqFAaSr0sZLIHKNA5VpjG7LrUts9shnGcdJ7vcV/8bUlj0UC7jitu/+v63309lhlQGeoq4HJX64p0p9D61McrfAE2+Jf+fcpl7K8NMfEcrxEj6xm7PW+lS5HuBHZlAUWlkNCGOH5YZP5VhS/rtE7+tcOHiUHL/HODub61soU0QvHhPU5+oCbKgtTNLtTZr1aiJRHS55GVYXoaVQivefoFeX0AAzfiJKj5zH+Z0leGNDmhhqLtJR5Zxo/4VykrPFjHBKdBNshrOmpCz9BYInmxbxQuIgC52dGjpEhnuGQ0W6lrnMnVk9Ic9EUrXYRsLl/0T0CoJniVv8CAPZXie3IEGMdVXyBy4bH8e3MXuA0aySEKwI2OYoLWkfCUCINYty4zKG9TONA2FQCMX/AHo9UJlCaFCYHFi76aVpjWe7W8spuXElzqSiBRd5Ea3jjPP1C+QSzsNbJAdJCB2GgEqYPCHFXlDbyVJPgw9GOUIlzs4G/YNPjhr3HBrAJfa8Cj6ineZu2ARpB0lqq5nz0l6DDBXio5LzRSh0lGtrhhYvM8/MvXS2XT6ubceJrfaOZL/7LcIQHJnV+Ispr06pFuPbdBHuUtFsAlsNabrUXFPzS0uEomWWCUthN/TSqaknKpB0nxR+0/c9Lwv6sApCOJrmph+88F1X3Q4oSf62NWqbHj1NcMTWMNZMLzgsENem0C+6Qr0ECL3aSQghkUaqci4CSJ1iJCWrUtYSRqMaEXwPLtJA4PCzEmE5dv8sdXRVCBhIQeGZ1x57f9bkryI5BtNIDsT9QojDWAlY70cFWljGKiKZzjTCHxaJfaq3EwwtaSBPshJKVQRfdlVTTy6zFIYkL2yb0uX3Qb7wIYsK9IBoFNULzmVuJKxL+GlH9o9kYXzjugqBhICgjePY6xcT5Kh21L/5OHFxz56cwRbYCvJN1fQq0cCDu8vHT4eY2kEv0CW+dTZqn0tBXOhbvLhaZRWojdvBv1opGnYDtZn02KJTYQ4azJOmjdJdfk8Raaz7gag6WRDT6CHNXrZ3ApVdiKCDzNVC4XE5QPxKbtMwCh/YQ7tn2hPTdnMWyIIXCkapWjG4hx0ZrgGMmLkTeiglba0kxSpP6eE1cnbBoQSUScrRWRJjQIqj9uW154yh47OSxQSBL41nsCTU/kIAXwS3ZVsfmFpjXYQGE5R1XqcNFMqlIjfTMI/ONbtP5eZez0Ygibwdl2ivHUaLk8nvtVrWsSPoZhkxZIj4tZ7hemxMNBAVAAqROEeODedRTla2a9wkJfBs6/VEo5Hstmp9SxFHj9aOgy8SDsXEjuMUbFJkVTnQzusryxDbTfIQeigXBSq6UnDpRFnsFrVrlE77tSO8iu8YbAGDeGtMoDvEiAndcw3asIlVSme8Ga/+TUhikFufHM9cBi5DXrZ5OYzLPpjecbCZSUmjyncUN2ENN0HxtJKgqqVKPNsGc6MQP4Z9PO/Vx53JkeBYOHUGsEBmwboUEVZ/0IV9Ry7wmtixnJBOizurgjELWLmvvDCOLPgdLZ9A2/U3amtLcgzP2 X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28db6b3f-c615-4b86-2d69-08dbfac23935 X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4045.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2023 03:27:09.4828 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mn24X+UvLKKnAlxmw4bEDG2JbJ1jQV2q3RgtmDAFtdF+zHGPiHGVWKTX4MxS37z/SyKfSGli8goJWjBGNszJyw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR06MB6839 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 11 Dec 2023 19:27:16 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1785045076006632908 X-GMAIL-MSGID: 1785045076006632908 From: cuibixuan Add a new event to calculate the shrink_inactive_list()/shrink_active_list() execution time. Example of output: kswapd0-103 [007] ..... 1098.353020: mm_vmscan_lru_shrink_active_start: nid=0 kswapd0-103 [007] ..... 1098.353040: mm_vmscan_lru_shrink_active_end: nid=0 nr_taken=32 nr_active=0 nr_deactivated=32 nr_referenced=0 priority=6 flags=RECLAIM_WB_FILE|RECLAIM_WB_ASYNC kswapd0-103 [007] ..... 1098.353040: mm_vmscan_lru_shrink_inactive_start: nid=0 kswapd0-103 [007] ..... 1098.353094: mm_vmscan_lru_shrink_inactive_end: nid=0 nr_scanned=32 nr_reclaimed=0 nr_dirty=0 nr_writeback=0 nr_congested=0 nr_immediate=0 nr_activate_anon=0 nr_activate_file=0 nr_ref_keep=32 nr_unmap_fail=0 priority=6 flags=RECLAIM_WB_ANON|RECLAIM_WB_ASYNC kswapd0-103 [007] ..... 1098.353094: mm_vmscan_lru_shrink_inactive_start: nid=0 kswapd0-103 [007] ..... 1098.353162: mm_vmscan_lru_shrink_inactive_end: nid=0 nr_scanned=32 nr_reclaimed=21 nr_dirty=0 nr_writeback=0 nr_congested=0 nr_immediate=0 nr_activate_anon=0 nr_activate_file=0 nr_ref_keep=11 nr_unmap_fail=0 priority=6 flags=RECLAIM_WB_FILE|RECLAIM_WB_ASYNC Signed-off-by: Bixuan Cui --- include/trace/events/vmscan.h | 38 +++++++++++++++++++++++++++++++++-- mm/vmscan.c | 8 ++++++-- 2 files changed, 42 insertions(+), 4 deletions(-) diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h index 406faa5591c1..9809d158f968 100644 --- a/include/trace/events/vmscan.h +++ b/include/trace/events/vmscan.h @@ -395,7 +395,24 @@ TRACE_EVENT(mm_vmscan_write_folio, show_reclaim_flags(__entry->reclaim_flags)) ); -TRACE_EVENT(mm_vmscan_lru_shrink_inactive, +TRACE_EVENT(mm_vmscan_lru_shrink_inactive_start, + + TP_PROTO(int nid), + + TP_ARGS(nid), + + TP_STRUCT__entry( + __field(int, nid) + ), + + TP_fast_assign( + __entry->nid = nid; + ), + + TP_printk("nid=%d", __entry->nid) +); + +TRACE_EVENT(mm_vmscan_lru_shrink_inactive_end, TP_PROTO(int nid, unsigned long nr_scanned, unsigned long nr_reclaimed, @@ -446,7 +463,24 @@ TRACE_EVENT(mm_vmscan_lru_shrink_inactive, show_reclaim_flags(__entry->reclaim_flags)) ); -TRACE_EVENT(mm_vmscan_lru_shrink_active, +TRACE_EVENT(mm_vmscan_lru_shrink_active_start, + + TP_PROTO(int nid), + + TP_ARGS(nid), + + TP_STRUCT__entry( + __field(int, nid) + ), + + TP_fast_assign( + __entry->nid = nid; + ), + + TP_printk("nid=%d", __entry->nid) +); + +TRACE_EVENT(mm_vmscan_lru_shrink_active_end, TP_PROTO(int nid, unsigned long nr_taken, unsigned long nr_active, unsigned long nr_deactivated, diff --git a/mm/vmscan.c b/mm/vmscan.c index 4e3b835c6b4a..73e690b3ce68 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1906,6 +1906,8 @@ static unsigned long shrink_inactive_list(unsigned long nr_to_scan, struct pglist_data *pgdat = lruvec_pgdat(lruvec); bool stalled = false; + trace_mm_vmscan_lru_shrink_inactive_start(pgdat->node_id); + while (unlikely(too_many_isolated(pgdat, file, sc))) { if (stalled) return 0; @@ -1990,7 +1992,7 @@ static unsigned long shrink_inactive_list(unsigned long nr_to_scan, if (file) sc->nr.file_taken += nr_taken; - trace_mm_vmscan_lru_shrink_inactive(pgdat->node_id, + trace_mm_vmscan_lru_shrink_inactive_end(pgdat->node_id, nr_scanned, nr_reclaimed, &stat, sc->priority, file); return nr_reclaimed; } @@ -2028,6 +2030,8 @@ static void shrink_active_list(unsigned long nr_to_scan, int file = is_file_lru(lru); struct pglist_data *pgdat = lruvec_pgdat(lruvec); + trace_mm_vmscan_lru_shrink_active_start(pgdat->node_id); + lru_add_drain(); spin_lock_irq(&lruvec->lru_lock); @@ -2107,7 +2111,7 @@ static void shrink_active_list(unsigned long nr_to_scan, lru_note_cost(lruvec, file, 0, nr_rotated); mem_cgroup_uncharge_list(&l_active); free_unref_page_list(&l_active); - trace_mm_vmscan_lru_shrink_active(pgdat->node_id, nr_taken, nr_activate, + trace_mm_vmscan_lru_shrink_active_end(pgdat->node_id, nr_taken, nr_activate, nr_deactivate, nr_rotated, sc->priority, file); }