From patchwork Mon Dec 11 13:08:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 176706 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp7034147vqy; Mon, 11 Dec 2023 05:08:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IHEteF3OoSa5+0aGb4rFsHwObY8BhSoP0tgnpC86beCvnhL6T6awmMHLhOlnFQqpkIf8JMF X-Received: by 2002:a05:6871:8286:b0:1fb:75b:99bf with SMTP id sq6-20020a056871828600b001fb075b99bfmr6323325oab.110.1702300134122; Mon, 11 Dec 2023 05:08:54 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1702300134; cv=pass; d=google.com; s=arc-20160816; b=Pa2w7btp18RfzXIIx13zUNMLwhLJq0v7df5fNYt7+A5ZLJ+QSjg7wer8ipA4l+6xgM QXQrGM8LJ7+uMJGuZetcvJaEsrtesaYjGl9F3UDde33LarhfEaWn3GnkHwVhQ9jcW2Io p+cYAUFfQb1KqbjFZ9VR45aWBLZWylwLn8ZKXPb8NjOp8q8ZvxnfBWuREOl34Exuu1/V KVJmX4OW+GUrtDUyTM/b/DmpugGCYJvEbJj1Hck3Y/Lyjo3ENNgUEPt8GbJVJHJDrjrg aVj/ToTUU+kBnRJGGqyhmt2Ba3oEizgitETqUVTs5nMZCcGa2JTG29cIICZ4EbxtdEA4 VJQQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :in-reply-to:autocrypt:references:cc:to:from:content-language :subject:user-agent:mime-version:date:message-id:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=/h/WKoqe8mKU4Agla95jTnMaZl/l+d6oPqKym1JRHl0=; fh=8WW8/k0o0G2vlJiZAQKLzwZ5FShsw2CjyMds4OH6804=; b=w3QKgMf2Fp2G5rg4o5/qmEJmXevgIK14wazI57kygRqy25kJJ2uIJwJEDEyP7glJgO 0GK90Tq6HMzmFBcqRhgIvClsGsym3xAZ59OB7VEA2j7b67MPT4ansGMxsCy5HfNM3Ps+ NZMGSSWCYUWnwU3GN6/RMl2/u83uEn06uD56uZQr2jd7AoXX+LQmwd9yfuSmcj8qFUbb ytqJe3nicQu5ryPEhbMICKETvQfOCnS+vtdpo7i4GLqzutS6/hBfYhR5pDlmubJUNicu +SiiRlBvM0YGvr/DfwTIb37fq6De7xLANoRD/VtwkqBgELKfYMY3i+NuG53yAg+0X31h NRKw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.com header.s=google header.b=GtlokNJH; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id d10-20020ab07c4a000000b007c415c7c186si1300408uaw.86.2023.12.11.05.08.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 05:08:54 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=google header.b=GtlokNJH; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 98A7638582BB for ; Mon, 11 Dec 2023 13:08:53 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id 2243D3858C42 for ; Mon, 11 Dec 2023 13:08:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2243D3858C42 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2243D3858C42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::334 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702300128; cv=none; b=s2JGjg+jk96s5k6RLPkS504p0C20r6T2l1dLvLUISCHckj3YAbVRaeQywv4W+0NEXGXBpuHKau17l8ndQirTmnjsTIjp1Ahabo0TNynX7MTbApfHPWwhNRi2CJV0Lm8hgmyBHC9uBdo2q2fPlLLgWTG5qdlfMzK84GkE4wRDME4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702300128; c=relaxed/simple; bh=qYyS2cr9f0BQjJwxCqlkrGnF1mNYchr0wkXgKXC7tk4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=Kxc/SGN1/GjJasssaZ9gwT9rOs+6qnjjeubEZUTOyFA6rEmGPxMsbmtjFNiLPdsUHjKMDtXy9Za5t+zebnpUKVjL8iqEMhWyeoV5G9aMxoCGN8lNXGApLvgxRI0URXT5ytC7PuWw+9K/adsvuFbSmY0qRwKA/yobv3Q/rYT0Ymo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-40c3ceded81so19995145e9.1 for ; Mon, 11 Dec 2023 05:08:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1702300121; x=1702904921; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=/h/WKoqe8mKU4Agla95jTnMaZl/l+d6oPqKym1JRHl0=; b=GtlokNJHJDqw7nWiJ2zlC0ItVsw7qjWmWQaslxef2vRUqwCFj4Y+ymNouc7Q2FF+m4 nHjeEXdBeduijv4dJ6b0r5W8D/Z6B2kdz5meXdhQwd33pZn3/H5T6P5nHkFcjruPlRRG 5DbDrzwAYQijvLMjOjR878FVghCngLogBo/hWfbGQPLmJTXUjFLkm1LyPRRO/NeoOruw gcZ4I7UbL0crNHuuphWzNySa+6bk7hzSUl4eb1W0DXyyfl7Ez6UWno4Gj36MmHYEjnoH 7twIB+OXeC7wMdL+o1YWlB+MIjQ5BrPQtTRTPPo+xKibj0lNwWZD1uKNxy81wWAxuW0i z++A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702300121; x=1702904921; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/h/WKoqe8mKU4Agla95jTnMaZl/l+d6oPqKym1JRHl0=; b=SxZckGr7L0+WBYvB1WUcXPw7GmAcLNVGI3Y1eL49FJzijYXZzblReDohNMwWQBu+ir wiP+J+rUIWF8OQV8viXdmMex0I5/Z/bQkvWny0p2kzvnlRxPkIBucI2MXAIVkaL0XIEf Hkxf+NFn/RJiClqvXDX3xwhKEwG1pBAhtN+Ee8EmhRiWANzUEMTOvfzvIWXf+FU/hwE1 V7QyF5inNnSDgnfUIlYtQ7uY/7P4veVCEZMqe7+skRUpKmLRxCxLT+MFPoEcYNxiHqjk vRcOnAOk+H6b6dXgqzc21tTzK6TjIfoqc3THjlzRqhlRQhlmiWs6akGJ9hruGjyVmELl 95OA== X-Gm-Message-State: AOJu0YxjfEdFFS9W/ZTxezEXwwkMz0e+7DDTiCHfjvOnEn3M6qfIpHEU JmEklK/ocdyj5OB0IDqcUMX7e3z0QUL5sLBygJiN X-Received: by 2002:a05:600c:1c93:b0:40b:5e59:e9f8 with SMTP id k19-20020a05600c1c9300b0040b5e59e9f8mr2124901wms.151.1702300120887; Mon, 11 Dec 2023 05:08:40 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id he10-20020a05600c540a00b0040b3829eb50sm12829168wmb.20.2023.12.11.05.08.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Dec 2023 05:08:40 -0800 (PST) Message-ID: <433944f9-2735-4113-ab9c-d546abf0aa45@suse.com> Date: Mon, 11 Dec 2023 14:08:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 1/4] x86: don't needlessly override .bss Content-Language: en-US From: Jan Beulich To: Binutils Cc: "H.J. Lu" References: <25484cfc-e9d3-4b6b-968d-7642ae53301d@suse.com> Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <25484cfc-e9d3-4b6b-968d-7642ae53301d@suse.com> X-Spam-Status: No, score=-3026.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784991065353590684 X-GMAIL-MSGID: 1784991065353590684 ELF, COFF, and Mach-O all have custom handlers for .bss. Don't override those; install a handler only for a.out. --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -181,7 +181,7 @@ static const reg_entry *build_modrm_byte static void output_insn (const struct last_insn *); static void output_imm (fragS *, offsetT); static void output_disp (fragS *, offsetT); -#ifndef I386COFF +#ifdef OBJ_AOUT static void s_bss (int); #endif #if defined (OBJ_ELF) || defined (OBJ_MAYBE_ELF) @@ -1201,9 +1201,10 @@ const pseudo_typeS md_pseudo_table[] = {"align", s_align_ptwo, 0}, #endif {"arch", set_cpu_arch, 0}, -#ifndef I386COFF +#ifdef OBJ_AOUT {"bss", s_bss, 0}, -#else +#endif +#ifdef I386COFF {"lcomm", pe_lcomm, 1}, #endif {"ffloat", float_cons, 'f'}, @@ -15475,17 +15476,13 @@ md_pcrel_from (fixS *fixP) return fixP->fx_size + fixP->fx_where + fixP->fx_frag->fr_address; } -#ifndef I386COFF +#ifdef OBJ_AOUT static void s_bss (int ignore ATTRIBUTE_UNUSED) { int temp; -#if defined (OBJ_ELF) || defined (OBJ_MAYBE_ELF) - if (IS_ELF) - obj_elf_section_change_hook (); -#endif temp = get_absolute_expression (); subseg_set (bss_section, (subsegT) temp); demand_empty_rest_of_line (); From patchwork Mon Dec 11 13:09:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 176707 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp7034608vqy; Mon, 11 Dec 2023 05:09:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IEPoiTqT36wa/5qzOUxNtJljcys8141kG+2AOpJquj9DkZ40wTiS0iJ4gs2VBsUQJB/ffjm X-Received: by 2002:a4a:ea17:0:b0:590:6a57:9caf with SMTP id x23-20020a4aea17000000b005906a579cafmr2369955ood.10.1702300169016; Mon, 11 Dec 2023 05:09:29 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1702300168; cv=pass; d=google.com; s=arc-20160816; b=AIfEmvZLByY5SS8xA4W+PdgYz7K+OUf77F/abcpkW22uNowc/thBVm91GTTyA3uifY G4nUrFDvGGo7Y6WHmvE4tldqUgeZuQ1iAw9z18yLIRHoAVEUEmmLHaqZ7LOE/0evG8oN 86NMky1Jm3dscE5d5jlyNKOtggCXYRi1b5HHP1nWcgLA0QPfL1OGHER6MQfcRAW/mzkS yLJHcqrhY+bAPcm4gCj9EyzhOX6sscUpgxcXsyBMemMwBVpvxWcfyfYJ5gLOI6HIhOY4 xbs2arBQOrVR+jjUSJQ5wvUQLKYJ00X8qWXypXs0HzEWAvvxo0vFh9knLPvFkoaTbuWK qltg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :in-reply-to:autocrypt:references:cc:to:from:content-language :subject:user-agent:mime-version:date:message-id:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=2zU2L8oyR0tDwzyO76/AJov4rRv/ZINEDRb3/3n+3M0=; fh=5Xzgsfi+BxTA/WBX/8ajZrRB4ZtN7RJCiTegFMT79QQ=; b=lI/n/fS6NkcNMgCHY+MqrOoRntC/thTKO0kKb8MHwVe8vUhqc0cRxmiSJK1eczRXZZ /8/E2X6UaETx408q5jdrVwE6IucVxziZbha0i0Ph62STvSz7UfqT0NZIf5pPGXFReES2 cSBXCWldSCB0BMAERSO3pvWCAtR2igkBdPurYvUq/w9Z1q9FFi54D8XM3fbrGmIFTGs8 m2ez7eeGZ4sSoisfmEUatASdl8j7WDdZ+aZTBwQrcd4pPrkiYASxVGJdnkn00ZRRTXhF FvatIn7hrP/ia+W8fvxwREaS8IGzCxhBP6N7jqAM/CfSBDdjtJSRVdMEQVZK0UEPaMSg la6Q== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.com header.s=google header.b=gDy6AGHI; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id et15-20020a0561221c0f00b004b311385efesi1302630vkb.316.2023.12.11.05.09.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 05:09:28 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=google header.b=gDy6AGHI; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BAD0C3857B9A for ; Mon, 11 Dec 2023 13:09:28 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by sourceware.org (Postfix) with ESMTPS id 555733858C56 for ; Mon, 11 Dec 2023 13:09:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 555733858C56 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 555733858C56 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::330 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702300164; cv=none; b=GwZUQ/yg8BEwj0WCitMXqmtfID4gOGVxOM6fiAmJLQwRYdYhas8O6kZIQcg39hZyA8KEhq0Z6VoIwsuZgolXLKQsCSok8dP8Xh7PCOIm52tgccMJv2rlfM6vK/hjkW/VqNXytrYJkyaXpJxEK0lqBM5c3zMB6c/gU8IhRgOeBUg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702300164; c=relaxed/simple; bh=JJCJiusZlEzXkg6VUlgkOF1rgyyza+j1YNsFo4ipQPU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=gJdUJPgVI0vJMb7dsBwk/lz+UG1RrwyxUua1o8j6O4bKbhZkQ6Dbpt7+Im8S6dYjMZveWL6qw/a2s5Xmh/dWx7XRnRJZwigny8nFV+mVV76s52cWWnIruxScI3zjX0Ns+ZIvpnMgStQZs0o9GBgs8h6ESlaJALNu6FID27rvj+c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-40c2308faedso46599015e9.1 for ; Mon, 11 Dec 2023 05:09:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1702300161; x=1702904961; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=2zU2L8oyR0tDwzyO76/AJov4rRv/ZINEDRb3/3n+3M0=; b=gDy6AGHI5XM/a0gw4A6pJqsISVdtS5y4Gr5nHTYF5OoYoGMzVsRTl1Gb8qjg7PpyiQ pk/JeThlafCtmVHq9ZPHSs9G5VlvhzBZzfRFjCaRWI6kST0lR0bDBMxL+1Inj9so3UMA BdEFZB7MfVL/JMIQZVsUpl/99xDqDY7EVjkoq0dy7c/SOxYrm22MAJj0i253enPFnVqJ KxeR7LCMLSiSdhKedRKVn71MmlCk3TR0ULP8aFbzh6wtMWji2z/+7EaEn6QAM3HjkdiN 3RdRSv84dI21fTd7p+mL0ffgRApoXiD81brhAVIKmWFHQoIYW0/0Syzz+Uc5SoP1mXJC U8Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702300161; x=1702904961; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2zU2L8oyR0tDwzyO76/AJov4rRv/ZINEDRb3/3n+3M0=; b=iuA2ly4gLAEDjr/2TUEdNquaxLMzB/LL8BrxAsMUUHem04qRpXrrGqDjrrcc2h2QPr r+ClRI1H+BDUhDaymqyFd3k9yEVr1Vg7skt5dAJyFUniHFm/Hje/PdGBo6Btc8vlky9i YnYNtRwD8/axO2Y3v+yE3LpcOO7pxWS4f275MA6//AQFpbdujsP5HmvU/EZv4rSTtnS2 kSxdDQWG+siSKoxCqJEDHjgDwZUEctupUzti+sEFY9Egm/2NLZl2cnJf1tNscHYxA8QG RZphR8Nn9hUHSr8jF/ER7Z8r8y6yvJKSXt4kOql0TYjYBs/Ws08fYGVyqnmmwVUQ8meQ p+MA== X-Gm-Message-State: AOJu0YzZIZEvPdlmepgaLr2hIa2BMPkEs+52mHsGX/C4PgZqN0SQx6KQ rhTj93BLembvYMEa5jFxF1XxqDs5gzDMLM3z8Gs/ X-Received: by 2002:a05:600c:350c:b0:40c:2990:45c7 with SMTP id h12-20020a05600c350c00b0040c299045c7mr2356104wmq.86.1702300161074; Mon, 11 Dec 2023 05:09:21 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id he10-20020a05600c540a00b0040b3829eb50sm12829168wmb.20.2023.12.11.05.09.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Dec 2023 05:09:20 -0800 (PST) Message-ID: <956811de-8605-44da-9429-4107f0bc114f@suse.com> Date: Mon, 11 Dec 2023 14:09:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 2/4] ELF: drop "push" parameter from obj_elf_change_section() Content-Language: en-US From: Jan Beulich To: Binutils Cc: "H.J. Lu" , Nick Clifton , Alan Modra References: <25484cfc-e9d3-4b6b-968d-7642ae53301d@suse.com> Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <25484cfc-e9d3-4b6b-968d-7642ae53301d@suse.com> X-Spam-Status: No, score=-3026.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784991102207660111 X-GMAIL-MSGID: 1784991102207660111 No caller outside of obj-elf.c cares about the parameter - drop it by introducing an obj-elf.c-internal wrapper. While adding the new function parameter, take the opportunity and change the adjacent boolean one to "bool". --- v2: New. --- a/gas/config/obj-elf.c +++ b/gas/config/obj-elf.c @@ -540,14 +540,14 @@ get_section_by_match (bfd *abfd ATTRIBUT other possibilities, but I don't know what they are. In any case, BFD doesn't really let us set the section type. */ -void -obj_elf_change_section (const char *name, - unsigned int type, - bfd_vma attr, - int entsize, - struct elf_section_match *match_p, - int linkonce, - int push) +static void +change_section (const char *name, + unsigned int type, + bfd_vma attr, + int entsize, + struct elf_section_match *match_p, + bool linkonce, + bool push) { asection *old_sec; segT sec; @@ -820,6 +820,17 @@ obj_elf_change_section (const char *name #endif } +void +obj_elf_change_section (const char *name, + unsigned int type, + bfd_vma attr, + int entsize, + struct elf_section_match *match_p, + bool linkonce) +{ + change_section (name, type, attr, entsize, match_p, linkonce, false); +} + static bfd_vma obj_elf_parse_section_letters (char *str, size_t len, bool *is_clone, int *inherit, bfd_vma *gnu_attr) @@ -1488,8 +1499,7 @@ obj_elf_section (int push) } } - obj_elf_change_section (name, type, attr, entsize, &match, linkonce, - push); + change_section (name, type, attr, entsize, &match, linkonce, push); if (linked_to_section_index != -1UL) { --- a/gas/config/obj-elf.h +++ b/gas/config/obj-elf.h @@ -198,7 +198,7 @@ extern void obj_elf_data (int); extern void obj_elf_text (int); extern void obj_elf_change_section (const char *, unsigned int, bfd_vma, int, struct elf_section_match *, - int, int); + bool); extern void obj_elf_vtable_inherit (int); extern void obj_elf_vtable_entry (int); extern struct fix * obj_elf_get_vtable_inherit (void); --- a/gas/config/tc-arm.c +++ b/gas/config/tc-arm.c @@ -27775,7 +27775,7 @@ start_unwind_section (const segT text_se } obj_elf_change_section (sec_name, type, flags, 0, &match, - linkonce, 0); + linkonce); /* Set the section link for index tables. */ if (idx) --- a/gas/config/tc-ia64.c +++ b/gas/config/tc-ia64.c @@ -1139,7 +1139,7 @@ obj_elf_vms_common (int ignore ATTRIBUTE obj_elf_change_section (sec_name, SHT_NOBITS, SHF_ALLOC | SHF_WRITE | SHF_IA_64_VMS_OVERLAID | SHF_IA_64_VMS_GLOBAL, - 0, NULL, 1, 0); + 0, NULL, true); S_SET_VALUE (symbolP, 0); S_SET_SIZE (symbolP, size); --- a/gas/config/tc-microblaze.c +++ b/gas/config/tc-microblaze.c @@ -150,7 +150,7 @@ microblaze_s_data (int ignore ATTRIBUTE_ { #ifdef OBJ_ELF obj_elf_change_section (".data", SHT_PROGBITS, SHF_ALLOC+SHF_WRITE, - 0, 0, 0, 0); + 0, 0, false); #else s_data (ignore); #endif @@ -163,7 +163,7 @@ microblaze_s_sdata (int ignore ATTRIBUTE { #ifdef OBJ_ELF obj_elf_change_section (".sdata", SHT_PROGBITS, SHF_ALLOC+SHF_WRITE, - 0, 0, 0, 0); + 0, 0, false); #else s_data (ignore); #endif @@ -282,7 +282,7 @@ microblaze_s_rdata (int localvar) { /* rodata. */ obj_elf_change_section (".rodata", SHT_PROGBITS, SHF_ALLOC, - 0, 0, 0, 0); + 0, 0, false); if (rodata_segment == 0) rodata_segment = subseg_new (".rodata", 0); } @@ -290,7 +290,7 @@ microblaze_s_rdata (int localvar) { /* 1 .sdata2. */ obj_elf_change_section (".sdata2", SHT_PROGBITS, SHF_ALLOC, - 0, 0, 0, 0); + 0, 0, false); } #else s_data (ignore); @@ -303,12 +303,12 @@ microblaze_s_bss (int localvar) #ifdef OBJ_ELF if (localvar == 0) /* bss. */ obj_elf_change_section (".bss", SHT_NOBITS, SHF_ALLOC+SHF_WRITE, - 0, 0, 0, 0); + 0, 0, false); else if (localvar == 1) { /* sbss. */ obj_elf_change_section (".sbss", SHT_NOBITS, SHF_ALLOC+SHF_WRITE, - 0, 0, 0, 0); + 0, 0, false); if (sbss_segment == 0) sbss_segment = subseg_new (".sbss", 0); } --- a/gas/config/tc-mips.c +++ b/gas/config/tc-mips.c @@ -16435,7 +16435,7 @@ s_change_section (int ignore ATTRIBUTE_U section_type = SHT_PROGBITS; obj_elf_change_section (section_name, section_type, section_flag, - section_entry_size, 0, 0, 0); + section_entry_size, 0, false); } void --- a/gas/config/tc-msp430.c +++ b/gas/config/tc-msp430.c @@ -622,7 +622,7 @@ msp430_profiler (int dummy ATTRIBUTE_UNU subseg = now_subseg; /* Now go to .profiler section. */ - obj_elf_change_section (".profiler", SHT_PROGBITS, 0, 0, 0, 0, 0); + obj_elf_change_section (".profiler", SHT_PROGBITS, 0, 0, 0, false); /* Save flags. */ emit_expr (& exp, 2); --- a/gas/config/tc-rx.c +++ b/gas/config/tc-rx.c @@ -488,7 +488,7 @@ parse_rx_section (char * name) else type = SHT_NOBITS; - obj_elf_change_section (name, type, attr, 0, NULL, false, false); + obj_elf_change_section (name, type, attr, 0, NULL, false); } else /* Try not to redefine a section, especially B_1. */ { @@ -503,7 +503,7 @@ parse_rx_section (char * name) | ((flags & SEC_STRINGS) ? SHF_STRINGS : 0) | ((flags & SEC_THREAD_LOCAL) ? SHF_TLS : 0); - obj_elf_change_section (name, type, attr, 0, NULL, false, false); + obj_elf_change_section (name, type, attr, 0, NULL, false); } bfd_set_section_alignment (now_seg, align); --- a/gas/config/tc-tic6x.c +++ b/gas/config/tc-tic6x.c @@ -4662,7 +4662,7 @@ tic6x_start_unwind_section (const segT t } obj_elf_change_section (sec_name, type, flags, 0, &match, - linkonce, 0); + linkonce); /* Set the section link for index tables. */ if (idx) From patchwork Mon Dec 11 13:09:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 176708 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp7034995vqy; Mon, 11 Dec 2023 05:10:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IE1PPZjbILOlLgB3Zny63TRyh93tfXia5RAjIaYXb7KxcqXPdCf70Gucq0NOSYkyqqHjtXX X-Received: by 2002:a05:6830:314e:b0:6da:9f4:b8ae with SMTP id c14-20020a056830314e00b006da09f4b8aemr3632589ots.56.1702300199898; Mon, 11 Dec 2023 05:09:59 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1702300199; cv=pass; d=google.com; s=arc-20160816; b=S65Ph1pUHQfu2TZlLaYPbWuh1UHJAxsJsQ8fwld1f6ZEqdqMDxNt8Eoeic8KNx/jxW 9Z/mnnEZnbyp2mrsYE+UDCKY9MIeZzf1EpcVEO/PXrcCJgpdl3XFJIETo/qOm2JlZBqG 1txts7a13iQca953SpxVmIGYovhcAv8d5j6j33ShwQlq0BOJ8JRHcfzRWA1e73b24cUD 5S2JieVLpXagzqt6/PQSEIg0ErcveeEmRt8XzLddt69p9V40g9IojBKuR+3LOnBTXI4Q 09RY9RtHgDcIB0FreKGujoQP63U/H6cg8d+KAfPDpTe+z871k7tjYYQ5tgtpHnhR2pVS 6Ylw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :in-reply-to:autocrypt:references:cc:to:from:content-language :subject:user-agent:mime-version:date:message-id:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=4lEIbOgAqS7EelNKMF2gzF9cprWvqHHISA/USHrP6ug=; fh=5Xzgsfi+BxTA/WBX/8ajZrRB4ZtN7RJCiTegFMT79QQ=; b=WdGFAZM3TsdoPFvImY+zx9KepTMKAmPS/b5R5KgchL5IsKEeHddvRL7tCO2sfUgycI 6yqD6/kDyRlrUWacyFr9dfUMVFWt9fC+EVO+jNyca850inB0hyckKHMEIAOhbgZDuG1J uRfeWN7GzKSBjTWX0FNI0haAnfNM6leGU5PBicOROuNbkRr5RpK8mf87qAEusP3v/OjW 39uT2+AbaV402PnaxfxtrOca0DKDjKBizGX8mtrqC237GG19BswlhR0qFkc3aii81qow SkejU8xK3UT4BdoRSIaZZYpO98Aw2EsPTj82jMxHlR+it//IOJaJBoiJf+XDiTTgBtgH /PfQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.com header.s=google header.b=MW2ntxQm; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id a4-20020a67f2c4000000b004648f3eaeb9si1200806vsn.138.2023.12.11.05.09.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 05:09:59 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=google header.b=MW2ntxQm; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3F8B93857B92 for ; Mon, 11 Dec 2023 13:09:59 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by sourceware.org (Postfix) with ESMTPS id C40A63858413 for ; Mon, 11 Dec 2023 13:09:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C40A63858413 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C40A63858413 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702300194; cv=none; b=udCBnGvH6PWXsS3xVVSIjblbmoawaR5dDbycMa+yQg5kVxkiirJJ93/TtdqxbecuZhNG4V4Zgud8SjhaT7Hwf0YjacIhUQ0Jk1eO8MPGEvGiIOaWcrGURZIBlRFSmaCxvfuuCGL9gYTThcSPMw0rd+7YRci1KWGXO3goFHt9Xb4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702300194; c=relaxed/simple; bh=VQD/YqugqTbTSz3b3w0jGOPmd2ZLv+5r/e0my3OvtMQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=YAWc6JtBbU3AGtZR1sJu3vGFEiHd4I4M9jktPbzh+2y09KqLK72B5I3b3lHQhG6nP45hWV56cxhQemtOEYawbrsErM4bKwEHac0RaJ5XhgMXJSgDvnMDbEi07m67NfSZKXnvCxJ27BmnAI4VBpVe8ggxcwltNHbLZW/zGomAHtg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-40c3984f0cdso27246685e9.1 for ; Mon, 11 Dec 2023 05:09:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1702300191; x=1702904991; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=4lEIbOgAqS7EelNKMF2gzF9cprWvqHHISA/USHrP6ug=; b=MW2ntxQm3FhLAJ1B5/K2vRg6EFAluj3pbpoFXDovG4kJm9NiOijt+VRFTZV4uQXZSa E2/yEHvPtvTvKJ+N7NghweAcCjtK7g2vB69u0QLXXAEkhNbEvnQOpxjPFowNs6TyEefi MPnvufw+6nN/5kf1k787ong/bmfann/gSj0LNXao4DRbIuok4FK/6m7WATptwmVz+wpE FFT/ZA5meJ0scs4oVZRkSb07PZDUeyvqoTHgUSpWmi30OXFI10eybkWtZaqh3Tgx4hkn n5DU6hIGWDsb1YFjcgvn2KJn2p6+KQftECsw2f1zxvR54iYas4bsmCEHeZd9QmZLoN+G 4ttA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702300191; x=1702904991; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4lEIbOgAqS7EelNKMF2gzF9cprWvqHHISA/USHrP6ug=; b=svFS8/g2Fe4ubViExfoHtCfANNYkOzlmBnRMSca+9K5sU12CwMQdUsLBrR/EHPXdnb M/TAFnhN7REUi/TMEpDRgDBUeu+eAO+GfJWwf26VfNHB9wzk9+CwwUkxWLvTDRGfgOAj fAI5T6/qyfasjoEyEaL+aUPUmuSlFIhYkZH9ZdLIBafDIYdDoP8R5PSqmafjDO4V7qBA BechM0a3ZKoXIODCeNBHv9Wqo3qkSNixdRHLWE8JVfnz8INE1KfSZc0MWukCbtZ+VWsB KY6FN/MMVjjS3GlAOJvmHKu9nJ0rPCnD5/HUuBZlZ41FVhFDRBVGsuE+TdlyOwRwyLhh g7tA== X-Gm-Message-State: AOJu0YxH3GqOF47LCqHyYBrsUrWLU8OrUf4JFTZYUJwAqlYA8v9f2wqJ WjVV05ie7Xy6wpVlzUVhusGeMo7bTsTkIPm2bkk0 X-Received: by 2002:a7b:c8c8:0:b0:40b:5e21:dd44 with SMTP id f8-20020a7bc8c8000000b0040b5e21dd44mr2452221wml.114.1702300191593; Mon, 11 Dec 2023 05:09:51 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id he10-20020a05600c540a00b0040b3829eb50sm12829168wmb.20.2023.12.11.05.09.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Dec 2023 05:09:51 -0800 (PST) Message-ID: <49271770-95e3-4c34-9e0a-aa9886ad6760@suse.com> Date: Mon, 11 Dec 2023 14:09:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 3/4] ELF: reliably invoke md_elf_section_change_hook() Content-Language: en-US From: Jan Beulich To: Binutils Cc: "H.J. Lu" , Nick Clifton , Alan Modra References: <25484cfc-e9d3-4b6b-968d-7642ae53301d@suse.com> Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <25484cfc-e9d3-4b6b-968d-7642ae53301d@suse.com> X-Spam-Status: No, score=-3026.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784991133974217852 X-GMAIL-MSGID: 1784991133974217852 ... after any (sub)section change. While certain existing target hooks only look at now_seg, for a few others it looks as if failing to do so could have caused anomalies if sub-sections were used. In any event a subsequent x86 change is going to require the sub-section to be properly in place at the time the hook is invoked. This primarily means for obj_elf_section() to pass the new subsection into change_section(), for it to be set right away (ahead of invoking the hook). Also adjust obj_elf_ident() to invoke the hook after all section changes. (Note that obj_elf_version(), which also changes sections and then changes them back, has no hook invocation at all so far, so none are added. Presumably there is a reason for this difference in behavior.) --- v2: Re-base over new earlier patch. --- a/gas/config/obj-elf.c +++ b/gas/config/obj-elf.c @@ -547,7 +547,8 @@ change_section (const char *name, int entsize, struct elf_section_match *match_p, bool linkonce, - bool push) + bool push, + subsegT new_subsection) { asection *old_sec; segT sec; @@ -585,10 +586,10 @@ change_section (const char *name, if (old_sec) { sec = old_sec; - subseg_set (sec, 0); + subseg_set (sec, new_subsection); } else - sec = subseg_force_new (name, 0); + sec = subseg_force_new (name, new_subsection); bed = get_elf_backend_data (stdoutput); ssect = (*bed->get_sec_type_attr) (stdoutput, sec); @@ -828,7 +829,7 @@ obj_elf_change_section (const char *name struct elf_section_match *match_p, bool linkonce) { - change_section (name, type, attr, entsize, match_p, linkonce, false); + change_section (name, type, attr, entsize, match_p, linkonce, false, 0); } static bfd_vma @@ -1114,8 +1115,8 @@ obj_elf_section (int push) bfd_vma attr; bfd_vma gnu_attr; int entsize; - int linkonce; - subsegT new_subsection = -1; + bool linkonce; + subsegT new_subsection = 0; struct elf_section_match match; unsigned long linked_to_section_index = -1UL; @@ -1499,7 +1500,8 @@ obj_elf_section (int push) } } - change_section (name, type, attr, entsize, &match, linkonce, push); + change_section (name, type, attr, entsize, &match, linkonce, push, + new_subsection); if (linked_to_section_index != -1UL) { @@ -1507,9 +1509,6 @@ obj_elf_section (int push) elf_section_data (now_seg)->this_hdr.sh_link = linked_to_section_index; /* FIXME: Should we perform some sanity checking on the section index ? */ } - - if (push && new_subsection != -1) - subseg_set (now_seg, new_subsection); } /* Change to the .bss section. */ @@ -2529,9 +2528,17 @@ obj_elf_ident (int ignore ATTRIBUTE_UNUS *p = 0; } else - subseg_set (comment_section, 0); + { + subseg_set (comment_section, 0); +#ifdef md_elf_section_change_hook + md_elf_section_change_hook (); +#endif + } stringer (8 + 1); subseg_set (old_section, old_subsection); +#ifdef md_elf_section_change_hook + md_elf_section_change_hook (); +#endif } #ifdef INIT_STAB_SECTION From patchwork Mon Dec 11 13:10:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 176709 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp7035251vqy; Mon, 11 Dec 2023 05:10:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IHB2yDZZkBbHdy1dZn1FxMYgttOPPtanR3JHSlmvTNs1oraquITeDxo85iFFYUSub6wMTxo X-Received: by 2002:a67:ef08:0:b0:464:810c:54d8 with SMTP id j8-20020a67ef08000000b00464810c54d8mr3458622vsr.1.1702300221284; Mon, 11 Dec 2023 05:10:21 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1702300221; cv=pass; d=google.com; s=arc-20160816; b=zRrsqWpWLW0Pq17NaFQfZUZoGGZLfouVxT9BU6FFKwtjBBwlCi80qOw1GJppn7qfRd Sokx0mSBBdqQwbJLjeVsxtjgnoshYqe/s3WukBhNQvWnODR33nWszbInc9qbz3B7k4Ym oRAldOKVkDdBSGCnkNxxZ+QYkh2jNACzV8EvQPtUUTIy22pwmbeUqB39s0n4u16jYIqf GDONaFVwrL8MtpzF1FExQiRDl6eDmW82eWTu7s6xjK0N4gUQgqpKMCxo8ksqe4D2ND1i X+ZomXeH8vBn2t/j7HdDFU79AHqq3giUabsa4HKWFwLdPg2YQk5/YS9TNOZL2M60UFSL O+Ag== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :in-reply-to:autocrypt:references:cc:to:from:content-language :subject:user-agent:mime-version:date:message-id:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=9mEMcMc4MzHxZZFPrA4O742B7xGCp+7sU94WvgFFgOg=; fh=8WW8/k0o0G2vlJiZAQKLzwZ5FShsw2CjyMds4OH6804=; b=xU46IPtC1TIl4H2XknvpMBLBgIcKTaaZKKG85Ht/8f5nyMdiLJfxAWL+9Qn49lO+yn b5XgVYkocfGM4kH6J9b6oChw8kb7H3JNWVb/J/AOnwqZ4OjOY67LAaVnud+mpXFNQOgV C4NY7I5ZZGkXkRwiyPUG1QPExB2lh6CrIlo3OReB4j+8jDXwHHyMeGJH9k4ziEji2SoD hMhen1dILlq9a2dESdz59551FPrOuYEwu+f/OXnWfMmplg7zZIHulVch1TkrTt/U3eie wn2b3DoT36GOgL5XmoBEeXAeTDcJYNRrhw1ouWf7H9lwxAHjqruSws/oXZZT/HyexJ9L p32g== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.com header.s=google header.b=Wj9J25DS; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id r18-20020a67cd92000000b004649146b120si1197379vsl.377.2023.12.11.05.10.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 05:10:21 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=google header.b=Wj9J25DS; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A5E2B385AC2E for ; Mon, 11 Dec 2023 13:10:20 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 26823385735A for ; Mon, 11 Dec 2023 13:10:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 26823385735A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 26823385735A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702300216; cv=none; b=keZ3ea6oUJAXUyPN5zCeKTwQgBiQB4ImDDJos+vHB+CYZogrhKb9iQ3FdvZFRMc91KBQIlJ8hiugPOPJrYfhue6Mhwp/KmN4/3Gxvd7UtXWeAFySg/FSvzgw0VnUG6N1pPhLYzCQ4w6VK2AIjk3KHV1vHCIICOt1NIoaN64ltyk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702300216; c=relaxed/simple; bh=5BxyDWz3RgODbE2iUeOi+0i9GZIOAZlss5oMN6+C+3A=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=JG5+/DNmCCIZ76m4DfhsWnoJCztkU2ha1ncUxHqDrLoEmQ+ktL2bewZ8WwrfjYVcq7y1YXzDZlI980zbGiQCYXNy+FLPyZq9M/zbFx6g36p3jS2x4XF5XufuAqBBfDpG/2mYKjAjdilyfSiG5dBcknX1q8KtQTQvy7pGe3mfGBE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-40c41b43e1eso17006845e9.1 for ; Mon, 11 Dec 2023 05:10:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1702300212; x=1702905012; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=9mEMcMc4MzHxZZFPrA4O742B7xGCp+7sU94WvgFFgOg=; b=Wj9J25DSZx+5t8h2PcB9HPPW0WiGLlu51TiEpcjAwKmpdmFkraBDGFCE7MnFv6xp+X iew6EpfsYVOF/MPfU4fgd06dsiYKO4SZzXxUeACGnLKahvncmcrgVA7w3u+GHFaUgWOm gRKAh0UNPOMmk4QEQJiOsQUYWHr6YdDJ2yIKjfel82hz/PqnE+oX/8YQxwzatDjt4Nr0 SnO6lnNhZK+qVRc9xSdaO0q6cRY0FOLNMcPw2eXN4E7s0jb3Lh03UreXZBSgIITKLAoY P1H9Mm8kU5jdU7r8SIa1hXsgWZJvBneWeRv6ost1GQfKfZJYBVbDZHoInaMB42SgG+Rt GiWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702300212; x=1702905012; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9mEMcMc4MzHxZZFPrA4O742B7xGCp+7sU94WvgFFgOg=; b=Onvl30xx+rWiYEAD3WRNDu4Mg21F1Bbg1SjQ9vMJfor8Wlf1NzOQctENjRjaxWEIMw fmzUGd2wtKX2wlp5y2e0RqHEAxpBy+KF+Ua/GZouZH0ehLOhTfkMQBunLS+ChS36Wj+A kXiv8iXzvTHs7D3FPEj3nbdR2pbPBz0dxcoeaDRUY1PsWIOTVyn/0MYEZOVKkqFELBbz JkH0FgdNn5SZEXRk6bWLwA6n967HclWyrC5kHXGW2JxRuZM4vpaoPhA8q3cxUhM+alOi IRNtkeLI6oGs7Jy7To9ho5XicBz0zDsI73x+7K55zMVZSNOVXJQJ57gMsiETwlq36rlV 3kLg== X-Gm-Message-State: AOJu0YwnLWh7BG+ABRpCxotI4mzQL9NEAs4hMhuKR6yaSENdrww977EK oEFLt6h2ab/vh16vDq/OfA/Pu1RbJjsJthicPh18 X-Received: by 2002:a1c:4c16:0:b0:40c:513:eae4 with SMTP id z22-20020a1c4c16000000b0040c0513eae4mr1976493wmf.44.1702300211971; Mon, 11 Dec 2023 05:10:11 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id he10-20020a05600c540a00b0040b3829eb50sm12829168wmb.20.2023.12.11.05.10.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Dec 2023 05:10:11 -0800 (PST) Message-ID: Date: Mon, 11 Dec 2023 14:10:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH v2 4/4] x86: last-insn recording should be per-subsection Content-Language: en-US From: Jan Beulich To: Binutils Cc: "H.J. Lu" References: <25484cfc-e9d3-4b6b-968d-7642ae53301d@suse.com> Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <25484cfc-e9d3-4b6b-968d-7642ae53301d@suse.com> X-Spam-Status: No, score=-3026.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784991156478924782 X-GMAIL-MSGID: 1784991156478924782 Otherwise intermediate subsection switches result in inconsistent behavior. Leverage ELF's section change hook to switch state as necessary, limiting overhead to the bare minimum when subsections aren't used. --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -15920,6 +15920,39 @@ i386_elf_section_type (const char *str, return -1; } +void +i386_elf_section_change_hook (void) +{ + struct i386_segment_info *info = &seg_info(now_seg)->tc_segment_info_data; + struct i386_segment_info *curr, *prev; + + if (info->subseg == now_subseg) + return; + + /* Find the (or make a) list entry to save state into. */ + for (prev = info; (curr = prev->next) != NULL; prev = curr) + if (curr->subseg == info->subseg) + break; + if (!curr) + { + curr = XNEW (struct i386_segment_info); + curr->subseg = info->subseg; + curr->next = NULL; + prev->next = curr; + } + curr->last_insn = info->last_insn; + + /* Find the list entry to load state from. */ + for (curr = info->next; curr; curr = curr->next) + if (curr->subseg == now_subseg) + break; + if (curr) + info->last_insn = curr->last_insn; + else + memset (&info->last_insn, 0, sizeof (info->last_insn)); + info->subseg = now_subseg; +} + #ifdef TE_SOLARIS void i386_solaris_fix_up_eh_frame (segT sec) --- a/gas/config/tc-i386.h +++ b/gas/config/tc-i386.h @@ -294,6 +294,8 @@ struct i386_segment_info { last_insn_prefix } kind; } last_insn; + subsegT subseg; + struct i386_segment_info *next; }; #define TC_SEGMENT_INFO_TYPE struct i386_segment_info @@ -395,6 +397,9 @@ extern void tc_x86_frame_initial_instruc #define md_elf_section_type(str,len) i386_elf_section_type (str, len) extern int i386_elf_section_type (const char *, size_t); +#define md_elf_section_change_hook i386_elf_section_change_hook +extern void i386_elf_section_change_hook (void); + #ifdef TE_SOLARIS #define md_fix_up_eh_frame(sec) i386_solaris_fix_up_eh_frame (sec) extern void i386_solaris_fix_up_eh_frame (segT); --- a/gas/testsuite/gas/i386/i386.exp +++ b/gas/testsuite/gas/i386/i386.exp @@ -745,6 +745,8 @@ if [gas_32_check] then { run_dump_test "nop-6" run_dump_test "unique" + run_dump_test "lfence-subsect" + run_dump_test "property-1" if {[istarget "*-*-linux*"]} then { --- /dev/null +++ b/gas/testsuite/gas/i386/lfence-subsect.d @@ -0,0 +1,18 @@ +#as: -mlfence-before-indirect-branch=all +#warning_output: lfence-section.e +#objdump: -dw +#name: -mlfence-before-indirect-branch=all w/ subsection switches + +.*: +file format .* + +Disassembly of section .text: + +0+ <_start>: + +[a-f0-9]+: f3 ff d0 repz call \*%eax + +[a-f0-9]+: f3 c3 repz ret + +[a-f0-9]+: cc int3 + +[a-f0-9]+: cc int3 + +[a-f0-9]+: cc int3 + +0+8 : +#pass --- /dev/null +++ b/gas/testsuite/gas/i386/lfence-subsect.s @@ -0,0 +1,19 @@ + .text +_start: + rep + + .subsection 2 +aux1: + nop + + .previous + call *%eax + rep + + .pushsection .text, 2 +aux2: + nop + + .popsection + ret + .p2align 2, 0xcc