From patchwork Fri Dec 8 16:08:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 175889 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp5555712vqy; Fri, 8 Dec 2023 08:09:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IHQXmPsUOqKN6GtbQ9dFz1WBCs5Bu351w8rjJU/XeJRinlni+2Bqed01O26UOhFBbbFsT27 X-Received: by 2002:a05:6a20:914b:b0:190:228e:4c11 with SMTP id x11-20020a056a20914b00b00190228e4c11mr220876pzc.90.1702051784980; Fri, 08 Dec 2023 08:09:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702051784; cv=none; d=google.com; s=arc-20160816; b=m994c2+YSlUcg2pD/4NK5btS2VDa82TXithGUoyiaiQIz46XLuJnWR86WBBH0jPmmv Y6uGJ0C3PbJqwhJh6PqJHZo2MlzYJH9D1mD72w1m8QzTRKa/yz/SAZKWHCXcLR3ls/gU UNIBW9VKeHXhfW0vFhHWz28PINynUX27vB4ayE0XNGm8rWPGmAsU3hF/TRjfryw4g9YN 9uKev9kwnRf5tKSwefR23mg5EAzciNTkAS6JymaxRrqPVELEVK2pbhZ/Wn5zvPj6DWa8 0euuRlAVUuH77JVJPRy78zKOktcc/D/vUFLzlICk6cFY8sCoElCVLwOqJJtqanaqS4qJ Apyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=bnUrJ75KR7JY0FX+rTQii19xqhlihImvM0hTVxuC2G4=; fh=HkEJnMNLsUwGqICrtg0bQUhKc/ThDn5Y5tdodny3s5A=; b=bHk7nnI3sMB2Ro380oJhQ0giX2cyW799pGJREOOHG4YfadSm3wQZHSaesF9ZdaKIUi KvbYYTNuQMS3iq7T9zkxD0HiI3yZgbZRL1no8vqayMECQjJ6Ty01ysbqM5yYzC5+Cm6L /lV9FZ5RgLOjvI8QxVE7131mxLnnEuIsI52FHv3P4ormOFKHh7MtIGGrmn3nelMABC8K kuFKuiaH7OnViznlMkXEkHfv4Yj1dh0yOqJkiI/hxVztfTstxhrYq5eEPArETLp9riUg YJB0MNaf7R9EgEUJvtdO+PvNH6c+mDX8prKChLEq15H2S4lEsdUT3upL3g/AnoSWjE5F klJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id bz39-20020a056a02062700b005c67e10f240si1826249pgb.312.2023.12.08.08.09.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 08:09:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 193DC82E10A7; Fri, 8 Dec 2023 08:09:41 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573889AbjLHQJc (ORCPT + 99 others); Fri, 8 Dec 2023 11:09:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233666AbjLHQJQ (ORCPT ); Fri, 8 Dec 2023 11:09:16 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20B171994 for ; Fri, 8 Dec 2023 08:09:22 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rBdPe-00007w-ET; Fri, 08 Dec 2023 17:09:14 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBdPc-00ES0F-5z; Fri, 08 Dec 2023 17:09:12 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rBdPb-00GUaC-Su; Fri, 08 Dec 2023 17:09:11 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Dominik Brodowski , Greg Kroah-Hartman Cc: Pavel Machek , Kalle Valo , "Steven Rostedt (Google)" , Paolo Abeni , linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 1/7] pcmcia: bcm63xx: Convert to platform remove callback returning void Date: Fri, 8 Dec 2023 17:08:06 +0100 Message-ID: <33611a4245b4dabc609a75cf0e0db5e06e9a6fc8.1702051073.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1822; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=rK09bKbPy9IbxRyCb0eChVFpuUmGGmru+y/jU63xJqA=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlcz9qf3TyhbKQ0U4p75u1hl/4Mrffgxd57x3kV GXFT44SdOaJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZXM/agAKCRCPgPtYfRL+ TijcB/wOCUrzq/j4P2FtkyFicRvWJMrTqnRvDntTRY+jRqWW8O9B9u/G9kdrd4QkYgIXnEGIk03 lhfIIUesDJOtV4xZUtbpdMcmm7mddVSP3iRV5YjnCNiQp7Y4rq3bkmH5frSgnVq5tEn9syzl12W p83Rx2OUCTw4RSxDrdqxSvkbDSR4anVM7uQN4xs0P8pwUtSbJnjOKtnUy88iF4Kq9LlDFy0UtfW wtj/psLY47/K9fM3MEHJfisa+aULQ0ILBTACcVFuGG8tdQUn/+xWP9HFmEy2MR3ycAd2AziQFlu Pt9Xa4e/kgBi2QTe4s6yfHO9anTFAySqvgQupJp6X4sR3muf X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 08 Dec 2023 08:09:41 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784730652376724901 X-GMAIL-MSGID: 1784730652376724901 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/pcmcia/bcm63xx_pcmcia.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/pcmcia/bcm63xx_pcmcia.c b/drivers/pcmcia/bcm63xx_pcmcia.c index dd3c26099048..a5414441834a 100644 --- a/drivers/pcmcia/bcm63xx_pcmcia.c +++ b/drivers/pcmcia/bcm63xx_pcmcia.c @@ -437,7 +437,7 @@ static int bcm63xx_drv_pcmcia_probe(struct platform_device *pdev) return ret; } -static int bcm63xx_drv_pcmcia_remove(struct platform_device *pdev) +static void bcm63xx_drv_pcmcia_remove(struct platform_device *pdev) { struct bcm63xx_pcmcia_socket *skt; struct resource *res; @@ -449,12 +449,11 @@ static int bcm63xx_drv_pcmcia_remove(struct platform_device *pdev) res = skt->reg_res; release_mem_region(res->start, resource_size(res)); kfree(skt); - return 0; } struct platform_driver bcm63xx_pcmcia_driver = { .probe = bcm63xx_drv_pcmcia_probe, - .remove = bcm63xx_drv_pcmcia_remove, + .remove_new = bcm63xx_drv_pcmcia_remove, .driver = { .name = "bcm63xx_pcmcia", .owner = THIS_MODULE, From patchwork Fri Dec 8 16:08:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 175884 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp5555403vqy; Fri, 8 Dec 2023 08:09:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IGDeSEZ8UR4EyVZbn/tBI/ABqa9Ur1QC7zhMqxVfizt0vujGD0Ms41zjxB/7fnEOCAAQplH X-Received: by 2002:a17:90b:b10:b0:286:f3d8:de3f with SMTP id bf16-20020a17090b0b1000b00286f3d8de3fmr280026pjb.84.1702051762373; Fri, 08 Dec 2023 08:09:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702051762; cv=none; d=google.com; s=arc-20160816; b=DoojonjQVZnGaBHJC8d1FXWm3AdwT/X3pJrrSsw1lnTS3l2blWoeiO2QRptx8Qxbyw aj1y7asBlipx/VGPRA7LEtDY1kbmeEciTWYBtrGz2GkG+mQltrRbbGNbi0dH0QilEV2T NX+vKZRfa37Ynk3OSS8qSaJ5OtbSiRnEJzkfklfOvLSJE2THv1ezBeB25Q6DVMIvC/9d bo1h1IMns2j5tmJ+CsLGA3Xx6q6dau9y0rXx6c9Rk+3X7sOd3R3oljyHmgB5BZyPpgrN H2fbc7Dk/9aLhukJSFMVVvS4I3Ycs0iXJpQYWHB1pPheoQ8jgdh+d7RXRv7VvKAUl3Oj AaSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=PqYgDDFD03a/9CFqZDSq0c02MUJUSRZn8OXXTaebIrc=; fh=vyx8h/R3/RgPDF3hs4DKbHATzneQA+WUA+Ft3xYcKZY=; b=eq0lPGhmT7oQPrj2eWGDe7JQoZX40yQFwes6vtqBInql8YwXHHVe7IA8AScIRXoor/ wEQOTLz/bqRkSP/ENMdvErSYizvzFJRtMWTI3NUH4lRKpDtimiwD0KIsuFXMNpjNcIEo 32BxUQrTUEhmxhhB/ZVv/DlOLEzoCc9Xu0LXA5fvONQhgrDgbSxeKlC3SjbRjsIINzTI G5ViF+LLRBgnU53+FwEWy8dBh8OtDaOdlZPKEaM5IQT/WpxcvC5F0WsbAmVd4igrk4n6 BPBYsl4RDR3C2LQLxZvr3P+U+Sc+59kYvZwn8KUEBIM96yzOd7+rI03NwtCTbFkLWwGk +Vig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id c10-20020a17090a8d0a00b00286971a69a4si3177292pjo.94.2023.12.08.08.09.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 08:09:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id AC0F580A8B5C; Fri, 8 Dec 2023 08:09:20 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233632AbjLHQJK (ORCPT + 99 others); Fri, 8 Dec 2023 11:09:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233525AbjLHQJI (ORCPT ); Fri, 8 Dec 2023 11:09:08 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEF88173F for ; Fri, 8 Dec 2023 08:09:14 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rBdPc-00007x-Rv; Fri, 08 Dec 2023 17:09:12 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBdPc-00ES0I-Cn; Fri, 08 Dec 2023 17:09:12 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rBdPc-00GUaG-3a; Fri, 08 Dec 2023 17:09:12 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Dominik Brodowski , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 2/7] pcmcia: db1xxx_ss: Convert to platform remove callback returning void Date: Fri, 8 Dec 2023 17:08:07 +0100 Message-ID: <3d4c108421f2b1175d3a75ee6854e7772f8a0f82.1702051073.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1949; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=hoOY5rB1wBTrm118MtH1tMoeiGlvJRV6JaXbOehuwJI=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlcz9s7low3YagEVqKvVCP8KpeDw29gpuTL57GW 8gR3BuoyWSJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZXM/bAAKCRCPgPtYfRL+ TquFB/9ngk35j3HsFMuqUz7AHsV1DL1owZ3//hwU4IDZar2fh9KXu8S6NdL69qrH3ONbRq6r2I9 D5fi/U+YlDS1j03udvaDYEBdXi36THcMqLUaSPJb16vyTF+cWGzugfXK9ybwHv49KGM1Wfg5yq7 FfzoKCDwZ7V54bl0racUEOYQhcXA5ltYrIOpVSdpDI/4mpAQQB7OwW73SDBrdCvl6ggyz7PgYsL DRnCw7RCSWzVRAnILInxCiBXFLgssOittjh7ScwUpv9SNc4J5y1vvFVQleJ7fyUbdzWxErYRwD6 0aH3XGiDkjf8cCPTBfSis2uyJ6d4yxKcBEUvZxlcrbXJE2bS X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 08 Dec 2023 08:09:20 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784730628632901494 X-GMAIL-MSGID: 1784730628632901494 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/pcmcia/db1xxx_ss.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pcmcia/db1xxx_ss.c b/drivers/pcmcia/db1xxx_ss.c index 87a33ecc2cf1..509713b9a502 100644 --- a/drivers/pcmcia/db1xxx_ss.c +++ b/drivers/pcmcia/db1xxx_ss.c @@ -577,7 +577,7 @@ static int db1x_pcmcia_socket_probe(struct platform_device *pdev) return ret; } -static int db1x_pcmcia_socket_remove(struct platform_device *pdev) +static void db1x_pcmcia_socket_remove(struct platform_device *pdev) { struct db1x_pcmcia_sock *sock = platform_get_drvdata(pdev); @@ -585,8 +585,6 @@ static int db1x_pcmcia_socket_remove(struct platform_device *pdev) pcmcia_unregister_socket(&sock->socket); iounmap((void *)(sock->virt_io + (u32)mips_io_port_base)); kfree(sock); - - return 0; } static struct platform_driver db1x_pcmcia_socket_driver = { @@ -594,7 +592,7 @@ static struct platform_driver db1x_pcmcia_socket_driver = { .name = "db1xxx_pcmcia", }, .probe = db1x_pcmcia_socket_probe, - .remove = db1x_pcmcia_socket_remove, + .remove_new = db1x_pcmcia_socket_remove, }; module_platform_driver(db1x_pcmcia_socket_driver); From patchwork Fri Dec 8 16:08:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 175891 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp5555964vqy; Fri, 8 Dec 2023 08:10:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IEnRbeQC35YtdOqw7Wwj6d6XryI/JtyFzJA0quJmLyRFZ/zr9nQKsmRTpkNB3kQpKUHVuyu X-Received: by 2002:a17:902:f549:b0:1d0:6ffd:6e70 with SMTP id h9-20020a170902f54900b001d06ffd6e70mr219841plf.104.1702051803503; Fri, 08 Dec 2023 08:10:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702051803; cv=none; d=google.com; s=arc-20160816; b=H+pvJtgRGd01ZrY0q2/fpJlYr0Hhc3BiPm1AhIPk07m8SQxDAx+u8K3EFXPnt/9ThA K6lAO4Eqq1jt01r6RllNdBfp9TNh+d2zRhV9OylULljKn6CC0q8E5YlN7AXNch9JiFpL FAbPFkhyfTBe7kbsKX4pzU381GWQaCS0N6P+xABF5XqJUv9E7pewY3F9FxwggqVTUFdy wRqkYNAMy1lCfttyn/lX3n0nBzfxyfXv6gB5ixMhYw5ITWKWTtNFeumm8yPx8o11FOnY F9DBE8B6hmLr4Wb8aHwV3+ZZFYlN1rGYkcIEothKmVLY4q0oVThjXJ05fJXwCq3NzqSl mgrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=PjRDhG9yTf3z30XDWLOboMTEufnEHy528yN+ux6qEBA=; fh=cNwtFUZjTXH2UUcqOFMfvCD75rIs3idIFJ0h0H0CVvA=; b=PCry5C0i/Uk/gs4SgYa4fNbNLhTUH8IMpA0LbpGvSuvtmf6nEvwXmRxzZqRoQCNJF4 OxFNgicSlQc2IHU7rlabmcdiV0g1vjfbS5/hg2QLJSJsuXeBsi7zS0hq/HifZqow9Ztp MhxD50hfFUVR5PMNhYGlTH9t7Hwv6lJW3Vq61LYLQVb09ni7sKNCp8A9MQ7zRz1Z43hW j4p+zzBnPvJy1ve4WfUcwdCaequ/eyeeCVjjcNQ9MrVcIdmFgddYKJKlovuO95n29UIa Gn4OOu8Ugr84QusJf+u4MH859vycXiS5m46rzQB7sstenWbq6n40wgoHUukvegTu05Uc 1L+Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id v8-20020a170902b7c800b001d0187da0a0si1765096plz.292.2023.12.08.08.10.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 08:10:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id DCB6E837E665; Fri, 8 Dec 2023 08:09:59 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573944AbjLHQJf (ORCPT + 99 others); Fri, 8 Dec 2023 11:09:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233802AbjLHQJQ (ORCPT ); Fri, 8 Dec 2023 11:09:16 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 543AD1996 for ; Fri, 8 Dec 2023 08:09:22 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rBdPe-00007y-EO; Fri, 08 Dec 2023 17:09:14 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBdPc-00ES0L-Ja; Fri, 08 Dec 2023 17:09:12 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rBdPc-00GUaK-AC; Fri, 08 Dec 2023 17:09:12 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Dominik Brodowski , Greg Kroah-Hartman Cc: Pavel Machek , Kalle Valo , Paolo Abeni , "Steven Rostedt (Google)" , linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 3/7] pcmcia: electra_cf: Convert to platform remove callback returning void Date: Fri, 8 Dec 2023 17:08:08 +0100 Message-ID: <7b07c8624ab53ec90554b7a665bef7662bd94295.1702051073.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1830; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=n+hlrlFsRjhTMFN/VhJfgAOKKI1JiL5o8AuQJaDTRE8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlcz9t4grYDDRNZRyGpl8l+mzx2yGASB8M17muz Vz022OdPTSJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZXM/bQAKCRCPgPtYfRL+ TpWNB/485Cj9cA18CE30IsaMcPnXRbCFsk534FXaxYYJXEMycoz4bZpvGAJ8jLOXWgDgnK70lsO +pkBkxwNVpvix2AxSiF1GJKuRYbtq3ddnTRfcBepESP3rormcBQnV2b1uxXh1cTgzlNprF13JfT tnqRFcuKsW7T5Y5yCk0hfyZ2G5f2Hw/myzn+GW33HwdfyvZhAlShhuiPiGb/VAxTMkL2qkobj67 mCJjMz9qfoQ1ai/FBtGTw0jkvOHNZnauPOGw83L0B0sjSgVSI3dvvrkOSizpLpMQ5C2rHABZwLh mKheugxZLvGkY1Z/cp+whv808yrozTDnjguLm2OgWGiqzRLr X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 08 Dec 2023 08:10:00 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784730672021335099 X-GMAIL-MSGID: 1784730672021335099 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/pcmcia/electra_cf.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pcmcia/electra_cf.c b/drivers/pcmcia/electra_cf.c index efc27bc15152..5ae826e54811 100644 --- a/drivers/pcmcia/electra_cf.c +++ b/drivers/pcmcia/electra_cf.c @@ -307,7 +307,7 @@ static int electra_cf_probe(struct platform_device *ofdev) } -static int electra_cf_remove(struct platform_device *ofdev) +static void electra_cf_remove(struct platform_device *ofdev) { struct device *device = &ofdev->dev; struct electra_cf_socket *cf; @@ -326,8 +326,6 @@ static int electra_cf_remove(struct platform_device *ofdev) release_region(cf->io_base, cf->io_size); kfree(cf); - - return 0; } static const struct of_device_id electra_cf_match[] = { @@ -344,7 +342,7 @@ static struct platform_driver electra_cf_driver = { .of_match_table = electra_cf_match, }, .probe = electra_cf_probe, - .remove = electra_cf_remove, + .remove_new = electra_cf_remove, }; module_platform_driver(electra_cf_driver); From patchwork Fri Dec 8 16:08:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 175887 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp5555576vqy; Fri, 8 Dec 2023 08:09:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IGD4vFmmh0pipjbJj4Z5Pdp2BhsUd5xq+WeH9LUhQrX5xodzCbmsDr/6PV4dc7KVliHpqDB X-Received: by 2002:a17:90a:cb94:b0:286:9cdc:c2e1 with SMTP id a20-20020a17090acb9400b002869cdcc2e1mr264219pju.13.1702051775725; Fri, 08 Dec 2023 08:09:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702051775; cv=none; d=google.com; s=arc-20160816; b=A5Z6F33WVTBvj57Ygrmwh0ZJKhdL3rEno0JnCBC0vCo3/4scHblp1Jc9PfWkGe8mFL zIEk9IFSxuLbZx8IpLx6+5aD7IV4gJWLfNBozD9gw2CazBu9dkaf1VAW3fzKy6rS5mIw batYPKCrOxJNb3cuvM1+N/XiLQq3XWT9Tmdg1cvFXT/YokSktabnt8FQGNZtsJSovmUq rl687Sgipu+M89APf6ATa0pY8A+4wjXGMOkOeT6QIZ7WuQaOrq+P/LaYtaDyd5Nu7Xe3 IkGDPI1NYO8iQuDT3+h3EQ+kjnVru1sQQAzzkQ6rCl5CdzXWbYulPLavQo9f1PmJmUxQ avbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=lPsIqd6GyW1gNAvnb+HyHwECw/HPLQVIp/t+BHjQi0Y=; fh=s0Gx9AMFtMTCDS4nZmC1Kt+CYwr1GWTLQST3h3KzV/o=; b=KdpUCsZ3hvIwOxvzBod49eGKhiQ5V34lF3dWkBZf0YBymebqUSwSKt3CdEyLBIgkd8 n909p1oqwVffPrD16QXXjn4novwsxcDfmKXdSqBejoH7r/KCzBiDntQmzOHVquw32l4D Jxjd5sLVkEaMbOhJcuWFZ1vplyu4niXDiPWhV2vcUUQdJ25XlyeaMnETxxzNIABJzMyV uPQYOXpb+nTkYvbboWuWIfC0wH6uHBktsaGBT+ImMH/gwZ3hdudqnm1OxbJgWPhSQTut YzhBjAu+Ruz+KozfB95WPxzGI8RaJS/QVFoQol14J2QVc6LrKO1f+1ODgQyOasLwsJah qj1A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id h15-20020a17090aa88f00b0028a2fd5ba9csi1299000pjq.107.2023.12.08.08.09.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 08:09:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id EE2F782E1095; Fri, 8 Dec 2023 08:09:30 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235907AbjLHQJV (ORCPT + 99 others); Fri, 8 Dec 2023 11:09:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233610AbjLHQJN (ORCPT ); Fri, 8 Dec 2023 11:09:13 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D61B9171C for ; Fri, 8 Dec 2023 08:09:19 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rBdPe-000088-EY; Fri, 08 Dec 2023 17:09:14 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBdPc-00ES0O-Qo; Fri, 08 Dec 2023 17:09:12 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rBdPc-00GUaO-H9; Fri, 08 Dec 2023 17:09:12 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Dominik Brodowski , Greg Kroah-Hartman Cc: Pavel Machek , "Steven Rostedt (Google)" , Paolo Abeni , Kalle Valo , linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 4/7] pcmcia: omap_cf: Convert to platform remove callback returning void Date: Fri, 8 Dec 2023 17:08:09 +0100 Message-ID: <9d96646b75b10f7562d4d18010e885b7fc55e0ab.1702051073.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1745; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=RbjHfi5RXtO4cc8x56c5B+Z/tmcBf4To9DyVqGrX0Mw=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlcz9uzcEXgFvxHOFei0v+/iJGpZmJ3AUq5eLjE /WeNYj57paJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZXM/bgAKCRCPgPtYfRL+ TuNiCACNqZGlNha/Xc541obujpShtx6aayui0pbg6Wz+3ZIzoDiAvtzMRVCvJOaLzjEh13m/bGs tClR79pkmqPpYeAmLQ82WGZbEbvjohsA+5bofFYGzUVFAAv5Iu2YGsz8k0KU9Rgs2EPPSJbBuuG rfFcXDs/n1dlm3DpHuCKOO+XlfxABBtBXD3VgxUXBpEg9LWy55JXRewJQtAP2TTG48q+H6uo7nP bu2Sxwmf1MLzIqLOJYkzv6+HFPR5EMBsaLwLZ9dX2LCKdFwDZT6X0dQJUgNR1hdPrH/i2dNQruQ QWYqvuLCEimGnBiIgTqLzjj+njANSuoYpjF1WfJXxEjxile2 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 08 Dec 2023 08:09:31 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784730642877849157 X-GMAIL-MSGID: 1784730642877849157 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/pcmcia/omap_cf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/pcmcia/omap_cf.c b/drivers/pcmcia/omap_cf.c index e613818dc0bc..80137c7afe0d 100644 --- a/drivers/pcmcia/omap_cf.c +++ b/drivers/pcmcia/omap_cf.c @@ -290,7 +290,7 @@ static int __init omap_cf_probe(struct platform_device *pdev) return status; } -static int __exit omap_cf_remove(struct platform_device *pdev) +static void __exit omap_cf_remove(struct platform_device *pdev) { struct omap_cf_socket *cf = platform_get_drvdata(pdev); @@ -300,14 +300,13 @@ static int __exit omap_cf_remove(struct platform_device *pdev) release_mem_region(cf->phys_cf, SZ_8K); free_irq(cf->irq, cf); kfree(cf); - return 0; } static struct platform_driver omap_cf_driver = { .driver = { .name = driver_name, }, - .remove = __exit_p(omap_cf_remove), + .remove_new = __exit_p(omap_cf_remove), }; static int __init omap_cf_init(void) From patchwork Fri Dec 8 16:08:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 175886 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp5555531vqy; Fri, 8 Dec 2023 08:09:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IHmzCxT0yyyIPzTviKBn4b7OhiuEa8kZtxSR2DWVRQeh4nblGCA3S0Pjj9CgYar/svEBix4 X-Received: by 2002:a17:90a:5787:b0:286:742e:47b8 with SMTP id g7-20020a17090a578700b00286742e47b8mr309363pji.3.1702051772122; Fri, 08 Dec 2023 08:09:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702051772; cv=none; d=google.com; s=arc-20160816; b=Nt0NGzB5D+DsGleYJf3KvUB8E6x5cq9yldcXQ/fTcDNlI7Pr6BdzXaA9zw6JbEn8R0 QAkp/XxrPmLUlc5XHW82himBIU19X2nLlnOux1RxTeVaro7FcKZGQv8mvsHmyF7k4kRL jxesZCZBKrpnzYySQ8FmhtFLCk07AMu1N7SNUZmjIyg3nLNQhZCYEJ9Ls/zmh8L+MZtQ Zs+yOgzfVAkKp4bmgcuQ/BGoUVavTlYcv2iuxOdeHhZt2vQR62GJf36jB4jKWEIdZo/L 9XYLBECLZQNeoRagl/f8culPVcvvinUceZx/QD/LmwAUb1/umiRDLUb9UsYHyllLCGN8 H6+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=yurDGX0DjdPih6MLCGHWQz13shJi0UKpAx5ts8YSl50=; fh=eFkhKPH8o6TfDQ+LVr0RN6ysuBCZ25gGxWY1BHAsAuk=; b=egFs53j9i8MOXDyrSARvvJ9sfhPGwmgOM46hdhBqj7Gn26NBJ0fj3/UbY3lrX2sJzK Exjdt0f3UbuQxzrrIQ09GF/nFYxS7anQUYnARSFBpBKnQGDN8V/qCGBUFUmxXeh6upBb Es9N7N3v0MRRNzCWMJmSeLLoFfL8elrk7uXhHc3MVoqSPVGFdLok9YIidoZlIZhNLJQu qqjxuloi5OgEUgKSI7ojhSUVkXoL+hpKRVuA6syo36/aA+NNIZsVjmf9OTit5jizMD+f EPAYxD4/1bdv0emr7lgeU85aU6gtJWWUXSi81L07KlMFFejsdmCc3frYo0esgnhanADE zLpA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id bj20-20020a17090b089400b002866c761c77si3150575pjb.176.2023.12.08.08.09.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 08:09:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 68CE8813550A; Fri, 8 Dec 2023 08:09:28 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233632AbjLHQJT (ORCPT + 99 others); Fri, 8 Dec 2023 11:09:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233534AbjLHQJN (ORCPT ); Fri, 8 Dec 2023 11:09:13 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86FC01989 for ; Fri, 8 Dec 2023 08:09:19 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rBdPd-000089-Hm; Fri, 08 Dec 2023 17:09:13 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBdPd-00ES0S-0V; Fri, 08 Dec 2023 17:09:13 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rBdPc-00GUaS-NR; Fri, 08 Dec 2023 17:09:12 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Dominik Brodowski , Greg Kroah-Hartman Cc: Daniel Mack , Haojian Zhuang , Robert Jarzmik , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 5/7] pcmcia: pxa2xx: Convert to platform remove callback returning void Date: Fri, 8 Dec 2023 17:08:10 +0100 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1870; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=hvn8AQUIqYIyVFAM+ew2t9GzPmRIrB2d2DyEy1ujsww=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlcz90RZC/CPits6AxPT2VDwenom4vwo7b3Ux8k UrtlvzSI3mJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZXM/dAAKCRCPgPtYfRL+ TkgxB/450LmDHFEQA6eZw+c0u/hHlMa4ZxsV6qeu5sZ0RIGGDgGGcneuz5ggq9a/A6ZpkmhZpcF wKnySPUZ9buT+h0XS0JLrrCAFjxJ/4aKbzB0E4Fr3SmWAZnojZ7chE5T/L3T/BbjmhubSW+HJ6t mb2cIVMPWCId+J0dBsKVo/uoEMztSyQ50zM/Hwl7YtsvUWvyItEAD+5ZNhxMEYfa5HfhOsEgsPA qsbOMmufsdyvb+2t60AZWVeaiMPyHQ8ZL/ndgTJ8WUN75zE+8DRo4JoS8S209V4GTKC3aVBIYP0 AiMynIskF3X1hPg7u6pgQ9o39vBrvV1xc5onmzK7dMHFRt6n X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 08 Dec 2023 08:09:28 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784730638822817608 X-GMAIL-MSGID: 1784730638822817608 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/pcmcia/pxa2xx_base.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pcmcia/pxa2xx_base.c b/drivers/pcmcia/pxa2xx_base.c index 5254028354f4..457fb81b497a 100644 --- a/drivers/pcmcia/pxa2xx_base.c +++ b/drivers/pcmcia/pxa2xx_base.c @@ -313,15 +313,13 @@ static int pxa2xx_drv_pcmcia_probe(struct platform_device *dev) return ret; } -static int pxa2xx_drv_pcmcia_remove(struct platform_device *dev) +static void pxa2xx_drv_pcmcia_remove(struct platform_device *dev) { struct skt_dev_info *sinfo = platform_get_drvdata(dev); int i; for (i = 0; i < sinfo->nskt; i++) soc_pcmcia_remove_one(&sinfo->skt[i]); - - return 0; } static int pxa2xx_drv_pcmcia_resume(struct device *dev) @@ -338,7 +336,7 @@ static const struct dev_pm_ops pxa2xx_drv_pcmcia_pm_ops = { static struct platform_driver pxa2xx_pcmcia_driver = { .probe = pxa2xx_drv_pcmcia_probe, - .remove = pxa2xx_drv_pcmcia_remove, + .remove_new = pxa2xx_drv_pcmcia_remove, .driver = { .name = "pxa2xx-pcmcia", .pm = &pxa2xx_drv_pcmcia_pm_ops, From patchwork Fri Dec 8 16:08:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 175888 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp5555672vqy; Fri, 8 Dec 2023 08:09:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IEAquo3AyDQDubkqt4OpkVMgsZnPXws4BtMPuksnnLWm4+7PmBzWAM0XUCj0XSU41ULksEH X-Received: by 2002:a17:903:1c6:b0:1d0:6ffd:6e5e with SMTP id e6-20020a17090301c600b001d06ffd6e5emr204696plh.86.1702051782982; Fri, 08 Dec 2023 08:09:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702051782; cv=none; d=google.com; s=arc-20160816; b=zDp8q25ZDqPzDsOsSh3PPkFhXt7FEj+FkdpI9s9Jtce9Kd+WLjG6P3is4oRSzMm6Hv 0V21JGWoYTBcA0Ca91+bbc9W0Z+quxluBsfW3mi+yVdzC07y7o1SPmdHxi48LbFTc2gJ GCAOq5fiAANpAGEm26k1x6EKivVQdOdPeSj4UWEqAfAbebaY/ZB1v8tjWV1ZgLJLXC16 HoDZ6L0/0vB/elhumNsu84YuIjW4HBFopHQe6ifh39jQ0ljXLHqQWBJEuCJM6gEq1aPB ZwKkS8zZQ+x8ll+AYLmh9s+Oz4FI6yT7QS26+5zJeN5z/r+Bg21taKt/DMbOxGsGwtzX 1HIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=NqLtdNNgWgYJato9AFHBclieOLfs8saAkp/YFuc22OQ=; fh=DFy/UAYLG6XeTU06F3TdyZPdaMuT7mZVrTmB6YqQprQ=; b=wtO4JV6hK66OTU8oJ9juY2n05TLquBK+MMe93ga7vQAaBuQjvQ+EVfCr/OkDlXeSiU 1S++x3+V2U53a0RBoVY77QBLzJqj+wGFN2/mKnqLXYrsap1DiLHlh9EHmCSUys4nnZnT uxB4Yk/jensZWbFuxWDvb0zmkLiFgImUxRT+uu5piN3vsSBTQBYnOUiiSBuoshBcgpnH LAVyGQ5xpQJ76izYjuPxbJAx28kYwbylY85Piuh+Grd8e8A+tuqAbVlSG/LI40ND9DBY Fb/3tCj1rQc97iT2o9gBWTuj6g8ktUnczaDpxw/Xl0HqUDbG925jrG6nmuatVR7lJZTx QYHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id n9-20020a170903110900b001cffca283fasi1816149plh.144.2023.12.08.08.09.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 08:09:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id A9308807C5C1; Fri, 8 Dec 2023 08:09:38 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235874AbjLHQJ3 (ORCPT + 99 others); Fri, 8 Dec 2023 11:09:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233712AbjLHQJO (ORCPT ); Fri, 8 Dec 2023 11:09:14 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 729D2198C for ; Fri, 8 Dec 2023 08:09:20 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rBdPe-00008A-Et; Fri, 08 Dec 2023 17:09:14 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBdPd-00ES0V-7c; Fri, 08 Dec 2023 17:09:13 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rBdPc-00GUaW-Ug; Fri, 08 Dec 2023 17:09:12 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Dominik Brodowski , Greg Kroah-Hartman Cc: Viresh Kumar , Lee Jones , Linus Walleij , Arnd Bergmann , linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 6/7] pcmcia: sa1100: Convert to platform remove callback returning void Date: Fri, 8 Dec 2023 17:08:11 +0100 Message-ID: <6473afe67fc5c320a8184d0871a8561f7685e265.1702051073.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1892; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=soQnZWwWX5NPDCGNgya11PcjXTdqO51zNv14LXCtkeM=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlcz96dq8FIqBF+9nhRULOPdYII0+SJ2lmN0qx4 vOsf7RMtN2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZXM/egAKCRCPgPtYfRL+ TsaZCACGrDJbeg57n+TS5zDu2iOt3i8CZPfzAc6KKsn7mM7PtesUBYd47RUUdVFme+9wLJBlq2h z/ybFAM6vFgwnMuArx9SE8DJH712b+aLSnOlmlmCABTBjK3JssgIwT0+0/7DYyntyCS7NOUl0t4 FTwFReArCVrjsTf0R8RewDs5ntQKD4Dy4GtjPecVCcrb9wdONxaJ2D+ui8ioy0Qh/Ixpcl2Ptus Vdgv9EXACyiFSaCmuqcjl3mwb2JgW2FsbWRcTru3TziMRAS/rM3VjTCdVv9L2Z4JdnzhCBRJKd5 PkHLWFxTBCprnaj/y6kcBAA4cyg2MeD/niAksyFzW9Ts9YqS X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 08 Dec 2023 08:09:38 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784730650508676990 X-GMAIL-MSGID: 1784730650508676990 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/pcmcia/sa1100_generic.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/pcmcia/sa1100_generic.c b/drivers/pcmcia/sa1100_generic.c index 89d4ba58c891..ccb219c38761 100644 --- a/drivers/pcmcia/sa1100_generic.c +++ b/drivers/pcmcia/sa1100_generic.c @@ -158,20 +158,18 @@ static int sa11x0_drv_pcmcia_probe(struct platform_device *pdev) return sa11xx_drv_pcmcia_add_one(skt); } -static int sa11x0_drv_pcmcia_remove(struct platform_device *dev) +static void sa11x0_drv_pcmcia_remove(struct platform_device *dev) { struct soc_pcmcia_socket *skt; if (dev->id == -1) { sa11x0_drv_pcmcia_legacy_remove(dev); - return 0; + return; } skt = platform_get_drvdata(dev); soc_pcmcia_remove_one(skt); - - return 0; } static struct platform_driver sa11x0_pcmcia_driver = { @@ -179,7 +177,7 @@ static struct platform_driver sa11x0_pcmcia_driver = { .name = "sa11x0-pcmcia", }, .probe = sa11x0_drv_pcmcia_probe, - .remove = sa11x0_drv_pcmcia_remove, + .remove_new = sa11x0_drv_pcmcia_remove, }; /* sa11x0_pcmcia_init() From patchwork Fri Dec 8 16:08:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 175885 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp5555458vqy; Fri, 8 Dec 2023 08:09:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IEClbVrmPunPw21ZsVoW37a0tn+3vM5bqDlAPW39odH27oMv9hgQEiGEfCILvEtx26jlHbQ X-Received: by 2002:a05:6a00:856:b0:6cd:f8cd:528e with SMTP id q22-20020a056a00085600b006cdf8cd528emr343500pfk.5.1702051766435; Fri, 08 Dec 2023 08:09:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702051766; cv=none; d=google.com; s=arc-20160816; b=E/RjiJX0TflUNN43pijLARqTEV/itOAMYTHe749+wIrU6YT6Jz04ZOAsk17399usox hYwJz9o2RWvFg81rSb4+WnXaZkR+4KLI7QJRv3MOfrJ7zS8y9h7CWpCvxD470tkY9xno bPXI+tzuyyqWaiWLkcz+DN4MZi2kxk3wa4iNYnqce0NqnmQtDVHmyTScwTxH8QJg2gjH 4Ny4bSrTqm4i7fHSYUAv1lW0Ax6ohB4YucpAlSxV5eFnDxY8UbipL/ojv8Px5LdJFy0X +gx9y85van+DwCXeDE9ad9RAKAMk84sUz/QBzJhPGv/fahzMN8Yp22ayew3JrqBVE7K8 xsbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=G4X8U/nj8Sp7IUk7o/bFguXGKEwzaIctyUMz3eVvU5w=; fh=vyx8h/R3/RgPDF3hs4DKbHATzneQA+WUA+Ft3xYcKZY=; b=057YYHVIc1Wg3/2zXc8S+iLeoow420HqWCRivz1srrRoK1fBFKEm0wES52ZG7JwEvy ySkYvrYepFSFQul2xbQdBXvxVOgSn6oiVVqh+zXmEyffkesNJL+qU0wgL/q8Bj/H5fcM vDVx+TkEHrDXFlZCC5YxVuC0KdGXH4y5qdB2IvykbltlTwmDyGivD41bw1Np/VpGSr5R b8O4dCfevtsuk7LiyEN8N3L9HI6biZAAd5J9xfPuIHltunw0ZdclyiW4LCt6G+W+DaeW +vKLZKjdgtMNJi+7laEeVYmBJS7l1QrlljNlsjigl4HkpYvVupmCtl/PsChWKVJuD6Gd avfQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id fh29-20020a056a00391d00b006cbf2bcf071si1749883pfb.204.2023.12.08.08.09.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 08:09:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 4699F8725CC7; Fri, 8 Dec 2023 08:09:23 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573829AbjLHQJM (ORCPT + 99 others); Fri, 8 Dec 2023 11:09:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233534AbjLHQJJ (ORCPT ); Fri, 8 Dec 2023 11:09:09 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96371198C for ; Fri, 8 Dec 2023 08:09:15 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rBdPd-00008J-Pz; Fri, 08 Dec 2023 17:09:13 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rBdPd-00ES0Y-DP; Fri, 08 Dec 2023 17:09:13 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rBdPd-00GUaa-4I; Fri, 08 Dec 2023 17:09:13 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Dominik Brodowski , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 7/7] pcmcia: xxs1500_ss: Convert to platform remove callback returning void Date: Fri, 8 Dec 2023 17:08:12 +0100 Message-ID: <09a89926787cb9f64caa73c510f04d9f04a5136f.1702051073.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1937; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=1a3XrsIBjUzDTZoYZo4bHiJM6guDdpuYJ7uENxq/LbU=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlcz97w6if+bX06ito1EaAC/uUsJes2JGyWHnGh dgvlVq86nCJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZXM/ewAKCRCPgPtYfRL+ Ts89B/oCRgIz6tkNDFCrphlrv06SguKi+HPpSGGGY7TgCExVUV2jfIhyf6ZdBHryu2siN/p4VPj ZhfzTTulkKtT2wo2fzHOMk8aGeD9c9FUnA9sBwKZYKPoR2bwm+vaAl4b/uGNlOkSSbhZi8kZAz9 bR3nQ8lOwrHWwk8Zf8jamhyJ8cOPKMKxIcF7ramO5mSYBCiToS438PLO9FIkTCyuZcimw7RM5Wq r/XCKtnQgtN6gMceOLF4GwnYLZkoUMr+o7zn2Zo1/wOdABOkIfft10kEecl3ghUdrJ6SXC6/tAK m1nK+HFlsB3WJ6Pe0gm8elfqNIzhFIOKC90kmr+mmkxIiPeX X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 08 Dec 2023 08:09:23 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784730633203286185 X-GMAIL-MSGID: 1784730633203286185 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/pcmcia/xxs1500_ss.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pcmcia/xxs1500_ss.c b/drivers/pcmcia/xxs1500_ss.c index b11c7abb1dc0..2a93fbbd128d 100644 --- a/drivers/pcmcia/xxs1500_ss.c +++ b/drivers/pcmcia/xxs1500_ss.c @@ -301,7 +301,7 @@ static int xxs1500_pcmcia_probe(struct platform_device *pdev) return ret; } -static int xxs1500_pcmcia_remove(struct platform_device *pdev) +static void xxs1500_pcmcia_remove(struct platform_device *pdev) { struct xxs1500_pcmcia_sock *sock = platform_get_drvdata(pdev); @@ -309,8 +309,6 @@ static int xxs1500_pcmcia_remove(struct platform_device *pdev) free_irq(gpio_to_irq(GPIO_CDA), sock); iounmap((void *)(sock->virt_io + (u32)mips_io_port_base)); kfree(sock); - - return 0; } static struct platform_driver xxs1500_pcmcia_socket_driver = { @@ -318,7 +316,7 @@ static struct platform_driver xxs1500_pcmcia_socket_driver = { .name = "xxs1500_pcmcia", }, .probe = xxs1500_pcmcia_probe, - .remove = xxs1500_pcmcia_remove, + .remove_new = xxs1500_pcmcia_remove, }; module_platform_driver(xxs1500_pcmcia_socket_driver);