From patchwork Fri Dec 8 02:44:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: yang.guang5@zte.com.cn X-Patchwork-Id: 175534 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp5206602vqy; Thu, 7 Dec 2023 18:49:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IEX/wK+jiUHjQSOeSFI21X/gWvx5hTcGtF6uGSOhsQTD0JwpYxPJy6XQABinhWUhCGzPXrf X-Received: by 2002:a17:903:2309:b0:1d0:c7f:8eed with SMTP id d9-20020a170903230900b001d00c7f8eedmr4273009plh.58.1702003774977; Thu, 07 Dec 2023 18:49:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702003774; cv=none; d=google.com; s=arc-20160816; b=YNvZZPlvJxkH5BK6dNDK82qUt9qw2hTpfg77ee0nJhRJD+/CCgED9KVOYr7utX22dK 9wKlhLaY9Mm0B/Soi5QXvWleM9naC9Mi8LqmO1X9TCx5+WhL5p8BWjnCXuw4YZOGRCNh vdET1esUrbWNEgTqonPB/BvW+kNQSc0oF20eZtF0aSQq2VTyuLutg+1VhMbMi/Rv8/Wc jTYcAH6SDYtAgiyyYQjJ+UumzEhFgSGrl90pprV7dUZ5grNaQvfY0oYksYo+5For/E1l cNc+AJitOjhSokrYz9jTLeK/EyPRFcY5MHPJH5ljROKg3vnXZFEW24LWFbXhwQVEJ5Bo ekGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:mime-version:message-id:date; bh=mvGhHHrkN+mSJpAGZcigVWJ8DBUFxqOerrHEu1MjZ6s=; fh=adcyJEYfJukhpUSRMKZLQ0mgi6Qr8xjE74AIn85Razg=; b=aE9YCQYXlyIpRMFMYK4rfluf47L5SCOT0E5VY3x+fuxBNVMaqfNZDyOGSgTISfnX8o BZiWJeTJnmYw0jwcqjQwvuPLZCIMrCsXH+tJx7Ux9rGu0Wth0Yu05h9B+WLM1Fy6UcL/ a6X5I/RBgmwuNz4kWn/ALHlyc9LuCShYhRqzE1bpvSCNxRjjvuheAGQY3BBjEzqJ1BrV 0X3On2WZrWC2nFN5Z00Bj60SZhADKgd4H2WuL9PSudoAcq+Do/SPIjW3E5gRG7QVhO3b mIKCnnhdlkDSbK7ifu5t9SmikwF2zU5B79TZUDXK89zDCWZPjAQu1Mo83KR7tvPnYs/l gQng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id y8-20020a17090322c800b001cfb316a183si796656plg.141.2023.12.07.18.49.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 18:49:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 9DD178172962; Thu, 7 Dec 2023 18:49:26 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573008AbjLHCpN (ORCPT + 99 others); Thu, 7 Dec 2023 21:45:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1573005AbjLHCpM (ORCPT ); Thu, 7 Dec 2023 21:45:12 -0500 Received: from mxct.zte.com.cn (mxct.zte.com.cn [58.251.27.85]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61A541708 for ; Thu, 7 Dec 2023 18:45:18 -0800 (PST) Received: from mxde.zte.com.cn (unknown [10.35.20.165]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxct.zte.com.cn (FangMail) with ESMTPS id 4Smb8p25Pwz5SgL for ; Fri, 8 Dec 2023 10:45:14 +0800 (CST) Received: from mxhk.zte.com.cn (unknown [192.168.250.138]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mxde.zte.com.cn (FangMail) with ESMTPS id 4Smb8g5DRTz64Yhq for ; Fri, 8 Dec 2023 10:45:07 +0800 (CST) Received: from mse-fl2.zte.com.cn (unknown [10.5.228.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4Smb8b4FnLz5B101; Fri, 8 Dec 2023 10:45:03 +0800 (CST) Received: from xaxapp02.zte.com.cn ([10.88.97.241]) by mse-fl2.zte.com.cn with SMTP id 3B82itc9067680; Fri, 8 Dec 2023 10:44:55 +0800 (+08) (envelope-from yang.guang5@zte.com.cn) Received: from mapi (xaxapp02[null]) by mapi (Zmail) with MAPI id mid31; Fri, 8 Dec 2023 10:44:56 +0800 (CST) Date: Fri, 8 Dec 2023 10:44:56 +0800 (CST) X-Zmail-TransId: 2afa657283282d5-bc543 X-Mailer: Zmail v1.0 Message-ID: <202312081044568085747@zte.com.cn> Mime-Version: 1.0 From: To: Cc: , , , , , , , , , , , , , , , , , , , , Subject: =?utf-8?q?=5BPATCH_linux-next=5D_drm/amd/display=3A_replace_kzalloc?= =?utf-8?q?_and_memcpy_with_kmemdup?= X-MAIL: mse-fl2.zte.com.cn 3B82itc9067680 X-Fangmail-Gw-Spam-Type: 0 X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 65728339.000/4Smb8p25Pwz5SgL X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 07 Dec 2023 18:49:26 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784680309834932416 X-GMAIL-MSGID: 1784680309834932416 From: Yang Guang Convert kzalloc/memcpy operations to memdup makes for cleaner code and avoids memcpy() failures Signed-off-by: Chen Haonan --- drivers/gpu/drm/amd/display/dc/core/dc.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c index 76b47f178127..867e1a0fdef6 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c @@ -2264,12 +2264,10 @@ struct dc_state *dc_copy_state(struct dc_state *src_ctx) #ifdef CONFIG_DRM_AMD_DC_FP if (new_ctx->bw_ctx.dml2) { - dml2 = kzalloc(sizeof(struct dml2_context), GFP_KERNEL); - if (!dml2) - return NULL; - - memcpy(dml2, src_ctx->bw_ctx.dml2, sizeof(struct dml2_context)); - new_ctx->bw_ctx.dml2 = dml2; + dml2 = kmemdup(src_ctx->bw_ctx.dml2, sizeof(struct dml2_context), GFP_KERNEL); + if (!dml2) + return NULL; + new_ctx->bw_ctx.dml2 = dml2; } #endif