From patchwork Wed Dec 6 14:43:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nam Cao X-Patchwork-Id: 174606 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp4151202vqy; Wed, 6 Dec 2023 06:44:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IFGFsP3fdXP306+zJhNzawQKLpcB53GcbgKLgJ0dcd//pLbSmnkJzMsXXTSPI7740st95AU X-Received: by 2002:a05:6358:431b:b0:170:21d7:cb5e with SMTP id r27-20020a056358431b00b0017021d7cb5emr1678729rwc.47.1701873845323; Wed, 06 Dec 2023 06:44:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701873845; cv=none; d=google.com; s=arc-20160816; b=Fqv26SlVsyc14tCzBSCT+aN0LjsMmPANhJPdCfYo7uSSpOVIzWlYhj0CXq8mU0/rIS s3NSmhNWo6ttHrEUbGwoeT1VfBM+f7rAdGoZix3govXXXvnwK8DlCU5qxKISSnPAvAqX FxTlsYSYFFctDSYiuxYcP7mPHgcaoZtbolbYFNu9/Z920CJjfRsDLlqWZqfa5nzUkQ68 KJpRIJgrLXziyyLho26bdi52seEIbLi4/TER0IlbkpMLEe5J0rgJsIKZwRScPJdB6q9I 2Bmiqe5pWAwi8S5UmmXJMkljdyH3zlKjoxuTU5FBwEER32IXYxVPT0/h1VnZ9cg4ryZh 07Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:dkim-signature:dkim-signature:from; bh=mAF870uQ0onfTlbiDl5VP75x4lowIYu0iaaaG3AvEnM=; fh=1IKp81/Uvl9vUeFxTVLSiabzC4OE9m73g8+CMu1UOiY=; b=mJjhDNGXmIj5A1Fcy5na0YgiKixFq2idFoe7Omp9BL8BYNJYUtXurmUBX5Dqmr5MCn zqx4r6X4Na6nW1luclTVJ+dl2JGsVVELOuVnVc1Ib5wtW4La0i9nLZG42zY7BW37rxUS vENEJhLxIW7RmELeTXN8cL+ES7rhCBuhRTtdGjf83kwPssONLIvozazUTZGqf390a43k sdqxGusNP9ZM5BsxyeLSALUv5z1DU2d8DJdP1oI9+PsPeLMx5aMEyyvmPq4o6fidTA8Z PqF4Adm2Ue93WUxYqNqcWttCQ1yYKz5n+c1gNwLihvHRSQqZIdg2gTtd39r4Gl1Hecxr XZMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=vuavcnaq; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id s23-20020a63e817000000b005c1ce5625c9si11801674pgh.816.2023.12.06.06.44.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Dec 2023 06:44:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=vuavcnaq; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 154AE80294C3; Wed, 6 Dec 2023 06:44:04 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378970AbjLFOnw (ORCPT + 99 others); Wed, 6 Dec 2023 09:43:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378943AbjLFOnw (ORCPT ); Wed, 6 Dec 2023 09:43:52 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8274A1BD; Wed, 6 Dec 2023 06:43:58 -0800 (PST) From: Nam Cao DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1701873837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=mAF870uQ0onfTlbiDl5VP75x4lowIYu0iaaaG3AvEnM=; b=vuavcnaqGzr2N+M1K1Kdm4ls72k288AsQrkpqzvT0Mck1T8T9L2pLSlJNaVULg25ZWBUm6 GX04rhJxiakvop13d9Ay8yxoF3bysocFzYnbh985VYacL46psHy5p9LSKXJNqhGX5ze5Qj gAwx9LMM7FuY09Dt/mneorhtU/iKr282GTkSn5IvYoMh4LNVv9Hyg09ffvKQIU83sBlFD5 ETxuQ1pgj7RqdjNZXI9shQNiE/40tRHHlesdKsb0Mdh2/18R4CI2kRKFVkn3M9mOQVYtG+ g3MkR7HiGR4j9pXw2Fyhgcpvki/S1YQasOATxhgPiQ7Ox5gg9sdZt1adO0nvAg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1701873837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=mAF870uQ0onfTlbiDl5VP75x4lowIYu0iaaaG3AvEnM=; b=2GwYdPx0vHeTwED8sPssZImual1eE0YffQ1kmhcu6FbpNhwC5lIG8ULgXBmGYZPsa5CitT FXZ/9sT56G4DqQAQ== To: broonie@kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, daniel@zonque.org Cc: Nam Cao Subject: [PATCH v2] spi: cadence: revert "Add SPI transfer delays" Date: Wed, 6 Dec 2023 15:43:51 +0100 Message-Id: <20231206144351.74492-1-namcao@linutronix.de> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 06 Dec 2023 06:44:04 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784544069199834459 X-GMAIL-MSGID: 1784544069199834459 The commit 855a40cd8ccc ("spi: cadence: Add SPI transfer delays") adds a delay after each transfer into the driver's transfer_one(). However, the delay is already done in SPI core. So this commit unnecessarily doubles the delay amount. Revert this commit. Signed-off-by: Nam Cao --- drivers/spi/spi-cadence.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cadence.c index 12c940ba074a..bd96d8b546cd 100644 --- a/drivers/spi/spi-cadence.c +++ b/drivers/spi/spi-cadence.c @@ -451,7 +451,6 @@ static int cdns_transfer_one(struct spi_controller *ctlr, udelay(10); cdns_spi_process_fifo(xspi, xspi->tx_fifo_depth, 0); - spi_transfer_delay_exec(transfer); cdns_spi_write(xspi, CDNS_SPI_IER, CDNS_SPI_IXR_DEFAULT); return transfer->len;