From patchwork Tue Dec 5 23:05:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 174229 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3758117vqy; Tue, 5 Dec 2023 15:05:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IGXvbiduMj0B4U0hKYnwkeFQ2SAmB1ckMPEB9Q1FL7OjVT0Doo1xTWzOGe8e7hQz/wRoTox X-Received: by 2002:a62:8484:0:b0:6ce:2731:e862 with SMTP id k126-20020a628484000000b006ce2731e862mr2041211pfd.41.1701817531111; Tue, 05 Dec 2023 15:05:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701817531; cv=none; d=google.com; s=arc-20160816; b=IuJuQV1X9IHTM5qtOTBOiyrMMIdzO9zTGJX8ExqkYhsl8NPjD3sYZxjzPo/ZuB1EGQ 0/yXAuy0VLe0C5yR5VX2ogb+SfQsFkg/nLAk4eCKitTg1X5a8kchhydlGbNf5++m76x+ UK3v/kblADeG7TS5mUyJ2WEKyQeb46ffhqt6oTwAg6YWAN9uJUDQdWMU7RfVa1kvmua6 7TcVeMQVkVAEOm0E0ZVcH60KIMKz/vw13tHlNKSX+V1HwHQDlsehikJAQgmxHbe0pnjw ICk81A3MCpJFY5kHocfePSgWTlfzonQvt7w1+7ro8fgi+jHiVl+nUVO3uSt6Dp0CDjUh aOuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=g9g0AqQltjx9HVi2PVmhYskrOtwbSdqnOJIb+sPsbDU=; fh=gwkyaTlwLFJXu80f0q09XxdfhZjI34vUYWoI+enPr7w=; b=mKNJJpYvG6bQbPSPUxWbEh8437x5V7f/xvvvszakASqS2T4AYLSupemgz5ZAZQvA48 87iaRPsbiyB2cMEMav6qyGuR1h7OJWBacmw8h7gog6PrbkyFI+FX9SUBJfToWQbstJnv 1mO/pdz6IHK1KaHXfRMa3rhjkeAsi4KtTisniYRpySytfQ7sCBC812VCt+UL4BkFlD6N 0Jsc/F6jK6w0LejjWRPwhwwYwo0CqtODhnSvFnpdgk/c7IZBfaOo3pWKYuOqNH8umDkt e2m6cYnYV24kQT4lfBBj6pFda4EgqGYe8L2UQLTamlL/4kxMKjy+wjiAabzzAiRmZzom xQyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JZGvNj4v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id k20-20020a63d114000000b005c1c5d338a9si10376241pgg.658.2023.12.05.15.05.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 15:05:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JZGvNj4v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id A9BA182A41EC; Tue, 5 Dec 2023 15:05:19 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346559AbjLEXFL (ORCPT + 99 others); Tue, 5 Dec 2023 18:05:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346555AbjLEXFK (ORCPT ); Tue, 5 Dec 2023 18:05:10 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACDF6B9 for ; Tue, 5 Dec 2023 15:05:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701817515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g9g0AqQltjx9HVi2PVmhYskrOtwbSdqnOJIb+sPsbDU=; b=JZGvNj4vzVesqoLOtCOLP4euBwjPjpmPpx2nsBgYsBdbHMTkKiS7KgcM3k35ulyFikzjQ6 qND1L7lzHBB4PW+gkVVJLgkQbrDCbMIUpxPdPOsD+sNLEKNPKFs0R3dK9lYFxrEgUV7tM6 cAPUVAhz2qwd71pAnDa0t9VUV9DuJPM= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-8g54K8ZlNYGoh-sbE_VNJA-1; Tue, 05 Dec 2023 18:05:13 -0500 X-MC-Unique: 8g54K8ZlNYGoh-sbE_VNJA-1 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-423f4f5f586so2436171cf.0 for ; Tue, 05 Dec 2023 15:05:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701817513; x=1702422313; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g9g0AqQltjx9HVi2PVmhYskrOtwbSdqnOJIb+sPsbDU=; b=BqM2smaNtWmsNEtdQ2b2yHkH/5ugVBoSOOm39CFX+Hh10WCfyF8ejamcAOtzQPSX67 SfxJHC5/8QddGCuk1uHsfQojqET0LMgKOxu75x+pFRS82rQm9mvk/GOwrDZ2441onQt8 JGsEemoGpL0yoB8rbXYpO3uJDJykC+6aljD8xV5ngWXLOAihYypLMcq7cX5B9xnubDa0 6CzWg3idp8kzVUmOEAOKxHiuG7lrWZIRvcCbuZmXlGv37V2dOeWNqM7S/eFjmjMc9oEe 2o8BBlbykHOa2bVVH+fFUjscYjGSO1tLNEdtbU/LiNk25rRqqRtW/6BGFGj6+61v3gHE SzEQ== X-Gm-Message-State: AOJu0YxQIU97S/kfC7O2ATna2ZPyTTQWoKFavxjVRg3iM9WuI8WMeNCE if92kqOsWrndqFTCvMvwLApaRG8RcCdVOzR0lU+drAJoCLJd+xjBYO0gohuLlYxNIJsqJWSBBXk czCU0MzDClCCu6JLn9HB2aF07 X-Received: by 2002:ac8:7d8c:0:b0:425:4043:5f1b with SMTP id c12-20020ac87d8c000000b0042540435f1bmr2507693qtd.89.1701817513292; Tue, 05 Dec 2023 15:05:13 -0800 (PST) X-Received: by 2002:ac8:7d8c:0:b0:425:4043:5f1b with SMTP id c12-20020ac87d8c000000b0042540435f1bmr2507679qtd.89.1701817513069; Tue, 05 Dec 2023 15:05:13 -0800 (PST) Received: from [192.168.1.164] ([2600:1700:1ff0:d0e0::47]) by smtp.gmail.com with ESMTPSA id df15-20020a05622a0ecf00b00423da75b0f4sm5504430qtb.71.2023.12.05.15.05.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 15:05:11 -0800 (PST) From: Andrew Halaney Date: Tue, 05 Dec 2023 17:05:09 -0600 Subject: [PATCH 1/3] soc: qcom: pmic_pdcharger_ulog: Search current directory for headers MIME-Version: 1.0 Message-Id: <20231205-pmicpdcharger-ulog-fixups-v1-1-71c95162cb84@redhat.com> References: <20231205-pmicpdcharger-ulog-fixups-v1-0-71c95162cb84@redhat.com> In-Reply-To: <20231205-pmicpdcharger-ulog-fixups-v1-0-71c95162cb84@redhat.com> To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Halaney X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 05 Dec 2023 15:05:20 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784485019395728498 X-GMAIL-MSGID: 1784485019395728498 As specified in samples/trace_events/Makefile: If you include a trace header outside of include/trace/events then the file that does the #define CREATE_TRACE_POINTS must have that tracer file in its main search path. This is because define_trace.h will include it, and must be able to find it from the include/trace directory. Without this the following compilation error is seen: CC drivers/soc/qcom/pmic_pdcharger_ulog.o In file included from drivers/soc/qcom/pmic_pdcharger_ulog.h:36, from drivers/soc/qcom/pmic_pdcharger_ulog.c:15: ./include/trace/define_trace.h:95:42: fatal error: ./pmic_pdcharger_ulog.h: No such file or directory 95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE) | ^ compilation terminated. Fixes: 086fdb48bc65 ("soc: qcom: add ADSP PDCharger ULOG driver") Signed-off-by: Andrew Halaney Reviewed-by: Neil Armstrong --- drivers/soc/qcom/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile index 110108e23669..05b3d54e8dc9 100644 --- a/drivers/soc/qcom/Makefile +++ b/drivers/soc/qcom/Makefile @@ -10,6 +10,7 @@ obj-$(CONFIG_QCOM_PDR_HELPERS) += pdr_interface.o obj-$(CONFIG_QCOM_PMIC_GLINK) += pmic_glink.o obj-$(CONFIG_QCOM_PMIC_GLINK) += pmic_glink_altmode.o obj-$(CONFIG_QCOM_PMIC_PDCHARGER_ULOG) += pmic_pdcharger_ulog.o +CFLAGS_pmic_pdcharger_ulog.o := -I$(src) obj-$(CONFIG_QCOM_QMI_HELPERS) += qmi_helpers.o qmi_helpers-y += qmi_encdec.o qmi_interface.o obj-$(CONFIG_QCOM_RAMP_CTRL) += ramp_controller.o From patchwork Tue Dec 5 23:05:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 174230 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3758270vqy; Tue, 5 Dec 2023 15:05:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IEe4tD28AYRjbbB5Sm641GeV6NPRBlY05tdcun193sWSU6y0Q2Dyi7CfBil6P2hQE/B17f5 X-Received: by 2002:a05:6a20:5491:b0:18f:97c:6144 with SMTP id i17-20020a056a20549100b0018f097c6144mr8897791pzk.65.1701817545961; Tue, 05 Dec 2023 15:05:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701817545; cv=none; d=google.com; s=arc-20160816; b=gAAATheSkPN/P22EURtPmqp8SeskgQzQ1y39UttfaccdhJKkXoCv9SNxoA5YSi1vy0 BsXdUvVzOorOz0U4tbbEc4c6rVzgvZ+NyNam3wYltAdpzleJpQQWUoDVSiXxbiTRCFQx NxwzRmJukLC2+MAi1FAJiGFGhLu+mhd7s+Dyg/qSypWkDsczxZJpCtzeCk2CYOQqmO4J NBeHXv9Z2mosKGKUHztfoI6LqCqGLDyLgZaDAm6ilAWS+8rI2h1gOeUsFZ1z/DDI1F0t qFfemFM4BpP1j1ZHHMD+iFitpW6GWdw/FtoO/RimI9lwDJfcTiWoR7tAQZWZBRPRwqyj 73Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=zI2EQGzuy4/i38sKyTTPT4IeppHHa6FP6X9uU+Zh4lQ=; fh=gwkyaTlwLFJXu80f0q09XxdfhZjI34vUYWoI+enPr7w=; b=pukfK/3WZEuYSlw0AXGJo0w1ZCqWyxzzWeW1A6Rs3PkWpowUEP9VEcSYHbLYgJ+Qzy V83vT1lS5HbNQQFQh3Ark3H/axnouke8ByRmeu0sb/wByucZN9R1DmnWsbpo/HHwaWkr c1+xbKt3Yn94lYLjl+dskMIWWy+8dtFL62Ahu539fWhG96PQH1jft4rFeXaY2E9TjYDc k6sH4R84Nn3+rzdWDqTbMqU74PTRpk0yMx1JbCAHuAorja8hcOjHEZWFHHfSS+vYkAIs KJ+Z42flBywKlEwMcQJnPNVQ1LEPaKF9PPGKKe7Q+uHAOLtp64odQ01mzoXHe0l2wDvO f92A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Ps4GGRf2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id e187-20020a6369c4000000b005c5e276b55esi9964117pgc.441.2023.12.05.15.05.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 15:05:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Ps4GGRf2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id F3147803028B; Tue, 5 Dec 2023 15:05:29 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346607AbjLEXFS (ORCPT + 99 others); Tue, 5 Dec 2023 18:05:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346549AbjLEXFK (ORCPT ); Tue, 5 Dec 2023 18:05:10 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E571CD45 for ; Tue, 5 Dec 2023 15:05:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701817516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zI2EQGzuy4/i38sKyTTPT4IeppHHa6FP6X9uU+Zh4lQ=; b=Ps4GGRf29+R3oZuPRQTLey+AyxWsZtp5zv5YDkzSDTOoQN0qdwtJGe8qE/XqBglqt9DTYh fuOhJD4jMvQiHiZBNOdMfl/hCoJkgHc4yFJxsvMgaqCQTYSlqTFgtXX2uY18ZAkbpSPsYk aUUR2M7Ff98+7TVFP6LKT/DDx39SwHw= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-375-bJ7NQHHbPPmBFmcmcypx2A-1; Tue, 05 Dec 2023 18:05:14 -0500 X-MC-Unique: bJ7NQHHbPPmBFmcmcypx2A-1 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-423f2e9ed5dso2229331cf.0 for ; Tue, 05 Dec 2023 15:05:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701817514; x=1702422314; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zI2EQGzuy4/i38sKyTTPT4IeppHHa6FP6X9uU+Zh4lQ=; b=YLvPnj3xDCyeQqu4xmNcxtSorusKJLYNcx5EfDoeujVIwtNtyXqjksOg/HpUzxbscL sS1TuAzxjFGFwMU8tdKdMpalUr8p0HvzEFAY81BRgxPagCBd84YhL8SoAbF+vl6ZRjes 2XUtOTytTJcDq1Q5V1Cz7fLYWHdHij5aGIeERg5kuLxKnRpfaqH+X/s1mtvbIIkVTvaH dlU1Z2SJLMWgVYPz1ZHLNJPfATRsPwAXgejg3gSrSgFxw4qa5gNSUjGywEqrbKVowH/q CNFb37P6Tjweutut+1WlegMrlu5+o1z1vPHmNn+iCy/FI2J5nwWHMtz0jbMIQ9pzCdKP tnfQ== X-Gm-Message-State: AOJu0YxGFfC+uxzHS0d46QfMtlkh5bOFDHeWfcaFPvcMJdCJX/y4L00P lx0L4sthKWc1KKuKljWnVR1FHtjt/nycHZdA38UYeTok6K/Nz1Ud28CUuTnpeSGqBu6NFeM1ejZ mSjxuhYx232PMsy0esz+9wmtn X-Received: by 2002:a05:622a:86:b0:425:4043:29f0 with SMTP id o6-20020a05622a008600b00425404329f0mr2448048qtw.107.1701817514109; Tue, 05 Dec 2023 15:05:14 -0800 (PST) X-Received: by 2002:a05:622a:86:b0:425:4043:29f0 with SMTP id o6-20020a05622a008600b00425404329f0mr2448032qtw.107.1701817513875; Tue, 05 Dec 2023 15:05:13 -0800 (PST) Received: from [192.168.1.164] ([2600:1700:1ff0:d0e0::47]) by smtp.gmail.com with ESMTPSA id df15-20020a05622a0ecf00b00423da75b0f4sm5504430qtb.71.2023.12.05.15.05.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 15:05:13 -0800 (PST) From: Andrew Halaney Date: Tue, 05 Dec 2023 17:05:10 -0600 Subject: [PATCH 2/3] soc: qcom: pmic_pdcharger_ulog: Move TRACE_SYSTEM out of #if protection MIME-Version: 1.0 Message-Id: <20231205-pmicpdcharger-ulog-fixups-v1-2-71c95162cb84@redhat.com> References: <20231205-pmicpdcharger-ulog-fixups-v1-0-71c95162cb84@redhat.com> In-Reply-To: <20231205-pmicpdcharger-ulog-fixups-v1-0-71c95162cb84@redhat.com> To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Halaney X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 05 Dec 2023 15:05:30 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784485034922653314 X-GMAIL-MSGID: 1784485034922653314 As specified in samples/trace_events/trace-events-sample.h: * Notice that TRACE_SYSTEM should be defined outside of #if * protection, just like TRACE_INCLUDE_FILE. Fixes: 086fdb48bc65 ("soc: qcom: add ADSP PDCharger ULOG driver") Signed-off-by: Andrew Halaney Reviewed-by: Neil Armstrong --- drivers/soc/qcom/pmic_pdcharger_ulog.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/soc/qcom/pmic_pdcharger_ulog.h b/drivers/soc/qcom/pmic_pdcharger_ulog.h index 9d5d9af4fbe4..152e3a6b5480 100644 --- a/drivers/soc/qcom/pmic_pdcharger_ulog.h +++ b/drivers/soc/qcom/pmic_pdcharger_ulog.h @@ -3,14 +3,14 @@ * Copyright (c) 2023, Linaro Ltd */ +#undef TRACE_SYSTEM +#define TRACE_SYSTEM pmic_pdcharger_ulog + #if !defined(_TRACE_PMIC_PDCHARGER_ULOG_H) || defined(TRACE_HEADER_MULTI_READ) #define _TRACE_PMIC_PDCHARGER_ULOG_H #include -#undef TRACE_SYSTEM -#define TRACE_SYSTEM pmic_pdcharger_ulog - TRACE_EVENT(pmic_pdcharger_ulog_msg, TP_PROTO(char *msg), TP_ARGS(msg), From patchwork Tue Dec 5 23:05:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 174231 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3758326vqy; Tue, 5 Dec 2023 15:05:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IGBsr265Pq6Gs07lpEVn+r++duTiOAJBpmtoiHKrd6FovsH8iueXFQxq5pnpwYzepexA61K X-Received: by 2002:a17:902:a603:b0:1d0:6ffd:e2eb with SMTP id u3-20020a170902a60300b001d06ffde2ebmr5720894plq.133.1701817551326; Tue, 05 Dec 2023 15:05:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701817551; cv=none; d=google.com; s=arc-20160816; b=bi5WUUFYoW9lJaTo2d+yQd3N2QFqiY1uXJ8J5hqIy8Pt3I7UZbksAHoEEGLghkkZwV hXB9q6Cr/kEhsrHsER9MpN0KKLkG+GXG6QRwA0zHgjxppsDzLAl0Sy0IfGMZNIqGbhQo hEHE4V3/vqSzvPUXRYKa0N148+mZD5QA1KL7tH4ws3mHujM39JS3z9kIbxlLTPlEzOL1 HGGeCuIVC8a/Fk4cI595CDHx2KdhyWd9hoc73f+HAYf5KXgD/tko69jANiANYcr80G3Q 4rNgb/2BkmZ/f/qntkmsFAwxGCnVVxgoHZZM1tRz/PJh/eGIO/3fa7Ke7zXvqTnh8LuN /PAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=KP09DeLuYz+Og6dlZ9z2Kp7En1LOdjS8AGaZ+gDsxfo=; fh=BFLtzM8Zr5WPSqMt7DJ9R3GS7YDOZ1t8lNTDmTBnfCg=; b=N/aDVD0IOoAkpeesAcdPzz2pDj/01ddofDddJE5i1XCmsnFssrNL55CPWG85u+O81O 0xHl03F2P7BatKzlkBsNXqMTZ2ZhAzpYTxiCVHZgiAp+gj+SiJ0i8DjTE+GmAcZUITZa 02ApmbNZ7i7J/ZRzLsdFN8/S6e1nyhdsQ5szs57xWF5tWcnTPrhZD5d3/p7LaQnLYSwh 8j31eZ4Rsm+SUTTb9m5KFJ+H0dA8l08fMgIM5XT4nSkY0ptzmHCDKPhVPf/rHXdDxUpy FRoPeBA/pEdCF5fBPw2WhbX5PDlXuK4VPcvvVqb1o7LlCCAPGbBfnacuoQ9mIg0LFg0A SV2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BHzUkluf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id x18-20020a170902ec9200b001cfee4c128asi1609637plg.356.2023.12.05.15.05.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 15:05:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BHzUkluf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 5E49882072DA; Tue, 5 Dec 2023 15:05:32 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346572AbjLEXFW (ORCPT + 99 others); Tue, 5 Dec 2023 18:05:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346555AbjLEXFN (ORCPT ); Tue, 5 Dec 2023 18:05:13 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 880601AA for ; Tue, 5 Dec 2023 15:05:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701817518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KP09DeLuYz+Og6dlZ9z2Kp7En1LOdjS8AGaZ+gDsxfo=; b=BHzUklufT9IgonPTwvPnuIUSY+DCd2KsQS7XnPWIE6/Kxyg96mCfkLmKsyoosqViwnSom9 FB0uLzWi+qAYXpOgm3C6opXngfdOma0YF9G2AivhFMLNbzFr6X+fcJlfuZoKz16J3IOASA RbUn1u4rn2cmTVx8KfMgw1ri+91m9Jk= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-phLg7Ax2Ok-MdV-1fPvv9w-1; Tue, 05 Dec 2023 18:05:17 -0500 X-MC-Unique: phLg7Ax2Ok-MdV-1fPvv9w-1 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-423f436ed56so2318381cf.1 for ; Tue, 05 Dec 2023 15:05:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701817516; x=1702422316; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KP09DeLuYz+Og6dlZ9z2Kp7En1LOdjS8AGaZ+gDsxfo=; b=b2JOkeR/aGrTiKt/eDxSWxR+XN+PA3H6xlv458gMXAgbrf8aVc5R8dgNVfbiM/bYnw iYFIxZODoqYchiD+fV+y8O3swexOdkRZZqw1BKwnC/Qm+/78aVWXiNdGK2uRrbz+jE9C Lsx128rx+QOFV7uVe0OzznKX+jGGEgyMSoqCWZoZwCdszOzV/8I5sYT9gDd4X54NbtrD T+JvdHp4bvWpL8/9LeH4QBLIzDzySyDTY3qefFYDGupzCi9JmmHhsMr39InNG9hNLgd/ +sYmGeFu1a/RDz20m1HDlecHLE2Xtv7hkwoq4PxTJFP2blnEgSgZE71st5OCV2WhFZ2U lROg== X-Gm-Message-State: AOJu0Yze3/1z9dMwP9nMJ3r1ZyTcMAopxicKDJegPD89Qu4d1PVhsBJz 2HhSU5UopX1FlgBkQk868A2VqQe/089QGZVJQeDJxS5Rt4Z7DrFR28gl36HsGnmk2dhw6RgUlwY CobF1qdS2Aw7DfJiNOsOQbU/J X-Received: by 2002:a05:622a:152:b0:425:4043:5f33 with SMTP id v18-20020a05622a015200b0042540435f33mr2451718qtw.113.1701817516311; Tue, 05 Dec 2023 15:05:16 -0800 (PST) X-Received: by 2002:a05:622a:152:b0:425:4043:5f33 with SMTP id v18-20020a05622a015200b0042540435f33mr2451705qtw.113.1701817516092; Tue, 05 Dec 2023 15:05:16 -0800 (PST) Received: from [192.168.1.164] ([2600:1700:1ff0:d0e0::47]) by smtp.gmail.com with ESMTPSA id df15-20020a05622a0ecf00b00423da75b0f4sm5504430qtb.71.2023.12.05.15.05.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 15:05:14 -0800 (PST) From: Andrew Halaney Date: Tue, 05 Dec 2023 17:05:11 -0600 Subject: [PATCH 3/3] soc: qcom: pmic_pdcharger_ulog: Fix hypothetical ulog request message endianess MIME-Version: 1.0 Message-Id: <20231205-pmicpdcharger-ulog-fixups-v1-3-71c95162cb84@redhat.com> References: <20231205-pmicpdcharger-ulog-fixups-v1-0-71c95162cb84@redhat.com> In-Reply-To: <20231205-pmicpdcharger-ulog-fixups-v1-0-71c95162cb84@redhat.com> To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Halaney , kernel test robot X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 05 Dec 2023 15:05:32 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784485040321124167 X-GMAIL-MSGID: 1784485040321124167 Sparse reports the following: % ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make C=2 W=1 drivers/soc/qcom/pmic_pdcharger_ulog.o ... CC drivers/soc/qcom/pmic_pdcharger_ulog.o CHECK drivers/soc/qcom/pmic_pdcharger_ulog.c drivers/soc/qcom/pmic_pdcharger_ulog.c:57:34: warning: incorrect type in initializer (different base types) drivers/soc/qcom/pmic_pdcharger_ulog.c:57:34: expected restricted __le32 [usertype] owner drivers/soc/qcom/pmic_pdcharger_ulog.c:57:34: got int drivers/soc/qcom/pmic_pdcharger_ulog.c:58:33: warning: incorrect type in initializer (different base types) drivers/soc/qcom/pmic_pdcharger_ulog.c:58:33: expected restricted __le32 [usertype] type drivers/soc/qcom/pmic_pdcharger_ulog.c:58:33: got int drivers/soc/qcom/pmic_pdcharger_ulog.c:59:35: warning: incorrect type in initializer (different base types) drivers/soc/qcom/pmic_pdcharger_ulog.c:59:35: expected restricted __le32 [usertype] opcode drivers/soc/qcom/pmic_pdcharger_ulog.c:59:35: got int Let's deal with endianness conversion in the rare case this ever runs on a big-endian machine (and to quiet down sparse for this file). Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202312060355.M0eJtq4X-lkp@intel.com/ Fixes: 086fdb48bc65 ("soc: qcom: add ADSP PDCharger ULOG driver") Signed-off-by: Andrew Halaney Reviewed-by: Neil Armstrong --- drivers/soc/qcom/pmic_pdcharger_ulog.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/soc/qcom/pmic_pdcharger_ulog.c b/drivers/soc/qcom/pmic_pdcharger_ulog.c index f1aaacf05005..238cd38589dc 100644 --- a/drivers/soc/qcom/pmic_pdcharger_ulog.c +++ b/drivers/soc/qcom/pmic_pdcharger_ulog.c @@ -54,9 +54,9 @@ static int pmic_pdcharger_ulog_request(struct pmic_pdcharger_ulog *pg) { struct get_ulog_req_msg req_msg = { .hdr = { - .owner = MSG_OWNER_CHG_ULOG, - .type = MSG_TYPE_REQ_RESP, - .opcode = GET_CHG_ULOG_REQ + .owner = cpu_to_le32(MSG_OWNER_CHG_ULOG), + .type = cpu_to_le32(MSG_TYPE_REQ_RESP), + .opcode = cpu_to_le32(GET_CHG_ULOG_REQ) }, .log_size = MAX_ULOG_SIZE };