From patchwork Tue Dec 5 20:29:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Edwards X-Patchwork-Id: 174187 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3689604vqy; Tue, 5 Dec 2023 12:29:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IENkbaxfiLKA3RFArdeC9Apyx4Uyj7NfsC15cyq9Wz3oIFaLz88Wfgib778mJkTmaHpqlCb X-Received: by 2002:a17:90a:307:b0:286:6cc0:62a5 with SMTP id 7-20020a17090a030700b002866cc062a5mr2093023pje.36.1701808163957; Tue, 05 Dec 2023 12:29:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701808163; cv=none; d=google.com; s=arc-20160816; b=gk9hP9hz1w+ww0mHxFn/h9YRkJS0XcCNs9tFUkidiuW/k2U5C+zpo090Yzq1K+D2e/ rQyp5MmLyOYNKYyP2MGc7YLShSpK78gxu+jejZ48z7tS1dry83PyJQ3dwlVJKoJCWKgn 3qtYExIhbUYJmvz1P8cBDXmBKNzIcxn/hYtMfiTySTF1W8JBw9MrmSM1nrpsIp8iQLSt JpzfILUFrbK9VtsaNO3Nm7Rt20gX1xl6MpfHoE0zC51gYvOl2bXYK46DhgnpnNrwJCAA x3PPS5tlbjCNAf+lKZBstC4z0bCitzCsBNnAGDPpl/eHeZp5Y5T15ktgXtYAYMZUTe/7 qEYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=LYftztaNvPp9AiycXxFsDD/pusJZO5VD4GKLxnNaenc=; fh=WsPG8bmoeVdJ+mTvc3JfGT690EmTY9Rsmm35P0eF47I=; b=Bu2a6lXuqeZ9UMPCihMoRnCOzaBq4vfzP3GaHMcy8PFnL6D5qXTJRyIb02tQO7nEYb n65iX6CraKlT8MDlC6owWLI92jx4WBptZIhqMfRXnbmw830lZwBjn3thWso6KUjE5vQI yznIjol8EFaEJK3CWlwfgArdu48DjA5512DwFmwc6jd70kwHjRoGB1lnIxnzwcRHv3lV zoVr8YBxaZnmn3UaPi48UiXODoA17qoRMjXazlyMHLqkBglWqE6drZcGiJDRwihPUJIw LqzXBf7Jf8ckNCBNVwYcYdrBR6rNBfdMD19ifAczcgDc941YTdxaARrXVB0tLWwBgvIV /JGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ROO6w6Gc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id d10-20020a170903230a00b001cfd5a36b31si4310925plh.495.2023.12.05.12.29.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 12:29:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ROO6w6Gc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id D91C180309B9; Tue, 5 Dec 2023 12:29:22 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235123AbjLEU3K (ORCPT + 99 others); Tue, 5 Dec 2023 15:29:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230162AbjLEU3I (ORCPT ); Tue, 5 Dec 2023 15:29:08 -0500 Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01749129; Tue, 5 Dec 2023 12:29:14 -0800 (PST) Received: by mail-io1-xd36.google.com with SMTP id ca18e2360f4ac-7b3bc70fca5so5146839f.1; Tue, 05 Dec 2023 12:29:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701808154; x=1702412954; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LYftztaNvPp9AiycXxFsDD/pusJZO5VD4GKLxnNaenc=; b=ROO6w6Gc3UGUgtB23hLKn7QZVd9c7gSwZG8luUTDCKVHuXrTucFu0H/xUd+SVDXDtv PIiKySlgPjtEq69g6uJGTvjapgGQ8u5htSObTsyz4WCz4VsojD9SM/tJku8IwmL215HR Yf/78KhP1IaHpV7xgCVSC0j9RVFXRDbdjDEhsj++qd4VNxzAVB1gHIDMAmD642vzxyB7 K0e6tSX7TebCzHuEl224QULL0BTit5RYAD/aO9o/wYhJCr9XMSrMaOaGxTiJrGrZJDcP UJRc8mJ2NNaAwYxfTYDmCaMVpxtU/ujcCn6SZUkbdKVu02tbyYLNTkemkMKL6N3fMIFQ tVuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701808154; x=1702412954; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LYftztaNvPp9AiycXxFsDD/pusJZO5VD4GKLxnNaenc=; b=aIJ4yapcfsLYyd1Ws6jgmk+273J7Vl+d3kprdT57upwLD3RsG3nCJOp8ww+tTniEb5 IyJhnMgLvZr6A0XHxcUJ63bEOvqpIdmbuxsOkn6UEcW+RpqG0EZgAR85nN2nisY3rkH9 q1DtvpvKeOQNLegf2rN/QMyZwVAcSTqCUzsE7T1DKwmjfnH1OITTWCL3HRuohNjn0oYV 2fk/K5kOLI6u3q7zV4HUeaHb1oOWPziLc1ogCYqzAWO6Hpa+7azT1J9h692D51e83D8m iUmFWqXMqE2ciGcxXb4DlzrUvLZx3rVycVCHdcqk38ykZDx567JtkCvIboqluv+g4x9G iPLg== X-Gm-Message-State: AOJu0YwlJdQX1KRsbU8OK69s8kwgZd75hDbjb3pYoVUykGgJ9y6KOB5j FdYFX0s48VpPxQnGQqJlp6tdAS5St9oi5fVY X-Received: by 2002:a5d:8716:0:b0:7b3:9de6:695c with SMTP id u22-20020a5d8716000000b007b39de6695cmr1889441iom.7.1701808154136; Tue, 05 Dec 2023 12:29:14 -0800 (PST) Received: from celestia.nettie.lan ([2001:470:42c4:101:3fb7:1e39:b284:286f]) by smtp.gmail.com with ESMTPSA id cw2-20020a05663849c200b004302370a169sm3296320jab.157.2023.12.05.12.29.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 12:29:13 -0800 (PST) From: Sam Edwards X-Google-Original-From: Sam Edwards To: Heiko Stuebner , Rob Herring Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, =?utf-8?q?Daniel_?= =?utf-8?q?Kukie=C5=82a?= , Sven Rademakers , Joshua Riek , Sam Edwards Subject: [RESEND PATCH] arm64: dts: rockchip: Fix eMMC Data Strobe PD Date: Tue, 5 Dec 2023 12:29:00 -0800 Message-ID: <20231205202900.4617-2-CFSworks@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 05 Dec 2023 12:29:23 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784475197361419653 X-GMAIL-MSGID: 1784475197361419653 JEDEC standard JESD84-B51 defines the eMMC Data Strobe line, which is currently used only in HS400 mode, as a device->host clock signal that "is used only in read operation. The Data Strobe is always High-Z (not driven by the device and pulled down by RDS) or Driven Low in write operation, except during CRC status response." RDS is a pull-down resistor specified in the 10K-100K ohm range. Thus per the standard, the Data Strobe is always pulled to ground (by the eMMC and/or RDS) during write operations. Evidently, the eMMC host controller in the RK3588 considers an active voltage on the eMMC-DS line during a write to be an error. The default (i.e. hardware reset, and Rockchip BSP) behavior for the RK3588 is to activate the eMMC-DS pin's builtin pull-down. As a result, many RK3588 board designers do not bother adding a dedicated RDS resistor, instead relying on the RK3588's internal bias. The current devicetree, however, disables this bias (`pcfg_pull_none`), breaking HS400-mode writes for boards without a dedicated RDS, but with an eMMC chip that chooses to High-Z (instead of drive-low) the eMMC-DS line. (The Turing RK1 is one such board.) Fix this by changing the bias in the (common) emmc_data_strobe case to reflect the expected hardware/BSP behavior. This is unlikely to cause regressions elsewhere: the pull-down is only relevant for High-Z eMMCs, and if this is redundant with a (dedicated) RDS resistor, the effective result is only a lower resistance to ground -- where the range of tolerance is quite high. If it does, it's better fixed in the specific devicetrees. Fixes: d85f8a5c798d5 ("arm64: dts: rockchip: Add rk3588 pinctrl data") Signed-off-by: Sam Edwards --- arch/arm64/boot/dts/rockchip/rk3588s-pinctrl.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-pinctrl.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s-pinctrl.dtsi index 63151d9d2377..30db12c4fc82 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588s-pinctrl.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3588s-pinctrl.dtsi @@ -369,7 +369,7 @@ emmc_cmd: emmc-cmd { emmc_data_strobe: emmc-data-strobe { rockchip,pins = /* emmc_data_strobe */ - <2 RK_PA2 1 &pcfg_pull_none>; + <2 RK_PA2 1 &pcfg_pull_down>; }; };