From patchwork Tue Dec 5 13:54:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 174057 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3444321vqy; Tue, 5 Dec 2023 05:58:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IFHZCz6tSZj1Rpq2fRQ7QWuuJlBEZBAIoimq2//QkPS6hezgKCntu5cNIZFSw3GvfZA7aFD X-Received: by 2002:a05:6830:439e:b0:6d3:127b:6fba with SMTP id s30-20020a056830439e00b006d3127b6fbamr6760189otv.9.1701784734837; Tue, 05 Dec 2023 05:58:54 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1701784734; cv=pass; d=google.com; s=arc-20160816; b=j+Xy0ni9wjUKEwhLsc/1hKv+NMo6fDZEn7fXXqhEFSreApQX3cCU+JyiWd3mnkmMLF 1sEV0va41nQVp24SrtLTA2+zFG0412gTQOwelNNXhpJhiV0gfbIJ7q0EE0XmkRj/cyJb pfN3YL9fivmvdt5dClCPRFEBa/lOciT006fzvqorlOr2Q0NjRIpjkOV8xIQeMkQ3Ysfb qh1qgyM4C/cJ+ktbfhd8R5NGSXI+240FqquEEIpICRODB9SUWaa60vQ2jCieNz9sLscm Ccp9eMf35U/Z/jldtGTqajFVLq2Y+1nMnREvvuL1hvn+6ehUSmUxmSh9cX0pngK6uDv9 DHAw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:errors-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:mime-version :subject:to:from:date:dkim-signature:dkim-signature:arc-filter :dmarc-filter:delivered-to; bh=Gzeev5qGUmmaFumMkB6OYo7EgKGMmy7oM0cgkIHuJzI=; fh=hPrbWPhweUx4V0GV9uXJqbyAzg2ABmTz7kczrAQqMmM=; b=Dn/sJXkeOFjnsLkBVw2erRos56x68ZG6PBHBUn8LnyJJOGN05c1zw8T0gcmbryUNnX RNomYwDYy0KOi+7R7Za66lL+sELBm/1w/q+rEJ4C5RyWThEIwaXfoWomRMIr+2TD4PVi oM0cejQ4aBjwSPnoArWsC3KFlRToQJTJhxqKvG9WQjj1NLrsi6tClausHMO2UHKLsL7C akbHdA1lVY9vdscAv+ZBjcle40ZNv/NZDkULbC6cD7nDtKnKfbwg5NyITN7gL219qMKA Js3oDEp6ZHEdcVcuiS0k5AI6dhqr8BtsyltvDS5JDOFsp1vF4mGmyCjidXRJLw00F5Pg bS6Q== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=AY7lew1o; dkim=neutral (no key) header.i=@suse.de header.b=zXmRTbsD; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id gd26-20020a05622a5c1a00b0042383d2deedsi12510805qtb.614.2023.12.05.05.58.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 05:58:54 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=AY7lew1o; dkim=neutral (no key) header.i=@suse.de header.b=zXmRTbsD; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 970253858032 for ; Tue, 5 Dec 2023 13:58:54 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 22CC83858407 for ; Tue, 5 Dec 2023 13:58:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 22CC83858407 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 22CC83858407 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701784712; cv=none; b=MQ8U84BCkzudhYD/wbg9kOTdjosYE0E+y9lXlHZMGGl5FIuah+UVMjEeP0HddGvY/pQMmeR9i0vPEraX29Mx06yBT4XOxyrKuOJOFe1pjyH3K4esLOvbjJm93Xyu0VK12qRVb9T8ZMArDxTWdkH2qGCSAVClNnmEBeShyVRQgVU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701784712; c=relaxed/simple; bh=BWSY8C+Bk2XXmEZna1DqKOd76s8jads/7pI4PkKjlyM=; h=DKIM-Signature:DKIM-Signature:Date:From:To:Subject:MIME-Version; b=FXVHNargJ8JQNg73TlWoSXM2LNXvq1/1WkA9VeGGz2mvD4icCK1nD6xyzhC0P+eqtlGCd7kAKUhg/SMa73nnU/Ld/m/zr5JDnDBH7uDcY06e7KBM/3/GF3bYUDG+rvzB66bXvknWKWU4+kKTgFQMi8VSX7mGXWrSUhz2Ws2EM6w= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D1CD321A61 for ; Tue, 5 Dec 2023 13:58:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1701784709; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=Gzeev5qGUmmaFumMkB6OYo7EgKGMmy7oM0cgkIHuJzI=; b=AY7lew1o9xzL4q+sqglRQaT05OSOVem6MMo3IB+OzwUwiLkME57LJblLJM8rea4FvhyVQz 2bvISbwZQhLCFER607JR/c7xEyI3PMlZ0d7/CI9irXqCMg9GRlycI2Jppug8rjBWLzt90w 3NEuVJxz7xPBF+tyRrZ4s8j0ky1ObRQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1701784709; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=Gzeev5qGUmmaFumMkB6OYo7EgKGMmy7oM0cgkIHuJzI=; b=zXmRTbsDjAvfF+KbsVkCTiTzCMChIRM6gw2J00r+Uik0fNHz+qaP7v1mFcKFEBKINCIzTn JCt1no5R954P+ZBw== Date: Tue, 5 Dec 2023 14:54:45 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] ipa/92606 - IPA ICF merging variables in different address-space MIME-Version: 1.0 X-Spamd-Result: default: False [2.40 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; MISSING_MID(2.50)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-0.00)[13.55%] Authentication-Results: smtp-out1.suse.de; none X-Spam-Score: 2.40 X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Message-Id: <20231205135854.970253858032@sourceware.org> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784450630393439750 X-GMAIL-MSGID: 1784450630393439750 The following aovids merging variables that are put in different address-spaces. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR ipa/92606 * ipa-icf.cc (sem_variable::equals_wpa): Compare address-spaces. --- gcc/ipa-icf.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gcc/ipa-icf.cc b/gcc/ipa-icf.cc index c72c9d57a80..81232d5706e 100644 --- a/gcc/ipa-icf.cc +++ b/gcc/ipa-icf.cc @@ -1666,6 +1666,10 @@ sem_variable::equals_wpa (sem_item *item, if (DECL_IN_TEXT_SECTION (decl) != DECL_IN_TEXT_SECTION (item->decl)) return return_false_with_msg ("text section"); + if (TYPE_ADDR_SPACE (TREE_TYPE (decl)) + != TYPE_ADDR_SPACE (TREE_TYPE (item->decl))) + return return_false_with_msg ("address-space"); + ipa_ref *ref = NULL, *ref2 = NULL; for (unsigned i = 0; node->iterate_reference (i, ref); i++) {