From patchwork Tue Dec 5 12:26:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 174029 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3391777vqy; Tue, 5 Dec 2023 04:27:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IHrhcIdO4VvvK2pEax5FSJ4Q1LjJc7Cpoj7yu0rytx2B+qupauke8Kahf62Ds1K5RiE9boM X-Received: by 2002:a17:902:e546:b0:1d0:a791:758d with SMTP id n6-20020a170902e54600b001d0a791758dmr3899046plf.135.1701779252500; Tue, 05 Dec 2023 04:27:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701779252; cv=none; d=google.com; s=arc-20160816; b=T26eSMJZjl5HUOef05tEOa1PEre/8piJWrDsHWLqbnl9MUtpzDHUrd6qoJ6oY+B9Gj y8UdPlGHtCVu2MI3re/JsGX6l6jJcQ00Ufbu57zoTEWJCpbchGjeTQcmUT+K2jbZkW42 p2KLBqj4dCDAbjaQuTUKqHr9PDgLsHqj6Z9InjKzKlapEserOC3YZBDA0yt0cVai/b4q +52FPafbsSuRBpbl3xKYn9iGDSEUIGe55dx4D6OofOpaVxLLZaAJFsk9kphXKvkeRmGw bffJ7VMSJVZRS9zkZ7akh8JPlIDLW5riz3srcVTS6WpenNjqrCoEQeIvighT2s2aDNEJ cBCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=+b1knwi2HMD8mYZhKPz9Sk2fdrSpwI+6fqWXcPr4WD8=; fh=+bOS7EAwdGBDNDi3DApgKxJaZ2RNm60AI+OqdQ0si9c=; b=rrTFQgghmeL6nI3kuOwwQ7ombo+nS2Wf5F6wy2HwVsZjhpXPQw2XuxXJ6RtA3c3+7o add1YF7Y+FGObKx60OdTA/WNG1pO0nfcRexl4qsSOSV20K6hx53rg16XkHbI+jmSR+Lz /K1YyqcOT3CElcjNPGoiIje2SwZgyZhrO3ojz4wiiaHOWQfuacsrFnxVfnVbZO7lmVII xN0kc5iXFN+iSzsqZsRz2LnvoO3hVMVWrh4icX0K2h6t5wpaT8yXM5FdF8SDFMR+zEvU RTaaQ2a3e0c5h1TbsaIzhYJxB+OyUasfHnXn8cF7Z/CCWN0KsuPHDW0dFfwfhrzAyx1v XfMg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id ba1-20020a170902720100b001d04c097d28si8052457plb.518.2023.12.05.04.27.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 04:27:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 95839822AE43; Tue, 5 Dec 2023 04:27:29 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235198AbjLEM0k (ORCPT + 99 others); Tue, 5 Dec 2023 07:26:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235148AbjLEM0d (ORCPT ); Tue, 5 Dec 2023 07:26:33 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61D08D7 for ; Tue, 5 Dec 2023 04:26:40 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rAUVX-0005XW-KJ; Tue, 05 Dec 2023 13:26:35 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rAUVW-00Djuo-SO; Tue, 05 Dec 2023 13:26:34 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rAUVW-00EhQa-JR; Tue, 05 Dec 2023 13:26:34 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Liam Girdwood , Mark Brown Cc: patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 1/8] regulator: arizona-ldo1: Convert to platform remove callback returning void Date: Tue, 5 Dec 2023 13:26:16 +0100 Message-ID: <76c7af01e2c8b3ab6585a04bc3f0d163fbb7fdf7.1701778038.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2157; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=tqCSGHqBxpGncb/+HKOeTjE6jA8FKgj6miulNJehbSo=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlbxbnODU3ZgR0fcmS1aFFE63uhc6c35DkU4ysm IwvnJ5XRzWJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZW8W5wAKCRCPgPtYfRL+ TqJUB/42N8x71AwQgruQABeImfIN7vEaTkaTthiUERrgXAnkBzZ9gegXAy7pvht0kx7KCwXwYKQ f/m/Xkrf8wXWN+2PAo0aoBsh9p+K4akQOsOuApKCOWItKTNextjtAYmplBZnZnlzBDFcCyX+D9y q5+SdJ9ZXfgGTOEhBIoTMekZawYBDuAaTno7ZTLTPK0X46E2miZttmTywkwuR8jdcx8xWztHdf2 uqz2j8yAzXaxXiPf+vDjO9RjhVw+7OoEZ9vSxqmSwXo8FdZm22cGjZ3NQ49s4fiYdipQGzx9uhV TrlpV9kbWMTQ3P76Tzgr8GKnX83oMIqzv4BoL5d3qpeJEWLS X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 05 Dec 2023 04:27:29 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784444881533528795 X-GMAIL-MSGID: 1784444881533528795 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Charles Keepax --- drivers/regulator/arizona-ldo1.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/regulator/arizona-ldo1.c b/drivers/regulator/arizona-ldo1.c index b465c0010665..4b54068d4f59 100644 --- a/drivers/regulator/arizona-ldo1.c +++ b/drivers/regulator/arizona-ldo1.c @@ -339,14 +339,12 @@ static int arizona_ldo1_probe(struct platform_device *pdev) return ret; } -static int arizona_ldo1_remove(struct platform_device *pdev) +static void arizona_ldo1_remove(struct platform_device *pdev) { struct arizona_ldo1 *ldo1 = platform_get_drvdata(pdev); if (ldo1->ena_gpiod) gpiod_put(ldo1->ena_gpiod); - - return 0; } static int madera_ldo1_probe(struct platform_device *pdev) @@ -377,7 +375,7 @@ static int madera_ldo1_probe(struct platform_device *pdev) static struct platform_driver arizona_ldo1_driver = { .probe = arizona_ldo1_probe, - .remove = arizona_ldo1_remove, + .remove_new = arizona_ldo1_remove, .driver = { .name = "arizona-ldo1", .probe_type = PROBE_FORCE_SYNCHRONOUS, @@ -386,7 +384,7 @@ static struct platform_driver arizona_ldo1_driver = { static struct platform_driver madera_ldo1_driver = { .probe = madera_ldo1_probe, - .remove = arizona_ldo1_remove, + .remove_new = arizona_ldo1_remove, .driver = { .name = "madera-ldo1", .probe_type = PROBE_FORCE_SYNCHRONOUS, From patchwork Tue Dec 5 12:26:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 174023 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3391391vqy; Tue, 5 Dec 2023 04:26:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IG5QOvYWxASOOVceCgsR+lAXNCm7Dmh9zgS7O+muGJBYgwAdg2d45r4HdKhA4TbI8Kvxj4F X-Received: by 2002:a17:902:720a:b0:1d0:6ffd:e2ef with SMTP id ba10-20020a170902720a00b001d06ffde2efmr4243967plb.137.1701779205339; Tue, 05 Dec 2023 04:26:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701779205; cv=none; d=google.com; s=arc-20160816; b=lwpGouzWT34OJtZCJ/0LmiuExLiUAtvyrzaHC3gix8C7mHS/YsXSyFR2SHoXZhOBoV gVPGzvF1X+33E1xPwv9AQk93lWTAWpJabogeSUzZftE2JIqRXcYhZPnmMCfJPxsueU96 IPtWZFs6pG05/fINgT2UJveT3A3E+lgf4nYExHCg3TLLVpmfP7qB6KZjcOxwSBUPeGsM jIZxkERVttKqOmUPMLTa50B5bLi4Kij/Njc9diUMHArkpXXbbFMoUTvsd+SZu2QLpf8U bATvV6E2E86SW8a3ynTM/25yoFtYo7UZem6DP74n/DVU4XaQbDVlCs/15yt4af1XL1dO ksKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=l1dEnt1STa0zYIltqERfcWT038bn7mZMfufxjMJTrL4=; fh=hjIksG6EtuG1RH3YtJvtaLD1e60yuZ9kPU55ceFRx48=; b=UraUpYqyT6OgxTkHbl1a8WBpDj/nYGk8K5f72aTvjjiX98eH8OXGsoSmMNMWc6hDRA oB8/DNjG2Eran2Oz/wSU4dUQw7EvzPJn8rvMk3/JZV9a4cdwwSAcYGq9SZH8sSBIqngz inQDA6ePdKVbPZcKuTn9yUTgt/0+CAC8fmD6nC8XZwyt2lzzWR88/IAv7bpjBwC07p4H 2R/Hnx+WuUI/JCJFcUDS65SgZq6vAjK/hOyrgnuGg8JqmgIIxBhx5RMLZpA+pXRb9V0o a8nxhijMAii+YBqxDJG4zF9UkMWkWJqVijk6j+vlsQVpzimOa8AfazTVsZhju7lTIrMC bmmQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id v24-20020a170902e8d800b001d0b3be7e4asi2554546plg.161.2023.12.05.04.26.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 04:26:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 42D1580C5F91; Tue, 5 Dec 2023 04:26:44 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235146AbjLEM0e (ORCPT + 99 others); Tue, 5 Dec 2023 07:26:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231945AbjLEM0b (ORCPT ); Tue, 5 Dec 2023 07:26:31 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0748A116 for ; Tue, 5 Dec 2023 04:26:38 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rAUVX-0005XX-Ey; Tue, 05 Dec 2023 13:26:35 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rAUVX-00Djur-2H; Tue, 05 Dec 2023 13:26:35 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rAUVW-00EhQd-PT; Tue, 05 Dec 2023 13:26:34 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Liam Girdwood , Mark Brown Cc: Marek Vasut , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 2/8] regulator: bd9571mwv: Convert to platform remove callback returning void Date: Tue, 5 Dec 2023 13:26:17 +0100 Message-ID: <639e796b36815a219ff1172cc758ba7378211d74.1701778038.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1844; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=xHLhRqowwhFDnR1Zz3hrHDK3dQ0zi02Jx4061ISe4MM=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlbxboQOaQkKi2vEhgf7ZGG0FfDWxXYpAN6cRlW K/zmQb5HeqJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZW8W6AAKCRCPgPtYfRL+ TtJqB/9e48xXfRTGrxFhfDHXi37CoQOy9e3v7lcsWmzELvxm0TOXy6bKEhcgZNuCqJP5wwUk1N0 8xFFcSEr4zOn2UBM1VtvoVU9IX/9QGmYZxwmZT9MPJwax4LswsO8+CreHzbtc2DR5iNx0Je5Eeh NdL7c9NSnyNi2eB+PZoTa+lfrerh03l7ETvyltKcIhf4heaqw6CJ0mfFg+I2hB9lmFnDw2+rMIA qM+W++qoJpzP7LwL/R/P1Z7Yjre1h8l5+pbo+dyWl4vIhNDIeVZtXEI/g9G/mTk4MfuElMviw/Y j9Cy0KNqDouDLaGjr0yEI4dBeDfxuZnzsGaCIFBHxq2PlmW/ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 05 Dec 2023 04:26:44 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784444831865203411 X-GMAIL-MSGID: 1784444831865203411 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Geert Uytterhoeven --- drivers/regulator/bd9571mwv-regulator.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/bd9571mwv-regulator.c b/drivers/regulator/bd9571mwv-regulator.c index d469481d8442..c7ceba56e7dc 100644 --- a/drivers/regulator/bd9571mwv-regulator.c +++ b/drivers/regulator/bd9571mwv-regulator.c @@ -260,10 +260,9 @@ static const struct dev_pm_ops bd9571mwv_pm = { SET_SYSTEM_SLEEP_PM_OPS(bd9571mwv_suspend, bd9571mwv_resume) }; -static int bd9571mwv_regulator_remove(struct platform_device *pdev) +static void bd9571mwv_regulator_remove(struct platform_device *pdev) { device_remove_file(&pdev->dev, &dev_attr_backup_mode); - return 0; } #define DEV_PM_OPS &bd9571mwv_pm #else @@ -357,7 +356,7 @@ static struct platform_driver bd9571mwv_regulator_driver = { .pm = DEV_PM_OPS, }, .probe = bd9571mwv_regulator_probe, - .remove = bd9571mwv_regulator_remove, + .remove_new = bd9571mwv_regulator_remove, .id_table = bd9571mwv_regulator_id_table, }; module_platform_driver(bd9571mwv_regulator_driver); From patchwork Tue Dec 5 12:26:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 174022 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3391386vqy; Tue, 5 Dec 2023 04:26:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IFw3Ks1s0Uo2nJd9oSh1o0UmlOom0uUkNmhmta9f4dQojx5sB/ON6pCXmpCcEkBxPzbk8iJ X-Received: by 2002:a17:902:c950:b0:1d0:8abf:3ea with SMTP id i16-20020a170902c95000b001d08abf03eamr3287345pla.85.1701779204956; Tue, 05 Dec 2023 04:26:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701779204; cv=none; d=google.com; s=arc-20160816; b=VJg3GEd2+ykRgEX0a8Pysstlc6h/q/IwQVdT1QnGo/fqCJVNQJSvRCs4a3zcUD4szv UY7Nbgi6J1qNV8lFrBrJlCeWw40ruVGuTb+LN1O0g1iRAV1ojMczQQcCH+b6YGRBS0Gl lQCMnktlye3AoH93oEhJnztt6iHBEfNdHeC6dYwiv2ID7u5AAuxh59M++5JjXe7qknXw mq46u+syvUOJYASeCcE0XKigD0u6SyaXk/bXniYttgc8jvo7RRg/hr0AVYEQqlIui1qE ruup3PEDiR6cM2ocf5Tv2ouNqn/v0vj3eif4hLN4D46ofPXSFugR2hF2M/gR12Gzcx7L aZ9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=M43wITVH2fO0MFSx9k2ho7xUAIHJk3raduPLAQdMDxU=; fh=SV7jp/N4w5H/WguTuPXZpem2ktA8CMnlzZDNo6r9whw=; b=XHHXmI6Ixhg//XmLe2IbEAfE7nt73eMUdDvkxVpEMuM0YT4OIIRPfCRMFbA/bTRaSi BH7RaYCAhI1AjNDmvVF05/0sO15kTCrPsWp7RJMdjuJT5yR05wvDQ5Rm4gpj1sFWq4zJ YI0m8tJ8JZu3hjkuNBv8nPFS8XJBLzHF9Xs81/GNhvyVvKMQUUvoXRoWzw+s07pOGlpx /T5BBg7U99EJTdPU5DJyiZnq7ElKX1ECiQV6YZfHEZ1l88DRNm2u8jMiZFXj1agYGw9j 5BocgrCxD3Y2YPgDSAXlzZs+tO6SCY0plRXKgBDK1PFkAV5uYrGD35dJXp8Mc3noM+yk Lzqg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id bj6-20020a170902850600b001d06eae7137si5655702plb.260.2023.12.05.04.26.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 04:26:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id D816A80FE96A; Tue, 5 Dec 2023 04:26:41 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235140AbjLEM0c (ORCPT + 99 others); Tue, 5 Dec 2023 07:26:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231941AbjLEM0b (ORCPT ); Tue, 5 Dec 2023 07:26:31 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A44F910F for ; Tue, 5 Dec 2023 04:26:37 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rAUVX-0005XY-K6; Tue, 05 Dec 2023 13:26:35 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rAUVX-00Djuu-7a; Tue, 05 Dec 2023 13:26:35 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rAUVW-00EhQh-Uq; Tue, 05 Dec 2023 13:26:34 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 3/8] regulator: db8500-prcmu: Convert to platform remove callback returning void Date: Tue, 5 Dec 2023 13:26:18 +0100 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1728; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=aQBaFL+FANXD31y3+CbqmAskYiXzkwfN3BmtZOQME1Q=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlbxbpizW0JIt1XczXtpIgApN7XcjmUuaG+FhOf Df5QsH3KhaJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZW8W6QAKCRCPgPtYfRL+ TmbUB/wK0Qf/b8gsd9YQ6Hsl1DpgEI0ASqXa8lirDvQU/cJMTo5iN1xlEcnjAqYEC8VR6+gBUWU 3/Nqjdcco4i+4fQ9KzGyL7HzmTuhL5xUcRSA6WYpVxeL940o6HfR7HBLiQZZziXdVe+uf6lilc8 oiJiqebw9iuv7BuMZHpo3tlbhOIcm9U1zb9/EsJYWtx55MmSrNbUx7SJsl9q7mY3WJS6cLDdOZ6 bEW/5dB8SPO19nZ6p0E9OrUAv9wFcfofvozmJwiv4O316ACdj3hDbVzkyagRuo7ycx83GuRcOp6 DABtEHAPSWb370DtrDpUBkbagM0g8oaB5ItADe/JUICsqV9+ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 05 Dec 2023 04:26:42 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784444831730569521 X-GMAIL-MSGID: 1784444831730569521 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/regulator/db8500-prcmu.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/db8500-prcmu.c b/drivers/regulator/db8500-prcmu.c index 34c5e485d0af..1e2d54da1b9a 100644 --- a/drivers/regulator/db8500-prcmu.c +++ b/drivers/regulator/db8500-prcmu.c @@ -469,11 +469,9 @@ static int db8500_regulator_probe(struct platform_device *pdev) return 0; } -static int db8500_regulator_remove(struct platform_device *pdev) +static void db8500_regulator_remove(struct platform_device *pdev) { ux500_regulator_debug_exit(); - - return 0; } static struct platform_driver db8500_regulator_driver = { @@ -482,7 +480,7 @@ static struct platform_driver db8500_regulator_driver = { .probe_type = PROBE_PREFER_ASYNCHRONOUS, }, .probe = db8500_regulator_probe, - .remove = db8500_regulator_remove, + .remove_new = db8500_regulator_remove, }; static int __init db8500_regulator_init(void) From patchwork Tue Dec 5 12:26:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 174027 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3391550vqy; Tue, 5 Dec 2023 04:27:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IHDiRhRaoA28NH69qhdKcr5tpMNFe8rMV3R0/viFEhtTQ16zHMyyXp5GDuW7aE/K0mlAKnv X-Received: by 2002:a05:6a20:7352:b0:18b:94c5:257c with SMTP id v18-20020a056a20735200b0018b94c5257cmr2902144pzc.16.1701779223992; Tue, 05 Dec 2023 04:27:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701779223; cv=none; d=google.com; s=arc-20160816; b=QuKyIwoBhRwxjods/icRR7WFDDePhS4LlXvntmzHTY4rES79m94gN6bONvibeeZ5VC Mk9e/f9s1JbgaKELjUTHcL62qjJw2NkzpiaNTpos5xtYJHT+eqYN3+VtCq6HSpUDB2F3 GznJ7X3tRm6yEwh77+oJVGIuHEU7LlTBKpIOS7eoIvYwa2rXxvc7+wwaQQZkEBUISKeS gtCP0T2G3tfjBvIBHAwuAOssol+0JfjIxZYyU8e9scbqcaj2dzCoFa5m6fZrqWHJO51R MSjSPnU2l/9caU8CXcU9a6/WUma2SOkNmc8JOmkUDHDIJr5khp9dlyZjNpC+Yvm/hQOu hH9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=jCBgI/ojb7tPzaf7yc4efGbClN2W7714z+OXJp0pzV4=; fh=ngtBh25P6mLYKRTVXn/J5Ppoq/KJSo3gYX6g5J5bE9k=; b=MtxJM4jJupOXQ3q1mVhp+hSGTc92VwUidDTtkUGmU3SfpHiy0/KZN10sOTiIWTWDte N7Xq8ofJmiCPI1UjiHSZXFtfxXBe8ooE4N2/8BvbUfjjzt99gsNORgogMPsUtZeSVk/8 nyTduTILyLmpoWe/yBrMwve0CvpZRertYHzItoBtEOV6UGvxjLPZDI0CVBZbsg2nzIJe q9oYdAbaxCpEQtAylggJFli/6zrVyRX3taz/hwAsqyDnERK0mG0I7tfbtBeYzZDgnf4+ ZT91V/n0D9GqmYZ7yoaHC9rvm3kUPds0oSzxq4O2wX+oqJKYdx9wPwm6gh4/cNvRQIZE lZCg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id gg16-20020a17090b0a1000b002866c405e01si5872778pjb.17.2023.12.05.04.27.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 04:27:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id B2DB280C65C2; Tue, 5 Dec 2023 04:27:02 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235174AbjLEM0r (ORCPT + 99 others); Tue, 5 Dec 2023 07:26:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235151AbjLEM0f (ORCPT ); Tue, 5 Dec 2023 07:26:35 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C865C9 for ; Tue, 5 Dec 2023 04:26:41 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rAUVY-0005Xu-76; Tue, 05 Dec 2023 13:26:36 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rAUVX-00Djux-Eg; Tue, 05 Dec 2023 13:26:35 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rAUVX-00EhQm-5Y; Tue, 05 Dec 2023 13:26:35 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Liam Girdwood , Mark Brown Cc: Maxime Coquelin , Alexandre Torgue , linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 4/8] regulator: stm32-vrefbuf: Convert to platform remove callback returning void Date: Tue, 5 Dec 2023 13:26:19 +0100 Message-ID: <2e96cf99c8d97b728d891a745e8f94ee39fbfee8.1701778038.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2049; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=sYW+VRQlaUR4tM4vU6xMFTkIkYFDO3ZsrQVPaJ+GEJ4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlbxbqWGuXtsy7gv6tNYQlb2xj7XMEobJPqduLF BBMwrfHmbqJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZW8W6gAKCRCPgPtYfRL+ TgbCB/98owzxEUqbrEj9sMckpRxSmLplun0ZyYiCAYe6awaXUO86peyV+H+0CXO93EdHbFb4Ha1 xR5aVqiHFvoflGPGMgYevzws9GXypUxbh9gddEc2dz8xIkjTjFUvIKL/GtY/xbEwdI812mdn2vK cwO2rD6nuyqSKMytiCXe1J1ms/54sERaxtP2fOqj35P8hbQoBW6LBF9iC4Q7bu7gWN8jzQUTFFb g5GpT/vMiC1D1cyVqLkr+nihchbcCW2SQ1C5Pa7VtvAxHVy1/T5Q7GsxR7SxccytJxtrxjMPlhE tA3urkm3LotZUnKzL2NsfSDubXKXyLeesFdivas8fQU+d4sc X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 05 Dec 2023 04:27:02 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784444851615206857 X-GMAIL-MSGID: 1784444851615206857 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/regulator/stm32-vrefbuf.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/stm32-vrefbuf.c b/drivers/regulator/stm32-vrefbuf.c index 717144cbe0f9..40855105dd33 100644 --- a/drivers/regulator/stm32-vrefbuf.c +++ b/drivers/regulator/stm32-vrefbuf.c @@ -233,7 +233,7 @@ static int stm32_vrefbuf_probe(struct platform_device *pdev) return ret; } -static int stm32_vrefbuf_remove(struct platform_device *pdev) +static void stm32_vrefbuf_remove(struct platform_device *pdev) { struct regulator_dev *rdev = platform_get_drvdata(pdev); struct stm32_vrefbuf *priv = rdev_get_drvdata(rdev); @@ -244,8 +244,6 @@ static int stm32_vrefbuf_remove(struct platform_device *pdev) pm_runtime_disable(&pdev->dev); pm_runtime_set_suspended(&pdev->dev); pm_runtime_put_noidle(&pdev->dev); - - return 0; }; static int __maybe_unused stm32_vrefbuf_runtime_suspend(struct device *dev) @@ -282,7 +280,7 @@ MODULE_DEVICE_TABLE(of, stm32_vrefbuf_of_match); static struct platform_driver stm32_vrefbuf_driver = { .probe = stm32_vrefbuf_probe, - .remove = stm32_vrefbuf_remove, + .remove_new = stm32_vrefbuf_remove, .driver = { .name = "stm32-vrefbuf", .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Tue Dec 5 12:26:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 174028 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3391668vqy; Tue, 5 Dec 2023 04:27:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IEVeAUwznf1Ba4LCMKGBmyyK8dgT3kpS1Fnuc/hQofj6VRF9/cQhPQKCaIGpBsCA1xmkv46 X-Received: by 2002:a05:6a21:1c8d:b0:18f:97c:9786 with SMTP id sf13-20020a056a211c8d00b0018f097c9786mr5638808pzb.110.1701779238400; Tue, 05 Dec 2023 04:27:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701779238; cv=none; d=google.com; s=arc-20160816; b=rEZ5Ydv9PeyMlwkx697G2r4W4xhIsif33v3q51L8joO+yDWb2Hn8bNVMu+Inpq7IVr Xy/ktxNNNXOb6UR5jGglf9aNXE0DSWcA2bE2n2BqCtNZ8TZCI8x5fYULhTLHCS1tSZvS iDTNZxpveaIztbg95Hy39iE2+fqAzfM6MT0xydHIb35j0g7lSr3WqVm2EiViBxHDxArh f8zjA7qk/XCfFvfyiUT7P6U92+D3MxLVis49yjn3PbtnLEtZXFz8P4996C0aeZZ0mk7p hPh3uPQara11elnxrsgLEVZMjF3Ew2jvWyvh3gJ3hE5vzRddHfPxnyUOCHr13GmZ7il/ XiDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=VZJs3GlxVjVaGsFVhp2UPMoLSaP6rTL6BWLhoFMDviA=; fh=Yizh0STwvmuKUAXlOou9xqxgjBVhxLb2DVtrpboQ5+w=; b=w0y3pHOlG1GKhVYb5VqKYBQjsNgET3SqFZjiy0S9i89okDgCwwn9oSDch+ie1ZfPNE oNdJBNT26jovUEmUmH1diwOF59n2DQmW/hQEEsggbfeQTkPVabiCBn6EQmdxA/UUCdfA jZLOOtEmWN/JywAqAs3BKJMbM0/9DngF5GJ05IU2RrPLgSX0aRlWcOwv3ZxHcWEprMqJ +gJA5MyNwSrTHKCC3CwOPDMlhiVu5O+YmaT5R2EkfAOpuZn4603E1PvkLZeGpVO5jncz Roc9XpXrDNzYc08CcE0zF2Ey2pjTKec7e3XumW+i6Jp03H245qW1FR5ezgQjJ1mXl2P8 kMOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id f5-20020a056a00238500b006ce54dc2d09si3079653pfc.254.2023.12.05.04.27.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 04:27:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 8B5A8803BA9B; Tue, 5 Dec 2023 04:27:15 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235140AbjLEM0p (ORCPT + 99 others); Tue, 5 Dec 2023 07:26:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232013AbjLEM0g (ORCPT ); Tue, 5 Dec 2023 07:26:36 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BC2B109 for ; Tue, 5 Dec 2023 04:26:42 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rAUVZ-0005Y1-Ay; Tue, 05 Dec 2023 13:26:37 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rAUVX-00Djv1-LJ; Tue, 05 Dec 2023 13:26:35 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rAUVX-00EhQq-CJ; Tue, 05 Dec 2023 13:26:35 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Liam Girdwood , Mark Brown Cc: Kunihiko Hayashi , Masami Hiramatsu , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 5/8] regulator: uniphier: Convert to platform remove callback returning void Date: Tue, 5 Dec 2023 13:26:20 +0100 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2025; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=MfQF9iwHzK7xCZssdcBcprKdoRpEqSRfvgyJg9UlPro=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlbxbrq9fl7uKhfoRDiG7dqJCrt0vg0UWtZzvc/ +ly7sZfv92JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZW8W6wAKCRCPgPtYfRL+ TlwyCAC02HaN2JA3GOM5Pz1awjMRcqAd7FBE3meTNtDblEqQYbRj45gdB3s+eakbwt8OGXe0s4+ IYvp/HN4pzTqf52GEThQ4tzV0heLJDZqsTo8G1zwhTUICI93/Mwsl3JtaYrgj89jASG5I4ZA0+W KLX86oNb1t2tAlyzUQAuC4iqJpD3d8MaQRWhGc7nDRUTP55DdlZ7onsx5ttLvAh5WGYrtD/3+1e xD+ZEps+OeYZUr8Uc/TnLmCg3Lh3NuC9BqUIWA/fW5vt1/8xYF4+8MOuPvcRPXziAUZ0gcEOW4K PW6h57ydJu6eI0TeCsy/nyb3KfjsM499f5xeQtMABzzHO4tx X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 05 Dec 2023 04:27:15 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784444866421497942 X-GMAIL-MSGID: 1784444866421497942 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/regulator/uniphier-regulator.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/uniphier-regulator.c b/drivers/regulator/uniphier-regulator.c index 1d8304b88bd6..5f868042392f 100644 --- a/drivers/regulator/uniphier-regulator.c +++ b/drivers/regulator/uniphier-regulator.c @@ -115,7 +115,7 @@ static int uniphier_regulator_probe(struct platform_device *pdev) return ret; } -static int uniphier_regulator_remove(struct platform_device *pdev) +static void uniphier_regulator_remove(struct platform_device *pdev) { struct uniphier_regulator_priv *priv = platform_get_drvdata(pdev); int i; @@ -124,8 +124,6 @@ static int uniphier_regulator_remove(struct platform_device *pdev) reset_control_assert(priv->rst[i]); clk_bulk_disable_unprepare(priv->data->nclks, priv->clk); - - return 0; } /* USB3 controller data */ @@ -209,7 +207,7 @@ MODULE_DEVICE_TABLE(of, uniphier_regulator_match); static struct platform_driver uniphier_regulator_driver = { .probe = uniphier_regulator_probe, - .remove = uniphier_regulator_remove, + .remove_new = uniphier_regulator_remove, .driver = { .name = "uniphier-regulator", .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Tue Dec 5 12:26:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 174025 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3391497vqy; Tue, 5 Dec 2023 04:26:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IHzHM8YdrrCE8KNfeGn0VEiQevlhcqutyt7+5cLZPAB9Vevu0bGJX4qOyObvJAnms2BV5gh X-Received: by 2002:a05:6e02:130f:b0:35d:59a2:2bb with SMTP id g15-20020a056e02130f00b0035d59a202bbmr6445532ilr.91.1701779217035; Tue, 05 Dec 2023 04:26:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701779217; cv=none; d=google.com; s=arc-20160816; b=TXbAA3Bi6BWaJINCy/PV6zBhnEccjcVdU8Co+X6lUrlUs4+mrQFuVxQWPGuyUxrDlE 8r9CWnOSAh75osmwiwRKfHraHUGyBo2ZQ+UoEbvWkOOjrFrGWD52BGuOgpYuLh47Xkf/ Sgp4XVYhf0zJmF15XcDwkl6v8Zj1zVDH7CODH++lt4/XBae2vHhGO1UuRnm7bkNgrZ2j m0TUUaV0SS06DUdagBvIJaPJHUOviA++m+tYnvHasScPq98rbyPbd891v0aG0V2q3EE5 v42gcIbmHnvLYz1ImIOoEFKEyqVer5Q2PAMWfCkgSFxaVEomqXa2TQNYDVhVCqkuDJMS sRMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=iz4S9wGLtU367r9UzGRSB/QAT3ieU73xFVMSChw56e8=; fh=SV7jp/N4w5H/WguTuPXZpem2ktA8CMnlzZDNo6r9whw=; b=XjO5FkJ6QbQdRXKd9kYCGNBTePuAHj/s8SRiD9uOzH8bLULd+8oj9pgPM5KJ9H8Wpd N9fBaDtgciW5e9DflLX0gutIm9rAzbAAEExka5EQ4ik5uMAAy39WyZmWRpG4AUfwvMb8 C/kJndCP2DzEsbRdgBYj5XmQy2jWsVzyHnD5k0TZQr0FIjyEy0JC0m+IFK/JYCn1jxLQ TZv0XYGl7D1/Odkqljmu8GoqSAsz4GB9U1TVbMtiNwGc7hGFh/b65Kd5vvvewHOr7WQP Qe/a7fBzyd0Wh4mLnOF7r6fSvwiCTyiky9RKv6d6qpy3HgAMEpMXHJNO+KV5sDIJ+Kgp m0Gg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id c12-20020a630d0c000000b005c6689f9d69si4979066pgl.187.2023.12.05.04.26.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 04:26:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id D509D80A4AD7; Tue, 5 Dec 2023 04:26:48 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235166AbjLEM0i (ORCPT + 99 others); Tue, 5 Dec 2023 07:26:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231888AbjLEM0c (ORCPT ); Tue, 5 Dec 2023 07:26:32 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2783C11F for ; Tue, 5 Dec 2023 04:26:38 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rAUVY-0005Y2-7R; Tue, 05 Dec 2023 13:26:36 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rAUVX-00Djv6-Qq; Tue, 05 Dec 2023 13:26:35 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rAUVX-00EhQu-I2; Tue, 05 Dec 2023 13:26:35 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 6/8] regulator: userspace-consumer: Convert to platform remove callback returning void Date: Tue, 5 Dec 2023 13:26:21 +0100 Message-ID: <89c5f261707bf178e1508cf5dd55121f0da2dc3f.1701778038.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2190; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=A8FP1XBHehjd8UZNqwQtALdNNbXhhXcBzW90wH3+wU0=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlbxbt3vaMkK4LhyfDydpOLGLXDFYQBWohwmjpu 9scuU8+/uOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZW8W7QAKCRCPgPtYfRL+ TtCQB/9nVBvW/kdX4kAi9nIrvM74HxCnyXKpICHcrA/OS3LUZ9JMacf2aFINSrGVRFzqWXY6zbP CxwOkupHvIut6+Rgs5HyxXwT8sF4Dh/KpH5fKZ4/A7oEBEX8FXWauziq8vMAjxavImdQCLsNHd2 w9W+Qb7bBfW/c2SYnFwTyJ0aWamRJwT/ZkiaF7cc8buQs9HXbDSgtG4neFmrW1XSHOlCciPom8o cdPsI8kf4xyVyxY7BFDhtjO8ZnpQitWrMbU0V6Eh1FCtStPSnFDETH8Fig2KLG2+Q/ymECJn8Z+ 3CtO9SueGnykA0xkxN6ahwAQxtoVvNDH7yHz50X7ty0t545p X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 05 Dec 2023 04:26:49 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784444844155346621 X-GMAIL-MSGID: 1784444844155346621 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/regulator/userspace-consumer.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/userspace-consumer.c b/drivers/regulator/userspace-consumer.c index 97f075ed68c9..53d1b9d6f69c 100644 --- a/drivers/regulator/userspace-consumer.c +++ b/drivers/regulator/userspace-consumer.c @@ -194,7 +194,7 @@ static int regulator_userspace_consumer_probe(struct platform_device *pdev) return ret; } -static int regulator_userspace_consumer_remove(struct platform_device *pdev) +static void regulator_userspace_consumer_remove(struct platform_device *pdev) { struct userspace_consumer_data *data = platform_get_drvdata(pdev); @@ -202,8 +202,6 @@ static int regulator_userspace_consumer_remove(struct platform_device *pdev) if (data->enabled && !data->no_autoswitch) regulator_bulk_disable(data->num_supplies, data->supplies); - - return 0; } static const struct of_device_id regulator_userspace_consumer_of_match[] = { @@ -213,7 +211,7 @@ static const struct of_device_id regulator_userspace_consumer_of_match[] = { static struct platform_driver regulator_userspace_consumer_driver = { .probe = regulator_userspace_consumer_probe, - .remove = regulator_userspace_consumer_remove, + .remove_new = regulator_userspace_consumer_remove, .driver = { .name = "reg-userspace-consumer", .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Tue Dec 5 12:26:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 174024 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3391409vqy; Tue, 5 Dec 2023 04:26:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IGynygccoZwB4F+Ff7hoCPnvScgiT29Bj9qYs5RydvW4tP/Y0hph3jr8NHQRL01XDrVOZVj X-Received: by 2002:a17:902:c412:b0:1d0:b6ca:e485 with SMTP id k18-20020a170902c41200b001d0b6cae485mr2331517plk.128.1701779208400; Tue, 05 Dec 2023 04:26:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701779208; cv=none; d=google.com; s=arc-20160816; b=aHsyKMOapRZSDJctn15+rvuKvv9qoL9O4tdIu5ZJQbfY/Odmka9B8R689aOmm2vxnM ENDBbYNpssN0JvhbS3rlXKhgQQrq+pOMXgxym+LzCjfnMVy/YAJTTSveAD8MHTVLu6zi oBfqhhe+m2hXujkzuuLIep60L7av8PhAk1GUj9tOXrjof/NCeYLWcIpKUPJ/gIJYi5G5 4h+3uRNzsOXMmYc0Q8WEEBPXkjCtlEaA8+O6tQMo9mCKkKf4HscSf0QUrgj0patswzT+ PX5k4dKiGT9JMihgrThvw2EHTtFFHS2mfAmeguhmflgbPnoKOS2Vn0rbAEZGoKV48D7w OqBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=NENcXo3LEuAaluIyX7atY27CioG9wbywkjeF/WfJjUY=; fh=SV7jp/N4w5H/WguTuPXZpem2ktA8CMnlzZDNo6r9whw=; b=vbLOQRIxN5uXhDorbHwL9EVNGOYLZ4qsHxvgZ8SQRQvo5BNatgtNxbxqj2Dmu2YpdG A7cYVb1INztzeEEOIKVrzVz4vWhFbIQZtx8QiXAvhEICC/6BYPanCB8X1s301lQ3NJCW lt/pbc2OuGtqMsYHs35zf2yko+Emc6hMO0HWVvaXibHc0FTj9ySyg+n5Teh9Z6YMNWpt R1699EnHGgoSVo4ymZWUCSwKy3QZ88UinvSVzqDzmpoKdpllz6OF+MrD/+RA+qB7jPAj lrTKefVV03zXUvNhabU90J2SkfsEX2IWZUuPJqY3dT9jS7UVMjz97FY0hRBzOCxXynau if2g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id y9-20020a170902b48900b001cffb969691si9217864plr.222.2023.12.05.04.26.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 04:26:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 6A16680C5FA5; Tue, 5 Dec 2023 04:26:47 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235157AbjLEM0g (ORCPT + 99 others); Tue, 5 Dec 2023 07:26:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231897AbjLEM0c (ORCPT ); Tue, 5 Dec 2023 07:26:32 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 655CAC9 for ; Tue, 5 Dec 2023 04:26:38 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rAUVY-0005YB-DY; Tue, 05 Dec 2023 13:26:36 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rAUVY-00Djv9-0j; Tue, 05 Dec 2023 13:26:36 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rAUVX-00EhQy-OG; Tue, 05 Dec 2023 13:26:35 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 7/8] regulator: virtual: Convert to platform remove callback returning void Date: Tue, 5 Dec 2023 13:26:22 +0100 Message-ID: X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1830; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=1OKfIPBeDkKIREgYV7LXbr/0td99Z79KwgLwoughZ/c=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlbxbuOE/46ozZYuwEBtuuizP6Db361dH5Sjxp+ Slow9GJVjeJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZW8W7gAKCRCPgPtYfRL+ TmwIB/wJ6YpQ2ODQNk1jeVFJkg/vHO2WmI6bTHeiE1UEBDv3ANOfLiYCgutRQsfrDuzLocHJtF0 AEs1cdzNB5wQY5HtKvILN9fDWyidpJPwtG3Zygn1MHiEiOjmSsA364LJdS+hviBCGw+Xsa9B0FN zbCqA6olDtPyDCvo2C0Kz6oA3NH9Jlknhxqk03o2q8ayvEoCIvKf7I8uRHOYBuOTxiwRsz9/vrl qVeJhH4DGsPUz9jt36MBGXgfZYIe4PWb/oonaWO2mWv1oxl6FM2lCtHk5cYxViy0kpVtWb0D+YA V00SHr+iaR43hrxfthWVFdCA4uFAJLxNBVwubf0D8mG4w51T X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 05 Dec 2023 04:26:47 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784444835181860963 X-GMAIL-MSGID: 1784444835181860963 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/regulator/virtual.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/virtual.c b/drivers/regulator/virtual.c index d5a160efdae6..0a0ee186c6af 100644 --- a/drivers/regulator/virtual.c +++ b/drivers/regulator/virtual.c @@ -345,7 +345,7 @@ static int regulator_virtual_probe(struct platform_device *pdev) return 0; } -static int regulator_virtual_remove(struct platform_device *pdev) +static void regulator_virtual_remove(struct platform_device *pdev) { struct virtual_consumer_data *drvdata = platform_get_drvdata(pdev); @@ -353,13 +353,11 @@ static int regulator_virtual_remove(struct platform_device *pdev) if (drvdata->enabled) regulator_disable(drvdata->regulator); - - return 0; } static struct platform_driver regulator_virtual_consumer_driver = { .probe = regulator_virtual_probe, - .remove = regulator_virtual_remove, + .remove_new = regulator_virtual_remove, .driver = { .name = "reg-virt-consumer", .probe_type = PROBE_PREFER_ASYNCHRONOUS, From patchwork Tue Dec 5 12:26:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 174026 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3391509vqy; Tue, 5 Dec 2023 04:26:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IEAl2yuLfibPNdf0zdmmFGjxbI6yHpOP+7tDiIc/6UjwJX/pOL3Wi15iQbPoLuZ0yr/sVPl X-Received: by 2002:a05:6a21:32a0:b0:18f:97c:8a29 with SMTP id yt32-20020a056a2132a000b0018f097c8a29mr7095343pzb.84.1701779218923; Tue, 05 Dec 2023 04:26:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701779218; cv=none; d=google.com; s=arc-20160816; b=BcWBk1jY+TAK78lATmFiQDquDMV506yPxMpRo7K4pbMmTopOlgj4QAuchITB/MTFMH CNTA4D2JJRa6pfW4F6ESM5C8On/pjOhCnR3GJQrnbQX9piSbfACXxHJlPD23E56ZzmOx z8ADpompmIyNF4HcsxyEzb6NDhC+n1Ct1YRrRduy1zPMVpdja2yr9QX3H2uO4kVrn1SX KB+6RlJuOrizGGaQHw5WyUSJgHFBJmaxhbSQuOnfJaPemgAMQG9V/YU1NxhtsNG3OGha 4LaExeoPgMIJKQFsH+LhRKo0Iu6LR8cvAukC14TvmJezLI6uJoX7z6bcZGjp23seETG+ jzVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=D5NrSzna7INnsXccytkg94x0324E8SoI5WpimyzuIhk=; fh=+bOS7EAwdGBDNDi3DApgKxJaZ2RNm60AI+OqdQ0si9c=; b=i2Kc4FWP3vML7vwzYM65/zvYwUfWjGbEWhZOiv2doFIzdBU3mc7xqKLMCCd4Mj6KQY f2oZqGVWFln48ZTA2tEQSrWhgUHZcpX5iNO/s1ghF+x3Q7Mf5hvCQpanIX/6+l7ORpW7 LjilKychjY6fyaBImGjRXFw+HoVlD+0HXv5OlzVrM7UkKwvwLrVRujfWXYMMKL/3EVDy wV0myyyOi9kydDUHnMYKOjnBTLwiED1DZhaFz0PeFazlu8rCNeomZTdEuc5/SEEZVv2i 4AnmQdlb5USs6QMftjbqrnF5qj5EkthVYPhscGmf7brgfUZX+vefVW6icBUy6p+tfN4z TNkA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id y21-20020a056a001c9500b006cb7f9ddbd5si250862pfw.321.2023.12.05.04.26.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 04:26:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 072F480C65D2; Tue, 5 Dec 2023 04:26:58 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235163AbjLEM0n (ORCPT + 99 others); Tue, 5 Dec 2023 07:26:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235142AbjLEM0e (ORCPT ); Tue, 5 Dec 2023 07:26:34 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A623C10F for ; Tue, 5 Dec 2023 04:26:40 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rAUVY-0005YU-Jo; Tue, 05 Dec 2023 13:26:36 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rAUVY-00DjvC-6i; Tue, 05 Dec 2023 13:26:36 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rAUVX-00EhR2-U0; Tue, 05 Dec 2023 13:26:35 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Liam Girdwood , Mark Brown Cc: patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 8/8] regulator: wm8350: Convert to platform remove callback returning void Date: Tue, 5 Dec 2023 13:26:23 +0100 Message-ID: <1f7bbc545829a1cc3df40be0424fe46d7449fb72.1701778038.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1929; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=uGW+3kGg7E8CYPUZDYr0vtieqTGUZjfYrj/+nnZMeCo=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlbxbvtvaXAKewk789zdSg231w7Q/drOBpuY49i mOQm03R7/uJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZW8W7wAKCRCPgPtYfRL+ TqJ7CACEozsAbKkt6lOP19XV6OZ6tXJSH5WsUAVOfYvQohvM9BR+HeeUI22qYxq22wpvRnFEzkv SfTf/fyXYiifW7/88tlLg+5UpL6v+GCVQJMRsKJcJ5lvDDZYH7XfOTMz5PqNox/ZIXpgQf2ehRg gPaec0VE41ysvLW/I7AX9DUNbxL1aglPNYOYVzcrZkDviz+K+XDG3686mReIEcrOvpZE8bTapRA uNHH8sxlAug8ssCzBBvxtTLfJb5tkg/n7i9gEChJH6sg2l9CqN3RqlV4dUgzo1wJUJZEQOZlk2a GjHLKwB+BrdzwfT6RT7mnIKrJixUvZ50xBntzjKgnnKLMDPr X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 05 Dec 2023 04:26:58 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784444845748173891 X-GMAIL-MSGID: 1784444845748173891 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Charles Keepax --- drivers/regulator/wm8350-regulator.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/wm8350-regulator.c b/drivers/regulator/wm8350-regulator.c index 1445bafcab40..9939a5d2cbec 100644 --- a/drivers/regulator/wm8350-regulator.c +++ b/drivers/regulator/wm8350-regulator.c @@ -1158,14 +1158,12 @@ static int wm8350_regulator_probe(struct platform_device *pdev) return 0; } -static int wm8350_regulator_remove(struct platform_device *pdev) +static void wm8350_regulator_remove(struct platform_device *pdev) { struct regulator_dev *rdev = platform_get_drvdata(pdev); struct wm8350 *wm8350 = rdev_get_drvdata(rdev); wm8350_free_irq(wm8350, wm8350_reg[pdev->id].irq, rdev); - - return 0; } int wm8350_register_regulator(struct wm8350 *wm8350, int reg, @@ -1306,7 +1304,7 @@ EXPORT_SYMBOL_GPL(wm8350_register_led); static struct platform_driver wm8350_regulator_driver = { .probe = wm8350_regulator_probe, - .remove = wm8350_regulator_remove, + .remove_new = wm8350_regulator_remove, .driver = { .name = "wm8350-regulator", .probe_type = PROBE_PREFER_ASYNCHRONOUS,