From patchwork Tue Aug 30 11:13:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 835 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:ecc5:0:0:0:0:0 with SMTP id s5csp1794839wro; Tue, 30 Aug 2022 04:15:45 -0700 (PDT) X-Google-Smtp-Source: AA6agR5ufcm9lgNxMGnfn4tBCm5BDjwEHy/4eSDI8NW4mijZLnanWMC3e3Ds9DikcO+7C5ri9oXk X-Received: by 2002:a05:6402:25c6:b0:43b:7797:d953 with SMTP id x6-20020a05640225c600b0043b7797d953mr20211819edb.254.1661858145100; Tue, 30 Aug 2022 04:15:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661858145; cv=none; d=google.com; s=arc-20160816; b=c1dX0zmtfjMev/eYB6SJPnBOdDNX0TedYTi56O0DIRDbRPovJxgJWw4i+3WRNK5lUD X6lsHTX1XFKXxGfKwDQukdo02W6/gtN23Dsj1ZXKC72lTtbe8zhhnlqhcuaBouvJI0bp zAMbhOZl+VsUVYgdD2Q+JAlWv/naJ/+MEA14BuoPbLtpzlhpx0oQrgYMdkf6oIvGc7es Kh5MPkQw6qdm4cBB26L7ii5SM339CWU4qgck7A5eZUIFzGR3MXhpV1Z7bArhZ1NcJAJ4 YHV4yOi42idmybX8DrOlDu4xLqYy05v+wWfRrGgkaj83IzR+ip8LV35tero8yxvPJSXP m57g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:sender:errors-to:reply-to:from:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :mime-version:user-agent:subject:to:date:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=LGoai6+mXqFWFZ77N/k6oUd1xZLKvd83o3Qalme3lW0=; b=w3VdMtot2OR7uV1fubg0R6jt56EPw+qb1TrPQcY+KRWuqjOl97L4EH5SoZMY5criWH IMlTs/ovgOIPOupMFdt0xHiOjZIWy8x5RUqSePpuzG3QtXfGwf0dyhK/Ka/I9w6sEk+p fsZcLWF9ttQwJk2loa4Ko+i87IKru3/bzRkIter79BI5gfOkwue0wCZ/0RlGS+2a9HWG fATdVptLEqhKrm7w6QYj/ER3lxEliDKnLyDuVWzcPpODPb7UKxO7fYIJHorPFcJv8W0g 2mC42eQmrKd8vuXLfe+ef6efwsvM1CXZhb1xXz16ggfRLZUGuLE+7bXcBQx2df9NwVMg grOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=KFtYcsst; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id qf37-20020a1709077f2500b0072a6d845d91si9638728ejc.159.2022.08.30.04.15.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Aug 2022 04:15:45 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=KFtYcsst; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 79874383906D for ; Tue, 30 Aug 2022 11:14:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 79874383906D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1661858077; bh=LGoai6+mXqFWFZ77N/k6oUd1xZLKvd83o3Qalme3lW0=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=KFtYcsstHgX/LUBq+Q6vSoIM9jat68dgl6OVZRpfXkwoTa0s0qckpbf8Wm8lQE3Ys TXWaaNm1jfYC2+1dfrVklX6qL0Bp4b8XHOtMP/mdaVdcCKPOTl4MQVeCcINqKcD9pu 7hA7dFeKSJ9ggoKbg3D08X10hpDkNOgHYu3rdx6c= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id A39DB3839058 for ; Tue, 30 Aug 2022 11:13:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A39DB3839058 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id C647C21F99 for ; Tue, 30 Aug 2022 11:13:44 +0000 (UTC) Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id BFF102C141 for ; Tue, 30 Aug 2022 11:13:44 +0000 (UTC) Date: Tue, 30 Aug 2022 11:13:44 +0000 (UTC) To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/67196 - normalize use predicates earlier User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" Message-Id: <20220830111437.79874383906D@sourceware.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1742584566097750046?= X-GMAIL-MSGID: =?utf-8?q?1742584566097750046?= The following makes sure to have use predicates simplified and normalized before doing uninit_analysis::overlap because that otherwise cannot pick up all flag setting cases. This fixes half of the issue in PR67196 and conveniently resolves the XFAIL in gcc.dg/uninit-pred-7_a.c. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/67196 * gimple-predicate-analysis.cc (uninit_analysis::is_use_guarded): Simplify and normalize use prediates before first use. * gcc.dg/uninit-pred-7_a.c: Un-XFAIL. --- gcc/gimple-predicate-analysis.cc | 6 +++--- gcc/testsuite/gcc.dg/uninit-pred-7_a.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gcc/gimple-predicate-analysis.cc b/gcc/gimple-predicate-analysis.cc index ffdd8a15fe7..62a13c39d7a 100644 --- a/gcc/gimple-predicate-analysis.cc +++ b/gcc/gimple-predicate-analysis.cc @@ -2087,6 +2087,9 @@ uninit_analysis::is_use_guarded (gimple *use_stmt, basic_block use_bb, if (!init_use_preds (use_preds, def_bb, use_bb)) return false; + use_preds.simplify (use_stmt, /*is_use=*/true); + use_preds.normalize (use_stmt, /*is_use=*/true); + /* Try to prune the dead incoming phi edges. */ if (!overlap (phi, opnds, visited, use_preds)) { @@ -2106,9 +2109,6 @@ uninit_analysis::is_use_guarded (gimple *use_stmt, basic_block use_bb, m_phi_def_preds.normalize (phi); } - use_preds.simplify (use_stmt, /*is_use=*/true); - use_preds.normalize (use_stmt, /*is_use=*/true); - /* Return true if the predicate guarding the valid definition (i.e., *THIS) is a superset of the predicate guarding the use (i.e., USE_PREDS). */ diff --git a/gcc/testsuite/gcc.dg/uninit-pred-7_a.c b/gcc/testsuite/gcc.dg/uninit-pred-7_a.c index 434d90ac570..c2ba2a4248d 100644 --- a/gcc/testsuite/gcc.dg/uninit-pred-7_a.c +++ b/gcc/testsuite/gcc.dg/uninit-pred-7_a.c @@ -23,7 +23,7 @@ int foo (int n, int l, int m, int r) blah(v); /* { dg-bogus "uninitialized" "bogus warning" } */ if ( l ) - blah(v); /* { dg-bogus "uninitialized" "bogus warning" { xfail *-*-* } } */ + blah(v); /* { dg-bogus "uninitialized" "bogus warning" } */ return 0; }