From patchwork Tue Dec 5 10:52:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 173952 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3344730vqy; Tue, 5 Dec 2023 02:54:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IGUllUhI8QqK1I2IXN9PZ445iLp8xJOBBeGY45r+EqSkna98FOwbfzRV+IeX+TGqKUSUelv X-Received: by 2002:a92:c68f:0:b0:35d:59a2:bea with SMTP id o15-20020a92c68f000000b0035d59a20beamr3454403ilg.128.1701773660669; Tue, 05 Dec 2023 02:54:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701773660; cv=none; d=google.com; s=arc-20160816; b=cz7i7dmfGGwqBvthkRF6sGJHKVbJfRz7pjvfWBEBZCMmIDxdfqk1I8vk9MgJtYEB8t rirnCS2Bz1UGAlbyAZEpD8zuI0B4CXjjTETKMg2DWMkMKE4GvsYx50WWmV121kRsYEYv 57o6bxLER/+rKQ8MOekGuZS17sMM4poElZ7DOlTYwtI1WldwQRSiS++OdHp74OqTXmlG LnZbgG9JLwLo7Ag+ve/qsVLxmCLIXeV5nKcsikvDKNIHN9nMTMCjiTL2cHs6GtYahSM+ LqCUOHbXQlh3DP+lSAxRn1schObpyQvW9dfn3WnWRbRr74fbMqYct9lbIDocOm2ZWRjM rXxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9yGi3UQjgH7vKIKdKQCwE11iHS9JPf1l9kS7cSUyqbg=; fh=yrurfj0wqsNBtuv2/DS7hXM5gjUdNl0RGba7zZuGnHQ=; b=KbttuoRGXalzipHLOIRB6rb+0ydkv2C8FIE2r5UoNKMScjNHJQk3bo+V9vvQxKq41x SM6qEb7xUF5ibX2C/1aX4MW/duI8z851XSzBgkv1K48RF9abM+b1aAURgyiKBDKhnH7d tbNz+E6AYKdKWg/JyhFwCkYkVGGoxvGOlCvLfLup+NV+k8BbLsm2miF6ow64vK82gnMo /LhGQPcRilodr0pKMS8QEynW0vwBeK5Bn/DoWno7EICUP153orhJuiHZ3W4n4OphJNV2 14jiDiqbrMvLkCLNbOXEnDk4YQeEcMuwMnHCKTQqRw7ANwZpfpVmtDHwplRtA4HMLXJR SsVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=my897ijY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id cl3-20020a056a02098300b005be3c09abebsi5332568pgb.225.2023.12.05.02.54.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 02:54:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=my897ijY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id F34FB80A23B0; Tue, 5 Dec 2023 02:54:12 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376591AbjLEKyA (ORCPT + 99 others); Tue, 5 Dec 2023 05:54:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345032AbjLEKx6 (ORCPT ); Tue, 5 Dec 2023 05:53:58 -0500 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16D34113 for ; Tue, 5 Dec 2023 02:54:05 -0800 (PST) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-a1975fe7befso593151366b.2 for ; Tue, 05 Dec 2023 02:54:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1701773643; x=1702378443; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9yGi3UQjgH7vKIKdKQCwE11iHS9JPf1l9kS7cSUyqbg=; b=my897ijY0zxb7MaNHGo/3F01VcJ0zZrWMzeFmWcjnoWg3uYz6ibHBPEd1aDLxNtyya SaRv0nWftCUb2JDRjr8y0FQlpKQIQd6T+VDDjQfHd5C1zFlOu3LRK8Tik9ZwM3lmfinY cDMO+eWQONtsHRonaR0BiZjesTo4HHfqYEK0k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701773643; x=1702378443; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9yGi3UQjgH7vKIKdKQCwE11iHS9JPf1l9kS7cSUyqbg=; b=b8hUWyeMvFW70Z1imyLwa2I/ttr0e7QE6t8NHEbNDGoC/RuG0emSEpTsCrjWJqsv9T nSMZYIDO2ob4qSavY7/8cnrJpHvy+bOMVmdRj8k0sVwR6VzNud5dnk2mAkieuwIcUUez I1UAEtNVSzKJwZWn8Ndvb91SklewHa6zZHp50Ovdf17/Gd8ZaePOEpdbyAmRHKTVypi2 YD89/fFr38BlVZJfKKhkzfQW7uh8Bh/LrOLAmksqnPVj+M5XtChyTx6nm6eokx+Yy6pS QDnrv9IBGkVVqbtfr85xkr3mGJ2VCfbhaV8jJhuB8fQZVv428nH+pqHOKY680I3n/s7l UpZw== X-Gm-Message-State: AOJu0Yxnipn2bUDVVcCnOn7tgEc0iBSaOuVYFaq9o3bXxgbaLpKefciw 5K6LHIXochQJu5+GrL1O3zRquCMTZ4FfGABHNVAogA== X-Received: by 2002:a17:906:2814:b0:a19:a19a:eadc with SMTP id r20-20020a170906281400b00a19a19aeadcmr311534ejc.149.1701773643372; Tue, 05 Dec 2023 02:54:03 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-54-95-129.retail.telecomitalia.it. [82.54.95.129]) by smtp.gmail.com with ESMTPSA id n23-20020a170906089700b0099297782aa9sm6413491eje.49.2023.12.05.02.54.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 02:54:03 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , michael@amarulasolutions.com, Dario Binacchi , Andrzej Hajda , Daniel Vetter , Dave Stevenson , David Airlie , Frieder Schrempf , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Robert Foss , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v4 01/10] drm/bridge: Fix bridge disable logic Date: Tue, 5 Dec 2023 11:52:48 +0100 Message-ID: <20231205105341.4100896-2-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231205105341.4100896-1-dario.binacchi@amarulasolutions.com> References: <20231205105341.4100896-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 05 Dec 2023 02:54:13 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784439017701306549 X-GMAIL-MSGID: 1784439017701306549 As explained by the comment of the fixed code, we need to find the next bridge that hasn't set the "pre_enable_prev_first" flag to true. The code, on the contrary, was doing the opposite. So, the order of disabling the bridges couldn't be altered as required by setting the "pre_enable_prev_first" flag to true. Fixes: 4fb912e5e190 ("drm/bridge: Introduce pre_enable_prev_first to alter bridge init order") Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/gpu/drm/drm_bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index 30d66bee0ec6..f66bf4925dd8 100644 --- a/drivers/gpu/drm/drm_bridge.c +++ b/drivers/gpu/drm/drm_bridge.c @@ -686,7 +686,7 @@ void drm_atomic_bridge_chain_post_disable(struct drm_bridge *bridge, */ list_for_each_entry_from(next, &encoder->bridge_chain, chain_node) { - if (next->pre_enable_prev_first) { + if (!next->pre_enable_prev_first) { next = list_prev_entry(next, chain_node); limit = next; break; From patchwork Tue Dec 5 10:52:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 173953 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3344741vqy; Tue, 5 Dec 2023 02:54:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IHHItgDHzzO1PuRPXA6uhCn8u4+g5jO5fkgPOyU2aWmfOgq8RPzy9+8Iwz2XPNtiiSzSdY6 X-Received: by 2002:a17:902:9302:b0:1d0:91a0:a29 with SMTP id bc2-20020a170902930200b001d091a00a29mr2059207plb.6.1701773662507; Tue, 05 Dec 2023 02:54:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701773662; cv=none; d=google.com; s=arc-20160816; b=uKk11fbO2D5Ypw9ieJhsRac2zgMbRFAezSji28+i61S8NOcHmeovWdySzNoW7t6VJ3 sBMkBGHHvuZBi7Qhj8sXQEBGw5CsP9Y5nEE3UaY+C22xlDupfR8KMQ05MjWc8ixb3h4f lP0289x2LcOL5GND4cfBVWkLiVfyDrT/OaTGfWN71nXrgjGcBUk2lQLqoQj1O6aiyT1h NWVtSjjlrS6gLvRQzdGlm/B6UHF70//D7+9Xra/rKbAZ2v3di2rVuBL+RaGPMNIlhSGz zitcCy/CpFhHngObGh/KK42ZHOPJsVG0s+L+RsboF1/Jv2mTjnRT31BMYtQLVaioNnZH IcLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fu0Px4Tbxip0tKoFWKIyTvbcuMI1IJ2fyAiFtPcJOWc=; fh=yrurfj0wqsNBtuv2/DS7hXM5gjUdNl0RGba7zZuGnHQ=; b=mbvbrZhuvi6XzppftZQ3t38JGaG69Wq2dtCxbYu7+MqJVOZTMaZ51/596ZwsFynYhm 8oJqXhvkXpDVKZJiRbD4PMscuLIP0zUbxRhuhQdMIRWqg/rbL7tmRL7b/LXGK5LIE332 DmUxx7hZp/CXXkbcl6vfgxA1HUmItqyxTKn01D2uCzB30h9WlX+IPBbJg3g9WPPs6FxO hNb3bUAtNIg0zTXWE8ZS3ecgp8G22BfevwHnvXWrqeTWIgb2h7kw+Gyn3pCVxfR4DvRG SXknrf8PFyhvVVRTGJKjN1iPA2wl0Qk2KsxcHNgbCoQ4zYapMJk0rjg4cAhNQ3fLxfte flBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=b8WPXIpg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id x12-20020a170902ea8c00b001cff9cd4d6fsi5592846plb.174.2023.12.05.02.54.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 02:54:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=b8WPXIpg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 415B680E70B1; Tue, 5 Dec 2023 02:54:18 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376680AbjLEKyD (ORCPT + 99 others); Tue, 5 Dec 2023 05:54:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376606AbjLEKyA (ORCPT ); Tue, 5 Dec 2023 05:54:00 -0500 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13E17109 for ; Tue, 5 Dec 2023 02:54:07 -0800 (PST) Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2c9f572c4c5so40939441fa.2 for ; Tue, 05 Dec 2023 02:54:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1701773645; x=1702378445; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fu0Px4Tbxip0tKoFWKIyTvbcuMI1IJ2fyAiFtPcJOWc=; b=b8WPXIpgLqjlmT/oCeG7Bt+qzOSMQ+Urp6mTEYH67oqWB7KgxyrQ/UZbBzMWMoZ50c RerIoC0DV/pO/PViB/q6itggmld6wrBHH3blX+NsXCqBFdinr5VYJ/xQJagDZ8yFAfYA LDms3dqmo5VjM3QUxjzCKS/RuM/1LggQh+TQg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701773645; x=1702378445; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fu0Px4Tbxip0tKoFWKIyTvbcuMI1IJ2fyAiFtPcJOWc=; b=Ou5uDE3gdMAtM+gESEJNO8cK9Em9YZNeFT8CmQuP2uqs34g4glb4hpb744cIXSzYnm lUX4tKeMQQTGV64PPw1rBzjdN+0QAuAOzHidgHx3nGg/zoFGF5ApYx/2KjpxDjpZkaDs 9PJK0dotcu+CMW70W5Jz+JV20uPe//fOOTnS0K54OY2kiby7V1DhLJTkT4pQoMlOmnEp cAw4cIlwB14ZOF+wfP12o+OBi4rF8iKBA3Av5FG7yW1jELQim9plPHmOU3e4rU00tlSP xlI3EqGb+fspVLBRgh7mJxMpmjpHxwJyMaBsuAkOtW3OAs7VqNEafqVPRPsTja2Z4zyT 7z8w== X-Gm-Message-State: AOJu0YwHpi3sOTXyRQVCyQRfHtfwkqUjqt5mhkPz9GEFO3CAGD+CirsO Dmteh+5eGPnbBmAlmngFSK3WO4K0lHbOL14aHxZgrQ== X-Received: by 2002:ac2:4c8c:0:b0:50b:fe3f:8086 with SMTP id d12-20020ac24c8c000000b0050bfe3f8086mr1104607lfl.53.1701773645010; Tue, 05 Dec 2023 02:54:05 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-54-95-129.retail.telecomitalia.it. [82.54.95.129]) by smtp.gmail.com with ESMTPSA id n23-20020a170906089700b0099297782aa9sm6413491eje.49.2023.12.05.02.54.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 02:54:04 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , michael@amarulasolutions.com, Dario Binacchi , Andrzej Hajda , Daniel Vetter , Dave Stevenson , David Airlie , Frieder Schrempf , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Robert Foss , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v4 02/10] drm/bridge: Fix a use case in the bridge disable logic Date: Tue, 5 Dec 2023 11:52:49 +0100 Message-ID: <20231205105341.4100896-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231205105341.4100896-1-dario.binacchi@amarulasolutions.com> References: <20231205105341.4100896-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 05 Dec 2023 02:54:18 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784439019777522816 X-GMAIL-MSGID: 1784439019777522816 The patch fixes the code for finding the next bridge with the "pre_enable_prev_first" flag set to false. In case this condition is not verified, i. e. there is no subsequent bridge with the flag set to false, the whole bridge list is traversed, invalidating the "next" variable. The use of a new iteration variable (i. e. "iter") ensures that the value of the "next" variable is not invalidated. Fixes: 4fb912e5e190 ("drm/bridge: Introduce pre_enable_prev_first to alter bridge init order") Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/gpu/drm/drm_bridge.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index f66bf4925dd8..2e5781bf192e 100644 --- a/drivers/gpu/drm/drm_bridge.c +++ b/drivers/gpu/drm/drm_bridge.c @@ -662,7 +662,7 @@ void drm_atomic_bridge_chain_post_disable(struct drm_bridge *bridge, struct drm_atomic_state *old_state) { struct drm_encoder *encoder; - struct drm_bridge *next, *limit; + struct drm_bridge *iter, *next, *limit; if (!bridge) return; @@ -680,14 +680,15 @@ void drm_atomic_bridge_chain_post_disable(struct drm_bridge *bridge, * was enabled first, so disabled last */ limit = next; + iter = next; /* Find the next bridge that has NOT requested * prev to be enabled first / disabled last */ - list_for_each_entry_from(next, &encoder->bridge_chain, + list_for_each_entry_from(iter, &encoder->bridge_chain, chain_node) { - if (!next->pre_enable_prev_first) { - next = list_prev_entry(next, chain_node); + if (!iter->pre_enable_prev_first) { + next = list_prev_entry(iter, chain_node); limit = next; break; } From patchwork Tue Dec 5 10:52:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 173962 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3344984vqy; Tue, 5 Dec 2023 02:55:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IFO7YJu8aeod7ll1g031hj+99BtQLvXV+QysaikPvzEvEhP3VG17kx92n8Uk8gDFEsVrZic X-Received: by 2002:aa7:9815:0:b0:6ce:4cc8:99db with SMTP id e21-20020aa79815000000b006ce4cc899dbmr656331pfl.66.1701773705671; Tue, 05 Dec 2023 02:55:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701773705; cv=none; d=google.com; s=arc-20160816; b=OCYriTLqsYGhB6lExlT2QfOX+M8fsQfeNBru9zPfIK5t/KlXklttBIq9ZyGWkcv6Um OHeOGAnl1Q76nZJZbUjt2s3oJhe3fgDce0QAcsn2Bw3nWOxc7PaQgoWoz1KkThGYY15e iRCQP5BBdarwsT/p568OPix8PdxSHWz0a1E5brS+2dPuORm0M95HfN8o6mf/AspydHVQ 9je1HipHgEb/JIe5npBBCR0KjaUy4U8uejj4G6xt3FlidGVLtIeuMgfCVf64u6g8LHSd zWEjBZIMxmOvREDQWhL6gao+y5epFwrs80P3jsIazj28tiUZFd8BNEyC0rlDjLfbxAzN Iu5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=3CX2gA6r/dtvGkH0YEYWwI6mzbAd5lMyIJziHnyg55Q=; fh=m6aHy4GVWeiYcahcFfIzqNn3pzsQZUVlVWbThwuybpU=; b=JHuKH4TvBsw2/OQVDVJN5O78zYrScLYkdGtPEJ6rcpz+DfQGCfAdfP7kR8CaPg5C9E u4nXfur5o5FTL8HolY3xKkBhPwXwgrAYGP+LiUAxdYsvAECKZjr/3Soa7B8mekD6IzOF k60/IcjUE+7Rukwlc0+ufpN/+wBDrBf3oUGtJgOdE8A0PtHzzgrZsEVXgduUsC9lCmDs +2dbpbAqwGinEhE7RBfulsZpzKVELE52ATYqDUJmASTQzl+n0V7v9EU06CnQ34m4aun/ dMwUTp6qwl7Bqu+aotdErsizwZsTX+z95p6AkJUcAoISdYbbI9ssXXDT2YSUqSUcdsXj VmYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=QNflQm4n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id fj8-20020a056a003a0800b0069014d63f21si9600559pfb.148.2023.12.05.02.55.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 02:55:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=QNflQm4n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 4896480A28CB; Tue, 5 Dec 2023 02:54:54 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376720AbjLEKyG (ORCPT + 99 others); Tue, 5 Dec 2023 05:54:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346615AbjLEKyC (ORCPT ); Tue, 5 Dec 2023 05:54:02 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E9E811F for ; Tue, 5 Dec 2023 02:54:08 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-40c0e7b8a9bso19134825e9.3 for ; Tue, 05 Dec 2023 02:54:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1701773647; x=1702378447; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3CX2gA6r/dtvGkH0YEYWwI6mzbAd5lMyIJziHnyg55Q=; b=QNflQm4nT2D0Zm1bviJb/L5kCeVHFVlkXRvEIxBzOCwqfqSLtVuXKH7U7vDhkKbcB7 eG5Fo+kZRS3Idr3sjnb9n3bfpKaJ16JcCLYJTh6syPZi8A0ozh4xlt/N/bzivP/k3j7T ZaIAaXMh8IkU+RPpxLXAjPtbTR9L8s7LIB+wg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701773647; x=1702378447; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3CX2gA6r/dtvGkH0YEYWwI6mzbAd5lMyIJziHnyg55Q=; b=bgpwoR+SM+2BoB62TfWTAFXuyGonOyaD89+Z2m5HRUXS3kmbUeu5YdzUTQ6zYPNHHh LiXkfvk6fEVn1a5GMMpbdiWeDEwoYuwMUPvAstxB8niebMM/x/TjwIzuRkw6nUH+cLG1 YySa0Y45VrFlYiyc0/bYM0ggW0S3iFAqLsCIcYhvLYFppygPIrIBeTjgRbRxUxhA97i7 yePW8DX3mVQF8X/RMDNtfxoLFXlRHqGEJSKJhgdSe827cfvDjoJb5JEsY3FIJ9igkItl QTXfBlc4hAfyScLZrypBa7TgCkZPtguaBXl5h2Nukmz7VG8rM42kpqB/ckYx+8ADUOwE tEhg== X-Gm-Message-State: AOJu0YwjZgE+0YPGn/Kp+tTYfLHR1CU+DcBxcuB/MOivlIasf1UUiO2L NklQMbbO1tSLe94Of8DOzEDq5AXtJfMW1e0eS/Q7iA== X-Received: by 2002:a05:600c:18a6:b0:405:3e9a:f1e3 with SMTP id x38-20020a05600c18a600b004053e9af1e3mr354060wmp.11.1701773646681; Tue, 05 Dec 2023 02:54:06 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-54-95-129.retail.telecomitalia.it. [82.54.95.129]) by smtp.gmail.com with ESMTPSA id n23-20020a170906089700b0099297782aa9sm6413491eje.49.2023.12.05.02.54.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 02:54:06 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , michael@amarulasolutions.com, Dario Binacchi , Andrzej Hajda , Daniel Vetter , David Airlie , Inki Dae , Jagan Teki , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Maarten Lankhorst , Marek Szyprowski , Maxime Ripard , Neil Armstrong , Robert Foss , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v4 03/10] drm: bridge: samsung-dsim: enter display mode in the enable() callback Date: Tue, 5 Dec 2023 11:52:50 +0100 Message-ID: <20231205105341.4100896-4-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231205105341.4100896-1-dario.binacchi@amarulasolutions.com> References: <20231205105341.4100896-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 05 Dec 2023 02:54:54 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784439065156193498 X-GMAIL-MSGID: 1784439065156193498 The synaptics-r63353 (panel-bridge) can only be configured in command mode. So, samsung-dsim (bridge) must not be in display mode during the prepare()/unprepare() of the panel-bridge. Setting the "pre_enable_prev_first" flag to true allows the prepare() of the panel-bridge to be called between the pre_enabled() and enabled() of the bridge. So, the bridge can enter display mode only in the enabled(). The unprepare() of the panel-bridge is instead called between the disable() and post_disable() of the bridge. So, the disable() must exit the display mode (i .e. enter command mode) to allow the panel-bridge to receive DSI commands. samsung_dsim_atomic_pre_enable -> command mode r63353_panel_prepare -> send DSI commands samsung_dsim_atomic_enable -> enter display mode samsung_dsim_atomic_disable -> exit display mode (command mode) r63353_panel_unprepare -> send DSI commands samsung_dsim_atomic_post_disable Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/gpu/drm/bridge/samsung-dsim.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index be5914caa17d..15bf05b2bbe4 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -1494,7 +1494,6 @@ static void samsung_dsim_atomic_pre_enable(struct drm_bridge *bridge, return; samsung_dsim_set_display_mode(dsi); - samsung_dsim_set_display_enable(dsi, true); } } @@ -1507,6 +1506,7 @@ static void samsung_dsim_atomic_enable(struct drm_bridge *bridge, samsung_dsim_set_display_mode(dsi); samsung_dsim_set_display_enable(dsi, true); } else { + samsung_dsim_set_display_enable(dsi, true); samsung_dsim_set_stop_state(dsi, false); } @@ -1524,6 +1524,8 @@ static void samsung_dsim_atomic_disable(struct drm_bridge *bridge, if (!samsung_dsim_hw_is_exynos(dsi->plat_data->hw_type)) samsung_dsim_set_stop_state(dsi, true); + samsung_dsim_set_display_enable(dsi, false); + dsi->state &= ~DSIM_STATE_VIDOUT_AVAILABLE; } @@ -1532,7 +1534,8 @@ static void samsung_dsim_atomic_post_disable(struct drm_bridge *bridge, { struct samsung_dsim *dsi = bridge_to_dsi(bridge); - samsung_dsim_set_display_enable(dsi, false); + if (!samsung_dsim_hw_is_exynos(dsi->plat_data->hw_type)) + samsung_dsim_set_stop_state(dsi, true); dsi->state &= ~DSIM_STATE_ENABLED; pm_runtime_put_sync(dsi->dev); From patchwork Tue Dec 5 10:52:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 173956 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3344833vqy; Tue, 5 Dec 2023 02:54:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IGuaM/nPHssnDQi6KG73y0z4F9poLOqwF4BvWlOZlqaJ1sBGhdTrrugENX5Z6R6uqe50oS7 X-Received: by 2002:a17:90b:33c7:b0:286:c5ae:5264 with SMTP id lk7-20020a17090b33c700b00286c5ae5264mr710728pjb.31.1701773680251; Tue, 05 Dec 2023 02:54:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701773680; cv=none; d=google.com; s=arc-20160816; b=oOmx6RcDsX747DU1PhwLVzr9eDHydWf40HuJaVxjNf7wIRjnBPSJ2oDZ/rCCwalWzn 2gIKEuCL2OVE43wrL63wOaleKFEz18f/odr/qazwAcVJQ4l/Dp1FDLAYt6TpU72HGWUx pfZSMUMxcJogOBNoc5BlbC1bzVMC+xsaO/4ni6PJYc385tLkFdYdiQ+wAlyKZ15Bk1mt B7S0jUtU6WAzY8pQOgqnRnLxAA2QOoXOhEOBZUK3032gRElRCGxjbwnBZe3U7bJ5Uo3n eDiA61q+VWV8VavHlD6rUAhOSKzougUcZN4RCpm4g6moAJUHS3MEXpH3LSQDaPrAQcWr wWfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=LRuU/Yf3+WOs2/s3BqHchrpBnPmBNhkaR5Vfu/UBGmU=; fh=m6aHy4GVWeiYcahcFfIzqNn3pzsQZUVlVWbThwuybpU=; b=HJnM5n9iWEs2FCMGH9Wxk0RwjTAdNaYoY/DYPeso4zebQaU7C9pVnXvPA1LGOOr0ge B5Nmi5ypPSgHU6IZM7/ue9GSbD//SRcplnKjKelPeAHcuxHWGMHmtay4eI4Z7SsSa3Cl g+wmudfBNR98gIHkb39UuZR3ASJOEjc2jfpA2pYyB+/c9zBDS72w2acN+IWUCUnQDLks 1+1KAd1TN1H1Tfjsuqrrx5dgLU79jjmV/KoyRcwb8uDJIVYLalrXapgd7cxSI+UuFUmW LJ1fy6ok+TMxeX9scQu7lYVKNrgGBMXUNsEC6hRyYuYacM56oYeFL1/k5zu5wEBCdBxh Rnpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=nieHMYoi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id t4-20020a17090aba8400b00286d14e6342si1644097pjr.184.2023.12.05.02.54.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 02:54:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=nieHMYoi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id EEEB2804B130; Tue, 5 Dec 2023 02:54:35 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376739AbjLEKyI (ORCPT + 99 others); Tue, 5 Dec 2023 05:54:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376686AbjLEKyD (ORCPT ); Tue, 5 Dec 2023 05:54:03 -0500 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E05AF109 for ; Tue, 5 Dec 2023 02:54:09 -0800 (PST) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a1b7b6bf098so337215766b.1 for ; Tue, 05 Dec 2023 02:54:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1701773648; x=1702378448; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LRuU/Yf3+WOs2/s3BqHchrpBnPmBNhkaR5Vfu/UBGmU=; b=nieHMYoiQKcAMQYc6s6FuaHlkX32CGA6i9ms9Xoh0DAUxDlyMw3NxtPwwE4w73ejb0 4qOE/IYeX+eUoreKcWZa6olR1kDpfLDR1ZkeS+3jwwfYpD4ZAqsqSHzuyjurMK4+73W5 3CfnsW1tVa69kv2BGUhasR4F8pkm81gnnS06Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701773648; x=1702378448; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LRuU/Yf3+WOs2/s3BqHchrpBnPmBNhkaR5Vfu/UBGmU=; b=quffvZ959T+7HJaEYAIEsEPagqvQPyI62KPYPJuCNOs5LpGtNLdqQbFK1XQyeyAUrr uHBo51SttgeDx7l3bH5gR5KTm6+Ssc52rQVCMPu1Yf53FP5jW53v388wvMzK9Tz07SAa +fKDzHjosA7sVs2O6rk76cya81eRbKkElt2JzpdERXTFYr1sPdlcAs7mDx5ELams7WFA TYZpJmMyf22dywic9PAhzmz2A6F5fW8xMs9rnWrILZiMJ7FhNUhs7VvT1Xxz2UbCTKFP F7pMyQR0wNYIVBqLQWhixjqvd53m7KPjWf1NEB3zxbQ9Ji0lUSGnpDBSCmJIANtuKpRq C0MQ== X-Gm-Message-State: AOJu0YxHwIsL3MCqcUOuKT7QdrnGh8oBKI8qRo3u6rHFkl+TpJBgMdTG 2fvkDOmEgfamOSBJA/d+fcPUo4r2xNkFR0JDGOs83Q== X-Received: by 2002:a17:906:10c:b0:a1c:f04d:8fb2 with SMTP id 12-20020a170906010c00b00a1cf04d8fb2mr103178eje.58.1701773648268; Tue, 05 Dec 2023 02:54:08 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-54-95-129.retail.telecomitalia.it. [82.54.95.129]) by smtp.gmail.com with ESMTPSA id n23-20020a170906089700b0099297782aa9sm6413491eje.49.2023.12.05.02.54.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 02:54:07 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , michael@amarulasolutions.com, Dario Binacchi , Andrzej Hajda , Daniel Vetter , David Airlie , Inki Dae , Jagan Teki , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Maarten Lankhorst , Marek Szyprowski , Maxime Ripard , Neil Armstrong , Robert Foss , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v4 04/10] drm: bridge: samsung-dsim: complete the CLKLANE_STOP setting Date: Tue, 5 Dec 2023 11:52:51 +0100 Message-ID: <20231205105341.4100896-5-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231205105341.4100896-1-dario.binacchi@amarulasolutions.com> References: <20231205105341.4100896-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 05 Dec 2023 02:54:36 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784439038508083221 X-GMAIL-MSGID: 1784439038508083221 The patch completes the setting of CLKLANE_STOP for the imx8mn and imx8mp platforms (i. e. not exynos). Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/gpu/drm/bridge/samsung-dsim.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index 15bf05b2bbe4..13f181c99d7e 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -96,6 +96,7 @@ #define DSIM_MFLUSH_VS BIT(29) /* This flag is valid only for exynos3250/3472/5260/5430 */ #define DSIM_CLKLANE_STOP BIT(30) +#define DSIM_NON_CONTINUOUS_CLKLANE BIT(31) /* DSIM_ESCMODE */ #define DSIM_TX_TRIGGER_RST BIT(4) @@ -945,8 +946,12 @@ static int samsung_dsim_init_link(struct samsung_dsim *dsi) * power consumption. */ if (driver_data->has_clklane_stop && - dsi->mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) + dsi->mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) { + if (!samsung_dsim_hw_is_exynos(dsi->plat_data->hw_type)) + reg |= DSIM_NON_CONTINUOUS_CLKLANE; + reg |= DSIM_CLKLANE_STOP; + } samsung_dsim_write(dsi, DSIM_CONFIG_REG, reg); lanes_mask = BIT(dsi->lanes) - 1; From patchwork Tue Dec 5 10:52:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 173954 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3344825vqy; Tue, 5 Dec 2023 02:54:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IFyuE/H4vUHMQLQLTMxyubKEyd6ierPiA+ao/+JH3FYIBwIznOfPjMzmyas/gt1pja1bQFO X-Received: by 2002:a17:903:2444:b0:1d0:c6fd:3147 with SMTP id l4-20020a170903244400b001d0c6fd3147mr444886pls.71.1701773679481; Tue, 05 Dec 2023 02:54:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701773679; cv=none; d=google.com; s=arc-20160816; b=P44QB0Xxvce53Mhsj7M/db32vBSaosKM3oFryxf/uym7Uddx9NrKhYE/xJbnieEs2w fxnr0hr8qI6pRdH4kRttHjmlfQW4CzZjpJ7O1c1pypnTwD2H2HSxO/lZd7paeJq8yvfI YPArSkDhhuC0CWmz7vkwL5cF0jLmAOlluS+LlmwIFSDxUn9VuwArR7apoamoPhQeaRV8 cK2o386EhEGC1kzOqU3qxObzFCUMlX5OUL09U72LXJUQUhiTqO/CMS1rumzLH+yd0w8x lCckYgNA7f6lmZ2tGuZfog68i0ceFpLNrSxKZ3sbByddRT/+NEYEQCMfO8w4XrOCldLR llmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9dqXlBbcQt0R29oSjxr4jyi0yptqDX27ArBU37Ndav8=; fh=6zMG0Z8XcspgSxDk55siqf83pNQJKdG1GaqIeIrDDYI=; b=PJ5i/emAa6ZUKGTnKdbtgXNScdtGSRaaV6OhUhw5CiNaNJnDfWNc0umjaCabyVlzj7 8Ur1nWF/K+IR8pQmaADw7sth3XKvtth4exHB6tolAn87/H/KWcpeKt2Kh9tCF22Rf9ZT KTj8IzqN691fiq48Pk1Efj71PgxPXNb9ZR6+s40XDeuvPhND9a7kiJ/r08xZCPRgqzko phdE4kd5nD6xRsoXuCEOMYYOG9r5M3At1Kyt4hF1uFUiAGtOi274fC/Hhu9LJ/PRWa/a s1BcdoVe7CMrX20NMY0jo1HjmE/RBGZHtQ+64nSzqBMgMa2kL4mrBvau7fltQXro1+dY 5YKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=V834Ea7Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id c4-20020a170902b68400b001d0a47b6eddsi3228680pls.615.2023.12.05.02.54.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 02:54:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=V834Ea7Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 681A880A28C9; Tue, 5 Dec 2023 02:54:30 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346804AbjLEKyQ (ORCPT + 99 others); Tue, 5 Dec 2023 05:54:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376695AbjLEKyN (ORCPT ); Tue, 5 Dec 2023 05:54:13 -0500 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B2BF185 for ; Tue, 5 Dec 2023 02:54:11 -0800 (PST) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a1b54b58769so308470166b.0 for ; Tue, 05 Dec 2023 02:54:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1701773650; x=1702378450; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9dqXlBbcQt0R29oSjxr4jyi0yptqDX27ArBU37Ndav8=; b=V834Ea7QEbLlDANziHtk630zx0eRLG0UP6thG/Ol60r+zCahKGto37Macv1nsiLTf3 J05EagMkC6i+vXw/ZE6mdJo5ZjJtt5nmNUja7XBKyRIeU/0TebodD/gfLIBtSjoa6dqh 6gbgcMrT0G7WjHdckuQhZ3FesCgf0WYkB1EbQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701773650; x=1702378450; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9dqXlBbcQt0R29oSjxr4jyi0yptqDX27ArBU37Ndav8=; b=koqI3guLqXE0/GcscEiKcocDKGcFUGnwG5laAH7hJLtOAJQFIYhF81Wn/gpeIRzEKf mQb62kPfJD89JNStXGQcJyKZM95ZB5MK1mKmFzXOKKIm72VrLD86JLsZuBV2o39/qZZN T//lEQ4qvRF3TdHCR8DqJixe+rSwtqdBaYzPdjiNN3lHs/bWq6kmO35/BNy10QSHcDqv D9qw8XLqlheiHY5L5awwtcIKNUiVcKcpcNjvYFluMbITF+UJ4V1I11C2FS/caatIWjIT Hd5xNoGIqpv94jCbEQ15IGAFerP9O5BtB180rxFP5ndYFr+X1LwKBmWyncAm7ro1j1TF wT4g== X-Gm-Message-State: AOJu0Yy2NZ/7oPHcqUmSqsa+PgPoD+qK0yxXvCUIq/sX6FJdbCmkF2WW 3TZz/uzRdVlFpFhe1qbP8yJpUMpym6ft6Vo+tNksog== X-Received: by 2002:a17:906:cc96:b0:a17:781f:20bf with SMTP id oq22-20020a170906cc9600b00a17781f20bfmr337719ejb.6.1701773649822; Tue, 05 Dec 2023 02:54:09 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-54-95-129.retail.telecomitalia.it. [82.54.95.129]) by smtp.gmail.com with ESMTPSA id n23-20020a170906089700b0099297782aa9sm6413491eje.49.2023.12.05.02.54.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 02:54:09 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , michael@amarulasolutions.com, Dario Binacchi , Krzysztof Kozlowski , Conor Dooley , Daniel Vetter , David Airlie , Jessica Zhang , Krzysztof Kozlowski , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Rob Herring , Sam Ravnborg , Thomas Zimmermann , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH v4 05/10] dt-bindings: display: panel: Add synaptics r63353 panel controller Date: Tue, 5 Dec 2023 11:52:52 +0100 Message-ID: <20231205105341.4100896-6-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231205105341.4100896-1-dario.binacchi@amarulasolutions.com> References: <20231205105341.4100896-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 05 Dec 2023 02:54:30 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784439037360641097 X-GMAIL-MSGID: 1784439037360641097 From: Michael Trimarchi Add documentation for "synaptics,r63353" panel. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi Reviewed-by: Krzysztof Kozlowski --- (no changes since v3) Changes in v3: - Add 'Reviewed-by' tag of Krzysztof Kozlowski. - Replace "synaptics,r63353" compatible with "syna,r63353", as required by vendor-prefixes.yaml. Changes in v2: - Add $ref to panel-common.yaml - Drop port, reset-gpios, and backlight - Set port and backlight ad required - Replace additionalProperties with unevaluatedProperties .../display/panel/synaptics,r63353.yaml | 61 +++++++++++++++++++ 1 file changed, 61 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/synaptics,r63353.yaml diff --git a/Documentation/devicetree/bindings/display/panel/synaptics,r63353.yaml b/Documentation/devicetree/bindings/display/panel/synaptics,r63353.yaml new file mode 100644 index 000000000000..e5617d125567 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/synaptics,r63353.yaml @@ -0,0 +1,61 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/synaptics,r63353.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Synaptics R63353 based MIPI-DSI panels + +maintainers: + - Michael Trimarchi + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + items: + - enum: + - sharp,ls068b3sx02 + - const: syna,r63353 + + avdd-supply: true + dvdd-supply: true + reg: true + +required: + - compatible + - avdd-supply + - dvdd-supply + - reg + - reset-gpios + - port + - backlight + +unevaluatedProperties: false + +examples: + - | + #include + + dsi { + #address-cells = <1>; + #size-cells = <0>; + + panel@0 { + compatible = "sharp,ls068b3sx02", "syna,r63353"; + reg = <0>; + avdd-supply = <&avdd_display>; + dvdd-supply = <&dvdd_display>; + reset-gpios = <&r_pio 0 5 GPIO_ACTIVE_LOW>; /* PL05 */ + backlight = <&backlight>; + + port { + panel_in: endpoint { + remote-endpoint = <&mipi_dsi_out>; + }; + }; + }; + }; + +... From patchwork Tue Dec 5 10:52:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 173961 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3344940vqy; Tue, 5 Dec 2023 02:54:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IFNoZXXNSI+3m1NsfkmotvfiE90wfR6uCefKEH/rGQHl1jeJeh4QPon+42Q/WQRrRYYQfpM X-Received: by 2002:a05:6a20:729e:b0:18b:826e:e611 with SMTP id o30-20020a056a20729e00b0018b826ee611mr3548678pzk.40.1701773697740; Tue, 05 Dec 2023 02:54:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701773697; cv=none; d=google.com; s=arc-20160816; b=fzttrlf5miYrFL2Y2xrbWq1RE2SE0TIjpIlxS3YwQYW7gR1esuMA3rjqRnD63eN/11 4cS7kcpDOIiOFd+2FOc4ZjEw/a2BSciSQyIxtwxsyXrsLzWzXsANKKYcHlMYGudhvw9D LbeJjidy5w89LCylFsQuio2M+aYeUBzGVinVD/m0Jrv1J/3Pt+lGHAlz9Kav58fw8NxF 3W2yBoDFbs9gYRmCn/bNtOiaB8FpbtJ4ay9ZcgNTCeezC504afkinYYNlViLVeA7W4lS DT9t+JskJSyU1/POSTF5WKHe4/8ziWz46+VBaYtaFl1zxKFwHvkBlB8+aPvic258E4JX Do8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=wSNU+Jq9XEvjoSdX9cIvuPipP71yJs5/klp+ZtYxSM8=; fh=YMCpMfj2GNScjLvWYsHyWUGLqrAoIyNb9XBc8eC5U/M=; b=Bh3BgXmvJZ1FBCzbqzfPAkC1sQRhrDbh2OjYTeODDKDTlM/Uvpf5cgEZkCDteqO1mS q8wCOnWZY4Eq02feHLusOQWHn2QTuNsihtj/rFkvBt3zVLgVsi9ZzfiNN1nvdfyK+Z4K X15oC6nVgya/azUORistbpy9btJWttyGpDi/+NhAcS5EtUH2DUZNVrl5ituICR4QZMqw T75mT/6X85ikGsIUMWy1BuBba5Un8rMQVE+50kAEn+tRtEKT+OnZT1ayLduxUr2mzRUS wTCXmlBG++8ugCEVyo27Q0a5ic/f5mJBEvTdr3fEemsjREoja4UJ2tC18mLFCB+Ng25n BZug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=JksvFYGs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id r65-20020a17090a43c700b002866d97048asi5691841pjg.114.2023.12.05.02.54.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 02:54:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=JksvFYGs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id EF1CF80EFC4D; Tue, 5 Dec 2023 02:54:51 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376771AbjLEKyU (ORCPT + 99 others); Tue, 5 Dec 2023 05:54:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376795AbjLEKyP (ORCPT ); Tue, 5 Dec 2023 05:54:15 -0500 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36DA418F for ; Tue, 5 Dec 2023 02:54:13 -0800 (PST) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-9fa2714e828so726819866b.1 for ; Tue, 05 Dec 2023 02:54:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1701773651; x=1702378451; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wSNU+Jq9XEvjoSdX9cIvuPipP71yJs5/klp+ZtYxSM8=; b=JksvFYGs2BLB8S8nan/x2UbMkoFw0WFfaBMAHCZT6Eq4iVTwZ1280ERxfxcnQVa99B ImIUUYnCd9YYNvkHqKQSYOZ9AYyQ/l2c6BcfulWvJvU7StMsms1+BayZHZkihUTdh1DM e37hTiGTt6ovqkRzw8cG667JclcAelO2pQZ+s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701773651; x=1702378451; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wSNU+Jq9XEvjoSdX9cIvuPipP71yJs5/klp+ZtYxSM8=; b=tVRJismloao1k7NRJND4Sm0W25WDq5DjDyAQx8di8ZJ+cvElGO8CiBdE2p461RtL4N bB7fHSWzPKXShQFmQeeb0ScAvmu1XCJKeWBk2IwfiWojO0+Vl94WXzvCIlTALdbqn92n MrUL97+M9Hq7Cyt3kegKz+c/v51ct8gZGPL98fjXICun5Dp5mtcF2TMeB2SLmDsRjIFJ dGUMvdy+A61RLuUEnMnqg4r2KuU69i3dxkQIiqcOlQLPA4Z1RzuUWfGmq6OHyfuvXquz apkbbmGOG0+cLFfxT5MtNmexBCyj90YKYRfzGyu6yG1eJzwu4xEHn1LWpdA5Pt41dkrh DS8A== X-Gm-Message-State: AOJu0YycwX1v01Rp5hrvc96A5WHsmI0xpItydrZQdUaIU4K4e7/0oJ2k OC5zaYamIfqxnlVXAMhgLWlvUbWtY37Yvk5Jtpiu/A== X-Received: by 2002:a17:906:4e5a:b0:a19:a19b:55cf with SMTP id g26-20020a1709064e5a00b00a19a19b55cfmr349594ejw.95.1701773651235; Tue, 05 Dec 2023 02:54:11 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-54-95-129.retail.telecomitalia.it. [82.54.95.129]) by smtp.gmail.com with ESMTPSA id n23-20020a170906089700b0099297782aa9sm6413491eje.49.2023.12.05.02.54.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 02:54:10 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , michael@amarulasolutions.com, Dario Binacchi , Daniel Vetter , David Airlie , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Sam Ravnborg , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v4 06/10] drm/panel: Add Synaptics R63353 panel driver Date: Tue, 5 Dec 2023 11:52:53 +0100 Message-ID: <20231205105341.4100896-7-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231205105341.4100896-1-dario.binacchi@amarulasolutions.com> References: <20231205105341.4100896-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 05 Dec 2023 02:54:52 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784439056881324586 X-GMAIL-MSGID: 1784439056881324586 From: Michael Trimarchi The LS068B3SX02 panel is based on the Synaptics R63353 Controller. Add a driver for it. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- Changes in v4: - Set the reset gpio to low in a single operation - Remove duplicated code for prepare/unprepare callbacks Changes in v2: - Adjust the timings of the panel reset MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + .../gpu/drm/panel/panel-synaptics-r63353.c | 363 ++++++++++++++++++ 4 files changed, 379 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-synaptics-r63353.c diff --git a/MAINTAINERS b/MAINTAINERS index 788be9ab5b73..b82dc141d209 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6874,6 +6874,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc F: Documentation/devicetree/bindings/display/ste,mcde.yaml F: drivers/gpu/drm/mcde/ +DRM DRIVER FOR SYNAPTICS R63353 PANELS +M: Michael Trimarchi +S: Maintained +F: Documentation/devicetree/bindings/display/panel/synaptics,r63353.yaml +F: drivers/gpu/drm/panel/panel-synaptics-r63353.c + DRM DRIVER FOR TI DLPC3433 MIPI DSI TO DMD BRIDGE M: Jagan Teki S: Maintained diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 99e14dc212ec..d018702be3dc 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -735,6 +735,15 @@ config DRM_PANEL_SITRONIX_ST7789V Say Y here if you want to enable support for the Sitronix ST7789V controller for 240x320 LCD panels +config DRM_PANEL_SYNAPTICS_R63353 + tristate "Synaptics R63353-based panels" + depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE + help + Say Y if you want to enable support for panels based on the + Synaptics R63353 controller. + config DRM_PANEL_SONY_ACX565AKM tristate "Sony ACX565AKM panel" depends on GPIOLIB && OF && SPI diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index d10c3de51c6d..f267d932c2b5 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -74,6 +74,7 @@ obj-$(CONFIG_DRM_PANEL_SHARP_LS060T1SX01) += panel-sharp-ls060t1sx01.o obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7701) += panel-sitronix-st7701.o obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7703) += panel-sitronix-st7703.o obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7789V) += panel-sitronix-st7789v.o +obj-$(CONFIG_DRM_PANEL_SYNAPTICS_R63353) += panel-synaptics-r63353.o obj-$(CONFIG_DRM_PANEL_SONY_ACX565AKM) += panel-sony-acx565akm.o obj-$(CONFIG_DRM_PANEL_SONY_TD4353_JDI) += panel-sony-td4353-jdi.o obj-$(CONFIG_DRM_PANEL_SONY_TULIP_TRULY_NT35521) += panel-sony-tulip-truly-nt35521.o diff --git a/drivers/gpu/drm/panel/panel-synaptics-r63353.c b/drivers/gpu/drm/panel/panel-synaptics-r63353.c new file mode 100644 index 000000000000..0a3c2a3d5998 --- /dev/null +++ b/drivers/gpu/drm/panel/panel-synaptics-r63353.c @@ -0,0 +1,363 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Synaptics R63353 Controller driver + * + * Copyright (C) 2020 BSH Hausgerate GmbH + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include + +#include +#include +#include + +#include