From patchwork Tue Dec 5 07:17:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hao Ge X-Patchwork-Id: 173755 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp3260105vqy; Mon, 4 Dec 2023 23:18:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IHKXo3taN6rkLqnU259afmJXWM/AL+y+hwtI7rUdK2ZCHoTM7gNmFjGBzfQP25VyGmv4q25 X-Received: by 2002:a92:870b:0:b0:35c:8f50:acd3 with SMTP id m11-20020a92870b000000b0035c8f50acd3mr6975175ild.18.1701760688781; Mon, 04 Dec 2023 23:18:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701760688; cv=none; d=google.com; s=arc-20160816; b=FVCBSNWaDOA8sl6yxiHkUrl4j4wMnyNYzuL52dKXekE3IOTMBry6ypMXlU2klQ6y/U hEgTobEkvpWAgaT2Okc4bfHo8hjHloUgEMKJyBk15HE+kX0kWHxmfWmvFBii+i0mBl1Y /s7/kI/h4C9YP/QVABF6oOadIx5EjQ18ZyeYMZbse5/nJ8Wjs2BxzfRYRUFOwyyBQw0R /rgRPTnrDfeVOktifZnL2RtXJzcLd8NXqTAwXo8SldEhfXB2vr3jydYHTP/8S37zLgVH 4ecVvfHYo6UPRoyBZfjng+RXd8i1Tp0M2hvw1gVgAw6FPmwCpAiR9tTuV1tFI6LDHmnW S1YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=cG5D9aRfWnD1ZO/9Gao5RDSuOs2N866RiPagDGIi/zw=; fh=VSUMJQsCNay8jimRTr0Lw5WsiXNxkITOCloOFkOAhGg=; b=DrreYpIC8l6xc+iNESESdsWNPUw9dRj4mZSuI7N8ulQXCj7uJlbMpsOjO2wXfmeUMf vxqUDKeE7vHOW2fSTlN2nwAMfD8DmB+9JWb94EDBNE16qLYeve3fe59X/FH8qZf39E3O ZHbEIxSU22DU1vNlEDf73wDFzZ9JNX9hcHAY9Su9sxKAxyzJcwiRQFF9JwLtLld7dMZG Y2I6NNDjMEGio6CN+zlWZ3JX2o5inJ1D6l3sJc0odjAEifrt0JzvrTQaYmgMq2UzJMC5 56sthw7+xI2Mw/AhblijpN1fR+nWrFka5XwkzFSd/pF10UAxWsjXg64zG4U5nqe20BPq 4kCQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id h3-20020a636c03000000b005c1f51c706bsi8742893pgc.599.2023.12.04.23.18.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 23:18:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 7D0738048C26; Mon, 4 Dec 2023 23:18:06 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344557AbjLEHRs (ORCPT + 99 others); Tue, 5 Dec 2023 02:17:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344545AbjLEHRr (ORCPT ); Tue, 5 Dec 2023 02:17:47 -0500 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D02C2120; Mon, 4 Dec 2023 23:17:51 -0800 (PST) X-UUID: 72c259b530ca412d990ed16bea96c82a-20231205 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.33,REQID:37ff4f08-ae8f-4c00-be1f-4934fa865b46,IP:20, URL:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:5 X-CID-INFO: VERSION:1.1.33,REQID:37ff4f08-ae8f-4c00-be1f-4934fa865b46,IP:20,UR L:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:5 X-CID-META: VersionHash:364b77b,CLOUDID:cf802996-10ce-4e4b-85c2-c9b5229ff92b,B ulkID:231205151737ZPV80MR5,BulkQuantity:0,Recheck:0,SF:38|24|17|19|44|66|1 02,TC:nil,Content:0,EDM:-3,IP:-2,URL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,CO L:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-UUID: 72c259b530ca412d990ed16bea96c82a-20231205 X-User: gehao@kylinos.cn Received: from localhost.localdomain [(116.128.244.171)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 554557348; Tue, 05 Dec 2023 15:17:36 +0800 From: Hao Ge To: viro@zeniv.linux.org.uk, brauner@kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, gehao618@163.com, Hao Ge Subject: [PATCH] fs/namei: Don't update atime when some errors occur in get_link Date: Tue, 5 Dec 2023 15:17:33 +0800 Message-Id: <20231205071733.334474-1-gehao@kylinos.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 04 Dec 2023 23:18:06 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784425415994138031 X-GMAIL-MSGID: 1784425415994138031 Perhaps we have some errors occur(like security),then we don't update atime,because we didn't actually access it Signed-off-by: Hao Ge --- fs/namei.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/fs/namei.c b/fs/namei.c index 71c13b2990b4..033d36d5c1c5 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -1779,15 +1779,6 @@ static const char *pick_link(struct nameidata *nd, struct path *link, unlikely(link->mnt->mnt_flags & MNT_NOSYMFOLLOW)) return ERR_PTR(-ELOOP); - if (!(nd->flags & LOOKUP_RCU)) { - touch_atime(&last->link); - cond_resched(); - } else if (atime_needs_update(&last->link, inode)) { - if (!try_to_unlazy(nd)) - return ERR_PTR(-ECHILD); - touch_atime(&last->link); - } - error = security_inode_follow_link(link->dentry, inode, nd->flags & LOOKUP_RCU); if (unlikely(error)) @@ -1810,6 +1801,16 @@ static const char *pick_link(struct nameidata *nd, struct path *link, if (IS_ERR(res)) return res; } + + if (!(nd->flags & LOOKUP_RCU)) { + touch_atime(&last->link); + cond_resched(); + } else if (atime_needs_update(&last->link, inode)) { + if (!try_to_unlazy(nd)) + return ERR_PTR(-ECHILD); + touch_atime(&last->link); + } + if (*res == '/') { error = nd_jump_root(nd); if (unlikely(error))