From patchwork Mon Dec 4 17:01:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 173463 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp2898457vqy; Mon, 4 Dec 2023 09:01:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IEVQUDTxgcmehnTbFfNgnnbRddJZik7V7KvTNnFMryVgM2cQJ4VQXbSLUFJcYDti4xJ3So6 X-Received: by 2002:a05:6a20:938b:b0:18b:ec94:deed with SMTP id x11-20020a056a20938b00b0018bec94deedmr1675072pzh.45.1701709294136; Mon, 04 Dec 2023 09:01:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701709294; cv=none; d=google.com; s=arc-20160816; b=0kAnlqXOBKzA/tKUWX0WPJRQAM2+eGxGd2yqTXoPoZeStiN/+A21hqNlztFh25iG8/ BseGATrr6UkZUJ37h2z8ll11j6lmjUxKLKvuw/MMX0V/LfYIp8XWCPGjQpEoq/3u5Hqm y3bv7T+zvaip1o8z+5l0oVGYQCIUr5dlz7olyqYx24IpHP7r2Rk3Tyazchlobeak/r/U eyiD6ZqrMy5elpcFQJ9rky53ml3yHjYcR23+Ngbt5Ftzo20jAFInuSyb0W8aA2RuqW+y dOgbESmKNIXg1VMciwbBfuP9TnbQB3zWkr+bfBlsbEld6tYnsz4J+1xybb5NntIQ8Ix5 sQoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=1yw+mkzZ8WSThgOMrf0SaKscIOkk2RXSkarx/JDgGcE=; fh=6PrN+MackKfYei1ahlNe+U4ZFyle1OFOC5goKGbUhgA=; b=dkDFauc9qgLgqJrlxNUsc0tMuQONsShFtcAlsBpgyNRXm/tBc6SJZqy/VmgsJlCGT5 Hs1rxrjggsSCZ1BiAkjfMHC8+hHlE+H7reOShGQzXo4VHQUBmf1rbnckQDt/HGAspajN mhcRdwwIy+WA1exmsc5Ukdl/eyl9NShYKJDkd3pE36QBq6Gg/zZ4aQohuTlJblCG1uEE n/TZ561U1gtyQIVmUgX7laveKqW8pspAe1FbX+3TifibJN3GqTH2TsHAGmSa/td1N1eS IwJ2IzKZdWSS6uBM523sEfjj/4IqoKodVEEerexYPfERdhnOZtt1kqwXfpafjx09Gqs5 Ah7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iGvBZLtY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id fh19-20020a056a00391300b0068e2d888713si8055501pfb.167.2023.12.04.09.01.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 09:01:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iGvBZLtY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 04B65804C66F; Mon, 4 Dec 2023 09:01:26 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229561AbjLDRBG (ORCPT + 99 others); Mon, 4 Dec 2023 12:01:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230208AbjLDRBD (ORCPT ); Mon, 4 Dec 2023 12:01:03 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB4E8CA for ; Mon, 4 Dec 2023 09:01:09 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F5F8C433C7; Mon, 4 Dec 2023 17:01:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701709269; bh=PrQN3LxsLo0hnYtX+mHxOw3BE7UQ018hcELFYEAwoxQ=; h=From:To:Cc:Subject:Date:From; b=iGvBZLtYs7yHtlLTahRlEyaMg77PkPNKCUnY79j+4a+CQ0rzo/s8oWQILhuPdvPah DXg32bDyS/S+oRwZ/rTx+ePKScRNqgIcPlsFAlXdMrwxfzGqc/48qdxze/hx9zZHv4 FfghEKC/+5gGgaUZUYSWaVNMcBHvC9WDKTVAyXUxCVQle9dgrLwZnKVMwRjumzvyKy HbwQ/G80otDrUBS13rwTJK+5hCsXWO8VYjkXJ2AmSvqeNrKo26vG+Mbn2ej+ak+6lJ PbYedmzbC9cXA0f/a4J9cx2Kos0QLDzgLekg7WZItSI4QvlSTYhLxm1CwwCc8yiVcC BIrLl4SrYaj5Q== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Stephen Rothwell , damon@lists.linux.dev, linux-mm@kvack.org, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH mm-unstable] mm/damon: document get_score_arg field of struct damos_quota Date: Mon, 4 Dec 2023 17:01:06 +0000 Message-Id: <20231204170106.60992-1-sj@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 04 Dec 2023 09:01:26 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784371525122152830 X-GMAIL-MSGID: 1784371525122152830 Commit 99b36eab9c05 ("mm/damon/core: implement goal-oriented feedback-driven quota auto-tuning") on mm-unstable missed documenting 'get_score_arg' field of 'struct damos_quota' on the kernel-doc comment. Fix it. Fixes: 99b36eab9c05 ("mm/damon/core: implement goal-oriented feedback-driven quota auto-tuning") on mm-unstable Signed-off-by: SeongJae Park --- include/linux/damon.h | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index 508a262418a2..aa34ab433bc5 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -137,6 +137,7 @@ enum damos_action { * @weight_age: Weight of the region's age for prioritization. * * @get_score: Feedback function for self-tuning quota. + * @get_score_arg: Parameter for @get_score * * To avoid consuming too much CPU time or IO resources for applying the * &struct damos->action to large memory, DAMON allows users to set time and/or @@ -156,10 +157,10 @@ enum damos_action { * &weight_nr_accesses, and &weight_age, because monitoring operations are * encouraged to respect those. * - * If @get_score function pointer is set, DAMON calls it back and get the - * return value of it for every @reset_interval. Then, DAMON adjusts the - * effective quota using the return value as a feedback score to the current - * quota, using its internal feedback loop algorithm. + * If @get_score function pointer is set, DAMON calls it back with + * @get_score_arg and get the return value of it for every @reset_interval. + * Then, DAMON adjusts the effective quota using the return value as a feedback + * score to the current quota, using its internal feedback loop algorithm. * * The feedback loop algorithem assumes the quota input and the feedback score * output are in a positive proportional relationship, and the goal of the