From patchwork Mon Dec 4 15:56:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 173453 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp2861004vqy; Mon, 4 Dec 2023 08:02:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IFUfKY50I9h/NzTxu8pJHoNcZ1eMYi1FOVN4AZdDZsktnfinme6IxB5CocCC84u2KDHa6kS X-Received: by 2002:a17:902:ea06:b0:1d0:b139:2c8b with SMTP id s6-20020a170902ea0600b001d0b1392c8bmr1177898plg.15.1701705779511; Mon, 04 Dec 2023 08:02:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701705779; cv=none; d=google.com; s=arc-20160816; b=bG7E+mHRCozgCS8X+36HwBjA4LhArp7BZDd2eHDHbIAxHkaJLQ86y4Vv3TtFTKwHSA SLM/bRWDNvOKdwS4OS1i50I9k/PF86EbYswYqb7UlVyE/o7CcqfcPE3rjgG5eNM5mOkf HJr85Gses7BElNWYq5NTrC0nAMloykDiwIhQt/kTZYLzeW0Lfnitgpt50WozxyQi+XaX N1w11zypTCym9gWpKnA6sKH9hIuGuTREREkXLdTKbVq5R/fKJOLFsLz31BW5yk7w/66P AhGN45hC4qAfTIt1oanLrCjLsFkDPjNUrp542Qq4Az4NmUCay4R2IZIHegixIz5RyQ9r ggJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7zgdmuCW7K1LG3mDqjKSlI+CNXZbDMbwE86Bifysuww=; fh=bb00IWANzUrbEims5abAG2NrFRW6cV0KBtrUyXvAr8o=; b=pwVb9wyha1k0ZW7Oa8eOfMjjOquWCvFp+OL87O4bwdE3S8hclJbzIMHoQnAHumgfN7 odbhTMotXGTlwxPblvyqozkn6DhAGP4w0iYe27lN51ymX3uSE68zjQtNDAYx9OSyyImv nHuTLVnmvqCVTZHp4bYG2N7qPldFXJ8sZFvxZ4aGFrTUuBUXyRnEs0oXHhW3i1FfG0T6 /5CBa35Wqr/r62y94d8Ggfk59dRUJYSYxRYIGZrCfAvGafpbNkxYhNg3qf1fq7KUzsDR 1o/fFvIPRfzkKm+lTZgWAZypFiEkeHjrpsT09TDd7krbj6VBm9zr2k3Li+Xr1n72GZD8 hATQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=bkMbRs1U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id x13-20020a170902ea8d00b001ca96a6eefesi5590788plb.577.2023.12.04.08.02.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 08:02:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=bkMbRs1U; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id B4D6480411A7; Mon, 4 Dec 2023 08:02:42 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343869AbjLDQCW (ORCPT + 99 others); Mon, 4 Dec 2023 11:02:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234633AbjLDQCU (ORCPT ); Mon, 4 Dec 2023 11:02:20 -0500 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4FA783; Mon, 4 Dec 2023 08:02:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701705747; x=1733241747; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=369hT2RdaeQdkkRIYwcHHDkywQmjX9HmaXJZaM+vdg4=; b=bkMbRs1UH2vRg8FNuswtjS7nggOZIIhSmU88yvQb1FJWVKqmdl6MbtWx 1wLgXNTELjyJFfouBmEybAmRfjYi3BbvyZkkLYdJx/NVSqbSB1HuNrVAl CI0QsCfr7zwhK9V1rwFlR3KQ3NwQHkxZfpfUAYuhYe2Xci5iEHVHpFiAQ Bk1YibZWI2zRvv3bvwtM3vvuncwyjDuUUgFtm5QAmgIAC+OTnhHPbR98s weWRjGeE7ETn3M4LPbCkcJLMhtKdszEzivYV9zdFCwXOwLvXeqGqzX3xL lYLpJbufsZL0F/C5wNVVv5sK9pPO8JyDnXMpzbtiO/1s8xrFCWXXtiiUW w==; X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="807859" X-IronPort-AV: E=Sophos;i="6.04,250,1695711600"; d="scan'208";a="807859" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 08:00:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="774297197" X-IronPort-AV: E=Sophos;i="6.04,250,1695711600"; d="scan'208";a="774297197" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga007.fm.intel.com with ESMTP; 04 Dec 2023 08:00:44 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 02DB6315; Mon, 4 Dec 2023 18:00:42 +0200 (EET) From: Andy Shevchenko To: Linus Walleij , Andy Shevchenko , =?utf-8?q?Jonathan_Neu?= =?utf-8?q?sch=C3=A4fer?= , Geert Uytterhoeven , Claudiu Beznea , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, linux-renesas-soc@vger.kernel.org Cc: Lakshmi Sowjanya D Subject: [PATCH v1 1/5] pinctrl: renesas: Mark local variable with const in ->set_mux() Date: Mon, 4 Dec 2023 17:56:32 +0200 Message-ID: <20231204160033.1872569-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20231204160033.1872569-1-andriy.shevchenko@linux.intel.com> References: <20231204160033.1872569-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 04 Dec 2023 08:02:42 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784367839621838330 X-GMAIL-MSGID: 1784367839621838330 We are not going to change pins in the ->set_mux() callback. Mark the local variable with a const qualifier. While at it, make it also unsigned. Signed-off-by: Andy Shevchenko Reviewed-by: Geert Uytterhoeven Acked-by: Geert Uytterhoeven --- drivers/pinctrl/renesas/pinctrl-rzg2l.c | 2 +- drivers/pinctrl/renesas/pinctrl-rzv2m.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c index aed59c53207c..68fcc2a4efbc 100644 --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c @@ -273,7 +273,7 @@ static int rzg2l_pinctrl_set_mux(struct pinctrl_dev *pctldev, struct function_desc *func; unsigned int i, *psel_val; struct group_desc *group; - int *pins; + const unsigned int *pins; func = pinmux_generic_get_function(pctldev, func_selector); if (!func) diff --git a/drivers/pinctrl/renesas/pinctrl-rzv2m.c b/drivers/pinctrl/renesas/pinctrl-rzv2m.c index 21d7d5ac8c4a..eb304fab1796 100644 --- a/drivers/pinctrl/renesas/pinctrl-rzv2m.c +++ b/drivers/pinctrl/renesas/pinctrl-rzv2m.c @@ -165,7 +165,7 @@ static int rzv2m_pinctrl_set_mux(struct pinctrl_dev *pctldev, struct function_desc *func; unsigned int i, *psel_val; struct group_desc *group; - int *pins; + const unsigned int *pins; func = pinmux_generic_get_function(pctldev, func_selector); if (!func) From patchwork Mon Dec 4 15:56:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 173451 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp2860864vqy; Mon, 4 Dec 2023 08:02:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IFWNQ+kXcrJYQkEfTQXmK29EeoIcP7cr/AGK996RYgtOJdrRZ3WGU8ENgtA6Grto5FzOMM/ X-Received: by 2002:a05:6870:6587:b0:1fb:75a:de56 with SMTP id fp7-20020a056870658700b001fb075ade56mr5521956oab.68.1701705769814; Mon, 04 Dec 2023 08:02:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701705769; cv=none; d=google.com; s=arc-20160816; b=dp+CXbc7TmICxMiMtPAhIuAd+AJdVJtUYSuHGNJe+/wT4OvQnr6ZG9PXDWyKHpW3Wj ez+rSi8er7JfA+cTXYw2mTmYk17GcA9u7f6uqqRU/jqi6vtc7lIds/KbFcHlgStFayYn 3a8YHsrPHWlR44VzjT4mVSadw/xc63+mGg0YK4Uv0AwdeYNQyKbKzYViiekm9NRL6X16 GcMBO+PxJ0a4F7EkPBtsbZemTc2Mmfs9qtY9GAXDUF2YHwO3+buMzz5GzUkXQCBD3eww PvyG6kGlgpyc9TCVGOnhPRs/4/ewXjW9BZ5Yt7rGT6t645d0Njfc75VSfP318QUiLxSa zFIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hNL3a0QFRdrGd2JUv2BrvBpw4f82UweZpFoqamOoj78=; fh=bb00IWANzUrbEims5abAG2NrFRW6cV0KBtrUyXvAr8o=; b=spbbH+dHSqC8W6nw+f2vrC/PzAKaF81rE5Au1xHv1RFjZfA/ij3yrgEn5eEkV5l9QF rgoZL5BhtkvEvgfxYIXf/Ef1Xlz3cKBrDMHIhPP5N7mDT+SWEV2PfL+lTTKpHlKMBDu9 oNrIa7CR8VIj5ypiwHspqCsprT/9x/yTM08IfXxAoXmun9s4Db3ul99TQI5P6WY5lRqe 5iPPkA3h6wU7UJvtla33yKWwt4ewWdaGZi7uqbJ2IYH7YKRuBoQChRO/k+N1LPZm1KP0 79zDeJSaJzyGld1LSHW1do7GGWf+rnn8G3klYnjLnqMB4OOMDxzSorRe3Kd8xdxVm3qk iiIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gJjqFwHl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id f4-20020a056830264400b006d7eb83fa1fsi3273904otu.129.2023.12.04.08.02.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 08:02:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gJjqFwHl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id AC342804E717; Mon, 4 Dec 2023 08:02:40 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344335AbjLDQC0 (ORCPT + 99 others); Mon, 4 Dec 2023 11:02:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343929AbjLDQCW (ORCPT ); Mon, 4 Dec 2023 11:02:22 -0500 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DF72A9; Mon, 4 Dec 2023 08:02:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701705748; x=1733241748; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=I3BxyR7sGYM/0yoNVJh1VwzK7MSxRwGnKpjvhvZzSkE=; b=gJjqFwHlqW1DPVy5a54rdpIWspG20IXzaRPjaJxLlfeUKcyMlsisig3a LNkl8KO5UWMVSL7LZghoKuyzNazzrzl6U6o4HYDGBieCj4oqo7WjW7e2v 5CQju1Z9xm5WvEyghdtjUhV5FmgyBkspk3FoGoGa7cSSUTvxBtRg4GtQR jLRcrpUF+Kcld69mBARMwDYZlX08lzPwE8mz6en9UhDHNV2gDZeqDJCpH hUErF65uwU5OrNn/brEYnuBIjP0kF+w1or3BCmTYes5TwsJWHWTUAV5WW H9eaXBsFmWADdR0N6JJ6m1Y++TR4E9NbUG+Nx78OdjteS/PPMG1VXaKsc Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="807872" X-IronPort-AV: E=Sophos;i="6.04,250,1695711600"; d="scan'208";a="807872" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 08:00:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="774297196" X-IronPort-AV: E=Sophos;i="6.04,250,1695711600"; d="scan'208";a="774297196" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga007.fm.intel.com with ESMTP; 04 Dec 2023 08:00:44 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 12746881; Mon, 4 Dec 2023 18:00:43 +0200 (EET) From: Andy Shevchenko To: Linus Walleij , Andy Shevchenko , =?utf-8?q?Jonathan_Neu?= =?utf-8?q?sch=C3=A4fer?= , Geert Uytterhoeven , Claudiu Beznea , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, linux-renesas-soc@vger.kernel.org Cc: Lakshmi Sowjanya D Subject: [PATCH v1 2/5] pinctrl: core: Make pins const unsigned int pointer in struct group_desc Date: Mon, 4 Dec 2023 17:56:33 +0200 Message-ID: <20231204160033.1872569-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20231204160033.1872569-1-andriy.shevchenko@linux.intel.com> References: <20231204160033.1872569-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 04 Dec 2023 08:02:41 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784367828965822356 X-GMAIL-MSGID: 1784367828965822356 It's unclear why it's not a const unsigned int pointer from day 1. Make the pins member const unsigned int pointer in struct group_desc. Update necessary APIs. Reviewed-by: Geert Uytterhoeven Signed-off-by: Andy Shevchenko --- drivers/pinctrl/core.c | 2 +- drivers/pinctrl/core.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index 12daf0bb091e..6380e1fa6509 100644 --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c @@ -640,7 +640,7 @@ static int pinctrl_generic_group_name_to_selector(struct pinctrl_dev *pctldev, * Note that the caller must take care of locking. */ int pinctrl_generic_add_group(struct pinctrl_dev *pctldev, const char *name, - int *pins, int num_pins, void *data) + const unsigned int *pins, int num_pins, void *data) { struct group_desc *group; int selector, error; diff --git a/drivers/pinctrl/core.h b/drivers/pinctrl/core.h index 8b59dd72e4ff..8ef4b536bca5 100644 --- a/drivers/pinctrl/core.h +++ b/drivers/pinctrl/core.h @@ -203,7 +203,7 @@ struct pinctrl_maps { */ struct group_desc { const char *name; - int *pins; + const unsigned int *pins; int num_pins; void *data; }; @@ -222,7 +222,7 @@ struct group_desc *pinctrl_generic_get_group(struct pinctrl_dev *pctldev, unsigned int group_selector); int pinctrl_generic_add_group(struct pinctrl_dev *pctldev, const char *name, - int *gpins, int ngpins, void *data); + const unsigned int *pins, int num_pins, void *data); int pinctrl_generic_remove_group(struct pinctrl_dev *pctldev, unsigned int group_selector); From patchwork Mon Dec 4 15:56:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 173452 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp2860936vqy; Mon, 4 Dec 2023 08:02:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IGbEWGTkeZiVBTF8WUeBG/WCMMYsYyshBq8ThIDKP/yh6Sfvxo3u4wDBQL031r4ePydbB3M X-Received: by 2002:a17:902:8e87:b0:1d0:6ffe:1e8e with SMTP id bg7-20020a1709028e8700b001d06ffe1e8emr2222227plb.113.1701705774654; Mon, 04 Dec 2023 08:02:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701705774; cv=none; d=google.com; s=arc-20160816; b=PQugOetah6qMalCVqQsx99Z2qm7hoDsmOlv1mOU4Ivc6lhguKGxJYDrI7PBUFpkpQ7 MI2uhuvD7ptwnUhrtTGbtOrEIj2+QOgwCPDgs+P7O3rV5nlHYQeXILbq9qHjRKRiFAEF tdWgsohnCo9evmo7nycbdz2SLUjMAhJ0QwfBRiD6Crvii9HWTSrdDiXqd7yt3Dz6H6hZ UQVrLn+hjczQEka4kpF6d/n3M1VMP9OuNV+SBV32bNw4JD+stPqSAgGh0pDzMYE4Rghs +w9lJ2Haczqc0T7HW5G68C04Qru20Iw4+jLu5GDKgW+Y4eLUrm4fT6Jp4fEzQJhK15WC oe9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=jhDb/HHOY9FsCnNlIgyCIkjJpR6gLHDbwVIHtDdGEQ0=; fh=bb00IWANzUrbEims5abAG2NrFRW6cV0KBtrUyXvAr8o=; b=KNrB91mYhFrM3Hu04/PvwjTx0cCjafWDY5zmiIO4uUXoU0uTcBbkFCAZyHLYpiEFYJ bnP8g3IgvYulkAr4NmmcbLSWEP0ymkHabJbTzZ3JljvDOxWK5+Olq4NkrwcTXmm3I/Cw zHaXTKetbeJWE+z1IilPyJJqDNnVGfyV2HUp7mGhRV/KMf8/uSv8uUzxlwRKk/ORFBPf zMQsjJvwUvs2s6bQ8R0sP7K+wKpRxVEknIWbKeDYCTbS48RA+jilcyGAJIPoPnOLgx6G 1138s0GKZ56GAe7DzWKzmBNUXdFLNIS975aTXVi1JWd4O6ELhNzBs7sNc5vVqwlKWHyU Sb7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="FX/2i/Ez"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id x20-20020a1709027c1400b001d0b43fe4ebsi1064921pll.611.2023.12.04.08.02.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 08:02:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="FX/2i/Ez"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 603798079AE7; Mon, 4 Dec 2023 08:02:42 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344478AbjLDQC2 (ORCPT + 99 others); Mon, 4 Dec 2023 11:02:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343972AbjLDQCW (ORCPT ); Mon, 4 Dec 2023 11:02:22 -0500 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D028B0; Mon, 4 Dec 2023 08:02:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701705748; x=1733241748; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=GcznTEzkYh7381dOAmLl/g2Ovk3HvI9vfBlGPtxsvN8=; b=FX/2i/Ez9IbgsV8Yf5CSEMiC7/34GX7vzuVhkCNJcdqPIK/in3QnCzh8 +JEjSsYh5Axz1NJovaBYo0IFzi9qEFZQiL+r+rS00fSBmH0sId1TFQ7xV 5vnLffRXvnt4Epki25rUGKOa6DN63xMYnyz4ShVZvLE/dmtlA+eZLjb75 gL0aJ0w+IPSPMreEKV/S968+YQQOb0QIbL+EUe55qiDHRRDRmiv8bBZxv KTqDFtEtB/oWgS4cZcn9Z18gQd1aNOrQTZ3W7pFlIj6m4OjKHnj7/m7Ol sn7ICVU2oCzVTrTY28kybGW6jt6PCAXs7/pJR5s9o0is3ZtT8ZDgU3WiQ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="807882" X-IronPort-AV: E=Sophos;i="6.04,250,1695711600"; d="scan'208";a="807882" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 08:00:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="774297204" X-IronPort-AV: E=Sophos;i="6.04,250,1695711600"; d="scan'208";a="774297204" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga007.fm.intel.com with ESMTP; 04 Dec 2023 08:00:44 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 1DF2FA02; Mon, 4 Dec 2023 18:00:43 +0200 (EET) From: Andy Shevchenko To: Linus Walleij , Andy Shevchenko , =?utf-8?q?Jonathan_Neu?= =?utf-8?q?sch=C3=A4fer?= , Geert Uytterhoeven , Claudiu Beznea , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, linux-renesas-soc@vger.kernel.org Cc: Lakshmi Sowjanya D Subject: [PATCH v1 3/5] pinctrl: equilibrium: Convert to use struct pingroup Date: Mon, 4 Dec 2023 17:56:34 +0200 Message-ID: <20231204160033.1872569-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20231204160033.1872569-1-andriy.shevchenko@linux.intel.com> References: <20231204160033.1872569-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 04 Dec 2023 08:02:42 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784367834787317548 X-GMAIL-MSGID: 1784367834787317548 The pin control header provides struct pingroup. Utilize it instead of open coded variants in the driver. Signed-off-by: Andy Shevchenko --- drivers/pinctrl/pinctrl-equilibrium.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/pinctrl/pinctrl-equilibrium.c b/drivers/pinctrl/pinctrl-equilibrium.c index fd59cfdeefac..4ebae516d1b1 100644 --- a/drivers/pinctrl/pinctrl-equilibrium.c +++ b/drivers/pinctrl/pinctrl-equilibrium.c @@ -705,7 +705,7 @@ static int eqbr_build_groups(struct eqbr_pinctrl_drv_data *drvdata) struct device *dev = drvdata->dev; struct device_node *node = dev->of_node; unsigned int *pins, *pinmux, pin_id, pinmux_id; - struct group_desc group; + struct pingroup group, *grp = &group; struct device_node *np; struct property *prop; int j, err; @@ -721,49 +721,49 @@ static int eqbr_build_groups(struct eqbr_pinctrl_drv_data *drvdata) of_node_put(np); return err; } - group.num_pins = err; - group.name = prop->value; - pins = devm_kcalloc(dev, group.num_pins, sizeof(*pins), GFP_KERNEL); + grp->npins = err; + grp->name = prop->value; + pins = devm_kcalloc(dev, grp->npins, sizeof(*pins), GFP_KERNEL); if (!pins) { of_node_put(np); return -ENOMEM; } - group.pins = pins; + grp->pins = pins; - pinmux = devm_kcalloc(dev, group.num_pins, sizeof(*pinmux), GFP_KERNEL); + pinmux = devm_kcalloc(dev, grp->npins, sizeof(*pinmux), GFP_KERNEL); if (!pinmux) { of_node_put(np); return -ENOMEM; } - for (j = 0; j < group.num_pins; j++) { + for (j = 0; j < grp->npins; j++) { if (of_property_read_u32_index(np, "pins", j, &pin_id)) { dev_err(dev, "Group %s: Read intel pins id failed\n", - group.name); + grp->name); of_node_put(np); return -EINVAL; } if (pin_id >= drvdata->pctl_desc.npins) { dev_err(dev, "Group %s: Invalid pin ID, idx: %d, pin %u\n", - group.name, j, pin_id); + grp->name, j, pin_id); of_node_put(np); return -EINVAL; } pins[j] = pin_id; if (of_property_read_u32_index(np, "pinmux", j, &pinmux_id)) { dev_err(dev, "Group %s: Read intel pinmux id failed\n", - group.name); + grp->name); of_node_put(np); return -EINVAL; } pinmux[j] = pinmux_id; } - err = pinctrl_generic_add_group(drvdata->pctl_dev, group.name, - group.pins, group.num_pins, + err = pinctrl_generic_add_group(drvdata->pctl_dev, + grp->name, grp->pins, grp->npins, pinmux); if (err < 0) { - dev_err(dev, "Failed to register group %s\n", group.name); + dev_err(dev, "Failed to register group %s\n", grp->name); of_node_put(np); return err; } From patchwork Mon Dec 4 15:56:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 173454 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp2861078vqy; Mon, 4 Dec 2023 08:03:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IFvUiN2ChUUfEQbuPRqCGrLzzoNAxnOPKU9E3sPY7+j3sdWhBs4RsNkrpVcEkpzV+wzjuHn X-Received: by 2002:a05:6870:3328:b0:1fb:75a:6d3c with SMTP id x40-20020a056870332800b001fb075a6d3cmr5454268oae.99.1701705784019; Mon, 04 Dec 2023 08:03:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701705784; cv=none; d=google.com; s=arc-20160816; b=H7HM9Ny/7SJersukFH+mR8JNFSmLYCbJnRUWTie2C/VCZS3RYINyeLuCPqv6hef2qO tmMuw9MAOw33zHEbPtjidmh54vYwe9jdr5cETqFDtIUyItangf7Gf0hJdZxSF+NkxoxJ llivXfYoOzvbgKaQfcP2dHYpaW3CaoxbUafeBWfIKK97OXk2DfgPoiPCw7QznRgUKW+m 5gegFa5r+Hl+goHh71ZrHzMKAVRQbe9uGZTOQpXA/EFnKMbYtRKsbg7abSuTjJL8a3fa Ac7qx9doqCun9qVWAcgPzDDQIgeV2DBnGgXOu2iSuBVDIR9kZPtrQ1ii/o3cQ0UCOgM0 7wWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=QPuhUdOjAWJEaCRyfNF1IlapG251gNSYm96EGdpOvEA=; fh=bb00IWANzUrbEims5abAG2NrFRW6cV0KBtrUyXvAr8o=; b=DbHSf6R6+KDO1TMZkSTaq7DRZpRxjnpJDZjHJ1Or5vNQKe9DaYreZEb+PCUxgx9WBi xKTwrtqBgHDOZsCfGHkCE0lbGUyjS8xUEonxtUyYa8X0Nhketh8jrNCof0+Zwupofa66 AYa2y4O3ilXa92saHWUyZFIjIlQDpNNf+NyHKcpKGIpDsnjGhdjSforUffrR5H+BXNmv HbXt9VXsUzT27Nxr7Atn9Nu+xhGv8UjvP+VAv9rqTl38fPtNYLYpu2RZuSn/TnATkJ4H 4bosP+c5Vr/xhsw+zdagaSi/up6ppkhsVsWQtLVVCWy/kGLxysP6OKt78je/pThRWB2M uyXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="i6g/bhyr"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id js3-20020a056870bac300b001fb03f70dffsi1796625oab.12.2023.12.04.08.02.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 08:03:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="i6g/bhyr"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id C3F0C80A4F5A; Mon, 4 Dec 2023 08:02:48 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344488AbjLDQCb (ORCPT + 99 others); Mon, 4 Dec 2023 11:02:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344301AbjLDQCX (ORCPT ); Mon, 4 Dec 2023 11:02:23 -0500 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0913E83; Mon, 4 Dec 2023 08:02:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701705750; x=1733241750; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mX8nkFa+pUFM3JtjtNpLHJ2j2h/kDkAZjOuxZ+/LWq0=; b=i6g/bhyr6pd+nzjHfyVPWB8XrkdeQRJousy5sE7zljg8cznKg8y9U+qO +ge8Ax7hTVyEGSNtqRB8kyPZHZUNBGcSJ3uUiHJbKreLHYaoGk0W3d4pC DdpPMjLWixp7CX085SVwJDa69VwmAtUek5I9HXkL7Vgjk4Ifq+jW8OSGY mNqRZlqInyhBIAI1VNU7UaRLrGEluwbtTWoAsDlXWZAE8tS+O+dU4V/tf 2R6CaCEjA5FjaBmS77jJxaK9408yWhIwfBWtW1H5LUpLnb2GjByD6TWhN TR6e3cR2FfLRgL2FICpSt+0vqAgFNda/uDDCkLKvt4lJMSOvwV4EjOHXa g==; X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="807884" X-IronPort-AV: E=Sophos;i="6.04,250,1695711600"; d="scan'208";a="807884" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 08:00:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="774297203" X-IronPort-AV: E=Sophos;i="6.04,250,1695711600"; d="scan'208";a="774297203" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga007.fm.intel.com with ESMTP; 04 Dec 2023 08:00:44 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 2D122A5F; Mon, 4 Dec 2023 18:00:43 +0200 (EET) From: Andy Shevchenko To: Linus Walleij , Andy Shevchenko , =?utf-8?q?Jonathan_Neu?= =?utf-8?q?sch=C3=A4fer?= , Geert Uytterhoeven , Claudiu Beznea , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, linux-renesas-soc@vger.kernel.org Cc: Lakshmi Sowjanya D Subject: [PATCH v1 4/5] pinctrl: keembay: Convert to use struct pingroup Date: Mon, 4 Dec 2023 17:56:35 +0200 Message-ID: <20231204160033.1872569-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20231204160033.1872569-1-andriy.shevchenko@linux.intel.com> References: <20231204160033.1872569-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 04 Dec 2023 08:02:49 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784367844217653439 X-GMAIL-MSGID: 1784367844217653439 The pin control header provides struct pingroup. Utilize it instead of open coded variants in the driver. Signed-off-by: Andy Shevchenko --- drivers/pinctrl/pinctrl-keembay.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-keembay.c b/drivers/pinctrl/pinctrl-keembay.c index 152c35bce8ec..87d328853ae4 100644 --- a/drivers/pinctrl/pinctrl-keembay.c +++ b/drivers/pinctrl/pinctrl-keembay.c @@ -1517,7 +1517,7 @@ static int keembay_gpiochip_probe(struct keembay_pinctrl *kpc, static int keembay_build_groups(struct keembay_pinctrl *kpc) { - struct group_desc *grp; + struct pingroup *grp; unsigned int i; kpc->ngroups = kpc->npins; @@ -1528,7 +1528,7 @@ static int keembay_build_groups(struct keembay_pinctrl *kpc) /* Each pin is categorised as one group */ for (i = 0; i < kpc->ngroups; i++) { const struct pinctrl_pin_desc *pdesc = keembay_pins + i; - struct group_desc *kmb_grp = grp + i; + struct pingroup *kmb_grp = grp + i; kmb_grp->name = pdesc->name; kmb_grp->pins = (int *)&pdesc->number; From patchwork Mon Dec 4 15:56:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 173455 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp2865430vqy; Mon, 4 Dec 2023 08:08:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IGaQN/mRItLnzC1tsUyW2rt3/5Fn7/kJcWHVKk/U8MTHnAKB7+lWaixl85QmYSk1Yi1PtNm X-Received: by 2002:a17:902:f7d4:b0:1d0:476f:b2ba with SMTP id h20-20020a170902f7d400b001d0476fb2bamr4116822plw.50.1701706093483; Mon, 04 Dec 2023 08:08:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701706093; cv=none; d=google.com; s=arc-20160816; b=HHiKcYjT2hcRzl405WFNS5CvIeLlKl5XoaVLYp+O3L30u2Jmp9mJt4tZIcFNY5cUCc rBdsSoJRwmp85pq52qJTRfRyu7jtf7HtqrvuoZuO+5DVt873Cc3S6zpXjqeMsvJQvey2 znzeC7WPQR2gJzryk3pJawaXlmn0pPvQPpV023Pqzip7wRCGflDqiloFqOEwS24DryCJ mrDjSMeV/BpwmjmUjlO3PyEISvYMjEikdJBUH8Bf3Lr9zWhGsb6WpJWlxFxsJqGBxGpR 1n10SXUlz+mNfXL6CKTifYqJgPAaXnwRfxU9JdQf5Y0s6SWHdLRNxIlqYjbCzAgqLtwo 0ktw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9TzWvOIsd72cmqfqE1B58EzmtMdPGePhdwGf/0CIcbY=; fh=bb00IWANzUrbEims5abAG2NrFRW6cV0KBtrUyXvAr8o=; b=l9H4b6Zf206fFUyEOk3RD14X+Bz5Bk7mxITK91wXikf5AxGRwwDCaVEx6cGTGzwuWn CjEzrpa7hUsfZ02P0TMEl9XQKdGnIEj4mnkVm4Cljrokvq/SqBoc9wN64VhZaK/z1m/C MhXvIsXTNPbUjrOmySiXm1LhQuQ/CougaVoSZ2eKcckfr5dr3ZCYgQyEADXFNsRRWodC r9cbqcVjAan9hdxk+RNTg/YiEB/Z3GwXSCdElqh+3o5Bgo9Bee5ZF5tkUV/X4u+rSztS UURWyQ2TyJBiVzqKDrHkcW+YxxB5mDfXiMH3leqvWDQF2iQIVb5n9A3oEyxPK75clwwa kmOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="nJ/puh3Y"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id w2-20020a170902e88200b001d003e30248si1885809plg.614.2023.12.04.08.08.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 08:08:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="nJ/puh3Y"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 56439808BD33; Mon, 4 Dec 2023 08:08:08 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234809AbjLDQH7 (ORCPT + 99 others); Mon, 4 Dec 2023 11:07:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234963AbjLDQHy (ORCPT ); Mon, 4 Dec 2023 11:07:54 -0500 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BA26A9; Mon, 4 Dec 2023 08:08:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701706082; x=1733242082; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=CyMweha2ZvuLisSoPmNJvwBvM8UVF+24ES7V+e13w7A=; b=nJ/puh3YkMMr4ow4roTP8fCrGxx42pg87in85xDgYJvB1y7Fo6YvlfMY OcV83eHYNa08727X6W0hqakN8VMXMRtLmXdt2nI7LeCrUW6QAb8AUTgWY dUMxRDPuRiRtWvAK0sPRpEfT1lB8bTbeKjiAZCTzm+mXPjhgzcZsoFPEw acwteRsmb+IjskBk9M3z5VWGUb/x9BdNELRpdug3hCRR3sX+kvNuI+SQ5 p3cFXC/9gXbmKcKn+T7sNrO2TlCrBKmFYBdZ++VZorXumfPjcLe/3P5hW Sf0X/iMaMIUqE8K+ys4ZQwcTJ6ThA7DLG3r3XjtWseqVaK1KhswL2LkD3 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="632533" X-IronPort-AV: E=Sophos;i="6.04,250,1695711600"; d="scan'208";a="632533" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 08:08:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10914"; a="861422786" X-IronPort-AV: E=Sophos;i="6.04,250,1695711600"; d="scan'208";a="861422786" Received: from black.fi.intel.com ([10.237.72.28]) by FMSMGA003.fm.intel.com with ESMTP; 04 Dec 2023 08:07:57 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 3C299A7D; Mon, 4 Dec 2023 18:00:43 +0200 (EET) From: Andy Shevchenko To: Linus Walleij , Andy Shevchenko , =?utf-8?q?Jonathan_Neu?= =?utf-8?q?sch=C3=A4fer?= , Geert Uytterhoeven , Claudiu Beznea , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, linux-renesas-soc@vger.kernel.org Cc: Lakshmi Sowjanya D Subject: [PATCH v1 5/5] pinctrl: nuvoton: Convert to use struct pingroup and PINCTRL_PINGROUP() Date: Mon, 4 Dec 2023 17:56:36 +0200 Message-ID: <20231204160033.1872569-6-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20231204160033.1872569-1-andriy.shevchenko@linux.intel.com> References: <20231204160033.1872569-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 04 Dec 2023 08:08:08 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784368168298678827 X-GMAIL-MSGID: 1784368168298678827 The pin control header provides struct pingroup and PINCTRL_PINGROUP() macro. Utilize them instead of open coded variants in the driver. Reviewed-by: Jonathan Neuschäfer Signed-off-by: Andy Shevchenko --- drivers/pinctrl/nuvoton/pinctrl-wpcm450.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c index 0cff44b07b29..4589900244c7 100644 --- a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c +++ b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c @@ -474,9 +474,8 @@ enum { #undef WPCM450_GRP }; -static struct group_desc wpcm450_groups[] = { -#define WPCM450_GRP(x) { .name = #x, .pins = x ## _pins, \ - .num_pins = ARRAY_SIZE(x ## _pins) } +static struct pingroup wpcm450_groups[] = { +#define WPCM450_GRP(x) PINCTRL_PINGROUP(#x, x ## _pins, ARRAY_SIZE(x ## _pins)) WPCM450_GRPS #undef WPCM450_GRP }; @@ -852,7 +851,7 @@ static int wpcm450_get_group_pins(struct pinctrl_dev *pctldev, const unsigned int **pins, unsigned int *npins) { - *npins = wpcm450_groups[selector].num_pins; + *npins = wpcm450_groups[selector].npins; *pins = wpcm450_groups[selector].pins; return 0; @@ -901,7 +900,7 @@ static int wpcm450_pinmux_set_mux(struct pinctrl_dev *pctldev, struct wpcm450_pinctrl *pctrl = pinctrl_dev_get_drvdata(pctldev); wpcm450_setfunc(pctrl->gcr_regmap, wpcm450_groups[group].pins, - wpcm450_groups[group].num_pins, function); + wpcm450_groups[group].npins, function); return 0; }