From patchwork Mon Dec 4 12:34:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 173271 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp2728829vqy; Mon, 4 Dec 2023 04:35:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IHfuAX2aei1vAaKGUDVw3hbGry1FVT+pvZtmnIeaqm+55Omw+XsfToIpky6pJUPsJb6nyVa X-Received: by 2002:a05:6808:286:b0:3b8:9906:c267 with SMTP id z6-20020a056808028600b003b89906c267mr3150123oic.56.1701693322155; Mon, 04 Dec 2023 04:35:22 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1701693322; cv=pass; d=google.com; s=arc-20160816; b=hjArCrbFa8UbABnPH28MU+USOsPQ+a7ieJaoA+b0+hE/XNNvdRtMvmVO5sY+ZhgF7O P86zJIa49pC7Pk9X9xUtQ2dydeQDd+CmGKl3W96cfiTS4svcf4Tu50d6Sfq5uop3XazG Cnyqbik9/r7dQ0Ru/Ji8SH9FkkDjBlBtMVaQwKeiJO1KQIyyU2mySFi7JrA/x6pazBgR RPy/kuBV8aPe4d9KiPfT+qyu6+7mHLkild37Cz8NB5LugRQeVT2lO9wcVGyRsR/e5ONf naN7WdhjNABYeZqM7JQfLFmlQyYhTmOJKlcXALY1tTB/qSD+jbTTpVQV7tc9Q7KUG/gH 7esA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:message-id:mime-version:subject :cc:to:from:date:dkim-signature:dkim-signature:arc-filter :dmarc-filter:delivered-to; bh=yRTozKloLk1wt6jwtDsP+7YHv29mBPomAecTShzmwKw=; fh=gSYembJIQudd+PvT0IV+g5bEjdJejrB7/Kk1rZi5kHg=; b=krktg78+TnG9L2ksm69YdcGgWrCXGBDPCb8s+7tzFlXJeH0v6OZ5gZnuZtDMmLrzcP SkMp0VUcZRfWM4b59HfX4WuyEf4dfQMhkdfb8Vvn3dkXH3OyCTrI8f0la+OOTA3wy0On RGdA5J061pzI3dIw6V+44J/TjAcU+JcjSc0m2V/03a8SvGsfNPzTHiRbiO2l1Rh0ItOS /8hsYwYNVcxODzPo1BCD5cSgLhm8zFYiB8zwoGuKTh/0ygrrb7SbZCXy76gjfzY465h4 AwZK2/XK7FEs+BkD1rrsByq1KmBarGzqOry+kIzI9XtcxJaO/DeQtEl6FbZdwxOslIXP k8ow== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=PlmsRZjp; dkim=neutral (no key) header.i=@suse.de; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id b11-20020ac844cb000000b0041957764bd3si8740059qto.734.2023.12.04.04.35.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 04:35:22 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=PlmsRZjp; dkim=neutral (no key) header.i=@suse.de; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DE9A9384F9B2 for ; Mon, 4 Dec 2023 12:35:21 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 4A13F385828E for ; Mon, 4 Dec 2023 12:34:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4A13F385828E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4A13F385828E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701693296; cv=none; b=iCRzPpbMoeI3ZwWyMAwVXNwIhoQNDTlupKswZWykKXtQXE93HqZkW5CiVdgclzmG7CjNMBjNF9uAIxvDDuYwfWyV1T1OWlCLTa803rm1F27WFvIQeazPwxC398u4twEtTJxi0hoXcR2fz7AA0o0p8XbbYXE85SM9JGgxbVvjBFs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701693296; c=relaxed/simple; bh=beYFbY5QdMP8qfxt54B2m6Su/rKJ6kcb2WSoQLcNOoE=; h=DKIM-Signature:DKIM-Signature:Date:From:To:Subject:MIME-Version: Message-Id; b=ZLSh9QpSgqtAjfFcraSGCCFa7016M5FSfiBBlb9fHpLouHqYMi1ij5E9hpoI6Lfsh0mg0YzxeQPu0JPFJqEEsAO49LdvMtfeRpTwrXT6GPL5atXoZInYSXBCwi0NCTtVzQmJMBrC6fHCGl6io4kogZhESlaeerU71kVXfXQOoVM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 41FF81FE64; Mon, 4 Dec 2023 12:34:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1701693285; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=yRTozKloLk1wt6jwtDsP+7YHv29mBPomAecTShzmwKw=; b=PlmsRZjpuJM2ad2WfPdg7lJ2fBW/2G9Tns+/THviFPrbKIIAbPUlwGfa/oFhi6QOTprJN0 vhQnVUeB+V5kKLCv5mJItA4y5s6+1MfwWRilQ4z//1btSIkWmbopGGA7Qwo9aAuTLL8IJ6 JvSTqAxb0t3L0EPMrunY8NY+M5IeM6c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1701693285; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=yRTozKloLk1wt6jwtDsP+7YHv29mBPomAecTShzmwKw=; b=0n6CBNzfEKGwnRPbspZRpT2Lx1C3nS7rScdGl6AIO+s11dq1UUUYMql8DAFEHbWmb4Wbox rsv4rUnFJ0sInQDw== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 1FE40139E2; Mon, 4 Dec 2023 12:34:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id T+fBBWXHbWWqZgAAn2gu4w (envelope-from ); Mon, 04 Dec 2023 12:34:45 +0000 Date: Mon, 4 Dec 2023 13:34:44 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org cc: "Joseph S. Myers" Subject: [PATCH] c/86869 - preserve address-space info when building qualified ARRAY_TYPE MIME-Version: 1.0 Message-Id: <20231204123445.1FE40139E2@imap2.dmz-prg2.suse.org> Authentication-Results: smtp-out2.suse.de; none X-Spam-Level: X-Spam-Score: -3.73 X-Spamd-Result: default: False [-3.73 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[gcc.target:url]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-2.63)[98.34%] X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784354776761360088 X-GMAIL-MSGID: 1784354776761360088 The following adjusts the C FE specific qualified type building to preserve address-space info also for ARRAY_TYPE. Bootstrap / regtest running on x86_64-unknown-linux-gnu, OK? Thanks, Richard. PR c/86869 gcc/c/ * c-typeck.cc (c_build_qualified_type): Preserve address-space info for ARRAY_TYPE. gcc/testsuite/ * gcc.target/avr/pr86869.c: New testcase. --- gcc/c/c-typeck.cc | 1 + gcc/testsuite/gcc.target/avr/pr86869.c | 9 +++++++++ 2 files changed, 10 insertions(+) create mode 100644 gcc/testsuite/gcc.target/avr/pr86869.c diff --git a/gcc/c/c-typeck.cc b/gcc/c/c-typeck.cc index a6edbc85f10..836893905fa 100644 --- a/gcc/c/c-typeck.cc +++ b/gcc/c/c-typeck.cc @@ -16263,6 +16263,7 @@ c_build_qualified_type (tree type, int type_quals, tree orig_qual_type, t = build_variant_type_copy (type); TREE_TYPE (t) = element_type; + TYPE_ADDR_SPACE (t) = TYPE_ADDR_SPACE (element_type); if (TYPE_STRUCTURAL_EQUALITY_P (element_type) || (domain && TYPE_STRUCTURAL_EQUALITY_P (domain))) diff --git a/gcc/testsuite/gcc.target/avr/pr86869.c b/gcc/testsuite/gcc.target/avr/pr86869.c new file mode 100644 index 00000000000..fbfb378e8c9 --- /dev/null +++ b/gcc/testsuite/gcc.target/avr/pr86869.c @@ -0,0 +1,9 @@ +/* { dg-do compile } */ + +struct S { + char y[2]; +}; + +void foo(const __memx struct S *s) { + const char (*p)[2] = &s->y; +}