From patchwork Mon Dec 4 08:57:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 173143 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp2631573vqy; Mon, 4 Dec 2023 00:57:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IH8YMC3OxMC+Y9FE1PTqTz8uZowiIEQmq1+KPxLbMHLQMRmqSv1Yu2hRC2ETFbNNiqv3c6F X-Received: by 2002:a05:6358:785:b0:170:166c:6763 with SMTP id n5-20020a056358078500b00170166c6763mr4595042rwj.2.1701680277240; Mon, 04 Dec 2023 00:57:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701680277; cv=none; d=google.com; s=arc-20160816; b=It++XUDYZnZh746L2MxlDbZBdLxrrDFBcgkhxKrdCF0gVXOnSC/fGjMkCqIsUn2MTt BjO+Ll7urtHE/D/ClRXsGC/E2aYVByl6OqAdR+SEpj5anFqmO2iN3ASvGEenp3xUEWn5 pEAbwkc9tvCF8CpEvAlwMQ9mcsCGO82ZBgQ7Zm36IweCxpErG5ia+DtTRHeMV3xFLlrQ 030rpir9Ynay36V4MdV+m1c2e0wcN4ECsvbdJgIUSKpjqXwYvWYDprahTV7d8vV6G/DM U6J10673TVuVa3Pd/pSvmpESvKrEd9mKqNaD14wPubS7cWGq1CPxpUrQXnQ7/jasIsfZ Cmjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=CmguLwHno4+ep63d/2yDufPK8h00mOPzfPbypUQQUes=; fh=u8rLQsUjk/DQ68o09SM+wx8FxqDFcT3zeQdKot9Eyy4=; b=jeUxEKPAu8XPlR6GyhEbzk67OBbLh3yqA+cz4nfYAEuAbQ1kC53AQMYUlrtPE8E01Y Mz7JpRbLRKFInmrM/Dnp0tZVlUfViXg8srj51kwBxdnQINs2dJu25GL9KrfRBixnL7m2 75tDPpcb+/glte6hUB071EsCVeL6ydDYbsMr1oHj59/wF6bzoskOBGb1FiMK6ANtgsUX JBhZMgJvYi8dT4MHExVS7Ucw2KqavjBRUySRfJbbGdAN7YDf55JDD7PDKfFBZaO3PNpf 3W8pgabBWChi5rpcVnfQbnWaK4nIOJVLrAPybrJRgI6uiLggBLLjyluRY9V8Z7bBDyrx EdRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b="wm+D+Cr/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id y192-20020a638ac9000000b005c65f10c216si3509071pgd.287.2023.12.04.00.57.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 00:57:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b="wm+D+Cr/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id C571180A9ABC; Mon, 4 Dec 2023 00:57:48 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231925AbjLDI5h (ORCPT + 99 others); Mon, 4 Dec 2023 03:57:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234708AbjLDI50 (ORCPT ); Mon, 4 Dec 2023 03:57:26 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30CA8F3 for ; Mon, 4 Dec 2023 00:57:33 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-40c09f4814eso11970915e9.1 for ; Mon, 04 Dec 2023 00:57:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1701680251; x=1702285051; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CmguLwHno4+ep63d/2yDufPK8h00mOPzfPbypUQQUes=; b=wm+D+Cr/2hpPZaNmEgfm7IBMJ5KbbNRgF4Ed85HacNnpJ+sJiYSUL9kURrJYzDBnF+ hDDhV3IgKdjuWg+8mR/9lCtJyg5jVbeLqhB9qyx/XGfy9uw071xkAzM2UlAvrpEPDVZN Ih7+v0CjRjLgMp6Rx8xZVZWtZIzcgCImL7H8bXOXhdgwl6bwZCSPpFjStL00XhXmxb0/ EhU3hZCVEZX7p8rlUC1WrSLRpsakbAGoDmXOaWSPMaK3svmQUdiTFSk1RL9oESNKTNJF YyApPX0FFnkOKsPIZcPYBVqe90ZXasTdOdJtnkJIPgCsBe7ADp18Tk4lC+OoTHU7BlHW 4S+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701680251; x=1702285051; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CmguLwHno4+ep63d/2yDufPK8h00mOPzfPbypUQQUes=; b=QpOfHOrBAaLg2fzrgSC8HVQzWmnrmUU46y+BP9weZKPBC/mEfcsXXA5uRBjWUbsoHc b2ViHXwH4fJDmv9L6SE988bn5lK6lN00fxz0YeNCMIkY0LqTI4GbiNqQp9O6/92WmTtB C6H886qUloz0PdHa5KsYzjXPKq/NUmaF6TjGuU1nEtRa21KEoOZ3iHCk7RXEpxd46mke wm318k657RsA0cFjr0jiQALUU1uKTZXwFvLb66/TK4tvhxkppm1aubAdGAJN6DR5MDQY qcifsvz6o7NfCn6scW6P14vhORYOIQYmD4O5Mci3Qev1I+C4CGGvPr+7j2R97sWdP8Ir OQCQ== X-Gm-Message-State: AOJu0YyG6k4wflT/0EbBqoZALsYnFmwdDmLbEpQvmFYZ88wZMVhmj16E 4m/oajHzR131V+O8iCL34YiMzw== X-Received: by 2002:a05:600c:3503:b0:40b:4b93:a369 with SMTP id h3-20020a05600c350300b0040b4b93a369mr2268142wmq.14.1701680251485; Mon, 04 Dec 2023 00:57:31 -0800 (PST) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:4cb1:229e:8c33:122a]) by smtp.gmail.com with ESMTPSA id l15-20020a05600c4f0f00b0040b33222a39sm17959138wmq.45.2023.12.04.00.57.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 00:57:31 -0800 (PST) From: Bartosz Golaszewski To: Linus Walleij , Andy Shevchenko , Kent Gibson Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v2] gpio: sim: implement the dbg_show() callback Date: Mon, 4 Dec 2023 09:57:19 +0100 Message-Id: <20231204085719.17928-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 04 Dec 2023 00:57:49 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784341098458450251 X-GMAIL-MSGID: 1784341098458450251 From: Bartosz Golaszewski Provide a custom implementation of the dbg_show() callback that prints all requested lines together with their label, direction, value and bias. This improves the code coverage of GPIOLIB. Signed-off-by: Bartosz Golaszewski --- v1 -> v2: - use PTR_IF() instead of #ifdef drivers/gpio/gpio-sim.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c index 1928209491e1..49c3e51bf8e4 100644 --- a/drivers/gpio/gpio-sim.c +++ b/drivers/gpio/gpio-sim.c @@ -20,6 +20,7 @@ #include #include #include +#include #include #include #include @@ -28,6 +29,7 @@ #include #include #include +#include #include #include #include @@ -224,6 +226,25 @@ static void gpio_sim_free(struct gpio_chip *gc, unsigned int offset) } } +static void gpio_sim_dbg_show(struct seq_file *seq, struct gpio_chip *gc) +{ + struct gpio_sim_chip *chip = gpiochip_get_data(gc); + const char *label; + int i; + + guard(mutex)(&chip->lock); + + for_each_requested_gpio(gc, i, label) + seq_printf(seq, " gpio-%-3d (%s) %s,%s\n", + gc->base + i, + label, + test_bit(i, chip->direction_map) ? "input" : + test_bit(i, chip->value_map) ? "output-high" : + "output-low", + test_bit(i, chip->pull_map) ? "pull-up" : + "pull-down"); +} + static ssize_t gpio_sim_sysfs_val_show(struct device *dev, struct device_attribute *attr, char *buf) { @@ -460,6 +481,7 @@ static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev) gc->to_irq = gpio_sim_to_irq; gc->request = gpio_sim_request; gc->free = gpio_sim_free; + gc->dbg_show = PTR_IF(IS_ENABLED(CONFIG_DEBUG_FS), gpio_sim_dbg_show); gc->can_sleep = true; ret = devm_gpiochip_add_data(dev, gc, chip);