From patchwork Sun Dec 3 09:49:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 172923 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp2158873vqy; Sun, 3 Dec 2023 01:50:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IF3ifZDeIPqIFtcH3sYCLi7+06PMOFg5MdplVabdIQLACXE/Q23MDuU/TjmTv8cijFH6Cht X-Received: by 2002:a17:902:e883:b0:1d0:93d1:b19c with SMTP id w3-20020a170902e88300b001d093d1b19cmr455057plg.13.1701597016331; Sun, 03 Dec 2023 01:50:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701597016; cv=none; d=google.com; s=arc-20160816; b=FtGO8j75dmbto+hZ24LYlVLKfzuK7uUQkrMB4ZGLz9QYHlzNEisy9Zt5KZ+HH37WxV ASZwUkcUMr+ZXVyny2XPCedE+HoH2Ukp5ZJRMeBFwlzceKRCpHpLm+OlCD0kD014B8IQ vA4XDj4YsPzQAfxuKvyRlehpCXzgNkjrvDTJcD2QbIR2v4fiwsHi5Zr28QPBBEHJ8j9O 1xr/tmTHC3vYZokkX5oA9NdUK3ydNH1aN93XHqgvhrhKPXPl4Sex4wh3O8HgHg1hHmNp dVBlLGwdqn/ybsnVt1n4JCji7M67tIryLgYMyWPHzObnFzlbsoddW/opXxQu0BjI4lI6 3r6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=WwSUxpvNbpHEFj89ltje+ECirCiC4B9RnOHF5NAiUz4=; fh=C99EpQazXaiSvqwsMVoK+n5/qdfhLqLnxroWjLlHl7s=; b=zv//nFI9caF7smY2vuDj+kiA/r2PFWQCNH0Ul2xZpIGvoyFLR0o3s1DJPrV0IntWBr at+WB+jlJCR17SSvZopcYDZfAxj30osrSiDVyv0v/dST0r7TOyRfriBFCxj6pzFnpt3D Ts1LgAwo+WwJlWe5yGTreHpUx+gB/QqDP+cc4+4iHO7hhbvYmzLdUTXqVpfUzCxSAohT +eKJXXQAD0XcjawoEOiEyYv7C1pJnfQuWcffpeNcTvtFHQf5lEDM4T6hFW1cm8f0obAe iYw1TJuprjd0+aKmA/PfzddLSM/CFk3KxKUJu/6VJ2jbdRW0nqvg7x8RW4gJsoWkpbfE 8ZPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MdCQBWpJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id 6-20020a170902c14600b001d091c3aaefsi531237plj.485.2023.12.03.01.50.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Dec 2023 01:50:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MdCQBWpJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 7E1D88097884; Sun, 3 Dec 2023 01:50:15 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233322AbjLCJtx (ORCPT + 99 others); Sun, 3 Dec 2023 04:49:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjLCJtv (ORCPT ); Sun, 3 Dec 2023 04:49:51 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 005B8DA for ; Sun, 3 Dec 2023 01:49:55 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19F62C433C9; Sun, 3 Dec 2023 09:49:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701596995; bh=DQgligyVko6JOkpsukWsLHEde1ox5xe3QB7/zY+o3mc=; h=From:To:Cc:Subject:Date:From; b=MdCQBWpJATcuy0G8YGsVOOdYN6tVbI+HTba5TIrjOmIdUpI/IfuDMiUCCkk7sxNOq f3f/l9bHGyWii4wNCS7cbYACpBT403QtK+zJ5DgB2ui3BjGnMUuALVc3pH6EgBV+ZI bQoRQ43aqM5VVIqg4x2SgfId0j9Na0Kpei38vJLAFyQZjbZpa6FY388+nCMt+T9mz2 WCCxyX4ceHbHSwI6nMxJRsjNCwtJZZe417YofNj8Ew+3LU0mvm/YcM1BqlurDizojU D/xH2D1K9j8HnYPQ3I/ptSgdJbp5bvb3/ejDqp5Cz9+Qw3776utGljLpRllPyvimkF cOzThHeNnVlxg== From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Masahiro Yamada , Nathan Chancellor , Andi Kleen , Nick Desaulniers , Nicolas Schier , Sam Ravnborg , linux-kernel@vger.kernel.org Subject: [PATCH v2 1/4] modpost: move __attribute__((format(printf, 2, 3))) to modpost.h Date: Sun, 3 Dec 2023 18:49:31 +0900 Message-Id: <20231203094934.1908270-1-masahiroy@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sun, 03 Dec 2023 01:50:15 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784253793014296887 X-GMAIL-MSGID: 1784253793014296887 This attribute must be added to the function declaration in a header for comprehensive checking of all the callsites. Fixes: 6d9a89ea4b06 ("kbuild: declare the modpost error functions as printf like") Signed-off-by: Masahiro Yamada Reviewed-by: Nathan Chancellor --- (no changes since v1) scripts/mod/modpost.c | 3 +-- scripts/mod/modpost.h | 3 ++- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index cb6406f485a9..ca0a90158f85 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -60,8 +60,7 @@ static unsigned int nr_unresolved; #define MODULE_NAME_LEN (64 - sizeof(Elf_Addr)) -void __attribute__((format(printf, 2, 3))) -modpost_log(enum loglevel loglevel, const char *fmt, ...) +void modpost_log(enum loglevel loglevel, const char *fmt, ...) { va_list arglist; diff --git a/scripts/mod/modpost.h b/scripts/mod/modpost.h index 69baf014da4f..9fe974dc1a52 100644 --- a/scripts/mod/modpost.h +++ b/scripts/mod/modpost.h @@ -197,7 +197,8 @@ enum loglevel { LOG_FATAL }; -void modpost_log(enum loglevel loglevel, const char *fmt, ...); +void __attribute__((format(printf, 2, 3))) +modpost_log(enum loglevel loglevel, const char *fmt, ...); /* * warn - show the given message, then let modpost continue running, still From patchwork Sun Dec 3 09:49:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 172922 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp2158838vqy; Sun, 3 Dec 2023 01:50:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IGGFQs5liDH+jyzMt9c7o/e13hCS25INSz21mypl31whVlXpbPrX66/FPec90ylkjWh/wmV X-Received: by 2002:a92:520c:0:b0:35d:59a2:2a4 with SMTP id g12-20020a92520c000000b0035d59a202a4mr3531816ilb.68.1701597007626; Sun, 03 Dec 2023 01:50:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701597007; cv=none; d=google.com; s=arc-20160816; b=UND9uRYNyHI3zx2ITnmZNylwrPEMcojNPxau2f0AvBfn6Wzs8jp67HiRBF7Fm+GTIi XcdJMGfjKoW5iEbdjBKfllTEVUsIRD+DbS2tzeBs+jBAg/a/2lIsIacyekUnqKyELvnq GKvs+f2KNt0LyJGqhrY/ElRemp75jWi8hDyv7wUXUh90ckaA/PI6cTSnaQYtP1HUu3QH jez9Z2ZWfsHIfpYOtRt/Scr1wDtqCfyxJyFZDW5ZU9eeKs1F8zyY/4TzUdhI9sR77bYV 8+NrBGzbfvFtShTXLLsemkEFpJyIKv6xXNU/XGW6N7s1J8TZRlK1N3IHiBfu68QnfTgo c3Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=favE9t77tApv9tYsd3Aeb3yyJJ+m3IS6kMOTpruxKfs=; fh=PFwXawrH1uMeasvl/p3z1jdQgSTgo4FZ0xmHmWTcQfM=; b=WsjN2nRTtPTNoHeEZlbUdTb28OVJrGKHMD6yBSIUkxf/Oek3rNYEtnCCfcdQKWGY+y ZRLcfBMTy7eS65GqBckBhJKvBiZ+Yu7K54eXCv+cx8o2gUm0FqJGuQ3fSSY2uqspBHkj VCGOM5rLczXKf9tp+TCKGYtObefvoWYe1SdBc72yO+Y0sWr/s+LDOLayqv9wsfDuRFoY N74N5nsU7WPcCKGXlHM5dVQF1jDCAqybZVcgx8e1nM+cDgYR5iCoRN81h1y0IXUVA24e ONCJIjqN7H1jbqJ2bJRsXT61RwZl2xH4T6v19Ndr+CQqZ5i2S8f4saDYfg6G0ThFPOH5 V3+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=krGY099a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id mq7-20020a17090b380700b00285be1801d8si6417400pjb.101.2023.12.03.01.50.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Dec 2023 01:50:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=krGY099a; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 5151B809502F; Sun, 3 Dec 2023 01:50:06 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232858AbjLCJtw (ORCPT + 99 others); Sun, 3 Dec 2023 04:49:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231638AbjLCJtv (ORCPT ); Sun, 3 Dec 2023 04:49:51 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4530CED for ; Sun, 3 Dec 2023 01:49:57 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D41B7C433CC; Sun, 3 Dec 2023 09:49:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701596996; bh=rmsWponTX5RKX19qzp5R0zCYaOiow+z0DQeDMbnv4hs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=krGY099aw4XVTLnHqechM+QYTTiVpi77Y5Sg9sl2m20KUWYFikFGob/yeUNdPDMvv mgL2T/dyKctjBYe85UnYisBy0M2w6RF8eyks00H1v2cEq/PNLT2vbw4Mj2fKyWo8N/ JwwI/sZKc1f1xcAziikHBfx/kdu/y1JwYg4bi5F4gj+/3oRg8/alQrKu+nAZeHVaF2 PWnaplfhFxxhvlxy9pk0fAS+zw1DaDb0noGL+ok4nxxUhYPT+K9cpVzhxLcW9SX+h5 KsDXXZiroAkKy0hAhm3AZiQiFiUDB1nqv+UAPqgtImF0L2OdDi9TqeSSTXZMlM2nTW JNVr0n4xoXzPg== From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Masahiro Yamada , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , linux-kernel@vger.kernel.org Subject: [PATCH v2 2/4] modpost: inform compilers that fatal() never returns Date: Sun, 3 Dec 2023 18:49:32 +0900 Message-Id: <20231203094934.1908270-2-masahiroy@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231203094934.1908270-1-masahiroy@kernel.org> References: <20231203094934.1908270-1-masahiroy@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sun, 03 Dec 2023 01:50:06 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784253784078544022 X-GMAIL-MSGID: 1784253784078544022 The function fatal() never returns because modpost_log() calls exit(1) when LOG_FATAL is passed. Inform compilers of this fact so that unreachable code flow can be identified at compile time. Signed-off-by: Masahiro Yamada Reviewed-by: Nathan Chancellor --- Changes in v2: - Use noreturn attribute together with alias scripts/mod/modpost.c | 3 +++ scripts/mod/modpost.h | 5 ++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index ca0a90158f85..c13bc9095df3 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -90,6 +90,9 @@ void modpost_log(enum loglevel loglevel, const char *fmt, ...) error_occurred = true; } +void __attribute__((alias("modpost_log"))) +modpost_log_noret(enum loglevel loglevel, const char *fmt, ...); + static inline bool strends(const char *str, const char *postfix) { if (strlen(str) < strlen(postfix)) diff --git a/scripts/mod/modpost.h b/scripts/mod/modpost.h index 9fe974dc1a52..835cababf1b0 100644 --- a/scripts/mod/modpost.h +++ b/scripts/mod/modpost.h @@ -200,6 +200,9 @@ enum loglevel { void __attribute__((format(printf, 2, 3))) modpost_log(enum loglevel loglevel, const char *fmt, ...); +void __attribute__((format(printf, 2, 3), noreturn)) +modpost_log_noret(enum loglevel loglevel, const char *fmt, ...); + /* * warn - show the given message, then let modpost continue running, still * allowing modpost to exit successfully. This should be used when @@ -215,4 +218,4 @@ modpost_log(enum loglevel loglevel, const char *fmt, ...); */ #define warn(fmt, args...) modpost_log(LOG_WARN, fmt, ##args) #define error(fmt, args...) modpost_log(LOG_ERROR, fmt, ##args) -#define fatal(fmt, args...) modpost_log(LOG_FATAL, fmt, ##args) +#define fatal(fmt, args...) modpost_log_noret(LOG_FATAL, fmt, ##args) From patchwork Sun Dec 3 09:49:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 172925 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp2158908vqy; Sun, 3 Dec 2023 01:50:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IH81TjR0AyIwKr+nof/OYfvbMrpHIQX978Zugjw37p0lSLlmg/7PPEKTQdrW5SzGGahm08Q X-Received: by 2002:a05:6870:6789:b0:1fb:d08:43f5 with SMTP id gc9-20020a056870678900b001fb0d0843f5mr3071436oab.2.1701597026101; Sun, 03 Dec 2023 01:50:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701597026; cv=none; d=google.com; s=arc-20160816; b=E6v5yNl70/8sHUF32lVg7hqs3UJQIKk0jcy+HeqkVPigAYL/VCKcRZBfkh8oU/iy9q 7RPQqWWHcae9ecGLF2M4cfGMOD/fkNxKxxDQIeTEXWn+jwRirYiriAzFJCoif2uHUBik gsUWEqr8x5Vvs4Iiel/+bPslYWv//yRddU5EccaGY2zG027wokgjDd7+cOhAvQSc1Ks2 p6J7jUJ/5Wr43qYuiO5LZ794W7SfZja5yro1sewWDyuX0ZeuH8kvy8DlDG/QmlHoxidY 28BfNwoc/sA6CSWdmmHfx9iUQApVbGq9bsrpqn4Pmq25f1HO3ppi7wDcr8bHNnvhjYuB D/iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=oYNTDDP+SJUfOD3NhHqOqy3bqh6/ODzJYFoTXIWOPTE=; fh=md/tq5L9/pRMvAD62d0GqWddCfc+JZG0bPold5NI6Q8=; b=OCkL6xTdWEsIHTv5dGQkfCEXpwehgW75dSADDUvQqK5zRdVIdjaJq/Qnbj3sDYYEKj g/3fbkm/Ib3GPEV3tJHv9/VoCJZgFzADSsrcnqp/zZJ7AqYhhyDWP1kKj1AgpAGDAlf/ EPsU5MgdehFXIx4wjYODyfx8roXHkBS13PoA4thuxQ5dh7zMfNHraib5xt70wqNVmCT0 CDvaysGA9rikT2kjfhzmD545cMBJVynM4/55aMUeVAWlGBXsUpSzc1LKy3yBHBGPDlnc ZjVbc+4AhVBhfzhiUE4DAcvLAfQqFj+H7vEIfYID/Pq2wR2Cfg5eG1TyKHlTl2qrtxgh uLCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="cGbXL9/Y"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id y29-20020a634b1d000000b005c63a36938fsi1149966pga.809.2023.12.03.01.50.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Dec 2023 01:50:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="cGbXL9/Y"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id C23458087DF6; Sun, 3 Dec 2023 01:50:23 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233335AbjLCJtz (ORCPT + 99 others); Sun, 3 Dec 2023 04:49:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233260AbjLCJtw (ORCPT ); Sun, 3 Dec 2023 04:49:52 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE16ADA for ; Sun, 3 Dec 2023 01:49:58 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D96FC433CA; Sun, 3 Dec 2023 09:49:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701596998; bh=2DvonXnTe7s/F9D7y3v/KBQpYELTPDsU5vhrOaqP0pU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cGbXL9/YNvdZ3anDtwiwLsyBey9CwF9Zt9CsaYDGb8EKVE3wrJB/WhDBRGjY1Uxxs Tn5B7LbKOvQkSogqXHVf/+u/ag2wpVX9EBYkBYcIh7SKaoAnySjiJN+YOVd2U9Ps58 YJRWdgzIaWA7WEVAG0xWQoEMLHmFMTVPLWjouvzxYsFX3xOctviP0fdgEJUnbfFDpM al/hCwPCuju0DP+lZOFjGzUYR65MIAj8fHRrC2gQFSlr8wdvyZnYJ8y6l0KsQ25mvc OOm9BamZlQDMJIerOt4X3z45JEQeKLjd51OACKQb610rvMHLUrXHD8l64l3XLp/7DG X54qRPJZ1vv+Q== From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Masahiro Yamada , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Tom Rix , linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: [PATCH v2 3/4] modpost: remove unneeded initializer in section_rel() Date: Sun, 3 Dec 2023 18:49:33 +0900 Message-Id: <20231203094934.1908270-3-masahiroy@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231203094934.1908270-1-masahiroy@kernel.org> References: <20231203094934.1908270-1-masahiroy@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sun, 03 Dec 2023 01:50:23 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784253803118672779 X-GMAIL-MSGID: 1784253803118672779 This initializer was added to avoid -Wmaybe-uninitialized (gcc) or -Wsometimes-uninitialized (clang) warning. Now that compilers recognize fatal() never returns, it is unneeded. Signed-off-by: Masahiro Yamada --- Changes in v2: - Split into a separate patch scripts/mod/modpost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index c13bc9095df3..3233946fa5f6 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -1421,7 +1421,7 @@ static void section_rel(struct module *mod, struct elf_info *elf, for (rel = start; rel < stop; rel++) { Elf_Sym *tsym; - Elf_Addr taddr = 0, r_offset; + Elf_Addr taddr, r_offset; unsigned int r_type, r_sym; void *loc; From patchwork Sun Dec 3 09:49:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 172924 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp2158901vqy; Sun, 3 Dec 2023 01:50:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IHSxXeesj1dZezQ8MfcVcM8GAwhJJSWZcncBW2D78UKuEDf5u4q3tll38Raov09+0XReeUX X-Received: by 2002:a17:90b:380a:b0:286:8f8f:5e3d with SMTP id mq10-20020a17090b380a00b002868f8f5e3dmr956556pjb.30.1701597024759; Sun, 03 Dec 2023 01:50:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701597024; cv=none; d=google.com; s=arc-20160816; b=VmFzxD/ZJ6ufaamtcsCNhcoE8eHiPAhS86IbLEtHG81pKq+TKoG5fv3WmiF3XlCqeb i+ADl01zNoHsqYoEZq3HSHT0F0tyRpuTsPUAngZYJfMbW/AgPjDU+05+CcEb1YPpLMcA uBcct1o9VvHybG+EJTEJwrtUOMvkQmOo4du9stluUEtKpdKUOCfhnmwN5z0VfksMfvmU LWwoVE4od5EwZkaohB6x4XCuqFeLePl2IkfU6WPBVDLzAmRDo4oMKACZ/se3n8iOFhZ0 lZqUKepmQvv9scxDs8YpYJFZCcw2rB80bXGOp2wqZElZOSiQf04C/J3S8d+u7vRWA9SI hf4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hwc7xDlJ0n7pGo9+0EFSwjGZhyXoLFAjw6CaivdjGok=; fh=md/tq5L9/pRMvAD62d0GqWddCfc+JZG0bPold5NI6Q8=; b=KQ6efHBcHQgorTgtuCEr1tciQ7UTXX/x7uCP2+nEw63qxuS1nQTYoKvw0WeFwK2uTL ZjGYgcOTW9cuIi4FBtgVSCiBvHZnfA8hkoqVELjoFnTcSl4My5wJ7y3vPZVpn6F+HBIe T1Avj/oys8CFbxxnHYb2WmePK2NRi05sODm73IRV04mxQ4EJcpiXYgXAYermLNhDwFPF y/TEgDCjRkdLEw9oyZu1pSqJWPn0kFJToF+35OVZ0kEXJLI1zjay/NX7Kir7rrxieg5T 4AzJ6KhA7+BIZ35EOqL7HczYCieVLF4OyyetG4N9hZ0E1bjzc5KlrFjWS8INzIYXNxlE y1sA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="VNv2/I0y"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id oc10-20020a17090b1c0a00b00280479459f7si8741619pjb.50.2023.12.03.01.50.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Dec 2023 01:50:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="VNv2/I0y"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id CF9F4809788F; Sun, 3 Dec 2023 01:50:23 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233349AbjLCJt4 (ORCPT + 99 others); Sun, 3 Dec 2023 04:49:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233328AbjLCJty (ORCPT ); Sun, 3 Dec 2023 04:49:54 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2BC3DA for ; Sun, 3 Dec 2023 01:50:00 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 099D3C433CB; Sun, 3 Dec 2023 09:49:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701597000; bh=3fREL+3pDb0+f3gpXJDWy/Z+fjSVV4sYVi1Ga8WtaHw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VNv2/I0y1QaQgNoItB2fCs1RK2AgJtD5NdVHjX92RWhrLjqitS+cRVeZ2kXIsGx8o QER7zjLtrPvCDVpDGyc3FQjR1VGYW3GSPNVdnBPNTd/weX/xjWmn3qQ+K1pop+vvcg GFEsnbwuHQbnxVpzlV+Nq196TtY3G02V8Ierf2Za1v9CKfTZdcZyFKZPK5izOAbYYl ZOpkXYUBx5i1XQIVUb6TT7YK1VqGX0xTOhvmbj9cb/vYAtzzh/DiO1FD7tn+eXX70Q AtM5DljHuHWcL9uKAyXzFm49NNpivgg0zf9/3DC1s2cXsmpzfMak3IwicdamK9Zc7m G3A13S5DzjkPg== From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Masahiro Yamada , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Tom Rix , linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: [PATCH v2 4/4] modpost: remove unreachable code after fatal() Date: Sun, 3 Dec 2023 18:49:34 +0900 Message-Id: <20231203094934.1908270-4-masahiroy@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231203094934.1908270-1-masahiroy@kernel.org> References: <20231203094934.1908270-1-masahiroy@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sun, 03 Dec 2023 01:50:23 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784253801664758978 X-GMAIL-MSGID: 1784253801664758978 Now compilers can recognize fatal() never returns. While GCC 4.5 dropped support for -Wunreachable-code, Clang is capable of detecting the unreachable code. $ make HOSTCC=clang HOSTCFLAGS=-Wunreachable-code-return [snip] HOSTCC scripts/mod/modpost.o scripts/mod/modpost.c:520:11: warning: 'return' will never be executed [-Wunreachable-code-return] return 0; ^ scripts/mod/modpost.c:477:10: warning: 'return' will never be executed [-Wunreachable-code-return] return 0; ^ 2 warnings generated. Signed-off-by: Masahiro Yamada Reviewed-by: Nathan Chancellor --- Changes in v2: - Change the patch order - Update the commit description and add warning example. scripts/mod/modpost.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 3233946fa5f6..e2bc180cecc8 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -476,11 +476,9 @@ static int parse_elf(struct elf_info *info, const char *filename) fatal("%s: not relocatable object.", filename); /* Check if file offset is correct */ - if (hdr->e_shoff > info->size) { + if (hdr->e_shoff > info->size) fatal("section header offset=%lu in file '%s' is bigger than filesize=%zu\n", (unsigned long)hdr->e_shoff, filename, info->size); - return 0; - } if (hdr->e_shnum == SHN_UNDEF) { /* @@ -518,12 +516,11 @@ static int parse_elf(struct elf_info *info, const char *filename) const char *secname; int nobits = sechdrs[i].sh_type == SHT_NOBITS; - if (!nobits && sechdrs[i].sh_offset > info->size) { + if (!nobits && sechdrs[i].sh_offset > info->size) fatal("%s is truncated. sechdrs[i].sh_offset=%lu > sizeof(*hrd)=%zu\n", filename, (unsigned long)sechdrs[i].sh_offset, sizeof(*hdr)); - return 0; - } + secname = secstrings + sechdrs[i].sh_name; if (strcmp(secname, ".modinfo") == 0) { if (nobits)