From patchwork Sat Dec 2 14:03:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 172849 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp1782939vqy; Sat, 2 Dec 2023 06:16:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IE9b6JwBLmhtt9LnhaCPWGTU9sO8YKGUXV9slbxMHYu5lcPoV2mviB0hS1GHcWX07blgBI5 X-Received: by 2002:a17:902:cec1:b0:1cf:6d8c:c8f1 with SMTP id d1-20020a170902cec100b001cf6d8cc8f1mr394395plg.46.1701526563048; Sat, 02 Dec 2023 06:16:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701526563; cv=none; d=google.com; s=arc-20160816; b=sJVuZQZnllW4e1WPz1roQVriCl1gqfgFWoFpZo5muJgyXu7fZSkDdWzg6bJk/e8yq4 YGnNOw1hDqmZPiEEfVI3C2HRFNY+gr31/c2RqqoThkj5bJn7jTRrANovZ3x4HG4Nc+Nl ONHBLaN4NZBv3Vi8ty4PTpQSKAll/wRYeC578zOfId6sDEL4/60h5TN/gOEO5B0KyQfJ lMPfzwU0m0blqL3vDAqF+osorFJHLSjgNWjKFRG5MsD+8QCW3lV/j0HGHh7liUXDB8l0 9rQweigA/ol7hHKUfnSy+wfuFXDokr5wViWmqwNXjj+TAtQjbgeYZBzNwF7Ff+RVOO8W byFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=uOokWDl+oyaUKWX5QKHg5XCfz8ADRQZshUfy4hkE0cY=; fh=srb/EijQIrMEdOeqn3qQX6qrsAGyqHAqeSFkl/qDdLM=; b=vBkCBFvt0BT8mlE75vQCRr/228F1Zmb1ejqhHAmpY233fZ7/k1YeWTOlxI0KOuCRQU hq2hKIY568T/4SwB0NgUVz40tHTU0hr/oVG9fpQL0j2VLUx8LlDByANzYlMzC8jUdYn4 OyLz2iqqUQhrERPuFp8L6FuyfAUxxE7hhlIy2zpASzlf4iaUkVaDmWoEoqBMAyUovdlg M6SfD5spigdlSAc6lUKMGdBL0Pn7Wp+uPf1k9X9CwxUNlZi1WcmcOYGvKa1HtHkjGXoG ynheAD2Dc8Wgffa/X1pOAbTA7SUthJDp9L7w5WinOHlbqpYDVjOa6PckCMawyL8rK526 XtVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="oQ72I/i6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id x4-20020a170902ec8400b001d06beccdc0si1488056plg.596.2023.12.02.06.16.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Dec 2023 06:16:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="oQ72I/i6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 508D6805F941; Sat, 2 Dec 2023 06:16:01 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232994AbjLBOPr (ORCPT + 99 others); Sat, 2 Dec 2023 09:15:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232975AbjLBOPo (ORCPT ); Sat, 2 Dec 2023 09:15:44 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8563A12E for ; Sat, 2 Dec 2023 06:15:51 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E82F8C433C8; Sat, 2 Dec 2023 14:15:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701526551; bh=fwdhwt3eDeqZRwcBFACwkkWnjPtptuE2Wu5b5bty77c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oQ72I/i6LN9WRbDkrkT9M9kOLmigG1FyWGGpxqvKDzK8Ed7mBok7Xna5Rno92B6gj /XX0nb16HB6UkRBDog/J/WWTPO/5HtSFde3mvKL+Yo4z4M7PJyanFKMRJ0ecX0vpwu kW0h6cCwkSUUIOzNSolHE+92AyLd7syaH+iL98NweXOkA4xA5WEnnmMAVNqHUvYlDN fYOdl/nIa/HYzblmbtfeba1gDN0VzQEY7gta52VNWuc+y4S4MLdaGLanZV9Ne5H8uM yxx/DRCMIs+4u1zB+ol2wV6E7lqNnlKjcWNXa+lYHWlMxDrNxj8nY5kExp7zxqauhT 62de3GKfgbhDQ== From: Jisheng Zhang To: Paul Walmsley , Palmer Dabbelt , Albert Ou Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] riscv: select ARCH_USE_CMPXCHG_LOCKREF Date: Sat, 2 Dec 2023 22:03:22 +0800 Message-Id: <20231202140323.315-2-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20231202140323.315-1-jszhang@kernel.org> References: <20231202140323.315-1-jszhang@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sat, 02 Dec 2023 06:16:01 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784179917506856655 X-GMAIL-MSGID: 1784179917506856655 Select ARCH_USE_CMPXCHG_LOCKREF to enable the cmpxchg-based lockless lockref implementation for riscv. Using Linus' test case[1] on TH1520 platform, I see a 11.2% improvement. On JH7110 platform, I see 12.0% improvement. Link: http://marc.info/?l=linux-fsdevel&m=137782380714721&w=4 [1] Signed-off-by: Jisheng Zhang --- arch/riscv/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index 433ec617703e..da4ae76a892c 100644 --- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -51,6 +51,7 @@ config RISCV select ARCH_SUPPORTS_PAGE_TABLE_CHECK if MMU select ARCH_SUPPORTS_PER_VMA_LOCK if MMU select ARCH_SUPPORTS_SHADOW_CALL_STACK if HAVE_SHADOW_CALL_STACK + select ARCH_USE_CMPXCHG_LOCKREF if 64BIT select ARCH_USE_MEMTEST select ARCH_USE_QUEUED_RWLOCKS select ARCH_USES_CFI_TRAPS if CFI_CLANG From patchwork Sat Dec 2 14:03:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 172850 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp1782993vqy; Sat, 2 Dec 2023 06:16:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IEAHD4/m20Avc97R8MhNSJV4nYiXsm6IjVhsajXAmvsI7zOehGX1i3q6DERdQLuyfjdXBig X-Received: by 2002:a05:6a00:1701:b0:6ce:2731:d5cd with SMTP id h1-20020a056a00170100b006ce2731d5cdmr485441pfc.62.1701526568409; Sat, 02 Dec 2023 06:16:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701526568; cv=none; d=google.com; s=arc-20160816; b=mV5mG+TRe+DulyVs8bP2Dtrcq+IDuPlC8I0VNU/+E8sGr5W4IMchhdnpk2DqFqncV+ P29YarNQoPTIHIDGHRz+VwdvDRS4kTwoC1h0C1fm5Zj9qjogTOb55xLa5Km0dVtBUIh9 ZE8ZAYccv3iA7n6NEKfROVRTYHg9lJF4e3J10uICaNICpert//RRFTmmDr7Y0KrSQKTc ST2JzqcT+hv/Eh9myet/mGJRz3fd6p0ZHuEkGAfU6uqA+pMln/0PbjQA0W71d0lZNdEL 6lDiBUexbcubUukz4lQa8V3tMeAAjUJYqHc5UHDoPUUEqFMSvbRoNNimrKVajbVIEU0v rbHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=UR+bEbpPE9n0U4RvU6vv0pWumxOhLGxna0+vV2kSvR4=; fh=srb/EijQIrMEdOeqn3qQX6qrsAGyqHAqeSFkl/qDdLM=; b=jGgw95UENQXkAGWC2+lf2F6IkYe94s5QwBaeQxJEftmlLnmzVihLV4vpf/fXPION/w HT6cJALvYSsaW0soDitvrtPdkOd/hbgVorHis/ERakQc1Y/zgXNBvcV9vHVMyfkA/tDg oECgX4Z5VIjTxwLuLqSfkYcSxxN+yw+FLfSXT4GRp646LTmnXT3Ymc8gfelohlMcjChw CpyFpfRJi5RdDA0Fi0Qb6cuHxSQMFkZq2eP9DpdlMGwPAqHM7mpV6vkwwR0slqzs52Cy olt1sBDap3im1MIU9ltz9OGOW0qTfr3ggGgsZfkGkStVuW9UMygtHAULnSASDDXcQyQn +/jQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ial5msYM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id m18-20020a056a00081200b006c3077a3400si5126623pfk.279.2023.12.02.06.16.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Dec 2023 06:16:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ial5msYM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id B3B9C8042D25; Sat, 2 Dec 2023 06:16:02 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233011AbjLBOPu (ORCPT + 99 others); Sat, 2 Dec 2023 09:15:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232987AbjLBOPq (ORCPT ); Sat, 2 Dec 2023 09:15:46 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A39A11C for ; Sat, 2 Dec 2023 06:15:53 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3574C433B6; Sat, 2 Dec 2023 14:15:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701526552; bh=f5wYmmEc/6YNMD4xeSRCsSaZscE5Ri2p04isx1ogm+s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ial5msYMisNvSBLgaIv84BoLRvHY5kBgWPY2YeInOEJ03ZnAa+AU8INHjN48bxfof KJx5rAacZfFcgF1QYUUOkQyJSThnvmHmzlOlgdLg0I+occ47+4DyG91NJKP86M4RDs LPq3zhIgi1Gv/xvP4arCU2uAa8uhs2hTnlcWPYX0n4bSqHrVaf0RvoNZtQUL4xRKlF D1tCHvXQdP9MsjEsAAGX5Zq8SoFhlWsJdRz2FFTYbuS7DP8DJ3wgSFseWk4SMOzgF4 z0dqLn3uX6cT306Y3tErtpAcxAmmQ39Yhnb8KVYCdM27TkerisIXDEeXZ71zPmg/nT KSHPimVFypkpg== From: Jisheng Zhang To: Paul Walmsley , Palmer Dabbelt , Albert Ou Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] riscv: cmpxchg: implement arch_cmpxchg64_{relaxed|acquire|release} Date: Sat, 2 Dec 2023 22:03:23 +0800 Message-Id: <20231202140323.315-3-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20231202140323.315-1-jszhang@kernel.org> References: <20231202140323.315-1-jszhang@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Sat, 02 Dec 2023 06:16:02 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784179922728201482 X-GMAIL-MSGID: 1784179922728201482 After selecting ARCH_USE_CMPXCHG_LOCKREF, one straight futher optimization is implementing the arch_cmpxchg64_relaxed() because the lockref code does not need the cmpxchg to have barrier semantics. At the same time, implement arch_cmpxchg64_acquire and arch_cmpxchg64_release as well. However, on both TH1520 and JH7110 platforms, I didn't see obvious performance improvement with Linus' test case [1]. IMHO, this may be related with the fence and lr.d/sc.d hw implementations. In theory, lr/sc without fence could give performance improvement over lr/sc plus fence, so add the code here to leave performance improvement room on newer HW platforms. Link: http://marc.info/?l=linux-fsdevel&m=137782380714721&w=4 [1] Signed-off-by: Jisheng Zhang --- arch/riscv/include/asm/cmpxchg.h | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/arch/riscv/include/asm/cmpxchg.h b/arch/riscv/include/asm/cmpxchg.h index 2f4726d3cfcc..6318187f426f 100644 --- a/arch/riscv/include/asm/cmpxchg.h +++ b/arch/riscv/include/asm/cmpxchg.h @@ -360,4 +360,22 @@ arch_cmpxchg_relaxed((ptr), (o), (n)); \ }) +#define arch_cmpxchg64_relaxed(ptr, o, n) \ +({ \ + BUILD_BUG_ON(sizeof(*(ptr)) != 8); \ + arch_cmpxchg_relaxed((ptr), (o), (n)); \ +}) + +#define arch_cmpxchg64_acquire(ptr, o, n) \ +({ \ + BUILD_BUG_ON(sizeof(*(ptr)) != 8); \ + arch_cmpxchg_acquire((ptr), (o), (n)); \ +}) + +#define arch_cmpxchg64_release(ptr, o, n) \ +({ \ + BUILD_BUG_ON(sizeof(*(ptr)) != 8); \ + arch_cmpxchg_release((ptr), (o), (n)); \ +}) + #endif /* _ASM_RISCV_CMPXCHG_H */