From patchwork Thu Nov 30 14:16:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 171929 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp419135vqy; Thu, 30 Nov 2023 06:17:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IHkxPecLjteFH2hwa5bZsT5a4jvfyzslV7Y8GAegitP3HWIn/UkSVKr02pus0Jo15RypM1N X-Received: by 2002:a05:6a20:4423:b0:187:a6ee:9d6f with SMTP id ce35-20020a056a20442300b00187a6ee9d6fmr37825233pzb.0.1701353847652; Thu, 30 Nov 2023 06:17:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701353847; cv=none; d=google.com; s=arc-20160816; b=N0CEtyTUGhB9dR2METGcbGGg48RXos8n6kVFroR7lPZhs9arOU7/cN2YlIqSPS9fy/ ZIMEu667SP/9JqbCC2XgC6LFwRaYfwjV9RdVYk9q8rDfpDhh7uzc80orHaMLLW5SJhGN zmbkZ6Jclg16Lsx9tQInNKMK61Ulid15U9v4v5Dv9+ILgjLJLPcpoRtjCP09RXfimKSx p3fiVlvAb56/t1P385WgEV3PbldlXxwKn85lB9MVgGzxWfY7a3JSy62aApOdw7UbB1AW RWiwD9TjPjLxyDdSyWHuntT3YHK1z1y/wJnkjJL0qOFH19Jm9e/1oIJ/30S43ooigza9 1kgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9yGi3UQjgH7vKIKdKQCwE11iHS9JPf1l9kS7cSUyqbg=; fh=yrurfj0wqsNBtuv2/DS7hXM5gjUdNl0RGba7zZuGnHQ=; b=PjPqk0+VKZ7ogXOyaZ/U9qXSITLFaSmaanJd3gYn6pK41T1KKpUmtBX/atAO7h7aMJ iEP5HOZvHPRiU1ADv6FIxaxk1V6edtkZV9CPJf9kjVe1xuypTsruUCSjo9g5yHskNlEA 911F4NTIrVVmV/5qldzvEidledtqGOrmUTNIPHx3kc1p3j5FMNLCPxT0WvLaXqmBPowe xBvlRbadg7b0kgx1xhRsBf4p6YMc1xDRxBdnaQhnfLWRTR4hgDZRILB2FY02Loh6dxh+ 3hKQW8jZSFdv/V21NSivFpnN0ysJl6fAiDnUacEKUgD3kdKdG/GrfkMdNK70T8lKYUHy TAxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=XvsyvLyM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id k190-20020a6384c7000000b005c2783b71cesi1268128pgd.661.2023.11.30.06.17.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 06:17:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=XvsyvLyM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 514608026DCA; Thu, 30 Nov 2023 06:17:25 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345931AbjK3ORL (ORCPT + 99 others); Thu, 30 Nov 2023 09:17:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345896AbjK3ORJ (ORCPT ); Thu, 30 Nov 2023 09:17:09 -0500 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5054BBD for ; Thu, 30 Nov 2023 06:17:16 -0800 (PST) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a08e4352992so141214666b.1 for ; Thu, 30 Nov 2023 06:17:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1701353834; x=1701958634; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9yGi3UQjgH7vKIKdKQCwE11iHS9JPf1l9kS7cSUyqbg=; b=XvsyvLyMPtI3GoxpMgck/+6f8D16FWCeyBAj4ANEBmPkBmx+q+vTAUOUb8BejlHyjk EQZvhWM/8WGmMdji1wmdWlmommNl3gPz8Nz31x6I9zNOoU8PfDbE9d4aOeGGl+4H7Ol1 7Yy3LDZW81uuMf/z8awAtYPRUqtsEkxXVBkbg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701353834; x=1701958634; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9yGi3UQjgH7vKIKdKQCwE11iHS9JPf1l9kS7cSUyqbg=; b=hBFxxQpJSSgylxzxXYrpU9DiAc+gP3rrA1Wvx1J/zYti+DuPEqjL9CysMVmgFYR/+U mRuRMs8CQVSOYFpcCsb8tlvLwAEYA9vhn9+DU2N8l/wKCpSgi7PS15DYI1mkiECorU9q gZxZywz34DLDlgaP60rmHtBwcasfs5Zdk+enbRL+wZuudZdKiYaeQvry2BNyOfCG26pF n0VdnzKREroukOuKfhtQOsQTAslD9W4OS6PRtRG0dbXhqSPIS/hI1YrRvt0avhIns/Ny ssQMgbiHXFLha+nblQhGRz+RL736YXUWq3g/pPfmBW052kcpR76dAUBbOIz+lDGzEkBS IliQ== X-Gm-Message-State: AOJu0YxmWvLSCs2hngBjs81vBvM5JnnSEoAHnOtd+neG0jikm4hHvViz 8YfbjMHd5KbZRarfRZycz6Sshj87dSH/zx5ydhhBmA== X-Received: by 2002:a17:906:15a:b0:9e4:651f:60cf with SMTP id 26-20020a170906015a00b009e4651f60cfmr14558074ejh.1.1701353834502; Thu, 30 Nov 2023 06:17:14 -0800 (PST) Received: from localhost.localdomain ([2001:b07:6474:ebbf:d1eb:b106:516d:db0a]) by smtp.gmail.com with ESMTPSA id my18-20020a1709065a5200b009f28db2b702sm716064ejc.209.2023.11.30.06.17.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 06:17:14 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , michael@amarulasolutions.com, Dario Binacchi , Andrzej Hajda , Daniel Vetter , Dave Stevenson , David Airlie , Frieder Schrempf , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Robert Foss , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v3 01/10] drm/bridge: Fix bridge disable logic Date: Thu, 30 Nov 2023 15:16:18 +0100 Message-ID: <20231130141705.1796672-2-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231130141705.1796672-1-dario.binacchi@amarulasolutions.com> References: <20231130141705.1796672-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 30 Nov 2023 06:17:25 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783998812155195336 X-GMAIL-MSGID: 1783998812155195336 As explained by the comment of the fixed code, we need to find the next bridge that hasn't set the "pre_enable_prev_first" flag to true. The code, on the contrary, was doing the opposite. So, the order of disabling the bridges couldn't be altered as required by setting the "pre_enable_prev_first" flag to true. Fixes: 4fb912e5e190 ("drm/bridge: Introduce pre_enable_prev_first to alter bridge init order") Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/gpu/drm/drm_bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index 30d66bee0ec6..f66bf4925dd8 100644 --- a/drivers/gpu/drm/drm_bridge.c +++ b/drivers/gpu/drm/drm_bridge.c @@ -686,7 +686,7 @@ void drm_atomic_bridge_chain_post_disable(struct drm_bridge *bridge, */ list_for_each_entry_from(next, &encoder->bridge_chain, chain_node) { - if (next->pre_enable_prev_first) { + if (!next->pre_enable_prev_first) { next = list_prev_entry(next, chain_node); limit = next; break; From patchwork Thu Nov 30 14:16:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 171930 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp419157vqy; Thu, 30 Nov 2023 06:17:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IGcRhdTWrkHBTa1SoERumY4PQr6vRrA4LWCqYnPN1e+45LDQO1s2Vqq/zHyiKJqBp7uFZlx X-Received: by 2002:a05:6870:c86:b0:1f9:77fe:7977 with SMTP id mn6-20020a0568700c8600b001f977fe7977mr30288303oab.13.1701353849624; Thu, 30 Nov 2023 06:17:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701353849; cv=none; d=google.com; s=arc-20160816; b=nmHmhmvrC9XRXxFwHyZ+zPeAykSQbwInbBW1vzq+NgDhKxMRfMuCgLEmcPS0NFfuuv oV/oEsjy0bxnDniRRwGm4emKUfVVLMg4eFU/gBQ8CohhvUOFDC+gJ7MeLT2hZZy0+C3m M1jRk0tRpGRtbLCFF/swwWBm7AqzqPjXLfPp65jZUchyDntir1aAJHvW3FO6HoXuYkcu dFrHe7V9g/VjTRGFQTns9KC9Fgpfli2RWIjXJB/UQuYRHaSIAdC+RYLQHQfbGMjzz2T7 88QViiG5TPHG5qJAkvXlNteFkEtPphOIe6bRfkmGQDeB/gZJ7iWC5b7dk4gsmiP+HZWk T3Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fu0Px4Tbxip0tKoFWKIyTvbcuMI1IJ2fyAiFtPcJOWc=; fh=yrurfj0wqsNBtuv2/DS7hXM5gjUdNl0RGba7zZuGnHQ=; b=WwtXYGbo9tnH83d87DVbvacQ2i9Xc6gVzETDII0XvbK+O2FRwojs1dEcgeeow4X/SF 7a1oF1Qq0Yr2SGiLHVNmOMmjcICGkzoPPkFrWzFI5WbZanIeNbLJ0gh7+iKFtsGXPEGL n9HxQw6Y3aIkKqlYNNrcfguu1Aki+c9m+uTb7A9qsDRqj/CK1Zo1XDevqGMs01aTscEj y+5K9qNkvYqro/x/kQ8tbH+b3B7g7wsT3+tDG/4P3etReIc9sYoT2UWqqlYUbt2PQ5BT uyqIOF6kPYbcHkR03yuMcceDL+WLoUGxcFi+F7BAKdU4zwvyO0X4ZY3OIym2juOwPpw2 rOig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=WKUeHvW1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id l3-20020a056870d3c300b001fac5d6b6b4si443474oag.103.2023.11.30.06.17.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 06:17:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=WKUeHvW1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 59F8F802767C; Thu, 30 Nov 2023 06:17:28 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345946AbjK3ORO (ORCPT + 99 others); Thu, 30 Nov 2023 09:17:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345930AbjK3ORL (ORCPT ); Thu, 30 Nov 2023 09:17:11 -0500 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D404F85 for ; Thu, 30 Nov 2023 06:17:17 -0800 (PST) Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-54bfa9b3ffaso1116953a12.1 for ; Thu, 30 Nov 2023 06:17:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1701353836; x=1701958636; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fu0Px4Tbxip0tKoFWKIyTvbcuMI1IJ2fyAiFtPcJOWc=; b=WKUeHvW1UfvIzoIM+Zt/rulv0IcAV84RRBZR2M9w+hEa2zTAkcpXUF6qRBGaJvF8qT jkzCuRSgpiSm2+wL/YmT8OIWDtisvmGogX4AD/OfzWui44McQKJPsHe6tmZhjY8Cnqtw duO86GnfrgKNjbaa5s1bosIXPWorU6xArM/NI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701353836; x=1701958636; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fu0Px4Tbxip0tKoFWKIyTvbcuMI1IJ2fyAiFtPcJOWc=; b=GfBhR+ynLp5qogncFz59Akjw6wlGCncI88sOTYJCdcoN5JrSMEgUyPPkrS+1+QR7a0 PjuZLFayc3MAibq2sBsV1Db5exGI1RP0arGXRaqw6uXUaDr/kAhM6o1aTWT73vPG7ail uOR/jqZ8VXWmMlkYfiUik+UyPPxr6rAYIAgJc0J8lDD2TW4VkZ9M2wVxsIWSPR+wKaBA OZlYD8Qnrq4ISREQShwOPVPO7U4xdsKx+NUHJ95g0FOG4PzFPTzAeLD5RXcacikPElJ5 +piPAm4QDdwWd6cazYggMkghrbrvnl+aQQ6od/aa7k9Q2tH2/5Udrz98h9gRb7eM61VO 3Ybg== X-Gm-Message-State: AOJu0Ywss+lz0IRuKEQbr8MRmu36gPB7BiR7j6RHSDtsxT6fCUVnpbsX EAqvpjMcoKLMtrstPtiT00Qp9JYqrl76zAVGR2/QCA== X-Received: by 2002:a17:907:1051:b0:a18:bb79:9a0 with SMTP id oy17-20020a170907105100b00a18bb7909a0mr1186409ejb.58.1701353835975; Thu, 30 Nov 2023 06:17:15 -0800 (PST) Received: from localhost.localdomain ([2001:b07:6474:ebbf:d1eb:b106:516d:db0a]) by smtp.gmail.com with ESMTPSA id my18-20020a1709065a5200b009f28db2b702sm716064ejc.209.2023.11.30.06.17.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 06:17:15 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , michael@amarulasolutions.com, Dario Binacchi , Andrzej Hajda , Daniel Vetter , Dave Stevenson , David Airlie , Frieder Schrempf , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Robert Foss , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v3 02/10] drm/bridge: Fix a use case in the bridge disable logic Date: Thu, 30 Nov 2023 15:16:19 +0100 Message-ID: <20231130141705.1796672-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231130141705.1796672-1-dario.binacchi@amarulasolutions.com> References: <20231130141705.1796672-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 30 Nov 2023 06:17:28 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783998814116526767 X-GMAIL-MSGID: 1783998814116526767 The patch fixes the code for finding the next bridge with the "pre_enable_prev_first" flag set to false. In case this condition is not verified, i. e. there is no subsequent bridge with the flag set to false, the whole bridge list is traversed, invalidating the "next" variable. The use of a new iteration variable (i. e. "iter") ensures that the value of the "next" variable is not invalidated. Fixes: 4fb912e5e190 ("drm/bridge: Introduce pre_enable_prev_first to alter bridge init order") Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/gpu/drm/drm_bridge.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index f66bf4925dd8..2e5781bf192e 100644 --- a/drivers/gpu/drm/drm_bridge.c +++ b/drivers/gpu/drm/drm_bridge.c @@ -662,7 +662,7 @@ void drm_atomic_bridge_chain_post_disable(struct drm_bridge *bridge, struct drm_atomic_state *old_state) { struct drm_encoder *encoder; - struct drm_bridge *next, *limit; + struct drm_bridge *iter, *next, *limit; if (!bridge) return; @@ -680,14 +680,15 @@ void drm_atomic_bridge_chain_post_disable(struct drm_bridge *bridge, * was enabled first, so disabled last */ limit = next; + iter = next; /* Find the next bridge that has NOT requested * prev to be enabled first / disabled last */ - list_for_each_entry_from(next, &encoder->bridge_chain, + list_for_each_entry_from(iter, &encoder->bridge_chain, chain_node) { - if (!next->pre_enable_prev_first) { - next = list_prev_entry(next, chain_node); + if (!iter->pre_enable_prev_first) { + next = list_prev_entry(iter, chain_node); limit = next; break; } From patchwork Thu Nov 30 14:16:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 171931 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp419235vqy; Thu, 30 Nov 2023 06:17:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IHrOFNNvYk1OuLBVTUuUtGRqLYiNAbaOpW4XWNelq8C78ZOcSv17agaWHApp5MjLO8f28Pr X-Received: by 2002:a17:90b:3b51:b0:285:b906:a3d3 with SMTP id ot17-20020a17090b3b5100b00285b906a3d3mr15590911pjb.2.1701353855780; Thu, 30 Nov 2023 06:17:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701353855; cv=none; d=google.com; s=arc-20160816; b=oGSzats/ufPrvAt+BVDWROVGooSUpCcJ7bmyeSBrXzp+xY9Ptnd/pwjKJ61+F/sLGu T2vtJ/8pfwBFXror7Bgjhw0nlFudTBkkrlofMyVLb7q9ttDNwGz+aAON4eqo///bQyj/ VaIDwt0v0iWWvFchKve1/c5N6SuF/lLybUiwXJeIXMKls9hDjkp3hZ6rQ6XRq84NJfSb bQ30vHnzMTQ5eUf8jywuLA2OdvIoPIUbW5EIHlSVnpUBL1D99KYiOQoLVJQgVg/R/Vbv vW3SMW2gYTtoPVcR1apxkkG1UAhSjT+mTC1dvd51PCUACvfeTejQs92bOfXropentcIL kB6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=3CX2gA6r/dtvGkH0YEYWwI6mzbAd5lMyIJziHnyg55Q=; fh=m6aHy4GVWeiYcahcFfIzqNn3pzsQZUVlVWbThwuybpU=; b=n5fmUQbdDv7YiM7B8+QMMMoEqxxRYyi9izjeLYHJs1BgF87KpBMprUkyw3vbInT+gk WzOsCPdiPbhDO+/ZIbWOKzf0MuZe4/sSQ0To6GjUplNTO2phF0z2PRJnda3pS3BMnTzj dFVYpErTNm5eOJISt7LUjhS4T5/K6/vyqsSx45URmjyHd27mlVfqhFHOv6FytHvX3NWg MngBHnAutqlgT5CWOk3G6D+YbEX8FXZ7SmeMiTIJUSaSFl3OEJoT6dwgs4L367GZ1iEz sli3oEzSDTPNfkXgbHH0i4q/R29kB0K9dkvof6S6Kc7TmHxbz1JnC04E3R/j1+sTZGUq E3Zg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=NAQQF9CG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id bg8-20020a17090b0d8800b00285ad8fa94esi3493241pjb.126.2023.11.30.06.17.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 06:17:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=NAQQF9CG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id A1B0A8026DF4; Thu, 30 Nov 2023 06:17:34 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345930AbjK3ORR (ORCPT + 99 others); Thu, 30 Nov 2023 09:17:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345896AbjK3ORN (ORCPT ); Thu, 30 Nov 2023 09:17:13 -0500 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79FCE83 for ; Thu, 30 Nov 2023 06:17:19 -0800 (PST) Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-50aabfa1b75so1477409e87.3 for ; Thu, 30 Nov 2023 06:17:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1701353837; x=1701958637; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3CX2gA6r/dtvGkH0YEYWwI6mzbAd5lMyIJziHnyg55Q=; b=NAQQF9CGd2EXG8YvKEnsscjo0HUWWemZLQW4B3vpiXibNdSAvbgLwTIhPVFaF7hMqv UDxUkIZMGog8Ii6zoGQqaG8hahL/4jLyTG8E4H00ocfjnQMezH/bemAFUyoOX8D3uMi1 ICaUmb40+HHBQA3CZD4ztSg0rS61Ime6LCRho= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701353837; x=1701958637; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3CX2gA6r/dtvGkH0YEYWwI6mzbAd5lMyIJziHnyg55Q=; b=IztGEAmRwObVtNcZ4QvpQSilDnWnRoK5WKjOkGLCeLMr3IIIwJDvIuNekmydhovd0f WXNg2G0e/bZ//9YcApbCGT3FDF2PeSmIMMMwrPnuxZP2eYsjHPnofP2dq+a1RDLUB+b4 whDNx8KIzwamS467g+uPM6pWObyK9U0LBikBHvhzTJUaXURQBjIOO1uJXfmF9JabubJ9 2EZCKNFHfqkNvJ3dBQ5Dwvh4RTO1l2brvEq5lTZ+tugwkrz6i0wKdYX+m0VieHVcopz6 iUzH0ycBYON+Ive5CKVLiEMZnWVtnZqeViwjHcxUOukn3S2BzQ0nTZZF8VpoD8WZDpL0 8LEg== X-Gm-Message-State: AOJu0YzmiWwX/ldCI4W7bqUDzOT5mGO8JAEHQAqh9KCYQhspd0Oscg2F 990NFwoSATNJ9I0sMNytc89j5EcDPB/iEZUHVGulNw== X-Received: by 2002:a05:6512:3d88:b0:50b:c910:dd00 with SMTP id k8-20020a0565123d8800b0050bc910dd00mr3629996lfv.46.1701353837401; Thu, 30 Nov 2023 06:17:17 -0800 (PST) Received: from localhost.localdomain ([2001:b07:6474:ebbf:d1eb:b106:516d:db0a]) by smtp.gmail.com with ESMTPSA id my18-20020a1709065a5200b009f28db2b702sm716064ejc.209.2023.11.30.06.17.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 06:17:17 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , michael@amarulasolutions.com, Dario Binacchi , Andrzej Hajda , Daniel Vetter , David Airlie , Inki Dae , Jagan Teki , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Maarten Lankhorst , Marek Szyprowski , Maxime Ripard , Neil Armstrong , Robert Foss , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v3 03/10] drm: bridge: samsung-dsim: enter display mode in the enable() callback Date: Thu, 30 Nov 2023 15:16:20 +0100 Message-ID: <20231130141705.1796672-4-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231130141705.1796672-1-dario.binacchi@amarulasolutions.com> References: <20231130141705.1796672-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 30 Nov 2023 06:17:34 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783998820615088602 X-GMAIL-MSGID: 1783998820615088602 The synaptics-r63353 (panel-bridge) can only be configured in command mode. So, samsung-dsim (bridge) must not be in display mode during the prepare()/unprepare() of the panel-bridge. Setting the "pre_enable_prev_first" flag to true allows the prepare() of the panel-bridge to be called between the pre_enabled() and enabled() of the bridge. So, the bridge can enter display mode only in the enabled(). The unprepare() of the panel-bridge is instead called between the disable() and post_disable() of the bridge. So, the disable() must exit the display mode (i .e. enter command mode) to allow the panel-bridge to receive DSI commands. samsung_dsim_atomic_pre_enable -> command mode r63353_panel_prepare -> send DSI commands samsung_dsim_atomic_enable -> enter display mode samsung_dsim_atomic_disable -> exit display mode (command mode) r63353_panel_unprepare -> send DSI commands samsung_dsim_atomic_post_disable Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/gpu/drm/bridge/samsung-dsim.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index be5914caa17d..15bf05b2bbe4 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -1494,7 +1494,6 @@ static void samsung_dsim_atomic_pre_enable(struct drm_bridge *bridge, return; samsung_dsim_set_display_mode(dsi); - samsung_dsim_set_display_enable(dsi, true); } } @@ -1507,6 +1506,7 @@ static void samsung_dsim_atomic_enable(struct drm_bridge *bridge, samsung_dsim_set_display_mode(dsi); samsung_dsim_set_display_enable(dsi, true); } else { + samsung_dsim_set_display_enable(dsi, true); samsung_dsim_set_stop_state(dsi, false); } @@ -1524,6 +1524,8 @@ static void samsung_dsim_atomic_disable(struct drm_bridge *bridge, if (!samsung_dsim_hw_is_exynos(dsi->plat_data->hw_type)) samsung_dsim_set_stop_state(dsi, true); + samsung_dsim_set_display_enable(dsi, false); + dsi->state &= ~DSIM_STATE_VIDOUT_AVAILABLE; } @@ -1532,7 +1534,8 @@ static void samsung_dsim_atomic_post_disable(struct drm_bridge *bridge, { struct samsung_dsim *dsi = bridge_to_dsi(bridge); - samsung_dsim_set_display_enable(dsi, false); + if (!samsung_dsim_hw_is_exynos(dsi->plat_data->hw_type)) + samsung_dsim_set_stop_state(dsi, true); dsi->state &= ~DSIM_STATE_ENABLED; pm_runtime_put_sync(dsi->dev); From patchwork Thu Nov 30 14:16:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 171935 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp419672vqy; Thu, 30 Nov 2023 06:18:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IFx0wtjQw7hnIlsUNkqvcPcfCTvTQ7AobY09h5Kj/9UpXJupFMXLUgUOaexx81WuevYIN/U X-Received: by 2002:a05:6a21:190:b0:18b:9041:5729 with SMTP id le16-20020a056a21019000b0018b90415729mr29787474pzb.17.1701353888119; Thu, 30 Nov 2023 06:18:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701353888; cv=none; d=google.com; s=arc-20160816; b=xd9CiXixpjZIRFXMvtH5Fb5T+XsSpSdmG3qplqirPJbB6lPSEsPqEEVaWgerE1xWvs K+Mmyp+g2p3a2HgUA9KMMvUdsFLBIW/H0ZFiEWA48iWCMgLueQv+V3r7I4DOtGAnFzC+ 1k0dJd7/Mh1wg0N+nKPW7o61OEDH7SsPvZ0E5eyJezdwxaAtEOWZQllaGCieNIc7Fx0s Y4NcGSQcQKFgnsjt1NRzs+taGsfWrl7YsQ/cewOxJV/J13DdnvfeKqgjToKAhs5ImPp1 G4VIJk1SgwIEw3MLn7rUCjltV6N2HHkKW+y0npOir4AbvHPA3ldTyhgi4YBOwTHCeYw6 yv0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=LRuU/Yf3+WOs2/s3BqHchrpBnPmBNhkaR5Vfu/UBGmU=; fh=m6aHy4GVWeiYcahcFfIzqNn3pzsQZUVlVWbThwuybpU=; b=c8svHtmtRf3unWNcx2VkEfBDNiMQmmPxkarVxMvieC1NQmIYvRb1h4UJbK4gYehGLd bPKegHliKi3b4TflDmKfbhlSeKAbJtou9wTM4vQoya2gFM0uofyr0EjCfZxN/7PZ3Xk7 mk2SzyH2XZwj3WFDlRlwLQqDIuVX1euasIzBd+ksHa8kbjCLqdN3+/ufg6Qr1xQNkdbA fWjft2b0bGHAWcLykgu87NnuTcp+YzwP3DibQ7V7c8Nxi74qtc5JSRmjcQQLCKWE+BpE TDWvxo35rQ91GB8tKW1AJpI6QEro6ltugWtHJKUYzBYRlPIu7d+p76udWPu7gxMHAklO o43Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=ajTJeqhw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id e24-20020a656898000000b005b90b2d917asi1351936pgt.278.2023.11.30.06.18.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 06:18:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=ajTJeqhw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 8333F80C7776; Thu, 30 Nov 2023 06:18:02 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345989AbjK3ORU (ORCPT + 99 others); Thu, 30 Nov 2023 09:17:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345940AbjK3ORO (ORCPT ); Thu, 30 Nov 2023 09:17:14 -0500 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60BD385 for ; Thu, 30 Nov 2023 06:17:20 -0800 (PST) Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-a18b0f69b33so111519566b.0 for ; Thu, 30 Nov 2023 06:17:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1701353838; x=1701958638; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LRuU/Yf3+WOs2/s3BqHchrpBnPmBNhkaR5Vfu/UBGmU=; b=ajTJeqhwBV4+OZhstNIbMDi7arqPtoNOm1xx9NQjMJRhhWsucF8UiZ+5bEG31aEPHW uJVtsL3MQZyKn3JUVPrekmEALUfcV66F4iTPnyY0Nx5Y2OzBnIEr/j6xLe/vl00/KlJR LQuXadqo+stOuAfN/p0JVA0gKQ+kZh6O+xQC0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701353838; x=1701958638; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LRuU/Yf3+WOs2/s3BqHchrpBnPmBNhkaR5Vfu/UBGmU=; b=N0W+KJSr6ol8XFyAWZRdmf3eJu62Sgsipf4/gAIzA5zwhY/PM1al0zrYtoyksxb/wR 8sYNnuFob0aCFrPXRO0lMwvU901eEeS2/VUYm7lHY9g0nYrLHpHWK4oMs7j1xxeqqi2b g/TKibGFkUdsDyTMVx8nA7IXJaE1DYqCzzQw8YgSjVFutYdH0vK9KTcYJ2rdRY3W0Iaz PKT9O9x81Io/R3/0HOXjRdLEFcdoEKUVtO5sEj2uFzBgOYYlHOIf1POaBJXr2/R7y46H PYslnacqk4XuKVEOt7Khwlh1kaOxEaVkQ6MSAvrOY+oFQ2cKnkf9LpA4879oMiZfPKeO CFDw== X-Gm-Message-State: AOJu0Yy49s+KkB5Kj4wUIzxsOK8jR7V2aoj6yqFuQTn9sW+Q4gTv5Qgb MDJOLhO3PZb5gdId7bP8ip8tQN4M3Vke3AI4VL9QGw== X-Received: by 2002:a17:906:20dd:b0:a18:a1e7:5682 with SMTP id c29-20020a17090620dd00b00a18a1e75682mr1828465ejc.14.1701353838727; Thu, 30 Nov 2023 06:17:18 -0800 (PST) Received: from localhost.localdomain ([2001:b07:6474:ebbf:d1eb:b106:516d:db0a]) by smtp.gmail.com with ESMTPSA id my18-20020a1709065a5200b009f28db2b702sm716064ejc.209.2023.11.30.06.17.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 06:17:18 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , michael@amarulasolutions.com, Dario Binacchi , Andrzej Hajda , Daniel Vetter , David Airlie , Inki Dae , Jagan Teki , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Maarten Lankhorst , Marek Szyprowski , Maxime Ripard , Neil Armstrong , Robert Foss , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v3 04/10] drm: bridge: samsung-dsim: complete the CLKLANE_STOP setting Date: Thu, 30 Nov 2023 15:16:21 +0100 Message-ID: <20231130141705.1796672-5-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231130141705.1796672-1-dario.binacchi@amarulasolutions.com> References: <20231130141705.1796672-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 30 Nov 2023 06:18:02 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783998854550749069 X-GMAIL-MSGID: 1783998854550749069 The patch completes the setting of CLKLANE_STOP for the imx8mn and imx8mp platforms (i. e. not exynos). Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/gpu/drm/bridge/samsung-dsim.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index 15bf05b2bbe4..13f181c99d7e 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -96,6 +96,7 @@ #define DSIM_MFLUSH_VS BIT(29) /* This flag is valid only for exynos3250/3472/5260/5430 */ #define DSIM_CLKLANE_STOP BIT(30) +#define DSIM_NON_CONTINUOUS_CLKLANE BIT(31) /* DSIM_ESCMODE */ #define DSIM_TX_TRIGGER_RST BIT(4) @@ -945,8 +946,12 @@ static int samsung_dsim_init_link(struct samsung_dsim *dsi) * power consumption. */ if (driver_data->has_clklane_stop && - dsi->mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) + dsi->mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) { + if (!samsung_dsim_hw_is_exynos(dsi->plat_data->hw_type)) + reg |= DSIM_NON_CONTINUOUS_CLKLANE; + reg |= DSIM_CLKLANE_STOP; + } samsung_dsim_write(dsi, DSIM_CONFIG_REG, reg); lanes_mask = BIT(dsi->lanes) - 1; From patchwork Thu Nov 30 14:16:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 171934 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp419599vqy; Thu, 30 Nov 2023 06:18:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IG5lR4yOsHbWnMqBI1E5bqFuLo6vrs/+9Lmz5B/Csw1ikXukxnBNNjWOOtQ2rDD8bV5151v X-Received: by 2002:a05:6e02:1788:b0:35c:789a:ccc7 with SMTP id y8-20020a056e02178800b0035c789accc7mr26156190ilu.2.1701353882756; Thu, 30 Nov 2023 06:18:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701353882; cv=none; d=google.com; s=arc-20160816; b=0w7uEYz8sRlLRgjFwWfG/vTnlOKVIpVWo/U/Zw+LXp6++N4HDCin+SPFalK2z51iFM NU0o/ovVTueNQO3eFA8Jrv1DKq+iHhDbi492s0OmA/SsOwNnqo67VxqxOdXMJNhDcABh +ZQJB9JSRT+q75DxbYpdixX+m8dVqDQLn8w0O3BBmKev9+aMHh60BvW9PacnWzWZ0Qsg oMDKsft6dXVnUrDJpVvNk8QODNsIPc7LmMEelAe3bLsqT2FkGHLH+MaOYdCx+xFjzv7T MbTxUgrsb0VKkhPeXu8sksxa/toTNC4k47bACWLHfYS/h1E53HXX5jF1fWDSXcWEGFNA oDPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=3QJ1tzyCpIHFa1ha6myU5p3ee5DYOXcZKQquWzA0n00=; fh=6zMG0Z8XcspgSxDk55siqf83pNQJKdG1GaqIeIrDDYI=; b=qPsrufWLOPkmGMq9wQbZ82o7e55AHBO4oWyFjTeNF+f28SmWUftGGK8Mrcc18Vie9B pY6HpYl9abgUU+3o5enU+iHJM9dOUDB5poifAqYZ6r7Ai008mY/EGHzJ10z80rJ3feln D/jp8w5pQmGVXCF1IOXX1Z4uqMIEWAffrcwhVIBV2yLzg7SRHooEmThOUeGOT5OSM9SA icz9b+6HLiE97Z2amvk0lXwxCIUBjSGff4lk9E6R6Kp+kvUhbbzvHjESn6ygmzpTKzEu VQl25HwyY1s1Zl6qsvb2qPJSoGNyd1Q5Iyr967kju8YLiq8zRu2He37v/Iw0VUOP7KkN k2ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=d+FcSy+i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id y64-20020a636443000000b005c200f02d9asi1464451pgb.621.2023.11.30.06.18.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 06:18:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=d+FcSy+i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 65366826EEB6; Thu, 30 Nov 2023 06:17:59 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345960AbjK3ORX (ORCPT + 99 others); Thu, 30 Nov 2023 09:17:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345964AbjK3ORQ (ORCPT ); Thu, 30 Nov 2023 09:17:16 -0500 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9BDAD46 for ; Thu, 30 Nov 2023 06:17:21 -0800 (PST) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-a18b0f69b33so111525166b.0 for ; Thu, 30 Nov 2023 06:17:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1701353840; x=1701958640; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3QJ1tzyCpIHFa1ha6myU5p3ee5DYOXcZKQquWzA0n00=; b=d+FcSy+iKVU4utz8rVdzzkULsnP/Ejrsqb/ZITpQbK5m9PGkBDP6C9ykBoFT1Ee89w xEBMuHYUnIExDVXBZXVoD8gWryyuX4KPB4nBAaaN+n61eLhIyMR4cphlXXWfnSwNZSRh tKOFm1eaLGH9G+lGKrLk36oHXhcZeCagdulMw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701353840; x=1701958640; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3QJ1tzyCpIHFa1ha6myU5p3ee5DYOXcZKQquWzA0n00=; b=E/FoRNQmGNx4lsJhxTBpS9yqdgPQ2DEseib19Yrj80tVDEkzFtHYfX/fcf/ALB70+P 3M9J6djVpWLwDcAuKHvDlQLMAzzCwqXoaRIy846l+2opcA5uUpQ9snmAJwU10TAXF6Ic G2iXH1C4gq6+Ocd9mUQYl2NoHWt7YBshGISVcUVpqIkUp9WaYu0rn4H70oo1k3Na2mQL mcRXxIQuHe5FVvvnRstcQGEDm3YiHfFyZX66nuQeedhQfDrLNN8MJmV6wlXfOBDD19hX ZKYPVMh9dO3Fkcwj0TMvqvmaaFYQILVYfUDb6Qs6lRxLzhhWjKyrWGa7aD6HMNwVV5LK ESSw== X-Gm-Message-State: AOJu0YxI4SZCscJmcpn6tKZsgxpDBAp4dSXLxl7Ai7fQJUlGDMNZwImL cYl4pGFjC/bvXsgnshP9ppIDit4m8RsbEFI9mbfdKg== X-Received: by 2002:a17:906:2bd1:b0:9e8:2441:5cd4 with SMTP id n17-20020a1709062bd100b009e824415cd4mr15496183ejg.17.1701353840040; Thu, 30 Nov 2023 06:17:20 -0800 (PST) Received: from localhost.localdomain ([2001:b07:6474:ebbf:d1eb:b106:516d:db0a]) by smtp.gmail.com with ESMTPSA id my18-20020a1709065a5200b009f28db2b702sm716064ejc.209.2023.11.30.06.17.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 06:17:19 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , michael@amarulasolutions.com, Dario Binacchi , Krzysztof Kozlowski , Conor Dooley , Daniel Vetter , David Airlie , Jessica Zhang , Krzysztof Kozlowski , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Rob Herring , Sam Ravnborg , Thomas Zimmermann , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH v3 05/10] dt-bindings: display: panel: Add synaptics r63353 panel controller Date: Thu, 30 Nov 2023 15:16:22 +0100 Message-ID: <20231130141705.1796672-6-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231130141705.1796672-1-dario.binacchi@amarulasolutions.com> References: <20231130141705.1796672-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 30 Nov 2023 06:17:59 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783998849001472324 X-GMAIL-MSGID: 1783998849001472324 From: Michael Trimarchi Add documentation for "synaptics,r63353" panel. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi Reviewed-by: Krzysztof Kozlowski --- Changes in v3: - Add 'Reviewed-by' tag of Krzysztof Kozlowski. - Replace "synaptics,r63353" compatible with "syna,r63353", as required by vendor-prefixes.yaml. Changes in v2: - Add $ref to panel-common.yaml - Drop port, reset-gpios, and backlight - Set port and backlight ad required - Replace additionalProperties with unevaluatedProperties .../display/panel/synaptics,r63353.yaml | 61 +++++++++++++++++++ 1 file changed, 61 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/synaptics,r63353.yaml diff --git a/Documentation/devicetree/bindings/display/panel/synaptics,r63353.yaml b/Documentation/devicetree/bindings/display/panel/synaptics,r63353.yaml new file mode 100644 index 000000000000..e5617d125567 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/synaptics,r63353.yaml @@ -0,0 +1,61 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/synaptics,r63353.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Synaptics R63353 based MIPI-DSI panels + +maintainers: + - Michael Trimarchi + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + items: + - enum: + - sharp,ls068b3sx02 + - const: syna,r63353 + + avdd-supply: true + dvdd-supply: true + reg: true + +required: + - compatible + - avdd-supply + - dvdd-supply + - reg + - reset-gpios + - port + - backlight + +unevaluatedProperties: false + +examples: + - | + #include + + dsi { + #address-cells = <1>; + #size-cells = <0>; + + panel@0 { + compatible = "sharp,ls068b3sx02", "syna,r63353"; + reg = <0>; + avdd-supply = <&avdd_display>; + dvdd-supply = <&dvdd_display>; + reset-gpios = <&r_pio 0 5 GPIO_ACTIVE_LOW>; /* PL05 */ + backlight = <&backlight>; + + port { + panel_in: endpoint { + remote-endpoint = <&mipi_dsi_out>; + }; + }; + }; + }; + +... From patchwork Thu Nov 30 14:16:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 171932 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp419319vqy; Thu, 30 Nov 2023 06:17:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IG2LIESUEKtbjZi05eZFiPrhGe0bx+9BPXOYGkMUeiNc9hA4z23EMYdE2fMST4uq3mrpxck X-Received: by 2002:a05:6a20:3d0d:b0:18c:52d:8f79 with SMTP id y13-20020a056a203d0d00b0018c052d8f79mr22922399pzi.62.1701353862381; Thu, 30 Nov 2023 06:17:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701353862; cv=none; d=google.com; s=arc-20160816; b=QfmhUrBSLDuenyP5P5A/p2TPxgoJtl4rEVAJcgoH/PpG2wKPi8NzIOdsu2ZOHxQ9qu okWB79nOjD19Yw07CV6nZYF/WgZvGPs2fUlIuPsNVUP3DndP45iZRfWDPIo5YD8WN+B1 gR1bp52w5AWTifu4iDDnk7qzozrQY6FG/Ttc6X1SIqEnmCRvKNs6e2+yggcD/2maEwSj /gCbCWuv+beeNxPVIs/sqKPz2NPMMTk9Jx8Cnhvj2Z5tcuoQxUOJDd4AalQsLHKvMNK6 goo0DHcPy/PyGtgt40yfC7KGIIebwS+4xRkyq8jmdYPs84/J+hL+xzwhmU+um+ArwpUU 0pRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=BB+8tiThrQ8A3cvAQ5Ca0/LgocfETriGMEf/l26sW2A=; fh=YMCpMfj2GNScjLvWYsHyWUGLqrAoIyNb9XBc8eC5U/M=; b=E6g6MMrjbCbx8DlTFIlvTGQ+TvIH84M/IBO6vXekavqlMptP9JIBq0Umnlckr2rt23 cNP/c2lKJRoS9+EwxvXoqU03eN4DDr9Av+qW/6YshCsyQrnYMh7V2IjWxDLfe8BYDASa 7cQBMM1+P5gIpfHxmzsUn0nKhvsiihvUAd7kS30vSLEW2YG/wVb2GMC3bl0aZ9y0qp+v 8KF7uVekNToT+ZUF1OSfFQsK/70BNMXUn3O+ogIUHo7U+8iigu9xpVPuNaCp93qa2qd2 ZWHD5QQzzfTVCZhiD08Lq8Sfx3qfPRwoQX66lxGAODoYOxq5PAZB1BfwWHdb0FBkKU4q dn3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=IKU7S21Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id u16-20020a056a00099000b006cb4ac19d40si1351287pfg.226.2023.11.30.06.17.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 06:17:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=IKU7S21Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 07A348026AD0; Thu, 30 Nov 2023 06:17:41 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345979AbjK3OR1 (ORCPT + 99 others); Thu, 30 Nov 2023 09:17:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345925AbjK3ORS (ORCPT ); Thu, 30 Nov 2023 09:17:18 -0500 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BDF8BD for ; Thu, 30 Nov 2023 06:17:23 -0800 (PST) Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-50bbfad8758so1357481e87.3 for ; Thu, 30 Nov 2023 06:17:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1701353841; x=1701958641; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BB+8tiThrQ8A3cvAQ5Ca0/LgocfETriGMEf/l26sW2A=; b=IKU7S21QrNn1ZLvl7B/9wQ6K/KO3helYxjvo+Epre1x65qojKycwUZvJRx0YI5pNJw njgTc0KhtLR/K5k1xAOzSa5PJUFylRWpRKFwehDP02WMIUD+3uRigdFi+jNP6MFtH1QL U54Nx4zVvLNS7+S6/Y715AObVxYYBE6GuPd5U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701353841; x=1701958641; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BB+8tiThrQ8A3cvAQ5Ca0/LgocfETriGMEf/l26sW2A=; b=cqqKE482XBM8iC3x94995znXscF5zE4W/VZtMAdUNsqa/Pctv+aU2I0tBjGUP37jDn 4hrPOaC6Sc9ziJPv0D/valJEucdeim0sSH2vVRTC2kgRIWMIVSDmRt3RB1kxzQD9B5b2 53SGHRX8fdlQ8ZtZvCpgohpc3dUbRpL0ex1zvkn5hcW+wr0Z0EwrnSdiiv4rhnVDF8E4 dJqk+LORtPrQvQvsVFubpwCLf6dhyUOmK6kQD06onBkc+bgKomNsEhmXWF2Y6+78hEE+ 6ja6U5KjrURwaXFVKVunW4ilmmPKJ3zCgTKXsnttmG70mmgF5IdSZGqtmuIYzq8//zaH MDQA== X-Gm-Message-State: AOJu0Yzfn3QSniOfQA0O97ztrXRxvok3GfcpwSj1zxpxBi1nWlkrTIpx mRpKlZKRst8y9TurKoTDViCCBgzXCpvasIvyhRWYxQ== X-Received: by 2002:ac2:546e:0:b0:50b:bf92:dd7e with SMTP id e14-20020ac2546e000000b0050bbf92dd7emr5050173lfn.35.1701353841276; Thu, 30 Nov 2023 06:17:21 -0800 (PST) Received: from localhost.localdomain ([2001:b07:6474:ebbf:d1eb:b106:516d:db0a]) by smtp.gmail.com with ESMTPSA id my18-20020a1709065a5200b009f28db2b702sm716064ejc.209.2023.11.30.06.17.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 06:17:20 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , michael@amarulasolutions.com, Dario Binacchi , Daniel Vetter , David Airlie , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Sam Ravnborg , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v3 06/10] drm/panel: Add Synaptics R63353 panel driver Date: Thu, 30 Nov 2023 15:16:23 +0100 Message-ID: <20231130141705.1796672-7-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231130141705.1796672-1-dario.binacchi@amarulasolutions.com> References: <20231130141705.1796672-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 30 Nov 2023 06:17:41 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783998827881292023 X-GMAIL-MSGID: 1783998827881292023 From: Michael Trimarchi The LS068B3SX02 panel is based on the Synaptics R63353 Controller. Add a driver for it. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- (no changes since v2) Changes in v2: - Adjust the timings of the panel reset MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + .../gpu/drm/panel/panel-synaptics-r63353.c | 375 ++++++++++++++++++ 4 files changed, 391 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-synaptics-r63353.c diff --git a/MAINTAINERS b/MAINTAINERS index 012df8ccf34e..c373764b6e64 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6875,6 +6875,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc F: Documentation/devicetree/bindings/display/ste,mcde.yaml F: drivers/gpu/drm/mcde/ +DRM DRIVER FOR SYNAPTICS R63353 PANELS +M: Michael Trimarchi +S: Maintained +F: Documentation/devicetree/bindings/display/panel/synaptics,r63353.yaml +F: drivers/gpu/drm/panel/panel-synaptics-r63353.c + DRM DRIVER FOR TI DLPC3433 MIPI DSI TO DMD BRIDGE M: Jagan Teki S: Maintained diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 99e14dc212ec..d018702be3dc 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -735,6 +735,15 @@ config DRM_PANEL_SITRONIX_ST7789V Say Y here if you want to enable support for the Sitronix ST7789V controller for 240x320 LCD panels +config DRM_PANEL_SYNAPTICS_R63353 + tristate "Synaptics R63353-based panels" + depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE + help + Say Y if you want to enable support for panels based on the + Synaptics R63353 controller. + config DRM_PANEL_SONY_ACX565AKM tristate "Sony ACX565AKM panel" depends on GPIOLIB && OF && SPI diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index d10c3de51c6d..f267d932c2b5 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -74,6 +74,7 @@ obj-$(CONFIG_DRM_PANEL_SHARP_LS060T1SX01) += panel-sharp-ls060t1sx01.o obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7701) += panel-sitronix-st7701.o obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7703) += panel-sitronix-st7703.o obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7789V) += panel-sitronix-st7789v.o +obj-$(CONFIG_DRM_PANEL_SYNAPTICS_R63353) += panel-synaptics-r63353.o obj-$(CONFIG_DRM_PANEL_SONY_ACX565AKM) += panel-sony-acx565akm.o obj-$(CONFIG_DRM_PANEL_SONY_TD4353_JDI) += panel-sony-td4353-jdi.o obj-$(CONFIG_DRM_PANEL_SONY_TULIP_TRULY_NT35521) += panel-sony-tulip-truly-nt35521.o diff --git a/drivers/gpu/drm/panel/panel-synaptics-r63353.c b/drivers/gpu/drm/panel/panel-synaptics-r63353.c new file mode 100644 index 000000000000..d45373de7c9f --- /dev/null +++ b/drivers/gpu/drm/panel/panel-synaptics-r63353.c @@ -0,0 +1,375 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Synaptics R63353 Controller driver + * + * Copyright (C) 2020 BSH Hausgerate GmbH + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include + +#include +#include +#include + +#include