From patchwork Wed Nov 29 22:35:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 171646 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6359:296:b0:164:83eb:24d7 with SMTP id ek22csp21825rwb; Wed, 29 Nov 2023 14:36:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IGeTxBNY4f/s6NBR2VIz7c5kq/fuCHdgUHyF7rntdf7v5S5h9QDf4vpmoqUSTxySJpDvXlP X-Received: by 2002:a17:90b:118:b0:277:68c3:64b9 with SMTP id p24-20020a17090b011800b0027768c364b9mr31996010pjz.5.1701297380407; Wed, 29 Nov 2023 14:36:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701297380; cv=none; d=google.com; s=arc-20160816; b=WY9dTngmlFgpVgOXT6uPqzfFb5/FQgFA1xH9LJ46cje6hD3hpwkkvSgsOLiLLaa3eN SGovWTVG+Mb87Aoaxm/am9sqOk4PQYSg0JG6b/FZoa93bhxncON9pGTyWn4Ra8kfbajO wjp6eOYM7N+IsdsqS8v48MsD5bRhj4i7obB6g5WY55tmoxi8JXe/R17aE9M/2ujYIE9W uvzh02cHFcg/IyttBHCxPRAhNmPIi4kiArPnJWTgunwun+iJHeVYmWB+XbdClKaFnTQw 18jaoSirpeeDxXfpM+uJ62kaJV4lnmg+FKVkuvPIz02Nziu94rBHAZtSacGhy0rysd8D pv2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:mime-version:message-id:date :dkim-signature; bh=WXS7/e2VY4X2gQe3kEWDUpAXAmm4xsAO1n9z3bPt+MA=; fh=ZfnX1ZtZfgq8YHLLEEJEKYHEdgstk51q+Th7TLqhWBg=; b=WNLx+di7ZINzgsrGSMwnMekYEiQ55G8eC6qlOVU2pRAckYi77KqwN5+n4W9yGv/AhD rSot0vz2RFpzoYqrugGkOfmyjKQ25kWVudHEetOvdTLyPKryt/R1IfwBqt8f/RKkjY5g CBeeiEjV3CdmhM/2OBIOfhwqUm/LpuGSpe8kAhg0IjB+CpO1fkolmIj0VCl5U6nU2sCG 7y+DynlyIHk4crKWwBQWztoP9/GWQgcG+ir7pZKgrAVmcgO5cVHDuZRwgEbaJAGNy/Gq 2I+LWXdDzIP9fOm4cxveQ+up98GfmuF7tMrt56IQ2cA6lPiUOyyFEWAk+RFMgmnTsk6a lOXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=j38Jd5Hb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id h24-20020a17090aa89800b002772b8993ebsi2151656pjq.159.2023.11.29.14.36.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 14:36:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=j38Jd5Hb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 9D2B08031AFC; Wed, 29 Nov 2023 14:36:14 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231514AbjK2WgF (ORCPT + 99 others); Wed, 29 Nov 2023 17:36:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231228AbjK2WgE (ORCPT ); Wed, 29 Nov 2023 17:36:04 -0500 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3219C1 for ; Wed, 29 Nov 2023 14:36:10 -0800 (PST) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-db49589f622so337199276.3 for ; Wed, 29 Nov 2023 14:36:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701297370; x=1701902170; darn=vger.kernel.org; h=cc:to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=WXS7/e2VY4X2gQe3kEWDUpAXAmm4xsAO1n9z3bPt+MA=; b=j38Jd5HbasSPeHNKCfmy4mnlVxhAxOWxmBqpBdlqRWcQngjrlYGNIS8/H9NSFysi73 6sc25+fADc0JDTW5gqYuGUF/3k8/OMNPxp0fvEvhjEGsX5Rkn/CGdQttKLVkKUHQRtfN 3FQCi9bOGiGJMXfJdjp9pqIms/IITxcyIsJ09MXzuPl6yj4pLqrYj/qVEeOgN/KtkFnI siOL48+kIUPMMgFYIeXvkw74TqFi79oV7fav9Erm6Zy5betC9OEcjQ/g3+nzp7wgPP98 8LVJx4397j7r1qtJeyPDM3J4pxiiaTn0QKdqgNOEE1Iw6eUQLaRz4bwGDtH099EuPxA9 VJnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701297370; x=1701902170; h=cc:to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=WXS7/e2VY4X2gQe3kEWDUpAXAmm4xsAO1n9z3bPt+MA=; b=DTrK5JGUTJTZ9Ko1BrCsZsN34BnrRSD/1VdlTELu3AfRODgxtoTmnLWO2i7wruGubR dF5ULTLlgWcfHr8Xtajb60kxxIuqrm5qgZAMhth1vTkv/LaMgY/XBcCu9qruTcdsgIpT 5KofVsoYv+cgH++UNoY1V+qjofDrDqdXvN6AVU8zoP/p94dqPYNxzyxV/3iAPmBvxGoU ifPzBGGzCsc8lE9MV/zWYQYcvJFhBDiNOZA0L+JDBxOAhOLbhOpccsGQr947tWcRDlGn E6r6u0RBv//MMQ2w75XBPojxpSjRmgvqPVMNWogxvyhcg1OcdCnPZZbPCmXooWjBjnD1 0mvA== X-Gm-Message-State: AOJu0Yy3mbPSk4dc8DTnqdU60s4sRnEjErXztWlmg8mo+iQYnL4wRLZi okw9JMXKgorVObx46kiq740X1+O6kvoj X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:70ed:81b4:2b6c:fbc0]) (user=irogers job=sendgmr) by 2002:a25:24d8:0:b0:db5:2a4:c55b with SMTP id k207-20020a2524d8000000b00db502a4c55bmr189209ybk.2.1701297369900; Wed, 29 Nov 2023 14:36:09 -0800 (PST) Date: Wed, 29 Nov 2023 14:35:40 -0800 Message-Id: <20231129223540.2247030-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.43.0.rc1.413.gea7ed67945-goog Subject: [PATCH v1] perf stat: Fix help message for --metric-no-threshold option From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Stephane Eranian X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 29 Nov 2023 14:36:14 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783939602099520545 X-GMAIL-MSGID: 1783939602099520545 Copy-paste error led to help message for metric-no-threshold repeating that of metric-no-merge. Reported-by: Stephane Eranian Fixes: 1fd09e299bdd ("perf metric: Add --metric-no-threshold option") Signed-off-by: Ian Rogers --- tools/perf/builtin-stat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index a3af805a1d57..c77a3308d3fb 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -1255,7 +1255,7 @@ static struct option stat_options[] = { OPT_BOOLEAN(0, "metric-no-merge", &stat_config.metric_no_merge, "don't try to share events between metrics in a group"), OPT_BOOLEAN(0, "metric-no-threshold", &stat_config.metric_no_threshold, - "don't try to share events between metrics in a group "), + "disable adding events for the metric threshold calculation"), OPT_BOOLEAN(0, "topdown", &topdown_run, "measure top-down statistics"), OPT_UINTEGER(0, "td-level", &stat_config.topdown_level,