From patchwork Wed Nov 29 14:05:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 171368 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a5a7:0:b0:403:3b70:6f57 with SMTP id d7csp360385vqn; Wed, 29 Nov 2023 06:06:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IHzCnNzkTxqPjipDPSuI/FOWO7tgar6eZ2hCBB0XSCZaWJQleqHOT0CfbREn9Q01dIyAiDb X-Received: by 2002:a05:6830:1107:b0:6d8:4837:e8a4 with SMTP id w7-20020a056830110700b006d84837e8a4mr4261924otq.25.1701266803780; Wed, 29 Nov 2023 06:06:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701266803; cv=none; d=google.com; s=arc-20160816; b=tnxvY+Eo2m9KIAJHDpeOxN0KjbXckvENoGWXUJ4yh/jzIcMUDOjUqwflnO/QfCyvtD zZRqlVK3wHKjPC3boNsHHA9br5ZbfwtRVEej1HsHQDfcfbRQeJJw2asRwdYyMYcRy+Pb jerGmF997keEmRJyTy0D0yAUG76ru4L1WIkkruok6pc/+m4eC1vo/XsQWlqkZ9zrWC6y npueQINNIpG2+cIX8KSq2F6YkTAApvmzOa+q6rPS5e4+pTIrfqtYiG3gwtl5Ug7XCTPo onf7baNX2SLl/NrnXaCjEq7LX5xXqtGiE/0kniDapDDYbBj7V76ylz2CJKrQWzKSwZvU uLXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=MQ8xtOf7SPY4n43K7AQFcp4yw6pnczR2hfrcA2zNKh8=; fh=rO/e/KoyDl3y+Fl0LLNtzHTki+DYKutnpbrHEe4bxHI=; b=ujahIE9v3cK4DBTeWyLwFrWunZmuPlPnmaUY4iXTYVrEmOZ/+5SwUqEgfWuTNY50pt 6GoZwiG8pvZFw6JAOCJkui0GDW+ib9q5PmMpie1VJSTOxFji2Z2H/Kvw2+FYWlyD1Psa m0zVKUwXM2+Lf7CJld0bgF8bAkBnRfRVyuxfPZKbKL4JuJcwPTIPOQj0sE7z2LQF4/r4 9/1s8RnN9Dph3ABf1q9Ii6yHIHseqUEnR/BAvhEETtIOKsrcun0MvkNdi0A2kyARteUU Exry6IUmoNjTPe3KMEBWWDiYlxs36vsXgAWp+Yyv2ntArtJl2czUY0TO85sS9WVKBYou eZCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=v3yzIOkf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id j11-20020a056830270b00b006d7ffdad98bsi5630949otu.32.2023.11.29.06.06.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 06:06:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=v3yzIOkf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id E84DC8079AFD; Wed, 29 Nov 2023 06:06:04 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234120AbjK2OFi (ORCPT + 99 others); Wed, 29 Nov 2023 09:05:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230480AbjK2OFg (ORCPT ); Wed, 29 Nov 2023 09:05:36 -0500 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 997A5DD for ; Wed, 29 Nov 2023 06:05:42 -0800 (PST) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a00a9c6f1e9so968529466b.3 for ; Wed, 29 Nov 2023 06:05:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701266741; x=1701871541; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MQ8xtOf7SPY4n43K7AQFcp4yw6pnczR2hfrcA2zNKh8=; b=v3yzIOkfFadhqPhGKQCzWKANSK51Sg9KBXlQP4IfJwapYPKGtgNgqEeMMs0/Y3qv46 rDKBr174nkdSv+Ruot3atuNe4j1QBW4Y3jZRUBJClmhlHhLNZ1f83X1TCyHC7zJs3T2l QqixzXPqjcpS8Cqzfnjy8cxZuWP6a/PGKx95G6YaJPkNy9LZm7erajMx8p+V0xi7oJV/ Q5XyI7pNM4ui8yEI76JjbGSRJ7IP6Vv1YwuDnSwHzsFl/8ulcwinAAEvNyM+R0RJALDV LiJMMsuEoHy0t7DVNEh/lqTrq48QrJ9dHSs+2nIV8IOfyYMliWDtBIp7r74F0JitUkEN OW3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701266741; x=1701871541; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MQ8xtOf7SPY4n43K7AQFcp4yw6pnczR2hfrcA2zNKh8=; b=ex4t7vVPfq2yZYRtuIcMxyPuDxhFYlrQoC5EtImbbMFwncDvhEcmVr9eVTrHB9M8Qi 6iXu04T6eeCtDAAcyulyrJ61L1De1YcmwENAJbNGl8bOREPX7RQ1eJJJ0hkiILEVEvpA Dvd5t4NyQz+n7Pjmq7+xdz1Hle3cBgcxLiK0PvdbngopdpGWoxr4pwIwTbLD41YAEmSi FWvxwJEXyiH0fsYmUZiig5sCwOyZ97td6VS3lRXzVWOtbchtEUnnYM8DZCoYjWUaW9EA 84Co9Ji/kK45cBNcpvKzPsd4O1Dr4nn72A4oMCDrvNK8FssHo7gBHCtIC4L7FaGcifpv 4dXg== X-Gm-Message-State: AOJu0YxQ0p6aOnVfsXzuIKtV+bHQ279WGew9HkcUUhyZWIfqc98Hw0Qh LtHmryDSyk/lfLCv2uwYC390Sw== X-Received: by 2002:a17:906:fcc:b0:9bd:a75a:5644 with SMTP id c12-20020a1709060fcc00b009bda75a5644mr12183367ejk.16.1701266741102; Wed, 29 Nov 2023 06:05:41 -0800 (PST) Received: from krzk-bin.. ([178.197.223.109]) by smtp.gmail.com with ESMTPSA id o14-20020a1709062e8e00b009fe3e9dee25sm7947530eji.61.2023.11.29.06.05.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 06:05:40 -0800 (PST) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Neil Armstrong Subject: [PATCH 1/2] arm64: dts: qcom: sm8450: correct TX Soundwire clock Date: Wed, 29 Nov 2023 15:05:36 +0100 Message-Id: <20231129140537.161720-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 29 Nov 2023 06:06:05 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783907540181406397 X-GMAIL-MSGID: 1783907540181406397 The TX Soundwire controller should take clock from TX macro codec, not VA macro codec clock, otherwise the clock stays disabled. This looks like a copy-paste issue, because the SC8280xp code uses here correctly clock from TX macro. The VA macro clock is already consumed by TX macro codec, thus it won't be disabled by this change. Fixes: 14341e76dbc7 ("arm64: dts: qcom: sm8450: add Soundwire and LPASS") Reported-by: Neil Armstrong Signed-off-by: Krzysztof Kozlowski Acked-by: Konrad Dybcio Reviewed-by: Neil Armstrong --- Considering that in Downstream, the TX Soundwire is part of VA macro, there is no clear reference code explaining this. Let's just go with SC8280xp approach because it seems reasonable, but don't ask me "why". --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi index a305f8c03f9e..28207c7423f0 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -2314,7 +2314,7 @@ swr2: soundwire@33b0000 { ; interrupt-names = "core", "wakeup"; - clocks = <&vamacro>; + clocks = <&txmacro>; clock-names = "iface"; label = "TX"; From patchwork Wed Nov 29 14:05:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 171369 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a5a7:0:b0:403:3b70:6f57 with SMTP id d7csp360420vqn; Wed, 29 Nov 2023 06:06:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IHorcpii2KlR6+W5wJl91Qv3HyO3u5OYUVJUdn7fu3VYJGpRHNEd5UTXekAiZOJc4VaK5yR X-Received: by 2002:a05:6871:5811:b0:1f9:4244:4c52 with SMTP id oj17-20020a056871581100b001f942444c52mr22623806oac.41.1701266805731; Wed, 29 Nov 2023 06:06:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701266805; cv=none; d=google.com; s=arc-20160816; b=iBGtTDOt5BIhPrFjcSiPzH6J2qRszvGL2zXssYogboURVLhaX1d9C7zdAbp16ibz+6 II35jv5pjMLXj46ogimDaH8Q3STsu+yEnAwNtAIO4tlPu+KhfCIBpyNmO/j9LU5hpvy6 6GBkOPWTQlquRhoXzX2CNkyMBnnTLTAe4OSv6fFqUWsXO80mXQETzYDJjOLXLE3w1kk2 89Jq1OZ7JL8Bix60A/3kDCoedCp9Ti5RYrXkBk1hj5v3TTDd95RMlGnTaia1JyRhgpaL Iq8iO8Op7rYgo/IhFjnrM8VClI9qswYbpfpht2PwClNpuLm7bE1BT4JxV2k0at07kBOK oIkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vIpe57LK+ad4j3gXLtYhpcdtMPnG7fFGsBLCvb5Xl00=; fh=rO/e/KoyDl3y+Fl0LLNtzHTki+DYKutnpbrHEe4bxHI=; b=IfCdl4YJXpHuq2P/YvGgzyXdaDGrH+0MqhNDjPkAiQ0/OVkzzLYjJpydbynsfWFZC4 41TvNvoFQPhcE+jMrWrXMAqmWwJDt8kMRkPUXjRppz9EzNc8qNP4xCdfcjy4aNiqQcrb KdNS8EXspgq17nXUi7xyTPnGbxAtedBC8HgT7lEdHc1hsCO3XOTlkS5p0q5nK/gt1okF xYP/Fa82zgIMlNlitZuvkIUOoVfh4r0PsbInADaxlalj8c5fLekeo99Iz0An9xy+R4+V bQGNa+O6gkdwF3zHDTUgLxS86CXU5pfAhYKH2AlxyC3Wfh9LNYJQz7u6QySzD45aVKTc H7Iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rE3DPTLV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id i12-20020a9d68cc000000b006d7ed25d3a1si5392872oto.158.2023.11.29.06.06.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 06:06:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rE3DPTLV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 14F02808A967; Wed, 29 Nov 2023 06:06:17 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234148AbjK2OFq (ORCPT + 99 others); Wed, 29 Nov 2023 09:05:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233108AbjK2OFi (ORCPT ); Wed, 29 Nov 2023 09:05:38 -0500 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E1B01AD for ; Wed, 29 Nov 2023 06:05:44 -0800 (PST) Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-54b532b261bso4953251a12.1 for ; Wed, 29 Nov 2023 06:05:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701266742; x=1701871542; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vIpe57LK+ad4j3gXLtYhpcdtMPnG7fFGsBLCvb5Xl00=; b=rE3DPTLVdTe+gXcLth66c37DX7SHlmOGKngnUuV7dpsbAkjqxCnzvmwNN7Su83SGBZ nXGKvARiV4aMEOPSHjfyFl2zVG9+xztHErG9zsFZ0vcc97QL/PjJyEbAjvo+RI5x9442 ubwPmw8l3Ovv6vhL4mWGReiFyWSlzaAC8ngcr8xmvjcYCREzQmXaQ3/eOfi17xiUzS/j SfflkVLzvOFbZUFY4LAIoyAwoXOVTktVknOtBrGqiBEiT+rGvdQzCVTuYKt73/1a4S32 urydTKiOt7Tv2jn7l243x9sMmD2zqwT3J1pqrQvA6h26HlpcbD8BJjIQkYJjEU1KpJ7+ cuvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701266742; x=1701871542; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vIpe57LK+ad4j3gXLtYhpcdtMPnG7fFGsBLCvb5Xl00=; b=ZbNjQiyKGtng8S5RUC+SkJvY7QGVj3VOjBNJkIopBnv8CTHibWvGwETEcXFlsAqxNo jsf5029NfVxWyTlDJIBha0fj00dkMWY3waI8FINquBjQx4gkcbiM9hc+nxLVMkPdm2KV FvbH66VWMlHbBhYCTUM1v+/U1gjTir+2A4sF5Glov58tg7GDdqHxtCTU45QWbOw+PYMB 2Ld3baIz4kPqHbRzlUG7RzsHR+MnnGih7/gnQSdTL7TQDp+wlZwyp0MuEURv/eqnc5vx VWKSuhEiJQcZW+p2eZlAzvxaIwZfrPUlfuN4bPXzaQNQ1zwZNLTv9tqKiUofAvuGNa9v W8CA== X-Gm-Message-State: AOJu0YxlUbxSAgt8tj7kYsW61DusVFlsJHtcGwjMmIPnNwvk5G7ommp0 eDgL9SL6YayrlnFkSCUtoOK+GQ== X-Received: by 2002:a17:906:fa06:b0:a0d:ebfe:e404 with SMTP id lo6-20020a170906fa0600b00a0debfee404mr9221770ejb.22.1701266742475; Wed, 29 Nov 2023 06:05:42 -0800 (PST) Received: from krzk-bin.. ([178.197.223.109]) by smtp.gmail.com with ESMTPSA id o14-20020a1709062e8e00b009fe3e9dee25sm7947530eji.61.2023.11.29.06.05.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 06:05:42 -0800 (PST) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Neil Armstrong Subject: [PATCH 2/2] arm64: dts: qcom: sm8550: correct TX Soundwire clock Date: Wed, 29 Nov 2023 15:05:37 +0100 Message-Id: <20231129140537.161720-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231129140537.161720-1-krzysztof.kozlowski@linaro.org> References: <20231129140537.161720-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 29 Nov 2023 06:06:17 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783907541911472970 X-GMAIL-MSGID: 1783907541911472970 The TX Soundwire controller should take clock from TX macro codec, not VA macro codec clock, otherwise the clock stays disabled. This looks like a copy-paste issue, because the SC8280xp code uses here correctly clock from TX macro. The VA macro clock is already consumed by TX macro codec, thus it won't be disabled by this change. Fixes: 61b006389bb7 ("arm64: dts: qcom: sm8550: add Soundwire controllers") Reported-by: Neil Armstrong Signed-off-by: Krzysztof Kozlowski Reviewed-by: Neil Armstrong --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi index 52e8f4c52426..2fd3faacf554 100644 --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi @@ -2199,7 +2199,7 @@ swr2: soundwire@6d30000 { interrupts = , ; interrupt-names = "core", "wakeup"; - clocks = <&lpass_vamacro>; + clocks = <&lpass_txmacro>; clock-names = "iface"; label = "TX";