From patchwork Wed Nov 29 13:56:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: marius.cristea@microchip.com X-Patchwork-Id: 171366 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a5a7:0:b0:403:3b70:6f57 with SMTP id d7csp352251vqn; Wed, 29 Nov 2023 05:56:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IHpdRf7b2OgdvPzf25F3XGe9jxRHTTBfX1GGLSbDe9m7zpuJp/q0/FXJhrTP8tFXkKKUZBP X-Received: by 2002:a17:90b:1bc8:b0:285:d550:9979 with SMTP id oa8-20020a17090b1bc800b00285d5509979mr9482817pjb.6.1701266211651; Wed, 29 Nov 2023 05:56:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701266211; cv=none; d=google.com; s=arc-20160816; b=hhx0s64c+WtjA5ufJUiMn38+8DwFNO2czh4d7grfR/WLigOO9RFjuhvICmaM9MoWlI 1zBPNEeUQh21ZjivEmrk6TzZHfvHdjvLcl+027N0cDcebQgo+qIRpZ10EWTe6wWolESM z4U6ShlApglpkVgpm6EOZhp+ygOt7PcxDauQmCMY/hjoh8QbMbI68zw1wujmj9QxlMeE 9JHI3ucRpMxd0He5h1H/Ggmaq8JlUil8iwasiaSaED+lkPSH5rllhpgH9AKy1Pj5HaRK yI1/HYe5WcS0lnyIcT9PJn7D/om0TDIKY5UKArEpGz2p6lv9F02joT0qFNKPOiuxW101 TogA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=RU9/WrQ2QN+WaJymQKZqBPmRnsuN6OLKxrccCsdlWZY=; fh=OahkkZGRMsx/QsvTzHLvmCoK5Fz3HImW7eii1n0wrVw=; b=l8A8ibG5fqtlVX3kQIifiWxD14fkR95HclLVwF/9yISTd+s3BOSub8KcYeTN/DqwDk Mj40vGZGhuOqAv68Nh97gCnmpuaPTm2Fiz/BaE4YvRxOXFqXLqs0wf09Kg9gSV7tdCnN 9TIHJoKF1kcfhpXOpmcgPb2/OljKEWnI4uPgyjjwZUvBC8VADA+ImQT4t4tFcpCusRfF L7PN4ZG2shLds8lJnApm8IHa4rGweVjMm4bP95pH6BULg4KTtAaoRSmbbCItkzoyaNkX lGmDt26SukfhR1NWEsPm3PomXc4I+XWkg1XeYSbrZmWFOGY7PgCgYm3J+0cuDhG/iOJB 1HEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=Phxi3k2u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id co8-20020a17090afe8800b002839be230b2si1311172pjb.44.2023.11.29.05.56.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 05:56:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=Phxi3k2u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 13015822A4A5; Wed, 29 Nov 2023 05:56:47 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234434AbjK2N4i (ORCPT + 99 others); Wed, 29 Nov 2023 08:56:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230472AbjK2N4h (ORCPT ); Wed, 29 Nov 2023 08:56:37 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 070A6DE; Wed, 29 Nov 2023 05:56:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1701266203; x=1732802203; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=hei7pXJNKVP4qTlallaoc626BSGQdU10VHphmCZ1qaE=; b=Phxi3k2ujMog2Ek76+OslxHqMUmlr8/XuH0P4G6gebDiYPED733L5vwC ZUktuKTtYsHRagrFCx9X2nhYClv0uJKDRlgqknGQZffv5uk7MI45lKPcu 2GOmxJWVgLkkPx+wWnXpfcxfOXgWfmJ1sm3rpaZqFc2f8XlmAo2jY7C4a +60qNxcg8hH39Yo98iE5SxCQgaho0le8t+cb4YaJgyf86uQb9hWlbl67C Xv6xF8zFJPBEf/dtAJgRP2A1FAj9Vy5lszQx4XeJTsdn4OA/K7EB9dNXF iUDRl4ur8TKzI+fu4bNJfBY32vBxEGGUtIF9/I4P52a29fIJ2WBNzwm2H g==; X-CSE-ConnectionGUID: BHQX6+MwTYmhpSKF5vn9xQ== X-CSE-MsgGUID: bOTPZ+PEQJm/gapsuwWiuQ== X-ThreatScanner-Verdict: Negative X-IronPort-AV: E=Sophos;i="6.04,235,1695711600"; d="scan'208";a="13258106" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa1.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 29 Nov 2023 06:56:43 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 29 Nov 2023 06:56:24 -0700 Received: from marius-VM.mshome.net (10.10.85.11) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Wed, 29 Nov 2023 06:56:22 -0700 From: To: , , , CC: , , Subject: [PATCH v2] iio: adc: MCP3564: fix hardware identification logic Date: Wed, 29 Nov 2023 15:56:19 +0200 Message-ID: <20231129135619.63475-1-marius.cristea@microchip.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 29 Nov 2023 05:56:47 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783906919319942625 X-GMAIL-MSGID: 1783906919319942625 From: Marius Cristea In mcp3564_config() fix the hardware identification logic based on the hardware ID registers. Second part of the code was disabled by an logic error. Fix a typo related to the "MODULE_DESCRIPTION". Fixes: 33ec3e5fc1ea (iio: adc: adding support for MCP3564 ADC) Signed-off-by: Marius Cristea --- drivers/iio/adc/mcp3564.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) base-commit: 6543f376ec8aa90a6c1ed44b765f4f0d6c3eb1db diff --git a/drivers/iio/adc/mcp3564.c b/drivers/iio/adc/mcp3564.c index e3f1de5fcc5a..e914a885a868 100644 --- a/drivers/iio/adc/mcp3564.c +++ b/drivers/iio/adc/mcp3564.c @@ -1122,7 +1122,7 @@ static int mcp3564_config(struct iio_dev *indio_dev) enum mcp3564_ids ids; int ret = 0; unsigned int tmp = 0x01; - bool err = true; + bool err = false; /* * The address is set on a per-device basis by fuses in the factory, @@ -1509,5 +1509,5 @@ static struct spi_driver mcp3564_driver = { module_spi_driver(mcp3564_driver); MODULE_AUTHOR("Marius Cristea "); -MODULE_DESCRIPTION("Microchip MCP346x/MCP346xR and MCP356x/MCP346xR ADCs"); +MODULE_DESCRIPTION("Microchip MCP346x/MCP346xR and MCP356x/MCP356xR ADCs"); MODULE_LICENSE("GPL v2");