From patchwork Thu Nov 10 08:44:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olivier MOYSAN X-Patchwork-Id: 18015 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp27052wru; Thu, 10 Nov 2022 00:53:25 -0800 (PST) X-Google-Smtp-Source: AMsMyM7T4smkzY/saRvLiej9XyS1asIoRWUM/j8LatKKUTKH5To/qT1dwtCST0tRF6OiOonUA/JV X-Received: by 2002:a17:902:d707:b0:187:2364:1dc1 with SMTP id w7-20020a170902d70700b0018723641dc1mr53643327ply.77.1668070404830; Thu, 10 Nov 2022 00:53:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668070404; cv=none; d=google.com; s=arc-20160816; b=TzQfNOSnzWul0k8+jJwPPciUkNjRGtYnYteF1o8euUNXHZ27wNrvBMgJG/HhncCxnT QZybweAOk37m0bZlemMSuTiPtTKwmGRkTaNeluZSBI8M4mnJ/tQ6vKZxaoAt/bCOQhm7 mcfCalNqb9vJwRzjXW5pZnOXuBGEpffsFHUPm/jYVDh6usIBTjWzZZC1e87XEr4fkAAX BOUdtcE46L81GeROPG6m0PZAyvcWpBgOx4ILo3B0Uw21k3VhF5CtDecgXpWz9Iczj7Nf eZrYtBVdUwqYENmQdEGi8/IZLQjgVpX7GTU87ox5DIbAhcTBQnPk3Ot+TQ4qRhRKNMf2 wsGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=6Q/BJ+yH7QNtYOt6tTbme4eART79NuYynx686HaXT/Y=; b=knFdFZq5sidC3r81FLLIV9XZGX905apecYcqF4dDn3OuYGKZuZQbSIlwwK53D8pXM8 nohq6GUmYpzDXH6KpwDg/drtdJ1Y/ENsN08M4Ka3W3xo/cSOhHB1ZnVTHI9QumbAQ0A7 LHO6u+GRTvz9WBhdr1ICJ5D4CUCRqvhbnYkVJttJTo0Z01hF8C9mJ0EHRqjz7iZPW5zL sQRdpuF4jvCQ8G23Tqaems28wEulRxWviIpan8cVk9kb/C9DCTiM5gVtHwTIl/UTxB9u ZSBUMkj9DwImBkLDMBRoIfIQghAz+gDO/eUQCgrKdLRJeEITQsE3J2RndUpqJhMkcrN+ afxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=yaRQfVwV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b13-20020a6541cd000000b0044a82d20079si19292867pgq.526.2022.11.10.00.53.09; Thu, 10 Nov 2022 00:53:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=yaRQfVwV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232871AbiKJIp1 (ORCPT + 99 others); Thu, 10 Nov 2022 03:45:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229551AbiKJIpZ (ORCPT ); Thu, 10 Nov 2022 03:45:25 -0500 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 868D9286C4 for ; Thu, 10 Nov 2022 00:45:24 -0800 (PST) Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2AA8bR7U012563; Thu, 10 Nov 2022 09:45:02 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=selector1; bh=6Q/BJ+yH7QNtYOt6tTbme4eART79NuYynx686HaXT/Y=; b=yaRQfVwVeQk7QcktjF14+F0Sr2bcE9eC7pmpb30bt5DaI+ZKFyXpFhAK6zE2/cPLaRl5 9WjMzf0kLbgz1cJq+A452OmWwIgUbw+CKEcIvOaQOyYV+t5pgy0j+scRMlwDZhLJQf6z zz/l6erCH+deuF7D5r+LNN/YusDeOnpxTKRDKCSoKO59SnNcka333qxGiTBzaav7JWaA VbeQYAIAdJTgGJ9OOMzTNgrRzy85qR5jpI/4S1oxuLCNTrRON2P9DZ1OPfcbDrWomY3f QCjRs3+a7pMp+rOQ8lofgiHKKV/dCYl0rqezZJq5ifcPmfsq1bSdnmwskdB8FTidkTam Bg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3krwxyr223-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Nov 2022 09:45:02 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 0053010003A; Thu, 10 Nov 2022 09:44:56 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 9BB3B20BE73; Thu, 10 Nov 2022 09:44:56 +0100 (CET) Received: from localhost (10.211.13.61) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.32; Thu, 10 Nov 2022 09:44:56 +0100 From: Olivier Moysan To: Olivier Moysan , Arnaud Pouliquen , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Maxime Coquelin , Alexandre Torgue CC: , , , Subject: [PATCH] ASoC: stm32: i2s: remove irqf_oneshot flag Date: Thu, 10 Nov 2022 09:44:06 +0100 Message-ID: <20221110084406.287117-1-olivier.moysan@foss.st.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.211.13.61] X-ClientProxiedBy: EQNCAS1NODE4.st.com (10.75.129.82) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-10_06,2022-11-09_01,2022-06-22_01 X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749098592605338232?= X-GMAIL-MSGID: =?utf-8?q?1749098592605338232?= The IRQF_ONESHOT flag allows to ensure that the interrupt is not unmasked after the hard interrupt context handler has been executed and the thread has been woken. The interrupt line is unmasked after the thread handler function has been executed. The STM32 I2S driver does not implement a threaded IRQ handler. So, the IRQF_ONESHOT flag is not useful in I2S driver. Remove this flag to allow the interrupt routine to be managed as a thread in RT mode. Signed-off-by: Olivier Moysan --- sound/soc/stm/stm32_i2s.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/stm/stm32_i2s.c b/sound/soc/stm/stm32_i2s.c index ce7f6942308f..f3dd9f8e621c 100644 --- a/sound/soc/stm/stm32_i2s.c +++ b/sound/soc/stm/stm32_i2s.c @@ -1077,7 +1077,7 @@ static int stm32_i2s_parse_dt(struct platform_device *pdev, if (irq < 0) return irq; - ret = devm_request_irq(&pdev->dev, irq, stm32_i2s_isr, IRQF_ONESHOT, + ret = devm_request_irq(&pdev->dev, irq, stm32_i2s_isr, 0, dev_name(&pdev->dev), i2s); if (ret) { dev_err(&pdev->dev, "irq request returned %d\n", ret);