From patchwork Tue Nov 28 20:43:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 170958 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp4214229vqx; Tue, 28 Nov 2023 12:43:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IFOLB3FUjdih73y216iTWzh8g6p+WuXQMWSoqnD2F63kGCz1vE+aDupLNfLj3IM3dfxxgED X-Received: by 2002:a05:6a21:338e:b0:18c:8fef:22d3 with SMTP id yy14-20020a056a21338e00b0018c8fef22d3mr9947989pzb.34.1701204206268; Tue, 28 Nov 2023 12:43:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701204206; cv=none; d=google.com; s=arc-20160816; b=rAhSsDXaDErq02FAaYinwAeM7jT1bv5SMPtMchiN8OoPHbhshsq9/p9Jz/Aa6oihjw +Ye47EGZe2cSgNo3NGTWfPd8VEP15mbZ+Z7ZqATUogVg039zDgehLlL0wV7qQoc83zb3 CtbOqqjpKP74O8G74lmsQYE4N4UOD+MfT2CumCmtXjwdtqcIYh5W38jsy2HEOaZFXWbI Lk2i03TldywMpqVWo7ajfLzjjbjLdBq7UoIH/f6iVmL7FdKm8d+3TmlZ9uLKU2yoDlQe FEbZ36QcX0UsTPU1Ap5jKDyBLw2mtRYTCmZ5Bn1m31wNE1L1ppT/+w5+TouhwcfZi4XM h+mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=YTvuKmkTJPAvRgA2l6Vxt5PQ3ZQRNuyzzv3L3pAw+UE=; fh=Sw1rtAM+hKyOoOQVYiiLzcdjc4spg79Z/tN6UmWUAKs=; b=e0rOSzY41KSEFuVOM44hDyj8XK05PSeetV6qINuUS8FzwjYXlZ2da+dHW8aDB9kZTq gfZayvjqz8/RKB7qtRdkpUZYF5uFqIA4A6ROAyIzEfeSA5IPebxHSArvxEFfchKRojH9 qnTLYWDCgSzgxzenbMz6F29cmPA9HNIbl2OHNHA7rLBvFyHPJsbqP3Z4QAcYfhi5d0Q/ BdBOskJYOYaqjLdqqGpmQ26xCkUu2QA+E53PBdGVd/HEmCCyyZgkwbXURnQythglXqz+ P0CvugfjtovzfUg/nnr4GAVyuBWa07zuDhGswkhS9CFfWVkkjkjNeJj2z7oEkf+OgjRS ka0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=alND4+3k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id be5-20020a656e45000000b005c1f51c706bsi13720207pgb.599.2023.11.28.12.43.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 12:43:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=alND4+3k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 34F5880B01D5; Tue, 28 Nov 2023 12:43:25 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345855AbjK1UnN (ORCPT + 99 others); Tue, 28 Nov 2023 15:43:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229538AbjK1UnM (ORCPT ); Tue, 28 Nov 2023 15:43:12 -0500 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EC5A1988 for ; Tue, 28 Nov 2023 12:43:19 -0800 (PST) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-407acb21f27so6999565e9.0 for ; Tue, 28 Nov 2023 12:43:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701204197; x=1701808997; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YTvuKmkTJPAvRgA2l6Vxt5PQ3ZQRNuyzzv3L3pAw+UE=; b=alND4+3kDWr3/zgpPK0NM0pPsupkjJIJxKSNdAckrySBT0sblFwgendjrLNt8uxrsR IGQ1CymDOB6ZD5ay79DTbow32zJe7IBwkg2JczijSQ3jUHJkyE21Q9drwQ73BccmnQa2 rFqcVj8W3B0TwZHVT3o+8PlTMA0TczsJZvxQZXejAHyUqMtHmOv7ZHGr9c3xQJIfZ+Yc a7HMwhbXpCdQvSgCp0EGw+XaoZ4dQH/dAtR9rYWA5XRg9JcO7NiIfPd54+J2Bd3h3fLK PVTjbDnggfdcWFCImpXQA8c28LyZDTIXKCAZlyM84DFyhy7XU2OkUMtDS3ixP82vX3ph 68zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701204197; x=1701808997; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YTvuKmkTJPAvRgA2l6Vxt5PQ3ZQRNuyzzv3L3pAw+UE=; b=igxEVu8gA/FCgbkhV0hf3tDvuRCKxjaXFs/OK8nYsA73rGsXeOObZjEqarXcRKxYRw QYu7QfgfbxIsOUnivSWpQ70q6oUpLZ3PUYsSuW9KdDi20W2CMOcsjdUHLCzgjqa6jyTU s2nj76hyVaCzeCnO4UD4Qjm1YwweqUEPCQH+8coc2tMWOCV05OXjOpWBkwFy5OmiC7UY j380jmcO3glXoHy+8Vu4img0oR4yH0NonB7TQB7KmhbuvWYOzMbeDnEQVhgvE0WFGBT4 Xurpy2gdGPYLNJOXsIPD+QYRLNz86uRBCR8I4nKgXrlH08ZPXjdVBXN6+uDQHutuKEE0 4SHg== X-Gm-Message-State: AOJu0YwUXfcdQjozslyfNjarX0Tk3qwfG6sbaPhO6e3BQdsGiRZQ5a+x CzetoP/k35d8HSDq9eucfh7xaSE6vs8= X-Received: by 2002:adf:fccb:0:b0:332:fb6a:6206 with SMTP id f11-20020adffccb000000b00332fb6a6206mr5716051wrs.2.1701204197330; Tue, 28 Nov 2023 12:43:17 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p54a07fa0.dip0.t-ipconnect.de. [84.160.127.160]) by smtp.gmail.com with ESMTPSA id m17-20020a5d6251000000b0033310d8d0e8sm2371953wrv.63.2023.11.28.12.43.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 12:43:17 -0800 (PST) Date: Tue, 28 Nov 2023 21:43:15 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 1/6] staging: rtl8192e: Remove action block acknowledgment Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 28 Nov 2023 12:43:25 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783841901651811527 X-GMAIL-MSGID: 1783841901651811527 Driver does not handle block acknowledgment correctly. Tests with AP have shown that the AP is giving up after some tries. Remove function rtllib_process_action(). Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtllib_softmac.c | 30 ----------------------- 1 file changed, 30 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c index d20970652432..1b66e718c59b 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac.c +++ b/drivers/staging/rtl8192e/rtllib_softmac.c @@ -1556,33 +1556,6 @@ void rtllib_ps_tx_ack(struct rtllib_device *ieee, short success) } EXPORT_SYMBOL(rtllib_ps_tx_ack); -static void rtllib_process_action(struct rtllib_device *ieee, - struct sk_buff *skb) -{ - u8 *act = skb->data + RTLLIB_3ADDR_LEN; - u8 category = 0; - - category = *act; - act++; - switch (category) { - case ACT_CAT_BA: - switch (*act) { - case ACT_ADDBAREQ: - rtllib_rx_ADDBAReq(ieee, skb); - break; - case ACT_ADDBARSP: - rtllib_rx_ADDBARsp(ieee, skb); - break; - case ACT_DELBA: - rtllib_rx_DELBA(ieee, skb); - break; - } - break; - default: - break; - } -} - static inline int rtllib_rx_assoc_resp(struct rtllib_device *ieee, struct sk_buff *skb, struct rtllib_rx_stats *rx_stats) @@ -1789,9 +1762,6 @@ inline int rtllib_rx_frame_softmac(struct rtllib_device *ieee, case IEEE80211_STYPE_DEAUTH: rtllib_rx_deauth(ieee, skb); break; - case IEEE80211_STYPE_ACTION: - rtllib_process_action(ieee, skb); - break; default: return -1; } From patchwork Tue Nov 28 20:43:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 170959 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp4214324vqx; Tue, 28 Nov 2023 12:43:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IHJSJtSkAORFVTV5WUM44KUg4eDy9IydKWSjOSkYB830NNACY3zbPweknImeMtBayQHa2vH X-Received: by 2002:a17:903:32cd:b0:1cf:b43f:a0c5 with SMTP id i13-20020a17090332cd00b001cfb43fa0c5mr12904281plr.54.1701204220178; Tue, 28 Nov 2023 12:43:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701204220; cv=none; d=google.com; s=arc-20160816; b=UZSMpspif/DmFL232x0mwadimiHBAVd+OW9LVrIDTgUtUjkDmITuR0Xo+5zkkiE77B GAwyJ+jEaWADR/685moLWq+mcJu5eV6vVyuLneUalY0ZLJ60KNaqxwN1+MVPVFq0NREL 0jyCjlWGX6uWUQ9O4n0cmBYAV5j4lMsmQi9Sl9nzAfWBFBHO5Sgn5wnPboj1A3D8Gug9 qydbL0+S46M5p0CbLrqwlgHU85sFR+/kknOTnYtPuqjtodtCfBsEuhJHX3lvt9v4F5tF 9C6qk8IMI22QeYKEnESCnmxOUqU/iwrAkc0G7p+W/oV0uK0Uv5nVTGMf93IPdo5QxCBL tqHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=njp3hQuRezyJWSCVkGDJUsCKh4qNw0wNTvM+MC2XVcU=; fh=Sw1rtAM+hKyOoOQVYiiLzcdjc4spg79Z/tN6UmWUAKs=; b=siMXYPOt5HCkZp7n+aAJvYTIQ7nOZz4YwgAmWcOK+ikn0UvrcrNgEi7/1qKp3XVhdj u/SDS12yLVa34zbhO5xrybamcLrOTSChyQ09SURkyePur51IThWgA0RnAu2RhmlZlGdn hlYuEe1e4DOGbw+/XgUdvTJKAUDZ4rmYuULtv3Od9Lrbn3RYXHiFJ2NJPCies2WVx+1B O09t2w5lwQdXIdQZcuaDtRfCsmio3qdYZ8hOT63uGjJbOIAJGmz5BsNqXuhSvj9l7l7p CpbcKlp+avIwQx1FZldKwK3bNDqOD+fWGX14Mlmv6jg3VQHNAr/BZ4kgLEaa8x4P732c 518Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=CER2TLMb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id jb6-20020a170903258600b001cc41020674si2364056plb.518.2023.11.28.12.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 12:43:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=CER2TLMb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 29BC880AE82C; Tue, 28 Nov 2023 12:43:37 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230115AbjK1UnW (ORCPT + 99 others); Tue, 28 Nov 2023 15:43:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229753AbjK1UnU (ORCPT ); Tue, 28 Nov 2023 15:43:20 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D18819AC for ; Tue, 28 Nov 2023 12:43:26 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-40b2a628c25so4631715e9.1 for ; Tue, 28 Nov 2023 12:43:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701204205; x=1701809005; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=njp3hQuRezyJWSCVkGDJUsCKh4qNw0wNTvM+MC2XVcU=; b=CER2TLMbqP22diyDiifFbryA9wgYE0s5fF7U7j535TfYFnCtNJY3AApvJHU4hd8DW0 T9s0ygaCINSXnjzw/EE2x2ls5OepVIreHlX1L8W6mMTgxzIUI05p/gR/rlx/wX0zfajY 9cqSnirrAok6uuwG6DiJxyhcE9O70gGyC9jWeU+La557/kTPqXteD+BL9fuK5zaWFTZP 5Qb9lG+Ea/zYKIiWEd5Qq/EF9A0Ej2OCwSEIkxGlGFtIMIiTg2qlatwGazi5BG5GuUhk 3jhP4JOUB/MTT7dy7AvdKAjauzbbXLl5kpd9hItKnnP6q/LU1O665dfFVEV5p9Sd3vEl RpMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701204205; x=1701809005; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=njp3hQuRezyJWSCVkGDJUsCKh4qNw0wNTvM+MC2XVcU=; b=XiD5GFgZyJySQu746LnySd0QeQ1JsEnCQXJ9KSH6k6Xk/CRvH+lPKTvx5GhHvrZD9b COyiCA9L0jZPMJIFktn2QfqIEsSjTyitT7kT6xgJr1kMwF1j/ASBSqnFWOBOSBw/ecb/ 8wZBX0dQXdRu0d90oUZOWRx/3d963GBsAqvBOkfqWcAkaETYQ8NuHNEPtlVszpcaaWl/ Dqhg4fvWZ3azGrLCJikqfatRJ9J4FJzG6ssDVIlK1gKE87Bp0TllquTIJ+Ano83ksd/1 WVkAcZVzoiECY6EZPADhDc8Eh31PdDyGgk51TWrhCMFpp6UsDBmAOP8xbX2wFhYTFCcH W6mQ== X-Gm-Message-State: AOJu0Yy8TLwrh5ZoQR4my3r5nOGAad767NdKLEklC2PdJyYu+bmHKUcr GGIlpuRUhd9OL3CNF4xE/s0= X-Received: by 2002:a05:600c:1d06:b0:40b:5150:c046 with SMTP id l6-20020a05600c1d0600b0040b5150c046mr404729wms.3.1701204204641; Tue, 28 Nov 2023 12:43:24 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p54a07fa0.dip0.t-ipconnect.de. [84.160.127.160]) by smtp.gmail.com with ESMTPSA id t6-20020a05600c450600b0040b379e8526sm12609152wmo.25.2023.11.28.12.43.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 12:43:24 -0800 (PST) Date: Tue, 28 Nov 2023 21:43:23 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 2/6] staging: rtl8192e: Remove unused function rtllib_rx_ADDBAReq() Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 28 Nov 2023 12:43:37 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783841916102005301 X-GMAIL-MSGID: 1783841916102005301 Remove unused function rtllib_rx_ADDBAReq(). Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 89 ----------------------- drivers/staging/rtl8192e/rtllib.h | 1 - 2 files changed, 90 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c index 58a950ef77ce..7e4aeb10a2db 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -211,95 +211,6 @@ static void rtllib_send_DELBA(struct rtllib_device *ieee, u8 *dst, netdev_dbg(ieee->dev, "Failed to generate DELBA packet.\n"); } -int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb) -{ - struct ieee80211_hdr_3addr *req = NULL; - u16 rc = 0; - u8 *dst = NULL, *dialog_token = NULL, *tag = NULL; - struct ba_record *ba = NULL; - union ba_param_set *ba_param_set = NULL; - u16 *ba_timeout_value = NULL; - union sequence_control *pBaStartSeqCtrl = NULL; - struct rx_ts_record *ts = NULL; - - if (skb->len < sizeof(struct ieee80211_hdr_3addr) + 9) { - netdev_warn(ieee->dev, "Invalid skb len in BAREQ(%d / %d)\n", - (int)skb->len, - (int)(sizeof(struct ieee80211_hdr_3addr) + 9)); - return -1; - } - -#ifdef VERBOSE_DEBUG - print_hex_dump_bytes("%s: ", DUMP_PREFIX_NONE, __func__, - skb->data, skb->len); -#endif - - req = (struct ieee80211_hdr_3addr *)skb->data; - tag = (u8 *)req; - dst = (u8 *)(&req->addr2[0]); - tag += sizeof(struct ieee80211_hdr_3addr); - dialog_token = tag + 2; - ba_param_set = (union ba_param_set *)(tag + 3); - ba_timeout_value = (u16 *)(tag + 5); - pBaStartSeqCtrl = (union sequence_control *)(req + 7); - - if (!ieee->current_network.qos_data.active || - !ieee->ht_info->current_ht_support || - (ieee->ht_info->iot_action & HT_IOT_ACT_REJECT_ADDBA_REQ)) { - rc = ADDBA_STATUS_REFUSED; - netdev_warn(ieee->dev, - "Failed to reply on ADDBA_REQ as some capability is not ready(%d, %d)\n", - ieee->current_network.qos_data.active, - ieee->ht_info->current_ht_support); - goto OnADDBAReq_Fail; - } - if (!rtllib_get_ts(ieee, (struct ts_common_info **)&ts, dst, - (u8)(ba_param_set->field.tid), RX_DIR, true)) { - rc = ADDBA_STATUS_REFUSED; - netdev_warn(ieee->dev, "%s(): can't get TS\n", __func__); - goto OnADDBAReq_Fail; - } - ba = &ts->rx_admitted_ba_record; - - if (ba_param_set->field.ba_policy == BA_POLICY_DELAYED) { - rc = ADDBA_STATUS_INVALID_PARAM; - netdev_warn(ieee->dev, "%s(): BA Policy is not correct\n", - __func__); - goto OnADDBAReq_Fail; - } - - rtllib_FlushRxTsPendingPkts(ieee, ts); - - deactivate_ba_entry(ieee, ba); - ba->dialog_token = *dialog_token; - ba->ba_param_set = *ba_param_set; - ba->ba_timeout_value = *ba_timeout_value; - ba->ba_start_seq_ctrl = *pBaStartSeqCtrl; - - if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev) || - (ieee->ht_info->iot_action & HT_IOT_ACT_ALLOW_PEER_AGG_ONE_PKT)) - ba->ba_param_set.field.buffer_size = 1; - else - ba->ba_param_set.field.buffer_size = 32; - - activate_ba_entry(ba, 0); - rtllib_send_ADDBARsp(ieee, dst, ba, ADDBA_STATUS_SUCCESS); - - return 0; - -OnADDBAReq_Fail: - { - struct ba_record BA; - - BA.ba_param_set = *ba_param_set; - BA.ba_timeout_value = *ba_timeout_value; - BA.dialog_token = *dialog_token; - BA.ba_param_set.field.ba_policy = BA_POLICY_IMMEDIATE; - rtllib_send_ADDBARsp(ieee, dst, &BA, rc); - return 0; - } -} - int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb) { struct ieee80211_hdr_3addr *rsp = NULL; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index 0a8c44e497f5..44a937953db8 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1776,7 +1776,6 @@ u8 HTCCheck(struct rtllib_device *ieee, u8 *pFrame); void HTResetIOTSetting(struct rt_hi_throughput *ht_info); bool is_ht_half_nmode_aps(struct rtllib_device *ieee); u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate); -int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb); int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb); int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb); void rtllib_ts_init_add_ba(struct rtllib_device *ieee, struct tx_ts_record *ts, From patchwork Tue Nov 28 20:43:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 170960 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp4214330vqx; Tue, 28 Nov 2023 12:43:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IGv0Q+piyo/ScuH/H8Ui7R/y69VbUt90BS72cA9rcmo+mUFyvkPDkSqv2aoUOB139qhteVJ X-Received: by 2002:a17:902:d303:b0:1cf:876e:aa41 with SMTP id b3-20020a170902d30300b001cf876eaa41mr18184710plc.30.1701204220757; Tue, 28 Nov 2023 12:43:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701204220; cv=none; d=google.com; s=arc-20160816; b=oPHWpx2PifVvFs3hZQaNGejugCA4fakPk3OTFQYORDQt/EIzSNNECpXxp5IMuCjvPL 7FHz3ytLWSNr1uYx8/R6nvWaxr0wQ5LV5fU6Cn1LbbJaKP3ypSKBWK1478OA1fDBED0b Gj88AAw1uXhdQutNr1X5PRad9DO1wM0poxt7dYgDjOOkRm/l1VL/Umqo5lM9KxOjeWK0 SV5kykLtySj6QxqpvzyHrxbmiwLuYXjysMVM8a62peSBYAGKDwfw9pVml/uXfzsY1+OO QglnZf7mlEAYc7HG4ZGpJT0KXtjGmQda8J8sscfrWvSXlVl+1zI82ssQltqg20LfW54K Q1OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=q4jh3kAmz3NLMMvf/uU8x0FwkaNbHPqHSzrIk9a+VQ0=; fh=Sw1rtAM+hKyOoOQVYiiLzcdjc4spg79Z/tN6UmWUAKs=; b=PkMKTMySI8G7t2Nz/LLRDb6TwYOwLq5ZtO0mHWwZILqU6Ba+biCcyOhxDkQvggD9pp nVM+v9qggsZ/LbdVIOK/ZQztWTX63ss/+adKY5B+Xg3SCKW3L+gZA3m1jAG7K6+lE5R3 4EcIxwAe7Z/Ads8+mp4SoXFgs8nJYP1prNPNAonld0q+AE7AtsNgYD9u56bTs81msF9O PEnmbDTdJiJd1FklYMVLqAEw4zseNaCbbG9L3SA87RCSw7kLGQ3wnnHsfVCSyPJccYs5 FwrvldY3FWFK1I2mSGtq00IONPdGHEheWQolBly9FVBXjjoBd5P3vIP0jAxy8bv1MtRJ vKnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="A/AIw8CD"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id v5-20020a170902b7c500b001cff3cae848si2443972plz.37.2023.11.28.12.43.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 12:43:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="A/AIw8CD"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 1FD5C80A87E6; Tue, 28 Nov 2023 12:43:37 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346085AbjK1Un1 (ORCPT + 99 others); Tue, 28 Nov 2023 15:43:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229586AbjK1UnZ (ORCPT ); Tue, 28 Nov 2023 15:43:25 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DB751707 for ; Tue, 28 Nov 2023 12:43:31 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-32f8246103cso1553140f8f.1 for ; Tue, 28 Nov 2023 12:43:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701204210; x=1701809010; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=q4jh3kAmz3NLMMvf/uU8x0FwkaNbHPqHSzrIk9a+VQ0=; b=A/AIw8CDPELYNUeNNKE/A8r9dWCEmp+s0ImWveJqBr2xu/1cBCWjk6Sny4wLmz79qx P0mDbsYQFwDgYNnGaCE4irG9847ERrdLTGyPPAK+T+lgSNhWzUHpnaO2ihFiXesu6QVV 1yeMvJzRfiq+xeGSlWPGgSOeF0OnKSgrQ3TT+sBs2tkrfJUZnmOH4eDdN9iEZYN9wWSb 2n8AUksjcGOAtOL1HpjCGFn2TsH3l9DDxKUq1+78qrpdERCnU38kw2ygTH8yL8C0LAJG AgiRz8lbRbBHJIDeztAIL5IL3P0QH0RcZKJ1SgAChDfVC2aD1zPwwebZetIfgEOMQj1j c0Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701204210; x=1701809010; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=q4jh3kAmz3NLMMvf/uU8x0FwkaNbHPqHSzrIk9a+VQ0=; b=sbWvzn6PddA5SZ8tniOSzdr1qzYX2mBzKydd7DA7uxuuGJl4zKq6PMoqAbdXg17trr yrfTjku91PiYFXHwTbMf5EgjKaH4xRtXpHbtrFKF9v0RdrvYoMtoQK4JMuLiksBuhJ0F tYMgftcYyyA/ls+vLgxkNzGe+Hvg1ZbBkTRW2pX917f1q+WHRqGBxjlL7Ml+GktQiVSC FGFjycshtYWVZ7LPs/OnCLMfgBmQ/qWhhKVOHk4NPT237a3hfNZDLizdeGB5iSJMaeg2 8Z7AYfYDW92cUTT3YL8pP+lyFAif0CCg9dmcbbMpUg2taEsVf8M3wkqGsF6xu0pNEsDI QrTg== X-Gm-Message-State: AOJu0YzwjIpEGR6ds5y0QYJaeO1qez7/hxX4KsoSuRnuvhY8z28LO2pJ OgngpY39Q+ZZAu4jbzCAxx4= X-Received: by 2002:a5d:6c6b:0:b0:32d:e435:92c4 with SMTP id r11-20020a5d6c6b000000b0032de43592c4mr14272134wrz.0.1701204209925; Tue, 28 Nov 2023 12:43:29 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p54a07fa0.dip0.t-ipconnect.de. [84.160.127.160]) by smtp.gmail.com with ESMTPSA id s11-20020adfeccb000000b003316b38c625sm15994336wro.99.2023.11.28.12.43.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 12:43:29 -0800 (PST) Date: Tue, 28 Nov 2023 21:43:28 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 3/6] staging: rtl8192e: Remove unused function rtllib_send_ADDBARsp() Message-ID: <3d0b46b4cd2538a797743978c4c2daeec32f1f09.1701202700.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 28 Nov 2023 12:43:37 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783841917132863976 X-GMAIL-MSGID: 1783841917132863976 Remove unused function rtllib_send_ADDBARsp(). Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c index 7e4aeb10a2db..fab7ced1b8c3 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -186,18 +186,6 @@ static void rtllib_send_ADDBAReq(struct rtllib_device *ieee, u8 *dst, netdev_dbg(ieee->dev, "Failed to generate ADDBAReq packet.\n"); } -static void rtllib_send_ADDBARsp(struct rtllib_device *ieee, u8 *dst, - struct ba_record *ba, u16 status_code) -{ - struct sk_buff *skb; - - skb = rtllib_ADDBA(ieee, dst, ba, status_code, ACT_ADDBARSP); - if (skb) - softmac_mgmt_xmit(skb, ieee); - else - netdev_dbg(ieee->dev, "Failed to generate ADDBARsp packet.\n"); -} - static void rtllib_send_DELBA(struct rtllib_device *ieee, u8 *dst, struct ba_record *ba, enum tr_select TxRxSelect, u16 reason_code) From patchwork Tue Nov 28 20:43:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 170961 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp4214463vqx; Tue, 28 Nov 2023 12:43:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IHiuH9eADF7yDGI25O24WopGlltJjzk0kDO+u8kKXO5cZqQmo4pvlNFRioErS+aQrgPRtza X-Received: by 2002:a05:6a20:8f1d:b0:18c:3b26:14f with SMTP id b29-20020a056a208f1d00b0018c3b26014fmr13392163pzk.56.1701204234987; Tue, 28 Nov 2023 12:43:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701204234; cv=none; d=google.com; s=arc-20160816; b=mltwJUnjNFX86SWG8JdFux5vGc/BoErENHyKDGxi0AcHNAQAMfFM83Vq38SdSlNk/s cWiQIusMjMAcVYIsod/TcaEC+239B2YDcqNMODfRV/BBitQX/YBz117c5q+RN+eyOhK/ YDU1X5vhWSnSU1p/chZYIHzMf1y1sKDVCIWU+J24qaQnVfEdMAhyD1CZsA+Nej2Pomh5 M1brrJnGWiP954Qt2fUR3LG6BL+T3nhzctvVdNwXhecVTTcdFS+uAY09gcNSogexVbyk S5VhCDRE7QNsJhV/iCetjXTXkoj3XSe++5UivkfFVRLocvJuhRRRbKi/Y6aOZS0knLKu 6gcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=9QnSXqV0Ukg8Tls+sByuxYlBpsCAZ28kGNWhfBeP1Ho=; fh=Sw1rtAM+hKyOoOQVYiiLzcdjc4spg79Z/tN6UmWUAKs=; b=iGgZ68C1Bi5X/sulvZZi7nKPEnkJiGVkZY8nrN92xzMzKHTU0kFq4YSNulriXZN+gM xCk+VNoJ4Jo+3NVoSGVC0zRu5KtkEsEh49BlDek56IbMDaPcIa91NOWCloH1GU2AMp/z zeonroOE2vnK+Uu3EyXjEEWHX5WcvKO6g9tBxiDMtEr/6q5TOmIv39WIuFsOQTHkKtwt ua7B1ZbNdEJr5tMY+JvWyLGduSQRRZ0xLKlbbxNdVYWq84rHNJvT5IUyvQxFx57/snLq HRpmvmPLYU+etxsYdADgRuBSsX+YQJQ+0q90Y1JA3wsqQuaxfC9AW2W/s0Hi4uDph542 Z08Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="E/bJsYoi"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id r33-20020a635d21000000b005c272dbe3aesi12284821pgb.555.2023.11.28.12.43.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 12:43:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="E/bJsYoi"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 7D8F480A1D9D; Tue, 28 Nov 2023 12:43:51 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230057AbjK1Uni (ORCPT + 99 others); Tue, 28 Nov 2023 15:43:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234807AbjK1Unc (ORCPT ); Tue, 28 Nov 2023 15:43:32 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7B061BC1 for ; Tue, 28 Nov 2023 12:43:37 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-3330bd1e9ecso257631f8f.0 for ; Tue, 28 Nov 2023 12:43:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701204216; x=1701809016; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9QnSXqV0Ukg8Tls+sByuxYlBpsCAZ28kGNWhfBeP1Ho=; b=E/bJsYoiSM68/R+ndirNNxut1KwVM9hdJjkeik6cfqNPtzGn6R/DU0uv6hXo0q164y WjxS92LM2Vq0wJlkS805KKfu7RODWs8I4Qjqhv4tcmNieAazdwthyH3yDllD1EXpZo11 6kwNZkplr0DgICIZAQtHbCGO2dHEjZPsWVIKO0zGkg75kP42TMhW+W/Llh4bfWbeVH+X fmwM78CaR7iNzoWr4ohRcaUgqcWj61uRooRf0GPPUgX6KEa76IS5PELFmNgGqVTKWA7u e+pfqBhQqCTNikF1rJJoh5gYZxi83rPB9NxT4EIUVZJaHuIV7zhmQMeFRwwlfL/j1wpx Tt4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701204216; x=1701809016; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9QnSXqV0Ukg8Tls+sByuxYlBpsCAZ28kGNWhfBeP1Ho=; b=Xeo+hVsqfAvDv0Sva5VIzjLpZjcGNtatJb2XJaE7G6oYPKAMAxTQHRTnt1yiRcgwcd BGHyIbbD4nXXYajQb+iCzBkvboFxUkpLWXeaAWbdzQK63iLTQgy+SNo3p0n0cdligsDA GhwI8saX3akdFBYdWPMiaTqXnOfbKKxO3ILrpBx7rHCk3ew+f1UDZRW8xJhnjFWMEPjB akty7DNF59E7RV8CMt/OltiHqkTlFpesTMPrCvwORtpgIVIjE3niXcpehnaNqJH8FW1k OGwQAGW0pz4GxvT/wp3zG4DcCcBSE+SQZLH18KvXnpKPmDDDRJ/u7LM6yGAq3zi4acpe ng2g== X-Gm-Message-State: AOJu0Ywn/tKP8GwjTTqI6SSdYD4kz58/6oF0+7S7kdZuoYGxK+kcsiTv Htj3jw13J3FlO5KO6+2lvuA= X-Received: by 2002:a05:6000:80e:b0:332:ff23:588a with SMTP id bt14-20020a056000080e00b00332ff23588amr5726442wrb.5.1701204216304; Tue, 28 Nov 2023 12:43:36 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p54a07fa0.dip0.t-ipconnect.de. [84.160.127.160]) by smtp.gmail.com with ESMTPSA id c11-20020a5d4f0b000000b00332e67d6564sm14585699wru.67.2023.11.28.12.43.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 12:43:36 -0800 (PST) Date: Tue, 28 Nov 2023 21:43:33 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 4/6] staging: rtl8192e: Remove unused function rtllib_FlushRxTsPendingPkts() Message-ID: <1a4471053e200e0eb8a39b0a2de6c2f4e9a36656.1701202700.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 28 Nov 2023 12:43:51 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783841931842358023 X-GMAIL-MSGID: 1783841931842358023 Remove unused function rtllib_FlushRxTsPendingPkts(). Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtllib.h | 3 +-- drivers/staging/rtl8192e/rtllib_rx.c | 33 ---------------------------- 2 files changed, 1 insertion(+), 35 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index 44a937953db8..b9ac313e5f97 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1814,8 +1814,7 @@ bool rtllib_MgntDisconnect(struct rtllib_device *rtllib, u8 asRsn); /* For the function is more related to hardware setting, it's better to use the * ieee handler to refer to it. */ -void rtllib_FlushRxTsPendingPkts(struct rtllib_device *ieee, - struct rx_ts_record *ts); + int rtllib_parse_info_param(struct rtllib_device *ieee, struct rtllib_info_element *info_element, u16 length, diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c index d9517dbc5593..fd0357753c30 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -488,39 +488,6 @@ void rtllib_indicate_packets(struct rtllib_device *ieee, } } -void rtllib_FlushRxTsPendingPkts(struct rtllib_device *ieee, - struct rx_ts_record *ts) -{ - struct rx_reorder_entry *pRxReorderEntry; - u8 RfdCnt = 0; - - del_timer_sync(&ts->rx_pkt_pending_timer); - while (!list_empty(&ts->rx_pending_pkt_list)) { - if (RfdCnt >= REORDER_WIN_SIZE) { - netdev_info(ieee->dev, - "-------------->%s() error! RfdCnt >= REORDER_WIN_SIZE\n", - __func__); - break; - } - - pRxReorderEntry = (struct rx_reorder_entry *) - list_entry(ts->rx_pending_pkt_list.prev, - struct rx_reorder_entry, List); - netdev_dbg(ieee->dev, "%s(): Indicate SeqNum %d!\n", __func__, - pRxReorderEntry->SeqNum); - list_del_init(&pRxReorderEntry->List); - - ieee->RfdArray[RfdCnt] = pRxReorderEntry->prxb; - - RfdCnt = RfdCnt + 1; - list_add_tail(&pRxReorderEntry->List, - &ieee->RxReorder_Unused_List); - } - rtllib_indicate_packets(ieee, ieee->RfdArray, RfdCnt); - - ts->rx_indicate_seq = 0xffff; -} - static void RxReorderIndicatePacket(struct rtllib_device *ieee, struct rtllib_rxb *prxb, struct rx_ts_record *ts, u16 SeqNum) From patchwork Tue Nov 28 20:43:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 170963 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp4214614vqx; Tue, 28 Nov 2023 12:44:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IEp0/k8GEJCzJei36wzXGkGPlSPopvh+h6PHZYR65D9BQUfGYUrcek9AWfK00KIKRpBsUi7 X-Received: by 2002:a05:6a20:144b:b0:18c:548d:3d0f with SMTP id a11-20020a056a20144b00b0018c548d3d0fmr16438783pzi.5.1701204252059; Tue, 28 Nov 2023 12:44:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701204252; cv=none; d=google.com; s=arc-20160816; b=l6rqWQ4hI9yR4O9Th6WkvlVM7N73zNWLYCBeFt+aJR1XoIQ5yo+KIFmAEBcVQh4LwE CAg7QH/hkNKR+MxmCk65fsViI3EFMZRoqHa+hgNai9zk5N4ItLKExyPCxlHRnbiJdp5N /h829z7TRj4Okf8GfsDL78CTr+npxdDLOe9YwG73DwAnXmh0yPsMiYHGlyh0Fwl8Pq9i hfgo7Eb4S6xve1Zb98ycNjYajehzcu7ieWpkxzEwaqGEA+rMA8ItLzLH3sADXK3lQ64m s/Ocjasw+puBKzNCrGk1paEK6etJjHfFUEK/9ElgjiSSoWbec7w+uy6n6RMLPjyFP6JM qPRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=V6Qf6Ds+xSBk1DuDIL8ubxSxi2PW7CPsIXUHtrOAG3o=; fh=Sw1rtAM+hKyOoOQVYiiLzcdjc4spg79Z/tN6UmWUAKs=; b=w8KuP0QTQapfOojxmjVVDd74XhkqXZ193rjyDydVWqn/RxVW4q85cf7H7M2WzWCAc5 nmXBOpB32WLOKS1aMeILnEXmLFW4EM9DyjSIOrGVetijVdM+7gonJ4JyXuswePbioBze wbld8Wv3UUn40qHvW682VFy46w8Pf14vekRR7N2kVmJtgIvIA0eha7mrsppYvkHZ0l34 hXk32rL2trTgdm1QhLxl+xUlI2/rIaE0WouhkFePCidICZQhIx5QLA1Tg3jIbchhrA6r 0iEzL4dQb4Krx4vEUk2wNZfH7aOUb468V/qKEORqCZDoCHo21GTOpFJU2hKS/qiYGheC +sCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=JbOLAyXy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id fi40-20020a056a0039a800b006c8d6276344si13359312pfb.339.2023.11.28.12.44.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 12:44:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=JbOLAyXy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 615858060CBB; Tue, 28 Nov 2023 12:44:08 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346198AbjK1Uno (ORCPT + 99 others); Tue, 28 Nov 2023 15:43:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234901AbjK1Ung (ORCPT ); Tue, 28 Nov 2023 15:43:36 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 680E019BA for ; Tue, 28 Nov 2023 12:43:41 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-40b3febbce3so4486025e9.1 for ; Tue, 28 Nov 2023 12:43:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701204220; x=1701809020; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=V6Qf6Ds+xSBk1DuDIL8ubxSxi2PW7CPsIXUHtrOAG3o=; b=JbOLAyXyXFCqPb956mV6UvVfb8f1u+z+brq14lps7EC3rCj+ZbAR4hNCZXT+AHIpga 9CLyII0xuE/XRZ6sm4XCv3upnHa6xUuO5Kpjcjt2oAZURsqLOcgSg0nBkH1mKuk1Bvel VflwKgfbcVMmqKM6IZMZThTeBRkqfeIHcm2pV27kmXAZ/a1mwXkWCE2wWVcimGbyr7DM ONAAKXxQs4K6qA8BZU5YfDM/qXHkdaTi7CCiBBLh08ky6+jVIRWP05RiS7NI3LSssdkq fdPn3DCi8gJBj7IxnwFu8j6OCkU7az6kyazHUII8CbN0R3ubc0zpSP8vsus4hKSSUCSB j1iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701204220; x=1701809020; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=V6Qf6Ds+xSBk1DuDIL8ubxSxi2PW7CPsIXUHtrOAG3o=; b=wNRlfIwg/pYjoqYdHWQ6vwCqNpx6DWldCMqSy4rZgbc0kK5uD2G27xyKVUeFABp19F 8xGGcRn3VuVMUQncrL0d/rb0P4mFRObQs/BmTMjamwoT0lCR+psOHOZA+zez1kuoh9wn IQasO86xIEGoPF5oJm6RfWMj+fBUQaayqI3yGo/3T+1RsH1Ugt/GqleR1AQhGtHOJSrR uYs1G7z5mR9tKL67SJ4l6y4orSjp9S0zpkN5elrI/ER3Je3UuNZW/4xQRCgjs+yvUkZM B6n6+LiwFbMxzyxT422h5GxcbpFtOYMibZV0HEhVPrGC4HMh51DnqtBH2vFlMvBziyMi +y+g== X-Gm-Message-State: AOJu0YyeWWeyXP2gtyRqssS0/jJQADMUoyl7K+YgTcMNFpYqR2pFCZjt sMqUwaMooMqhIF9NVxOMu4o= X-Received: by 2002:a05:600c:3b0c:b0:40b:2708:2a52 with SMTP id m12-20020a05600c3b0c00b0040b27082a52mr11322988wms.1.1701204219639; Tue, 28 Nov 2023 12:43:39 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p54a07fa0.dip0.t-ipconnect.de. [84.160.127.160]) by smtp.gmail.com with ESMTPSA id b5-20020a05600c4e0500b003feae747ff2sm19621595wmq.35.2023.11.28.12.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 12:43:39 -0800 (PST) Date: Tue, 28 Nov 2023 21:43:38 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 5/6] staging: rtl8192e: Remove unused function rtllib_rx_ADDBARsp() Message-ID: <988974fbec7d28455bb575eb52cfe1b974ce8293.1701202700.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 28 Nov 2023 12:44:08 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783841949730754391 X-GMAIL-MSGID: 1783841949730754391 Remove unused function rtllib_rx_ADDBARsp(). Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 99 ----------------------- drivers/staging/rtl8192e/rtllib.h | 1 - 2 files changed, 100 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c index fab7ced1b8c3..4dadeb43b9a2 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -199,105 +199,6 @@ static void rtllib_send_DELBA(struct rtllib_device *ieee, u8 *dst, netdev_dbg(ieee->dev, "Failed to generate DELBA packet.\n"); } -int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb) -{ - struct ieee80211_hdr_3addr *rsp = NULL; - struct ba_record *pending_ba, *admitted_ba; - struct tx_ts_record *ts = NULL; - u8 *dst = NULL, *dialog_token = NULL, *tag = NULL; - u16 *status_code = NULL, *ba_timeout_value = NULL; - union ba_param_set *ba_param_set = NULL; - u16 reason_code; - - if (skb->len < sizeof(struct ieee80211_hdr_3addr) + 9) { - netdev_warn(ieee->dev, "Invalid skb len in BARSP(%d / %d)\n", - (int)skb->len, - (int)(sizeof(struct ieee80211_hdr_3addr) + 9)); - return -1; - } - rsp = (struct ieee80211_hdr_3addr *)skb->data; - tag = (u8 *)rsp; - dst = (u8 *)(&rsp->addr2[0]); - tag += sizeof(struct ieee80211_hdr_3addr); - dialog_token = tag + 2; - status_code = (u16 *)(tag + 3); - ba_param_set = (union ba_param_set *)(tag + 5); - ba_timeout_value = (u16 *)(tag + 7); - - if (!ieee->current_network.qos_data.active || - !ieee->ht_info->current_ht_support || - !ieee->ht_info->current_ampdu_enable) { - netdev_warn(ieee->dev, - "reject to ADDBA_RSP as some capability is not ready(%d, %d, %d)\n", - ieee->current_network.qos_data.active, - ieee->ht_info->current_ht_support, - ieee->ht_info->current_ampdu_enable); - reason_code = DELBA_REASON_UNKNOWN_BA; - goto OnADDBARsp_Reject; - } - - if (!rtllib_get_ts(ieee, (struct ts_common_info **)&ts, dst, - (u8)(ba_param_set->field.tid), TX_DIR, false)) { - netdev_warn(ieee->dev, "%s(): can't get TS\n", __func__); - reason_code = DELBA_REASON_UNKNOWN_BA; - goto OnADDBARsp_Reject; - } - - ts->add_ba_req_in_progress = false; - pending_ba = &ts->tx_pending_ba_record; - admitted_ba = &ts->tx_admitted_ba_record; - - if (admitted_ba->b_valid) { - netdev_dbg(ieee->dev, "%s(): ADDBA response already admitted\n", - __func__); - return -1; - } else if (!pending_ba->b_valid || - (*dialog_token != pending_ba->dialog_token)) { - netdev_warn(ieee->dev, - "%s(): ADDBA Rsp. BA invalid, DELBA!\n", - __func__); - reason_code = DELBA_REASON_UNKNOWN_BA; - goto OnADDBARsp_Reject; - } else { - netdev_dbg(ieee->dev, - "%s(): Recv ADDBA Rsp. BA is admitted! Status code:%X\n", - __func__, *status_code); - deactivate_ba_entry(ieee, pending_ba); - } - - if (*status_code == ADDBA_STATUS_SUCCESS) { - if (ba_param_set->field.ba_policy == BA_POLICY_DELAYED) { - ts->add_ba_req_delayed = true; - deactivate_ba_entry(ieee, admitted_ba); - reason_code = DELBA_REASON_END_BA; - goto OnADDBARsp_Reject; - } - - admitted_ba->dialog_token = *dialog_token; - admitted_ba->ba_timeout_value = *ba_timeout_value; - admitted_ba->ba_start_seq_ctrl = pending_ba->ba_start_seq_ctrl; - admitted_ba->ba_param_set = *ba_param_set; - deactivate_ba_entry(ieee, admitted_ba); - activate_ba_entry(admitted_ba, *ba_timeout_value); - } else { - ts->add_ba_req_delayed = true; - ts->disable_add_ba = true; - reason_code = DELBA_REASON_END_BA; - goto OnADDBARsp_Reject; - } - - return 0; - -OnADDBARsp_Reject: - { - struct ba_record BA; - - BA.ba_param_set = *ba_param_set; - rtllib_send_DELBA(ieee, dst, &BA, TX_DIR, reason_code); - return 0; - } -} - int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb) { struct ieee80211_hdr_3addr *delba = NULL; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index b9ac313e5f97..7d64855d835d 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1776,7 +1776,6 @@ u8 HTCCheck(struct rtllib_device *ieee, u8 *pFrame); void HTResetIOTSetting(struct rt_hi_throughput *ht_info); bool is_ht_half_nmode_aps(struct rtllib_device *ieee); u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate); -int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb); int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb); void rtllib_ts_init_add_ba(struct rtllib_device *ieee, struct tx_ts_record *ts, u8 policy, u8 overwrite_pending); From patchwork Tue Nov 28 20:43:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 170962 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp4214534vqx; Tue, 28 Nov 2023 12:44:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IGVLIrZ3A1txPl4+5Jwin7J7xMunWOZSJcarRMzCDl0xyq3xHTnBmSt1qSCH/cY7C3Mio9X X-Received: by 2002:a17:903:2285:b0:1cf:b964:5e37 with SMTP id b5-20020a170903228500b001cfb9645e37mr11791193plh.12.1701204243109; Tue, 28 Nov 2023 12:44:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701204243; cv=none; d=google.com; s=arc-20160816; b=nfc0tTV4zsQfvp+Lzf8a9nq6+roJDVW6KxTrNIQROCNzf+Ef+pdb2xelZQvSpctM3R i4j2Hc5kF53PTtbkIciRq508ZPyDZfSz6Jyn0mz68hncOqnNCgp1G+JI0zDIY1It9E7B eeAetT4t0UHttY+gvxKT/QOrAQVLABNlzWFECBck0O09AVjg3VJnhvoXK0ArL9HYltc3 WcfvvjX3WU/a3RBSHaUysKtzj7MwHFDUqVJJA7UFDVpPlrqtYcLVcJ23OC9fLYTtGuzq JT/txZLYrrjgSe3mNZ/tN3dOOUwzt2x4XqU1BTZbfeL7D7I/P/4bgSlWPthZulnz1BfF hd6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=ikCgusC8eEFeJmPuPKC5u+Kpxfzr4U1dFEb8bUETbj8=; fh=Sw1rtAM+hKyOoOQVYiiLzcdjc4spg79Z/tN6UmWUAKs=; b=SU5tqgbQ3zmJrdUtX0MnRAX9nGZfdragvNG49q4ML6t4c5niXq8ePsKcPosnGoS+NB f34F57PIjxp3zJcxMjDG0SYNzNtPlOheJXrYyyyg6ApUeDlDch0oR05hhnXwBp3ZFKOb xW+zh92pWd6YZl9eNhwpaWGpl+KarE8PJ2GgxpiK/twCSYjWls8pYWykw42qV+wnyx1l A0qphpQhjHkaUDbm9daCTBhxSbzzUzCsClMGe8ZCVda9m7kGWVGHZdXI5zfAh/p8rKyZ PzAOwIvAIJoyEMuJt8CgO3vfhxoK/Q7lzWcZ6x28fuh1Zm+Okguzv+Ih3QArmZnF8hYS L7Yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=N8RsPuQP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id o14-20020a170902d4ce00b001d0050e246bsi1440097plg.43.2023.11.28.12.44.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 12:44:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=N8RsPuQP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 6556B8060CBA; Tue, 28 Nov 2023 12:44:00 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230050AbjK1Unu (ORCPT + 99 others); Tue, 28 Nov 2023 15:43:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346221AbjK1Unk (ORCPT ); Tue, 28 Nov 2023 15:43:40 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 432F819AE for ; Tue, 28 Nov 2023 12:43:46 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-40b3febbce3so4486185e9.1 for ; Tue, 28 Nov 2023 12:43:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701204225; x=1701809025; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ikCgusC8eEFeJmPuPKC5u+Kpxfzr4U1dFEb8bUETbj8=; b=N8RsPuQP0NcADmz9wvhGmRxWxuWboBYjvDReV3rnQ+6kYuNXqpCm3hbYXU3YXc9mG4 2Vh1yXQhZ/PSCv0Bj1c1vJL3yboheOSjZ9Z6SHH8zMdmvdg75EOdg+qOQEFzfT/NOr31 R/5DpEtdlDi5MqIk2SvRhtbvrTgQ4Hu3ooRX9IJCuETGdWOlooyI8x+1OjvrSmMlQ0q7 qUGdLJk70TetJMblo7xud9l+XqD+N7dM30z0RtsB9HuEFXkuKIDEfvtY9N0bmvJOCG/C 7aeylG/aEhF7cKGZ9kIIhcVCWSG3XzcV8RVhLdNxanzNzypwY5laUvFvzNI/PWRQBeua V8ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701204225; x=1701809025; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ikCgusC8eEFeJmPuPKC5u+Kpxfzr4U1dFEb8bUETbj8=; b=GKdzs0BleK5/180Z1jb3zBKwUxrHJbtXJQ64PGIcQErXgSSPVcW48os7mApJMO86Oj Z317tObNOkCrV6xC8//xLjiDk/hcZZqepaShgBl4d/+n9HzfXtPBAGVjEHlnpkbOiuDE UF0hI//jest6qJ5LRJZiWboIclBHOlAY0dYjnQw7rsw2prCfXNyG5pODqOYTylUevQac OHQXbj7kP1w0ZqnXUu1fwzMo7HtAH4Hws86AjBM3ha9nt3JBcqAOf1NNS3TsYkYwpiLg yOKmAYLWBcz992iyM1V1cDWKhkNIcf7BocRXTZL9JTpkUCAaG5oA+HWvnI2FYuRpRPNL 0E7g== X-Gm-Message-State: AOJu0Ywd3S2bPZazy/Vt1xUu6wvxFea0lU0HoHNnRWD1b9outY1tmXvl HlNfoov1T6vcVdwLgOSkHJE4xeX+U9o= X-Received: by 2002:a05:600c:54f0:b0:40b:4b69:b1a0 with SMTP id jb16-20020a05600c54f000b0040b4b69b1a0mr2379669wmb.3.1701204224692; Tue, 28 Nov 2023 12:43:44 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p54a07fa0.dip0.t-ipconnect.de. [84.160.127.160]) by smtp.gmail.com with ESMTPSA id a15-20020a05600c348f00b0040b33222a39sm19690937wmq.45.2023.11.28.12.43.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 12:43:44 -0800 (PST) Date: Tue, 28 Nov 2023 21:43:43 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 6/6] staging: rtl8192e: Remove unused function rtllib_rx_DELBA() Message-ID: <566083b9cba530e3b17074bd3410e686c1778f0d.1701202700.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 28 Nov 2023 12:44:00 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783841940561808784 X-GMAIL-MSGID: 1783841940561808784 Remove unused function rtllib_rx_DELBA(). Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 62 ----------------------- drivers/staging/rtl8192e/rtllib.h | 1 - 2 files changed, 63 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c index 4dadeb43b9a2..725139eb2deb 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -199,68 +199,6 @@ static void rtllib_send_DELBA(struct rtllib_device *ieee, u8 *dst, netdev_dbg(ieee->dev, "Failed to generate DELBA packet.\n"); } -int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb) -{ - struct ieee80211_hdr_3addr *delba = NULL; - union delba_param_set *pDelBaParamSet = NULL; - u8 *dst = NULL; - - if (skb->len < sizeof(struct ieee80211_hdr_3addr) + 6) { - netdev_warn(ieee->dev, "Invalid skb len in DELBA(%d / %d)\n", - (int)skb->len, - (int)(sizeof(struct ieee80211_hdr_3addr) + 6)); - return -1; - } - - if (!ieee->current_network.qos_data.active || - !ieee->ht_info->current_ht_support) { - netdev_warn(ieee->dev, - "received DELBA while QOS or HT is not supported(%d, %d)\n", - ieee->current_network. qos_data.active, - ieee->ht_info->current_ht_support); - return -1; - } - -#ifdef VERBOSE_DEBUG - print_hex_dump_bytes("%s: ", DUMP_PREFIX_NONE, skb->data, - __func__, skb->len); -#endif - delba = (struct ieee80211_hdr_3addr *)skb->data; - dst = (u8 *)(&delba->addr2[0]); - pDelBaParamSet = (union delba_param_set *)&delba->seq_ctrl + 2; - - if (pDelBaParamSet->field.initiator == 1) { - struct rx_ts_record *ts; - - if (!rtllib_get_ts(ieee, (struct ts_common_info **)&ts, dst, - (u8)pDelBaParamSet->field.tid, RX_DIR, false)) { - netdev_warn(ieee->dev, - "%s(): can't get TS for RXTS. dst:%pM TID:%d\n", - __func__, dst, - (u8)pDelBaParamSet->field.tid); - return -1; - } - - rx_ts_delete_ba(ieee, ts); - } else { - struct tx_ts_record *ts; - - if (!rtllib_get_ts(ieee, (struct ts_common_info **)&ts, dst, - (u8)pDelBaParamSet->field.tid, TX_DIR, false)) { - netdev_warn(ieee->dev, "%s(): can't get TS for TXTS\n", - __func__); - return -1; - } - - ts->using_ba = false; - ts->add_ba_req_in_progress = false; - ts->add_ba_req_delayed = false; - del_timer_sync(&ts->ts_add_ba_timer); - tx_ts_delete_ba(ieee, ts); - } - return 0; -} - void rtllib_ts_init_add_ba(struct rtllib_device *ieee, struct tx_ts_record *ts, u8 policy, u8 overwrite_pending) { diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index 7d64855d835d..f1cd9eb96a7e 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1776,7 +1776,6 @@ u8 HTCCheck(struct rtllib_device *ieee, u8 *pFrame); void HTResetIOTSetting(struct rt_hi_throughput *ht_info); bool is_ht_half_nmode_aps(struct rtllib_device *ieee); u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate); -int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb); void rtllib_ts_init_add_ba(struct rtllib_device *ieee, struct tx_ts_record *ts, u8 policy, u8 overwrite_pending); void rtllib_ts_init_del_ba(struct rtllib_device *ieee,