From patchwork Sun Nov 26 15:44:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 169875 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp2543849vqx; Sun, 26 Nov 2023 07:47:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IG45D29tDuSGHHMjSsuWcUH+iFDqTtzCOLORJphtpRWSB18dse+F2DJsXf5vrcV8eSYMRH0 X-Received: by 2002:a05:6808:1455:b0:3b8:33dd:fae9 with SMTP id x21-20020a056808145500b003b833ddfae9mr14157463oiv.12.1701013635026; Sun, 26 Nov 2023 07:47:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701013634; cv=none; d=google.com; s=arc-20160816; b=i5LpfMR+XoOEJD/lxwndY2jXPQnSRz23RNFBlhzkRDbD8T2h6C9N5daydF5EMtTp/t ZLQ+nZFOKE9YNRp7Nl3VQwssdVZh8pMDAi+OLMRBgz1OaV5OFKjwmZ2NHHoYmHNJaVWY /SLzbaUugxEqhwrxyV82LGXu6rA0d1QH7J4Ctrpjq8epTVoTPl3PmG5e9O4OopU97aZg zKgcMAsQVNxxuKV6+Vr03QZC0kE320HJoOGAZriiidu2kw1WHai1hOt9c52Fn1AKpEsi Ykwxgp9PIS9P2HLmX9tSzreYMYeYbl/nW4pJLYu4/yV+xmll1UuWkh0ex+NZ1kNRWr6Q VS6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ZPhojAvgi+YoDilK1ECw25JeY/ntj0LxcVc6MoPKWUg=; fh=yrurfj0wqsNBtuv2/DS7hXM5gjUdNl0RGba7zZuGnHQ=; b=b/XNxf2SIjSviKnxGTtJM5kLsNiOvfqxfc/gM0bTYX2Lwa0Lhqi1BV0tb7PB1ltQ4X CDFf0+u3pGSMjOvuERYeJiw6+nsh1aFVZGFvfDoqhz1TI/XsZ99j4K6Ul3sxWlfanGze OfWKpNBl8B8av9Osth/VmK6azXHob0NztCE2dXkTaMnDz4N0b8GgCIfKyb7Awt6NH8E2 oCx1L4KPvE6uBKxH4aNl2yxc80YEFEdbQj8jcGpUenLsdZYk/DQwJSzGb7jP+zWDF/qW zx2RXnomlnsLvvBEb+uhzOb+bV/FEHvQHSwPpN+skSxfP54+j4GUWjkJnmODKumPpXVG k7Qw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=GL9ss8D6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id e36-20020a630f24000000b005ab92870413si7951175pgl.498.2023.11.26.07.47.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 07:47:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=GL9ss8D6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 6F3008068E36; Sun, 26 Nov 2023 07:47:12 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230488AbjKZPql (ORCPT + 99 others); Sun, 26 Nov 2023 10:46:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230229AbjKZPqc (ORCPT ); Sun, 26 Nov 2023 10:46:32 -0500 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E992010A for ; Sun, 26 Nov 2023 07:46:38 -0800 (PST) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-a00a9c6f283so458823766b.0 for ; Sun, 26 Nov 2023 07:46:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1701013597; x=1701618397; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZPhojAvgi+YoDilK1ECw25JeY/ntj0LxcVc6MoPKWUg=; b=GL9ss8D6v4qFRbk61VECZ4zLfvtoMVEqq2HUxlSxqnAJ5hWByl8N1rc8TmGgFwxXcT QoEnURT5m04l+nwl0NFFte5R93oCOYpd3G+nFwHOpsCNPCOHCwdoznRdy3b3xnl2ho9U tNX+taJEx6jSn13NSl+LjNTMg5q6XlaB4kzsU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701013597; x=1701618397; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZPhojAvgi+YoDilK1ECw25JeY/ntj0LxcVc6MoPKWUg=; b=vb73W76jhSZa0m693LwAw/9kwxnIUladz7gvTnHCXO0o+Qkg5VLGTLwACsUzFjaoCh vvuV180Fu7fUmLBTp6EPSA1Mbvcv1ToTfHbxPreIjw6srG+WxOWIpUViTsPlBLMaeWyD P8Ey+llnyo/n02g+mb9cpdn3Y8tRpWvF39C0aYm1n3odMMQBAjVBtKPsHJWSlI3sk7/K d0kiOZ4vgrgtyi9eMde3BBVujh7MeK6JcCXLfvJJ8MFHo/GSDOLW7FPaNIBrPzFEhMcF NTHAPtDFRo/qOsHEvYtyPIg97pfLUAxmuIJlML12J6gKj/WBSg0dU2Zh9ZQuWhVyaE+q p6HQ== X-Gm-Message-State: AOJu0Yzs61EcdkChly2ho2jzevIck2ResCCXb0g5Kmo7FwTA8TGUTvzS peinM/oGNnzV+YodUdjdjcIVtZV35hfbuswAyExD4g== X-Received: by 2002:a17:906:2f14:b0:9fe:ab09:4d9 with SMTP id v20-20020a1709062f1400b009feab0904d9mr5649578eji.59.1701013596469; Sun, 26 Nov 2023 07:46:36 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-95-244-100-54.retail.telecomitalia.it. [95.244.100.54]) by smtp.gmail.com with ESMTPSA id h24-20020a170906591800b009fdc684a79esm4656158ejq.124.2023.11.26.07.46.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 07:46:34 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , michael@amarulasolutions.com, Dario Binacchi , Andrzej Hajda , Daniel Vetter , Dave Stevenson , David Airlie , Frieder Schrempf , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Robert Foss , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v2 01/11] drm/bridge: Fix bridge disable logic Date: Sun, 26 Nov 2023 16:44:53 +0100 Message-ID: <20231126154605.15767-2-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231126154605.15767-1-dario.binacchi@amarulasolutions.com> References: <20231126154605.15767-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Sun, 26 Nov 2023 07:47:12 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783642073348329738 X-GMAIL-MSGID: 1783642073348329738 As explained by the comment of the fixed code, we need to find the next bridge that hasn't set the "pre_enable_prev_first" flag to true. The code, on the contrary, was doing the opposite. So, the order of disabling the bridges couldn't be altered as required by setting the "pre_enable_prev_first" flag to true. Fixes: 4fb912e5e190 ("drm/bridge: Introduce pre_enable_prev_first to alter bridge init order") Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/gpu/drm/drm_bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index 30d66bee0ec6..f66bf4925dd8 100644 --- a/drivers/gpu/drm/drm_bridge.c +++ b/drivers/gpu/drm/drm_bridge.c @@ -686,7 +686,7 @@ void drm_atomic_bridge_chain_post_disable(struct drm_bridge *bridge, */ list_for_each_entry_from(next, &encoder->bridge_chain, chain_node) { - if (next->pre_enable_prev_first) { + if (!next->pre_enable_prev_first) { next = list_prev_entry(next, chain_node); limit = next; break; From patchwork Sun Nov 26 15:44:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 169883 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp2546865vqx; Sun, 26 Nov 2023 07:54:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IGV/LFBwnyV/vqBLAtvRDbdtmTa8YAhPYFPWxyeBsxGnTtGb2dSX9lU+OLwaQBVGPMZdGRz X-Received: by 2002:a05:6a21:a5a0:b0:17a:4871:63fd with SMTP id gd32-20020a056a21a5a000b0017a487163fdmr15024303pzc.0.1701014094773; Sun, 26 Nov 2023 07:54:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701014094; cv=none; d=google.com; s=arc-20160816; b=PuftLkXCa42TKRSC55qcjySLpFpZZX7EYvYA0qxNwFbKjoOFVM+fJ62nfttxXS6BoA UHdjiavoWMUI+UyK6nbdD8w34udoKy8tl+Zm0HiLQr+WSiXIh+ua9XCkSyxOm+A3HIhp p3Vsgr7p2ZJncIRdd6OzNxNOEJgLrwGvqi4zPVke8muaHzWlrz2RIn4B0sUM4SDCClrd Oe1m+I4omouryZGUIKKrh79ENgZHKmB2jwq51QJVLRteTtxwGnoSZuEo2aAAEL5cffZ9 2mevYZpxSfL8AaAaeomUHbD3fVuNebtdWtUoCkd+Q2JUwUUf8vTPfqCahW7z/PYzS7EU c4nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=beJZbKgVXOvauoKe8Q8WUu/Tdv6GIAu4T+G5aSDiyXw=; fh=yrurfj0wqsNBtuv2/DS7hXM5gjUdNl0RGba7zZuGnHQ=; b=DMPG3b0oftWEOtKfwIpzJOz6na1Mv1PX+Gxhc9+/auWZU4lMYUvHCD59HurB0WJxjX CHFbTtoKRQrH10yNE0Cc+kF3IUtqm4sd+foZL7TKdglQ2jHFW/oO/7c5mw9H+sThbJTm lWoJGKiobGNafkB+vLX+TORNx4/8o6Wk5GE/m2rbd+jNRV2pYguXur4aS6Xk78pMtv8f 0j9ERxDCpHbi0jnV/5LvSosF5NEAQM6yL9iQOKQVYR1b3rIVbrT7sh/Yzv4bd1JBT+rg /l1O/YBP3kth2f3u2lEKoVfY9R3Uvg/PGJd97iQLYqVhPlcZvk+t4Jb6zrW+tZ1w45zI h1ug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=ilvDmsPF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id w8-20020a656948000000b005bddb7249e0si8733619pgq.313.2023.11.26.07.54.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 07:54:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=ilvDmsPF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id F068480B02B1; Sun, 26 Nov 2023 07:54:49 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231475AbjKZPrP (ORCPT + 99 others); Sun, 26 Nov 2023 10:47:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230243AbjKZPqe (ORCPT ); Sun, 26 Nov 2023 10:46:34 -0500 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2212E107 for ; Sun, 26 Nov 2023 07:46:41 -0800 (PST) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a00cbb83c82so488912666b.2 for ; Sun, 26 Nov 2023 07:46:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1701013599; x=1701618399; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=beJZbKgVXOvauoKe8Q8WUu/Tdv6GIAu4T+G5aSDiyXw=; b=ilvDmsPFXBSj0Us7+oJysEEVrS2Bo6JJQmyeJwrNeMK/GFBpdZ8JYSdbLdJTaz7dkY OYLfSGTHeg4IAdM2sY2gTxk2VbFhWtQj6TKmD6wXKNXSrJx7eWvmaGMm10LgoHxHqkcO pznZND6wrjvdAAVzHE/30Z3psxkUorB4WWTaY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701013599; x=1701618399; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=beJZbKgVXOvauoKe8Q8WUu/Tdv6GIAu4T+G5aSDiyXw=; b=Kx75JlNIXTIaVX7Flr4ZOta5SkFsPgREk5viNwZrnNdzaOWo8ou8DAk2I2K5yQpOzP UIbBMQYLdjWbAmSSuufBmXTxICzq2IjMAIXWM3r4SiRjVlgCBqgZmz+eI8uX2xX3c3re TcMiNfu7+UTTCOyewQIpYNb2GW0+pBfNHdiUpV/wy9bHh9vl0boYDBKKOoH1as2uUwK4 TKoN7ZUoNnzSDwaoomQz86AkZ1Ovuj8vjUsdSDPtEkBlNSlcMZwZJ8j+m0K3qU6pzMEQ v3ItadtWrFm41YlJ36uZd82Kfup/vNP9v8Rj2UEtL9Sq8MOFLBLVxlsz6Az3CFhsoceB MrhA== X-Gm-Message-State: AOJu0YxvG6O09RjCsw7Rg6u+OQVW3wgIWT1T1pBgJJ1JaKXNH+APE81x 7BBl+NzXfXVlx4fGzW0z8HYJ9euWbEfFe1SEKRwiGw== X-Received: by 2002:a17:906:1d2:b0:a08:e229:5659 with SMTP id 18-20020a17090601d200b00a08e2295659mr5777948ejj.17.1701013599386; Sun, 26 Nov 2023 07:46:39 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-95-244-100-54.retail.telecomitalia.it. [95.244.100.54]) by smtp.gmail.com with ESMTPSA id h24-20020a170906591800b009fdc684a79esm4656158ejq.124.2023.11.26.07.46.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 07:46:38 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , michael@amarulasolutions.com, Dario Binacchi , Andrzej Hajda , Daniel Vetter , Dave Stevenson , David Airlie , Frieder Schrempf , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Robert Foss , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v2 02/11] drm/bridge: Fix a use case in the bridge disable logic Date: Sun, 26 Nov 2023 16:44:54 +0100 Message-ID: <20231126154605.15767-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231126154605.15767-1-dario.binacchi@amarulasolutions.com> References: <20231126154605.15767-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Sun, 26 Nov 2023 07:54:50 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783642555498789554 X-GMAIL-MSGID: 1783642555498789554 The patch fixes the code for finding the next bridge with the "pre_enable_prev_first" flag set to false. In case this condition is not verified, i. e. there is no subsequent bridge with the flag set to false, the whole bridge list is traversed, invalidating the "next" variable. The use of a new iteration variable (i. e. "iter") ensures that the value of the "next" variable is not invalidated. Fixes: 4fb912e5e190 ("drm/bridge: Introduce pre_enable_prev_first to alter bridge init order") Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/gpu/drm/drm_bridge.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c index f66bf4925dd8..2e5781bf192e 100644 --- a/drivers/gpu/drm/drm_bridge.c +++ b/drivers/gpu/drm/drm_bridge.c @@ -662,7 +662,7 @@ void drm_atomic_bridge_chain_post_disable(struct drm_bridge *bridge, struct drm_atomic_state *old_state) { struct drm_encoder *encoder; - struct drm_bridge *next, *limit; + struct drm_bridge *iter, *next, *limit; if (!bridge) return; @@ -680,14 +680,15 @@ void drm_atomic_bridge_chain_post_disable(struct drm_bridge *bridge, * was enabled first, so disabled last */ limit = next; + iter = next; /* Find the next bridge that has NOT requested * prev to be enabled first / disabled last */ - list_for_each_entry_from(next, &encoder->bridge_chain, + list_for_each_entry_from(iter, &encoder->bridge_chain, chain_node) { - if (!next->pre_enable_prev_first) { - next = list_prev_entry(next, chain_node); + if (!iter->pre_enable_prev_first) { + next = list_prev_entry(iter, chain_node); limit = next; break; } From patchwork Sun Nov 26 15:44:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 169884 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp2546906vqx; Sun, 26 Nov 2023 07:55:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IHl71sB/oLfQdWpm5vA1Nxd3jPrKfuPTXgqq0ks+y63Rp4FBxvpaTE+hy0dT7FnEMXDz5lK X-Received: by 2002:a05:6a20:54a7:b0:18b:92b3:7c80 with SMTP id i39-20020a056a2054a700b0018b92b37c80mr13085180pzk.22.1701014100993; Sun, 26 Nov 2023 07:55:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701014100; cv=none; d=google.com; s=arc-20160816; b=TmwGVohInzYfqUDuYYqEyW6r4/b4c6VkCTPbUfvT87qPeCCKd2K7RdDN42ctl0PSvN NuFEHS0pvyaelbp8bm9DWitg8ugU8OdOdfy20t1kAf9e0sDBDj/WuiNTPteKEX4ITIIe 9Wj9i3KTC9MDbOY3D6sef4CkwqMIPNdNx6lUDyjRyV6M+tEJlJNjpH1C3DnSWpW2Ganb JpuijIH344cgr1pap75+zm94vbTEp4Yp5ebPNpYQKT+m663yIIoXtpFFDLjMJpEidZAb TDbZTURghjw1mPwDOkFaW6kX+tyJ5JJAUsqLZwOnK5D6OUDX1EVNLTilSpN4TdWmfz7w 0lrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Frvwetq2uP6wtxuP9UX1ctUqElygA7huby/aEqYEpm0=; fh=m6aHy4GVWeiYcahcFfIzqNn3pzsQZUVlVWbThwuybpU=; b=higw/xI0MRvTdHCyJzcD9yU2JO1IbHnMS7F+bMyNOBLUK9U1SyoUXFKtDrxKSub7I5 GlEXp7uyR7P+bpIsQusuJ0usFCR3u804mS7zRxZ0/yh1a04PInpt43sAUEBeRulPcxT6 OYiW7eo7Xas9HzUlTBXJxeA1uZdqXFShzfZT9Mf1dk5kbqIi/iNEPq5GJLF7HLnoTY3O KmVNQFaJL8ipMNVlvU9PEM6xGIo/WhB6r9QK+gG0Sd58O88I7SHXtKHXBdG2N+s3OiYO n2CzBN8WN6EkI9koGz7x4hNDaTbpcbUp8vjEEm4iwCo97C9om+n1KkJ3DNsBx8UPGCrn DZqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=bDRBqyHT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id a187-20020a624dc4000000b006c3212b57aasi7441101pfb.325.2023.11.26.07.55.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 07:55:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=bDRBqyHT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 073F780B19E5; Sun, 26 Nov 2023 07:54:55 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229489AbjKZPyn (ORCPT + 99 others); Sun, 26 Nov 2023 10:54:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230453AbjKZPqk (ORCPT ); Sun, 26 Nov 2023 10:46:40 -0500 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2B521A5 for ; Sun, 26 Nov 2023 07:46:44 -0800 (PST) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a08e4352992so278697566b.1 for ; Sun, 26 Nov 2023 07:46:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1701013603; x=1701618403; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Frvwetq2uP6wtxuP9UX1ctUqElygA7huby/aEqYEpm0=; b=bDRBqyHTyF+fHdoboWSuZZQfp6AcYc1IJ8ii28CCzvKa2krnfgE91PhZCo2OK3ioMV tXy08MhS8+Ds69186bFuAKpBtuk93ANCQDwJ/QtDwUlRKKGH88zXFnnGxQicUOsSnd+F rOungMdmME4OOyHxXtoy5IDaWATP2q/JtCAUY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701013603; x=1701618403; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Frvwetq2uP6wtxuP9UX1ctUqElygA7huby/aEqYEpm0=; b=GxpFrZ99BhggkcZKh3qnV44rlnuQApy0RVg2ctccaXfzjEhcYRSruqCU2wOjVV0mDk t8zHjqTIRsCvm/+BD80kOodft1u8m7INVRFwH9Qd8n9lG66iCAPkGMsDuO8BDkL2of/I romnMjM4HrBw1+6kqzRPTa0y2IpUnkqCKNTBof8gQ1tqiCKNw3ITu156tbXexnYfbdQY zNSl09HSZQGOAZfmDbLsdZQDulRl/iOJtwQTvtkJFOYD7Kg+iu5wHDHGrJOoYcshzT0k MkjWUOzLXe8mH7fqjdsrEOSYXS/hKahjv20DNXunJhhy55IWiceglF2xPfyU2afQSphD ZQFA== X-Gm-Message-State: AOJu0YwSbzCjJZRVLXbRwnhqWWiwQhJ5KrrRG77U7IfFVIJrkBvYF07U QCKEveuwnpIniDC/YMWYil/asXrEUdTzTE2g48BWrg== X-Received: by 2002:a17:906:25e:b0:a0d:35b:89a9 with SMTP id 30-20020a170906025e00b00a0d035b89a9mr1819881ejl.46.1701013603021; Sun, 26 Nov 2023 07:46:43 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-95-244-100-54.retail.telecomitalia.it. [95.244.100.54]) by smtp.gmail.com with ESMTPSA id h24-20020a170906591800b009fdc684a79esm4656158ejq.124.2023.11.26.07.46.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 07:46:41 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , michael@amarulasolutions.com, Dario Binacchi , Andrzej Hajda , Daniel Vetter , David Airlie , Inki Dae , Jagan Teki , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Maarten Lankhorst , Marek Szyprowski , Maxime Ripard , Neil Armstrong , Robert Foss , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v2 03/11] drm: bridge: samsung-dsim: enter display mode in the enable() callback Date: Sun, 26 Nov 2023 16:44:55 +0100 Message-ID: <20231126154605.15767-4-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231126154605.15767-1-dario.binacchi@amarulasolutions.com> References: <20231126154605.15767-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Sun, 26 Nov 2023 07:54:55 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783642561919437582 X-GMAIL-MSGID: 1783642561919437582 The synaptics-r63353 (panel-bridge) can only be configured in command mode. So, samsung-dsim (bridge) must not be in display mode during the prepare()/unprepare() of the panel-bridge. Setting the "pre_enable_prev_first" flag to true allows the prepare() of the panel-bridge to be called between the pre_enabled() and enabled() of the bridge. So, the bridge can enter display mode only in the enabled(). The unprepare() of the panel-bridge is instead called between the disable() and post_disable() of the bridge. So, the disable() must exit the display mode (i .e. enter command mode) to allow the panel-bridge to receive DSI commands. samsung_dsim_atomic_pre_enable -> command mode r63353_panel_prepare -> send DSI commands samsung_dsim_atomic_enable -> enter display mode samsung_dsim_atomic_disable -> exit display mode (command mode) r63353_panel_unprepare -> send DSI commands samsung_dsim_atomic_post_disable Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/gpu/drm/bridge/samsung-dsim.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index be5914caa17d..15bf05b2bbe4 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -1494,7 +1494,6 @@ static void samsung_dsim_atomic_pre_enable(struct drm_bridge *bridge, return; samsung_dsim_set_display_mode(dsi); - samsung_dsim_set_display_enable(dsi, true); } } @@ -1507,6 +1506,7 @@ static void samsung_dsim_atomic_enable(struct drm_bridge *bridge, samsung_dsim_set_display_mode(dsi); samsung_dsim_set_display_enable(dsi, true); } else { + samsung_dsim_set_display_enable(dsi, true); samsung_dsim_set_stop_state(dsi, false); } @@ -1524,6 +1524,8 @@ static void samsung_dsim_atomic_disable(struct drm_bridge *bridge, if (!samsung_dsim_hw_is_exynos(dsi->plat_data->hw_type)) samsung_dsim_set_stop_state(dsi, true); + samsung_dsim_set_display_enable(dsi, false); + dsi->state &= ~DSIM_STATE_VIDOUT_AVAILABLE; } @@ -1532,7 +1534,8 @@ static void samsung_dsim_atomic_post_disable(struct drm_bridge *bridge, { struct samsung_dsim *dsi = bridge_to_dsi(bridge); - samsung_dsim_set_display_enable(dsi, false); + if (!samsung_dsim_hw_is_exynos(dsi->plat_data->hw_type)) + samsung_dsim_set_stop_state(dsi, true); dsi->state &= ~DSIM_STATE_ENABLED; pm_runtime_put_sync(dsi->dev); From patchwork Sun Nov 26 15:44:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 169885 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp2546958vqx; Sun, 26 Nov 2023 07:55:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IGDvkWQ7R8539RZzjfgMiUW75e9MMeicqTEqMYArn20Lr4APNNMp05GDBvOj63cNjWk1AoT X-Received: by 2002:a17:902:f544:b0:1cf:ca7b:8ef3 with SMTP id h4-20020a170902f54400b001cfca7b8ef3mr1273294plf.11.1701014109991; Sun, 26 Nov 2023 07:55:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701014109; cv=none; d=google.com; s=arc-20160816; b=W+UaYoQLe5Q1isFiAEcfClS/gpnW4gG5PPC+zCQrpEULaLtrVOm8hedXUYdxx438eg 9gKAAGpTsCFoHvi5sFT/0ToT7bbxwqshCSNN1EuSEqp3Wa4qVi7XxwxvP3KP8aeuvs4b l3nX0HUXGHmk/N99XSLr+ZSg+Vpouh5ITVxn4Dk39+dXA4EV4zpdECNDJ2jAJQ2kvHbH 650uqz48oP3pquuxYkE9yjsas1mMQEAnvb7GWLdDZySganrr2Pj4HyeHVPBhomkEwr/t lj7Y/tKt4ABoYO5o62a18/QUYVNJ2u6vx47SMz0d9yUE/FAAPUuVTEesFWkgVdIBiUKm SPOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=lH7aqPIDP5zDMXKB9fcIq0eCdhqCYxRoC/nv219ztfM=; fh=m6aHy4GVWeiYcahcFfIzqNn3pzsQZUVlVWbThwuybpU=; b=i8p8KbyWd3r6O1N69yZCp0MTmgXBUp2tZnHAYnCFnI0mGbvEQMOMHC2g49zAeuTtT5 BO8D/lkRiChlC9gmtTCYDb+3zrPethEKl6n0SyoCQSs5V1nafmOfH8fS5pJtmbOuQAid 6nDj4b8XYxeMkak7n4g0bmwgIYnIkW+NVX3zuBld6mcVA3r3jrPm58f3lI7ayjtSA8xU yHNe5eBXpZELtt9ha+LjkxrOKPir+wyd7TEs0viJsuY5aoN0S1syHafX09HvXDOx1aG1 UG7rf0MEzmzSGJRdd0/m9BC6CVcOTKEFzsPmT5a9LS5KFSTU27gSkUu4WDLf5qf8hu+7 7h/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="fxVBJV/L"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id p6-20020a634206000000b005bddee56e49si7747138pga.72.2023.11.26.07.55.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 07:55:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b="fxVBJV/L"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 7770480AC44E; Sun, 26 Nov 2023 07:55:07 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230091AbjKZPyq (ORCPT + 99 others); Sun, 26 Nov 2023 10:54:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231128AbjKZPqm (ORCPT ); Sun, 26 Nov 2023 10:46:42 -0500 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6186D60 for ; Sun, 26 Nov 2023 07:46:47 -0800 (PST) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-a0bdf4eeb46so121768666b.3 for ; Sun, 26 Nov 2023 07:46:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1701013605; x=1701618405; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lH7aqPIDP5zDMXKB9fcIq0eCdhqCYxRoC/nv219ztfM=; b=fxVBJV/LoFEyIVCYKfwtM6n7n2PdpqN1VMuA8ECs0e/yISmIsE+nfzisIPKLc8thxr b/1WA/oHUeGnb/s8IXyZfyhafi5npVH+LX1cq3bNWOjF9v2Pts71EStJDMjz5TIzvq2s xvbsW3ixBzHpzi3szyu10+QJh+WoOy2vly6Jc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701013605; x=1701618405; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lH7aqPIDP5zDMXKB9fcIq0eCdhqCYxRoC/nv219ztfM=; b=fddLPAbNQ+LOkM2g+7Od/1IJZyKIjfw9KX6fPGPZA3tIRUOMGamP21KPHFYSILP0BT nLHPeM4eCjr2LWISaqG+i7IKcmLUNhwaclvhOyXs4TLVWzMGOgv9lv4auIBnMlhaHvJ/ SixuHlAJy/Ptiz31UXRn/5gXby3Wju1n0NkxYDWIv0uz/ZLlg57Y2wBQaYTJpbNVs0ih yC1V51alfXv2O5LUsJ9mGp7FhbBDoZ4o0tTzjwZjHi337OS0c/TIrwsS5dvZmjCwVvIj 805B7CI2UVkG18vBSbntIArBdIw59tPgzU+1EOyIrUeIgp4SPhSW5xvFkX0Zm1DczTJy rUGg== X-Gm-Message-State: AOJu0YyCE3IRrF8cvNbvuGkpP/14xdeWuLBxn2ZFfdNC+bQwGJBU+aDd e8+i7l2hxSZrpttsNH8BMdutQOqkek5h/HBY2WI4qg== X-Received: by 2002:a17:907:d92:b0:a01:de07:5926 with SMTP id go18-20020a1709070d9200b00a01de075926mr7488722ejc.45.1701013605262; Sun, 26 Nov 2023 07:46:45 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-95-244-100-54.retail.telecomitalia.it. [95.244.100.54]) by smtp.gmail.com with ESMTPSA id h24-20020a170906591800b009fdc684a79esm4656158ejq.124.2023.11.26.07.46.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 07:46:44 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , michael@amarulasolutions.com, Dario Binacchi , Andrzej Hajda , Daniel Vetter , David Airlie , Inki Dae , Jagan Teki , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Maarten Lankhorst , Marek Szyprowski , Maxime Ripard , Neil Armstrong , Robert Foss , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v2 04/11] drm: bridge: samsung-dsim: complete the CLKLANE_STOP setting Date: Sun, 26 Nov 2023 16:44:56 +0100 Message-ID: <20231126154605.15767-5-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231126154605.15767-1-dario.binacchi@amarulasolutions.com> References: <20231126154605.15767-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Sun, 26 Nov 2023 07:55:07 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783642571622472248 X-GMAIL-MSGID: 1783642571622472248 The patch completes the setting of CLKLANE_STOP for the imx8mn and imx8mp platforms (i. e. not exynos). Co-developed-by: Michael Trimarchi Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/gpu/drm/bridge/samsung-dsim.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index 15bf05b2bbe4..13f181c99d7e 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -96,6 +96,7 @@ #define DSIM_MFLUSH_VS BIT(29) /* This flag is valid only for exynos3250/3472/5260/5430 */ #define DSIM_CLKLANE_STOP BIT(30) +#define DSIM_NON_CONTINUOUS_CLKLANE BIT(31) /* DSIM_ESCMODE */ #define DSIM_TX_TRIGGER_RST BIT(4) @@ -945,8 +946,12 @@ static int samsung_dsim_init_link(struct samsung_dsim *dsi) * power consumption. */ if (driver_data->has_clklane_stop && - dsi->mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) + dsi->mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) { + if (!samsung_dsim_hw_is_exynos(dsi->plat_data->hw_type)) + reg |= DSIM_NON_CONTINUOUS_CLKLANE; + reg |= DSIM_CLKLANE_STOP; + } samsung_dsim_write(dsi, DSIM_CONFIG_REG, reg); lanes_mask = BIT(dsi->lanes) - 1; From patchwork Sun Nov 26 15:44:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 169877 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp2544071vqx; Sun, 26 Nov 2023 07:47:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IFlqxL3XrYo7frUNf3Sc9zFTadb3w4KzkTe5b87TJ24OFYxgupym0ltKJlye1e+AoRmz3rC X-Received: by 2002:a17:90b:4c09:b0:280:a68d:7a35 with SMTP id na9-20020a17090b4c0900b00280a68d7a35mr6916073pjb.22.1701013669902; Sun, 26 Nov 2023 07:47:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701013669; cv=none; d=google.com; s=arc-20160816; b=mENdU+l7czRpRvcFddH6YMuQcENV06KS3Lg3s8kaNPsx5VdGrD/6dKx/AkI8R7+jyM HNp6rikBxRZvkXVepIVDLod2DrsNjECj78BSrscfcZQybpi5612FpS8ysRh8f3hKaFaF OyxHyur40kSCaztohG3WtiwNwD1szq1uLxvm+0eGl5kJW4j38D0/6vxm3WBZHnUOSVnI MaLWxmQs0xe9VbRIi+GsvRkXVfZBu1GyStY7vAroKcOK/eNVcsOewJauL2dfFkfCgTYk 0Iwn1n5StAD41pACk8anGkEOsTHwFHb3UdC67ZCRbYqE28eDO+ODf5twa5ZOdQRM7SHB fzCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=3VVKgh/q76onEx9kq6IcN/9X/7jTKpjDPPOIb4Iciwc=; fh=rMUSeLjxyqS7ImFw5qehWtEuci36kDflDWRo++pMzKs=; b=KB0SVfcwotQ5B00rF0TJUQYp0PV659Kv0jBSOpF+VH1UErYsDwZRk4sN6iuaXbp43i mVFkQuOPZUAOL2xUVWHiwrM4dTQmL0u/sTrxvhYw9DgFpHjUX3yooy4q/UQ93vkECbM2 bZR97SEmysFPpfNYI2QQ0Ih6G/q6ABL4IuHIKP5/DcBcXiI20woCvJgxXTJd+M9FwRDF tpc8Pp+N53+INwNr7wXoLV4QFiastzINUPHON6nPVMVGUsOWgD1vaKAf4EAPDKmcS8D8 FJ+UxS90FyK8LCbL2vdy4JYiueflzc8/VyZVE9AnAHw62lBK1o0zj6XPzpj8bPHVp2dj hCfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=UepSTK1z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id j6-20020a17090a94c600b00276b87c8b8esi7993282pjw.59.2023.11.26.07.47.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 07:47:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=UepSTK1z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 7B7C18080D78; Sun, 26 Nov 2023 07:47:36 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232237AbjKZPrZ (ORCPT + 99 others); Sun, 26 Nov 2023 10:47:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231445AbjKZPrP (ORCPT ); Sun, 26 Nov 2023 10:47:15 -0500 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEC4010F0 for ; Sun, 26 Nov 2023 07:46:49 -0800 (PST) Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-5441305cbd1so4502572a12.2 for ; Sun, 26 Nov 2023 07:46:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1701013608; x=1701618408; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3VVKgh/q76onEx9kq6IcN/9X/7jTKpjDPPOIb4Iciwc=; b=UepSTK1zs+5LYf509oDVTGDD+yct0nfEF0d2l//fkvyyZPFHvs3AkZIY0XYxEFWIg2 aV3MjUxpM6Hh2TI2GtyuNxZXLzpjdIhsAxMYFL7u8yr219LZvPXRmstXK9NUm6rIiJh7 C9IWp3ogoFsuK+JEpQ8WHuh+GebfOuM/lfFjs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701013608; x=1701618408; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3VVKgh/q76onEx9kq6IcN/9X/7jTKpjDPPOIb4Iciwc=; b=tCYkXq2le9yetsg1G7JoIyeRQFmwEU83T7ojq5NvX7BfF+wkBb6Q23eoC/P7Ha55AF 2lOmvWwIv/ae5fd//l9xfU4be41cpOcCVsd3wPwbQh6L/S7oJAoguhAPKpNu3d8swXWg 2UIIljZYxlqLqdSOYgWtUD8nwNsFMXT07t12zL7Zq/V4/XFmA5DhtL0qSScDKx7TYRK0 t8GPCAeTIUo3xNK5hCAD+lRkhqQTSjsmx68ezfW897VvPDanzZdh7pCWuRCuWyI7g56C TifUJoERCOBcclgGZrUHy37O6q35s2MS9ijd0EIAvvSJrU4z0GOgMVRVZ5XImZ7QCAoz tl3w== X-Gm-Message-State: AOJu0YyRiqeDs97Y/a5mkhEyobobMw/zm/RlOJRKfOdGWDJ2pjPVsTKl EyzlaaKEqDxRKya3A9loquSjOs1HCJiyurKivYD7jA== X-Received: by 2002:a17:906:d210:b0:a03:d8ea:a269 with SMTP id w16-20020a170906d21000b00a03d8eaa269mr6106273ejz.11.1701013607789; Sun, 26 Nov 2023 07:46:47 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-95-244-100-54.retail.telecomitalia.it. [95.244.100.54]) by smtp.gmail.com with ESMTPSA id h24-20020a170906591800b009fdc684a79esm4656158ejq.124.2023.11.26.07.46.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 07:46:47 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , michael@amarulasolutions.com, Dario Binacchi , Conor Dooley , Daniel Vetter , David Airlie , Jessica Zhang , Krzysztof Kozlowski , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Rob Herring , Sam Ravnborg , Thomas Zimmermann , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH v2 05/11] dt-bindings: display: panel: Add synaptics r63353 panel controller Date: Sun, 26 Nov 2023 16:44:57 +0100 Message-ID: <20231126154605.15767-6-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231126154605.15767-1-dario.binacchi@amarulasolutions.com> References: <20231126154605.15767-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Sun, 26 Nov 2023 07:47:36 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783642109802002087 X-GMAIL-MSGID: 1783642109802002087 From: Michael Trimarchi Add documentation for "synaptics,r63353" panel. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi Reviewed-by: Krzysztof Kozlowski --- Changes in v2: - Add $ref to panel-common.yaml - Drop port, reset-gpios, and backlight - Set port and backlight ad required - Replace additionalProperties with unevaluatedProperties .../display/panel/synaptics,r63353.yaml | 61 +++++++++++++++++++ 1 file changed, 61 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/synaptics,r63353.yaml diff --git a/Documentation/devicetree/bindings/display/panel/synaptics,r63353.yaml b/Documentation/devicetree/bindings/display/panel/synaptics,r63353.yaml new file mode 100644 index 000000000000..590db3719eb2 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/synaptics,r63353.yaml @@ -0,0 +1,61 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/synaptics,r63353.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Synaptics R63353 based MIPI-DSI panels + +maintainers: + - Michael Trimarchi + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + items: + - enum: + - sharp,ls068b3sx02 + - const: synaptics,r63353 + + avdd-supply: true + dvdd-supply: true + reg: true + +required: + - compatible + - avdd-supply + - dvdd-supply + - reg + - reset-gpios + - port + - backlight + +unevaluatedProperties: false + +examples: + - | + #include + + dsi { + #address-cells = <1>; + #size-cells = <0>; + + panel@0 { + compatible = "sharp,ls068b3sx02", "synaptics,r63353"; + reg = <0>; + avdd-supply = <&avdd_display>; + dvdd-supply = <&dvdd_display>; + reset-gpios = <&r_pio 0 5 GPIO_ACTIVE_LOW>; /* PL05 */ + backlight = <&backlight>; + + port { + panel_in: endpoint { + remote-endpoint = <&mipi_dsi_out>; + }; + }; + }; + }; + +... From patchwork Sun Nov 26 15:44:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 169878 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp2544138vqx; Sun, 26 Nov 2023 07:47:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IHnFYdr9lADCcd7osrY/dLVSimvZtpXitQBsB8bQHD0UkzkCe4IhrwECwgyHJ9F0gW6n3xu X-Received: by 2002:a05:6808:2090:b0:3b8:5c57:6a77 with SMTP id s16-20020a056808209000b003b85c576a77mr7563744oiw.26.1701013679594; Sun, 26 Nov 2023 07:47:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701013679; cv=none; d=google.com; s=arc-20160816; b=uXUNCXFnh7VkI8Fg8fHy35AkQak9edoWWB59KSXuGpMJrLxNi686Z9T3c/HmhFcFo3 lsMZLuyxXMEZLfTQDer9a6krgZnmmklGDlmN1091h+Hxhw5JoIsmrHsdAeE5jZw8dKiv QIcBSoHATWctOtktKk3WasYTYRup6PPsnsu2qV6MHoxJRTjqsok3qPWQe/cY74j/WdVg Hf/MJ8/h7GFZ4XZVPqFurgDTyp7rXZEUBunL65HinKSCggpdC97Uf9rI9qj34XKutEP1 hG1q6onTojz3B5sJd7sf6vymocuHv/1cFRBghoC/23CFY6KtdZK8WYLfeGqHeS1FQBWO 4pFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cIMMz8wLJivOaa5nAUHEwRejpQ5B3CKhmLwaInr1cws=; fh=YMCpMfj2GNScjLvWYsHyWUGLqrAoIyNb9XBc8eC5U/M=; b=T80ACggnVjoEDks7qq3gK1AUTHbGhvtJBhEy9HZPbM3/UPwIrWk0N8/6+wv17BteD6 sOAju010HqB9pkFWfcdtJqiWy70DP7cLNuqeVKfcQNZhN0xJqBaKiQBpVARziJuSYawv 3PsjEXoHnEhQ+IWdZNcBlbm8LPTcvbjr18s3uwsfVsfaDlbUBzk1PfoKaJBAX3DRC79z JU9+UM729vD1nLgAd06qlv6erLXivK8rJgD8mV9To3JSjMIUj5jH5Qvs1B7uLA1BlqUV 6hLs5HkuxMwt1zVsqFrojP95+rX8loguuQn38PW/jmgpyi6AknYy6ETYn530uCaitz62 9TPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=IkttUpP5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id g14-20020a63200e000000b005b21d089aa7si8162366pgg.788.2023.11.26.07.47.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 07:47:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=IkttUpP5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 5F20580A5B4C; Sun, 26 Nov 2023 07:47:55 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232322AbjKZPr3 (ORCPT + 99 others); Sun, 26 Nov 2023 10:47:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231899AbjKZPrR (ORCPT ); Sun, 26 Nov 2023 10:47:17 -0500 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D59AD1733 for ; Sun, 26 Nov 2023 07:46:51 -0800 (PST) Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-507a0907896so4476030e87.2 for ; Sun, 26 Nov 2023 07:46:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1701013610; x=1701618410; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cIMMz8wLJivOaa5nAUHEwRejpQ5B3CKhmLwaInr1cws=; b=IkttUpP5VgzE4LFaiMXZZwYM0PS1wHGfZbMCnEzgSrn5N1YK/iyU/fWD+C/uST9a2F /E5n8eyxaH6j9cE5b7x7yNc8ODbDxUESEvR+n92oulRTMPPnFTzZq9MSgJfaIvTjtRw0 OUGWhsEDfC+meESVfYDXrYgMCLbkh4DkdbXxU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701013610; x=1701618410; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cIMMz8wLJivOaa5nAUHEwRejpQ5B3CKhmLwaInr1cws=; b=tCO/1NQ3w/OA+cA9gZ0awNRCRYTDrX0KDx16JjgoId3fq6aI3ekPnKZXbGzwbI8NdF E36JSF9JwvW5OJHbSCTKgsjtyzYDE5f0QsZRi2YbM2B75TB1m9yCCkaI83G6MLrGw2+C jziwFfDQ1QD0ccKobVngabyKSoUOPHrJ5q+AoYfXdGK7expchimpONhU+SyORKbDGiy/ Zqv/JlMvuUQYjzSJ+HeUMtD27WRJuZdKotHlH7lWzTi+JyTCTYJo/Av4tTlhQHOlZ9eu +wPxQy1HX5oQYVLNGoCWmcssQrMSI34LSLFTsBGejLOBeqI46KbvAF32yg1VrC28Khqg MlJw== X-Gm-Message-State: AOJu0Yy3AbCumcG2LhbbPkuuHQ9ZjwTVN5kOQwM3akbpzBrDNqPnx2ug j04cct29E4ebjqCrUXJsMQqXBiRg3xhp/v69vkg6+w== X-Received: by 2002:ac2:4424:0:b0:509:e5a3:ef49 with SMTP id w4-20020ac24424000000b00509e5a3ef49mr6156178lfl.18.1701013609648; Sun, 26 Nov 2023 07:46:49 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-95-244-100-54.retail.telecomitalia.it. [95.244.100.54]) by smtp.gmail.com with ESMTPSA id h24-20020a170906591800b009fdc684a79esm4656158ejq.124.2023.11.26.07.46.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 07:46:49 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Amarula patchwork , michael@amarulasolutions.com, Dario Binacchi , Daniel Vetter , David Airlie , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Sam Ravnborg , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v2 06/11] drm/panel: Add Synaptics R63353 panel driver Date: Sun, 26 Nov 2023 16:44:58 +0100 Message-ID: <20231126154605.15767-7-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231126154605.15767-1-dario.binacchi@amarulasolutions.com> References: <20231126154605.15767-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Sun, 26 Nov 2023 07:47:55 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783642119590492799 X-GMAIL-MSGID: 1783642119590492799 From: Michael Trimarchi The LS068B3SX02 panel is based on the Synaptics R63353 Controller. Add a driver for it. Signed-off-by: Michael Trimarchi Signed-off-by: Dario Binacchi --- Changes in v2: - Adjust the timings of the panel reset MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + .../gpu/drm/panel/panel-synaptics-r63353.c | 375 ++++++++++++++++++ 4 files changed, 391 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-synaptics-r63353.c diff --git a/MAINTAINERS b/MAINTAINERS index 509281e9e169..ab6985806793 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6875,6 +6875,12 @@ T: git git://anongit.freedesktop.org/drm/drm-misc F: Documentation/devicetree/bindings/display/ste,mcde.yaml F: drivers/gpu/drm/mcde/ +DRM DRIVER FOR SYNAPTICS R63353 PANELS +M: Michael Trimarchi +S: Maintained +F: Documentation/devicetree/bindings/display/panel/synaptics,r63353.yaml +F: drivers/gpu/drm/panel/panel-synaptics-r63353.c + DRM DRIVER FOR TI DLPC3433 MIPI DSI TO DMD BRIDGE M: Jagan Teki S: Maintained diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 99e14dc212ec..d018702be3dc 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -735,6 +735,15 @@ config DRM_PANEL_SITRONIX_ST7789V Say Y here if you want to enable support for the Sitronix ST7789V controller for 240x320 LCD panels +config DRM_PANEL_SYNAPTICS_R63353 + tristate "Synaptics R63353-based panels" + depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE + help + Say Y if you want to enable support for panels based on the + Synaptics R63353 controller. + config DRM_PANEL_SONY_ACX565AKM tristate "Sony ACX565AKM panel" depends on GPIOLIB && OF && SPI diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index d10c3de51c6d..f267d932c2b5 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -74,6 +74,7 @@ obj-$(CONFIG_DRM_PANEL_SHARP_LS060T1SX01) += panel-sharp-ls060t1sx01.o obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7701) += panel-sitronix-st7701.o obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7703) += panel-sitronix-st7703.o obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7789V) += panel-sitronix-st7789v.o +obj-$(CONFIG_DRM_PANEL_SYNAPTICS_R63353) += panel-synaptics-r63353.o obj-$(CONFIG_DRM_PANEL_SONY_ACX565AKM) += panel-sony-acx565akm.o obj-$(CONFIG_DRM_PANEL_SONY_TD4353_JDI) += panel-sony-td4353-jdi.o obj-$(CONFIG_DRM_PANEL_SONY_TULIP_TRULY_NT35521) += panel-sony-tulip-truly-nt35521.o diff --git a/drivers/gpu/drm/panel/panel-synaptics-r63353.c b/drivers/gpu/drm/panel/panel-synaptics-r63353.c new file mode 100644 index 000000000000..d45373de7c9f --- /dev/null +++ b/drivers/gpu/drm/panel/panel-synaptics-r63353.c @@ -0,0 +1,375 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Synaptics R63353 Controller driver + * + * Copyright (C) 2020 BSH Hausgerate GmbH + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include + +#include +#include +#include + +#include