From patchwork Fri Nov 24 18:49:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tommaso Merciai X-Patchwork-Id: 169544 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp1452159vqx; Fri, 24 Nov 2023 10:49:31 -0800 (PST) X-Google-Smtp-Source: AGHT+IG9+y+Nfry4u9SIgiQwFsLr8uSeeNbjZqaPnYCFL/uCY6cXMThnVlxW6KIyHvT9Lx6vAwar X-Received: by 2002:a05:6a00:a0c:b0:6bd:f224:c79e with SMTP id p12-20020a056a000a0c00b006bdf224c79emr3835729pfh.11.1700851771291; Fri, 24 Nov 2023 10:49:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700851771; cv=none; d=google.com; s=arc-20160816; b=VJDeQmaEalQfOmrMDcfJHEL3MUkPg6aGV2WuLXAz3o3Y5/kmJKCWl9SWUFeawx7vZC 1BGTfDSD/pTYe2m9LXa4gl8QOBj7QkyyfgG92hSzXDlsPtIYEUAoVPGZJ2Yztk5TvUmX RGXtHCS1QhmfesEidtN3mWkjjYH5dJEpE9uQwVgK5+K4UvHGH+EaUy3Wy+i+GGnbPpZ5 uvnEUgyjN1I2TxNvs2WMXBBbnX9B3cedgugpFLEzQKT4S+1iPnHej9VeMcGYy7U3DCuu ee2c7hglXHCwahY/Z5dzitDCRhsa2ti8D7zfFDP8TCxX0cGJn+y+rKk+x+P6UJuzVBJW 6//A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from:dkim-signature; bh=iFy/9Swy0nVL292Sr+H5OQDTykZcfrct9MdwEGt+ZX8=; fh=fPlKTAqP8S0vDW+ffNLrI1yUMrYC8X9lLmyZFDd1Dzs=; b=hbEcYpUH7T0bzp3oPLAA2Or4l95KkWGh3BhICAMmmOG2sl8bJdG+IU0iNN9Ic/c4YL i2K3vN2HF0x37xI5aHBYGL7+b2Ak/uyjvlYUxlSzOM2WI5JuEaHOZ1BOzjKqqYh5e/Mg YQXgQiRccaOXg6jfMgA+1FAaNBkwoG7WwYeH+v8KfcDv09UwG7bTKNHzdZjUr9xRo+Gf PlC8AtWzns+UzfQgg5zR67som+yEoUSh/4RIYUtSTNuq5YFYwp67NnCeQpn5kzDO/STA v2GnLdnQaGvxABtrhm22pMIgw3Z6wSfSCfvVp6tyduRjqnIo3x+tc7wtG0Dv6xJHkChV wSVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20230601 header.b=ek20PJmB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id l12-20020a056a00140c00b006cbb132d46dsi4024439pfu.244.2023.11.24.10.49.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 10:49:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20230601 header.b=ek20PJmB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 2AF1680BD272; Fri, 24 Nov 2023 10:49:30 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345916AbjKXStR (ORCPT + 99 others); Fri, 24 Nov 2023 13:49:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345865AbjKXStM (ORCPT ); Fri, 24 Nov 2023 13:49:12 -0500 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B72A1BCE; Fri, 24 Nov 2023 10:49:18 -0800 (PST) Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-548a2c20f50so3062059a12.1; Fri, 24 Nov 2023 10:49:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700851757; x=1701456557; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=iFy/9Swy0nVL292Sr+H5OQDTykZcfrct9MdwEGt+ZX8=; b=ek20PJmBhPDFhu9z/MpOV1Vaq2zIt8YMe+dq1kTrPHPIfsFVlJ68mh+oWQxRCiV6Ee GIgFZbZ3RGAMvtKBrVsB+YlwiK98G7xg/hTf5DuBTwcMbzXUR6idljJELhbPZj1ztS45 D+FkPgbXRDtMER3F09Ox83AQhsvzpRJBs2MiOLfRU92TOUSJQ3XO0nkBns6ztGUv7Zbr TlO0sTHHd/52puU2sEM949r0esqKYqvU+25Su1Q8B5GKoiXWu/olNtw+RtOvXHcbyzhH srzddvLQ/TvRCgWWqarYOYCPxbmYJ+P9x6fs/NIjvUqMUTDIG6hz6Q4r1VEsLaBldMVa Zw8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700851757; x=1701456557; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iFy/9Swy0nVL292Sr+H5OQDTykZcfrct9MdwEGt+ZX8=; b=qQH2nAvkQROzX8O6DvFJK4Pk1gdis1TN9pli78mKN8yAv6oQ4I9eIzucoAw/bUb0sw 4fJfu/jj3EtPPZljTVqjwNcCbXCiy6TIHCQitn2i8BLj8T3XAFbfMZzyPveRMRbQPuZw g6yxSy4iBf7/h2dnQDbGJvkXnUbOQDNo0gl43kY29j9+utQMO0oIiJXslW3l1gvN15VR 9crsxuUWz2UbJWY2aYv860ptMYwI6M8ElDtYJhdIhLoJ4frqOgY1a0Tjx2gYrVjKYHs4 TpV1/9R1BqljGcxm4r8O22JjB1eAStRbHgk3lkTsHzrtAW6vVQOXlQWij+mi+sA35bjd r1Hg== X-Gm-Message-State: AOJu0YzxEzCEMy8OWe3ZZl82wcVQzKifxguegDZT4MeUFd1iL4EJ428X /2wUeid0wdTswXNtOlNXEeBX+4dg9WI= X-Received: by 2002:a17:907:3ac2:b0:9c7:5a14:ecf2 with SMTP id fi2-20020a1709073ac200b009c75a14ecf2mr2498318ejc.56.1700851756476; Fri, 24 Nov 2023 10:49:16 -0800 (PST) Received: from tom-HP-ZBook-Fury-15-G7-Mobile-Workstation.station (net-2-39-142-131.cust.vodafonedsl.it. [2.39.142.131]) by smtp.gmail.com with ESMTPSA id e8-20020a170906080800b009fdc15b5304sm2385388ejd.102.2023.11.24.10.49.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 10:49:16 -0800 (PST) From: Tommaso Merciai Cc: linuxfancy@googlegroups.com, laurent.pinchart@ideasonboard.com, Tommaso Merciai , Sakari Ailus , Steve Longerbeam , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: ov5640: add missing v4l2_subdev_init_finalize Date: Fri, 24 Nov 2023 19:49:13 +0100 Message-Id: <20231124184913.2574925-1-tomm.merciai@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 24 Nov 2023 10:49:30 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783472346517769436 X-GMAIL-MSGID: 1783472346517769436 After the ov5640 configurations steps let's add v4l2_subdev_init_finalize that finalizes the initialization of the subdevice. References: - https://linuxtv.org/downloads/v4l-dvb-apis/driver-api/v4l2-subdev.html Signed-off-by: Tommaso Merciai --- drivers/media/i2c/ov5640.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c index 3f79a3b77044..338eea802ab8 100644 --- a/drivers/media/i2c/ov5640.c +++ b/drivers/media/i2c/ov5640.c @@ -3924,6 +3924,12 @@ static int ov5640_probe(struct i2c_client *client) if (ret) goto entity_cleanup; + ret = v4l2_subdev_init_finalize(&sensor->sd); + if (ret < 0) { + dev_err(dev, "subdev init error: %d\n", ret); + goto entity_cleanup; + } + ret = ov5640_sensor_resume(dev); if (ret) { dev_err(dev, "failed to power on\n");