From patchwork Thu Nov 10 01:22:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yan Zhao X-Patchwork-Id: 17899 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp668313wru; Wed, 9 Nov 2022 17:48:45 -0800 (PST) X-Google-Smtp-Source: AMsMyM7pdzOi3pD2opLpy/utsOy+YmfFmOjW5YFmTblnhu7IdA+rkLcmJd0wYhTa3p65iobVsSys X-Received: by 2002:a17:902:f68d:b0:187:282d:6d25 with SMTP id l13-20020a170902f68d00b00187282d6d25mr52714739plg.98.1668044924956; Wed, 09 Nov 2022 17:48:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668044924; cv=none; d=google.com; s=arc-20160816; b=bGNqtHOt9CxNktCX0DLgySEXUvYKesckMlvHrqcThmSsIa9Fl2Z/3aPmd3F1F8HvCi u9YqyO7w/xeUB6bikBURDxEcwxwNoeOS/l33tiHNtbNa3n9Tjh3M0iuXrZbMk7ESoRVw vEqSYFdkH1RoCIiUdJhdP5wl9dH+SY+lQ4mH/qEh4gBgngIa/XxGA4+jTMPdGieLcy0f yQukxbAzurcqLUFxB2nOVwJ0GudKL/b4LEiLdY8OTuyk6j5mla+NngdrfikzVRqo+M7+ WqURzIPMpenvSx9vvaAGnwlvluxVX3GP0OulwjgiTYzVdH/fc1wdHcvBIb/qGcDXpqc1 Vb8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=c2xEU/IDLavJDaYkJMDSFQwFlbDV+jeVNSiTmDsCrpc=; b=z3lfP9x/XeK+/f0YF6RV8g/DY6Q/fGPZysA8EsIOyunsoPIS0Tn6G4Nh4hsxMR5N+y SI+sEBR9EjxewphOqyNqXHCjIqKLwLr1qnMi0lxwKX1TdmQXkiNnBIk3uwUZjoFTtk43 FtIcQSgGNkQLFYg8XOaMSCttoliNsxteZcCypqgTUY2O+VHaPXJHH8bDo2uXJhoZRLtN PxVIyXFpr90GAm6jsFL77EGwy46BHvj7ozfxYBj33LKB5sYdz2XHQRK/T5E1muobL9qz FumMJRrL3gWfLEL4dSaWn5Ti+5ATjWlW6Dk87vIKHL8ka1KSWV90hjFRjkky/P/CvE/X g1yQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="O/qmz2G+"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d35-20020a631d63000000b004704522f653si19186213pgm.66.2022.11.09.17.48.32; Wed, 09 Nov 2022 17:48:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="O/qmz2G+"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232226AbiKJBpX (ORCPT + 99 others); Wed, 9 Nov 2022 20:45:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232168AbiKJBpO (ORCPT ); Wed, 9 Nov 2022 20:45:14 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF6A928E27; Wed, 9 Nov 2022 17:45:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668044713; x=1699580713; h=from:to:cc:subject:date:message-id; bh=Yu7AhOcppEOEMu7RqmcY9BM0Dgnu0f+ahhlPn/ItzqA=; b=O/qmz2G+XLSAahxrybAYwFXgPqp+syXXP+/wD81V42JZL5UQASzHiYMY IEzVdK5Ez0QMeWEqkLNZp00IxgM0eKe0PS0sTT7GEZhguhjmaWCzU5LYM 8k11rUv3Mp34r35s9fd05pzdJ7QVg5jHl3HWU7krvLE62WhGV8B0GzrD6 hJXOf/tfc8vZmBv5X9y8oI2x7xMpdRImGu+ssfbtW8w8Tu2HLdpLNhvMV 9JOECregw6r0Y4SqgpLM3mMIAi6o+TZONmAn4RcCH1595x9V1/eY01Z0i kiQ+rA+e0gpAdo42RX+IUEeWhracNMQz6js4E/MDUR/YDAqi1ZBSEtJ56 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10526"; a="312305678" X-IronPort-AV: E=Sophos;i="5.96,152,1665471600"; d="scan'208";a="312305678" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2022 17:44:56 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10526"; a="882158088" X-IronPort-AV: E=Sophos;i="5.96,152,1665471600"; d="scan'208";a="882158088" Received: from yzhao56-desk.sh.intel.com ([10.238.200.254]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2022 17:44:55 -0800 From: Yan Zhao To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: pbonzini@redhat.com, seanjc@google.com, Yan Zhao Subject: [PATCH] KVM: do not prepare new memslot for KVM_MR_DELETE Date: Thu, 10 Nov 2022 09:22:04 +0800 Message-Id: <20221110012204.3919-1-yan.y.zhao@intel.com> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749071875697067584?= X-GMAIL-MSGID: =?utf-8?q?1749071875697067584?= kvm_prepare_memory_region() is not useful for KVM_MR_DELETE, and each kvm_arch_prepare_memory_region() does nothing more than returning 0 for KVM_MR_DELETE. So, just don't call into kvm_prepare_memory_region() to avoid unnecessary error handling for KVM_MR_DELETE. Signed-off-by: Yan Zhao --- virt/kvm/kvm_main.c | 52 ++++++++++++++++++++++----------------------- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 25d7872b29c1..44e7fb1c376b 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -1612,19 +1612,17 @@ static int kvm_prepare_memory_region(struct kvm *kvm, * new and KVM isn't using a ring buffer, allocate and initialize a * new bitmap. */ - if (change != KVM_MR_DELETE) { - if (!(new->flags & KVM_MEM_LOG_DIRTY_PAGES)) - new->dirty_bitmap = NULL; - else if (old && old->dirty_bitmap) - new->dirty_bitmap = old->dirty_bitmap; - else if (!kvm->dirty_ring_size) { - r = kvm_alloc_dirty_bitmap(new); - if (r) - return r; + if (!(new->flags & KVM_MEM_LOG_DIRTY_PAGES)) + new->dirty_bitmap = NULL; + else if (old && old->dirty_bitmap) + new->dirty_bitmap = old->dirty_bitmap; + else if (!kvm->dirty_ring_size) { + r = kvm_alloc_dirty_bitmap(new); + if (r) + return r; - if (kvm_dirty_log_manual_protect_and_init_set(kvm)) - bitmap_set(new->dirty_bitmap, 0, new->npages); - } + if (kvm_dirty_log_manual_protect_and_init_set(kvm)) + bitmap_set(new->dirty_bitmap, 0, new->npages); } r = kvm_arch_prepare_memory_region(kvm, old, new, change); @@ -1849,21 +1847,23 @@ static int kvm_set_memslot(struct kvm *kvm, kvm_invalidate_memslot(kvm, old, invalid_slot); } - r = kvm_prepare_memory_region(kvm, old, new, change); - if (r) { - /* - * For DELETE/MOVE, revert the above INVALID change. No - * modifications required since the original slot was preserved - * in the inactive slots. Changing the active memslots also - * release slots_arch_lock. - */ - if (change == KVM_MR_DELETE || change == KVM_MR_MOVE) { - kvm_activate_memslot(kvm, invalid_slot, old); - kfree(invalid_slot); - } else { - mutex_unlock(&kvm->slots_arch_lock); + if (change != KVM_MR_DELETE) { + r = kvm_prepare_memory_region(kvm, old, new, change); + if (r) { + /* + * For MOVE, revert the above INVALID change. No + * modifications required since the original slot was preserved + * in the inactive slots. Changing the active memslots also + * release slots_arch_lock. + */ + if (change == KVM_MR_MOVE) { + kvm_activate_memslot(kvm, invalid_slot, old); + kfree(invalid_slot); + } else { + mutex_unlock(&kvm->slots_arch_lock); + } + return r; } - return r; } /*