From patchwork Fri Nov 24 09:03:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 169310 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp1018160vqx; Fri, 24 Nov 2023 01:03:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IFghR/aoeFNqVnVDqzPuFwhKwkf2RLBpKWf+KFeJUKcEwlQNvbRsfIuruLDFAh3EDmqTnJv X-Received: by 2002:a05:6808:1246:b0:3b2:e25d:9768 with SMTP id o6-20020a056808124600b003b2e25d9768mr2280041oiv.53.1700816627613; Fri, 24 Nov 2023 01:03:47 -0800 (PST) ARC-Seal: i=3; a=rsa-sha256; t=1700816627; cv=pass; d=google.com; s=arc-20160816; b=ioGgjThb0gBVjUFB+9QAeekORS1ao9bL8FIo8AteWDtQX2cfw07o0qIzPBvHGzliyj XFkUcyORo9YuZ34jvilnlPL3FVAyOcgKupjuzXyYqKyfT7UYW9saIcFYvxWFuipPCv/w VVT3+gzodjuOdnkeEvb9a5a+VRvX+SX/hRAP64zmBdEsLPFIWHFlvEcFHCIL2dhe80yW nmD5G4/JyR8oyStf63ir3ZZDdcdZPyyAwqRIjyRxpfKQ0fHLREXghx2o2Kq3lM9tMbTJ P84bKqdO2iuwbNyTuczZZnhs4T7wrlnLKL3V8+V1K41mLFhk9DTvZ9hEh0DSHmG5vlmp hhzg== ARC-Message-Signature: i=3; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version :content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:date:message-id :dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=W6gI19wzPsy41sy4+PVmnvhUJtJ8ONUTxnW/gbnYpyA=; fh=8WW8/k0o0G2vlJiZAQKLzwZ5FShsw2CjyMds4OH6804=; b=ipCiDO3j8ngmBUZX7rBeaT0gwhFWLHfHN29Qfgzz77aqN1KafjFzP8Q1af31NQxSoH FYimH20+uaTyV9BMW3lgyd/XomHcP0KaCgZwxAGEdlEd1hMagxaY0NB8G5JWKG7jjslr vEqsewgPmy4gzi06FHvFciP4NTc91H4pfd+/o8CBQEzUJhCIq0+6aJKhBjRm85pnIO6N osU98arqQQPDUziYgTIuRESpeOKu4mekELkz0RR8dGuPLFDUKSm/NZLbM4eQJ/luXHlr iF9KUOU3JWbqjxCKyJpmpdelRMn33K6opERDFiOl2/mEp4781EwOG39U983XbxSb9kmD mFfg== ARC-Authentication-Results: i=3; mx.google.com; dkim=pass header.i=@suse.com header.s=selector1 header.b=rtIzU79m; arc=pass (i=2); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id pz7-20020a05620a640700b007789262de78si2924194qkn.539.2023.11.24.01.03.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 01:03:47 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=selector1 header.b=rtIzU79m; arc=pass (i=2); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 17FFF385C414 for ; Fri, 24 Nov 2023 09:03:38 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2068.outbound.protection.outlook.com [40.107.105.68]) by sourceware.org (Postfix) with ESMTPS id D863A385DC03 for ; Fri, 24 Nov 2023 09:03:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D863A385DC03 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D863A385DC03 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.105.68 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700816613; cv=pass; b=EBDRvdw1d5grsa9x10xLyniYV8ltYOre18d22vb9ulDJ1vd+TGkBlJbDpaiYCIKoRS5j72wE9tDBUFYqOxP3DK0gBCdV9lqjYap01CTjF1ot7/rSBn+fn22ySTKzvzVgHouUbvmjG+AIIT07tJg5CPohvKIkbCHyFWm+Pf+jcqs= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700816613; c=relaxed/simple; bh=NnZ3rO6A7uWfmexUMjXFcPtvjJkZNqzQ6RiuT8eY0pY=; h=DKIM-Signature:Message-ID:Date:Subject:From:To:MIME-Version; b=cL2XUij+XDgz267cuwniAwirebaLYvZm57CfqMpA+/YDvSUrvl/INT9LzPRycISR8fHbiCKkED2tLCgcEdbPIiON8T0b4xZawHrkf1lp8+IjlOwT3uN9peG7YjQAHHDo7elDVYsk2Cv0byP0rfCnb1q91i18sNO0w11kwMhECrY= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XTzIsLs+xoUcY4WE21Ls6p/0YaqNL+qZHgcdIlmAjL1QZ33N/z1PXXxKyKR8OhtRD1+WZDPD8utwM8B/t22NWcBH1S3ze+leEzn3L8T0a4KJhQ+aYSPRjnZtjLynFa9kJrY/kIVBjNLSZAWMgteJSys0aE2NNax8rZ9gyRU9E/4lS18UMjCz+xjVRZu0b8wQVNQ9fANNr8mznJeHY1GPoKVWbe4ntU1pfHOlM8m5tfXWazAVzRU74LcmJJ0c1hkIXFMg1/5Y7DZp6y4kXiiNofCB7LsYYtI75sJp6uNaa8GPVeL2f67QT9XVkg5CoXHF87BFKXHRwMZqnwh3hHFULw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W6gI19wzPsy41sy4+PVmnvhUJtJ8ONUTxnW/gbnYpyA=; b=ByR6Rg+Q/d9tlB1BaD3G1CN/pKvWuENcNIGAeFR3Ici+BHhTZTmycbTWfq9kmecUdnZ2U9JtmPwJuWlSFR5tySWU6QkYUWscraUDE8CcSU+/qVKDXBY+07wuDc4lOCBBqofD6P73r+hFkoUD158/M1syPUPDu25Tte2KrRWjC+fhxQdzU8P+YVCYRy9WEYBKnDRaEIz0FnMCccoPtvOIemNX4xv/m3srUHUMYRGO2f2oG8SGoUm7j9ZMlyTC0+JgW1AENGMP35wYtnTO+1q12s+y/mLn5Hj1KN+CjHpnetClwJ79yFg+L6DtOLrHQ4A7REpGGetnOvHTeUTFA7ECYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W6gI19wzPsy41sy4+PVmnvhUJtJ8ONUTxnW/gbnYpyA=; b=rtIzU79mJwH2BuJZ4wNF34Qx81z7iqJIEKEnZtkbl8pAYVQdk6HdySz9UGnuWW/zHRtvNRwSIqU9NF0savdqkvwemkQekJQpho/3iuuzpH+mbkPBQz38fN3OB8vU0iQNj5ne9LeqslvsI9vAzTt18QFerQCEHMMGWFlnpCotee9onBN62aRSHzdtQdHWL52GBBffRygk64mIV4+vXAyT8KzvQIDPeM9WwwDJp8sjPgOkkdCzaRsxSXIT8qFOwX1fWUlyG8CwgyTIPtqqXcnz+RNkPo+DWPzmvS3/WQG+vcLF09e5EqGTzfLLT3QIl/dAMqgn3UVHqT9wcEzuQKDiKg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB9PR04MB8090.eurprd04.prod.outlook.com (2603:10a6:10:240::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.13; Fri, 24 Nov 2023 09:03:27 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44%3]) with mapi id 15.20.7046.012; Fri, 24 Nov 2023 09:03:27 +0000 Message-ID: <94626e2b-0e73-4267-9c80-cb25e1dbab9b@suse.com> Date: Fri, 24 Nov 2023 10:03:26 +0100 User-Agent: Mozilla Thunderbird Subject: [PATCH 1/6] x86: last-insn recording should be per-section Content-Language: en-US From: Jan Beulich To: Binutils Cc: "H.J. Lu" References: Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: X-ClientProxiedBy: FR5P281CA0033.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f3::10) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB9PR04MB8090:EE_ X-MS-Office365-Filtering-Correlation-Id: 11177b89-5a1d-4884-8267-08dbeccc38d5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wqIpm3f2rWPu3JVEeqCCZ/Jrm8REV4UV2HTTNtaRETbHa+8f932i2Rz6gdZrYONLUAmyH42TULTnh+pjGDSntVpzTW8XtWJEQtGpZwrCiRApZHfaVoA4cMRag4wgft113vPpyae8rjDreOOkKbIjRdIDeixx7IVMtls88x6Vg5B0GdrP4FSbz/5DrQsxX1+GpbpNpuqZ7ge29aVulHJopduAdkPhdpk7cSnKSdtF/pQpwNm4b1nsX3BkSjtsJbFM4BIUWDKNWf7VUwWMj83/7KgT3jmofZj+fec/pylrVFBgXL2BuyiNN+xZfvqxNtu4rMr2Zzik2xJ4xQRGXkFUsO/1EbSOn2pMnYPc3oJP9O0L6hj3NRiWBueNPBVSrMrXxYfQwrDlTUevV6wKVBjaA319PLzqAlVLYf7u6U5MLvVm+Oj4Q9TRsF74ySTLbIapNUCjGNvsubkeeDKpUtrsnHOfUA+zdpdBPrIqgj18wjY0CjNfSSTmIrCGwAoKL89jx8ZAMhjRVEA+owNS/CgWFaKgM2FHl28EQBuphedPDWvXXsXikxFhqu/pydFB/6qiKBTLi9PIVnERKS/0BfqSOJfFcbqsXMGSRBb2BJCrUTfagyawVScdVa5Zo6imHEHpO5h1Gh0TFoV3QLdrTjAA9FYWredIsxdHUb/ynFiCVGyzRP6zw9QO+p0ux7AyyqgQ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8790.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(376002)(39860400002)(346002)(366004)(230273577357003)(230173577357003)(230922051799003)(186009)(451199024)(64100799003)(1800799012)(41300700001)(30864003)(2906002)(5660300002)(6486002)(8936002)(31686004)(8676002)(4326008)(478600001)(6506007)(36756003)(6512007)(26005)(2616005)(83380400001)(86362001)(31696002)(66556008)(316002)(66476007)(66946007)(6916009)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?pGxlwRcfUKoK9kPDzNW/bciBXgD+?= =?utf-8?q?vAx/bz2kILJQ8U89GEZcCAfrBc2g6Xk5JBM00trg9HHq+8chdV45vY5EcBMmsFh1d?= =?utf-8?q?Xqi0k0Q/d+Gtp4CkBWDuS8pMg8A0ASJ3ROfmxKS0TwZqp9XI2NXmiQtXXJDPGKmuf?= =?utf-8?q?QFj63Yfp3IfrUV6zyB/4T0vOZxDN2DC6Wg0Boxvl2k813yV8o1m2nZQ074nHLGLB0?= =?utf-8?q?wpp7leCcJZ6LLCq3kd6QVrxQliDAHJ6tqpSD46NaO4GXnxGx9exnXTUx6EVCtuhLT?= =?utf-8?q?c2UF9LF9NJ73e+SfICsx5l8gX/zYLHT975XqlscwqcoEG1BXsQIwgS5kux7eEIkiu?= =?utf-8?q?cCUHjCfuYfJOsEVXlIq8Gnu0KPdIyhnIrStHUcoG/BDcTv1gJTAflIncfHkMUyMtr?= =?utf-8?q?3xlMwzjstA8MLALdog2atukqrw0lEY7UumT3HvB5g1GJzSrs1f4dedezGxV0XkAf2?= =?utf-8?q?wGbzMfZ6UXb014GBRMjBKu8Bz15VSaMapJ2zmv/1+j7skR9EXQkLYSbgQ0K9fbIU2?= =?utf-8?q?dyUGGsMEMQTbIYvfxh46V8yyLpHU9shj/6gWCs2hdgo7wYEDMTJ5RZSFq5q36DW5L?= =?utf-8?q?ECP4MKgQdt75d9xS34GrWhnpT/cdRRN9clCRpuQUA6dZlIoG7u2azmxxI/fsTq0tu?= =?utf-8?q?eY/FQQCdYftTRj/49KaTE/1BxkQEdzj+8Oen6WwGZ5e+7wKecAvGRufxaABAN8z8E?= =?utf-8?q?ledB+8d3/ogv0eUufjXw+RY6lqy3yOHcTIgm4lc/wra0ObKsRlZ1A31llQneN1yIr?= =?utf-8?q?ktaH7lOfSzcoMnZ43F4glL5EAT/1c6EgGkIP/a+QwBrKFm+hIMiv3Okd3HKK0zd9V?= =?utf-8?q?/Q/+uW4YYPKLDbu3mKM8WUhTET+jRj/5ioQotS4DI5/YtWfIRW+4T1HKYDlnnhLLX?= =?utf-8?q?4hGcYfaUhn56J/lruQpKCciSQhADnhAWQGcE8VZ4YjzIMDXsUhT4Vfi6V66g0MTgp?= =?utf-8?q?0w+3GM7pTN9ImR7TCJtQ7QmbJ7ed6kao2o6fqIr7QVy2v7S2BgKzPVy17ur8ctQlH?= =?utf-8?q?GymbEy0sylTHIxGq72my6G7BwjxZkxO/vYhf9k2tVJ9sXPVi0wc4PYxe54Dz0J97n?= =?utf-8?q?/tNPFAgj7zIvLMOtcqBtgNJUrSWjbX5eUi9wYqz/tqgZIw8P5RGtWXFSw0NGywYfV?= =?utf-8?q?6ZbvMnBf9S72Bx2Mpu9LKMg4jsGcfIy0e4bQhvX0w8LvqtkktcwfUyTMNcCad6G4J?= =?utf-8?q?yk1KLcIN2fz3+US289SUNvpkJiz4g+eXNDfirvghtb3QKxt9rlVmRRVJfc7Qtyqo0?= =?utf-8?q?H3vRVfkOfkjxwtaVroayDRtxguL6dsx2K5uUTjFf9WkXbK0vUMu/3oxI3L3JPqdfy?= =?utf-8?q?WieTSjwN/kfBKyDlgstC89d4Kx0VkwgJDLRPbwdk+7oJNrui75vWhAvPS8zcZ7gcV?= =?utf-8?q?zMInI7cBD+wAiGT2gLmk9gyUVRPEXHjN5r1/sSVkCNGrmAvWz3ZxHoWJth5mHYX1i?= =?utf-8?q?LiNCYWnxJr+z+TPiz2Wcgxn3SMpFbuKCwZLojZfTbGfiPCxhCi4S2ScbuFcRqCHom?= =?utf-8?q?QGFaGLf3XHfB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 11177b89-5a1d-4884-8267-08dbeccc38d5 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2023 09:03:27.5104 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9LCYzQQqXz3tEKf1AO0YYzw8HlCKUdUWhUE85TxB2V2BRpzpk6lvlL7evyl3ouYsz++k7srtTimockFYIpipqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8090 X-Spam-Status: No, score=-3026.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783435496128239355 X-GMAIL-MSGID: 1783435496128239355 Otherwise intermediate section switches result in inconsistent behavior. Note, however, that intermediate sub-section switches will continue to result in inconsistent or even inappropriate behavior. While there also add recording of state to s_insn(). --- i386_cons_align() qualifying the recording on SEC_CODE seems suspicious, too: md_assemble() isn't constrained to emitting instructions to only text sections. For sub-sections the best I can think of that we could do is warn when now_subseg is nonzero wherever we already warn based on last_insn state (and similarly bail rather than inserting any code). That would have not really intended effects in subsequent patches, though: We'd then generally suppress optimizations outside of subseg 0, and we'd also prefix plain old NOPs there (in i386_generate_nops()). For .insn I'm not entirely decided: We might also assume that only proper insns are constructed this way, and hence record last_insn_other in s_insn(). --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -178,7 +178,7 @@ static int check_word_reg (void); static int finalize_imm (void); static int process_operands (void); static const reg_entry *build_modrm_byte (void); -static void output_insn (void); +static void output_insn (const struct last_insn *); static void output_imm (fragS *, offsetT); static void output_disp (fragS *, offsetT); #ifndef I386COFF @@ -677,21 +677,6 @@ static enum lfence_before_ret_kind } lfence_before_ret; -/* Types of previous instruction is .byte or prefix. */ -static struct - { - segT seg; - const char *file; - const char *name; - unsigned int line; - enum last_insn_kind - { - last_insn_other = 0, - last_insn_directive, - last_insn_prefix - } kind; - } last_insn; - /* 1 if the assembler should generate relax relocations. */ static int generate_relax_relocations @@ -4971,7 +4956,7 @@ insert_lfence_after (void) /* Output lfence, 0xfaee8, before instruction. */ static void -insert_lfence_before (void) +insert_lfence_before (const struct last_insn *last_insn) { char *p; @@ -5007,12 +4992,11 @@ insert_lfence_before (void) else return; - if (last_insn.kind != last_insn_other - && last_insn.seg == now_seg) + if (last_insn->kind != last_insn_other) { - as_warn_where (last_insn.file, last_insn.line, + as_warn_where (last_insn->file, last_insn->line, _("`%s` skips -mlfence-before-indirect-branch on `%s`"), - last_insn.name, insn_name (&i.tm)); + last_insn->name, insn_name (&i.tm)); return; } @@ -5027,12 +5011,11 @@ insert_lfence_before (void) if (lfence_before_ret != lfence_before_ret_none && (i.tm.base_opcode | 1) == 0xc3) { - if (last_insn.kind != last_insn_other - && last_insn.seg == now_seg) + if (last_insn->kind != last_insn_other) { - as_warn_where (last_insn.file, last_insn.line, + as_warn_where (last_insn->file, last_insn->line, _("`%s` skips -mlfence-before-ret on `%s`"), - last_insn.name, insn_name (&i.tm)); + last_insn->name, insn_name (&i.tm)); return; } @@ -5129,6 +5112,8 @@ md_assemble (char *line) const char *end, *pass1_mnem = NULL; enum i386_error pass1_err = 0; const insn_template *t; + struct last_insn *last_insn + = &seg_info(now_seg)->tc_segment_info_data.last_insn; /* Initialize globals. */ current_templates.end = current_templates.start = NULL; @@ -5682,23 +5667,21 @@ md_assemble (char *line) if (i.rex != 0) add_prefix (REX_OPCODE | i.rex); - insert_lfence_before (); + insert_lfence_before (last_insn); /* We are ready to output the insn. */ - output_insn (); + output_insn (last_insn); insert_lfence_after (); - last_insn.seg = now_seg; - if (i.tm.opcode_modifier.isprefix) { - last_insn.kind = last_insn_prefix; - last_insn.name = insn_name (&i.tm); - last_insn.file = as_where (&last_insn.line); + last_insn->kind = last_insn_prefix; + last_insn->name = insn_name (&i.tm); + last_insn->file = as_where (&last_insn->line); } else - last_insn.kind = last_insn_other; + last_insn->kind = last_insn_other; } /* The Q suffix is generally valid only in 64-bit mode, with very few @@ -9667,7 +9650,8 @@ maybe_fused_with_jcc_p (enum mf_cmp_kind /* Return 1 if a FUSED_JCC_PADDING frag should be generated. */ static int -add_fused_jcc_padding_frag_p (enum mf_cmp_kind* mf_cmp_p) +add_fused_jcc_padding_frag_p (enum mf_cmp_kind *mf_cmp_p, + const struct last_insn *last_insn) { /* NB: Don't work with COND_JUMP86 without i386. */ if (!align_branch_power @@ -9678,13 +9662,12 @@ add_fused_jcc_padding_frag_p (enum mf_cm if (maybe_fused_with_jcc_p (mf_cmp_p)) { - if (last_insn.kind == last_insn_other - || last_insn.seg != now_seg) + if (last_insn->kind == last_insn_other) return 1; if (flag_debug) - as_warn_where (last_insn.file, last_insn.line, + as_warn_where (last_insn->file, last_insn->line, _("`%s` skips -malign-branch-boundary on `%s`"), - last_insn.name, insn_name (&i.tm)); + last_insn->name, insn_name (&i.tm)); } return 0; @@ -9693,7 +9676,7 @@ add_fused_jcc_padding_frag_p (enum mf_cm /* Return 1 if a BRANCH_PREFIX frag should be generated. */ static int -add_branch_prefix_frag_p (void) +add_branch_prefix_frag_p (const struct last_insn *last_insn) { /* NB: Don't work with COND_JUMP86 without i386. Don't add prefix to PadLock instructions since they include prefixes in opcode. */ @@ -9709,14 +9692,13 @@ add_branch_prefix_frag_p (void) if (!i.operands || i.tm.opcode_modifier.isprefix) return 0; - if (last_insn.kind == last_insn_other - || last_insn.seg != now_seg) + if (last_insn->kind == last_insn_other) return 1; if (flag_debug) - as_warn_where (last_insn.file, last_insn.line, + as_warn_where (last_insn->file, last_insn->line, _("`%s` skips -malign-branch-boundary on `%s`"), - last_insn.name, insn_name (&i.tm)); + last_insn->name, insn_name (&i.tm)); return 0; } @@ -9725,7 +9707,8 @@ add_branch_prefix_frag_p (void) static int add_branch_padding_frag_p (enum align_branch_kind *branch_p, - enum mf_jcc_kind *mf_jcc_p) + enum mf_jcc_kind *mf_jcc_p, + const struct last_insn *last_insn) { int add_padding; @@ -9799,13 +9782,12 @@ add_branch_padding_frag_p (enum align_br } if (add_padding - && last_insn.kind != last_insn_other - && last_insn.seg == now_seg) + && last_insn->kind != last_insn_other) { if (flag_debug) - as_warn_where (last_insn.file, last_insn.line, + as_warn_where (last_insn->file, last_insn->line, _("`%s` skips -malign-branch-boundary on `%s`"), - last_insn.name, insn_name (&i.tm)); + last_insn->name, insn_name (&i.tm)); return 0; } @@ -9813,7 +9795,7 @@ add_branch_padding_frag_p (enum align_br } static void -output_insn (void) +output_insn (const struct last_insn *last_insn) { fragS *insn_start_frag; offsetT insn_start_off; @@ -9943,7 +9925,7 @@ output_insn (void) insn_start_frag = frag_now; insn_start_off = frag_now_fix (); - if (add_branch_padding_frag_p (&branch, &mf_jcc)) + if (add_branch_padding_frag_p (&branch, &mf_jcc, last_insn)) { char *p; /* Branch can be 8 bytes. Leave some room for prefixes. */ @@ -10029,7 +10011,7 @@ output_insn (void) if (branch) /* Skip if this is a branch. */ ; - else if (add_fused_jcc_padding_frag_p (&mf_cmp)) + else if (add_fused_jcc_padding_frag_p (&mf_cmp, last_insn)) { /* Make room for padding. */ frag_grow (MAX_FUSED_JCC_PADDING_SIZE); @@ -10045,7 +10027,7 @@ output_insn (void) fragP->tc_frag_data.branch_type = align_branch_fused; fragP->tc_frag_data.max_bytes = MAX_FUSED_JCC_PADDING_SIZE; } - else if (add_branch_prefix_frag_p ()) + else if (add_branch_prefix_frag_p (last_insn)) { unsigned int max_prefix_size = align_branch_prefix_size; @@ -10948,6 +10930,7 @@ s_insn (int dummy ATTRIBUTE_UNUSED) unsigned int j; valueT val; bool vex = false, xop = false, evex = false; + struct last_insn *last_insn; init_globals (); @@ -11701,7 +11684,11 @@ s_insn (int dummy ATTRIBUTE_UNUSED) else if (i.rex != 0) add_prefix (REX_OPCODE | i.rex); - output_insn (); + last_insn = &seg_info(now_seg)->tc_segment_info_data.last_insn; + output_insn (last_insn); + last_insn->kind = last_insn_directive; + last_insn->name = ".insn directive"; + last_insn->file = as_where (&last_insn->line); done: *saved_ilp = saved_char; @@ -15496,13 +15483,15 @@ s_bss (int ignore ATTRIBUTE_UNUSED) void i386_cons_align (int ignore ATTRIBUTE_UNUSED) { - if (last_insn.kind != last_insn_directive + struct last_insn *last_insn + = &seg_info(now_seg)->tc_segment_info_data.last_insn; + + if (last_insn->kind != last_insn_directive && (bfd_section_flags (now_seg) & SEC_CODE)) { - last_insn.seg = now_seg; - last_insn.kind = last_insn_directive; - last_insn.name = "constant directive"; - last_insn.file = as_where (&last_insn.line); + last_insn->kind = last_insn_directive; + last_insn->name = "constant directive"; + last_insn->file = as_where (&last_insn->line); if (lfence_before_ret != lfence_before_ret_none) { if (lfence_before_indirect_branch != lfence_branch_none) --- a/gas/config/tc-i386.h +++ b/gas/config/tc-i386.h @@ -281,6 +281,23 @@ extern enum i386_flag_code { CODE_64BIT } i386_flag_code; +struct i386_segment_info { + /* Type of previous "instruction", e.g. .byte or stand-alone prefix. */ + struct last_insn { + const char *file; + const char *name; + unsigned int line; + enum last_insn_kind + { + last_insn_other = 0, + last_insn_directive, + last_insn_prefix + } kind; + } last_insn; +}; + +#define TC_SEGMENT_INFO_TYPE struct i386_segment_info + struct i386_tc_frag_data { union --- /dev/null +++ b/gas/testsuite/gas/i386/lfence-section.d @@ -0,0 +1,19 @@ +#as: -mlfence-before-indirect-branch=all +#warning_output: lfence-section.e +#objdump: -dw +#name: -mlfence-before-indirect-branch=all w/ section switches + +.*: +file format .* + + +Disassembly of section .text: + +0+ <_start>: + +[a-f0-9]+: f3 ff d0 repz call \*%eax + +[a-f0-9]+: f3 c3 repz ret + +[a-f0-9]+: cc int3 + +[a-f0-9]+: cc int3 + +[a-f0-9]+: cc int3 + +Disassembly of section \.text2: +#pass --- /dev/null +++ b/gas/testsuite/gas/i386/lfence-section.e @@ -0,0 +1,3 @@ +.*: Assembler messages: +.*:3: Warning: `rep` skips -mlfence-before-indirect-branch on `call` +.*:11: Warning: `rep` skips -mlfence-before-ret on `ret` --- /dev/null +++ b/gas/testsuite/gas/i386/lfence-section.s @@ -0,0 +1,19 @@ + .text +_start: + rep + + .section .text2, "ax" +aux1: + nop + + .text + call *%eax + rep + + .section .text2, "ax" +aux2: + nop + + .text + ret + .p2align 2, 0xcc --- a/gas/testsuite/gas/i386/i386.exp +++ b/gas/testsuite/gas/i386/i386.exp @@ -642,6 +642,17 @@ if [gas_32_check] then { run_dump_test "lfence-ret-c" run_dump_test "lfence-ret-d" run_dump_test "lfence-byte" + # This test uses the .section directive, which only ELF and COFF/PE support. + if {[is_elf_format] + || [istarget "*-*-vxworks*"] + || [istarget "*-*-coff*"] + || [istarget "*-*-pe*"] + || [istarget "*-*-cygwin*"] + || [istarget "*-*-mingw*"] + } then { + run_dump_test "lfence-section" + } + run_dump_test "branch" # These tests require support for 8 and 16 bit relocs, From patchwork Fri Nov 24 09:03:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 169311 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp1018399vqx; Fri, 24 Nov 2023 01:04:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IEqTlqVATdWHOmSNDurYc2oMU9qZmsn1mX0tu7ttCukOBBqSBiNCVWnODkc9U+l46zifadf X-Received: by 2002:a05:620a:3c13:b0:77b:c974:5d0 with SMTP id tn19-20020a05620a3c1300b0077bc97405d0mr1603771qkn.55.1700816647216; Fri, 24 Nov 2023 01:04:07 -0800 (PST) ARC-Seal: i=3; a=rsa-sha256; t=1700816647; cv=pass; d=google.com; s=arc-20160816; b=rq3san5ORyKDCZ9QK30sdkdTIlMYYGDAb/ZXPAeZ5vCPuJd73JBr+Lf0Ys7iHxmOOF jBtSCthTtRl9bBWabJeg5FOtRTN+G1Wh11QIRRa1FTjYgyztbVvSF4yvEDRgm5Fr6rHB NDEttJzkJAW/QwTE3lzebu3hG0l6xJK9aDn1Nlipv/6tBuznKl9U6M6pauJagQM4FH4i JB/B4iPbwl189fYgbEetXITns4ARYgz+dI6GmGFOhdUMksZlVnGFSBrc9od+KYpSJfEu SOxZ0GJZtngLATFLUPrZXUMC/WkiRDDuO2XNX9f8XIpJO9YXH5Ol6zV+sAo1uemER0fD lQdw== ARC-Message-Signature: i=3; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version :content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:date:message-id :dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=3ut9Bb3f4tNwSgU5wM5kxm+ZK+iT+cEPI+tJJKMDLZE=; fh=8WW8/k0o0G2vlJiZAQKLzwZ5FShsw2CjyMds4OH6804=; b=Oq1eK2g18T9JiwFIW6H3EjOhICM5Ksy8yRBFwvyE6CfHdAWsBXxD2UoW/vwkQ1KrU4 W8+m3gUl2kCKtRz/pg90D7qHcSROl5mjwE1KgMS4NUct0Q2vG/qvNLETDOWpwZZNBweB 1/93POyOrxWVu0MtzKnoC9xvXMWuS/KFq2JIFrNrhkfdQWKEz+AIfDte4bUH19gJK8NV Z4+QzekMlROY6z0DE3NTHInoX41ePOkropglZN5v210CHypZfU4HjmXZO4auK5cnmjLQ 4xLGFwJe458K2V9YSriJ+zx5B2+PUi+xqRLPj65XgLiVuL4/F7baDFusG/sYuDmoDrlu jDSg== ARC-Authentication-Results: i=3; mx.google.com; dkim=pass header.i=@suse.com header.s=selector1 header.b=hROyehyg; arc=pass (i=2); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id rj5-20020a05620a8fc500b0077d58e69edfsi2607150qkn.233.2023.11.24.01.04.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 01:04:07 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=selector1 header.b=hROyehyg; arc=pass (i=2); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 90D053861865 for ; Fri, 24 Nov 2023 09:03:58 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2065.outbound.protection.outlook.com [40.107.105.65]) by sourceware.org (Postfix) with ESMTPS id AECE83853337 for ; Fri, 24 Nov 2023 09:03:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AECE83853337 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AECE83853337 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.105.65 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700816633; cv=pass; b=E/wB2htYfzkM158u8D3PHuHChGn9QG29IB/6GBGcgSYj1E1xIyBjGSu7185/IZ7/TgnxiB9VfjinuYTl8J9ZLtFXUAMJKZIkN6tEKZHr8FkbPSDfYKPL6RGRPVsjH+7LubMk210qJXoOeHd/fps9rBtkHCyryXW9GKMJFlF1vx4= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700816633; c=relaxed/simple; bh=FdcaDMrGzhEf5CubmEprAIcZdol+6ogKIWkoQqcRI/8=; h=DKIM-Signature:Message-ID:Date:Subject:From:To:MIME-Version; b=b1fQ6+97sMBj6dZHIvk3EHLKP8awmgxw+ZBAykywQArYFP8ygoWAjwhtzhLFtoy9Z9Fs4MyYWJFSnFDY0UcFyoBWRNEbo5iRTfuQ6lCm/L6Zww3jkls0FJob9LUH8ROpfd3vj1FEjOSf9GoYnuNgKAo+s6beyVM5WXr4FrIPd04= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VVA8QgkQx1vThrMFuCci1who1y8rTSvZoF8dwMDYrkjRey+Y6rB/hf7WMQ290MiEwabMDjHkgCKvri85RIC1AjdbS68vQ4raTg9NxRt7+dsgkJbVwna9MUwlHIzAiQMXrgHmMoJR0uWxwMlzh5GTBdj0615EkNrDlZ+lxXBhrkfqFdxrFnVgwXruduenTd5gZ10hTyWZxcbKvSwFP9z1Cx/W+tPnvCiGtxavc85me+dSAQfU3o2WRlzFJiuVNGblxvyWjBtLzW5Z09wVHO+cw7IGpHFwUqVoDOjE9CHUQau6+WdU+pEJ0OWPQaCf9v5G/cgapG8Pu4Z9GNlFSSv+mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3ut9Bb3f4tNwSgU5wM5kxm+ZK+iT+cEPI+tJJKMDLZE=; b=fGzBqyHup9lBtCu6nRZtvLWHniv5SMEc1wXCWSUzffhKyQtmOogn+p/CboakaYavEtEiP+tbUoEM/OaEksYkWIJp53KxNXBt60H/gIDiNjyfUTqe34W4Z2jCRvC/zI7qj+Ng6msweyTf9CErFiJGdLFEr/z1E+1VUFNMn09L6VchZi93R7rTNGVr33hvFChOmmkefghOnh1HRRFz2spWvOrmeOAtpRkeB8+Ue/W6ZTYQ8EL7yCHP9wEFvEz05E/jrCVoHS2MHdzOHbSGmOV4XQ31eW/+jXNX8oLPAaPe2un0hJJmNtCMqHyujj8YP0n8qmmMecrSU9mg+qOtEJAXEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3ut9Bb3f4tNwSgU5wM5kxm+ZK+iT+cEPI+tJJKMDLZE=; b=hROyehyg7bKJn7tKyS6ieW2qYc+w2j4w6nNUZnpfcjEmZGe/X4d8vFfGeMK7wnyhglBD2NMnpydaqdXjXwRyrH+g0mV3ShNV1OYFJGkdGsWKP692JzerDt0y+5jXgsQ6NPJmTP80p0QaB44tJtKzREl2xGSyE54SU8AYcmrHMt3d347JE/8Sz0TrN/bwaIbjs+PVXxRjlZ81wF1AUkXXtYvvp/4i6jgjrS+5h7MMffJfvarA3LEFlXuMeenVw0SMa/dtwTmPWsz0FlwllCeRh6VpgskooH9CQq6jhvVCcqwSV+6/oIL/OzqnaBSeYiL12vei0+d9LT4Zj3F0mXMtMg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB9PR04MB8090.eurprd04.prod.outlook.com (2603:10a6:10:240::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.13; Fri, 24 Nov 2023 09:03:50 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44%3]) with mapi id 15.20.7046.012; Fri, 24 Nov 2023 09:03:50 +0000 Message-ID: <1cfe196e-4830-49f2-b06c-9c947c4996b5@suse.com> Date: Fri, 24 Nov 2023 10:03:50 +0100 User-Agent: Mozilla Thunderbird Subject: [PATCH 2/6] x86: suppress optimization after potential non-insn Content-Language: en-US From: Jan Beulich To: Binutils Cc: "H.J. Lu" References: Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: X-ClientProxiedBy: FR5P281CA0033.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f3::10) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB9PR04MB8090:EE_ X-MS-Office365-Filtering-Correlation-Id: 8b63e945-43b6-4ecf-690c-08dbeccc4699 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7rDaKw1wHXo+qumjNkR+eh/YJCMw78iJNgoSpoRw8DhXykGx6OAwFgsmsBCWQ6XSkiNbPDz0mY0soZoMiA8JVBgOiS6n0q0tzduoT4QhBHtfPq6b2FrESdHaVbHcejrOi70Mu6pLLQbwkNOksaRN5KqDeD2NesiXWjPLT0shtu0O9ZO3xAU6oC0XI3UmrhvY1jFriXH3MUDJm1M4Zb9Vze70vYbfTr5D2CAEvcS7k0whLFBgZv0lcADc+poft/+h7SjTfk4a5SeCjs9g6TcROQj06QmUUpeXhmIcizJyYuood1e88xuYWXZtVXGEoY3mrgjQv84G5t6/ze7k94e5CGuXANAjhfMUcGEY9+JF26o0Nw8mpU5ZZacGvfQzHLIzF+SNjS/LIxMfNAYSR8uJV27t373rtxjF6XDL2drEhlBlmzGGa5utQEU8seXysLue9/Usv/j3TO6/aNQlLh3pB1jfh8PapwG4Wn/nwKe0/t9LgGNpajLfa1yfB2qsotfMeSZ3SST9iKRA8cZ3SDLdEz/+yumBixWJA1MMws9o1nRmtbZJA73CPDG0op5ijYA4fFwGglyzo1nHF46aii/AzKA8eknaO+pqY+HO3jTK85nVELjLkmUPr5Jq03BwMwk7xLI/GC82UGjZWP58JQ8qTw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8790.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(136003)(376002)(39860400002)(346002)(366004)(230922051799003)(186009)(451199024)(64100799003)(1800799012)(41300700001)(2906002)(5660300002)(4744005)(6486002)(8936002)(31686004)(8676002)(4326008)(478600001)(6506007)(36756003)(6512007)(26005)(2616005)(86362001)(31696002)(66556008)(316002)(66476007)(66946007)(6916009)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?g6+DYpH9O6PpC8d+dgdGvlQD039y?= =?utf-8?q?gD8v2QEKEMa3/YGldkyt6fVP1EuXjhRp2Df8rLYGww+ulfjVYLlDq00vVqraXQ4cD?= =?utf-8?q?EUKDVSa/Wz4lgzYkr+XR76Rq6zdKM1rvqm5aydGMZfW36IYl9fVvMnUWKYqUPCvpg?= =?utf-8?q?dIjriC05n+iDTly3GLrbhJsuhet2QGLkvXlOpvcAVUoiHElh2fg28drlP05bCWY4l?= =?utf-8?q?zLvszn1+muJf+66jR/VM7OTrMMVhTkdxcwTtx04JP5ZGvUOkU18HoLnjn5pwdyoXg?= =?utf-8?q?9mCWpSVDj1ebboMLjOuRz6MzTSfQD0ao8GmnjtUl9vR7j7pKP8t9LlfxIifYGImtZ?= =?utf-8?q?kj/HszrTKj/boje3RsRxFQe6LcYzUkuVz595AnBl0aql9jsf0lskr+9JUG9UH0/qz?= =?utf-8?q?Ys23c+naVlJLRNG65HRQwuY++qJc16Ef+GtTWO7Mq9XIRh1EFk4JVkjRo2of0k85X?= =?utf-8?q?E1yBkq8DfltNCLyAXwhTBATcrMqb2ViF2to9M67XK2Mi4ZOdO43y1otuVpMA0tAl1?= =?utf-8?q?CXsgL9b4EYIyYZfJbs8CSo2z52pppWZv6M7wiYkrjXWnlHekpHOudZAscukyQwr/D?= =?utf-8?q?Q9U3wcN9CzBmFyOK9ib/E3d+TGCX9QC+ZGdRiRFqexuM1sfO23lVDOH0ncGR34U3l?= =?utf-8?q?1zG+oJWzrsyTlop/fZ8uabKfVic1oL8LLsm6rDs8bPGT0FK2whu+uGiLnM7rd8OZe?= =?utf-8?q?3SQphJrF0RnVOrkuvhVWZlQOxZBES3R7UCcQLqixk50bsrXL6J5z46KkM7i3om559?= =?utf-8?q?TN2sJ10dS8rcGbx/U+k4GFszSv+aMCOLQhF6dNhcQ8ZdOC5XNfawx0S/TfdQeBxGG?= =?utf-8?q?fC0hUUucP6xJ4J4tf+7pUwbUCb4/ETBhHH9RAnW+cauPtcb+ZAiNtPe1cXHYW3HdQ?= =?utf-8?q?CzveS+nC6BVaRsZUctj6ARAksOt4Sqohw+XyDsKm0MOnc0AD1nPZss1JY7rFCOiOB?= =?utf-8?q?6vpBGOzWWF4DPqqYlIXOPsjB9OSmeVcqaZ8hfNJMgNteayK7vpzxILkjogCGepsKP?= =?utf-8?q?N/D4L3ptA2BzLKUO/lpNWG1bBB26GU4Yl/ywLm1XsgTcv2CPZGWdYDkv0PjQtQz+h?= =?utf-8?q?nBKMuSljamrngbRAZXGEdHbX+1r8aNpNygIRuTPbXNbGrawkPYoTZsepSd/Zqm+eP?= =?utf-8?q?/ognLfMK2WQbtHbpTqT2Fh8J4c2FKygG3BO1D2Cxp0iHLk3eIBbJzNAKxALNg7wA6?= =?utf-8?q?ceGBJza9kA2pPMV/Ow4vweH3dY4al3x3ran7pUGsGV6fIXzVA9guuScfNjFbi5W4U?= =?utf-8?q?xMwXtmkh998pyjfJ4pRMnS9A4TvJDd4N0GpGWgllTzHYFRwvd1awryUBwB+j2ehIU?= =?utf-8?q?sTeJcUBoVLqXMFVvRoboZlyWtLHdpWWw8AZ44hsk94TSvIQVXmS1zDmtzIRiwi3zl?= =?utf-8?q?40T7HydHpoIcOeu95iWkjmN869o7DKOvIxiyeVF5luf8ZY1iJTKqZPC7gDTeb1MzB?= =?utf-8?q?NGOmIgOAAVYW/sHalaKhrR2XIaHnJvwOHg1iuD6+BfmG4Jtzj7s3JNwAQGfQgbAn8?= =?utf-8?q?k25n3wxy5qSw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b63e945-43b6-4ecf-690c-08dbeccc4699 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2023 09:03:50.6342 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jgfvhT8PggLncKZxrAw1ydu6YF6Nt1SxRs1PlpPC1CM6F+4JN4QnJdu3VitSfiItLBNRgnCq2W6g6h0VFUkwKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8090 X-Spam-Status: No, score=-3026.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783435516712111428 X-GMAIL-MSGID: 1783435516712111428 Just like avoiding to do other transformations potentially affected by stand-alone prefixes or direct data emission, also avoid optimization on the following insn. --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -5120,6 +5120,11 @@ md_assemble (char *line) retry: init_globals (); + /* Suppress optimization when the last thing we saw may not have been + a proper instruction (e.g. a stand-alone prefix or .byte). */ + if (last_insn->kind != last_insn_other) + i.no_optimize = true; + /* First parse an instruction mnemonic & call i386_operand for the operands. We assume that the scrubber has arranged it so that line[0] is the valid start of a (possibly prefixed) mnemonic. */ From patchwork Fri Nov 24 09:04:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 169312 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp1018771vqx; Fri, 24 Nov 2023 01:04:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IFzmmLeRGHvN5vvwj0PvSg6aLkdosNvpl19TyEm0xeM56FVqQslh3E1/0u/XZNhQ0mSdG4I X-Received: by 2002:ac8:58cc:0:b0:423:9512:4bab with SMTP id u12-20020ac858cc000000b0042395124babmr2747732qta.23.1700816679296; Fri, 24 Nov 2023 01:04:39 -0800 (PST) ARC-Seal: i=3; a=rsa-sha256; t=1700816679; cv=pass; d=google.com; s=arc-20160816; b=TX0m+jQ5MZyEmYsIts+H4Lxm8xXJY0xaHACkjh+N07kb7y7mLMX2IjyIK5Mk3Mt4r5 4VSbdZlPi5JAqIP0vegrZ3EsPm8zhGu4Qjaze55dU/vJRGYJwSDrLglyfzcXE5st+pXJ Mq2Xo/Eafk+8I/K3vjEBgrXN5ZBAujqB19qdDdsV7pLCqyXlzkqliIb52OYiLZWPKgw6 GN1RmxJw5+lIfZPoTJCzLyqavoLCGPUgpWi3RAZUsy4sIiBqXmaWDgn2u8dTR15GMkNJ fmXD1hQAxlvoJ9itz9yhC60HHnknd22LYetmMe4VKtvKTZlnxcTkKY9mi+egyqj3bW2J yyfw== ARC-Message-Signature: i=3; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version :content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:date:message-id :dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=/fjh4uYEsXN5eJRAxw/lS1RbaMC3a2M3urGkY+tVwmw=; fh=NphB2tBEqYSq+sQBy2n61cOzxowltn29nyeuQg2WRtw=; b=wFm61D/AdToEchjivXlRuiH41z7O8RP0d3ZeNkZ2UloyRsS03kJEaEscRbEAcg3m7V 2hLGuPqQHUCGNXnrjpNsalMAdHc7E6TS++QVUlQnUZ97ihYEptxnI9z3MRKMdqW4U5Zf zF5xgm8t0FBXOuQ8bHix+nnckhDudelIX1uEYpIU+6khdNrE8v544rEnZrwnfTEjj+pf m7FNPRuXJaMlguy9JrpT9QNJ++fxkCQYORq1mBwQMBHEqU71/2EGwSD2oCe5AMdNjhjP +SVh7dk3Nha4Syb/tHOpu1rnGTF6MaHQv7PIBY9FuN5qztIr3bR8cMlhIgbfjop/aq1o QCpg== ARC-Authentication-Results: i=3; mx.google.com; dkim=pass header.i=@suse.com header.s=selector1 header.b=yYmdLaj8; arc=pass (i=2); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id h5-20020ac87d45000000b00417fd10f754si2943461qtb.412.2023.11.24.01.04.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 01:04:39 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=selector1 header.b=yYmdLaj8; arc=pass (i=2); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D738F384F99B for ; Fri, 24 Nov 2023 09:04:27 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2041.outbound.protection.outlook.com [40.107.104.41]) by sourceware.org (Postfix) with ESMTPS id 485E938618CF for ; Fri, 24 Nov 2023 09:04:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 485E938618CF Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 485E938618CF Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.104.41 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700816662; cv=pass; b=r5e695l3yvQwX1EtdA96mwXS/rVLVcEbU0QEKhHp5zcHUS+sSGTJNBSK8Sj0Ibw1+S2LqcwhMEHgL6obNe8H8PscYGXuNh6eYMvgrOE60OIj8d3JooYs5/PxrfhIOaXe0Xk27wMJxG1ZKxV3hLxp60pQzjmPCeMmjSsIJB8vlmA= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700816662; c=relaxed/simple; bh=fqgQSUxJuCMTtvIuzDOn5V0o+w9pb2ahSAMHVxN9FuQ=; h=DKIM-Signature:Message-ID:Date:Subject:From:To:MIME-Version; b=Tbd9LJrkK58i6DICBQzPbFuN1qqxLWWCJ44q6p/qXfGo4W5zlnl7+MYgP3yO4QgawptkrJVcFYkIzqUTemuFqBgJFirjifdpfygXjQbN8hbbORXvupigmGlLOHXkazIQl/c2hmjbQb4/vlb0RlxaOfs3zSjqFuzfz0yj4fEkJYw= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BAkjtoB8dY1LinUEqdbTWSY8hRQXkECWBJhVD+sWbk/bldijJDRR76M/JCM/TKmX6Nl7IOmt2OJNonxcLHp+jNEUYv8TKdBHKr1kVV9mcUuaHOSMLbRGh8rE0Q1k/Mtw41QGbcae46Lpj6JtXhcu9IZapsL38j9d5p1/sqrw5wCWEDtEY9DF1ZuvRWhS0frhlE0JZ0Z4ulE8dSCFReBFRj177zdm+S8I9QOUPI7aE8iDm3pMHlS/v7dnVVcwR8o/s35p+j1Q2o8tf9BLXxImpgYI4PT7q2ZxgHwc6CWVVef2qPtgXy5P/G6PX79+M3/DylgAb26dT50VRtnnjMZbWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/fjh4uYEsXN5eJRAxw/lS1RbaMC3a2M3urGkY+tVwmw=; b=HW5/zGL8/Mcg9IiNhtxTaaDb/ecFkV3sudo7NZp15GhGYQZyaii/1l6ogKDFJMBbPHUaKL83d2lwj/ESXFNK04lG8mMr9lOLlZ3TVQS37t8OYdKkB+3JiEyM41bDdBT8C92TdfuU6EW+cD7VZmSwWo+q12D4V9T2yGhkHd0/Pt8gmdEqPg4IItizZpjwkuC+6Hf0nYpPOVEsueTjU1gdOozlMKLIfY3pqSafZi1L7rxsejaM5Up3fvZyxuF64S5lBsLewumStmzAflx0I3GT8hIhrNRhYb1Zq/2rlQo+gCY/6sXGQ+jZ3g8zxq/dwCAZKj9oA6fNglTjzZ8dqOg/Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/fjh4uYEsXN5eJRAxw/lS1RbaMC3a2M3urGkY+tVwmw=; b=yYmdLaj8er1yXDnmqoPg/gGX+sm0P/YlMZWYqYdoD3odRlX4h020LKyXDxiE+0Xs3NvCipqNPExgFWX2+mb/DGD9tADUHB3QQw+dFgh/CHVksvWhB64yuLLduFZw5vyzHHbugZFp5v4HTJ9Wjrq+NIN/lhAFNsqZ4RNxx2lLUKl4a3mE0mGQkImZDtVHaaGt6b6dmVrUy4vGC9S3yA/5RK0TeF75wDQvcPh/ED1aszEWzZ4oszCNqTqSzIemdyUVghxTNLMKx1Paup69pUg5ERl961hq29CtFtr11PYhxNKJyQ74NFShxyL3aXINuK3A89okMhZhbL0Au/hgQdIgiA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB8PR04MB6778.eurprd04.prod.outlook.com (2603:10a6:10:111::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.14; Fri, 24 Nov 2023 09:04:18 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44%3]) with mapi id 15.20.7046.012; Fri, 24 Nov 2023 09:04:18 +0000 Message-ID: <8857c2de-39b6-43c7-93d9-43554ef317c3@suse.com> Date: Fri, 24 Nov 2023 10:04:17 +0100 User-Agent: Mozilla Thunderbird Subject: [PATCH 3/6] gas: no md_cons_align() for .nop{,s} Content-Language: en-US From: Jan Beulich To: Binutils Cc: "H.J. Lu" , Nick Clifton References: <94626e2b-0e73-4267-9c80-cb25e1dbab9b@suse.com> Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <94626e2b-0e73-4267-9c80-cb25e1dbab9b@suse.com> X-ClientProxiedBy: FR5P281CA0033.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f3::10) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB8PR04MB6778:EE_ X-MS-Office365-Filtering-Correlation-Id: d29b9729-e894-4adc-5a53-08dbeccc570e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7fvQbZarUgXGRwiuyZXw1rI2fCpZ5MZOCTgIEa5l8GYM5Uqsy13Ok/TN3qxKRLDpZUoK7kUgLY4Zd6sJr+R9TzhLxQGCNuKkeCcamTt9McvGBs9HPBuzX6mOGoENyQH2ih/rzjfKRsU7uh4xXP3XzkJM2zCbCd3Q4ke7AXXeJiB6hu9WTQ8KTX79eHHRzfdAKMlS9qQLqRy40+azi6PugJar4cBwrvcpHH8G9Adfck1uh+vku16Jc6CbpBtV3BfkXPT7kxPqmEK0goC/xTg/vqilOQJT2G/B8OibzzAbxV0CoZj7/vFj0cE+dzBlKBjwFgKAEDR0YYsHAbUg4GwpTm3Jk3WHTtG98xONOqMEYIvuANfMDMfvwne2KTE81bC+aPVTwMOV2SOFOe0H5dv6FbefgnpoKJZTeyxfOajHrbyl9T8KW5Z25OoPCjby5dhTD4SssuPrf32WeaEoqFvFG/rTx2wZbYdGeQaNpmjEUhDps4NeAJMLzwK++eWzkbbaAEINPnh+BYdyDU4mVLLqDU+hAaa8vCWzqEx+t1EvfnaLOB4Uv1yOftlHcSZYrGaBdhpWqCdz86e5kj0PolB7sbu6DMP3cEsEBO9C4tpCO67wklPO1TYDEtQRGGbpU6YjMbKQ+OR0/9Sw8YdvRbL9yYvWpiQzEJU80VmQQbqQyaZiWKLud8EQb1A/lvqeQq7hWJTEroI2Q24yXf8DxIcjjFjA88WRJq1u1b7M813IQQQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8790.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(396003)(376002)(346002)(39860400002)(136003)(230922051799003)(230273577357003)(230173577357003)(1800799012)(64100799003)(451199024)(186009)(2616005)(2906002)(26005)(31696002)(5660300002)(86362001)(6512007)(31686004)(41300700001)(83380400001)(66899024)(8676002)(8936002)(4326008)(6506007)(316002)(6916009)(36756003)(54906003)(66946007)(66476007)(66556008)(478600001)(6486002)(38100700002)(142923001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?sDwV/J2UvUYnzPXaHdHvZMXH1CBo?= =?utf-8?q?uEoy7barJruDubrzNa9AnELw4Sif15rHdtkJ5go1o/O68eWhcRFatVjTdAGzbsBBr?= =?utf-8?q?bxEwP2rjPbEwGOevA7PON6c6o1+ZduKf4gX2uTBFtZGoerNfgh82+tz/05HHD9vzy?= =?utf-8?q?LxRXfFLkOJ5tHOdwXOtJMxvI8/ssBBR7JZEpr0rTPdLfYPmZJzhw8R/8ROWcXPkmo?= =?utf-8?q?793l4KEtbNNDe6dqomWeij69VauH+0NmTRCUC22acgmePtwYQrqLTGlRbRRNvbfN5?= =?utf-8?q?cuvlTwtIzUjeJ3l68f0fFMK5LgrH32mcPGIhO9cPk6L74VHtcF+3WspgumAJfv2NB?= =?utf-8?q?s+wnu6LocuqjXgG1jQQr+SY1A2FJcqiPuxzHBDyzhsBc0xYX3XItg/0s6NJS1PUKY?= =?utf-8?q?LQk9koB3mNj+Uso3YRkmNPkWdqRfGdY9EHN9SkChWUHaKiLf9R9GSjldOTBrEkcxU?= =?utf-8?q?jgLdQajesAK1yYAt46b+UkPmroHpOKRxIRshBYqyvWrL1mdqpC1JGSYe1hMYag+I5?= =?utf-8?q?gM6BdwF+oz6158GuwgNLquaUIssW+E/ZBg0mkpUpzQZaU/jFEKZCnC+eEZpVRbc7P?= =?utf-8?q?UbZ++wOjtYe7XdJpN9p+64ngDx9YnatC8P1i6yvhkhbTeRDwx1fSKe+iuP3nSymED?= =?utf-8?q?wtV70aBfLDdoTi7ai72VqTnkSiGpR9sdMZtjFk10DwUpkCxD4BFON9Ej487Fa2m70?= =?utf-8?q?wYvGXNMDfHnvo+u8NEGUDCnI/aPmlAKj4ue3ogIA7Fx3J1QfyPQceoJX3Y9/h/SEg?= =?utf-8?q?+iVC0yJWThWZdcdK2U+b+r280UFzq58P2QXasfDSjUNu7G14DJp7l/3riVvkLYwmJ?= =?utf-8?q?HCtNvr41+9zX2aCKmdYIDlH4dbj2g/OKGZzqyLYub1kYWWF4MXBH/CtQjJ5Vx2JFn?= =?utf-8?q?5xqEZKoApH0fINhs4l1eFhNWksEqN/anQx8xDnaiYMaO+hnu4NYT4RKhcH58nFBJc?= =?utf-8?q?Sl1BbswkQJmnDjzkEGh4fx3IygHkW7lNkFGAyEfNMxLzzfi5arJYpMVQ61zSGQuM1?= =?utf-8?q?szR0dpDXU6yafCULThhADaaDU2e2DXuK6wz+2vhw22nigOq2GuYcYyQO5AxtviO5p?= =?utf-8?q?O3Jp7+kUNroyS3U3rK8dczCklOTqzGI8/S60vhvJ+/ZbWkbkBvQA69aGaNVfEvT4Q?= =?utf-8?q?ZmnPlBuyetXYPZuzYNJ6Ulyac2CCptlSdU9A/F0VQbUbqe6sIWrYVGXTLTphHP2w0?= =?utf-8?q?O4kQJ4ixGLmmiNvAOSf/GGd3u7G2BF/zdd4C6UhLXXAt/mYYPrFB8c8N7fzioQSky?= =?utf-8?q?POXX5xjTnCegsZEruX/6fbdRY1/FLdEYuMveMXT7aYLNEU61VL1fkhN26IiUXKruK?= =?utf-8?q?S+WPQbMwGQ5xs8eeGSnyhkvJJNYBgGy6PzOzFKDPT3Jlpjcpfkdov7fl26g8uNFpy?= =?utf-8?q?u6qBclAWsHXEc4FnCNAK/7xZN7kuHcnAddDmVIGrnTELKkiu3NVq6sIWNDyrSqG+Y?= =?utf-8?q?46Xy2+UNXcCK9yyd+Y4yz+SxwdLM9PJ8TpqeM+Z0o0fGuBvIsupfW6XcTl6yTS+nG?= =?utf-8?q?nOrGhP7i1Rc+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d29b9729-e894-4adc-5a53-08dbeccc570e X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2023 09:04:18.2181 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6Z8HmwBIZnmRL9alrXPXD/rJUbme8d81kj0tO9Fo4AYvYt8ys+w4chDfDkqVja/ZN1Qp4ontft1PO4xtfKGLjg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6778 X-Spam-Status: No, score=-3026.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783435550045521124 X-GMAIL-MSGID: 1783435550045521124 .nop and .nops generate code, not data. Hence them invoking md_cons_align() is at best inappropriate. In fact it actually gets in the of x86'es state maintenance involving i386_cons_align(). --- I also consider it at least a little suspicious that all common code invocations of md_cons_align() have an argument of 1 passed to it: What's the point of that argument then? Target specific code invoking their own target hook can surely deal with passing appropriate arguments other than 1. --- a/gas/read.c +++ b/gas/read.c @@ -3466,10 +3466,6 @@ s_nop (int ignore ATTRIBUTE_UNUSED) md_flush_pending_output (); #endif -#ifdef md_cons_align - md_cons_align (1); -#endif - SKIP_WHITESPACE (); expression (&exp); demand_empty_rest_of_line (); @@ -3519,10 +3515,6 @@ s_nops (int ignore ATTRIBUTE_UNUSED) md_flush_pending_output (); #endif -#ifdef md_cons_align - md_cons_align (1); -#endif - SKIP_WHITESPACE (); expression (&exp); /* Note - this expression is tested for an absolute value in --- a/gas/testsuite/gas/i386/align-branch-6.e +++ b/gas/testsuite/gas/i386/align-branch-6.e @@ -1,2 +1,2 @@ .*: Assembler messages: -.*:4: Warning: `constant directive` skips -malign-branch-boundary on `jnc` +.*:5: Warning: `constant directive` skips -malign-branch-boundary on `jnc` --- a/gas/testsuite/gas/i386/lfence-byte.d +++ b/gas/testsuite/gas/i386/lfence-byte.d @@ -27,4 +27,13 @@ Disassembly of section .text: +[a-f0-9]+: f3 c3 repz ret +[a-f0-9]+: c3 ret +[a-f0-9]+: f3 ff d0 repz call \*%eax + +[a-f0-9]+ : + +[a-f0-9]+: 90 nop + +[a-f0-9]+: 0f ae e8 lfence + +[a-f0-9]+: ff d0 call \*%eax + +[a-f0-9]+: 8d 76 00 lea (0x)?0\(%esi\),%esi + +[a-f0-9]+: 83 0c 24 00 orl \$0x0,\(%esp\) + +[a-f0-9]+: 0f ae e8 lfence + +[a-f0-9]+: c3 ret #pass --- a/gas/testsuite/gas/i386/lfence-byte.s +++ b/gas/testsuite/gas/i386/lfence-byte.s @@ -21,3 +21,10 @@ _start: call *%eax .data .byte 0 + + .text +directive: + .nop + call *%eax + .nops 3 + ret From patchwork Fri Nov 24 09:05:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 169313 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp1019295vqx; Fri, 24 Nov 2023 01:05:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IHmZEny3GrUZUubwGyNvF67q00D/rcJ5c9R67e7H3imH2RbCWAb8qsgiQxdM8pvF+U5fkrg X-Received: by 2002:a05:620a:2493:b0:76c:ae1f:201e with SMTP id i19-20020a05620a249300b0076cae1f201emr8066239qkn.27.1700816723810; Fri, 24 Nov 2023 01:05:23 -0800 (PST) ARC-Seal: i=3; a=rsa-sha256; t=1700816723; cv=pass; d=google.com; s=arc-20160816; b=Yul2AlGTaruEslOdI+5qHSlETw1xBWyVra2iaVNSdN7sWXYGiDHSbC1Yd6rjkRfA6v NjtagIyZdpTy4D77g1+jthWS0XRIDde1k5C/aUKosxSLhLFEt29354Pe6hnKfyZSVxoZ rBhLSyO4h0Wnj9k3tfuXpUb54f0iF0qYwW31P9hYUOftDN8e9zQaTc1q3ZNhx/Vy3g6D QGShitivo4/48PJudTOiec0IiIkUECesLMH6FsiSbpo13T6LuVP9bpXe7sZeLTXMVbK7 xRinyeRkrL9HxjubESE2CZHPENDdIDUxWcI0+qKytwoU6ZBbQ19j0Wr4EnrAb0sMDP3U gu/A== ARC-Message-Signature: i=3; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version :content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:date:message-id :dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=n1xuXcFGeJpljOPNVPbl6+WCRtdDfJift+0WZUdh3PU=; fh=8WW8/k0o0G2vlJiZAQKLzwZ5FShsw2CjyMds4OH6804=; b=KDfE9uoiScFqjAeDuXQfmS2NRJtEUMF7PVjbFKGWlaRNX4lOK4o/ANJeWQyafK+jWU PfXi7JiZzDjyFkQZ3PVKyZaUtI2QTeTpU/MPJ7qf0f/pe3OFOH5v4kuFW0pEohEsa8NM eCGWH2fGqTZRBSW3xsQVgjiE+zGujjYjfxC0yXWA12fOv72/KOlt7qzz5X2mMUC7+otV wOaEUgGZEtcKrlv9aevhuvqnoH/MlGBrsOrpNZlC+GkSXfB4DeJP3MS061t/I4sOVxrU zvBtUUPM7WruJt791UcTpdlGzrhRY7JYtzwUUZV6mwEB+IZuuFlZlgbe/New5hNm/mac /hew== ARC-Authentication-Results: i=3; mx.google.com; dkim=pass header.i=@suse.com header.s=selector1 header.b=aqoLkNT9; arc=pass (i=2); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id v9-20020a05620a090900b007759a519e0dsi2723321qkv.73.2023.11.24.01.05.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 01:05:23 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=selector1 header.b=aqoLkNT9; arc=pass (i=2); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 158D3385DC29 for ; Fri, 24 Nov 2023 09:05:14 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2045.outbound.protection.outlook.com [40.107.13.45]) by sourceware.org (Postfix) with ESMTPS id 7B64E3858019 for ; Fri, 24 Nov 2023 09:05:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7B64E3858019 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7B64E3858019 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.13.45 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700816708; cv=pass; b=Sl7ZBl3H31UlAYUd2tbLcfA681xB/Eib73zClGCsCYohgLYQkKj7sU6q5+w86MRRyJZbkEE6vKylSZ3PTR5E+rThxotsT0Eu+fWW+iEpwgxBbBcWInjVJndmHHt9HzKhyvC/+1OO/1GfyXwU+ABTqLHMRLBmjuoocSpbqx8njEc= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700816708; c=relaxed/simple; bh=QFLsaL/eSrJPQjdZKCKSr+qcRlTe/witf4ygf87hvxE=; h=DKIM-Signature:Message-ID:Date:Subject:From:To:MIME-Version; b=wvRuQXQ+XeRATkkHQcaNOCwrXm1xGwH/pDV9FzP/huqYeFktc1u8zYHz/g3zWfNt4N3gbm0XewWXI52HKx3R0d4fb4gJz5zOFdSzTjCVxN0H0qiJsHHR14gAISO9PBeBA98rvQnDwtezJ2A99cXiDqt1ITdBgZUonYi0h8lJcAE= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VJlYCAbU9sNFSFVDo5Wf774Qy+evus9XbAakVESVJvAmY5G5KXMBKyRbpawOIpzLhCIqLf27Uo8VbRDmvjSMyt+YPJF56Hb/ywzb2ZqFm40rvnU3rnDalvwEoNXVxO+oxipp6aiyON0kMT1jyYT4Xwjgof27k8QiiMYmIteAE94xFL60veiFU53jV6E4jTbbIMtckKMIh/Sbn2LD/k9TR+gRbhZdilMx+l4WpGhPETEX7C5UUzFJiA0h6B5Ik23kpvR1KpwA8g30bOxqKWNgU25mX0HF7Uh+Fzln900GnM4G74wURVuU1FrPF5g9Q3m8PTV08mhVqP/pDpRS7DAbOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n1xuXcFGeJpljOPNVPbl6+WCRtdDfJift+0WZUdh3PU=; b=gJweJMKhAsN8V8J0xCYdqObtReYLLCIEJn5v03+2WW/NSNrCMqdL1gUhML2D2684oXKEbQ80lcW/d11MQi5itPxyelIIqk3240pm6vSZhFI0sGxwoJksR3jV9IU3Y7S9apgq970CkRtl5+ROcYzs641Geo5cXPZWYyF44u6aJiBBrROBdvKHeYyskx73GCpMKjcN5oFemEsruePwELp9hzmCMuYEc/v9T0RclMp0/IRvIVkuZmQKGfjVjFjgrV+dLfei9y2uj5T7iYGJx/WH231gYD0nXpeiRZ992WHTV+FfHcVzCIakDp+X05OLXrH7O8qJyDOhJHx8nGt5zQuC7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n1xuXcFGeJpljOPNVPbl6+WCRtdDfJift+0WZUdh3PU=; b=aqoLkNT9M71HNSXCW7p7T893fyUZK9Crg21ERtYBWFPz+bPcgBzZbJJkGqNizVAol39MYvDhed/YlZXeW4FpyBFKFygmB/EFlHnERZFX93j/wpnOg1FJOXE1S2gVpQgzPdWcqMSiehQe0TKNAfLEiZhspcO7xQCbilKfaKhYDSgpKtSFPtV+ABskdAkexoWAntDpXFMY/KigL+tIEv6tNA23moDHtIns7HrP/nubsu6y8czzjkc54ulb77CZ/MVrZqN/34ZssPn4lDQ+lYkqSHKiXZLlTuoOAmqzbOPASNfc2ahugL0ItZPP6oAjkn5iY88DSWN0+trVyJ9e4h4+ww== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB8PR04MB6778.eurprd04.prod.outlook.com (2603:10a6:10:111::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.14; Fri, 24 Nov 2023 09:05:04 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44%3]) with mapi id 15.20.7046.012; Fri, 24 Nov 2023 09:05:04 +0000 Message-ID: Date: Fri, 24 Nov 2023 10:05:03 +0100 User-Agent: Mozilla Thunderbird Subject: [PATCH 4/6] x86: i386_cons_align() badly affects diagnostics Content-Language: en-US From: Jan Beulich To: Binutils Cc: "H.J. Lu" References: Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: X-ClientProxiedBy: FR5P281CA0033.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f3::10) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB8PR04MB6778:EE_ X-MS-Office365-Filtering-Correlation-Id: b8e369c3-4cef-46a1-25f8-08dbeccc7277 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hYyWxYvnGzPxmT0DwmUeYRaUvDWzapP0W21fBSSd3UwOUdYhMylCStTlT/HYHf51yN3oIACFDKaI21X9EeAfDKDS+OCtnnLicOfD6wwt/hKjwxh9YZrmnvSkbHG0A1HYrGyTrIS0Yrvgp6kLOsq9eH94mVtJwWPmcuWO5kwrLyb8bLzbyrmhNUCQPqaaGEbQNWfv0bYnGKiHqNkD0k/K7oqbcoyc8/YCxmt5KkItnYHThHwKpsmmA2vMtC5pddY2AHHYnm/pes7+HLosoXvDYoyahujdEQJL/3hIJaBAXVl5z13G48chi+GElOak8ywQP0OdY4RhVGfpZmGAMtmMqMSZEZXnAjhZCnFE1t7T2Ioa0OsINc+FVJLXEMNRkuowVNjj4UC/eaqj05BoBpdEArLX2NaXgiO2faXTNwFN9X5ju81wE6gHiKx482qtsbOKPJXmwE9w9j2JGEMYI+le/bjpm+65IwpKAsCKzsjx8dYA/o/nA7lxt2juOrhUiAv5Vaz301sDod0CMO0xsk8Z96rwYOyeKerUQo8l0rfwUdZdewxg2s70YcBO4zAM24IeWkGxzMk+myX8OkfHLqSn61dALENzR71LDVnNBTmcYL7Y8FSFl77YVoBqwnctdFMUqm+pHD1pMkVpYmbhLce1+bnORb7KSfGVSvHj0J/udYDZvP6yu2nIFL6VJqcUPTEG X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8790.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(396003)(376002)(346002)(39860400002)(136003)(230922051799003)(230273577357003)(230173577357003)(1800799012)(64100799003)(451199024)(186009)(2616005)(2906002)(26005)(31696002)(5660300002)(86362001)(6512007)(31686004)(41300700001)(83380400001)(8676002)(8936002)(4326008)(6506007)(316002)(6916009)(36756003)(66946007)(66476007)(66556008)(478600001)(6486002)(38100700002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?yISHyB2I0LmP6A979lq6c8/0yoIH?= =?utf-8?q?qDZTdKkk1iDpg1J/EmQ2T6ylLN+zW4KVgH1x0+JZkT/udJZxrY0HTDqGX6VYLVcTx?= =?utf-8?q?s8cOOQO4vnJV4XAa/h4oq1G/2POCUHnWW1lsbSJQKa4K2/oyX/KmbDm9K1Dg1Kq6v?= =?utf-8?q?Dg4kUmpKXLoi1O7YIygxq/+2XMG2nVoctczwEdHgp7VPm+X/genM5z+qPM0aCeorn?= =?utf-8?q?ZpkFf0lz37g6WQ7ldngy/JBY79p8lj55JaRAzaP1ICbKpsgihQfheXYzGRdKmMxmc?= =?utf-8?q?cYV7oR3i/soYCPdO1it+4AQ/A/meD8AvfCxVR0FhoNOTtWF6xMZ0mwBTJl2PIjPfJ?= =?utf-8?q?IJO0Xif//hHZyhCAUZ9kPbHavce3dki4ad7UozHe2wrNG864iCNF9CNpHYc57asdG?= =?utf-8?q?0/k9cDwatdt+/qzPZr0Nr7RxGR968N2Y3hlukpg4Sj8Q5qDPrA9YmHfkJb6272S3q?= =?utf-8?q?aHP5q+10e8BMufhMVMvus2gVEclxk2mRRX8qN4zlSGGvzaFE05s5xb2MI+HmZH11d?= =?utf-8?q?VCOvrU3uf8FhYw267ORXQnpAA0ACeEjrR14mDeVRsgubfUCx1EvTEuBMofwm/s7bf?= =?utf-8?q?GAYrMTlMCvIjWXeZam2qHrB/Q3Fb5InIuAyh4TTh2SO3nfm36sYs6dk6Y32Dto4dP?= =?utf-8?q?pOY34YaSw+hLoy6VRT1SVPwywjcyiSk7Zmkt9O6O0TiVH4rCLr9u2AOgRTlRToGYq?= =?utf-8?q?NpXcsCKhdNsbOwckcbUCLXB7MRKsyAf7ENpznJe7SehYUZwxnXSwBrRO2j99+PLK+?= =?utf-8?q?NOnheOu0uXsX3Qh5uUSok1ce1JGoPygUEYDu5w+Nk3cEIpJ9j6DQSrm8Tev8q8h+V?= =?utf-8?q?VwLqDjXQAjgCfn1a7zjr+b+xaEprf8tr3xqJU/YKUStHdK+KAeeGydu0wKKd9bO2U?= =?utf-8?q?VSSfx7Y6GFwy4KA4aeD5vyHk6DF4wrDQS+OFeDVUR5ueW5pEmEWcEZU/aG+jgtI72?= =?utf-8?q?lhitUomSrIB+MMQCEH8a9via6x2V7qeQQ7B+HMVzA1kv6N48fWJg2PzfibGU7UiY2?= =?utf-8?q?nXmz3AcFfPERc3YNAf+TlC8qppk9YfulOAO2ZX0kMc3Ls3nownxenIY2qgvQOfKPw?= =?utf-8?q?990BKRHOQNopkVaxr2xp4Z4rqWESCwvBb1g6HkUVRl/gDMqIZJq59V9lhByBpeGh5?= =?utf-8?q?Hrd5otmlueoLO8UgCJQHSQSmP9P+wk65PVFNoyT4sa2IVCftD5TSe4bPQwtH6rXFS?= =?utf-8?q?0lXuLO9w0W0QfybsmG6HBtD8N+rJ1vZ1888Aa3/6R0cm0qlj0k+tOtp1m6Nt+Z3pa?= =?utf-8?q?f2INapj2evZNf7rMhWGlLozeyBOPbWyqEalxdKZrSfhMA2m6xb32XrqLinw1aLuX3?= =?utf-8?q?VbMG9kFmAqeMlxoLq7WdzUZrAvAmrx7lzcPWpKO5yL/HS2rz9rIwm8YuDk/4heQIZ?= =?utf-8?q?FHBxAmnksCPi+jQ+/aFAQ76Sux+PbDfsF4yFhpHSQQ19ErO8iJ5ZAxlF4sIr9t4Ya?= =?utf-8?q?SfPiCJqJRgP9JeaZ681wdzCW1yXaxUJod4qNuChndYiGd5WwlI33Q2gjlhdLjNMRK?= =?utf-8?q?UomEGBiwqjmT?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8e369c3-4cef-46a1-25f8-08dbeccc7277 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2023 09:05:04.2127 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: W6hTKR8+J7OhLNT8rYx8pdfAwK/DdevygJlHhoB+F1PkF6EmeJojl2dxHc+C70MeDYduVWj5FYUrUgXs7ADODw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6778 X-Spam-Status: No, score=-3026.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783435597037850587 X-GMAIL-MSGID: 1783435597037850587 Warning without knowing what's going to follow isn't useful, the more that appropriate warnings are emitted elsewhere in all cases. Not updating state (file/line in particular) also isn't helpful, as it's always the last directive ahead of a construct potentially needing fiddling with that's "guilty" in that fiddling being suppressed. --- Maybe the stray diagnostics are the reason why there is that questionable SEC_CODE check in the function (which for now I'm retaining there)? --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -15491,22 +15491,11 @@ i386_cons_align (int ignore ATTRIBUTE_UN struct last_insn *last_insn = &seg_info(now_seg)->tc_segment_info_data.last_insn; - if (last_insn->kind != last_insn_directive - && (bfd_section_flags (now_seg) & SEC_CODE)) + if (bfd_section_flags (now_seg) & SEC_CODE) { last_insn->kind = last_insn_directive; last_insn->name = "constant directive"; last_insn->file = as_where (&last_insn->line); - if (lfence_before_ret != lfence_before_ret_none) - { - if (lfence_before_indirect_branch != lfence_branch_none) - as_warn (_("constant directive skips -mlfence-before-ret " - "and -mlfence-before-indirect-branch")); - else - as_warn (_("constant directive skips -mlfence-before-ret")); - } - else if (lfence_before_indirect_branch != lfence_branch_none) - as_warn (_("constant directive skips -mlfence-before-indirect-branch")); } } --- a/gas/testsuite/gas/i386/lfence-byte.e +++ b/gas/testsuite/gas/i386/lfence-byte.e @@ -1,9 +1,6 @@ .*: Assembler messages: .*:5: Warning: `rep` skips -mlfence-before-ret on `ret` .*:7: Warning: `rep` skips -mlfence-before-ret on `ret` -.*:10: Warning: constant directive skips -mlfence-before-ret and -mlfence-before-indirect-branch .*:13: Warning: `rep` skips -mlfence-before-ret on `ret` -.*:17: Warning: constant directive skips -mlfence-before-ret and -mlfence-before-indirect-branch -.*:17: Warning: `constant directive` skips -mlfence-before-ret on `ret` -.*:20: Warning: constant directive skips -mlfence-before-ret and -mlfence-before-indirect-branch +.*:18: Warning: `constant directive` skips -mlfence-before-ret on `ret` .*:20: Warning: `constant directive` skips -mlfence-before-indirect-branch on `call` --- a/gas/testsuite/gas/i386/x86-64-lfence-byte.e +++ b/gas/testsuite/gas/i386/x86-64-lfence-byte.e @@ -1,9 +1,6 @@ .*: Assembler messages: .*:5: Warning: `rep` skips -mlfence-before-ret on `ret` .*:7: Warning: `rep` skips -mlfence-before-ret on `ret` -.*:10: Warning: constant directive skips -mlfence-before-ret and -mlfence-before-indirect-branch .*:13: Warning: `rep` skips -mlfence-before-ret on `ret` -.*:17: Warning: constant directive skips -mlfence-before-ret and -mlfence-before-indirect-branch -.*:17: Warning: `constant directive` skips -mlfence-before-ret on `ret` -.*:20: Warning: constant directive skips -mlfence-before-ret and -mlfence-before-indirect-branch +.*:18: Warning: `constant directive` skips -mlfence-before-ret on `ret` .*:20: Warning: `constant directive` skips -mlfence-before-indirect-branch on `call` From patchwork Fri Nov 24 09:05:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 169315 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp1019578vqx; Fri, 24 Nov 2023 01:05:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IFIUhvzzecf1viC0WwgO1wdx9KMb1W0tf0RKaUfjYHopWoruFUXWLtpCV7FTDMknk0lp9CD X-Received: by 2002:a0c:e90e:0:b0:67a:fd5:24a9 with SMTP id a14-20020a0ce90e000000b0067a0fd524a9mr2375568qvo.19.1700816754325; Fri, 24 Nov 2023 01:05:54 -0800 (PST) ARC-Seal: i=3; a=rsa-sha256; t=1700816754; cv=pass; d=google.com; s=arc-20160816; b=YF6UOadWUJLTP51/tvRoTODhm9uDXtup48NytzcSsC4QWsOxAjPxr6QyAM7vkMPhsG sBVVxxVKd46Zn/Jz63JDQYzyT2nptZzlJGgJtivrx1WRMqF8pGaEd3z0g5uIjJAwRJBp tV4ZvHOO4XwdWzDLSXJoE20e+J3PqnBb9SlnoH7WSTbY58QtmhCfM3SKlGu4/mvGYSZ5 ke5CV9OAEKsV0g5YSZsO40Gg3zOxJW7ccIyY/LD9UTDNGNsU5V7p+sFZPT+veEmPze40 eohQ+WP+dfrnfzDfx3Snx5b9LADtqQWYEWNyYqoaDUwq0r3KvyeI2Gt6Crc2aKRE0lRG laQg== ARC-Message-Signature: i=3; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version :content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:date:message-id :dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=3Xf4OPIRnaRiDyWs02V2+WNlPZjbiCE/FKDLocpd3oI=; fh=8WW8/k0o0G2vlJiZAQKLzwZ5FShsw2CjyMds4OH6804=; b=MYAYMVnZZA0qpEUCs7OlacmuI0EpFFz139n/hD6XXR7h5NdYk3thVXfwRuVpxfpaPz uqlSLu1TGB4dc2FERCVBvi7lY+EHUCtvBt6p47cLrdpD84QvJ3tYi1D1jYlwgG5nahDl PxAK3/4CJP1VbgqhNlzYy7/9nYQhunG+uNZt7rd1Zzuafht3KJUzr1ukH3BhEYzlPnWD il4Q++xfr4C8auZtPzvgPZChCyqfl6u9x/79nR6S0Du4m2eg+uk25DocQMWj5RKh9ZP/ sGUCgSEkJeriqJssljE84FM2YSIaw+So1wi9lGFBX//rJNAkGH0o48t4H4GaJFS03ZC8 V6fQ== ARC-Authentication-Results: i=3; mx.google.com; dkim=pass header.i=@suse.com header.s=selector1 header.b=YQsksXGa; arc=pass (i=2); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id dh14-20020ad458ce000000b0066cf12ca208si2860659qvb.309.2023.11.24.01.05.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 01:05:54 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=selector1 header.b=YQsksXGa; arc=pass (i=2); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B2A9B385E038 for ; Fri, 24 Nov 2023 09:05:40 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2072.outbound.protection.outlook.com [40.107.13.72]) by sourceware.org (Postfix) with ESMTPS id E8382385DC00 for ; Fri, 24 Nov 2023 09:05:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E8382385DC00 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E8382385DC00 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.13.72 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700816735; cv=pass; b=akMy+3mdiiH+p7wsNyKdqrSpPEg+Z1v7bisDg66VnCMZjQrE5ZeqC7P5oIseQGbPm2+KToMrB+ngT/qAQrKkwSz9qaVziuGoI1piFErQCdK/9DWsphZjf4HBI3GPMindFAEMHzJJDbxpzBHpvzPCdXEWKFy/FdMebvbVSSAaU40= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700816735; c=relaxed/simple; bh=FNXgx1hIkqju5nRll3JvUrKXAn0QNsHAhp9xHIff6Dk=; h=DKIM-Signature:Message-ID:Date:Subject:From:To:MIME-Version; b=aRJ3aKPjiKAx6SSwR/o+B4yPXd1q++DgGbE+QT60mshwJvkaCll3h/MhqzLcJQcw+LTi8NAxyHMAndQMtjsqYFLUSrdcRk4l3eVLKYg2jSiLIrOIUYmhQxm0uCwgLJhnB+R82MPTtpFArGxxqZutMzbVne3o+852Jdh1eu/+Qik= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lMZGpF0jOoHoGsWF8thSjnalcyfrbTk0XNnXZSEJZdoeB4Gwk3imDeEg7BcOjUfmWh/jo0twQJaFudxqzpkBnu7T9g5aKGizmAwS3KC/eEgJukvztxqNs3HZdkl0C48JQptAG7CGo8JxAyk6eUo6YMtcrX02GK5h4tJB7ReNDXY7xoayI41L5eZ1DpNSDY4QeFBbPvz7hTrmqiimSZqBxy0DQByo1vQU3uxtYk45XfRfwhJEiSlfUNZj78lifherpS3OGINzn5+R4xVRVm1sGd5mAGG4Q/pxCE535CL6v8RyyGwfX5SCJY7Lhtm1Ai8SNWhRzBnejVVhWH+uG03/CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3Xf4OPIRnaRiDyWs02V2+WNlPZjbiCE/FKDLocpd3oI=; b=DpTOhne0BJ7tp48TbefVzrSswpjnWMkjMQZISlEEh8iqcm6cUc13oAEcEsZjJQBv37TUUDwNIlS0hx07z0IbOgYYJbzQl05eaBnYNApUzavJ5EcLs0aeJyA+1471I6hfEZsNEbcWGx48K0NME789uIQu0yuKGsI8U1f0ce606goDesTZMWQvFSYvq1p7ytQ7joElh7iKO5Q7qd33JAU7pENstGfG4Hn25a0p5r6ZcK/bYu+bysKOlLoUBu2Jvpbm3wwPGnYqjA1ClxJDtYPedwo2oHPHcQ+RQ0sHDgeTcXQbFuCFVgg7klud8gAa9astSQmzDyc9J0tCoDiNsvJGzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Xf4OPIRnaRiDyWs02V2+WNlPZjbiCE/FKDLocpd3oI=; b=YQsksXGabE6yMFktk6hvgtEIkX6gniPl6hmiZBQbXb1Lc/+Dc36mTYRHJOiLus6mDD1s1coDMEkwl+101gOxMP1M+UGwoF0CO+nuYL5l1c3fiFRHGZnk4Ci9jRMru9lEYIahJQm//hOU66nQIAjrmkrXVM42yqJi9r4qijqzViYs3I7xlysXTfQZ+y5oXP3ib8n42kzbteMFfjqx6VXFRwXPO49ShFywYlittjd1ws18C4ovtwasboRu5GMyscyBmQyG3wMnCfrJ8SD0RzNo8yEAwXpD3A4juRQaSIiIBRMOuZ0NMZIn55SKv5lGsr6tcTEgCUW1PM6uOBQU0cORsw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB8PR04MB6778.eurprd04.prod.outlook.com (2603:10a6:10:111::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.14; Fri, 24 Nov 2023 09:05:31 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44%3]) with mapi id 15.20.7046.012; Fri, 24 Nov 2023 09:05:31 +0000 Message-ID: <6186c042-e778-470f-a995-1522aca041ea@suse.com> Date: Fri, 24 Nov 2023 10:05:31 +0100 User-Agent: Mozilla Thunderbird Subject: [PATCH 5/6] x86: adjust NOP generation after potential non-insn Content-Language: en-US From: Jan Beulich To: Binutils Cc: "H.J. Lu" References: Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: X-ClientProxiedBy: FR5P281CA0033.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f3::10) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB8PR04MB6778:EE_ X-MS-Office365-Filtering-Correlation-Id: 4d664370-9c30-47de-7910-08dbeccc82cf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rRkVYlbg1A90QH/P3/LwRyOdLnC7VHf4Cq5KvMoBjsuo6TIHrzcWkYnr64UtYYqljKtzqjZglr8WbdQsDwToLdWZzcDMXx6L8UPUQSPid0x+H39OOdrHLUdc8C56HDuHNdHzf4w8hrDpYUj4oXmm5MgwGvzG7dzKfN33RT2AgLFWeljeYpclSZ2WQvONY0wVHl2BW+Y71M8CvUdxqaUCX1sQ/l6nro9rRO9V65BhGjXuxYOk+AxBBFmzlMEAMy2oVUcWeZHPE0wss2iEoXJZbBs+RxEDnZRbRuD104gvVGJxESCiU4mRjaQLCEDSfP2093ZGWJWd1W8ndte9wDifxXta+Ma2J+MkXutdPzHkM8ht3dJH1eQZMWQ8GphwXBSPF/fyKdaGYFmBXEEq9BN/jCQFDV0Z/GKCdWHI9v1isef1VLu3/TE3rNyMv5ACDl8FTxnisjlB7HKrP45lKScWOTcH/znHfyMCFOuzEZ2e4U1jjZ5A64e//x0Q8e6lTi5Jzf7wI/idCz0qLqyPXa+CugfY3wqYMuvXuJo+ReuoSiXIqu5racmZb7YF4eZorVfMNBcGg0cNiRKJTwbTY3A55ORz5VXP3JDkCGTxUy5c9LGl+NVdivHssmfkSLpdYmzKuI+I3sMB6WUgpRIpuG1oDg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8790.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(396003)(376002)(346002)(39860400002)(136003)(230922051799003)(1800799012)(64100799003)(451199024)(186009)(2616005)(2906002)(26005)(31696002)(5660300002)(86362001)(6512007)(31686004)(41300700001)(8676002)(8936002)(4326008)(6506007)(316002)(6916009)(36756003)(66946007)(66476007)(66556008)(478600001)(6486002)(38100700002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?HvRun6+0Mi1zEKfz5SMVdV2+ttgU?= =?utf-8?q?MoD/vypxUOqYFpBu/63R0XG/q5McpbRrcs0tllI+hZW1zArSkyy7qnguNoTcK3uy1?= =?utf-8?q?yW7l07gsS/DU9sJk/NoC646ToM6KGkaJZqZvhcg5kAHD4MkPrRkAWkzmPbwkkyc1c?= =?utf-8?q?qwtjdmBkbZAOS2j6CGuFhdG+42ctuj5rqk8lUUprS3qYV9Lh251DFV7CTxljGZtFJ?= =?utf-8?q?4Ush/j7KvmTUm/ehixva06nFfKqj7ZtRpNszjSxn3sfi9hEi2vzVS9ulCRXr3b8kl?= =?utf-8?q?1U0pN7epfWQlx0qS05FvxKq+y4odeVfdhtQjXC6oKJKjI448af8V7IDKQPZ3eMKms?= =?utf-8?q?BiSomC9KAwL9QRk0PYdtFEO8m+IrnEbrSgnboY5WzzDKnhZ0YogWgJtgk3IPSP4n9?= =?utf-8?q?DqHfwVDXV874h90XWaMI0mjDOhCqlGe9rdiGwnD8K4qacyW+SS4pPvMARJ7SeeU0I?= =?utf-8?q?dLO2eAPEb62KqSSj6u+8JawWO5d2mckh8yddh/anO1mvJ/YdzAtVPn3tDSeYfG3YE?= =?utf-8?q?UTL6tTBeBqj1rG2wPLyP2VwKhXPRmXA9UD//cxJb8y1J7FvWyB75Akt7GrkNkPzp8?= =?utf-8?q?hgGdi9bOKCVarqf0NX2TyOtQWKIqEyjQf/NvNt2t/iNeSj9B393Fh5ljlTtLCHFm2?= =?utf-8?q?YjxpXVOh9zzlUd5tSpF3M7mi19yxmZtJh2/3GsKoXtUM6rfnpKp8sUPvfeyOgfyH9?= =?utf-8?q?WUzOH8lalp4LuenFngXh4sq5NSE6KkyeIolQxpGbf41P2C9IboizvxnmTRKz3dXO2?= =?utf-8?q?69PEE/J9fIU7yDFIUpg9fYaAyYweAqnGE2m7gLnsFigvBQc3L16amPvY1kR9NeS7Q?= =?utf-8?q?fRjzzhrMpWkk2MAsfe9+trvmcCDUbwm+U9dGADQUC2UMQPggFTqYRpSeg4OyG48XX?= =?utf-8?q?TxtWC46YZBBSCmKBWPclW1DWyGd2YNOsVZN3k5nlYBQ1xWxfpIEpgpD8b5nGr2ysw?= =?utf-8?q?DQxBNEJUv/FsWWaNm/vAmiQL8Jlcu+Bj7IwMksbPmbKUj8k2NKLV2+JQdteUrWqDg?= =?utf-8?q?KYEcQ2fw6EAjmmuU2Rrd81LLHs+9JxGBd7eHDcWKTGERNDkHRq7o2eo4rfXpfpzkg?= =?utf-8?q?3cSykk3IYCnKrmjavgCabuO3imrkEmJEAB3p82+aZZIS59XOgoaY+wEXI/kBs7+2J?= =?utf-8?q?3OspauYgP9TjIF6awq5TDQQWWGRP/aSPEvdgX+TKhOsWbDQ+wJsjiRLG4+gxBaFPL?= =?utf-8?q?sSTJ0rQDMEUGWi614+t7iUHei3gHWu4Tszug9gcpj2KYmmcNncCKme5/ikAhopAa7?= =?utf-8?q?89jwfpzT5SbPLT1J5APQMiqvLyYR6+ImX8nMmEX5W9hJ4PUE9Vkwgjk8oghWqn0Za?= =?utf-8?q?55+2OiWaWl7MBj9buKQYJQtVYDZZaIpZErmat99RKcGECKwoHdPDZ15E917ep/R6s?= =?utf-8?q?oDOOYEBoFGRdmM8hV/Cm3Hd8mHou/Xxagkv6NuHSUZqgJqITQzbNIDLilrGBX4Sjw?= =?utf-8?q?fhPHKfoCCN6977Dt45kAgjfJ66dzuuxejaFci3hb+b8QUTDQ3Ili7BZQmZx2qUM+s?= =?utf-8?q?k4T6n4a+kfiG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d664370-9c30-47de-7910-08dbeccc82cf X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2023 09:05:31.6219 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MCErz7dWBrlKSF1uVICyjmeyZe32diLhyHJTC45003NVXBwsOIHwETY37/V456KiPmljIYqEfidvqfm5OnMG4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6778 X-Spam-Status: No, score=-3026.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783435629036120516 X-GMAIL-MSGID: 1783435629036120516 Just like avoiding to do certain transformations potentially affected by stand-alone prefixes or direct data emission, also avoid emitting optimized NOPs right afterwards; insert a plain old NOP first in such cases. --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -1529,6 +1529,14 @@ i386_generate_nops (fragS *fragP, char * else if (fragP->fr_type != rs_machine_dependent) fragP->fr_var = count; + /* Emit a plain NOP first when the last thing we saw may not have been + a proper instruction (e.g. a stand-alone prefix or .byte). */ + if (!fragP->tc_frag_data.last_insn_normal) + { + *where++ = 0x90; + --count; + } + if ((count / max_single_nop_size) > max_number_of_nops) { /* Generate jump over NOPs. */ --- a/gas/config/tc-i386.h +++ b/gas/config/tc-i386.h @@ -321,6 +321,7 @@ struct i386_tc_frag_data unsigned int branch_type : 3; unsigned int cpunop : 1; unsigned int isanop : 1; + unsigned int last_insn_normal : 1; }; /* We need to emit the right NOP pattern in .align frags. This is @@ -347,7 +348,10 @@ struct i386_tc_frag_data (FRAGP)->tc_frag_data.cmp_size = 0; \ (FRAGP)->tc_frag_data.classified = 0; \ (FRAGP)->tc_frag_data.branch_type = 0; \ - (FRAGP)->tc_frag_data.mf_type = 0; \ + (FRAGP)->tc_frag_data.mf_type = 0; \ + (FRAGP)->tc_frag_data.last_insn_normal \ + = (seg_info(now_seg)->tc_segment_info_data.last_insn.kind \ + == last_insn_other); \ } \ while (0) From patchwork Fri Nov 24 09:06:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 169316 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp1019929vqx; Fri, 24 Nov 2023 01:06:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IFGXjfJGI5vp+zHdV752T8sJ3Aujsmx0E+ykcDRvRTNkB6KYyJdQ0xEawKt6KHzQ5En/mKZ X-Received: by 2002:a05:6214:154e:b0:67a:460:2c9b with SMTP id t14-20020a056214154e00b0067a04602c9bmr3299142qvw.20.1700816789015; Fri, 24 Nov 2023 01:06:29 -0800 (PST) ARC-Seal: i=3; a=rsa-sha256; t=1700816789; cv=pass; d=google.com; s=arc-20160816; b=nqvRywlMWuCoDwfXgaOI8C0Bsfuv+uoBjitdq3ZQCyWWdSZUE6qqP7hspUucFOLhIf +UA4woWlm0w4fWv8cUvUWaj2h2K14KAkBQq7Q5uaG1DzpSokRdEAhO+zlBGu+WiaAe4i qaTHtGoCV45zyLNnImJP9uQl1/x7JG0Xv1hdBmyKLXXio1mLXC9KAdXSGMeYLW+UTEOu UNQ8yj5oa8dDhM9kobQirjuW0AVCX2AkuQN+iFclxLJeJ6bqZA5MI+PylPyD1Wd/v/JT NrtwDRQCnd1/65PlL973rB7rk8t6cQ2CZ9UaAdX7veYSovjGZ40/iBvZU7XDpzV/v54/ Pi2g== ARC-Message-Signature: i=3; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:mime-version :content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:date:message-id :dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=smKlmhKM0SyzMtuK9PyoRV/b7GseysEnD2lGZbr4yOA=; fh=5Xzgsfi+BxTA/WBX/8ajZrRB4ZtN7RJCiTegFMT79QQ=; b=v8LnGLTNIDu5jZgp1UFTyeGE4Aj2BeBExao0RUtkDBsIAZjR56qERFK4labQ6e/7a6 a8GBJ9SkGiBcLfG/63Gpagrq7Xyo7YbTuy/k3zaByIfikO2cl+MkJYRJ2K5+tDUQG6Iz f/8+XC4QpvSwQv0njf+Ncl07Ik6qt4VBUTNlSHz80Cm17UO/tsjg6qO9keBAAUHrUpin TTTHjsjocNYw4MwyDDtA9ZaEm1sdH1fFoqtxJ2N7oyRSQGJmiaQ5ZQT3BgTB2xIGbQn/ P+nUgSlzTXEH0MZfxyoPDC8TiiFba70a+pw57vhb4hMIdnw0KHj8Z5eYa9QBUQLdfXC2 Go/g== ARC-Authentication-Results: i=3; mx.google.com; dkim=pass header.i=@suse.com header.s=selector1 header.b=ClpI7nx2; arc=pass (i=2); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id x5-20020a0ceb85000000b0066d0038725csi2911136qvo.598.2023.11.24.01.06.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Nov 2023 01:06:28 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=selector1 header.b=ClpI7nx2; arc=pass (i=2); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 60D06385DC16 for ; Fri, 24 Nov 2023 09:06:28 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2073.outbound.protection.outlook.com [40.107.13.73]) by sourceware.org (Postfix) with ESMTPS id E270F385DC11 for ; Fri, 24 Nov 2023 09:06:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E270F385DC11 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E270F385DC11 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.13.73 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700816783; cv=pass; b=ojps9deioNrodlVldqaQsx1Eg6YRtAg8eipTlnFD2u+mPJ6/yQGdEEUrIrP7JBBS2nHBBszt/RAy9Tjk71WicIae9kwTKDe/bJfZ6SIxMcl22rXRhWV5i9zm1A6uQe00URYb2PGU8fHhYmaJPk1+E86vNtaVUtk/p7vi6JUtm7w= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700816783; c=relaxed/simple; bh=7EReAQ09iA4aVZnaDb1g7z+5edeCSULQhPsrvtc2slM=; h=DKIM-Signature:Message-ID:Date:Subject:From:To:MIME-Version; b=lk62Z3ykZoSkVjzKxqedAhAaCZTQ78YD0Ro05S+13gRnHf5Acf09SMppyIjttBWixQBRL1Vr+GjAKUwSyl+7ohTAwKZhGTHGUndgdgZ/660B3P/ukQGKLeRor5k96wG9gj6Hcb7i0hByaVZ4YgtxLZNvRPmWVWIWH92LUElXo3Q= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e8OR3aDFGoO23wffTNA0XZ9/qZxpMNAWdwCY8HBOmOO4pW/PJ6fZAQkDDDZip1Vfd86DnYXN5AFF0Fm7QJTsb3YaYlFGpW5fi4t0BKUpX3T4q5wti2UMW2IX19tBqg5atA3I/lat/XsMY5fLBgr+XflrEskpO/lAkkKUL3DaH/x92QCkneUHKWTOihgePlTt9h95uqktmqBOpNjlKy0qAVZAUgHJrA8WQYdXBrudQs2H4crdWXQ88J9ZCgNRGV2qFTtornvJI23/YZwasnelhBdeSd7DCr3FmrCj9NxXw6ufOKrF98JseiZZXpSpXe/qUwIt9dl+FNg4k+hlacv4eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=smKlmhKM0SyzMtuK9PyoRV/b7GseysEnD2lGZbr4yOA=; b=IM5HUgM/0djL9LGmiZQxIITkiTVv2H7cLp3vNTlSZZ6wjcM73WTp5p8OIvYDZEtLuacP8Q2f2cZ8sJ1fGvURuLtPYimTC3C4fL2rPlRR7JRewCZpuoIH1O4eIO6CDVMIjS603bvTY+Z4M+iQvsKat31MKXkVzpwkIfGd12HKhk9kLBIxndWqmpKc6MFpyMkNDrwILrRGjWYNJOrvKNE2R6WcGQOqG03CiAAtLohpvyJct8sK86Zxp9ZvaAVAi7db04nnCS9/b3rljCTwLBDwKarCLayUdwB63XARBB1xjcJ2b3VHDYSkiGZMVk9xznwKQVHFWxZzOF4REJIJTTXSxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=smKlmhKM0SyzMtuK9PyoRV/b7GseysEnD2lGZbr4yOA=; b=ClpI7nx2USehenHW2JHiF5buUaSBI9zCgaJnE2UophTzWNs2VYrPPzR6ibdcmQTUDOP1IJUp46GAWVHUnsPTvtCevWjiRq2yYHTYCJhNjvwq0+aOFo1O2N67RN7rbd7ytGyiJ5D1wUUgIJAxe6BR9/bvoA1ucouiewWaJ6rQSYelMWB7PNOmzPOmqYZht5F6eCFK/uFTwQ23w9ji4+n0l0O8qLBZUzypL1XcVMEl3UsvRkSzEmc8s2PNrADWBAEZ+R30SQo22cP2+FKfNjYr7P0vImLMCwqVOQ8/WeVxTgVXnRpNH9BHYVFGYm2Qqn0+i8HlU1j/gxav5Q1+S31yPQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DB8PR04MB6778.eurprd04.prod.outlook.com (2603:10a6:10:111::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.14; Fri, 24 Nov 2023 09:06:19 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44%3]) with mapi id 15.20.7046.012; Fri, 24 Nov 2023 09:06:19 +0000 Message-ID: Date: Fri, 24 Nov 2023 10:06:18 +0100 User-Agent: Mozilla Thunderbird Subject: [PATCH 6/6] gas: drop unused fields from struct segment_info_struct Content-Language: en-US From: Jan Beulich To: Binutils Cc: "H.J. Lu" , Nick Clifton , Alan Modra References: Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: X-ClientProxiedBy: FR5P281CA0033.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f3::10) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DB8PR04MB6778:EE_ X-MS-Office365-Filtering-Correlation-Id: e44c2f8d-4ea8-4265-d5f1-08dbeccc9f2d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: slsDcEolHfXXyDLOPrefQaEG++y3MtRePEO73Wy3JZfmN0g0Gqly2cXMfzxXOX+FJx9f8k9/A1OHDX1kBQWQMBIauVIsGvDD1fcUUCkYHmDXcon9DyZ8dfHLVoAJWKiQWGr753TVB7Kk6N3cJUQ/R2+Wtjbw2MnLxfZARGKMAxtJj2r8gQ/BH3cZ9PjCHFsubjmytPyr6/fsbJ+5mVPoZUNyHBYAHzUeTXARJ6hJfZIra2PrB9/hgxSpaKOCLkVGg8XqXox9h78rkkDUa4TkI6P61tddwo7zAaVw66CN8s2qeaZsJfgvCGx254TB4BjvElqE5ZfsQwZIi60L+jCwJcjR/dVBDqgvRw6i2oWfZ6qFvEdpyfCu1AsBaemcYm3LXQcFRg/yMb1bC5Tv7V73dqTNHhoeujMVem9Y2OySB0HUUiqBraeOj5eLhZ8qGnTqstK7pSp2p37UAwE9UcfgjZrPNjWFLVrYixu5yNiI/XqWZqKW3pf/UZTx78Tr7zQ2jNTjptFTI8r+mK32SWCYZGsuPaCMyE1ww3I1eWSAWiHIsbjmG3kYziOOzJgIIiDlKyUSLxJqO8P5PIiUeBoeZb92od6t0kzB7kjhdGJDCGer4C9DBqLTiI3A5dE9FdqKEn52HAsRFHu9Q+NpB3XXfg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8790.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366004)(396003)(376002)(346002)(39860400002)(136003)(230922051799003)(1800799012)(64100799003)(451199024)(186009)(2616005)(2906002)(26005)(31696002)(5660300002)(86362001)(6512007)(31686004)(41300700001)(8676002)(8936002)(4326008)(6506007)(316002)(6916009)(36756003)(54906003)(66946007)(66476007)(66556008)(478600001)(6486002)(38100700002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?s3q+ZBHJUJtC+tSZ3ZWV4Ha06d8G?= =?utf-8?q?Q+laCBT1Eo7NTCwb1xhRu6QaeEsM3dW70YwU4oI7tpawiq4eJaflHxGTAX4f20dHP?= =?utf-8?q?KEyl2Mce66l9SWUDWyHF1vk4HADD6Fp4IAFCvLS4nkko8wD8hFo3wuuGkjZDTRT0G?= =?utf-8?q?r4MQVWzc7HYe28bTv2BNT9AeFIGy0Jqg7Up7ZMEAwEIONLpbM71SHsGymZQx/wE+g?= =?utf-8?q?ci8TMBRgSh4EaWx8/j4TXHe7b9mve/EMFQWBTxHLUKOQ5A7v/WdLPWcyCb5oMk6By?= =?utf-8?q?rw5D8BTgJvmhVwhRnzfnzkvkiDnbaZ0kM+nRFlYcFscETNQdBmdHmTfLsx9vnERZT?= =?utf-8?q?OzqYYmUkZOC3+aa46TGD5P95VLPgACVkcT6D5CIUijx3WUIIl3CyxhGLDGZX9rFj7?= =?utf-8?q?PVIrFT+8VB8jjiFqFL0xd9uJHk7biTSDu5k9cF9tIy23o332yQT0YvnS3lHypFi0b?= =?utf-8?q?nTCUvcBsbSXqCmNNUYEYP180QEBmAJj+FDxKd+udtO2H23QRdGsGKLml6XzZGjdwp?= =?utf-8?q?rv/tpXlmbKOb2VlV44YfpbbtnuFHGe28uRDhaN21QjFSjKpwZeiDwHJnuD/vVxuBt?= =?utf-8?q?S/esFUXryvy40luHFMExljQoYeysz1TslL0n/b5dacqK4/EYtV/z9JDlRKOqIM9TK?= =?utf-8?q?rPn5yCZjpFDTMrVaRl0dSzkJv/8pyUsrFs3HAiPntpD846ikwik/JhZ1G+Kx4PbRL?= =?utf-8?q?tbmA2vBUjN+EcGkX3A30OWCEOtmIY/6akZdSWLFx+W3ybLZQQM4i7D1OBQVD6Md6p?= =?utf-8?q?EJy3zSAO6mNIZIK9AliXZlLSg9mNaW16AkQ6rKlHmqhbWYnxDq0Qst+zTu6yFIbRj?= =?utf-8?q?zL1ATJM7wgHNZDpKA1IWejC2CtGaZaUa3JS0eFCYXCG3fvWnLd9Du53ASLh/JFAeD?= =?utf-8?q?Af4GzZRyxeEOaGw04V/PtUf/MRrxEV5wJMAvDgC/gPOSDY58o7CHlZHd1soQu36fm?= =?utf-8?q?Ly4/J2tHKLbYEdcE9ONH5mthnmYQJSjebw//4e8uFPEkyBHi14U2JtgiX/3EQva3D?= =?utf-8?q?j0NRFwK9mNc38n7h3cbI8XC1JWX+tQjPPIKmVoeG9oF/s03x+WLsi407gzkT7HT47?= =?utf-8?q?QjiXo6mYz6qNymD0/oMY6WW67JDiOTjamBHW0OBVOwTiUJK0O3yReAe5bwxt64ipg?= =?utf-8?q?L0YzWPiUOfuGbx9gDHqamICBMCm5pwRDgqVp0koao5rJSKCUQ4qG9xcBk5JSIdhmP?= =?utf-8?q?Ae0NYd4ydaZHRsPc68JhP7MZjfMhinJUGVMbpDiZUxHn08bG5r3JZGeiKOvKNiNyo?= =?utf-8?q?CWVxeZRC1qxgKIuUJ03tiqwQWA/A+o1jHF4/01MmdyfO8qqRCM3oBMUsoPT1vFqSS?= =?utf-8?q?ssa2OcPTDGbIV5lxo3X8ilvhP/MPIPgXKfN4kAOv/wLMoHivqT7Yie0IYNE0+I/ZD?= =?utf-8?q?ZcwfnTOAo/KRC4+povvGS3evxgQ4nTGWvjef2bkNyqn98Spj+fZ+kl0+cTzEveJGk?= =?utf-8?q?FFNJlteyMcOEz107be4MPxUnQbnQVpncxIvo4hWKYeDRK/WjHblljMkMd4X/1jzqA?= =?utf-8?q?LcXA8BJ8rM/F?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e44c2f8d-4ea8-4265-d5f1-08dbeccc9f2d X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2023 09:06:19.4785 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wL+Jdz+sbyu1izhS6GTfEG48rNz3Yk++M+/kAejzoUzOM7v55ZxflP1h776ZigZTBhPypuUnvpGWn0jwdlIC1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6778 X-Spam-Status: No, score=-3026.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783435665519810755 X-GMAIL-MSGID: 1783435665519810755 user_stuff, dot, and lineno_list_{head,tail} have no users (left), while bfd_section was only ever written. --- a/gas/subsegs.c +++ b/gas/subsegs.c @@ -61,7 +61,6 @@ alloc_seginfo (segT seg) seginfo = obstack_alloc (¬es, sizeof (*seginfo)); memset (seginfo, 0, sizeof (*seginfo)); - seginfo->bfd_section = seg; bfd_set_section_userdata (seg, seginfo); } /* --- a/gas/subsegs.h +++ b/gas/subsegs.h @@ -71,23 +71,13 @@ typedef struct segment_info_struct { there are frags. */ unsigned int bss : 1; - int user_stuff; - /* Fixups for this segment. This is only valid after the frchains are run together. */ fixS *fix_root; fixS *fix_tail; - symbolS *dot; - - struct lineno_list *lineno_list_head; - struct lineno_list *lineno_list_tail; - - /* Which BFD section does this gas segment correspond to? */ - asection *bfd_section; - /* NULL, or pointer to the gas symbol that is the section symbol for - this section. sym->bsym and bfd_section->symbol should be the same. */ + this section. */ symbolS *sym; /* Used by dwarf2dbg.c for this section's line table entries. */