From patchwork Thu Nov 23 16:56:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169034 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp581588vqx; Thu, 23 Nov 2023 08:57:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IF3ivhtEw+xF5lJLoC1Kkx8VADPY0/1eg84ThfEryVKrpPcTMVijD4m554GQkqbKvHZXDL8 X-Received: by 2002:aa7:943a:0:b0:6cb:a60c:2140 with SMTP id y26-20020aa7943a000000b006cba60c2140mr34571pfo.28.1700758662626; Thu, 23 Nov 2023 08:57:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758662; cv=none; d=google.com; s=arc-20160816; b=sjTpEIV9tqERhC/HnUDviV5TgHqVqydywAKRVngF1ol5mjNhMdLaQZPzvknku2O2Qp AxAJUVRTfS0/wRfrpweFXfROmHu/MokHZF6RvLv79EKS80E6X0iSdW8AknPE+GG+1jAq 0wEvEN4G3I5tnly72gE8/1vgNLweRROOvcAsd8Uy5xXlyEWIhNyfUU+yGqetNC/weQTn 0wKkpyQLQJyanbAneO5pYxBdHY4OmTjqsF/x4MJmJAZ1DUixUdnAA1QCqIOO4plGCnDq 5ExD9OWySE63eSkf8HWUE2GY1UA0/qXeXwLtAbp0fZq+ziPTXohbtn2PNRb3pwyljhtJ WXgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=boVbWvWJHlv8YNRSrUwzVySdxCantJGXBGJSbUT2MYc=; fh=tyeAz5h/TvcNAD5KNHAE9Tt2iqQFJWSDN8VOXemqabc=; b=qRnZ9Bu0+ZovR1J0oFQgcxCcIJ+8DIsSbC/BoGuTiVrvqlfYtJb68HL9i7hKrlxf4Z xWxas24KcxBpCLwFQlCadVPzaXo0qrcY1UX4MBx9jlavMzReJHRwNuXQv31z/1hbl+vj MtjY3u+p5h0rRMZc0dbCmjV1o0qIsG2DKT1IrxEAT7EW2XCwXprjtjJd4UoB46UFRYnI xCZgwhYDYRFBhdr/IXlVnZrKc7RKZI1J+zzxC8017B2nCZUcEd8Z5I/TmrVJiFQCoeS0 V2+vfY7POlUepyIkdpOl+8WMgcn8C+B3P5EwbHPzzf9PlHFsgiGNR3SCUBgEScjiHLIB vIiQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id a3-20020a056a000c8300b006cb50097712si1603169pfv.332.2023.11.23.08.57.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:57:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 26B5C80659A8; Thu, 23 Nov 2023 08:57:32 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345286AbjKWQ5N (ORCPT + 99 others); Thu, 23 Nov 2023 11:57:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345140AbjKWQ46 (ORCPT ); Thu, 23 Nov 2023 11:56:58 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F0CDD46 for ; Thu, 23 Nov 2023 08:57:04 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0c-0004z4-Mw; Thu, 23 Nov 2023 17:56:58 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0c-00B54W-6j; Thu, 23 Nov 2023 17:56:58 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0b-006oz6-Tm; Thu, 23 Nov 2023 17:56:57 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 01/18] mfd: ab8500-sysctrl: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:29 +0100 Message-ID: <20231123165627.492259-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1805; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=GS/UqHACqLFCxsb5xvMGweNluQ8cR4neHNMyqaMRa+A=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4Q8Pj9Sc/wSXZDMbwzL63aYnjZfexGCMhFLF N+Wdhi9HoyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+EPAAKCRCPgPtYfRL+ ThPdB/9f+Oj9hJK9NQybB41yGJvXzMIFj7Y8br+9cK9ocBHzrv4K7Kr0AzVw2ZFitdmQ+nYcs3O E/iMaKg0LCkOAUrTWi7lVUoKCVuW4uDJxBDnNxOFR08TaEuCCEZfO8Gx98J3nXsrQtOQp1gi6wo Pnm5a5F11ePtKNv/9U4brWz5qqC0wlOtvWvZx/PtT9/SbhgLPetfFw16RM1/mYuISR4/pTF6ILI FqHGj8caN09Knp0pMJdUbE9aQQcQpYQwCFjSOTQ+VyY1FSWZFTFVv1ULELcIXo3B1osTNG0V0+1 vp6DmhDpDqYv22iB9B7HlflLK8YdnfaYmZiONZr1qyV9m8d8 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:57:32 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374715147342014 X-GMAIL-MSGID: 1783374715147342014 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Acked-by: Linus Walleij Signed-off-by: Uwe Kleine-König --- drivers/mfd/ab8500-sysctrl.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/ab8500-sysctrl.c b/drivers/mfd/ab8500-sysctrl.c index eeeb62415f53..ce81fcb785d0 100644 --- a/drivers/mfd/ab8500-sysctrl.c +++ b/drivers/mfd/ab8500-sysctrl.c @@ -140,14 +140,12 @@ static int ab8500_sysctrl_probe(struct platform_device *pdev) return 0; } -static int ab8500_sysctrl_remove(struct platform_device *pdev) +static void ab8500_sysctrl_remove(struct platform_device *pdev) { sysctrl_dev = NULL; if (pm_power_off == ab8500_power_off) pm_power_off = NULL; - - return 0; } static const struct of_device_id ab8500_sysctrl_match[] = { @@ -161,7 +159,7 @@ static struct platform_driver ab8500_sysctrl_driver = { .of_match_table = ab8500_sysctrl_match, }, .probe = ab8500_sysctrl_probe, - .remove = ab8500_sysctrl_remove, + .remove_new = ab8500_sysctrl_remove, }; static int __init ab8500_sysctrl_init(void) From patchwork Thu Nov 23 16:56:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169043 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp583936vqx; Thu, 23 Nov 2023 09:01:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IHncVE7M7D1uMLeEtbYBp65CXdYsVK7Kcn6RbYCVpIxYRt6IJFoB5I94g36qJGW1Jc4Xv7M X-Received: by 2002:a05:6808:181:b0:3a7:1b28:4bc9 with SMTP id w1-20020a056808018100b003a71b284bc9mr6299742oic.54.1700758885255; Thu, 23 Nov 2023 09:01:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758885; cv=none; d=google.com; s=arc-20160816; b=BMsG70KX8wbseh2QB2pYR4wCi+lGggUGPGaii93ZeMWIoMptKhXE8+UvdgIBQKvU9g cHhTNE4FWNdbQQzRYN432MxgGvYPw2JplZPPv6rN2a+bG7JrBxZMLB1vI2Z2U5+r8G+u hBrK89UF8OIAW6uOhwIZie2yA7XdVpplHm1xXT7oRwFoO5mq86s3wlJ2WehW166n9o7K wJmVVGBSIxetbhzv1DYfsgkInp31VRhj6t+ARjnWGzUb3pPCglzVCuc/sIJRlp3Ss27E 69jf9cubfPvbtefkglfVRMxU1nIboaf5998vZzBFIb9qgYE3pdAIkEory0+lvPBDxu6p +sYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ZheSiNts4rCg/qKQSdeGyTFEG9ta0VByb8ksP4/T67k=; fh=Pb0YFf3Qb0jiyU9w8FvUhRt9p1tOuz1X66bA4DIOFKo=; b=Sl3MImOegiW4COy/PN0BqvYXU+tx+3GlEbV1/JJdU44R5P0HrvQ/Y2pggoWh7kmwYd OQXrKjmcfZC7m732wQvhXZdG+UwsC9WpWsdCwqn+H6iaLMVMVviZrV0lKYeLL5ddIP1F 5qoJnmmh7OQ1/d8+FuUHzpsRMDraPXKvVGESNQXCaZrGoUVku7Z7DpCI26ir6mfWTHL4 1YdKeJfEKSBueKmSlJHgdZWIMsigkqpOyRykX7cfcCTDPEcgZh+AyIYEW8I+YJTj8QBs ujPuSpd3EUkir2hNXPjKZWSzg+AjHqX4mNuJJ7UhzDk4SVRdVikG09jbxzxzyQL18jFl 6PaQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id dl3-20020a056808614300b003b6cb6a18c2si563835oib.211.2023.11.23.09.01.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 09:01:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id DF1AB8030B9C; Thu, 23 Nov 2023 08:57:53 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345188AbjKWQ5V (ORCPT + 99 others); Thu, 23 Nov 2023 11:57:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229970AbjKWQ46 (ORCPT ); Thu, 23 Nov 2023 11:56:58 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F5F0D48 for ; Thu, 23 Nov 2023 08:57:05 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0c-0004z6-SO; Thu, 23 Nov 2023 17:56:58 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0c-00B54Z-FD; Thu, 23 Nov 2023 17:56:58 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0c-006ozA-5t; Thu, 23 Nov 2023 17:56:58 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: Benson Leung , Guenter Roeck , chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 02/18] mfd: cros_ec_dev: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:30 +0100 Message-ID: <20231123165627.492259-3-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1720; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=LCw3bj2aWliMJeRhvUQKWZ55KhVQThCiahgEmDcwN4c=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4Q9cxZ+4UCl/GvDKW8mubt9953vOUXfszBV1 wxXWkcEyzCJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+EPQAKCRCPgPtYfRL+ TnSGCACPvoDxVg9509CpoLILWkjmQePD3RgHtDcRoR7vpXswXCrpfuxJ0LgJhErkN9IMJwHLJCZ n5MH/d47hy4AAlYyGpVfRdJDAaId5dQHOIC6qcmZh8IUKbJ+I4oFt5ReW2XRjvPZJD6SuE/HMIn m97u6S+ZX0DD7ELI5VFlmtH8lyt3zN6niBuAvpMc5aR0l+yGGUDuxto0cg1r19oGht93TgQUZJB bnuZFTb6XFh/A0ewm4kADppa6R23xUdDqI+I9J/wv1rF5Q8uOnVPQLBHM4jfZ9uqdEz7dNbHoPb BKvxqOcnohoCSeEKMHyyLOhGrMIytQKUsZ4X3M/BFwQ42KxY X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:57:54 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374948532531094 X-GMAIL-MSGID: 1783374948532531094 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/cros_ec_dev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c index 79d393b602bf..603b1cd52785 100644 --- a/drivers/mfd/cros_ec_dev.c +++ b/drivers/mfd/cros_ec_dev.c @@ -288,13 +288,12 @@ static int ec_device_probe(struct platform_device *pdev) return retval; } -static int ec_device_remove(struct platform_device *pdev) +static void ec_device_remove(struct platform_device *pdev) { struct cros_ec_dev *ec = dev_get_drvdata(&pdev->dev); mfd_remove_devices(ec->dev); device_unregister(&ec->class_dev); - return 0; } static const struct platform_device_id cros_ec_id[] = { @@ -309,7 +308,7 @@ static struct platform_driver cros_ec_dev_driver = { }, .id_table = cros_ec_id, .probe = ec_device_probe, - .remove = ec_device_remove, + .remove_new = ec_device_remove, }; static int __init cros_ec_dev_init(void) From patchwork Thu Nov 23 16:56:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169038 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp581727vqx; Thu, 23 Nov 2023 08:58:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IGA+3rwyUmVCMuJdBdREFV+Wo8dxGEmjad27xNnANeO46WMVccKFMjwhJZEmSnQPFJuzB8Z X-Received: by 2002:a17:902:ea10:b0:1ca:505:8c86 with SMTP id s16-20020a170902ea1000b001ca05058c86mr114575plg.20.1700758683471; Thu, 23 Nov 2023 08:58:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758683; cv=none; d=google.com; s=arc-20160816; b=jewZ55gvxjMOInePDNGbFy9o0kvEWDVcRGv/oB0hMQi1RHZ0McpH0NaJ5ZW9SnkQlj 1GNLY4y6DMyNzha3ECwBY20DlYtZwH2eYjiJwsVklw9xf8OuXOA4g/0SqWuB4Kek1hOW 6zLMcsseS4djNBGfaKc+p0GkxM1XYmU9bfugTK8cRWcTUZwGY9ruqU7K80FcmnuAWY+p 5DkKH5hje0xiGwXQd9DBOLOSp43kTfJIhOnnhRnbjiFh+JMkkUoq/xShqGHQoReOwQMI dXsDAt0rU+rtQAxNz6pCDorKOjv1HBBMSnuaLYkF9aJGcaivK/Rl8gg3eyEbavU6ylc4 GSNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Zt/C6viJeJbnEr2HEGFZLy2GDu3PuJUv8OdDWwF+NCE=; fh=D9qxE4/pZwJgl3gt/KCsRLGRT26DHlQ+CQvdrxUfoaI=; b=Jiku9X14pQliaPDlDSIjny7D1Ox2OMN9RY4LgpXNa++LnGMoWF+TOIirfqBB9fFpKx 32sQgFsQ14KUck4k3DWa7hcHtLW8WMtWMjtYM3kdNDG+Lqd8Y3TM0GgdTgF+MXvZMih8 d0AwPKt3BvtcSCYcU4MewhMbtJke3yorxJJxWKxtGqRyzVPdZQA/FzntHmUI42CfH/pC Iux4ip5hGuvhTaVooMZML8vWw1DDahcbYn3oNbzIuwzesxMWm5oCemsPIrAnCwid7OIF FxVtH4WZQER0W/FJIYmqGS4KaNHEWGZWao9fEOienYmNeYrvU4ccMwcRumjlcTYv0SAL qYyg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id d7-20020a170902cec700b001cc0fdbea2asi1185955plg.142.2023.11.23.08.58.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:58:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 7C536806C626; Thu, 23 Nov 2023 08:57:57 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345308AbjKWQ5q (ORCPT + 99 others); Thu, 23 Nov 2023 11:57:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345231AbjKWQ5F (ORCPT ); Thu, 23 Nov 2023 11:57:05 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C1F0D69 for ; Thu, 23 Nov 2023 08:57:09 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0d-0004zM-HJ; Thu, 23 Nov 2023 17:56:59 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0c-00B54c-Nx; Thu, 23 Nov 2023 17:56:58 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0c-006ozE-EW; Thu, 23 Nov 2023 17:56:58 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: Krzysztof Kozlowski , Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 03/18] mfd: exynos-lpass: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:31 +0100 Message-ID: <20231123165627.492259-4-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1928; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=hnM9lEd75w6pk/CQsI0uo+SpHXcPuNXW4NABO1kOboo=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4Q/qyjvQ43nqvF9ocHlWxZZXet54OMT5aOkA uSKIuL0GwGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+EPwAKCRCPgPtYfRL+ TknVB/4uSQ0b234ec72Txk+Vlps9O8AcJebgCma7EmgW5jEYa1OPXCGpHeQJsDnbKtDGS1zoliO /rJZGKGn6mpl03yOiScaZ3/U7LRw4+0XBVdlQOzNLx0NBFlGlraSE/SJT6BdfddFa+d8zj4L0qT pjH7I+orwLRpLIzFaN3DkM7nbLjhz6CvN5q3B4HZ56/aJMnvLBhbej5nC/We7R9JZ7LjhXfkgAL 64vjTOVPe/1ZX9CWT+2h/z+IAPm16jKiRTC9Hvo1mSupnH5ZfLU784ktR+aOV4f6Ir9g1AQKiMM Vb5KOHn2nL4JVXd1ylKWriSiPxUtz650GTAMakowHelSx4rG X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:57:57 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374737354478999 X-GMAIL-MSGID: 1783374737354478999 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/exynos-lpass.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/exynos-lpass.c b/drivers/mfd/exynos-lpass.c index 1506d8d352b1..e58990c85ed8 100644 --- a/drivers/mfd/exynos-lpass.c +++ b/drivers/mfd/exynos-lpass.c @@ -137,7 +137,7 @@ static int exynos_lpass_probe(struct platform_device *pdev) return devm_of_platform_populate(dev); } -static int exynos_lpass_remove(struct platform_device *pdev) +static void exynos_lpass_remove(struct platform_device *pdev) { struct exynos_lpass *lpass = platform_get_drvdata(pdev); @@ -146,8 +146,6 @@ static int exynos_lpass_remove(struct platform_device *pdev) if (!pm_runtime_status_suspended(&pdev->dev)) exynos_lpass_disable(lpass); regmap_exit(lpass->top); - - return 0; } static int __maybe_unused exynos_lpass_suspend(struct device *dev) @@ -187,7 +185,7 @@ static struct platform_driver exynos_lpass_driver = { .of_match_table = exynos_lpass_of_match, }, .probe = exynos_lpass_probe, - .remove = exynos_lpass_remove, + .remove_new = exynos_lpass_remove, }; module_platform_driver(exynos_lpass_driver); From patchwork Thu Nov 23 16:56:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169036 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp581686vqx; Thu, 23 Nov 2023 08:57:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IF01tljV6UfZxDwaXBDtBwqiyuM4yUoAqi12ao9QJIcdxOegCOzag+LJc/pYqabaV4Ol9+A X-Received: by 2002:a17:903:247:b0:1cc:31c4:377b with SMTP id j7-20020a170903024700b001cc31c4377bmr37684plh.63.1700758677906; Thu, 23 Nov 2023 08:57:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758677; cv=none; d=google.com; s=arc-20160816; b=r0Lk5+qUkInChkDjbYu5BYhMSk9zDO21GRg1b6/qxxl1EJUZPGn6hpiNbJ1rOQ6XK0 5VspWeah/YpZNNcEz3bdpjzC+42wYCg617zWcdnBUT3riRlLoUIKGG/y+4SabvBN3HMI dGb3XbunUwnlK3oZeQVvFyez6Dm7bnc/QwSTJtN6X8Fd6g8ZgZcyungYEYbhXDk11w8R H0ixdS3Ol3EO16KTkAlykHFfAiKWpUxgcR/ne7n/1fH5iNOmwY4F3YgufzibVtKvTkvc KaGcoIHXrzWaFYNV9EA2x/4Vf8DPZIIZ7+l/EX802i6s//p2ighwMeiCsNZ9c040k/br L0fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=nmdQO+GhILkGYlOJqOA9i9CQJU8sdyFdE1w+7jrQmgA=; fh=cIjNq8AJ7DYG+w9Jtcuz1ji5cufJZKE/mbz7BhfN7Sc=; b=oTvkqveIC9Al4LxkiAPk6Khfl0F50GjJOZCCoZfmiKroE5Fr14I3jpTy/FKnGgyDzw iHC6KHRA5d63scVu1lJJ0430el4hLAtWqaGQqKmTMs4bDNPkMYiukxuOKmFVjOv+4Cdd iJD8jPpy6DITY6WqF+iLx4qhkqd4M2TI9vWetAhNCQAzrnZoN0Ix7FrvJF/KbMPu53Hi r2sFvG9y8rY9Zt3KfPgvlCtB2rbmK8IDYS30qM7+BxzyGd/Yxpqni/DOWLiGAbls9LYV fJ42OyC9FE+Hmy4DCwU7/oxg3m48chhKfP4tllaB8B5z+fCOFA5bm20pEnZoQzsn2EiT 5dSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id jj14-20020a170903048e00b001bf1d1d99b0si1457013plb.568.2023.11.23.08.57.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:57:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 117868260C34; Thu, 23 Nov 2023 08:57:52 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345346AbjKWQ5g (ORCPT + 99 others); Thu, 23 Nov 2023 11:57:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345208AbjKWQ5E (ORCPT ); Thu, 23 Nov 2023 11:57:04 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50963D64 for ; Thu, 23 Nov 2023 08:57:08 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0d-0004zQ-Dl; Thu, 23 Nov 2023 17:56:59 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0c-00B54g-UL; Thu, 23 Nov 2023 17:56:58 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0c-006ozI-L1; Thu, 23 Nov 2023 17:56:58 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 04/18] mfd: fsl-imx25-tsadc: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:32 +0100 Message-ID: <20231123165627.492259-5-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1657; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=H9E4DQumuJYM4xGNsjymKWQwrBqvaE1jdcSqA7stR1c=; b=owGbwMvMwMXY3/A7olbonx/jabUkhtT4FocGfaaOewzxfHtil1sf2aDbr83dc66GIdswU79qe vUGZsFORmMWBkYuBlkxRRb7xjWZVlVykZ1r/12GGcTKBDKFgYtTACbCls/+z646rGhr3C5Bjiks tW/fztmy8prXz8TGDv5Fv1UupnQfCV7jfkixwfaWSoN7z5ZWjd0/1e/ZNvH8k19+S137VH6C7Cl FhijdjHs6p8Ks+hgFItikJWRiTyasrTul9Gzt2tfxEpqppwy0vj5dIRWl9/h13+xQ7ZslW4Wb3n C8Nly/v4J1Z1zirq0xrXXLj0uc3bRDK3DTh8s8bT/kBcI8OXbNv57JL7F2VrihxckViQbCoU9qK 7juPDu1ef1vu3sTi+dnL7lW6v0mSO+0kvWEFc2cf2K49HQXzrRbPLmWXTM+RfSi5xMhqfXckYLF nxenrHE048m68tzQ4Pm0xgvTgv4WLHgbsKKnYu2V6DUdAA== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:57:52 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374731167738782 X-GMAIL-MSGID: 1783374731167738782 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/fsl-imx25-tsadc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/fsl-imx25-tsadc.c b/drivers/mfd/fsl-imx25-tsadc.c index 089c2ce615b6..74f38bf3778f 100644 --- a/drivers/mfd/fsl-imx25-tsadc.c +++ b/drivers/mfd/fsl-imx25-tsadc.c @@ -194,11 +194,9 @@ static int mx25_tsadc_probe(struct platform_device *pdev) return ret; } -static int mx25_tsadc_remove(struct platform_device *pdev) +static void mx25_tsadc_remove(struct platform_device *pdev) { mx25_tsadc_unset_irq(pdev); - - return 0; } static const struct of_device_id mx25_tsadc_ids[] = { @@ -213,7 +211,7 @@ static struct platform_driver mx25_tsadc_driver = { .of_match_table = mx25_tsadc_ids, }, .probe = mx25_tsadc_probe, - .remove = mx25_tsadc_remove, + .remove_new = mx25_tsadc_remove, }; module_platform_driver(mx25_tsadc_driver); From patchwork Thu Nov 23 16:56:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169029 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp581405vqx; Thu, 23 Nov 2023 08:57:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IHf9MMUHfZHuxiuYZup7VMRpgrba+WHyr7eWDaOGPj424LyssP1suopnsv9HnQBN0vTY3mc X-Received: by 2002:a17:903:22d0:b0:1cf:696b:1a7f with SMTP id y16-20020a17090322d000b001cf696b1a7fmr144109plg.0.1700758638020; Thu, 23 Nov 2023 08:57:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758638; cv=none; d=google.com; s=arc-20160816; b=TGqyBqWpj5WpaSNJchnnGk4zs34SyCK236J4QFj81GmSz/kGhsewmTqhsFLcA4rTes F7ojIx8q7RqygeglT02lJPusf5GY6ZnOxG1hzxjf+DCmWuLP6ihi+A3MPCbSW3dXHy45 KSDXcFHNUsdmEqOgLUlSQ4uSCLmFteotZzj7APQ5V1gETa/wyRMBI388nbMoqmtOk04a xH+o9RBLoGLWbSZ8UOC09Yc0c828CjQNfT8hsr/DERL5jybyHdqeMg47yUq3NAhstlPp Q37ZnOR1vfU4gQAruVvV7eXgW9L4IAjSrbgOjOMtQXywKZrQx5X2Hq989IN2lx0saYBj z7og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=S6KAYq9D0deJY3F5emrtEOD0Bu/J2/oXLsIIYMngVw0=; fh=Zdg/IaJWIkan+8kr6bDKmrlAn6GL271tZGmx1ajMHC0=; b=rFkgcXr7Z5XlRCMoNZaZ1yix/3NymIvjumIRlggYthx3knStqKNMbnoqLLMqlF7DJf ivXA4b9rdi2k+9/QpEzYkdyBqocd6nUNthHrYF7I/y1/IXNnhQ8m/fVJXVyMwM799GIT CYRSFCM22hQoLQb67YM+ciMUOg19ayR4Z0XCpbk0fwWdxlbJY5/sRdlSHD5+iCYFPfZz JudjEQlHcFEKfs8H+d+BID6UQpEC97GhCWMSYO8cBRB6XKzVhF6Z97IhryVDK6G/gXeQ zNrpRBvf4998wjnsxEK6ZDShEsrOC0vx5nXyicJOcQqZZ/7G8s0i7EOV8rCPTC16fmZG 5Q5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id s13-20020a170902b18d00b001cc3473657bsi1443895plr.215.2023.11.23.08.57.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:57:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id E7925824E53D; Thu, 23 Nov 2023 08:57:05 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229949AbjKWQ44 (ORCPT + 99 others); Thu, 23 Nov 2023 11:56:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbjKWQ4z (ORCPT ); Thu, 23 Nov 2023 11:56:55 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37587BC for ; Thu, 23 Nov 2023 08:57:01 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0d-0004zR-IT; Thu, 23 Nov 2023 17:56:59 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0d-00B54k-66; Thu, 23 Nov 2023 17:56:59 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0c-006ozM-TS; Thu, 23 Nov 2023 17:56:58 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 05/18] mfd: hi655x-pmic: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:33 +0100 Message-ID: <20231123165627.492259-6-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1778; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=dI9I7gz8/r2ZcPCua/AplnWUDrg6g0W/Uk6MlFqZHHs=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RB+83Rz11Z6/NItwJ0/Z2CF9epAbSH3zyAJ bGInwhPFXeJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+EQQAKCRCPgPtYfRL+ TkNtB/wOctIRHw/GpGBKwLcWP5+UlhVikKuLUUUSBgs3bn3C+ji2CoY2cc56deEZZE4k5Fd7MGM /ae9HmULVtrQu6GSj25QNZna4hagUvC/NNFcDNbJ30cMxve4yqWRilnBqKKV5Napyc1dFgwiiGE cKT+l2u9f2FN1qHCxvW/ATkHT6zlXJPkUcJqhV1IMHRPN/q71spl8z3K9gsI0mmY1S3PnN9IsXk v3GqUubRdIGafZl75/bHxHOMkXRNLF+sXhdbNeJ9dRzO77PI71gbn+QtRzrAAdlOa+N44N20QA6 JAMBUPoxPHrt25mXDUnYv1y92yIivSmpLYmHoZYw9oRCkAa9 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:57:06 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374689524974672 X-GMAIL-MSGID: 1783374689524974672 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/hi655x-pmic.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c index 8feae8d8fd9d..042109304db4 100644 --- a/drivers/mfd/hi655x-pmic.c +++ b/drivers/mfd/hi655x-pmic.c @@ -144,13 +144,12 @@ static int hi655x_pmic_probe(struct platform_device *pdev) return 0; } -static int hi655x_pmic_remove(struct platform_device *pdev) +static void hi655x_pmic_remove(struct platform_device *pdev) { struct hi655x_pmic *pmic = platform_get_drvdata(pdev); regmap_del_irq_chip(gpiod_to_irq(pmic->gpio), pmic->irq_data); mfd_remove_devices(&pdev->dev); - return 0; } static const struct of_device_id hi655x_pmic_match[] = { @@ -165,7 +164,7 @@ static struct platform_driver hi655x_pmic_driver = { .of_match_table = hi655x_pmic_match, }, .probe = hi655x_pmic_probe, - .remove = hi655x_pmic_remove, + .remove_new = hi655x_pmic_remove, }; module_platform_driver(hi655x_pmic_driver); From patchwork Thu Nov 23 16:56:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169030 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp581416vqx; Thu, 23 Nov 2023 08:57:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IH6gXsuNlQyiA4YpU67q4CmVKZRAiWi2dMSeQIX7snbrrdBj1oay3DELHfs0rPNmXgbf1Ig X-Received: by 2002:a17:90b:33c3:b0:281:19db:b5a7 with SMTP id lk3-20020a17090b33c300b0028119dbb5a7mr32861pjb.49.1700758639466; Thu, 23 Nov 2023 08:57:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758639; cv=none; d=google.com; s=arc-20160816; b=XLRadt5FmPchy+ZA7widVy3EpRy0h1MpqnADCk7HKaKPatNK49V7t2R/701m/mumo7 FsBNXoAV6VTeOxz8n/Z1lqSosxW+lQch0UG0AFHAqHfTgopeTu7VifC7tQj2UWLQ5KHQ ZjgGmoOgZ/Rc5/pGMsSWUD6XIislIP08us5rF/kbn1mBpNGIdxKO9X+QUyHCXlgIHg4P WzX60oBt5y1vB2cHXSsOwesljrN6D8y/1Dx5/mre3M2oUor8Dkt+u8BNoqWLOAld6Oa6 qcFeIU+mhYOOW6+GTpeGzY+tnw8rPavpzNY1ApSc+i/OskP+ic0ngOWk7KCyATds2cSF 7pdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=zQAHI372AUVVJ1OB+OtHU1kxIYazri9P+mUkLa4FUVs=; fh=Zdg/IaJWIkan+8kr6bDKmrlAn6GL271tZGmx1ajMHC0=; b=pgGIsPzvxjsczC0sVuFByXZCghK423mqN5THoEezWTXlSeQi1d2c0Ytj5gmeCNqYA+ mQuR7HmRnMSyn2MYShO85J9Tw6GqeQBnmsUPKnW28l2222xMWau4VUAaHRQqLZVMKR9v KG0rfwxHzLlQBK1aCODmQOwGplBLTxVm+U5htnZVh6AL/xKM9/epdGmJkCChMzsiZ3RG aAfxPTaTi2xOso2dQOuao+KWAgtpO7jRSkMlAcDZUrW3X1Nk4y0CsSovTCFp7YBd6ZjO 4onOZUJWxM1CqKfOf93mWb3BcbypS6CbosEv72P8C3J+MCqRmG44NAQUS7F+7vRx36wB Z42Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id o11-20020a17090ad24b00b0028515bd32a2si1680808pjw.81.2023.11.23.08.57.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:57:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 1113A809AF91; Thu, 23 Nov 2023 08:57:11 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345166AbjKWQ5A (ORCPT + 99 others); Thu, 23 Nov 2023 11:57:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229921AbjKWQ44 (ORCPT ); Thu, 23 Nov 2023 11:56:56 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 720E8D42 for ; Thu, 23 Nov 2023 08:57:01 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0d-000503-Rr; Thu, 23 Nov 2023 17:56:59 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0d-00B54n-FI; Thu, 23 Nov 2023 17:56:59 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0d-006ozQ-6D; Thu, 23 Nov 2023 17:56:59 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 06/18] mfd: intel-lpss-acpi: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:34 +0100 Message-ID: <20231123165627.492259-7-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1698; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=Sme7QalM7Fxz+h2W/iOt36fGZfq+w2Qz9J3kQwKy1O8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RCnfCgkDJiIE25/oCfSiIzC5NO848BrtAnH ZyBqiDPe++JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+EQgAKCRCPgPtYfRL+ ToMQB/9Usf5Erf+yrIvwTJja/sV0wyLm7NbGOq/oPD0A6ULzpXEPJXuTuLFzeI+pUQ1izKzIpXX drtfihdCoaAjmIpQ2xlGLJF68i4FohnxMOUI53PnpT2LX7AzWA+g+EUiuldK/u1JmsPMf1kJNLG eiQDV7FQ5EhP+eZbiHSddN3ddK1mR99Ps+2lGCxnuq8/5fmdYe/56ds/hkTJu6fR2yIogyVbQWx AHBac4/+1LERCvnSy4ZkCsdy5K12f3VcJiPMX11dl/8BKpKzC+bnxraJTr24FHc8QtIY4faIWKr r39ArH582zRPo5wsmp1wUA2YZcJkh9BoWu7DNoISukGYB1gT X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:57:11 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374691286450303 X-GMAIL-MSGID: 1783374691286450303 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/intel-lpss-acpi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/intel-lpss-acpi.c b/drivers/mfd/intel-lpss-acpi.c index 212818aef93e..5184fd1a5df1 100644 --- a/drivers/mfd/intel-lpss-acpi.c +++ b/drivers/mfd/intel-lpss-acpi.c @@ -198,19 +198,17 @@ static int intel_lpss_acpi_probe(struct platform_device *pdev) return 0; } -static int intel_lpss_acpi_remove(struct platform_device *pdev) +static void intel_lpss_acpi_remove(struct platform_device *pdev) { intel_lpss_remove(&pdev->dev); pm_runtime_disable(&pdev->dev); - - return 0; } static INTEL_LPSS_PM_OPS(intel_lpss_acpi_pm_ops); static struct platform_driver intel_lpss_acpi_driver = { .probe = intel_lpss_acpi_probe, - .remove = intel_lpss_acpi_remove, + .remove_new = intel_lpss_acpi_remove, .driver = { .name = "intel-lpss", .acpi_match_table = intel_lpss_acpi_ids, From patchwork Thu Nov 23 16:56:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169033 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp581585vqx; Thu, 23 Nov 2023 08:57:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IHeyLhnWWIy0qra4n//Lvj3mDyCG2YRZE6Q68+b7NQioEDLfCe9oafacOCJcvFsS14S7u/m X-Received: by 2002:a17:90a:e7cf:b0:280:215e:7ae2 with SMTP id kb15-20020a17090ae7cf00b00280215e7ae2mr96237pjb.2.1700758662296; Thu, 23 Nov 2023 08:57:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758662; cv=none; d=google.com; s=arc-20160816; b=rDG3hDuugVoz9DX8i8dKGuU2LBQX0klH0AD09T2WSnPcIRYZz1OGOnIyBy1npWw6Kw kQh7ipE51zUwgoyIjYKtMwG/7AS+qaTL4+3klqjIQFJVMODPIJIVVf/nv/Xu5ED47wc7 KtZH0ss+/CvAbU61L09arWA5KgTbdsV47mi3QBd53SYAwBifz+eA2VGdKMa+Tjs1WMha Eq8dlIdzu9w3LVl/+SONCqLlQDJ7rhJoTJHPuL+3m42z92Wk7rIP+saPBwZm4BVGzKfX uLGGGZpPrf4fJFU7cxlSZKZ9WaXK4gFTkx0qdLn7kvs6XBa+LapN9h7UTF0hXL6g7X6N Gaew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=xuzl0oZcVQrevsPyZssuMk40bkqg7ew8yvEeT8CEi9E=; fh=Zdg/IaJWIkan+8kr6bDKmrlAn6GL271tZGmx1ajMHC0=; b=nYltDTqfIQGIwl6mKDUKz2BNE/ecPXAHSISYb6MvUEYcI42rHRLHc5KynAKwDsDYSR +g56mc1vUBL8MNhoJ+UCKbxA4AVnRLYErp8Lf/ubEyI/Al0rHpfup4rUcbC1RC+EXa7y qdVD6Sni6Gkh8QPzF+3/TCyMmYIOVl8gEFEh+s+ybFva92VMyuZXlZlgzt3njF1wEktU Y1AtiKDdlNy0toyx+SDdAVuHzuZXtNHic8qHVvXg0XczMGcWI3G+4DyRwv54ViPoYR0I RnAF0d8VXKTgrk0NYIPZurq1x/CMtqjQdYxfqkAjzTIiVJwleFbBoqqUm0Uge57exkgB o6mg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id lp6-20020a17090b4a8600b002803af4c4f8si1738309pjb.74.2023.11.23.08.57.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:57:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 22A2B80659A7; Thu, 23 Nov 2023 08:57:32 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345187AbjKWQ5B (ORCPT + 99 others); Thu, 23 Nov 2023 11:57:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229519AbjKWQ44 (ORCPT ); Thu, 23 Nov 2023 11:56:56 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF8D2D46 for ; Thu, 23 Nov 2023 08:57:01 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0e-00051H-6o; Thu, 23 Nov 2023 17:57:00 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0d-00B54t-Or; Thu, 23 Nov 2023 17:56:59 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0d-006ozU-Fw; Thu, 23 Nov 2023 17:56:59 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 07/18] mfd: kempld-core: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:35 +0100 Message-ID: <20231123165627.492259-8-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1898; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=KmijBtfkuKurQFpbpsAneLTGXJS1Jnusah8kZowlcJE=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RDkwUEr6r4st/+YMwIR6Z1awsT9exPwbnm+ tzt0Lu8yw2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+EQwAKCRCPgPtYfRL+ Ttn6B/4ufQ06c+9PQx3uvAkc7ww5TKk0Z7pNN69ibei2pGdkYQWM+s0VKB7rz0SBrWrltLOR/6G FKF61LS1f3IlHxPf5cplsK0Dcb7K15gmy7wdJ7C+un3FEA6ISQMk2ZwGQklHzCRuWn+pudJJJYR Zac1NvgcYdSWbl/CArFuX1NIa7gLd1z4S3b/5mMtDqtMsMEDeweLqu+7Li0nbqxvD77uzi7tDd+ JrVmtmMrTMJWT2wJ7fj5/Et0pFFXkonZrXjw2t2hg9TNuPjDeYbx1D7c2mBi63weorU0GFCIRXg +34765A/6ijn9ryLfJ0JdzdATOibqh0YhNhNCp1JqkusDJGE X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:57:32 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374715208591334 X-GMAIL-MSGID: 1783374715208591334 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/kempld-core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c index 33c6cfe9fe42..67af36a38913 100644 --- a/drivers/mfd/kempld-core.c +++ b/drivers/mfd/kempld-core.c @@ -535,7 +535,7 @@ static int kempld_probe(struct platform_device *pdev) return kempld_detect_device(pld); } -static int kempld_remove(struct platform_device *pdev) +static void kempld_remove(struct platform_device *pdev) { struct kempld_device_data *pld = platform_get_drvdata(pdev); const struct kempld_platform_data *pdata = dev_get_platdata(pld->dev); @@ -544,8 +544,6 @@ static int kempld_remove(struct platform_device *pdev) mfd_remove_devices(&pdev->dev); pdata->release_hardware_mutex(pld); - - return 0; } #ifdef CONFIG_ACPI @@ -563,7 +561,7 @@ static struct platform_driver kempld_driver = { .acpi_match_table = ACPI_PTR(kempld_acpi_table), }, .probe = kempld_probe, - .remove = kempld_remove, + .remove_new = kempld_remove, }; static const struct dmi_system_id kempld_dmi_table[] __initconst = { From patchwork Thu Nov 23 16:56:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169028 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp581356vqx; Thu, 23 Nov 2023 08:57:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IGxuHQpcFTVzTDtwZ+TerlfZlaSXo5N3+XWzxsTjsiqcFThA9CX2X3SngpIO3U5D2LYUbwH X-Received: by 2002:a05:6a20:3c90:b0:180:e3f1:4f60 with SMTP id b16-20020a056a203c9000b00180e3f14f60mr183538pzj.45.1700758633703; Thu, 23 Nov 2023 08:57:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758633; cv=none; d=google.com; s=arc-20160816; b=w8UGwo0pD8tahD4X+JlBi/Vgpz3jGwlAeSu+IG3iRJBF5x97Tu+hf16lxhtuhWj4p2 CRSoCsUwgR3s7d9yE8O2ZoHOBb+I23njXCCC/ivRCF3mUcVtkJNn+Z+92IwQQ3/pSNy/ hjIYqM6+0Rf2Ezg+LyYkF4sDVEgyvzGIp9/3HxapfocGN4dxQ6VhLUJEwhKs6Z0toaTr BAqxymr8T9JUPyCqWtmKQGltqo9KKxXNvysyhSxEM5PBeH7mK/r0Yj66klHwaA07leIL haMqdCW/WKmiuX+cgU5KddD2jSyTYS6TijXaKiQu18Py1VfitIGucljcdI9CEExHqJBX KIug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=cp1N31QWm6o7MZ0I8JJcE3c/9OfyixxPW9uF/7LnRhc=; fh=Zdg/IaJWIkan+8kr6bDKmrlAn6GL271tZGmx1ajMHC0=; b=gRhstg+2PXkG36020wYAQ9dnAYuYxSvXaFdlP2llCBE2H6oJf+/6mMZu0hLKXFmqCp A8tLJleiWE+F+ps0IHYjyRmNllhsYUGebtwHqPMrePhzf1kOq+IgTwaTcJM7JqzQsn6U nsOiBFgG90e+8WVNDxG0rTPoNih7/wphhsubOSV5YbLR6plN8HwHcJD7EJ+yIdkcmF03 NYDPiQ4MhOkHs0Ijx0ml65FpeE65RG2K+keTxGx7u/iX129GuewqhgGfUul5h+WlG3zV V8VEovw1wQSpGJpzoEEti1LucLi/9oBwdjvNjzEgWyNV1azgp/3M+iovFIRt1sLiBmYy 55oA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id cn4-20020a056a020a8400b00577475ee5f6si1569625pgb.618.2023.11.23.08.57.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:57:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id C82E88329A3C; Thu, 23 Nov 2023 08:57:07 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229686AbjKWQ47 (ORCPT + 99 others); Thu, 23 Nov 2023 11:56:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229526AbjKWQ44 (ORCPT ); Thu, 23 Nov 2023 11:56:56 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF8F6D48 for ; Thu, 23 Nov 2023 08:57:01 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0e-00053N-Du; Thu, 23 Nov 2023 17:57:00 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0e-00B54x-03; Thu, 23 Nov 2023 17:57:00 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0d-006ozY-NM; Thu, 23 Nov 2023 17:56:59 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 08/18] mfd: mcp-sa11x0: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:36 +0100 Message-ID: <20231123165627.492259-9-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1942; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=306Da8DHDzuEHmAs2DmBNmnh5FVbLXfhEvcGFu1AvDA=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RE0iIvzSXUDoJ9ZVZKIf15IRopeUzfSOp0C 53AfyWitiyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+ERAAKCRCPgPtYfRL+ ThT6B/9e+FvsnumNbUow1hEZHP3FjwjB8jAayEvtkeFQjLORjXL3V8rrtg6gyvW06tlteUyI3AP ALV4nxz7WfRe+LQuqpIULBW9FPfCUh4QO1wouqvS5/8aTmpQ0RKDqaPefNheRW7Wy+FLR+aGfED dYdfjqmHC6Oco4ZwXl945p6b/P80IGkyhPLmc1/lY1q7UboFwhTpYsb1mZfltVDLH+Vt+NBkKDG BH8tfcw40gVGwgVprukoLzsRqbgw3w5tNCZcyPq2dJOaWvLLrXPr0j+aqw/5Eo61WjysE1WOIe1 sRdbMD74i8uGKm7orHjTJ2raUv4mzZbhYItGuEFV1PjyJG0k X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:57:07 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374685244854284 X-GMAIL-MSGID: 1783374685244854284 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/mcp-sa11x0.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/mcp-sa11x0.c b/drivers/mfd/mcp-sa11x0.c index 1c9831b78cf9..3883e472b739 100644 --- a/drivers/mfd/mcp-sa11x0.c +++ b/drivers/mfd/mcp-sa11x0.c @@ -232,7 +232,7 @@ static int mcp_sa11x0_probe(struct platform_device *dev) return ret; } -static int mcp_sa11x0_remove(struct platform_device *dev) +static void mcp_sa11x0_remove(struct platform_device *dev) { struct mcp *mcp = platform_get_drvdata(dev); struct mcp_sa11x0 *m = priv(mcp); @@ -251,8 +251,6 @@ static int mcp_sa11x0_remove(struct platform_device *dev) mcp_host_free(mcp); release_mem_region(mem1->start, resource_size(mem1)); release_mem_region(mem0->start, resource_size(mem0)); - - return 0; } static int mcp_sa11x0_suspend(struct device *dev) @@ -288,7 +286,7 @@ static const struct dev_pm_ops mcp_sa11x0_pm_ops = { static struct platform_driver mcp_sa11x0_driver = { .probe = mcp_sa11x0_probe, - .remove = mcp_sa11x0_remove, + .remove_new = mcp_sa11x0_remove, .driver = { .name = DRIVER_NAME, .pm = pm_sleep_ptr(&mcp_sa11x0_pm_ops), From patchwork Thu Nov 23 16:56:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169040 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp581793vqx; Thu, 23 Nov 2023 08:58:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IFHKjGERW6X6ph7ChkXrGQcBbwNieg2lGMBPCR0rXTKNjRAJcw4ilESOXJM/IIwZD908KRe X-Received: by 2002:a05:6a20:3c8a:b0:140:6979:295d with SMTP id b10-20020a056a203c8a00b001406979295dmr239543pzj.2.1700758693282; Thu, 23 Nov 2023 08:58:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758693; cv=none; d=google.com; s=arc-20160816; b=poKsbC6d1ESe3QiJeWUjtmyMpHo0gIc3zOTpvhgmVadDi2zWakUJFUVQrmMO388hPx b+hjGdomCKH8t8A3jZQyKbEcn2dqDD6unUKsWtYiRu8hTQt62fQONhbR6tgZQbAJQ674 eTAUIRWhiD81cnqJPcJTDdFD+H100C4dINbnqFfZcYSSJik5OVsDit20YdRhn6skzXyW 7NnNvv9JJA3O2nllCFyka/r6LwkVnLZecZRQcP2dBu9VDOk2rxM0t1OnyL5F6vrb4oHk 8540rnO0FEFIB/q1802Ukgos9MKyoYl//EGi42ftN1K6mc1g4iOaEUOUmktdkoPHLlJd s7rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Jn0eLx0tD0YoJ5dMAsKpyjPkQn3MN+IzxiPG+s8xeBQ=; fh=cIjNq8AJ7DYG+w9Jtcuz1ji5cufJZKE/mbz7BhfN7Sc=; b=bhG0onoy0uKLLXwHEX8OJVsCzqBhX7yp4cSJSQTUuZgeeigbhIm5e1KtjF1c1OJIfy AKYbqATF5WVwvJllSkC3Fp0V7KbznyQMI8mMLVaWezoO92edifB6npQyLdbo2Gr7GJLS sXbuBDk/TQs2s1DtGJIlGfGwmy4a55fpoYH/kqmfEX1C3i8sbBwXSv0l6VH5W12RdKwr qyJXf73Lw9SWqlQfjuRHXzmxEEVIqBPpDjZDF7BKpJn78wnB966MelJXzwJvTqS5aqUX f0Owalx2zPT0j4B/M7wWk+mtXrq2tG1hArd7KK0oMFhAB9Jga5XBE38Oci39m2hjufLt kjqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id i18-20020a170902c95200b001b9ffda162csi1505164pla.441.2023.11.23.08.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:58:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 74557832DCE4; Thu, 23 Nov 2023 08:58:06 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345408AbjKWQ5u (ORCPT + 99 others); Thu, 23 Nov 2023 11:57:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345245AbjKWQ5F (ORCPT ); Thu, 23 Nov 2023 11:57:05 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6157DD7E for ; Thu, 23 Nov 2023 08:57:09 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0e-00054w-Mw; Thu, 23 Nov 2023 17:57:00 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0e-00B550-8E; Thu, 23 Nov 2023 17:57:00 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0d-006ozc-VH; Thu, 23 Nov 2023 17:56:59 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 09/18] mfd: mxs-lradc: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:37 +0100 Message-ID: <20231123165627.492259-10-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1686; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=GNK+c3Abifs5Um4n3RL+YvkDdPV3heWsrI7W1ir+IZ8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RFCaJ6YKeIfgaSRYJ+VtntxTS1jxS1g3H7Y y1ZQd/hUJeJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+ERQAKCRCPgPtYfRL+ ThjMCACQ4bf1a2PidPYlIeCGasO6BuOXhwT/Cb+640lGH78lqfL+3RaGVeFJRiCjV7hEnbuTIIU 6rAvOIPQzMmMbhyJXQz6f7955w5316eIHcoAJQONjqYWLnPRST6/t+4+O/kCMDaH8Mm+1b+8h87 cjbIy/E4SCLP1I1F1LCMfDQe6nvxntOqEPn/Xy9H0bg0gFvSKZVpJdcTcQ7+rSl0g1rOwldkA7w t7OsdALFnZblnxDLCOK267TDs5rC9O8HraKUOSw4Cu8+fzdQLO16pJwk5DM3XWTiNKvuvlelg5y oOmoCo9yd7Vg8R2b6C4skR0i9fL3yuxaxe9B7kHlZhAXrK3n X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:58:06 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374747620766192 X-GMAIL-MSGID: 1783374747620766192 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/mxs-lradc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/mxs-lradc.c b/drivers/mfd/mxs-lradc.c index ec1b356562b9..73893890b50a 100644 --- a/drivers/mfd/mxs-lradc.c +++ b/drivers/mfd/mxs-lradc.c @@ -230,13 +230,11 @@ static int mxs_lradc_probe(struct platform_device *pdev) return ret; } -static int mxs_lradc_remove(struct platform_device *pdev) +static void mxs_lradc_remove(struct platform_device *pdev) { struct mxs_lradc *lradc = platform_get_drvdata(pdev); clk_disable_unprepare(lradc->clk); - - return 0; } static struct platform_driver mxs_lradc_driver = { @@ -245,7 +243,7 @@ static struct platform_driver mxs_lradc_driver = { .of_match_table = mxs_lradc_dt_ids, }, .probe = mxs_lradc_probe, - .remove = mxs_lradc_remove, + .remove_new = mxs_lradc_remove, }; module_platform_driver(mxs_lradc_driver); From patchwork Thu Nov 23 16:56:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169042 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp583905vqx; Thu, 23 Nov 2023 09:01:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IEuusOr+PJF+FpQgGCD8sUHUkHlW1maT/f7PTAUqQ+srFs+yaR5YtOOSnxz2TB1keJm++5b X-Received: by 2002:a05:6a00:398d:b0:6cb:e246:93ec with SMTP id fi13-20020a056a00398d00b006cbe24693ecmr4116925pfb.15.1700758883642; Thu, 23 Nov 2023 09:01:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758883; cv=none; d=google.com; s=arc-20160816; b=r5crLmj/l7OjkPl1spMiGlD/RBec4BFy/+qwsgHRGaNsB08RCAsAQk9v8fCooKZN77 a3QA0gRf15Uvjpe0CAtKrFlSU8NW7FVr8LazAQEbiasu/7Pc2OI5Oqdv9si6e+8+qSum WzrgSQiRrSm+dOHKI4t7+BwdNjlJlCk3UyoR2Bkn54leFEo1lz7HkuAV6DVpkOzQ66Nf ilz7MRuxdfkUgMESf0W1C6/cbK4arvZT/3m+Uvrg2GErFW1ytbKGPnT7emJdwtusBBva ximtrophxuNVPwULba8juQEMn3avM9NzNygGiJKVaVj+FFVguCsgFJG1K5nVnX6PEv2b eMcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=K72U5H6VjLmZI96uYhbMy2p86zYhjQumD+7pQivSvM0=; fh=MPr1O/33eOLDJUuxTfiG33qwsHqzUAGRVnE+SCXoc58=; b=WlWD+hQ0+EvGi2VNdTWFU1DMFTrCXub1Rpsjd6T/moqKlnsD5wYx2U1PL/b5S1/sb8 ZscEz6QaU4KxvRDsknXVafZvRPNfXqHNrkvNswkdJzXhYNRYpUQAISQEivDLgCyqLJvS KzISMGE+S0sRwoJHMZvXuzmOJYDbn5RIlslAiplcBX1Zc40/ORDOmsTymHUHTQbclnTV oCPVag++JFuIy3urGlb5V5JxDTW3/PhpwTS/697L1Fn1ef7618nF5fqAsmADJBiU++F1 ydhC2ure+AslkZCJxocEsuYgTU14WJ/e3e6UmSm+UjHqLL4bLbdDBfx+mxL2ASjUAilI 2ZfA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id x39-20020a056a0018a700b006cbdeec441bsi1589023pfh.236.2023.11.23.09.01.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 09:01:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 70683803A5BF; Thu, 23 Nov 2023 08:57:39 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230190AbjKWQ5Y (ORCPT + 99 others); Thu, 23 Nov 2023 11:57:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345168AbjKWQ5B (ORCPT ); Thu, 23 Nov 2023 11:57:01 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F13ED41 for ; Thu, 23 Nov 2023 08:57:07 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0e-00055n-Ts; Thu, 23 Nov 2023 17:57:00 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0e-00B554-FM; Thu, 23 Nov 2023 17:57:00 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0e-006ozg-6J; Thu, 23 Nov 2023 17:57:00 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: Tony Lindgren , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 10/18] mfd: omap-usb-host: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:38 +0100 Message-ID: <20231123165627.492259-11-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1815; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=UItv2bTQ3oxGDvzjFaeeuB8LovhLd6RvQdqam8Wvj/k=; b=owGbwMvMwMXY3/A7olbonx/jabUkhtT4FrdX+9Y1c5bNCI5KLtC4IL7OM9Ot6i5ncor2vJQm3 n0/mgQ7GY1ZGBi5GGTFFFnsG9dkWlXJRXau/XcZZhArE8gUBi5OAZhIdB4Hw/aa/LJzO5oepxgd 23O8jSknwynepZ/h0ZJXTzmC97Rc983bvjBhRaKAsv53lld7m35+NVy6S9LuuJdi4NTJKje/MM8 SN8usCXvfGrS0qmit/MSlq7K12/eX26X81g+JcHnXcKhs+oylpsbPTUO9+NOEOfLvvFCVeL9W/v yN1a+0MvqL0jf18Rdk5WzRcPCY1apr8V/5z9PwQ2dU3jXc8ZoiuMj2o2TX0kSfzkeivme8HUxCf bOLpW+6+R9bMf/qDom0zbO+v1izNiHswkyR0voEEZma0z8uxLpcWh12/t22HTO6p6b29IoH3pGd c3nTlqNt6b3d69/OL2Cc1xxyg11LdelB9Vz9oiehaouLAQ== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:57:39 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374947349105272 X-GMAIL-MSGID: 1783374947349105272 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/omap-usb-host.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c index 78f1bb55dbc0..ebc62033db16 100644 --- a/drivers/mfd/omap-usb-host.c +++ b/drivers/mfd/omap-usb-host.c @@ -816,13 +816,12 @@ static int usbhs_omap_remove_child(struct device *dev, void *data) * * Reverses the effect of usbhs_omap_probe(). */ -static int usbhs_omap_remove(struct platform_device *pdev) +static void usbhs_omap_remove(struct platform_device *pdev) { pm_runtime_disable(&pdev->dev); /* remove children */ device_for_each_child(&pdev->dev, NULL, usbhs_omap_remove_child); - return 0; } static const struct dev_pm_ops usbhsomap_dev_pm_ops = { @@ -845,7 +844,7 @@ static struct platform_driver usbhs_omap_driver = { .of_match_table = usbhs_omap_dt_ids, }, .probe = usbhs_omap_probe, - .remove = usbhs_omap_remove, + .remove_new = usbhs_omap_remove, }; MODULE_AUTHOR("Keshava Munegowda "); From patchwork Thu Nov 23 16:56:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169037 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp581726vqx; Thu, 23 Nov 2023 08:58:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IGbatX5MFq1yftGP/xiHMhOaxCgLQRhfVG+laP8F6zvAzc9LG5WbiJ59z7iU6qObhRoMM+d X-Received: by 2002:a17:90b:1d09:b0:285:80d5:6e51 with SMTP id on9-20020a17090b1d0900b0028580d56e51mr81524pjb.21.1700758683286; Thu, 23 Nov 2023 08:58:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758683; cv=none; d=google.com; s=arc-20160816; b=E+KZ/iIffIRQ+94GBtq2oAKhQPgdGOeWpB6qcKDkDUj5dFyBA6Kue5NEDGK5bsUyCL rAb3uscIF6GXxieoH2KJniJHYcd0vPQ/uloMX6NLT4mwDZLPQ95tHxg7AIsY+JI7Juzy c7OtYMqCbOZVWrZVgBDZFbaceKoFNHCAf2MZT7gSlSOd+TXDePB9iRTLdSvIiM3i6F9k GtRztod0IW+uYGxCSOHYl/ID+TEec92rKRLnNd87hc+iEupzqOWhjveo91eydf8m3yua xgdiwPYI3KFBszTYawWf4H+tfrinNNLH/JZH76dXyPxS/Ry21OVnqJLNOm+IYLrRxN17 d2YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=tcT+1ISneeMRp40b2qlRnyZ1xpYNgyCti30IiAkMP9w=; fh=MPr1O/33eOLDJUuxTfiG33qwsHqzUAGRVnE+SCXoc58=; b=pn9hDy21SRaqj1A1fKVyS4Lxzkg56DJXTrMvwooSf+4Qxc96uTjS7c87I8DGSaRrY0 uIBFUeuQxyaGCxHvqdFsFBxXWwZ9QjQbQA2FdgStBuKx+yzF2Tz2uFbNzGZ/MyRc/Uie YvDVkAaGBr3L3vaizv17SMFrS9kwpO3hWBni9GHFa/dPB1RlE7voocl6btoNAU5+EU7r k4YDfrdQIy9KIhDY+dK0qcSlz88InRf8a55ytpqjDrhoCOJiPXwwgWq9m+toFH285rms WSgbHLhGp/vDn8M6Le0HiSkmsVAuzVMk34/07xME7nuViwfJg4764FBv/mrbB2aw1nOc X1Zg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id x17-20020a17090a789100b002801dcaf6a9si2108401pjk.64.2023.11.23.08.58.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:58:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id C5EA98290981; Thu, 23 Nov 2023 08:57:58 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345321AbjKWQ5b (ORCPT + 99 others); Thu, 23 Nov 2023 11:57:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345185AbjKWQ5B (ORCPT ); Thu, 23 Nov 2023 11:57:01 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7C30D5E for ; Thu, 23 Nov 2023 08:57:07 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0f-000572-6L; Thu, 23 Nov 2023 17:57:01 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0e-00B559-OK; Thu, 23 Nov 2023 17:57:00 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0e-006ozk-FA; Thu, 23 Nov 2023 17:57:00 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: Tony Lindgren , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 11/18] mfd: omap-usb-tll: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:39 +0100 Message-ID: <20231123165627.492259-12-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1867; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=6grJxx2LHRITrZAbOAlfmI+2kXgEuMJigw1AAr3yPog=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RIFwziiGXsZn1On1/MovUspXu733lLnlJFD RweOUzkJcaJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+ESAAKCRCPgPtYfRL+ TvoiB/420e3zD2ZZI9dSb9u1sLR6OEJ63GxYAc51glsm6MAZhyys0dNzjVte35LL+w8oHPQKf79 4WA6Ugt2sTgD9fOcRoPM0wv35ApqXwf6dYwBdISkQVFIUcMsql5XWbJ6zlSSEIooEl9Q+lgjvsQ zRuiAm0/psL39x8zoXNCYJzoif+fi8lZp5xUlsrnXbLYqV7qlhM2cRwIdYWGM3q96tuWxtrTl2w IvN+uykum8DzDcXeG0WNKJQAQL2jCkl35Kafzzs9WauOkBpu1/6FaDAdzrv1p+3PD0Ci2mYLFK0 uSpw69ugywtV/QdI/BEKquIyLcjVxfKTRoGUDf6YR4D4LK8S X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:57:59 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374737183348588 X-GMAIL-MSGID: 1783374737183348588 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/omap-usb-tll.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c index 906353735c78..b6303ddb013b 100644 --- a/drivers/mfd/omap-usb-tll.c +++ b/drivers/mfd/omap-usb-tll.c @@ -270,7 +270,7 @@ static int usbtll_omap_probe(struct platform_device *pdev) * * Reverses the effect of usbtll_omap_probe(). */ -static int usbtll_omap_remove(struct platform_device *pdev) +static void usbtll_omap_remove(struct platform_device *pdev) { struct usbtll_omap *tll = platform_get_drvdata(pdev); int i; @@ -287,7 +287,6 @@ static int usbtll_omap_remove(struct platform_device *pdev) } pm_runtime_disable(&pdev->dev); - return 0; } static const struct of_device_id usbtll_omap_dt_ids[] = { @@ -303,7 +302,7 @@ static struct platform_driver usbtll_omap_driver = { .of_match_table = usbtll_omap_dt_ids, }, .probe = usbtll_omap_probe, - .remove = usbtll_omap_remove, + .remove_new = usbtll_omap_remove, }; int omap_tll_init(struct usbhs_omap_platform_data *pdata) From patchwork Thu Nov 23 16:56:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169031 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp581478vqx; Thu, 23 Nov 2023 08:57:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IGGJTGAK5y+XvC3/ZQmnYBmSpjyVZ5g5ZDbg1pGUs1+m0NMfbGSPmwuBAb+NMpCPO4oZzcI X-Received: by 2002:a05:6a20:7d85:b0:18b:c927:d30f with SMTP id v5-20020a056a207d8500b0018bc927d30fmr260439pzj.10.1700758649951; Thu, 23 Nov 2023 08:57:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758649; cv=none; d=google.com; s=arc-20160816; b=QubxrPXJXEU0yan1JwbboV3Uym5Dt5e12TUdIWFMqAjlAArTOKdVgRYLcfhnn7a8Rz zq7HsXDParJxAm3IxK5Dt4qCa8Bamq4oGVba3aB5KtDjni41kaKLOf0Hbg02XF/Iqh/E 09lJg4z7trGcu6ZHEfl0otdVOHvvTudI9TJB5NLy96C2Gft3IbcKVvMfAre1GNkSaWqn Vq/0VsJTWxgmvPJj4rnO1WVuDmVWfjyYAYrexCrFvkbUVOJMb1XsPEtIJCD3+WVeEdca +in0E++mmYaAaf7Fxto0OjXXYcshTp3nX2JuNpg9zz073Bbl9mGLB5MMfdkmJ2JlNjqs zMmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=rYgoKVKU1CrWMupKRq0B9CX3znaO9RKxXc9mKyqkpO0=; fh=Zdg/IaJWIkan+8kr6bDKmrlAn6GL271tZGmx1ajMHC0=; b=IgHAZO1n+5iLJGgMxGW9DDlCzdVRFv+cvbY2sZ5g+CoQKsFU5UqBuU/9aj2q1uxPPW Y4bkwCQlIra9uexxWEe8daNrZfYayG77aJuZZeDEypytpTwuCCppKJ3fHlLnkTW7nG3w oCPdfDdlCmCJlvcxgydHPBYZBwxJNSz9+b8OATvXc8y6nmKCpVJxaB5hNZ8cBOw16Gjr h5AX8Rw9ib6ancQzlRkbHMcFpKrAQcva2SoXs/ExwOQaQ3QrA8XaQz4937TL1gMAffY+ 8BBA3/1JuCcWUKFZfFENjqaahE1mSz85T9f/mSX3P5thfCwV2xIqP85qHVEiQjPCDKq/ LQ1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id bo9-20020a17090b090900b00283a0cb5b9bsi1596134pjb.58.2023.11.23.08.57.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:57:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 2F60B8260C09; Thu, 23 Nov 2023 08:57:24 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345207AbjKWQ5E (ORCPT + 99 others); Thu, 23 Nov 2023 11:57:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229930AbjKWQ44 (ORCPT ); Thu, 23 Nov 2023 11:56:56 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2509DD53 for ; Thu, 23 Nov 2023 08:57:02 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0f-00057i-D2; Thu, 23 Nov 2023 17:57:01 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0f-00B55D-0Z; Thu, 23 Nov 2023 17:57:01 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0e-006ozo-Ns; Thu, 23 Nov 2023 17:57:00 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 12/18] mfd: pcf50633-adc: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:40 +0100 Message-ID: <20231123165627.492259-13-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1835; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=FtAnMobifYM32sw3SvUnyTDhNGwr52N00NU39uqq4PY=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RJMlhOsi8S7zcdLMJJGez9KN5J7DTm4Ovzc h33JyjXZYOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+ESQAKCRCPgPtYfRL+ TsSrCACGgOBx/tuJ6VjMhZrKaZ5Q4ORmRr+AKmZ/Jdi25XfzGMxN/QVvYjz4MZIcgK32AbMhuI+ lpzQq5URbuFHW6IUTN6TJj+/ttUcpwjyZt0nZ05mH8upuNsv0f61od4P2RErgPI22odTknb45NU AsK4vOceNV9AWvjJwkGeJFVmMo/DGJ4kHYOQVeliQmEZKdR8I5KlJbWHIfTdHiD9o6JFekGRDNa C4iM72L7ALHRA7LJSZwPf4BezOAqkNl0zR20e3n3ubAOAst4R25Q6gdq3E/MbxnKvh/F8gK/ZE2 5g7BkpUNuzlwXzz6rSI+ErdEhGIaQvol7QNcZNAQr8/hIs2u X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:57:24 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374702375760691 X-GMAIL-MSGID: 1783374702375760691 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/pcf50633-adc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/pcf50633-adc.c b/drivers/mfd/pcf50633-adc.c index 191b1bc6141c..ab55906f91f9 100644 --- a/drivers/mfd/pcf50633-adc.c +++ b/drivers/mfd/pcf50633-adc.c @@ -218,7 +218,7 @@ static int pcf50633_adc_probe(struct platform_device *pdev) return 0; } -static int pcf50633_adc_remove(struct platform_device *pdev) +static void pcf50633_adc_remove(struct platform_device *pdev) { struct pcf50633_adc *adc = platform_get_drvdata(pdev); int i, head; @@ -236,8 +236,6 @@ static int pcf50633_adc_remove(struct platform_device *pdev) kfree(adc->queue[i]); mutex_unlock(&adc->queue_mutex); - - return 0; } static struct platform_driver pcf50633_adc_driver = { @@ -245,7 +243,7 @@ static struct platform_driver pcf50633_adc_driver = { .name = "pcf50633-adc", }, .probe = pcf50633_adc_probe, - .remove = pcf50633_adc_remove, + .remove_new = pcf50633_adc_remove, }; module_platform_driver(pcf50633_adc_driver); From patchwork Thu Nov 23 16:56:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169045 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp584236vqx; Thu, 23 Nov 2023 09:01:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IHEZBUi546DPBPLsV3HyYroaosYQ0GRURa7t70m5UhV45kSautwEvltNMpI7j7eZHPXWTu4 X-Received: by 2002:a05:6820:513:b0:58d:a0:8c4a with SMTP id m19-20020a056820051300b0058d00a08c4amr265524ooj.0.1700758903596; Thu, 23 Nov 2023 09:01:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758903; cv=none; d=google.com; s=arc-20160816; b=AriG+Ef58cHBL59RDgoOoUAsEn+6YRBQ1AUiXPyciIzaXvJE8eoM7zfEQfAksVocNO v7ZrkC1b4v46fCTzhuuEAx5UYsXF2Q2ZXJREOunZaldvsyInFApAe0hq/HW+5rqcB0lB 4qkI56spwYTwPND7fC0i2bPrg0+YRJz6VmcVJRLph8Vom9SxUuBxDpAH4vxpL7uzacIQ QYBgmf9/FTyifOlxcS0yfAgIpz1N484CmGdXHx7GR6Qr+YfiVGGN6AwEvbl9WBPaA2X+ RfABgnW0MjIxTFDbsKf2Nyy6KMPurBtozQ1MpDyfEcPvJVRVE0f3grpFVsxJQRBB+XMN 1nXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=WSTzduU8ekYBRWA7afE70bIUJYnql0LaByzaesGq0bE=; fh=yfJMaNdqSZ8T71FfwLhd2f+2rbag6ER4GaoPLWd+tEM=; b=uImDgXZxnEXEahVKSjVt0WRPU9o57fv2cjezQ1S9JKkJITbomDdQs41gFPYzJQb6YJ rutgE+zuebp7ewjnuKLObloXIpoo2t8m614F5fANxhxo5tfn1mpmyrSHtkUm1WH24uK6 WntG8JWZmWxyUzMe2Ap3jRW2Im3Px8PJidpcBL2utTGV6d12Aa6rN4L21RlZqct5VdxT LViMFqNd8JMUAwA5CLRqL1umTaD4Wr+FiheaN30zdAmzYJyjdSetFB5r5LAIySAUzer/ rADTHxCXSUnPTA4CiekNM34ufzJTBQ2ddeDPLQL0PXgc2iGJMUcvhbmFsRsApcYc79BV CWDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id z9-20020a4a9c89000000b0058a7e918206si546766ooj.9.2023.11.23.09.01.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 09:01:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id BA045818909A; Thu, 23 Nov 2023 08:58:10 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345478AbjKWQ56 (ORCPT + 99 others); Thu, 23 Nov 2023 11:57:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345305AbjKWQ5Q (ORCPT ); Thu, 23 Nov 2023 11:57:16 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67B2710E5 for ; Thu, 23 Nov 2023 08:57:11 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0f-00058H-Lr; Thu, 23 Nov 2023 17:57:01 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0f-00B55H-8o; Thu, 23 Nov 2023 17:57:01 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0e-006ozs-W1; Thu, 23 Nov 2023 17:57:01 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 13/18] mfd: qcom-pm8xxx: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:41 +0100 Message-ID: <20231123165627.492259-14-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1720; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=kmmW3jQ8i81KFfqYxB0Ki4v/E6hUWk+ecQRLAZOVMi0=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RKkkPvevqUyzElWksaJzFiy57xDrcoz/rI+ 5duKyqUVSGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+ESgAKCRCPgPtYfRL+ Tos1CACw6arTk6jUW66Qko52akt9RHWRZbEU2z8w3FWnWDZ8FtMaRviddYr5vLNJkH8REHMKo59 luR8nZFEKsyzNBUKWMOFKsuY48gaVCYtOBgvZceoEGfAZK+DwX4gW6rw68yxAcIXsxZFV9fvfCa fkSK4SOlXt0J49eWjKFFKah99rcOD4wrm5Q9ODvI7ASlwEGgW6/8f8iU7Y2D+v33zFwmVbDqPLQ rumhqaQFkSFO9l+2yWuOvTIq7boaWo/vVwzev02a+2yt+MNeQBJLhaU080mT2KeMl+KAiLr3T7/ 74ZxAAx+1HKJIcTOFil15pq6m5TYfI9DKo7N1HeRwwgKQDIy X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:58:10 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374967839424693 X-GMAIL-MSGID: 1783374967839424693 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Reviewed-by: Konrad Dybcio Signed-off-by: Uwe Kleine-König --- drivers/mfd/qcom-pm8xxx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c index 07c531bd1236..8b6285f687da 100644 --- a/drivers/mfd/qcom-pm8xxx.c +++ b/drivers/mfd/qcom-pm8xxx.c @@ -585,19 +585,17 @@ static int pm8xxx_remove_child(struct device *dev, void *unused) return 0; } -static int pm8xxx_remove(struct platform_device *pdev) +static void pm8xxx_remove(struct platform_device *pdev) { struct pm_irq_chip *chip = platform_get_drvdata(pdev); device_for_each_child(&pdev->dev, NULL, pm8xxx_remove_child); irq_domain_remove(chip->irqdomain); - - return 0; } static struct platform_driver pm8xxx_driver = { .probe = pm8xxx_probe, - .remove = pm8xxx_remove, + .remove_new = pm8xxx_remove, .driver = { .name = "pm8xxx-core", .of_match_table = pm8xxx_id_table, From patchwork Thu Nov 23 16:56:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169044 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp584138vqx; Thu, 23 Nov 2023 09:01:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IHFioymdjdpLPQRWIcMZ0ceZ/QKStQkhwGdbfBdfvZ5GCyJgysUsiM34Q28yGNGus4S3upu X-Received: by 2002:a05:6808:bd6:b0:3b2:eade:5e81 with SMTP id o22-20020a0568080bd600b003b2eade5e81mr8365215oik.34.1700758897116; Thu, 23 Nov 2023 09:01:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758897; cv=none; d=google.com; s=arc-20160816; b=be2i+K5TDtMqbqkCttjGpVEKf7nHYbEyS25Oan12vMJe28tPjqFZLQymsTxb56eQxS dC9b/DVFWoJ7G/gbaaOLdLrEdqVJr/yJQ91eAhs8XG8VprxynN2FN9oZB4RLpAvL0j83 pNY7nxRETBzBDIMzx2jYkxLLfRachRzvn75PfJeTsW7OCgvZLRQ/TfCgoDIyI0Iy4Rpx xriss37z8v+drPEy7smqvHmZYp4hWTQtSOMeTqSrHR5lnCo1nvkOVOCOE0zwXpdSLYg+ kF/1hnHiOCaHle74KdUUXBIFVgOvVRflhMr+YI4ft2p5mB++L5EUyTbE2GtMMaQDQ141 SXZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=UgBlT319sLhai+YBmgYm1AJIGOsJSBUou51vvKYIeJ0=; fh=Zdg/IaJWIkan+8kr6bDKmrlAn6GL271tZGmx1ajMHC0=; b=rVQoKwNGCxR51IS1HfRaG8HcPdxr+Sff9q5XBEaSWUwfMNQGniFqVtYzgDF9+FM/b0 ECQ1EZ3yf+Xj/lz0TKT9uTHrPIcGT+Gw/Q767YjW9RhlWuxwzpAisb/Lq2T5soemAUT2 vsNj+FjFE5SzTYkYs/+9XGGiG3a+ZZz22x7/J9+pv/q5WmrgeFPr2TyRfHDb7kXQj8Q/ hZxM1dz1QNW5QZkZw8KVDYw6OEuE6MlHrSLSwG+wEJsMU6pg3MRX0Jhxqcn4zXOK8UL6 4lSKOm9K0DrGJHgt9Ul8Vl4V0zoYxIMQX8O9TSoqVOjf9a9AEqyHOlmb19yVsDDUuhmm eq6A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id ct16-20020a056808361000b003b8518b5cc2si113004oib.0.2023.11.23.09.01.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 09:01:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 7845280C247C; Thu, 23 Nov 2023 08:57:34 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345167AbjKWQ5H (ORCPT + 99 others); Thu, 23 Nov 2023 11:57:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229944AbjKWQ44 (ORCPT ); Thu, 23 Nov 2023 11:56:56 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74297D54 for ; Thu, 23 Nov 2023 08:57:03 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0f-00058S-UF; Thu, 23 Nov 2023 17:57:01 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0f-00B55M-Ht; Thu, 23 Nov 2023 17:57:01 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0f-006ozw-8s; Thu, 23 Nov 2023 17:57:01 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 14/18] mfd: sm501: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:42 +0100 Message-ID: <20231123165627.492259-15-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1850; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=zg/2ZKivK3j/zzzpz8S6gtZj3g6k3uJ+o38xadR7Krk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RLVqlKlHQf/icLBp7mzF2JWyccRJ6kaVxD9 ZxwFFiBXvyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+ESwAKCRCPgPtYfRL+ TpMwB/9Z7joueqrSTQ5o2Xb8R/dCAHqRR6UsmAR1YjWLq5pL1Rzpa8Gak2wetFc/nIU07qJdR7K QIe0DrE6Okv/OJUP5UVMdmr/pqRssuBnIPIZuKW43frusnGnaFvuDzX3/8l2GroW8zjPZ7ARjqx NKPlVjfutyeDb1+XH+rKXRR6lMuaLtVpeIMiALs2iKUFti3W9iSGd//bbEEbscyBkE9A3r82GOu iehYZd3xSfylBtB92N7zDDcgFVPWblukIYYrVTofG+LgS2U2zfGmu6UVE71Y2jU5KFREXnbcMEW 7XMoLoEi4jYdH+NA52nVtRDFVTHs6UCWwO+eJZZV2IPvjnQr X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:57:34 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374960904166310 X-GMAIL-MSGID: 1783374960904166310 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/sm501.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c index 28027982cf69..b3592982a83b 100644 --- a/drivers/mfd/sm501.c +++ b/drivers/mfd/sm501.c @@ -1667,7 +1667,7 @@ static void sm501_pci_remove(struct pci_dev *dev) pci_disable_device(dev); } -static int sm501_plat_remove(struct platform_device *dev) +static void sm501_plat_remove(struct platform_device *dev) { struct sm501_devdata *sm = platform_get_drvdata(dev); @@ -1675,8 +1675,6 @@ static int sm501_plat_remove(struct platform_device *dev) iounmap(sm->regs); release_mem_region(sm->io_res->start, 0x100); - - return 0; } static const struct pci_device_id sm501_pci_tbl[] = { @@ -1707,7 +1705,7 @@ static struct platform_driver sm501_plat_driver = { .of_match_table = of_sm501_match_tbl, }, .probe = sm501_plat_probe, - .remove = sm501_plat_remove, + .remove_new = sm501_plat_remove, .suspend = pm_sleep_ptr(sm501_plat_suspend), .resume = pm_sleep_ptr(sm501_plat_resume), }; From patchwork Thu Nov 23 16:56:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169039 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp581767vqx; Thu, 23 Nov 2023 08:58:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IFdnZbcOQgkYKxue7AhbrX1VWcu1HL+NI5Q8QMj6vs+Relu/lLDyLXCW6Z69ThmB5U7PAVJ X-Received: by 2002:a17:902:ea84:b0:1cf:5543:a96 with SMTP id x4-20020a170902ea8400b001cf55430a96mr59332plb.51.1700758690111; Thu, 23 Nov 2023 08:58:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758690; cv=none; d=google.com; s=arc-20160816; b=AnQw3pkunaAvJvYCMmCDcGi/GNcRvwOT715EegjIj0De0ehuNZGS2KWFDydNA9IwRr Oi1Yzw1sq1BkoSttYE5ej+WbLoEI0KIjvJQYltJR2FEd33JIkbhFVkIXNxYTXLe32GjQ loWEzp0nk29QNLGkeCP5dYyK/4RpW/2pqKCWvEQbkGIRD2usawN58ubB8vd6QjlE7ZGi pVpPaAOUn//c2YQWcSDY8oh50hTzjBl0O7MPl42MTEiWIS/iow+Xo5fZr3wiHUeNN7ZZ OjUloun2a39AnWTtwvxxVLt+OEUqBqixT5B3otZmUIqyyaPIu0UiTLfkgzEh/WFw7L34 yqoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=wBSWXbESFj/hWFQFGPwDBtS7ePfelgSBKNIUPCL5mWw=; fh=EeUu5qqm5c8zt5D4k3FDPjzWDcPXNXWxVs6KRgrSsoQ=; b=l8z3iC5nGAOpEXCpfQhnibTh7MhBTYEIYyXMpxW9XJxzdafQuX5Bm9/8ZccyJQerTA l0iRW2UYos/quKbjEUzIV1twHei2sgGXF08vxyy7OGrFD4U/ORh2watpzirS7/VSaQ9N VCYMF+d3AXy0SFloiVnRcV4WnPiojYIRGklFMt7ihauLJaK/XJbAUubuzcjhpNHTRFb2 AQfZdganrBIgsDpdjnzZbTbYcshsKFcY/xNDZGqtFm7xy7WIX6RZFYg6cTEiPCPWuOSj w9xaHnQru/pZ2zcTpA1r6Z4i3zuqyy4YxgxieQZZ3PayFVzYiRnQ+fRCJ74r+dfYIdP7 wR5Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id q4-20020a170902dac400b001ce66693239si1566830plx.206.2023.11.23.08.58.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:58:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 36116806BF04; Thu, 23 Nov 2023 08:58:04 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345432AbjKWQ5y (ORCPT + 99 others); Thu, 23 Nov 2023 11:57:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345253AbjKWQ5F (ORCPT ); Thu, 23 Nov 2023 11:57:05 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EE9410C9 for ; Thu, 23 Nov 2023 08:57:09 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0g-00058f-7S; Thu, 23 Nov 2023 17:57:02 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0f-00B55Q-Qq; Thu, 23 Nov 2023 17:57:01 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0f-006p00-HW; Thu, 23 Nov 2023 17:57:01 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 15/18] mfd: stm32-timers: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:43 +0100 Message-ID: <20231123165627.492259-16-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1913; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=jVkK8Ke5hsybq+hJya3Qt2KaRP0LWkU08638E+yF+OA=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RMWnS+kDacKKlH4v2Liesd5r6OzwvKBRTf0 42Nudp3EaOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+ETAAKCRCPgPtYfRL+ Tg51B/4iQeyWsKcZqQxzJ9EpqzADAmrRSQK1J+YgDkC/ssJwOFwFHeKS9ufGTLQZjueDdMviNqX VhZdoCQGRNaPOJGESuecYhuxZuAMuRX8wH9ekGMyx5PJLMf8Eo0kjpy8BNPewRkuvpasgc3ZRiR cOXatNi6ahOcob8Sw52RwHZJpyzqqLLhWt5AKCh2amYBpEo5uWwt192cGOffMLfw7C+sJXQXFzE pey/6uHGKQPofLnGxcpA987g/L1rQeaZFlqP97/GpwMozfiDxicqhDQGWCWf1Rse8p5j3qe7x0v fnP2lJ0Drk67B4wBR3zTU3eQMwcXGlO43rUPuXsSIhW0pukC X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:58:04 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374744338668680 X-GMAIL-MSGID: 1783374744338668680 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/stm32-timers.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/stm32-timers.c b/drivers/mfd/stm32-timers.c index a656a1c186a8..9fd13d88950c 100644 --- a/drivers/mfd/stm32-timers.c +++ b/drivers/mfd/stm32-timers.c @@ -306,7 +306,7 @@ static int stm32_timers_probe(struct platform_device *pdev) return ret; } -static int stm32_timers_remove(struct platform_device *pdev) +static void stm32_timers_remove(struct platform_device *pdev) { struct stm32_timers *ddata = platform_get_drvdata(pdev); @@ -316,8 +316,6 @@ static int stm32_timers_remove(struct platform_device *pdev) */ of_platform_depopulate(&pdev->dev); stm32_timers_dma_remove(&pdev->dev, ddata); - - return 0; } static const struct of_device_id stm32_timers_of_match[] = { @@ -328,7 +326,7 @@ MODULE_DEVICE_TABLE(of, stm32_timers_of_match); static struct platform_driver stm32_timers_driver = { .probe = stm32_timers_probe, - .remove = stm32_timers_remove, + .remove_new = stm32_timers_remove, .driver = { .name = "stm32-timers", .of_match_table = stm32_timers_of_match, From patchwork Thu Nov 23 16:56:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169035 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp581661vqx; Thu, 23 Nov 2023 08:57:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IGF4MCfjO4gwjg3NIimj/UgW/wvafFgGcJUfztXN5S465329ObjgZaWjTk30NpDNWz/NN6j X-Received: by 2002:a05:6a20:3d11:b0:189:c353:3a65 with SMTP id y17-20020a056a203d1100b00189c3533a65mr254441pzi.12.1700758674446; Thu, 23 Nov 2023 08:57:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758674; cv=none; d=google.com; s=arc-20160816; b=QVZ5TKE3bAol6EYynh0q+a5VSrdxZCnmly71YhnJqKBQ1c9cin8roQIXpow51pO2Rf UaSdv8iG4DsX2KZ862NU6IGsQz3y0k8cB0+pV6UVlSx5Ao4XrpWgxIHfJDvHaKqQU9Md J/IPWjwKZpZU30A66Aro+9uB/lGUhu0Z7vqJnA/g9KPTNa7tZO/0yN8vxxzi7ZxMasgo 3EWZieq3LcluqUwiCKKghPkuhS7xhnsiE0KobaruLLnEYkXmEJs0N1S+1hk5RXMYWZuD nZ2qaA5uLkoYFdlwsSnG1IQ3gIIDiJVjMrzCgfes9ZakEBSG7UPrfBmhyghVlafSDYRx Uq/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=hRhNpqdlNfu3ViDvku3YH4tpsoqmcQdD5jYzc+1XtNQ=; fh=Zdg/IaJWIkan+8kr6bDKmrlAn6GL271tZGmx1ajMHC0=; b=ZQ2p05MdkXyORAo8kVztOKUDbWolyRl0/sWjMShrFKThO6TcnEegw99snzmsLIeYRN TsEfT0KNXsI6hOXM1uFQYeDSZ2D4ZbG1wtzDUQYp6IP1rwYVmVOb5Ogk/RWT/919uLoF mJf4y2mJizHYCCIEhjU/s3CPiE08ROrKzXwyJXI4sH9w5wfU7T71ZyuJM6u6mW2C+CaW xtGGwol7BRm34gg9WjFlujGBXhj7OstKzCaPteOzYZohVZBfO9IyCvbLvmstaxBoe56F swAxcHEtYVb5aH+VShCmQsNsfOinKhTop9eNVESuXrE3KNIMMEUvdjmr27TPlmzHxEG/ S8Cg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id k1-20020a635a41000000b005acba4c9bf4si1642183pgm.2.2023.11.23.08.57.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:57:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id BD674809B6CC; Thu, 23 Nov 2023 08:57:50 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345270AbjKWQ5K (ORCPT + 99 others); Thu, 23 Nov 2023 11:57:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345133AbjKWQ46 (ORCPT ); Thu, 23 Nov 2023 11:56:58 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 043CCBC for ; Thu, 23 Nov 2023 08:57:04 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0g-00058l-E4; Thu, 23 Nov 2023 17:57:02 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0g-00B55U-1W; Thu, 23 Nov 2023 17:57:02 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0f-006p04-Ok; Thu, 23 Nov 2023 17:57:01 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 16/18] mfd: ti_am335x_tscadc: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:44 +0100 Message-ID: <20231123165627.492259-17-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1826; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=958CZe9ea6jlgCw+DhNvLHgJQMdn3TTMy73VrfjhS7g=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RNzUp+O1Q5mU1TkWEfA3LmuaPzBLdiln56y PSSEKex4f6JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+ETQAKCRCPgPtYfRL+ TurkCACzAHQ8fH88QHgqOLqaNePjWA12uL4ORz6rDd/07Qql/Ocfh960J2cC1A9UR/xfVcUw5M1 xRz2DM97OMdCUYi6zn7jATB7wZ5HQbgdf4GWEN8PZOdNZdExU+Da70xA3G2ftNnvOBDYQ9Xpjjl LcIX/J36/F15n0ewUYD93CLn5i9eZOlbn8cZwF1aM7Vu6jp38egkaQbS5r9O9TmiEgHEjzytFjD 1dwiHTLqpkoExD/kLDpsEO1eT/FTDc8pB8BlE0IwT1ozQ+GMTCceLq9L/28LGwj0Pw59DT8Ll0O ocPFfGmV7OYX/MmBSfr301ogvoJCLRoWcetR7uv8ixprikzT X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:57:51 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374727417791702 X-GMAIL-MSGID: 1783374727417791702 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/ti_am335x_tscadc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c index b88eb70c17b3..4bbd542d753e 100644 --- a/drivers/mfd/ti_am335x_tscadc.c +++ b/drivers/mfd/ti_am335x_tscadc.c @@ -298,7 +298,7 @@ static int ti_tscadc_probe(struct platform_device *pdev) return err; } -static int ti_tscadc_remove(struct platform_device *pdev) +static void ti_tscadc_remove(struct platform_device *pdev) { struct ti_tscadc_dev *tscadc = platform_get_drvdata(pdev); @@ -308,8 +308,6 @@ static int ti_tscadc_remove(struct platform_device *pdev) pm_runtime_disable(&pdev->dev); mfd_remove_devices(tscadc->dev); - - return 0; } static int __maybe_unused ti_tscadc_can_wakeup(struct device *dev, void *data) @@ -381,7 +379,7 @@ static struct platform_driver ti_tscadc_driver = { .of_match_table = ti_tscadc_dt_ids, }, .probe = ti_tscadc_probe, - .remove = ti_tscadc_remove, + .remove_new = ti_tscadc_remove, }; From patchwork Thu Nov 23 16:56:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169032 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp581535vqx; Thu, 23 Nov 2023 08:57:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IFhKSnfGRFgJ3xa307eY9blEc8uPvw7/Pr4W8O7bTQ3Q8wc2dVu0f1CK6kMYq9Si6Juyo1D X-Received: by 2002:a17:903:24c:b0:1ce:5b93:1596 with SMTP id j12-20020a170903024c00b001ce5b931596mr114530plh.5.1700758656538; Thu, 23 Nov 2023 08:57:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758656; cv=none; d=google.com; s=arc-20160816; b=seldIHq8TDTU0dnX2pz81HZwGJ75urPNDuFfz/SRg3ZVf3yCPPbWJ7PfwtF4QnF1kQ bq8EeEqc31qGa5ZoodFevxAHfObPgYwbJZqIIctBq6kYgzUeZXYNZOSUHY7ADiosZYJx gLNm4wPqZJCgkeeNFpRZjEr5ts5GP4Pr/UuqPGLRQJBa0LDeGzkMd/LbgurMPMHz/9K+ mjHvLxahd7dQ9ceJys0exL7XJLllnWDobtawy6PD0Oq0eugGPeuP6kOjKW6nQ6yRsTuZ ZNBJn7vboQGtjpBWcs7R7JooQfbFUSeTWRexzM5U1EbFv0ho7cicBrUkUWrQUZJdi0H/ RsJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=24wHeGRzEXMmta/hQR1yTMU63wiGv4/BkFZZuSLtfYY=; fh=Zdg/IaJWIkan+8kr6bDKmrlAn6GL271tZGmx1ajMHC0=; b=ImNf+UjumK7o7jlx7aydBLe0dCL6PARnrvQUR+bIXa4FTF2RQJ3uGa7mjWbQF8VhHr uES1XYL7+X4h9DokjKtgQg4/oGp67kExkbxfevlxrstEPAspxVTmQMm/wkxjKAscJdL5 wJXgDWAqu6EKSXnP6z8A2BmaEFj9GV/83+TUeOqKYpWseSVMEUCLmBGim2myJB0iGn6K f6Cn7tsWvOcewOgyWAp25nLUnec4B5Y/Dz8+ATkoZgwSkAX5jubPFJFzOrI6yRIKnuh5 Ufq7OqrOrZoaG9yNVyC4RVFM1DOn2xbVjr+wFaiXIXG5AKecZuae2iAorRY3KBUKNGTG Ga6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id s6-20020a170902ea0600b001cb02e6f149si1547397plg.538.2023.11.23.08.57.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 08:57:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 7BF18824E53D; Thu, 23 Nov 2023 08:57:31 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345339AbjKWQ5R (ORCPT + 99 others); Thu, 23 Nov 2023 11:57:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345145AbjKWQ46 (ORCPT ); Thu, 23 Nov 2023 11:56:58 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49236D42 for ; Thu, 23 Nov 2023 08:57:04 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0g-00058v-MR; Thu, 23 Nov 2023 17:57:02 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0g-00B55X-9s; Thu, 23 Nov 2023 17:57:02 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0g-006p08-0j; Thu, 23 Nov 2023 17:57:02 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 17/18] mfd: tps65911-comparator: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:45 +0100 Message-ID: <20231123165627.492259-18-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1926; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=DS/bp0Y0SVGN2rxRjkqNDXNDiJW5c7dknT63m3wnUL0=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RPuliNKk8BbKe9n0XXWQ4RFLhS0vJCQB6pC DrWE2WIpRuJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+ETwAKCRCPgPtYfRL+ Tq/hB/9U5uK3C/E0qQE1XN08NxkYDjSWNC4dbR5jjSSKuRmoMI8gTsSDNv3DoPuc4gnWelJuKC6 Ma9cm4OjpqmKbLrWJJrDz7gm1TZFnm8uVKpCrciM9LIcI4HJdN7UXIAeRDerSf7WxM6A72fzT+E jKhDQa2EQuYmy17k5vZdAqXtL8qNDSghg2l+miMezfZi8Dx1Er7k2Rqa2x2k8mHYTT4gk815wc+ CfpMKMaOCBNY3/S1Kf7lDYrt51v8Btv2mV0+UDPV/vmbsV41oUjKJzRfog+A5D1ktSXUXHmS4LO ku+89U/RF+v0wvHHfu4G2TJtB6Dlygj8IsH14ELnJ3TqSUcy X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:57:31 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374709377437776 X-GMAIL-MSGID: 1783374709377437776 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/tps65911-comparator.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/tps65911-comparator.c b/drivers/mfd/tps65911-comparator.c index 8f4210075913..f206a9c50e9d 100644 --- a/drivers/mfd/tps65911-comparator.c +++ b/drivers/mfd/tps65911-comparator.c @@ -140,15 +140,13 @@ static int tps65911_comparator_probe(struct platform_device *pdev) return ret; } -static int tps65911_comparator_remove(struct platform_device *pdev) +static void tps65911_comparator_remove(struct platform_device *pdev) { struct tps65910 *tps65910; tps65910 = dev_get_drvdata(pdev->dev.parent); device_remove_file(&pdev->dev, &dev_attr_comp2_threshold); device_remove_file(&pdev->dev, &dev_attr_comp1_threshold); - - return 0; } static struct platform_driver tps65911_comparator_driver = { @@ -156,7 +154,7 @@ static struct platform_driver tps65911_comparator_driver = { .name = "tps65911-comparator", }, .probe = tps65911_comparator_probe, - .remove = tps65911_comparator_remove, + .remove_new = tps65911_comparator_remove, }; static int __init tps65911_comparator_init(void) From patchwork Thu Nov 23 16:56:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 169041 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp583787vqx; Thu, 23 Nov 2023 09:01:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IHSOdWToautDZ6vH+Yd7sk+gWJhWXPI5U9nxK0rVwiCV+KvucpgaFYj65sSo1WxfymtQrp4 X-Received: by 2002:a9d:7d13:0:b0:6d6:4e53:c81b with SMTP id v19-20020a9d7d13000000b006d64e53c81bmr108614otn.8.1700758876079; Thu, 23 Nov 2023 09:01:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700758876; cv=none; d=google.com; s=arc-20160816; b=SouIHqwHBrgdnnUJ/SueLP1bglPKcBnXd4eUpulsXicOTWBuFiroLcrLzcXk+DcPH7 YLRWz1BE/l8Dxdge7rl4J10kgDioGI73l+LkvX/NNI2f+w43Z0iGjFGYgA1XF3WvLpta Rcn8KtqGcz/yicv3MKFI22hLRIqVp77x5sIo0nq32JhIjZB4zUwlhwILnemYi+sDzRbH KBl8NcoXJPax6A+UzMYmRwbJW24LCkztkF46gaKQPbVkBLAS3/TWtOWwzoIxgto415GO jIweB4v5oKNt6YVSKgYRLOPNmkCh6O+Yjxx+xrOeFlYCqkdE/n91W4P7MdyfvrcZMAbr cgHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=RZPZZxk4zSze1zxYsEPHU0lc2/suMkEahxFOBerIKEQ=; fh=MPr1O/33eOLDJUuxTfiG33qwsHqzUAGRVnE+SCXoc58=; b=nCsbIOjBK3gZEDhUk5NjgTL194WEdYDvMXtsxbI6sAweQnIsO0auvz8koWMttNMh7e bbBNLgrjQUC+6ugjyNemfHR4kiayfFybGYTWce5PW5AK8e2bW/Bu6ayiKUOlZz+1t6tq 7v6V8ynSLabghvC0yeoeV4Nbc2QtqMbl/EIcSAan5RnMVA191zq0YNruI1vzK3ZG2kd3 sIcUlIn2uuaVG7iue+HjcgDbqsVqLuLgTE4aWW1DFHL7ux4UPUwbEb2tQGofUIkKugjG 4Kg4xcWKBLzqmU9OVbhA22oMsxd8rPoop5pgCziwWBQ3rJ0+adXOQ+7b3B7KE4S4r9Ei 8Jpg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id el35-20020a05683071a300b006ce2a8bed77si688023otb.108.2023.11.23.09.01.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 09:01:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id AB21D8131A88; Thu, 23 Nov 2023 08:57:51 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231222AbjKWQ5l (ORCPT + 99 others); Thu, 23 Nov 2023 11:57:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345236AbjKWQ5F (ORCPT ); Thu, 23 Nov 2023 11:57:05 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46C6AD7D for ; Thu, 23 Nov 2023 08:57:09 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0h-00059B-0C; Thu, 23 Nov 2023 17:57:03 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0g-00B55c-Jp; Thu, 23 Nov 2023 17:57:02 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0g-006p0C-AV; Thu, 23 Nov 2023 17:57:02 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Lee Jones Cc: Tony Lindgren , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 18/18] mfd: twl4030-audio: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:46 +0100 Message-ID: <20231123165627.492259-19-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1723; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=DEtnBZo9+Rw2avXE1cyu5z7dDDmV5UUxzQ8KgZxe55o=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RQBLGaD9pFfd1Eg7BbBRcTWakbniKn95iPB cQ9N7fsf4uJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+EUAAKCRCPgPtYfRL+ Tvh2B/0YkRZYVT9s0hWo0DjSZZuxSkD8Rl/758nwco+aLXlRzC2A5W4oAkrVaSs/LvQj18zku32 Cz8tHBwDUbpykspjmGEkFpG7PLPVEgOUBxsDSuhRfN7zacoZG0jk6x0+ySCHaR1zh7Zh3BoVbfz Z6UCyw5jTTtm19/VJN++oB0/dGja6F2LBPCt1ajKF1aDm9rv43NN0yKyx877d3Z2CsJEEJ6ObE7 LZurYaIlvvCSCVkrfCeiZcGoIEqEcsO+qQsITI+A18Y3AHozwZUFYQNo/P+D30gwA0Hr61Ksg+i 4mjJQeq8mV5dA0YKds3GTIIy9h1u4KMGBWkWRtXVnVVYxo6j X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 23 Nov 2023 08:57:51 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783374939044465637 X-GMAIL-MSGID: 1783374939044465637 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/mfd/twl4030-audio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/twl4030-audio.c b/drivers/mfd/twl4030-audio.c index 88002f8941e5..d436ddf661da 100644 --- a/drivers/mfd/twl4030-audio.c +++ b/drivers/mfd/twl4030-audio.c @@ -258,12 +258,10 @@ static int twl4030_audio_probe(struct platform_device *pdev) return ret; } -static int twl4030_audio_remove(struct platform_device *pdev) +static void twl4030_audio_remove(struct platform_device *pdev) { mfd_remove_devices(&pdev->dev); twl4030_audio_dev = NULL; - - return 0; } static const struct of_device_id twl4030_audio_of_match[] = { @@ -278,7 +276,7 @@ static struct platform_driver twl4030_audio_driver = { .of_match_table = twl4030_audio_of_match, }, .probe = twl4030_audio_probe, - .remove = twl4030_audio_remove, + .remove_new = twl4030_audio_remove, }; module_platform_driver(twl4030_audio_driver);