From patchwork Thu Nov 23 12:04:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Clark X-Patchwork-Id: 168903 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp395247vqx; Thu, 23 Nov 2023 04:08:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IGszp/Tudw1tAYMF9Ey5kmPm1LmQoTkenhVKRWxUm/vD+l6357atPGi+LYE3DCRHPz5DLpx X-Received: by 2002:a05:6a20:6a1c:b0:18b:8d6c:d63 with SMTP id p28-20020a056a206a1c00b0018b8d6c0d63mr2087920pzk.7.1700741306351; Thu, 23 Nov 2023 04:08:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700741305; cv=none; d=google.com; s=arc-20160816; b=Iq/RfOzpH77TxnSimH9foglo/tnf3ZdPYDgLCpzHgFsvsdN2TiCcTx18iGlusH/SU7 KHWtetSFLLvYRPj8acwOfKxhRvMABdtHop1uRVZFC+h1ogLdhwIqltxYA+kyRfYYLOow g9mg4H28bxd0MOtZ0viTWd9yUCQSisx1R9SgX+ooIjlLAysO5klU5NB/ju9bL7NWC18V J6V4hCPsP1CPK3eFr24QEv6DK82f+MzQE2EzyF/y6E8UL6t7dhBfdNRGNDMSIgy8Xrx5 mSVrHvhoAC1fm7n1NdavLnhLdLfXSXc+O298q7WE3gXU8a7sO46xIBLKvi2mLrNzQkdv HiKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=k2zcsa+CetBQirU3Bp6mZXjT+COPFfSxcCx6PYpfnqA=; fh=L0mtDxzbexvY93/TXVDPqRiMSUezBOF86XyL0RxKhcM=; b=qrgVC+gD5N2lXKMjUGuxIhCGmqOrl+BjUVcofmsy7rghHl8Vu5Oy+FcnPsGnNwircA JXNACqfR9Kx1JbhDw34Oi+na1aht4uvRUinpSxGqF4HNE3i/szjhqE463KdjbM/0Rebh oytIpO+y/XXsXhUGLG3k1HG5eMb0pLeJVhxqZifjn+8ZuZUwPVxBDhGnO9gXVMRGN9An 7AdwagbxybSQvhg/X7QVg1WSZn8G/h8rCD1zMWvxOgWZ0BQ9EeXZ/erI8EGEwb2YcCp7 1GlOv3eMQAZ7fwRj88GBt98QUPZK0dliVF8ZdjXreNdvfJPZsreXqkJyJnwa1UZR9dZ4 a/tA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id w16-20020a63f510000000b005c2783b71cfsi1177319pgh.810.2023.11.23.04.08.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 04:08:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 97185801BA6D; Thu, 23 Nov 2023 04:06:37 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345224AbjKWMGX (ORCPT + 99 others); Thu, 23 Nov 2023 07:06:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345196AbjKWMGU (ORCPT ); Thu, 23 Nov 2023 07:06:20 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 16F84B2 for ; Thu, 23 Nov 2023 04:06:26 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1A0271063; Thu, 23 Nov 2023 04:07:13 -0800 (PST) Received: from e127643.arm.com (unknown [10.57.3.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 198543F7A6; Thu, 23 Nov 2023 04:06:24 -0800 (PST) From: James Clark To: coresight@lists.linaro.org, suzuki.poulose@arm.com Cc: James Clark , Mike Leach , Alexander Shishkin , Maxime Coquelin , Alexandre Torgue , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: [PATCH v3 1/4] coresight: Fix uninitialized struct warnings Date: Thu, 23 Nov 2023 12:04:56 +0000 Message-Id: <20231123120459.287578-2-james.clark@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231123120459.287578-1-james.clark@arm.com> References: <20231123120459.287578-1-james.clark@arm.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 23 Nov 2023 04:06:37 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783356515241521535 X-GMAIL-MSGID: 1783356515241521535 These warnings would be hit with the following W=1 build change so initialize all structs properly. Signed-off-by: James Clark --- drivers/hwtracing/coresight/coresight-cti-core.c | 2 +- drivers/hwtracing/coresight/coresight-etb10.c | 2 +- drivers/hwtracing/coresight/coresight-etm3x-core.c | 2 +- drivers/hwtracing/coresight/coresight-etm4x-core.c | 2 +- drivers/hwtracing/coresight/coresight-funnel.c | 4 ++-- drivers/hwtracing/coresight/coresight-replicator.c | 2 +- drivers/hwtracing/coresight/coresight-stm.c | 2 +- drivers/hwtracing/coresight/coresight-tmc-core.c | 2 +- drivers/hwtracing/coresight/coresight-tpda.c | 2 +- drivers/hwtracing/coresight/coresight-tpdm.c | 2 +- drivers/hwtracing/coresight/coresight-tpiu.c | 2 +- drivers/hwtracing/coresight/ultrasoc-smb.c | 2 +- 12 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-cti-core.c b/drivers/hwtracing/coresight/coresight-cti-core.c index 3999d0a2cb60..e805617020d0 100644 --- a/drivers/hwtracing/coresight/coresight-cti-core.c +++ b/drivers/hwtracing/coresight/coresight-cti-core.c @@ -974,7 +974,7 @@ static const struct amba_id cti_ids[] = { CS_AMBA_ID(0x000bb9aa), /* CTI - C-A73 */ CS_AMBA_UCI_ID(0x000bb9da, uci_id_cti), /* CTI - C-A35 */ CS_AMBA_UCI_ID(0x000bb9ed, uci_id_cti), /* Coresight CTI (SoC 600) */ - { 0, 0}, + { 0, 0, NULL }, }; MODULE_DEVICE_TABLE(amba, cti_ids); diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c index fa80039e0821..05e21cffd33b 100644 --- a/drivers/hwtracing/coresight/coresight-etb10.c +++ b/drivers/hwtracing/coresight/coresight-etb10.c @@ -837,7 +837,7 @@ static const struct amba_id etb_ids[] = { .id = 0x000bb907, .mask = 0x000fffff, }, - { 0, 0}, + { 0, 0, NULL }, }; MODULE_DEVICE_TABLE(amba, etb_ids); diff --git a/drivers/hwtracing/coresight/coresight-etm3x-core.c b/drivers/hwtracing/coresight/coresight-etm3x-core.c index 116a91d90ac2..8da1622e0837 100644 --- a/drivers/hwtracing/coresight/coresight-etm3x-core.c +++ b/drivers/hwtracing/coresight/coresight-etm3x-core.c @@ -1003,7 +1003,7 @@ static const struct amba_id etm_ids[] = { CS_AMBA_ID_DATA(0x000bb95f, "PTM 1.1"), /* PTM 1.1 Qualcomm */ CS_AMBA_ID_DATA(0x000b006f, "PTM 1.1"), - { 0, 0}, + { 0, 0, NULL}, }; MODULE_DEVICE_TABLE(amba, etm_ids); diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c index ce1995a2827f..c5ea808ea662 100644 --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c @@ -2390,7 +2390,7 @@ static const struct of_device_id etm4_sysreg_match[] = { #ifdef CONFIG_ACPI static const struct acpi_device_id etm4x_acpi_ids[] = { - {"ARMHC500", 0}, /* ARM CoreSight ETM4x */ + {"ARMHC500", 0, 0, 0}, /* ARM CoreSight ETM4x */ {} }; MODULE_DEVICE_TABLE(acpi, etm4x_acpi_ids); diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c index a5b1fc787766..ef1a0abfee4e 100644 --- a/drivers/hwtracing/coresight/coresight-funnel.c +++ b/drivers/hwtracing/coresight/coresight-funnel.c @@ -350,7 +350,7 @@ MODULE_DEVICE_TABLE(of, static_funnel_match); #ifdef CONFIG_ACPI static const struct acpi_device_id static_funnel_ids[] = { - {"ARMHC9FE", 0}, + {"ARMHC9FE", 0, 0, 0}, {}, }; @@ -391,7 +391,7 @@ static const struct amba_id dynamic_funnel_ids[] = { .id = 0x000bb9eb, .mask = 0x000fffff, }, - { 0, 0}, + { 0, 0, NULL }, }; MODULE_DEVICE_TABLE(amba, dynamic_funnel_ids); diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c index 91d93060dda5..73452d9dc13b 100644 --- a/drivers/hwtracing/coresight/coresight-replicator.c +++ b/drivers/hwtracing/coresight/coresight-replicator.c @@ -363,7 +363,7 @@ MODULE_DEVICE_TABLE(of, static_replicator_match); #ifdef CONFIG_ACPI static const struct acpi_device_id static_replicator_acpi_ids[] = { - {"ARMHC985", 0}, /* ARM CoreSight Static Replicator */ + {"ARMHC985", 0, 0, 0}, /* ARM CoreSight Static Replicator */ {} }; diff --git a/drivers/hwtracing/coresight/coresight-stm.c b/drivers/hwtracing/coresight/coresight-stm.c index a1c27c901ad1..891ee64efed8 100644 --- a/drivers/hwtracing/coresight/coresight-stm.c +++ b/drivers/hwtracing/coresight/coresight-stm.c @@ -950,7 +950,7 @@ static const struct dev_pm_ops stm_dev_pm_ops = { static const struct amba_id stm_ids[] = { CS_AMBA_ID_DATA(0x000bb962, "STM32"), CS_AMBA_ID_DATA(0x000bb963, "STM500"), - { 0, 0}, + { 0, 0, NULL }, }; MODULE_DEVICE_TABLE(amba, stm_ids); diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwtracing/coresight/coresight-tmc-core.c index 7ec5365e2b64..39bae35d4ffd 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-core.c +++ b/drivers/hwtracing/coresight/coresight-tmc-core.c @@ -594,7 +594,7 @@ static const struct amba_id tmc_ids[] = { CS_AMBA_ID(0x000bb9e9), /* Coresight SoC 600 TMC-ETF */ CS_AMBA_ID(0x000bb9ea), - { 0, 0}, + { 0, 0, NULL }, }; MODULE_DEVICE_TABLE(amba, tmc_ids); diff --git a/drivers/hwtracing/coresight/coresight-tpda.c b/drivers/hwtracing/coresight/coresight-tpda.c index 5f82737c37bb..4ac954f4bc13 100644 --- a/drivers/hwtracing/coresight/coresight-tpda.c +++ b/drivers/hwtracing/coresight/coresight-tpda.c @@ -300,7 +300,7 @@ static struct amba_id tpda_ids[] = { .id = 0x000f0f00, .mask = 0x000fff00, }, - { 0, 0}, + { 0, 0, NULL }, }; static struct amba_driver tpda_driver = { diff --git a/drivers/hwtracing/coresight/coresight-tpdm.c b/drivers/hwtracing/coresight/coresight-tpdm.c index 97654aa4b772..bd13a548375c 100644 --- a/drivers/hwtracing/coresight/coresight-tpdm.c +++ b/drivers/hwtracing/coresight/coresight-tpdm.c @@ -933,7 +933,7 @@ static struct amba_id tpdm_ids[] = { .id = 0x000f0e00, .mask = 0x000fff00, }, - { 0, 0}, + { 0, 0, NULL }, }; static struct amba_driver tpdm_driver = { diff --git a/drivers/hwtracing/coresight/coresight-tpiu.c b/drivers/hwtracing/coresight/coresight-tpiu.c index 59eac93fd6bb..7e69048ac944 100644 --- a/drivers/hwtracing/coresight/coresight-tpiu.c +++ b/drivers/hwtracing/coresight/coresight-tpiu.c @@ -218,7 +218,7 @@ static const struct amba_id tpiu_ids[] = { .id = 0x000bb9e7, .mask = 0x000fffff, }, - { 0, 0}, + { 0, 0, NULL }, }; MODULE_DEVICE_TABLE(amba, tpiu_ids); diff --git a/drivers/hwtracing/coresight/ultrasoc-smb.c b/drivers/hwtracing/coresight/ultrasoc-smb.c index 10e886455b8b..f0b6806202d1 100644 --- a/drivers/hwtracing/coresight/ultrasoc-smb.c +++ b/drivers/hwtracing/coresight/ultrasoc-smb.c @@ -586,7 +586,7 @@ static void smb_remove(struct platform_device *pdev) #ifdef CONFIG_ACPI static const struct acpi_device_id ultrasoc_smb_acpi_match[] = { - {"HISI03A1", 0}, + {"HISI03A1", 0, 0, 0}, {} }; MODULE_DEVICE_TABLE(acpi, ultrasoc_smb_acpi_match); From patchwork Thu Nov 23 12:04:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Clark X-Patchwork-Id: 168900 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp394578vqx; Thu, 23 Nov 2023 04:07:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IFxrHy7siH2tF36Jm1aE0mgsD1JccQQ/c4pepqQOO+5gYOoyTJ7Tz1T6Coao6aMS7yk7oIu X-Received: by 2002:a05:6a20:429b:b0:187:be84:38dd with SMTP id o27-20020a056a20429b00b00187be8438ddmr5518156pzj.62.1700741242801; Thu, 23 Nov 2023 04:07:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700741242; cv=none; d=google.com; s=arc-20160816; b=euoKr6Qq6D6jGD5LNPVf7QQkMJPGXdVMS2QNmNbnlajh9xKFdVf8tAxWaVJe3imIyM if6OipTuxI57454uqJFQ6Gy58usxW6V31DH5jBZv4CO4O8QkMDZlzzDz7e08LHC4dNsm 6Y1D4SPbudQlg3XvLigCyIJPIg69aQOI48Rmpzim008imGVoy5j2kMaLx7OJyjU/J1Ge kRUfI+kSLHviu319KdlDt32jNkZB9rtkgqOnetM+LTGJC/Y0vBL2Scud1DnUu8nWaxOH ehvh8CHlk/P135qKxDcqIYjEaVfCCIRcFxa1bzbXLmhaI8wNDrKPLmwLj9chroEG00KD hGUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=M18piu2VvihfdURupoT6XT0rD8JA0nysiKs5whZsC/I=; fh=L0mtDxzbexvY93/TXVDPqRiMSUezBOF86XyL0RxKhcM=; b=tPcW9fDyo79iTRMu9C/pr3j8JNAltDyOKKq3pCOAEaHQ+UFVy5i5XeWEiT/ioFgJxj hoRWTYT+mWJaerlVTs6fTrXrtWlqkmS2YL2IIfVUWu9xcWhgJeJrGA6h44WF3+QOTspy c0Wn5v3uZjJXXZ8PACVvPwv2I/vhzdorc1PrHnPBaXh2gVGVr4G9osRybOOG+C10ukHP +n057XMC4qNpciXI0O4FTjO8TxDvF0wz5iriAqvG0wxs+iOhB5CaJjdwlgerWh7AfMd5 RAHWPeK9xmziS/bE2AA5JRoNErONIWH+1nU6qKcZwkHYwHgJd422hWIq/WTLeD0pxk8L 9izQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id p9-20020a63c149000000b005b8f181b729si1217553pgi.360.2023.11.23.04.07.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 04:07:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 6313581E3E32; Thu, 23 Nov 2023 04:06:45 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345196AbjKWMG1 (ORCPT + 99 others); Thu, 23 Nov 2023 07:06:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345223AbjKWMGX (ORCPT ); Thu, 23 Nov 2023 07:06:23 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AC5EB91 for ; Thu, 23 Nov 2023 04:06:29 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DE13912FC; Thu, 23 Nov 2023 04:07:15 -0800 (PST) Received: from e127643.arm.com (unknown [10.57.3.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D47BA3F7A6; Thu, 23 Nov 2023 04:06:27 -0800 (PST) From: James Clark To: coresight@lists.linaro.org, suzuki.poulose@arm.com Cc: James Clark , Mike Leach , Alexander Shishkin , Maxime Coquelin , Alexandre Torgue , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: [PATCH v3 2/4] coresight: etm3x: Fix build warning Date: Thu, 23 Nov 2023 12:04:57 +0000 Message-Id: <20231123120459.287578-3-james.clark@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231123120459.287578-1-james.clark@arm.com> References: <20231123120459.287578-1-james.clark@arm.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Thu, 23 Nov 2023 04:06:45 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783356449198263353 X-GMAIL-MSGID: 1783356449198263353 The missing * in the comment block causes the following warning, so fix it: hwtracing/coresight/coresight-etm3x-core.c:118: warning: bad line: Signed-off-by: James Clark --- drivers/hwtracing/coresight/coresight-etm3x-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-etm3x-core.c b/drivers/hwtracing/coresight/coresight-etm3x-core.c index 8da1622e0837..74ae26911b8a 100644 --- a/drivers/hwtracing/coresight/coresight-etm3x-core.c +++ b/drivers/hwtracing/coresight/coresight-etm3x-core.c @@ -115,7 +115,7 @@ static void etm_clr_pwrup(struct etm_drvdata *drvdata) * * Basically the same as @coresight_timeout except for the register access * method where we have to account for CP14 configurations. - + * * Return: 0 as soon as the bit has taken the desired state or -EAGAIN if * TIMEOUT_US has elapsed, which ever happens first. */ From patchwork Thu Nov 23 12:04:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Clark X-Patchwork-Id: 168899 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp394405vqx; Thu, 23 Nov 2023 04:07:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IGdS6xSrPDhoxew7pRlqinI01TaOtZlSVuUmGRJbW94VEQf2fw290BOM0HDAa5Cvd5ulsx3 X-Received: by 2002:a17:903:4284:b0:1cc:4a70:1373 with SMTP id ju4-20020a170903428400b001cc4a701373mr4675189plb.58.1700741225124; Thu, 23 Nov 2023 04:07:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700741225; cv=none; d=google.com; s=arc-20160816; b=N1BbGoHPkOnvhHzzAZkNaV0WSK0FC/tGRNf1wGOPzdnj0K7gu/IIWdBLGMGkz+h6XI Caqvoyxdnp9vHWjOUGHQqa2CYAbEMKJtP/WHybjHAbFh1yEWqT3yrjajo8bEwmo1Nv2h u980AcSrBNpE0y1Vtd2wWSwd3dYSIU1nDsHV5zeORI9XFou+JRKSPBEKaPIbFTy+D4z2 YIylVspCvasTNwdCQB734Z57Ou8morFXdqpBEIsOtbvq23OhpVPS2tJ9wNXno+PzNJ6V tk+pr/jkAbVplUsEBRoFt8LiB63Y8wc68WSH8CIE/sZOIDAWkei5Ojtx8m5Zzsd3HZGW px9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=8a4ACM5urlIH/FTLgILfMOTkFX871c/y/R9emkBHUmM=; fh=L0mtDxzbexvY93/TXVDPqRiMSUezBOF86XyL0RxKhcM=; b=CBtNIoHysShr6COs6sWsXkc6JAOYQW7dRgID8SJP8W7esv7ebO54L+ztBHsiH2P5k4 l1/sSjNGknq8JYThO7jxa1p8l/c9p7XhwliHgshTH3Qmw5mIPm8nzB3dPr5PI3ygE5bn 6/h0affzgsfY+6+NLoiC2fuADpPi3cRyoEwhtt16RAd8puDhqKm5zZpjeHUWBbASYko3 EG+bWeT0n2DZaod2ucN49xpygdrZjkOawJluHtInmOxwlz+88kq8jBb4pmD5Ev1lNdhE 4iWrkNaT1KhFvIzioPZhdHu0eBotigewayKWp1oPJkBVtC2eJwvXD7WgRc1Xj0PeD/Ym Kh2g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id f7-20020a17090274c700b001cf639e5bbdsi967630plt.270.2023.11.23.04.06.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 04:07:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 8D18880847BD; Thu, 23 Nov 2023 04:06:52 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345232AbjKWMGc (ORCPT + 99 others); Thu, 23 Nov 2023 07:06:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345243AbjKWMG0 (ORCPT ); Thu, 23 Nov 2023 07:06:26 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A1FD9D56 for ; Thu, 23 Nov 2023 04:06:32 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B457D1042; Thu, 23 Nov 2023 04:07:18 -0800 (PST) Received: from e127643.arm.com (unknown [10.57.3.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A56DA3F7A6; Thu, 23 Nov 2023 04:06:30 -0800 (PST) From: James Clark To: coresight@lists.linaro.org, suzuki.poulose@arm.com Cc: James Clark , Mike Leach , Alexander Shishkin , Maxime Coquelin , Alexandre Torgue , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: [PATCH v3 3/4] coresight: Fix undeclared variable warnings from sparse checker Date: Thu, 23 Nov 2023 12:04:58 +0000 Message-Id: <20231123120459.287578-4-james.clark@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231123120459.287578-1-james.clark@arm.com> References: <20231123120459.287578-1-james.clark@arm.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 23 Nov 2023 04:06:52 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783356431059952696 X-GMAIL-MSGID: 1783356431059952696 Including the header with the declarations fixes the following warning with a C=1 build: coresight-cfg-afdo.c:102:27: warning: symbol 'strobe_etm4x' was not declared. Should it be static? coresight-cfg-afdo.c:141:26: warning: symbol 'afdo_etm4x' was not declared. Should it be static? Signed-off-by: James Clark --- drivers/hwtracing/coresight/coresight-cfg-afdo.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hwtracing/coresight/coresight-cfg-afdo.c b/drivers/hwtracing/coresight/coresight-cfg-afdo.c index 84b31184252b..e794f2e145fa 100644 --- a/drivers/hwtracing/coresight/coresight-cfg-afdo.c +++ b/drivers/hwtracing/coresight/coresight-cfg-afdo.c @@ -9,6 +9,7 @@ /* ETMv4 includes and features */ #if IS_ENABLED(CONFIG_CORESIGHT_SOURCE_ETM4X) #include "coresight-etm4x-cfg.h" +#include "coresight-cfg-preload.h" /* preload configurations and features */ From patchwork Thu Nov 23 12:04:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Clark X-Patchwork-Id: 168904 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp395259vqx; Thu, 23 Nov 2023 04:08:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IHnwr5pQ/Y20+f5SsLYHXdtYDq0Y6JiLaIssdHP6MrhsOlS8m+2AIqWRLl0KR50BT0d9nvZ X-Received: by 2002:a05:6a20:3954:b0:186:9a3f:f2c4 with SMTP id r20-20020a056a20395400b001869a3ff2c4mr5737183pzg.47.1700741307994; Thu, 23 Nov 2023 04:08:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700741307; cv=none; d=google.com; s=arc-20160816; b=W1/5CzPoY+LamjEBQJd5XAXdqxXEE7Ai6BXZqEVWSykT0GV/7DOW+NdEE/SGYYtpn5 oVX78ks07L0FFll74xh3Y/+rcKXAcLryUYUhJx4qEq3Qj96LtY7YR22qF2s+9JP7zHu+ y1V03kZzJU2HuAiRGjdXt0Eqc4UlBwOYlttRvOXQNxOWzPIHtFcMdldD4S+jps7uX8on yQtkcDVHnnimFD6xgM25lxMxrO+TKvmeH2NSZC1076HHl56RePdOWpFDLC2hj+O/aXNR vkyyTkfAKhFJG+EN2d6VYcaSryQbJEP3dLX5UpKImC6WlZPOsQeMQOxjqPcWkBKEyiI2 tv4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=PaRhRaJkWJKXngTv6njtzAikrYv5uSmXPtXdBrqYaQk=; fh=L0mtDxzbexvY93/TXVDPqRiMSUezBOF86XyL0RxKhcM=; b=PzDhog/u15JVGMYIC8X3bmYn0S/qjyLUUKWyZ35xB0yNrD4aaDhxhT77ZAdpO0JW61 paJBNklf7cJrZ0Eca36Qzjsip7mNZMtlwrT4gNAv+tBO2sDpA1Vw98Q2v6/AoLNgzjAC 2+v2C5NlVamExV6xCzoHcTlOAHQj7buYeOoum2w5Eb3tQyLwm89Oj3dXg+TQRPAoImJ0 A3WvUECoaaBTHfUTBd9on/j4QXXjeF6hmOFASmISv3ZUfm+HLd/LOdzmJ64AMT6lr+B5 2/vM+orplMYpzF1TiJ+VH3Q95vkSSUdwNJS13kV+NpNyKbLIXi6Wglhc4YPxk9aKPnnd XaVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id n7-20020a635907000000b0056b024a4dd0si1083324pgb.614.2023.11.23.04.08.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 04:08:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id C3CE3816EBCB; Thu, 23 Nov 2023 04:06:55 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345259AbjKWMGg (ORCPT + 99 others); Thu, 23 Nov 2023 07:06:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345237AbjKWMG3 (ORCPT ); Thu, 23 Nov 2023 07:06:29 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5C650D5C for ; Thu, 23 Nov 2023 04:06:35 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 842941063; Thu, 23 Nov 2023 04:07:21 -0800 (PST) Received: from e127643.arm.com (unknown [10.57.3.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 830F53F7A6; Thu, 23 Nov 2023 04:06:33 -0800 (PST) From: James Clark To: coresight@lists.linaro.org, suzuki.poulose@arm.com Cc: James Clark , Mike Leach , Alexander Shishkin , Maxime Coquelin , Alexandre Torgue , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: [PATCH v3 4/4] coresight: Make current W=1 warnings default Date: Thu, 23 Nov 2023 12:04:59 +0000 Message-Id: <20231123120459.287578-5-james.clark@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231123120459.287578-1-james.clark@arm.com> References: <20231123120459.287578-1-james.clark@arm.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 23 Nov 2023 04:06:55 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783356515142856652 X-GMAIL-MSGID: 1783356518013544837 Similarly to drivers/gpu/drm/amd/amdgpu/Makefile and fs/btrfs/Makefile, copy the current set of W=1 warnings from Makefile.extrawarn to the coresight makefile to make them default. Unfortunately there is no easy way to do this without copying. In addition to the default set of warnings, add -Wno-sign-compare to disable that warning. That's because Makefile.extrawarn does some extra steps to disable some -Wextra warnings unless W=2 or W=3 are used. That's the only one that's needed for Coresight, so disable it. Signed-off-by: James Clark --- drivers/hwtracing/coresight/Makefile | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/hwtracing/coresight/Makefile b/drivers/hwtracing/coresight/Makefile index 995d3b2c76df..4ba478211b31 100644 --- a/drivers/hwtracing/coresight/Makefile +++ b/drivers/hwtracing/coresight/Makefile @@ -2,6 +2,26 @@ # # Makefile for CoreSight drivers. # + +# Current W=1 warnings +subdir-ccflags-y += -Wextra -Wunused -Wno-unused-parameter +subdir-ccflags-y += -Wmissing-declarations +subdir-ccflags-y += -Wmissing-format-attribute +subdir-ccflags-y += -Wmissing-prototypes +subdir-ccflags-y += -Wold-style-definition +subdir-ccflags-y += -Wmissing-include-dirs +subdir-ccflags-y += -Wno-sign-compare +condflags := \ + $(call cc-option, -Wrestrict) \ + $(call cc-option, -Wunused-but-set-variable) \ + $(call cc-option, -Wunused-const-variable) \ + $(call cc-option, -Wpacked-not-aligned) \ + $(call cc-option, -Wformat-overflow) \ + $(call cc-option, -Wformat-truncation) \ + $(call cc-option, -Wstringop-overflow) \ + $(call cc-option, -Wstringop-truncation) +subdir-ccflags-y += $(condflags) + obj-$(CONFIG_CORESIGHT) += coresight.o coresight-y := coresight-core.o coresight-etm-perf.o coresight-platform.o \ coresight-sysfs.o coresight-syscfg.o coresight-config.o \