From patchwork Thu Nov 23 10:47:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 168863 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp354484vqx; Thu, 23 Nov 2023 02:48:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IEs4aMTvTvzTO2etc2eHB9+2N4EhmJgsXVZh2Wr45WSv4tyWC3qXqTGPjGwpFJsuZUa8hML X-Received: by 2002:a05:6a21:6da8:b0:17e:8dfa:f37f with SMTP id wl40-20020a056a216da800b0017e8dfaf37fmr3188437pzb.18.1700736519232; Thu, 23 Nov 2023 02:48:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700736519; cv=none; d=google.com; s=arc-20160816; b=EEwmBam0I0HJh++UmkasuAWeIKJN0QOU7PD2THj9zLq9g85gAvwAiR9D5XU3712nEt fFpm8Yehk51OoqAXZT09iQgjykhvV47pooF89aPnT18QcdElekMn1p4OOPEyqij9yqdo E15761D/QqCPbKw8EbTUtIUyUMR41QtTsgP2z10/k8Rb6xA4/Zr6TNJDiMt4u8BmboDV LoKUJklbcpRA7IdFd+ATwgV/YJpHPc8ILzO3vaB+3tF3IFBUe4jtC5+bNsNtxt30cKmg Ted0I7wCkuHH6+ij9MeknrXf6/6CkN3J2bJCjUqRb2dTUiX4ie1ZRv70ZaxCOT49SOw6 3MTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=R6Y/EeGEJknzq58trBhL22VwM7NsO/4PakbC25QJlrU=; fh=0FcwSaQ/3idP4nRPn5wKcZ3BUOFktj3Xk5qi64iZZlE=; b=nkQURXCoJQ9IEVGnNdyoKSY9kBxiYwIpKD8x221LIw4zi57txIGocvCfoD2IW9js+t fuIgKLiNVj1W9BM8z2a81hvcV8z6fVNC1HP7fphdBtXTyMupV0AD7bLmDuUo4z+H7acU M2Ytxow+grQ1HeI2BPuYBc0vEADGbYTwko4pFDBb7WsOREO0LNDkciw92U5uN+fqC5Cn ckDlmekk/+9I+q61BPASB7quRyDtpIU3sv71YggcrSyRLVFSrI90W25e9z81p7um5m9B /ElCt58FpoKC9vrrDeiO15tX7B7qBbhw5GjyMDkPFtiguKH2jMcSjcmR+ZZNlGYkZVcf aztQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iRG8lggd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id i2-20020a635402000000b005b7160263f2si1058803pgb.154.2023.11.23.02.48.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 02:48:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iRG8lggd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 581038083AA6; Thu, 23 Nov 2023 02:48:36 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344796AbjKWKsK (ORCPT + 99 others); Thu, 23 Nov 2023 05:48:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344787AbjKWKsJ (ORCPT ); Thu, 23 Nov 2023 05:48:09 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BBD41BD for ; Thu, 23 Nov 2023 02:48:15 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54935C433C8; Thu, 23 Nov 2023 10:48:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700736495; bh=C+pNMYVLFZEmoFSbcwLsLirku3hsdHnT0ZOPIncJ5go=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iRG8lggdbvok32Jt1t2luxAHhXf4vpDXyQYUCywG0OpPWeBQRKMMXuvRbJcaLIoey FZ1gcHucb3rsW9yiPHTQKm3bdccnyCEAbJuAX+OoD8yy00Wg6ziFj/tiJ3BGlEJBd5 7nWYhp+sYVXFeZ3AJ9HVEzLvCKkdYbABk4ORpjfjSgArvEU6rtE3sNV6ME7SdtVHaU b6z4+SJYMdu7nUhBrj02zQA/CH/1gZmhV84bd0mp8PvtlXi7iETLVHTdxWuFUXIfF/ mwSihdNvMnJMeuorFxdmW93sUgIXg92TJwzBawfkX70Yf1KxpT7Gvnq47kAVKjtDn3 5VMKP+R09gD6g== From: Arnd Bergmann To: Michael Ellerman Cc: Arnd Bergmann , Nicholas Piggin , Christophe Leroy , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Jakub Kicinski Subject: [PATCH v2 1/3] powerpc: ps3: move udbg_shutdown_ps3gelic prototype Date: Thu, 23 Nov 2023 11:47:59 +0100 Message-Id: <20231123104801.15537-2-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231123104801.15537-1-arnd@kernel.org> References: <20231123104801.15537-1-arnd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 23 Nov 2023 02:48:36 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783351496416070146 X-GMAIL-MSGID: 1783351496416070146 From: Arnd Bergmann Allmodconfig kernels produce a missing-prototypes warning: arch/powerpc/platforms/ps3/gelic_udbg.c:239:6: error: no previous prototype for 'udbg_shutdown_ps3gelic' [-Werror=missing-prototypes] Move the declaration from a local header to asm/ps3.h where it can be seen from both the caller and the definition. As suggested by Michael Ellerman, remove the CONFIG_PS3GELIC_UDBG option to prevent this from causing a build regression. Acked-by: Jakub Kicinski Signed-off-by: Arnd Bergmann --- arch/powerpc/Kconfig.debug | 1 - arch/powerpc/include/asm/ps3.h | 6 ++++++ arch/powerpc/platforms/ps3/Kconfig | 12 ------------ arch/powerpc/platforms/ps3/Makefile | 2 +- arch/powerpc/platforms/ps3/gelic_udbg.c | 1 + drivers/net/ethernet/toshiba/ps3_gelic_net.h | 6 ------ 6 files changed, 8 insertions(+), 20 deletions(-) diff --git a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug index ea4033abc07d..8c80b154e814 100644 --- a/arch/powerpc/Kconfig.debug +++ b/arch/powerpc/Kconfig.debug @@ -271,7 +271,6 @@ config PPC_EARLY_DEBUG_USBGECKO config PPC_EARLY_DEBUG_PS3GELIC bool "Early debugging through the PS3 Ethernet port" depends on PPC_PS3 - select PS3GELIC_UDBG help Select this to enable early debugging for the PlayStation3 via UDP broadcasts sent out through the Ethernet port. diff --git a/arch/powerpc/include/asm/ps3.h b/arch/powerpc/include/asm/ps3.h index a5f36546a052..d13d8fdc3411 100644 --- a/arch/powerpc/include/asm/ps3.h +++ b/arch/powerpc/include/asm/ps3.h @@ -514,4 +514,10 @@ u64 ps3_get_spe_id(void *arg); void ps3_early_mm_init(void); +#ifdef CONFIG_PPC_EARLY_DEBUG_PS3GELIC +void udbg_shutdown_ps3gelic(void); +#else +static inline void udbg_shutdown_ps3gelic(void) {} +#endif + #endif diff --git a/arch/powerpc/platforms/ps3/Kconfig b/arch/powerpc/platforms/ps3/Kconfig index a44869e5ea70..e9c1087dd42e 100644 --- a/arch/powerpc/platforms/ps3/Kconfig +++ b/arch/powerpc/platforms/ps3/Kconfig @@ -167,16 +167,4 @@ config PS3_LPM profiling support of the Cell processor with programs like perfmon2, then say Y or M, otherwise say N. -config PS3GELIC_UDBG - bool "PS3 udbg output via UDP broadcasts on Ethernet" - depends on PPC_PS3 - help - Enables udbg early debugging output by sending broadcast UDP - via the Ethernet port (UDP port number 18194). - - This driver uses a trivial implementation and is independent - from the main PS3 gelic network driver. - - If in doubt, say N here. - endmenu diff --git a/arch/powerpc/platforms/ps3/Makefile b/arch/powerpc/platforms/ps3/Makefile index 86bf2967a8d4..bc79bb124d1e 100644 --- a/arch/powerpc/platforms/ps3/Makefile +++ b/arch/powerpc/platforms/ps3/Makefile @@ -3,7 +3,7 @@ obj-y += setup.o mm.o time.o hvcall.o htab.o repository.o obj-y += interrupt.o exports.o os-area.o obj-y += system-bus.o -obj-$(CONFIG_PS3GELIC_UDBG) += gelic_udbg.o +obj-$(CONFIG_PPC_EARLY_DEBUG_PS3GELIC) += gelic_udbg.o obj-$(CONFIG_SMP) += smp.o obj-$(CONFIG_SPU_BASE) += spu.o obj-y += device-init.o diff --git a/arch/powerpc/platforms/ps3/gelic_udbg.c b/arch/powerpc/platforms/ps3/gelic_udbg.c index 6b298010fd84..a5202c18c236 100644 --- a/arch/powerpc/platforms/ps3/gelic_udbg.c +++ b/arch/powerpc/platforms/ps3/gelic_udbg.c @@ -14,6 +14,7 @@ #include #include +#include #include #include #include diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.h b/drivers/net/ethernet/toshiba/ps3_gelic_net.h index 0d98defb011e..0ec7412febc7 100644 --- a/drivers/net/ethernet/toshiba/ps3_gelic_net.h +++ b/drivers/net/ethernet/toshiba/ps3_gelic_net.h @@ -346,12 +346,6 @@ static inline void *port_priv(struct gelic_port *port) return port->priv; } -#ifdef CONFIG_PPC_EARLY_DEBUG_PS3GELIC -void udbg_shutdown_ps3gelic(void); -#else -static inline void udbg_shutdown_ps3gelic(void) {} -#endif - int gelic_card_set_irq_mask(struct gelic_card *card, u64 mask); /* shared netdev ops */ void gelic_card_up(struct gelic_card *card); From patchwork Thu Nov 23 10:48:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 168864 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp354500vqx; Thu, 23 Nov 2023 02:48:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IGpUCqIjg06DuWRGvYaQu4WKNJEH+ND4gL6avWDCkyUMHBhFITRXsOdhlzBtvPCUJAH1UjY X-Received: by 2002:a05:6808:10c4:b0:3b8:4841:2bae with SMTP id s4-20020a05680810c400b003b848412baemr2945322ois.19.1700736523273; Thu, 23 Nov 2023 02:48:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700736523; cv=none; d=google.com; s=arc-20160816; b=FUYY8S0YhSoL2Pty1+w9grNjDKzRoIsN9m9YuZpQ4atoiDzPnQshrwm3yhklUVqpU1 r6QXShGhj8l3XbYmJKIVsBL4nReOT+ox+sBjSTFKLcnYKfkMCncC2LMr5ZvWyErkhV8/ h6UOWg2saaQsSaRY4yqwjM66wtmw2NIzednz0+eZP6wJBla3NpBVsYoIPJcZrsd08Ei0 GkKQ0jsGUYb79zGd89RtEy51ZvP3mrLXV0rpJaZufr96ryMJZwO/+zOp/2cTleGphjcs noi/4pu7DIdAMsT/gaDPoEtLJjWVoGQYEsoerz8FDHDfvHqyTQyVGctn/ihFLAGWNY7o 7Q/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Qo3D7s42GVK4s1uJPPwT10kRMvk6H0nQqpAKMFtYoq0=; fh=iogb7Qd7AqyHlpSVxJDWK37b53wM5j9GlZ66B7PI+LI=; b=bEgFtIZ7LsNxoGjXB5Wzq0ajw3n4qONVKYFuRSDxWh59rJ1uBwABWBAhNDW4nqCjLX cLIE9BgIp0uuX7R3Fa2J1GnQ1L8gEW9wBlhzubyz6gZLOQkDSQnaWGDopDkxEZRP50T9 ow0S/dW6RjlOV6bfVT3QMtlzWJzUMQta1iJnSL5vaMLe4JGCnwdJBUz+eeQ2xmfg7SlQ O4zBDefw7NlhEWUaZLPMRHd/gnP9ETEKxTB6xtl3C+JFxsokutsIN/5ELqbvegSrXzuR cheE9fr7y2wbGqdvgnNWkJrUkPDgUlgk4e5iFXBDLkPtK5iy8F+BdSGbA/nLDYzPjuSB QqWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Jb28IYZu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id z4-20020a63c044000000b005bd28c9bb23si1076924pgi.308.2023.11.23.02.48.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 02:48:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Jb28IYZu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 8D8BA8075DFD; Thu, 23 Nov 2023 02:48:35 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344831AbjKWKsN (ORCPT + 99 others); Thu, 23 Nov 2023 05:48:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344808AbjKWKsL (ORCPT ); Thu, 23 Nov 2023 05:48:11 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B86D1BE for ; Thu, 23 Nov 2023 02:48:17 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65959C433C9; Thu, 23 Nov 2023 10:48:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700736496; bh=XewRPhT99Y03FufuA1LV3jWgAM7RX4SOby0kMRaZJ00=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Jb28IYZuVzwcLrvrvdnukKAYmz06zPlRup1+ZlrHUkGDRNnKhK/LnDE6VdgbLpj+m 7nGH2w6Z1wEvV1o01yirEafTzIchxEfH4n2wh7+t8IoMcGHOFAP/SKIzyt37JchohU ib2t6BeZZQ86+vnPtZ+l1dn7dxrBqkZmLsRPiASWYcgVIFUmk5vGvqSqP1M1fKyprv WtPDeYK0T522Y3EVQc2uUKBE+AX0HUsdGJvTOEm3AvSFnWESX7NOSJgufEHOEpjU/O JVbzAaHZKimJUay/NoPr4L/SKxigHhRfZtozFHHOguviIMwsJd6aOJ0UukOcKdgPZy H1T4gcKWtWZTQ== From: Arnd Bergmann To: Michael Ellerman Cc: Arnd Bergmann , Nicholas Piggin , Christophe Leroy , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] powerpc: pasemi: mark pas_shutdown() static Date: Thu, 23 Nov 2023 11:48:00 +0100 Message-Id: <20231123104801.15537-3-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231123104801.15537-1-arnd@kernel.org> References: <20231123104801.15537-1-arnd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Thu, 23 Nov 2023 02:48:35 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783351500389443077 X-GMAIL-MSGID: 1783351500389443077 From: Arnd Bergmann Allmodconfig builds show a warning about one function that is accidentally marked global: arch/powerpc/platforms/pasemi/setup.c:67:6: error: no previous prototype for 'pas_shutdown' [-Werror=missing-prototypes] Fixes: 656fdf3ad8e0 ("powerpc/pasemi: Add Nemo board device init code.") Signed-off-by: Arnd Bergmann --- arch/powerpc/platforms/pasemi/setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/pasemi/setup.c b/arch/powerpc/platforms/pasemi/setup.c index ef985ba2bf21..0761d98e5be3 100644 --- a/arch/powerpc/platforms/pasemi/setup.c +++ b/arch/powerpc/platforms/pasemi/setup.c @@ -64,7 +64,7 @@ static void __noreturn pas_restart(char *cmd) } #ifdef CONFIG_PPC_PASEMI_NEMO -void pas_shutdown(void) +static void pas_shutdown(void) { /* Set the PLD bit that makes the SB600 think the power button is being pressed */ void __iomem *pld_map = ioremap(0xf5000000,4096); From patchwork Thu Nov 23 10:48:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 168866 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce62:0:b0:403:3b70:6f57 with SMTP id o2csp355880vqx; Thu, 23 Nov 2023 02:52:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IE/kHQyYDAf2I4vFNoSO6VjNg0cAVutivHb6d0+/rmwHZo7K3+PXp3zc1t7hP13E9xCwsxo X-Received: by 2002:a17:90b:4c4b:b0:280:c97:5968 with SMTP id np11-20020a17090b4c4b00b002800c975968mr5786956pjb.5.1700736742038; Thu, 23 Nov 2023 02:52:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700736742; cv=none; d=google.com; s=arc-20160816; b=Ky0jXsMW3RHHP1u7CGe+cWxr45cZCsvu5KWgTtiodhkqdEwOXPvcnUtWJqb3Zriql5 U2x1VdaKTeF802W9rbr5/O1ityDP7E3pYDUwqq/flvrzOYCSt4OdsIMD3P9U9vCKGxyl Fq+EWVC5Jk7P+vfdp2LJrg6CkwntfFEQDa5wHYUpokSYxoZS20ruuJY1Uv9iDt/37hiJ FhPShSXozAhtDNBuZce61X/U9XNybfwCNIkFcv0RnUEU9zzdILhLTJZcQnzUfOfZjo2U zpbvK2bF6MHJbuAoulbo0mS6e9jaqJORftgcfK4VWVfYqOmeetUexOVA4/NsPut4JRIa CSsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6v+k+45d0SnmDk4MnVlFxXeiUV2frHoUXNiAeIm3A4E=; fh=iogb7Qd7AqyHlpSVxJDWK37b53wM5j9GlZ66B7PI+LI=; b=lVcobIt5Psv/a/NM8FZHWY7QcF3chU+DcF87pkfO9Wm8z+kSn0RkLMd08cGsCtVXiX w1E121xkyeE9hCffzBr6Pltqx05KEJVh5HRGpuDIsXfEQLIhs2xtIN9ONinv5OcqGoDP 4ifxJhvyxGmRhPNE+Ji9yIhQcfBjclTLqvz0dpvQ74SotPBkbm5qSxLZZ+GFxPOv4AJ5 pP+UZ/AcVZKURXfk0Wqxu5X7j03nO/cJp5EKSF1HtK2mtDjrg+/lc0zgYi+D8QygUOVU tHRpKYyQhJhNrF5agpzDUnACWYpk8EnAtvzlKVexTOVkpCv2A6zld0+sDYWGBynZa7H4 UKug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="UF/smYE6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id cl14-20020a17090af68e00b00284cad3afaasi1110924pjb.34.2023.11.23.02.52.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 02:52:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="UF/smYE6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 43EC280779B0; Thu, 23 Nov 2023 02:48:30 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344895AbjKWKsS (ORCPT + 99 others); Thu, 23 Nov 2023 05:48:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344824AbjKWKsM (ORCPT ); Thu, 23 Nov 2023 05:48:12 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09CD5D4A for ; Thu, 23 Nov 2023 02:48:19 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 456EDC433C8; Thu, 23 Nov 2023 10:48:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700736498; bh=bnImJ/ObQ6B/nPGCBESa5sKS25GC8i0wwxIop7YcLiQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UF/smYE6w5t3Qu/JkXRjWHikWmWDZmaBN5EAC0TUMncJwqfZpU4hZRIOLkZvfaEB7 mm+xLV+CyHdSJjMBRUaiN3Xb26CVJGT5Rbc6Iqsf8EioYjGQdfjA3bQn2Llibv7KcB wxDRkP+Skv7hD8WFmKTzR4O17Zr5+T4R9K1U3GIyPxAE57goc21d5V7iNvRg/HK01R M5JBj2jvncyqmoXhXTq2ovGGOOL+zKKWz/kuGzcn0L5WXG9DPX2lzz6jK5UlZGnEGZ LB1pRNtB2JwMDzAG9D/hc/+Q+YR1ZZ9kF9JeBFGGZND7JWtJzZ6UycYqQGDJVw7Clc 8MCN4mafoiABw== From: Arnd Bergmann To: Michael Ellerman Cc: Arnd Bergmann , Nicholas Piggin , Christophe Leroy , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/3] powerpc: powermac: mark smp_psurge_{give,take}_timebase static Date: Thu, 23 Nov 2023 11:48:01 +0100 Message-Id: <20231123104801.15537-4-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231123104801.15537-1-arnd@kernel.org> References: <20231123104801.15537-1-arnd@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 23 Nov 2023 02:48:30 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783351730159947373 X-GMAIL-MSGID: 1783351730159947373 From: Arnd Bergmann These functions are only called locally and should be static like the other corresponding functions are: arch/powerpc/platforms/powermac/smp.c:416:13: error: no previous prototype for 'smp_psurge_take_timebase' [-Werror=missing-prototypes] 416 | void __init smp_psurge_take_timebase(void) | ^~~~~~~~~~~~~~~~~~~~~~~~ arch/powerpc/platforms/powermac/smp.c:432:13: error: no previous prototype for 'smp_psurge_give_timebase' [-Werror=missing-prototypes] 432 | void __init smp_psurge_give_timebase(void) | ^~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Arnd Bergmann --- arch/powerpc/platforms/powermac/smp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/powermac/smp.c b/arch/powerpc/platforms/powermac/smp.c index c83d1e14077e..15644be31990 100644 --- a/arch/powerpc/platforms/powermac/smp.c +++ b/arch/powerpc/platforms/powermac/smp.c @@ -413,7 +413,7 @@ static void __init smp_psurge_setup_cpu(int cpu_nr) printk(KERN_ERR "Couldn't get primary IPI interrupt"); } -void __init smp_psurge_take_timebase(void) +static void __init smp_psurge_take_timebase(void) { if (psurge_type != PSURGE_DUAL) return; @@ -429,7 +429,7 @@ void __init smp_psurge_take_timebase(void) set_dec(tb_ticks_per_jiffy/2); } -void __init smp_psurge_give_timebase(void) +static void __init smp_psurge_give_timebase(void) { /* Nothing to do here */ }