From patchwork Mon Nov 20 12:29:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Quentin Schulz X-Patchwork-Id: 167112 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9910:0:b0:403:3b70:6f57 with SMTP id i16csp2163227vqn; Mon, 20 Nov 2023 04:31:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IEmUWvmjThWWnl5tmN2fA2lHJDyyuNuxPQfdO+WtXJPF/+nc4jlXc8McwzS2LDg+eYNRDgu X-Received: by 2002:a05:6a00:2e99:b0:6b2:baa0:6d4c with SMTP id fd25-20020a056a002e9900b006b2baa06d4cmr6186602pfb.33.1700483498346; Mon, 20 Nov 2023 04:31:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700483498; cv=none; d=google.com; s=arc-20160816; b=MdEL7XStTsNdzZR3b3XntGH3ClwC3l1eiWDO18sf8q09//6y+2gB9mzKcFI6TNoskn nxAGKKtGvsDmEptDS8zMtdnpa5IvQ45fxiejtI/irsig48NuN2MdW/Zn64k9ermjvjnr TaB9NQT9waqvJnOsHZjwgeq0salbpySLpi0+6TXH4uB81LMnf3P770fVfXrmjwWutfCG cV8VA07JNrZ+DmEYph1lnLTxwVKJ0I4QFZxIh9SUFalduHTnL7U0YM5srQ2GIqz0Wg8d 6wsXmtm/Wd4PGft0V1C5MOCggTQwOUTTvnu87yQ0gnRH46K7APtu4mdmXPApXgo85iK3 Jxig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=EevClquVp+K+Xs6zLHPZTlqrFA7f/h/qtRHgwhMpzvI=; fh=61MsDxO2nlB28w/gDedjzWsFJxOlFE0AkoXm0k2ZWfg=; b=hNxJ2oYEPPGm4LPvteUo0QfuNC2fqDKdIrSGrkpFo+E27G34yIPoWKDuhRphRO/4w3 gqcIL0UyI5C7q/olbaN6QZR2LxuERdOk8j00/oevY+9qvvTbJywbvVGJdy6Z7iifhmP4 41ETynDwiRmqtQoPg1kpVB07UBSxwXOZkk7R/Sl8azOLj/FvDqPo/DHDJrEZBkqq3aI6 LZpbo0MfANNdr+317/aHegK45WxeeDrp7RVgIOUrH5zNVv3RTaJPnauxdcwn6O/pwpBx y2Et+LdNCRp6H1dRMaxblUOFxbHi9NcmtrcNFZZeRFO3TCuOQ99rTbNIhajJEGJr75SW 88iw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id by22-20020a056a02059600b005b8ed896e82si8668037pgb.503.2023.11.20.04.31.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 04:31:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 2CC33807750E; Mon, 20 Nov 2023 04:30:41 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232738AbjKTMaS (ORCPT + 27 others); Mon, 20 Nov 2023 07:30:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233478AbjKTMaP (ORCPT ); Mon, 20 Nov 2023 07:30:15 -0500 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC465F1 for ; Mon, 20 Nov 2023 04:30:11 -0800 (PST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 0143AFF813; Mon, 20 Nov 2023 12:30:08 +0000 (UTC) From: Quentin Schulz To: Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Mark Yao Cc: Quentin Schulz , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Fabio Estevam , Quentin Schulz Subject: [PATCH v2 1/2] drm/rockchip: lvds: do not overwrite error code Date: Mon, 20 Nov 2023 13:29:48 +0100 Message-ID: <20231120-rk-lvds-defer-msg-v2-1-9c59a5779cf9@theobroma-systems.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231120-rk-lvds-defer-msg-v2-0-9c59a5779cf9@theobroma-systems.com> References: <20231120-rk-lvds-defer-msg-v2-0-9c59a5779cf9@theobroma-systems.com> MIME-Version: 1.0 X-Mailer: b4 0.12.4 X-GND-Sasl: foss@0leil.net X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 20 Nov 2023 04:30:41 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783086184734992864 X-GMAIL-MSGID: 1783086184734992864 From: Quentin Schulz ret variable stores the return value of drm_of_find_panel_or_bridge which can return error codes different from EPROBE_DEFER. Therefore, let's just return that error code instead of forcing it to EPROBE_DEFER. Fixes: 34cc0aa25456 ("drm/rockchip: Add support for Rockchip Soc LVDS") Cc: Quentin Schulz Signed-off-by: Quentin Schulz --- drivers/gpu/drm/rockchip/rockchip_lvds.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm/rockchip/rockchip_lvds.c index f0f47e9abf5a..17d8fc797151 100644 --- a/drivers/gpu/drm/rockchip/rockchip_lvds.c +++ b/drivers/gpu/drm/rockchip/rockchip_lvds.c @@ -578,7 +578,6 @@ static int rockchip_lvds_bind(struct device *dev, struct device *master, goto err_put_port; } else if (ret) { DRM_DEV_ERROR(dev, "failed to find panel and bridge node\n"); - ret = -EPROBE_DEFER; goto err_put_port; } if (lvds->panel) From patchwork Mon Nov 20 12:29:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Quentin Schulz X-Patchwork-Id: 167113 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9910:0:b0:403:3b70:6f57 with SMTP id i16csp2163264vqn; Mon, 20 Nov 2023 04:31:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IEI19LqEXT9mwiL7ERZaog2JIlj9mnlsiud/fxFIfLd86tEG5mqxh1fWofa+Phs3SderBS4 X-Received: by 2002:a05:6a00:300c:b0:6cb:913d:2cc6 with SMTP id ay12-20020a056a00300c00b006cb913d2cc6mr4976025pfb.15.1700483501332; Mon, 20 Nov 2023 04:31:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700483501; cv=none; d=google.com; s=arc-20160816; b=HHmMdl2k2NgRlXoIfLTpAXom+9ve2iGmHkss4Dc/oC3cd8mhW7GpkB1nRcYQSI7abb xamTEoXi2PH/JjJVd+GuSkgJrkbkJRuRMzScRdPRcnJX6RzQIy8iQY/Iu4K4qbp4L44b DytCla6Jy+RUZM/F14MSJL9fmNVIh7k5eK4F2f1bGiHNrN2gHGREt3suoCcGzYREMPMX ln/6eEddtsTYIafFsv5c/Gztdn3VmTUC8mADAlehziTy32Ikn7fIvllDjfXrc2DC4DHT aa8vMy/SJhdtZdptquiTbwy4yq8Az2WpjRcEMC7kh+KL0HOL3uep0CrF+dnL30KibgGb M43A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=iNGfZQBE4CMogyghdvmv53OkFQEjwglupw333f2vUEU=; fh=61MsDxO2nlB28w/gDedjzWsFJxOlFE0AkoXm0k2ZWfg=; b=b0WQfm326YpSGmh1l0ZAmRF/oXZnPysVGTgBjOVv7RETkrA+c9uHC/TalbhAqQTYO0 6GKqMQ7PaiLMC6lSElWJOyaexEJmMDqWuBHUvPtxqENR6Nw75xWqows3H0jRypNIJj0I /nHQ8IvytuNcdvqBh9UjmfLtJZWp3znQEvYdpnJfH66FWo0BplsGUHt+Iz4JJlLERLnN Hu0vFrcLpg5jGbfNZyJGcOvl2nv5muSmqM5YmlLR3HBKUTQMovegvh9IiYUjSMnZs2t1 qYl+PSJvvCZA+20LUON0jhV4tUHvJQlPGTfowwHbq/7LqvDlDDo5hVf8WRwFQqd6AgPh J+Vw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id c14-20020a63da0e000000b005bdd6196f4asi7889945pgh.392.2023.11.20.04.31.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 04:31:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 93CB8806716F; Mon, 20 Nov 2023 04:30:47 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233653AbjKTMaV convert rfc822-to-8bit (ORCPT + 27 others); Mon, 20 Nov 2023 07:30:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233644AbjKTMaR (ORCPT ); Mon, 20 Nov 2023 07:30:17 -0500 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84345F2 for ; Mon, 20 Nov 2023 04:30:13 -0800 (PST) Received: by mail.gandi.net (Postfix) with ESMTPSA id ACC3CFF811; Mon, 20 Nov 2023 12:30:10 +0000 (UTC) From: Quentin Schulz To: Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Mark Yao Cc: Quentin Schulz , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Fabio Estevam , Quentin Schulz Subject: [PATCH v2 2/2] drm/rockchip: lvds: do not print scary message when probing defer Date: Mon, 20 Nov 2023 13:29:49 +0100 Message-ID: <20231120-rk-lvds-defer-msg-v2-2-9c59a5779cf9@theobroma-systems.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231120-rk-lvds-defer-msg-v2-0-9c59a5779cf9@theobroma-systems.com> References: <20231120-rk-lvds-defer-msg-v2-0-9c59a5779cf9@theobroma-systems.com> MIME-Version: 1.0 X-Mailer: b4 0.12.4 X-GND-Sasl: foss@0leil.net X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 20 Nov 2023 04:30:47 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1783086187983081611 X-GMAIL-MSGID: 1783086187983081611 From: Quentin Schulz This scary message can misled the user into thinking something bad has happened and needs to be fixed, however it could simply be part of a normal boot process where EPROBE_DEFER is taken into account. Therefore, let's use dev_err_probe so that this message doesn't get shown (by default) when the return code is EPROBE_DEFER. Fixes: 34cc0aa25456 ("drm/rockchip: Add support for Rockchip Soc LVDS") Cc: Quentin Schulz Signed-off-by: Quentin Schulz --- drivers/gpu/drm/rockchip/rockchip_lvds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm/rockchip/rockchip_lvds.c index 17d8fc797151..f2831d304e7b 100644 --- a/drivers/gpu/drm/rockchip/rockchip_lvds.c +++ b/drivers/gpu/drm/rockchip/rockchip_lvds.c @@ -577,7 +577,7 @@ static int rockchip_lvds_bind(struct device *dev, struct device *master, ret = -EINVAL; goto err_put_port; } else if (ret) { - DRM_DEV_ERROR(dev, "failed to find panel and bridge node\n"); + dev_err_probe(dev, ret, "failed to find panel and bridge node\n"); goto err_put_port; } if (lvds->panel)